chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts

@@ -32,13 +32,13 @@ export interface Config {
 export class ChartViewport extends UI.Widget.VBox {
   private readonly delegate: ChartViewportDelegate;
   viewportElement: HTMLElement;
-  private alwaysShowVerticalScrollInternal: boolean;
+  #alwaysShowVerticalScroll: boolean;
   private rangeSelectionEnabled: boolean;
   private vScrollElement: HTMLElement;
   private vScrollContent: HTMLElement;
   private readonly selectionOverlay: HTMLElement;
   private cursorElement: HTMLElement;
-  private isDraggingInternal!: boolean;
+  #isDragging!: boolean;
   private totalHeight!: number;
   private offsetHeight!: number;
   private scrollTop!: number;
@@ -83,7 +83,7 @@ export class ChartViewport extends UI.Widget.VBox {
         this.viewportElement, this.startRangeSelection.bind(this), this.rangeSelectionDragging.bind(this),
         this.endRangeSelection.bind(this), 'text', null);
 
-    this.alwaysShowVerticalScrollInternal = false;
+    this.#alwaysShowVerticalScroll = false;
     this.rangeSelectionEnabled = true;
     this.vScrollElement = this.contentElement.createChild('div', 'chart-viewport-v-scroll');
     this.vScrollContent = this.vScrollElement.createChild('div');
@@ -99,7 +99,7 @@ export class ChartViewport extends UI.Widget.VBox {
   }
 
   alwaysShowVerticalScroll(): void {
-    this.alwaysShowVerticalScrollInternal = true;
+    this.#alwaysShowVerticalScroll = true;
     this.vScrollElement.classList.add('always-show-scrollbar');
   }
 
@@ -110,7 +110,7 @@ export class ChartViewport extends UI.Widget.VBox {
   }
 
   isDragging(): boolean {
-    return this.isDraggingInternal;
+    return this.#isDragging;
   }
 
   override elementsToRestoreScrollPositionsFor(): Element[] {
@@ -122,7 +122,7 @@ export class ChartViewport extends UI.Widget.VBox {
   }
 
   private updateScrollBar(): void {
-    const showScroll = this.alwaysShowVerticalScrollInternal || this.totalHeight > this.offsetHeight;
+    const showScroll = this.#alwaysShowVerticalScroll || this.totalHeight > this.offsetHeight;
     if (this.vScrollElement.classList.contains('hidden') !== showScroll) {
       return;
     }
@@ -141,7 +141,7 @@ export class ChartViewport extends UI.Widget.VBox {
     this.scrollTop = 0;
     this.rangeSelectionStart = null;
     this.rangeSelectionEnd = null;
-    this.isDraggingInternal = false;
+    this.#isDragging = false;
     this.dragStartPointX = 0;
     this.dragStartPointY = 0;
     this.dragStartScrollTop = 0;
@@ -270,7 +270,7 @@ export class ChartViewport extends UI.Widget.VBox {
     if (event.shiftKey) {
       return false;
     }
-    this.isDraggingInternal = true;
+    this.#isDragging = true;
     this.dragStartPointX = event.pageX;
     this.dragStartPointY = event.pageY;
     this.dragStartScrollTop = this.vScrollElement.scrollTop;
@@ -287,21 +287,21 @@ export class ChartViewport extends UI.Widget.VBox {
   }
 
   private endDragging(): void {
-    this.isDraggingInternal = false;
+    this.#isDragging = false;
   }
 
   private startRangeSelection(event: MouseEvent): boolean {
     if (!event.shiftKey || !this.rangeSelectionEnabled) {
       return false;
     }
-    this.isDraggingInternal = true;
+    this.#isDragging = true;
     this.selectionOffsetShiftX = event.offsetX - event.pageX;
     this.selectionStartX = event.offsetX;
     return true;
   }
 
   private endRangeSelection(): void {
-    this.isDraggingInternal = false;
+    this.#isDragging = false;
     this.selectionStartX = null;
   }
 
@@ -380,7 +380,7 @@ export class ChartViewport extends UI.Widget.VBox {
   }
 
   private showCursor(visible: boolean): void {
-    this.cursorElement.classList.toggle('hidden', !visible || this.isDraggingInternal);
+    this.cursorElement.classList.toggle('hidden', !visible || this.#isDragging);
   }
 
   private onChartKeyDown(keyboardEvent: KeyboardEvent): void {

package/front_end/ui/legacy/components/perf_ui/FlameChart.ts

@@ -301,7 +301,7 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
   private dragStartX!: number;
   private dragStartY!: number;
   private lastMouseOffsetY!: number;
-  private minimumBoundaryInternal!: number;
+  #minimumBoundary!: number;
   private maxDragOffset!: number;
   private timelineLevels?: number[][]|null;
   private visibleLevelOffsets?: Uint32Array|null;
@@ -4023,8 +4023,8 @@ export class FlameChart extends Common.ObjectWrapper.eventMixin<EventTypes, type
 
   private updateBoundaries(): void {
     this.totalTime = this.dataProvider.totalTime();
-    this.minimumBoundaryInternal = this.dataProvider.minimumBoundary();
-    this.chartViewport.setBoundaries(this.minimumBoundaryInternal, this.totalTime);
+    this.#minimumBoundary = this.dataProvider.minimumBoundary();
+    this.chartViewport.setBoundaries(this.#minimumBoundary, this.totalTime);
   }
 
   private updateHeight(): void {

package/front_end/ui/legacy/components/perf_ui/TimelineGrid.ts

@@ -44,21 +44,21 @@ const labelMap = new Map<HTMLDivElement|HTMLElement, HTMLDivElement>();
 
 export class TimelineGrid {
   element: HTMLDivElement;
-  private readonly dividersElementInternal: HTMLElement;
+  readonly #dividersElement: HTMLElement;
   private readonly gridHeaderElement: HTMLDivElement;
   private eventDividersElement: HTMLElement;
-  private dividersLabelBarElementInternal: HTMLElement;
+  #dividersLabelBarElement: HTMLElement;
 
   constructor() {
     this.element = document.createElement('div');
     Platform.DOMUtilities.appendStyle(this.element, timelineGridStyles);
 
-    this.dividersElementInternal = this.element.createChild('div', 'resources-dividers');
+    this.#dividersElement = this.element.createChild('div', 'resources-dividers');
 
     this.gridHeaderElement = document.createElement('div');
     this.gridHeaderElement.classList.add('timeline-grid-header');
     this.eventDividersElement = this.gridHeaderElement.createChild('div', 'resources-event-dividers');
-    this.dividersLabelBarElementInternal = this.gridHeaderElement.createChild('div', 'resources-dividers-label-bar');
+    this.#dividersLabelBarElement = this.gridHeaderElement.createChild('div', 'resources-dividers-label-bar');
     this.element.appendChild(this.gridHeaderElement);
   }
 
@@ -160,11 +160,11 @@ export class TimelineGrid {
   }
 
   get dividersElement(): HTMLElement {
-    return this.dividersElementInternal;
+    return this.#dividersElement;
   }
 
   get dividersLabelBarElement(): HTMLElement {
-    return this.dividersLabelBarElementInternal;
+    return this.#dividersLabelBarElement;
   }
 
   updateDividers(calculator: NetworkTimeCalculator.Calculator, freeZoneAtLeft?: number): boolean {
@@ -172,17 +172,17 @@ export class TimelineGrid {
     const dividerOffsets = dividersData.offsets;
     const precision = dividersData.precision;
 
-    const dividersElementClientWidth = this.dividersElementInternal.clientWidth;
+    const dividersElementClientWidth = this.#dividersElement.clientWidth;
 
     // Reuse divider elements and labels.
-    let divider = (this.dividersElementInternal.firstChild as HTMLElement | null);
-    let dividerLabelBar = (this.dividersLabelBarElementInternal.firstChild as HTMLElement | null);
+    let divider = (this.#dividersElement.firstChild as HTMLElement | null);
+    let dividerLabelBar = (this.#dividersLabelBarElement.firstChild as HTMLElement | null);
 
     for (let i = 0; i < dividerOffsets.length; ++i) {
       if (!divider) {
         divider = document.createElement('div');
         divider.className = 'resources-divider';
-        this.dividersElementInternal.appendChild(divider);
+        this.#dividersElement.appendChild(divider);
 
         dividerLabelBar = document.createElement('div');
         dividerLabelBar.className = 'resources-divider';
@@ -190,7 +190,7 @@ export class TimelineGrid {
         label.className = 'resources-divider-label';
         labelMap.set(dividerLabelBar, label);
         dividerLabelBar.appendChild(label);
-        this.dividersLabelBarElementInternal.appendChild(dividerLabelBar);
+        this.#dividersLabelBarElement.appendChild(dividerLabelBar);
       }
 
       const time = dividerOffsets[i].time;
@@ -216,7 +216,7 @@ export class TimelineGrid {
     // Remove extras.
     while (divider) {
       const nextDivider = divider.nextSibling;
-      this.dividersElementInternal.removeChild(divider);
+      this.#dividersElement.removeChild(divider);
       if (nextDivider) {
         divider = (nextDivider as HTMLElement);
       } else {
@@ -225,7 +225,7 @@ export class TimelineGrid {
     }
     while (dividerLabelBar) {
       const nextDivider = dividerLabelBar.nextSibling;
-      this.dividersLabelBarElementInternal.removeChild(dividerLabelBar);
+      this.#dividersLabelBarElement.removeChild(dividerLabelBar);
       if (nextDivider) {
         dividerLabelBar = (nextDivider as HTMLElement);
       } else {
@@ -256,7 +256,7 @@ export class TimelineGrid {
   }
 
   setScrollTop(scrollTop: number): void {
-    this.dividersLabelBarElementInternal.style.top = scrollTop + 'px';
+    this.#dividersLabelBarElement.style.top = scrollTop + 'px';
     this.eventDividersElement.style.top = scrollTop + 'px';
   }
 }

package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts

@@ -492,15 +492,15 @@ export interface TimelineOverview {
 }
 
 export class TimelineOverviewBase extends UI.Widget.VBox implements TimelineOverview {
-  private calculatorInternal: TimelineOverviewCalculator|null;
+  #calculator: TimelineOverviewCalculator|null;
   private canvas: HTMLCanvasElement;
-  private contextInternal: CanvasRenderingContext2D|null;
+  #context: CanvasRenderingContext2D|null;
 
   constructor() {
     super();
-    this.calculatorInternal = null;
+    this.#calculator = null;
     this.canvas = this.element.createChild('canvas', 'fill');
-    this.contextInternal = this.canvas.getContext('2d');
+    this.#context = this.canvas.getContext('2d');
   }
 
   width(): number {
@@ -512,14 +512,14 @@ export class TimelineOverviewBase extends UI.Widget.VBox implements TimelineOver
   }
 
   context(): CanvasRenderingContext2D {
-    if (!this.contextInternal) {
+    if (!this.#context) {
       throw new Error('Unable to retrieve canvas context');
     }
-    return this.contextInternal;
+    return this.#context;
   }
 
   calculator(): TimelineOverviewCalculator|null {
-    return this.calculatorInternal;
+    return this.#calculator;
   }
 
   update(): void {
@@ -538,7 +538,7 @@ export class TimelineOverviewBase extends UI.Widget.VBox implements TimelineOver
   }
 
   setCalculator(calculator: TimelineOverviewCalculator): void {
-    this.calculatorInternal = calculator;
+    this.#calculator = calculator;
   }
 
   onClick(_event: Event): boolean {

package/front_end/ui/legacy/components/quick_open/CommandMenu.ts

@@ -45,9 +45,9 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 let commandMenuInstance: CommandMenu;
 
 export class CommandMenu {
-  private readonly commandsInternal: Command[];
+  readonly #commands: Command[];
   private constructor() {
-    this.commandsInternal = [];
+    this.#commands = [];
     this.loadCommands();
   }
 
@@ -216,7 +216,7 @@ export class CommandMenu {
         id: view.viewId(),
         featurePromotionId: view.featurePromotionId(),
       };
-      this.commandsInternal.push(CommandMenu.createRevealViewCommand(options));
+      this.#commands.push(CommandMenu.createRevealViewCommand(options));
     }
     // Populate allowlisted settings.
     const settingsRegistrations = Common.Settings.Settings.instance().getRegisteredSettings();
@@ -227,13 +227,13 @@ export class CommandMenu {
       }
       for (const pair of options) {
         const setting = Common.Settings.Settings.instance().moduleSetting(settingRegistration.settingName);
-        this.commandsInternal.push(CommandMenu.createSettingCommand(setting, pair.title(), pair.value));
+        this.#commands.push(CommandMenu.createSettingCommand(setting, pair.title(), pair.value));
       }
     }
   }
 
   commands(): Command[] {
-    return this.commandsInternal;
+    return this.#commands;
   }
 }
 export interface ActionCommandOptions {

package/front_end/ui/legacy/components/source_frame/ResourceSourceFrame.ts

@@ -53,7 +53,7 @@ const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/source_frame/Reso
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class ResourceSourceFrame extends SourceFrameImpl {
-  private readonly resourceInternal: TextUtils.ContentProvider.ContentProvider;
+  readonly #resource: TextUtils.ContentProvider.ContentProvider;
   readonly #givenContentType: string;
 
   constructor(
@@ -66,7 +66,7 @@ export class ResourceSourceFrame extends SourceFrameImpl {
     super(lazyContent, options);
 
     this.#givenContentType = givenContentType;
-    this.resourceInternal = resource;
+    this.#resource = resource;
     if (isStreamingProvider) {
       void resource.requestStreamingContent().then(streamingContent => {
         if (!TextUtils.StreamingContentData.isError(streamingContent)) {
@@ -88,13 +88,13 @@ export class ResourceSourceFrame extends SourceFrameImpl {
   }
 
   get resource(): TextUtils.ContentProvider.ContentProvider {
-    return this.resourceInternal;
+    return this.#resource;
   }
 
   protected override populateTextAreaContextMenu(
       contextMenu: UI.ContextMenu.ContextMenu, lineNumber: number, columnNumber: number): void {
     super.populateTextAreaContextMenu(contextMenu, lineNumber, columnNumber);
-    contextMenu.appendApplicableItems(this.resourceInternal);
+    contextMenu.appendApplicableItems(this.#resource);
   }
 }
 

package/front_end/ui/legacy/theme_support/ThemeSupport.ts

@@ -43,7 +43,7 @@ let themeSupportInstance: ThemeSupport;
 const themeValueByTargetByName = new Map<Element|null, Map<string, string>>();
 
 export class ThemeSupport extends EventTarget {
-  private themeNameInternal = 'default';
+  #themeName = 'default';
   private computedStyleOfHTML = Common.Lazy.lazy(() => window.getComputedStyle(document.documentElement));
 
   readonly #documentsToTheme = new Set<Document>([document]);
@@ -142,7 +142,7 @@ export class ThemeSupport extends EventTarget {
   }
 
   themeName(): string {
-    return this.themeNameInternal;
+    return this.#themeName;
   }
 
   #applyTheme(): void {
@@ -156,8 +156,8 @@ export class ThemeSupport extends EventTarget {
     const systemPreferredTheme = window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'default';
 
     const useSystemPreferred = this.setting.get() === 'systemPreferred' || isForcedColorsMode;
-    this.themeNameInternal = useSystemPreferred ? systemPreferredTheme : this.setting.get();
-    document.documentElement.classList.toggle('theme-with-dark-background', this.themeNameInternal === 'dark');
+    this.#themeName = useSystemPreferred ? systemPreferredTheme : this.setting.get();
+    document.documentElement.classList.toggle('theme-with-dark-background', this.#themeName === 'dark');
 
     const useChromeTheme = Common.Settings.moduleSetting('chrome-theme-colors').get();
     const isIncognito = Root.Runtime.hostConfig.isOffTheRecord === true;

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -1793,7 +1793,6 @@ export const knownContextValues = new Set([
   'hide-network-messages-true',
   'hide-player',
   'hide-repeating-children',
-  'highlight-errors-elements-panel',
   'highlight-node-on-hover-in-overlay',
   'history',
   'historyRedo',
@@ -2732,6 +2731,7 @@ export const knownContextValues = new Set([
   'override-content',
   'override-headers',
   'override-source-mapped-file-warning',
+  'overscroll-anchor-name',
   'overscroll-behavior',
   'overscroll-behavior-block',
   'overscroll-behavior-inline',
@@ -3786,6 +3786,7 @@ export const knownContextValues = new Set([
   'timeline.ignore-list-new-regex.text',
   'timeline.ignore-list-pattern',
   'timeline.ignore-list-pattern.remove',
+  'timeline.insight-ask-ai.cache',
   'timeline.insight-ask-ai.cls-culprits',
   'timeline.insight-ask-ai.dismiss-field-mismatch',
   'timeline.insight-ask-ai.document-latency',
@@ -3801,7 +3802,6 @@ export const knownContextValues = new Set([
   'timeline.insight-ask-ai.legacy-javascript',
   'timeline.insight-ask-ai.long-critical-network-tree',
   'timeline.insight-ask-ai.modern-http',
-  'timeline.insight-ask-ai.network-dependency-tree',
   'timeline.insight-ask-ai.render-blocking-requests',
   'timeline.insight-ask-ai.slow-css-selector',
   'timeline.insight-ask-ai.third-parties',

package/package.json

@@ -102,5 +102,5 @@
       "@eslint/core": "0.15.1"
     }
   },
-  "version": "1.0.1512349"
+  "version": "1.0.1513662"
 }