chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/front_end/panels/timeline/TracingLayerTree.ts

@@ -149,61 +149,61 @@ export class TracingFrameLayerTree {
 
 export class TracingLayer implements SDK.LayerTreeBase.Layer {
   private parentLayerId: string|null;
-  private parentInternal: SDK.LayerTreeBase.Layer|null;
+  parentInternal: SDK.LayerTreeBase.Layer|null;
   private layerId: string;
-  private nodeInternal: SDK.DOMModel.DOMNode|null;
-  private offsetXInternal: number;
-  private offsetYInternal: number;
-  private widthInternal: number;
-  private heightInternal: number;
-  private childrenInternal: SDK.LayerTreeBase.Layer[];
-  private quadInternal: number[];
-  private scrollRectsInternal: Protocol.LayerTree.ScrollRect[];
-  private gpuMemoryUsageInternal: number;
+  #node: SDK.DOMModel.DOMNode|null;
+  #offsetX: number;
+  #offsetY: number;
+  #width: number;
+  #height: number;
+  #children: SDK.LayerTreeBase.Layer[];
+  #quad: number[];
+  #scrollRects: Protocol.LayerTree.ScrollRect[];
+  #gpuMemoryUsage: number;
   private paints: Trace.Types.Events.LegacyLayerPaintEvent[];
   private compositingReasons: string[];
   private compositingReasonIds: string[];
-  private drawsContentInternal: boolean;
+  #drawsContent: boolean;
   private paintProfilerModel: SDK.PaintProfiler.PaintProfilerModel|null;
   constructor(paintProfilerModel: SDK.PaintProfiler.PaintProfilerModel|null, payload: TracingLayerPayload) {
     this.parentLayerId = null;
     this.parentInternal = null;
     this.layerId = '';
-    this.nodeInternal = null;
-    this.offsetXInternal = -1;
-    this.offsetYInternal = -1;
-    this.widthInternal = -1;
-    this.heightInternal = -1;
-    this.childrenInternal = [];
-    this.quadInternal = [];
-    this.scrollRectsInternal = [];
-    this.gpuMemoryUsageInternal = -1;
+    this.#node = null;
+    this.#offsetX = -1;
+    this.#offsetY = -1;
+    this.#width = -1;
+    this.#height = -1;
+    this.#children = [];
+    this.#quad = [];
+    this.#scrollRects = [];
+    this.#gpuMemoryUsage = -1;
     this.paints = [];
     this.compositingReasons = [];
     this.compositingReasonIds = [];
-    this.drawsContentInternal = false;
+    this.#drawsContent = false;
 
     this.paintProfilerModel = paintProfilerModel;
     this.reset(payload);
   }
 
   reset(payload: TracingLayerPayload): void {
-    this.nodeInternal = null;
+    this.#node = null;
     this.layerId = String(payload.layer_id);
-    this.offsetXInternal = payload.position[0];
-    this.offsetYInternal = payload.position[1];
-    this.widthInternal = payload.bounds.width;
-    this.heightInternal = payload.bounds.height;
-    this.childrenInternal = [];
+    this.#offsetX = payload.position[0];
+    this.#offsetY = payload.position[1];
+    this.#width = payload.bounds.width;
+    this.#height = payload.bounds.height;
+    this.#children = [];
     this.parentLayerId = null;
     this.parentInternal = null;
-    this.quadInternal = payload.layer_quad || [];
+    this.#quad = payload.layer_quad || [];
     this.createScrollRects(payload);
 
     this.compositingReasons = payload.compositing_reasons || [];
     this.compositingReasonIds = payload.compositing_reason_ids || [];
-    this.drawsContentInternal = Boolean(payload.draws_content);
-    this.gpuMemoryUsageInternal = payload.gpu_memory_usage;
+    this.#drawsContent = Boolean(payload.draws_content);
+    this.#gpuMemoryUsage = payload.gpu_memory_usage;
     this.paints = [];
   }
 
@@ -224,7 +224,7 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
   }
 
   children(): SDK.LayerTreeBase.Layer[] {
-    return this.childrenInternal;
+    return this.#children;
   }
 
   addChild(childParam: SDK.LayerTreeBase.Layer): void {
@@ -232,17 +232,17 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
     if (child.parentInternal) {
       console.assert(false, 'Child already has a parent');
     }
-    this.childrenInternal.push(child);
+    this.#children.push(child);
     child.parentInternal = this;
     child.parentLayerId = this.layerId;
   }
 
   setNode(node: SDK.DOMModel.DOMNode|null): void {
-    this.nodeInternal = node;
+    this.#node = node;
   }
 
   node(): SDK.DOMModel.DOMNode|null {
-    return this.nodeInternal;
+    return this.#node;
   }
 
   nodeForSelfOrAncestor(): SDK.DOMModel.DOMNode|null {
@@ -256,19 +256,19 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
   }
 
   offsetX(): number {
-    return this.offsetXInternal;
+    return this.#offsetX;
   }
 
   offsetY(): number {
-    return this.offsetYInternal;
+    return this.#offsetY;
   }
 
   width(): number {
-    return this.widthInternal;
+    return this.#width;
   }
 
   height(): number {
-    return this.heightInternal;
+    return this.#height;
   }
 
   transform(): number[]|null {
@@ -276,7 +276,7 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
   }
 
   quad(): number[] {
-    return this.quadInternal;
+    return this.#quad;
   }
 
   anchorPoint(): number[] {
@@ -296,7 +296,7 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
   }
 
   scrollRects(): Protocol.LayerTree.ScrollRect[] {
-    return this.scrollRectsInternal;
+    return this.#scrollRects;
   }
 
   stickyPositionConstraint(): SDK.LayerTreeBase.StickyPositionConstraint|null {
@@ -305,7 +305,7 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
   }
 
   gpuMemoryUsage(): number {
-    return this.gpuMemoryUsageInternal;
+    return this.#gpuMemoryUsage;
   }
 
   snapshots(): Array<Promise<SDK.PaintProfiler.SnapshotWithRect|null>> {
@@ -385,7 +385,7 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
     // SDK.LayerBaseTree.Layer.ScrollRectType and Protocol.LayerTree.ScrollRectType are the
     // same type, but we need to use the indirection of the nonPayloadScrollRects since
     // the ScrollRectType is defined as a string in SDK.LayerBaseTree.Layer.ScrollRectType.
-    this.scrollRectsInternal = nonPayloadScrollRects;
+    this.#scrollRects = nonPayloadScrollRects;
   }
 
   addPaintEvent(paint: Trace.Types.Events.LegacyLayerPaintEvent): void {
@@ -401,7 +401,7 @@ export class TracingLayer implements SDK.LayerTreeBase.Layer {
   }
 
   drawsContent(): boolean {
-    return this.drawsContentInternal;
+    return this.#drawsContent;
   }
 }
 

package/front_end/panels/timeline/TrackConfigBanner.ts

@@ -35,12 +35,12 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
  * is no entry for a trace in this map it is assumed to be a new trace and the
  * banner will be shown if the user has any hidden track config.
  */
-const hiddenTracksInfoBarPerTrace = new WeakMap<Trace.Handlers.Types.ParsedTrace, UI.Infobar.Infobar|'DISMISSED'>();
+const hiddenTracksInfoBarByParsedTrace = new WeakMap<Trace.TraceModel.ParsedTrace, UI.Infobar.Infobar|'DISMISSED'>();
 
 /**
  * Creates an overlay for the timeline that will show a banner informing the user that at least one track is hidden.
  *
- * @param trace The trace parsed data.
+ * @param parsedTrace The trace parsed data.
  * @param callbacks An object containing the callback functions to be executed
  * when the user interacts with the banner.
  *   - `onShowAllTracks`: called when the user clicks the "Unhide all" button.
@@ -49,12 +49,12 @@ const hiddenTracksInfoBarPerTrace = new WeakMap<Trace.Handlers.Types.ParsedTrace
  * @returns A `Trace.Types.Overlays.Overlay` object to be rendered, or `null` if
  * no banner should be shown (because the user has already seen the banner)
  */
-export function createHiddenTracksOverlay(trace: Trace.Handlers.Types.ParsedTrace, callbacks: {
+export function createHiddenTracksOverlay(parsedTrace: Trace.TraceModel.ParsedTrace, callbacks: {
   onShowAllTracks: () => void,
   onShowTrackConfigurationMode: () => void,
   onClose: () => void,
 }): Trace.Types.Overlays.BottomInfoBar|null {
-  const status = hiddenTracksInfoBarPerTrace.get(trace);
+  const status = hiddenTracksInfoBarByParsedTrace.get(parsedTrace);
   if (status === 'DISMISSED') {
     // The user has already seen the banner + dismissed it for this trace, so
     // we don't need to do anything.
@@ -89,9 +89,9 @@ export function createHiddenTracksOverlay(trace: Trace.Handlers.Types.ParsedTrac
   );
   infobarForTrace.setCloseCallback(() => {
     callbacks.onClose();
-    hiddenTracksInfoBarPerTrace.set(trace, 'DISMISSED');
+    hiddenTracksInfoBarByParsedTrace.set(parsedTrace, 'DISMISSED');
   });
 
-  hiddenTracksInfoBarPerTrace.set(trace, infobarForTrace);
+  hiddenTracksInfoBarByParsedTrace.set(parsedTrace, infobarForTrace);
   return {type: 'BOTTOM_INFO_BAR', infobar: infobarForTrace};
 }

package/front_end/panels/timeline/TrackConfiguration.ts

@@ -39,6 +39,6 @@ export function buildPersistedConfig(groups: readonly PerfUI.FlameChart.Group[],
  * trace with the exact same start time is very unlikely.
  * It's not impossible, but unlikely enough that we think the min trace bounds time is a good enough value to use as a uuid.
  */
-export function keyForTraceConfig(trace: Trace.Handlers.Types.ParsedTrace): Trace.Types.Timing.Micro {
+export function keyForTraceConfig(trace: Trace.Handlers.Types.HandlerData): Trace.Types.Timing.Micro {
   return trace.Meta.traceBounds.min;
 }

package/front_end/panels/timeline/components/DetailsView.ts

@@ -72,8 +72,8 @@ const str_ = i18n.i18n.registerUIStrings('panels/timeline/components/DetailsView
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export function buildWarningElementsForEvent(
-    event: Trace.Types.Events.Event, parsedTrace: Trace.Handlers.Types.ParsedTrace): HTMLSpanElement[] {
-  const warnings = parsedTrace.Warnings.perEvent.get(event);
+    event: Trace.Types.Events.Event, parsedTrace: Trace.TraceModel.ParsedTrace): HTMLSpanElement[] {
+  const warnings = parsedTrace.data.Warnings.perEvent.get(event);
   const warningElements: HTMLSpanElement[] = [];
   if (!warnings) {
     return warningElements;
@@ -130,10 +130,10 @@ export interface DetailRow {
 }
 export function buildRowsForWebSocketEvent(
     event: Trace.Types.Events.WebSocketCreate|Trace.Types.Events.WebSocketInfo|Trace.Types.Events.WebSocketTransfer,
-    parsedTrace: Trace.Handlers.Types.ParsedTrace): readonly DetailRow[] {
+    parsedTrace: Trace.TraceModel.ParsedTrace): readonly DetailRow[] {
   const rows: DetailRow[] = [];
 
-  const initiator = parsedTrace.Initiators.eventToInitiator.get(event);
+  const initiator = parsedTrace.data.Initiators.eventToInitiator.get(event);
   if (initiator && Trace.Types.Events.isWebSocketCreate(initiator)) {
     // The initiator will be a WebSocketCreate, but this check helps TypeScript to understand.
     rows.push({key: i18n.i18n.lockedString('URL'), value: initiator.args.data.url});

package/front_end/panels/timeline/components/LayoutShiftDetails.ts

@@ -83,8 +83,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export interface ViewInput {
   event: Trace.Types.Events.SyntheticLayoutShift|Trace.Types.Events.SyntheticLayoutShiftCluster|null;
-  traceInsightsSets: Trace.Insights.Types.TraceInsightSets|null;
-  parsedTrace: Trace.Handlers.Types.ParsedTrace|null;
+  parsedTrace: Trace.TraceModel.ParsedTrace|null;
   isFreshRecording: boolean;
   togglePopover: (e: MouseEvent) => void;
   onEventClick: (event: Trace.Types.Events.Event) => void;
@@ -93,8 +92,7 @@ export interface ViewInput {
 export class LayoutShiftDetails extends UI.Widget.Widget {
   #view: typeof DEFAULT_VIEW;
   #event: Trace.Types.Events.SyntheticLayoutShift|Trace.Types.Events.SyntheticLayoutShiftCluster|null = null;
-  #traceInsightsSets: Trace.Insights.Types.TraceInsightSets|null = null;
-  #parsedTrace: Trace.Handlers.Types.ParsedTrace|null = null;
+  #parsedTrace: Trace.TraceModel.ParsedTrace|null = null;
   #isFreshRecording = false;
 
   constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
@@ -107,12 +105,7 @@ export class LayoutShiftDetails extends UI.Widget.Widget {
     void this.requestUpdate();
   }
 
-  set traceInsightsSets(traceInsightsSets: Trace.Insights.Types.TraceInsightSets|null) {
-    this.#traceInsightsSets = traceInsightsSets;
-    void this.requestUpdate();
-  }
-
-  set parsedTrace(parsedTrace: Trace.Handlers.Types.ParsedTrace|null) {
+  set parsedTrace(parsedTrace: Trace.TraceModel.ParsedTrace|null) {
     this.#parsedTrace = parsedTrace;
     void this.requestUpdate();
   }
@@ -154,7 +147,6 @@ export class LayoutShiftDetails extends UI.Widget.Widget {
     this.#view(
         {
           event: this.#event,
-          traceInsightsSets: this.#traceInsightsSets,
           parsedTrace: this.#parsedTrace,
           isFreshRecording: this.#isFreshRecording,
           togglePopover: e => this.#togglePopover(e),
@@ -189,9 +181,9 @@ export const DEFAULT_VIEW: (input: ViewInput, output: object, target: HTMLElemen
         </div>
         ${Trace.Types.Events.isSyntheticLayoutShift(input.event) ?
           renderLayoutShiftDetails(
-            input.event, input.traceInsightsSets, input.parsedTrace, input.isFreshRecording, input.onEventClick,
+            input.event, input.parsedTrace.insights, input.parsedTrace, input.isFreshRecording, input.onEventClick,
          ) : renderLayoutShiftClusterDetails(
-           input.event, input.traceInsightsSets, input.parsedTrace, input.onEventClick,
+           input.event, input.parsedTrace.insights, input.parsedTrace, input.onEventClick,
          )}
         </div>
       </div>
@@ -201,7 +193,7 @@ export const DEFAULT_VIEW: (input: ViewInput, output: object, target: HTMLElemen
 
 function renderLayoutShiftDetails(
     layoutShift: Trace.Types.Events.SyntheticLayoutShift, traceInsightsSets: Trace.Insights.Types.TraceInsightSets|null,
-    parsedTrace: Trace.Handlers.Types.ParsedTrace, isFreshRecording: boolean,
+    parsedTrace: Trace.TraceModel.ParsedTrace, isFreshRecording: boolean,
     onEventClick: (e: Trace.Types.Events.Event) => void): Lit.LitTemplate {
   if (!traceInsightsSets) {
     return Lit.nothing;
@@ -252,7 +244,7 @@ function renderLayoutShiftDetails(
 
 function renderLayoutShiftClusterDetails(
     cluster: Trace.Types.Events.SyntheticLayoutShiftCluster,
-    traceInsightsSets: Trace.Insights.Types.TraceInsightSets|null, parsedTrace: Trace.Handlers.Types.ParsedTrace,
+    traceInsightsSets: Trace.Insights.Types.TraceInsightSets|null, parsedTrace: Trace.TraceModel.ParsedTrace,
     onEventClick: (e: Trace.Types.Events.Event) => void): Lit.LitTemplate {
   if (!traceInsightsSets) {
     return Lit.nothing;
@@ -303,7 +295,7 @@ function renderLayoutShiftClusterDetails(
 
 function renderShiftRow(
     currentShift: Trace.Types.Events.SyntheticLayoutShift, userHasSingleShiftSelected: boolean,
-    parsedTrace: Trace.Handlers.Types.ParsedTrace, elementsShifted: Trace.Types.Events.TraceImpactedNode[],
+    parsedTrace: Trace.TraceModel.ParsedTrace, elementsShifted: Trace.Types.Events.TraceImpactedNode[],
     onEventClick: (e: Trace.Types.Events.Event) => void,
     rootCauses: Trace.Insights.Models.CLSCulprits.LayoutShiftRootCausesData|undefined): Lit.LitTemplate {
   const score = currentShift.args.data?.weighted_score_delta;
@@ -340,10 +332,10 @@ function renderShiftRow(
 function renderStartTime(
     shift: Trace.Types.Events.SyntheticLayoutShift,
     userHasSingleShiftSelected: boolean,
-    parsedTrace: Trace.Handlers.Types.ParsedTrace,
+    parsedTrace: Trace.TraceModel.ParsedTrace,
     onEventClick: (e: Trace.Types.Events.Event) => void,
     ): Lit.TemplateResult {
-  const ts = Trace.Types.Timing.Micro(shift.ts - parsedTrace.Meta.traceBounds.min);
+  const ts = Trace.Types.Timing.Micro(shift.ts - parsedTrace.data.Meta.traceBounds.min);
   if (userHasSingleShiftSelected) {
     return html`${i18n.TimeUtilities.preciseMillisToString(Helpers.Timing.microToMilli(ts))}`;
   }
@@ -356,12 +348,11 @@ function renderStartTime(
 
 function renderParentCluster(
     cluster: Trace.Types.Events.SyntheticLayoutShiftCluster|undefined,
-    onEventClick: (e: Trace.Types.Events.Event) => void,
-    parsedTrace: Trace.Handlers.Types.ParsedTrace): Lit.LitTemplate {
+    onEventClick: (e: Trace.Types.Events.Event) => void, parsedTrace: Trace.TraceModel.ParsedTrace): Lit.LitTemplate {
   if (!cluster) {
     return Lit.nothing;
   }
-  const ts = Trace.Types.Timing.Micro(cluster.ts - (parsedTrace?.Meta.traceBounds.min ?? 0));
+  const ts = Trace.Types.Timing.Micro(cluster.ts - (parsedTrace.data.Meta.traceBounds.min ?? 0));
   const clusterTs = i18n.TimeUtilities.formatMicroSecondsTime(ts);
 
   // clang-format off

package/front_end/panels/timeline/components/LiveMetricsView.ts

@@ -28,8 +28,9 @@ import * as UI from '../../../ui/legacy/legacy.js';
 import * as Lit from '../../../ui/lit/lit.js';
 import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
 import * as MobileThrottling from '../../mobile_throttling/mobile_throttling.js';
-import {getThrottlingRecommendations, md} from '../utils/Helpers.js';
+import {getThrottlingRecommendations} from '../utils/Helpers.js';
 
+import {md} from './insights/Helpers.js';
 import liveMetricsViewStyles from './liveMetricsView.css.js';
 import type {MetricCardData} from './MetricCard.js';
 import metricValueStyles from './metricValueStyles.css.js';

package/front_end/panels/timeline/components/NetworkRequestDetails.ts

@@ -124,7 +124,7 @@ export class NetworkRequestDetails extends UI.Widget.Widget {
   #target: SDK.Target.Target|null = null;
   #linkifier: LegacyComponents.Linkifier.Linkifier|null = null;
   #serverTimings: SDK.ServerTiming.ServerTiming[]|null = null;
-  #parsedTrace: Trace.Handlers.Types.ParsedTrace|null = null;
+  #parsedTrace: Trace.TraceModel.ParsedTrace|null = null;
 
   constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
     super(element);
@@ -137,7 +137,7 @@ export class NetworkRequestDetails extends UI.Widget.Widget {
     this.requestUpdate();
   }
 
-  set parsedTrace(parsedTrace: Trace.Handlers.Types.ParsedTrace|null) {
+  set parsedTrace(parsedTrace: Trace.TraceModel.ParsedTrace|null) {
     this.#parsedTrace = parsedTrace;
     this.requestUpdate();
   }
@@ -192,7 +192,7 @@ export interface ViewInput {
   entityMapper: TimelineUtils.EntityMapper.EntityMapper|null;
   serverTimings: SDK.ServerTiming.ServerTiming[]|null;
   linkifier: LegacyComponents.Linkifier.Linkifier|null;
-  parsedTrace: Trace.Handlers.Types.ParsedTrace|null;
+  parsedTrace: Trace.TraceModel.ParsedTrace|null;
 }
 
 export const DEFAULT_VIEW: (
@@ -428,7 +428,7 @@ function renderServerTimings(timings: SDK.ServerTiming.ServerTiming[]|null): Lit
 }
 function renderInitiatedBy(
     request: Trace.Types.Events.SyntheticNetworkRequest,
-    parsedTrace: Trace.Handlers.Types.ParsedTrace|null,
+    parsedTrace: Trace.TraceModel.ParsedTrace|null,
     target: SDK.Target.Target|null,
     linkifier: LegacyComponents.Linkifier.Linkifier|null,
     ): Lit.LitTemplate {
@@ -451,7 +451,7 @@ function renderInitiatedBy(
     }
   }
   // If we do not, we can see if the network handler found an initiator and try to link by URL
-  const initiator = parsedTrace?.NetworkRequests.eventToInitiator.get(request);
+  const initiator = parsedTrace?.data.NetworkRequests.eventToInitiator.get(request);
   if (initiator) {
     link = linkifier.maybeLinkifyScriptLocation(
         target,

package/front_end/panels/timeline/components/Sidebar.ts

@@ -134,16 +134,11 @@ export class SidebarWidget extends UI.Widget.VBox {
     this.#tabbedPane.setBadge('annotations', annotations.length > 0 ? annotations.length.toString() : null);
   }
 
-  setParsedTrace(parsedTrace: Trace.Handlers.Types.ParsedTrace|null, metadata: Trace.Types.File.MetaData|null): void {
-    this.#insightsView.setParsedTrace(parsedTrace, metadata);
-  }
-
-  setInsights(insights: Trace.Insights.Types.TraceInsightSets|null): void {
-    this.#insightsView.setInsights(insights);
-
+  setParsedTrace(parsedTrace: Trace.TraceModel.ParsedTrace|null): void {
+    this.#insightsView.setParsedTrace(parsedTrace);
     this.#tabbedPane.setTabEnabled(
         SidebarTabs.INSIGHTS,
-        insights !== null && insights.size > 0,
+        Boolean(parsedTrace?.insights && parsedTrace.insights.size > 0),
     );
   }
 
@@ -167,13 +162,8 @@ class InsightsView extends UI.Widget.VBox {
     this.element.appendChild(this.#component);
   }
 
-  setParsedTrace(parsedTrace: Trace.Handlers.Types.ParsedTrace|null, metadata: Trace.Types.File.MetaData|null): void {
+  setParsedTrace(parsedTrace: Trace.TraceModel.ParsedTrace|null): void {
     this.#component.parsedTrace = parsedTrace;
-    this.#component.traceMetadata = metadata;
-  }
-
-  setInsights(data: Trace.Insights.Types.TraceInsightSets|null): void {
-    this.#component.insights = data;
   }
 
   getActiveInsight(): ActiveInsight|null {

package/front_end/panels/timeline/components/SidebarInsightsTab.ts

@@ -20,9 +20,7 @@ const {html} = Lit;
 
 export class SidebarInsightsTab extends HTMLElement {
   readonly #shadow = this.attachShadow({mode: 'open'});
-  #parsedTrace: Trace.Handlers.Types.ParsedTrace|null = null;
-  #traceMetadata: Trace.Types.File.MetaData|null = null;
-  #insights: Trace.Insights.Types.TraceInsightSets|null = null;
+  #parsedTrace: Trace.TraceModel.ParsedTrace|null = null;
   #activeInsight: ActiveInsight|null = null;
   #selectedCategory = Trace.Insights.Types.InsightCategory.ALL;
   /**
@@ -35,39 +33,19 @@ export class SidebarInsightsTab extends HTMLElement {
 
   // TODO(paulirish): add back a disconnectedCallback() to avoid memory leaks that doesn't cause b/372943062
 
-  set parsedTrace(data: Trace.Handlers.Types.ParsedTrace|null) {
+  set parsedTrace(data: Trace.TraceModel.ParsedTrace|null) {
     if (data === this.#parsedTrace) {
       return;
     }
-    this.#parsedTrace = data;
-    this.#selectedInsightSetKey = null;
-
-    void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#render);
-  }
 
-  set traceMetadata(data: Trace.Types.File.MetaData|null) {
-    if (data === this.#traceMetadata) {
-      return;
-    }
-    this.#traceMetadata = data;
+    this.#parsedTrace = data;
     this.#selectedInsightSetKey = null;
 
-    void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#render);
-  }
-
-  set insights(data: Trace.Insights.Types.TraceInsightSets|null) {
-    if (data === this.#insights) {
-      return;
-    }
-
-    this.#selectedInsightSetKey = null;
-    if (!data || !this.#parsedTrace) {
-      return;
+    if (this.#parsedTrace?.insights) {
+      /** Select the first set. Filtering out trivial sets was done back in {@link Trace.Processor.#computeInsightsForInitialTracePeriod} */
+      this.#selectedInsightSetKey = [...this.#parsedTrace.insights.keys()].at(0) ?? null;
     }
 
-    this.#insights = new Map(data);
-    /** Select the first set. Filtering out trivial sets was done back in {@link Trace.Processor.#computeInsightsForInitialTracePeriod} */
-    this.#selectedInsightSetKey = [...this.#insights.keys()].at(0) ?? null;
     void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#render);
   }
 
@@ -102,7 +80,7 @@ export class SidebarInsightsTab extends HTMLElement {
   }
 
   #insightSetHovered(id: string): void {
-    const data = this.#insights?.get(id);
+    const data = this.#parsedTrace?.insights?.get(id);
     data && this.dispatchEvent(new Insights.SidebarInsight.InsightSetHovered(data.bounds));
   }
 
@@ -112,7 +90,7 @@ export class SidebarInsightsTab extends HTMLElement {
 
   #onZoomClick(event: Event, id: string): void {
     event.stopPropagation();
-    const data = this.#insights?.get(id);
+    const data = this.#parsedTrace?.insights?.get(id);
     if (!data) {
       return;
     }
@@ -170,27 +148,26 @@ export class SidebarInsightsTab extends HTMLElement {
   }
 
   #render(): void {
-    if (!this.#parsedTrace || !this.#insights) {
+    if (!this.#parsedTrace?.insights) {
       Lit.render(Lit.nothing, this.#shadow, {host: this});
       return;
     }
 
-    const hasMultipleInsightSets = this.#insights.size > 1;
-    const labels = Utils.Helpers.createUrlLabels([...this.#insights.values()].map(({url}) => url));
+    const insights = this.#parsedTrace.insights;
+    const hasMultipleInsightSets = insights.size > 1;
+    const labels = Utils.Helpers.createUrlLabels([...insights.values()].map(({url}) => url));
 
     const contents =
         // clang-format off
      html`
       <style>${sidebarInsightsTabStyles}</style>
       <div class="insight-sets-wrapper">
-        ${[...this.#insights.values()].map(({id, url}, index) => {
+        ${[...insights.values()].map(({id, url}, index) => {
           const data: SidebarSingleInsightSetData = {
-            insights: this.#insights,
             insightSetKey: id,
             activeCategory: this.#selectedCategory,
             activeInsight: this.#activeInsight,
             parsedTrace: this.#parsedTrace,
-            traceMetadata: this.#traceMetadata,
           };
 
           const contents = html`