chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/front_end/models/emulation/EmulatedDevices.ts

@@ -50,7 +50,7 @@ export class EmulatedDevice {
   isFoldableScreen: boolean;
   verticalSpanned: Orientation;
   horizontalSpanned: Orientation;
-  #showInternal: Show;
+  #show: Show;
   #showByDefault: boolean;
 
   constructor() {
@@ -69,7 +69,7 @@ export class EmulatedDevice {
     this.verticalSpanned = {width: 0, height: 0, outlineInsets: null, outlineImage: null, hinge: null};
     this.horizontalSpanned = {width: 0, height: 0, outlineInsets: null, outlineImage: null, hinge: null};
 
-    this.#showInternal = Show.Default;
+    this.#show = Show.Default;
     this.#showByDefault = true;
   }
 
@@ -263,7 +263,7 @@ export class EmulatedDevice {
       if (!Object.values(Show).includes(show)) {
         throw new Error('Emulated device has wrong show mode: ' + show);
       }
-      result.#showInternal = show;
+      result.#show = show;
 
       return result;
     } catch {
@@ -364,7 +364,7 @@ export class EmulatedDevice {
     json['show-by-default'] = this.#showByDefault;
     json['dual-screen'] = this.isDualScreen;
     json['foldable-screen'] = this.isFoldableScreen;
-    json['show'] = this.#showInternal;
+    json['show'] = this.#show;
 
     if (this.userAgentMetadata) {
       json['user-agent-metadata'] = this.userAgentMetadata;
@@ -453,18 +453,18 @@ export class EmulatedDevice {
     }
   }
   show(): boolean {
-    if (this.#showInternal === Show.Default) {
+    if (this.#show === Show.Default) {
       return this.#showByDefault;
     }
-    return this.#showInternal === Show.Always;
+    return this.#show === Show.Always;
   }
 
   setShow(show: boolean): void {
-    this.#showInternal = show ? Show.Always : Show.Never;
+    this.#show = show ? Show.Always : Show.Never;
   }
 
   copyShowFrom(other: EmulatedDevice): void {
-    this.#showInternal = other.#showInternal;
+    this.#show = other.#show;
   }
 
   touch(): boolean {
@@ -508,20 +508,20 @@ let emulatedDevicesListInstance: EmulatedDevicesList;
 
 export class EmulatedDevicesList extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   readonly #standardSetting: Common.Settings.Setting<any[]>;
-  #standardInternal: Set<EmulatedDevice>;
+  #standard: Set<EmulatedDevice>;
   readonly #customSetting: Common.Settings.Setting<any[]>;
-  readonly #customInternal: Set<EmulatedDevice>;
+  readonly #custom: Set<EmulatedDevice>;
   constructor() {
     super();
 
     this.#standardSetting = Common.Settings.Settings.instance().createSetting('standard-emulated-device-list', []);
-    this.#standardInternal = new Set();
-    this.listFromJSONV1(this.#standardSetting.get(), this.#standardInternal);
+    this.#standard = new Set();
+    this.listFromJSONV1(this.#standardSetting.get(), this.#standard);
     this.updateStandardDevices();
 
     this.#customSetting = Common.Settings.Settings.instance().createSetting('custom-emulated-device-list', []);
-    this.#customInternal = new Set();
-    if (!this.listFromJSONV1(this.#customSetting.get(), this.#customInternal)) {
+    this.#custom = new Set();
+    if (!this.listFromJSONV1(this.#customSetting.get(), this.#custom)) {
       this.saveCustomDevices();
     }
   }
@@ -541,8 +541,8 @@ export class EmulatedDevicesList extends Common.ObjectWrapper.ObjectWrapper<Even
         devices.add(device);
       }
     }
-    this.copyShowValues(this.#standardInternal, devices);
-    this.#standardInternal = devices;
+    this.copyShowValues(this.#standard, devices);
+    this.#standard = devices;
     this.saveStandardDevices();
   }
 
@@ -571,11 +571,11 @@ export class EmulatedDevicesList extends Common.ObjectWrapper.ObjectWrapper<Even
   }
 
   standard(): EmulatedDevice[] {
-    return [...this.#standardInternal];
+    return [...this.#standard];
   }
 
   custom(): EmulatedDevice[] {
-    return [...this.#customInternal];
+    return [...this.#custom];
   }
 
   revealCustomSetting(): void {
@@ -583,18 +583,18 @@ export class EmulatedDevicesList extends Common.ObjectWrapper.ObjectWrapper<Even
   }
 
   addCustomDevice(device: EmulatedDevice): void {
-    this.#customInternal.add(device);
+    this.#custom.add(device);
     this.saveCustomDevices();
   }
 
   removeCustomDevice(device: EmulatedDevice): void {
-    this.#customInternal.delete(device);
+    this.#custom.delete(device);
     this.saveCustomDevices();
   }
 
   saveCustomDevices(): void {
     const json: any[] = [];
-    this.#customInternal.forEach(device => json.push(device.toJSON()));
+    this.#custom.forEach(device => json.push(device.toJSON()));
 
     this.#customSetting.set(json);
     this.dispatchEventToListeners(Events.CUSTOM_DEVICES_UPDATED);
@@ -602,7 +602,7 @@ export class EmulatedDevicesList extends Common.ObjectWrapper.ObjectWrapper<Even
 
   saveStandardDevices(): void {
     const json: any[] = [];
-    this.#standardInternal.forEach(device => json.push(device.toJSON()));
+    this.#standard.forEach(device => json.push(device.toJSON()));
 
     this.#standardSetting.set(json);
     this.dispatchEventToListeners(Events.STANDARD_DEVICES_UPDATED);

package/front_end/models/extensions/ExtensionPanel.ts

@@ -48,7 +48,7 @@ export class ExtensionPanel extends UI.Panel.Panel implements UI.SearchableView.
   private readonly server: ExtensionServer;
   private readonly id: string;
   private readonly panelToolbar: UI.Toolbar.Toolbar;
-  private readonly searchableViewInternal: UI.SearchableView.SearchableView;
+  readonly #searchableView: UI.SearchableView.SearchableView;
 
   constructor(server: ExtensionServer, panelName: string, id: string, pageURL: string) {
     super(panelName);
@@ -57,11 +57,11 @@ export class ExtensionPanel extends UI.Panel.Panel implements UI.SearchableView.
     this.setHideOnDetach();
     this.panelToolbar = this.element.createChild('devtools-toolbar', 'hidden');
 
-    this.searchableViewInternal = new UI.SearchableView.SearchableView(this, null);
-    this.searchableViewInternal.show(this.element);
+    this.#searchableView = new UI.SearchableView.SearchableView(this, null);
+    this.#searchableView.show(this.element);
 
     const extensionView = new ExtensionView(server, this.id, pageURL, 'extension');
-    extensionView.show(this.searchableViewInternal.element);
+    extensionView.show(this.#searchableView.element);
   }
 
   addToolbarItem(item: UI.Toolbar.ToolbarItem): void {
@@ -71,11 +71,11 @@ export class ExtensionPanel extends UI.Panel.Panel implements UI.SearchableView.
 
   onSearchCanceled(): void {
     this.server.notifySearchAction(this.id, ExtensionAPI.PrivateAPI.Panels.SearchAction.CancelSearch);
-    this.searchableViewInternal.updateSearchMatchesCount(0);
+    this.#searchableView.updateSearchMatchesCount(0);
   }
 
   override searchableView(): UI.SearchableView.SearchableView {
-    return this.searchableViewInternal;
+    return this.#searchableView;
   }
 
   performSearch(searchConfig: UI.SearchableView.SearchConfig, _shouldJump: boolean, _jumpBackwards?: boolean): void {
@@ -102,37 +102,37 @@ export class ExtensionPanel extends UI.Panel.Panel implements UI.SearchableView.
 
 export class ExtensionButton {
   private readonly id: string;
-  private readonly toolbarButtonInternal: UI.Toolbar.ToolbarButton;
+  readonly #toolbarButton: UI.Toolbar.ToolbarButton;
   constructor(server: ExtensionServer, id: string, iconURL: string, tooltip?: string, disabled?: boolean) {
     this.id = id;
 
-    this.toolbarButtonInternal = new UI.Toolbar.ToolbarButton('', '');
-    this.toolbarButtonInternal.addEventListener(
+    this.#toolbarButton = new UI.Toolbar.ToolbarButton('', '');
+    this.#toolbarButton.addEventListener(
         UI.Toolbar.ToolbarButton.Events.CLICK, server.notifyButtonClicked.bind(server, this.id));
     this.update(iconURL, tooltip, disabled);
   }
 
   update(iconURL?: string, tooltip?: string, disabled?: boolean): void {
     if (typeof iconURL === 'string') {
-      this.toolbarButtonInternal.setBackgroundImage(iconURL);
+      this.#toolbarButton.setBackgroundImage(iconURL);
     }
     if (typeof tooltip === 'string') {
-      this.toolbarButtonInternal.setTitle(tooltip);
+      this.#toolbarButton.setTitle(tooltip);
     }
     if (typeof disabled === 'boolean') {
-      this.toolbarButtonInternal.setEnabled(!disabled);
+      this.#toolbarButton.setEnabled(!disabled);
     }
   }
 
   toolbarButton(): UI.Toolbar.ToolbarButton {
-    return this.toolbarButtonInternal;
+    return this.#toolbarButton;
   }
 }
 
 export class ExtensionSidebarPane extends UI.View.SimpleView {
-  private readonly panelNameInternal: string;
+  readonly #panelName: string;
   private server: ExtensionServer;
-  private idInternal: string;
+  #id: string;
   private extensionView?: ExtensionView;
   private objectPropertiesView?: ExtensionNotifierView;
   constructor(server: ExtensionServer, panelName: string, title: Platform.UIString.LocalizedString, id: string) {
@@ -141,22 +141,22 @@ export class ExtensionSidebarPane extends UI.View.SimpleView {
     const viewId = Platform.StringUtilities.toKebabCase(title);
     super({title, viewId});
     this.element.classList.add('fill');
-    this.panelNameInternal = panelName;
+    this.#panelName = panelName;
     this.server = server;
-    this.idInternal = id;
+    this.#id = id;
   }
 
   id(): string {
-    return this.idInternal;
+    return this.#id;
   }
 
   panelName(): string {
-    return this.panelNameInternal;
+    return this.#panelName;
   }
 
   setObject(object: Object, title: string|undefined, callback: (arg0?: (string|null)|undefined) => void): void {
     this.createObjectPropertiesView();
-    this.setObjectInternal(SDK.RemoteObject.RemoteObject.fromLocalObject(object), title, callback);
+    this.#setObject(SDK.RemoteObject.RemoteObject.fromLocalObject(object), title, callback);
   }
 
   setExpression(
@@ -176,7 +176,7 @@ export class ExtensionSidebarPane extends UI.View.SimpleView {
       this.extensionView.detach(true);
     }
 
-    this.extensionView = new ExtensionView(this.server, this.idInternal, url, 'extension fill');
+    this.extensionView = new ExtensionView(this.server, this.#id, url, 'extension fill');
     this.extensionView.show(this.element);
 
     if (!this.element.style.height) {
@@ -196,7 +196,7 @@ export class ExtensionSidebarPane extends UI.View.SimpleView {
     } else if (!result) {
       callback();
     } else {
-      this.setObjectInternal(result, title, callback);
+      this.#setObject(result, title, callback);
     }
   }
 
@@ -208,11 +208,11 @@ export class ExtensionSidebarPane extends UI.View.SimpleView {
       this.extensionView.detach(true);
       delete this.extensionView;
     }
-    this.objectPropertiesView = new ExtensionNotifierView(this.server, this.idInternal);
+    this.objectPropertiesView = new ExtensionNotifierView(this.server, this.#id);
     this.objectPropertiesView.show(this.element);
   }
 
-  private setObjectInternal(
+  #setObject(
       object: SDK.RemoteObject.RemoteObject, title: string|undefined,
       callback: (arg0?: (string|null)|undefined) => void): void {
     const objectPropertiesView = this.objectPropertiesView;

package/front_end/models/extensions/ExtensionServer.ts

@@ -165,7 +165,7 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
   private lastRequestId: number;
   private registeredExtensions: Map<string, RegisteredExtension>;
   private status: ExtensionStatus;
-  private readonly sidebarPanesInternal: ExtensionSidebarPane[];
+  readonly #sidebarPanes: ExtensionSidebarPane[];
   private extensionsEnabled: boolean;
   private inspectedTabId?: string;
   private readonly extensionAPITestHook?: (server: unknown, api: unknown) => unknown;
@@ -185,7 +185,7 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     this.lastRequestId = 0;
     this.registeredExtensions = new Map();
     this.status = new ExtensionStatus();
-    this.sidebarPanesInternal = [];
+    this.#sidebarPanes = [];
     // TODO(caseq): properly unload extensions when we disable them.
     this.extensionsEnabled = true;
 
@@ -726,7 +726,7 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     }
     const id = message.id;
     const sidebar = new ExtensionSidebarPane(this, message.panel, i18n.i18n.lockedString(message.title), id);
-    this.sidebarPanesInternal.push(sidebar);
+    this.#sidebarPanes.push(sidebar);
     this.clientObjects.set(id, sidebar);
     this.dispatchEventToListeners(Events.SidebarPaneAdded, sidebar);
 
@@ -734,7 +734,7 @@ export class ExtensionServer extends Common.ObjectWrapper.ObjectWrapper<EventTyp
   }
 
   sidebarPanes(): ExtensionSidebarPane[] {
-    return this.sidebarPanesInternal;
+    return this.#sidebarPanes;
   }
 
   private onSetSidebarHeight(message: PrivateAPI.ExtensionServerRequestMessage): Record {

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -6097,6 +6097,10 @@ export const NativeFunctions = [
     name: "DocumentTimeline",
     signatures: [["?options"]]
   },
+  {
+    name: "EventTrigger",
+    signatures: [["?options"]]
+  },
   {
     name: "KeyframeEffect",
     signatures: [["source"],["target","keyframes","?options"]]
@@ -7588,7 +7592,7 @@ export const NativeFunctions = [
     signatures: [["element","x","y","?dwidth","?dheight"]]
   },
   {
-    name: "drawHTMLElement",
+    name: "drawHTML",
     signatures: [["element","x","y","?dwidth","?dheight"]]
   },
   {
@@ -8427,6 +8431,14 @@ export const NativeFunctions = [
     name: "RTCSessionDescription",
     signatures: [["?descriptionInitDict"]]
   },
+  {
+    name: "RtcTransport",
+    signatures: [["name"]]
+  },
+  {
+    name: "sendPackets",
+    signatures: [["packets"]]
+  },
   {
     name: "revoke",
     signatures: [["permission"]]
@@ -8878,7 +8890,7 @@ export const NativeFunctions = [
     signatures: [["provokeMode"]]
   },
   {
-    name: "texHTMLElement2D",
+    name: "texHTML2D",
     signatures: [["target","level","internalformat","format","type","element"]]
   },
   {

package/front_end/models/persistence/IsolatedFileSystem.ts

@@ -74,14 +74,14 @@ const str_ = i18n.i18n.registerUIStrings('models/persistence/IsolatedFileSystem.
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export class IsolatedFileSystem extends PlatformFileSystem {
   private readonly manager: IsolatedFileSystemManager;
-  private readonly embedderPathInternal: Platform.DevToolsPath.RawPathString;
+  readonly #embedderPath: Platform.DevToolsPath.RawPathString;
   private readonly domFileSystem: FileSystem;
   private readonly excludedFoldersSetting:
       Common.Settings.Setting<Record<Platform.DevToolsPath.UrlString, Platform.DevToolsPath.EncodedPathString[]>>;
-  private excludedFoldersInternal: Set<Platform.DevToolsPath.EncodedPathString>;
+  #excludedFolders: Set<Platform.DevToolsPath.EncodedPathString>;
   private readonly excludedEmbedderFolders: Platform.DevToolsPath.RawPathString[] = [];
-  private readonly initialFilePathsInternal = new Set<Platform.DevToolsPath.EncodedPathString>();
-  private readonly initialGitFoldersInternal = new Set<Platform.DevToolsPath.EncodedPathString>();
+  readonly #initialFilePaths = new Set<Platform.DevToolsPath.EncodedPathString>();
+  readonly #initialGitFolders = new Set<Platform.DevToolsPath.EncodedPathString>();
   private readonly fileLocks = new Map<Platform.DevToolsPath.EncodedPathString, Promise<unknown>>();
 
   constructor(
@@ -90,11 +90,11 @@ export class IsolatedFileSystem extends PlatformFileSystem {
       automatic: boolean) {
     super(path, type, automatic);
     this.manager = manager;
-    this.embedderPathInternal = embedderPath;
+    this.#embedderPath = embedderPath;
     this.domFileSystem = domFileSystem;
     this.excludedFoldersSetting =
         Common.Settings.Settings.instance().createLocalSetting('workspace-excluded-folders', {});
-    this.excludedFoldersInternal = new Set(this.excludedFoldersSetting.get()[path] || []);
+    this.#excludedFolders = new Set(this.excludedFoldersSetting.get()[path] || []);
   }
 
   static async create(
@@ -142,15 +142,15 @@ export class IsolatedFileSystem extends PlatformFileSystem {
   }
 
   override initialFilePaths(): Platform.DevToolsPath.EncodedPathString[] {
-    return [...this.initialFilePathsInternal];
+    return [...this.#initialFilePaths];
   }
 
   override initialGitFolders(): Platform.DevToolsPath.EncodedPathString[] {
-    return [...this.initialGitFoldersInternal];
+    return [...this.#initialGitFolders];
   }
 
   override embedderPath(): Platform.DevToolsPath.RawPathString {
-    return this.embedderPathInternal;
+    return this.#embedderPath;
   }
 
   private initializeFilePaths(): Promise<void> {
@@ -167,14 +167,14 @@ export class IsolatedFileSystem extends PlatformFileSystem {
                     entry.fullPath as Platform.DevToolsPath.RawPathString))) {
               continue;
             }
-            this.initialFilePathsInternal.add(Common.ParsedURL.ParsedURL.rawPathToEncodedPathString(
+            this.#initialFilePaths.add(Common.ParsedURL.ParsedURL.rawPathToEncodedPathString(
                 Common.ParsedURL.ParsedURL.substr(entry.fullPath as Platform.DevToolsPath.RawPathString, 1)));
           } else {
             if (entry.fullPath.endsWith('/.git')) {
               const lastSlash = entry.fullPath.lastIndexOf('/');
               const parentFolder = Common.ParsedURL.ParsedURL.substr(
                   entry.fullPath as Platform.DevToolsPath.RawPathString, 1, lastSlash);
-              this.initialGitFoldersInternal.add(Common.ParsedURL.ParsedURL.rawPathToEncodedPathString(parentFolder));
+              this.#initialGitFolders.add(Common.ParsedURL.ParsedURL.rawPathToEncodedPathString(parentFolder));
             }
             if (this.isFileExcluded(Common.ParsedURL.ParsedURL.concatenate(
                     Common.ParsedURL.ParsedURL.rawPathToEncodedPathString(
@@ -502,18 +502,18 @@ export class IsolatedFileSystem extends PlatformFileSystem {
 
   private saveExcludedFolders(): void {
     const settingValue = this.excludedFoldersSetting.get();
-    settingValue[this.path()] = [...this.excludedFoldersInternal];
+    settingValue[this.path()] = [...this.#excludedFolders];
     this.excludedFoldersSetting.set(settingValue);
   }
 
   override addExcludedFolder(path: Platform.DevToolsPath.EncodedPathString): void {
-    this.excludedFoldersInternal.add(path);
+    this.#excludedFolders.add(path);
     this.saveExcludedFolders();
     this.manager.dispatchEventToListeners(Events.ExcludedFolderAdded, path);
   }
 
   override removeExcludedFolder(path: Platform.DevToolsPath.EncodedPathString): void {
-    this.excludedFoldersInternal.delete(path);
+    this.#excludedFolders.delete(path);
     this.saveExcludedFolders();
     this.manager.dispatchEventToListeners(Events.ExcludedFolderRemoved, path);
   }
@@ -525,7 +525,7 @@ export class IsolatedFileSystem extends PlatformFileSystem {
   }
 
   override isFileExcluded(folderPath: Platform.DevToolsPath.EncodedPathString): boolean {
-    if (this.excludedFoldersInternal.has(folderPath)) {
+    if (this.#excludedFolders.has(folderPath)) {
       return true;
     }
     const regex = (this.manager.workspaceFolderExcludePatternSetting()).asRegExp();
@@ -533,14 +533,13 @@ export class IsolatedFileSystem extends PlatformFileSystem {
   }
 
   override excludedFolders(): Set<Platform.DevToolsPath.EncodedPathString> {
-    return this.excludedFoldersInternal;
+    return this.#excludedFolders;
   }
 
   override searchInPath(query: string, progress: Common.Progress.Progress): Promise<string[]> {
     return new Promise(resolve => {
       const requestId = this.manager.registerCallback(innerCallback);
-      Host.InspectorFrontendHost.InspectorFrontendHostInstance.searchInPath(
-          requestId, this.embedderPathInternal, query);
+      Host.InspectorFrontendHost.InspectorFrontendHostInstance.searchInPath(requestId, this.#embedderPath, query);
 
       function innerCallback(files: Platform.DevToolsPath.RawPathString[]): void {
         resolve(files.map(path => Common.ParsedURL.ParsedURL.rawPathToUrlString(path)));
@@ -553,7 +552,7 @@ export class IsolatedFileSystem extends PlatformFileSystem {
     progress.setTotalWork(1);
     const requestId = this.manager.registerProgress(progress);
     Host.InspectorFrontendHost.InspectorFrontendHostInstance.indexPath(
-        requestId, this.embedderPathInternal, JSON.stringify(this.excludedEmbedderFolders));
+        requestId, this.#embedderPath, JSON.stringify(this.excludedEmbedderFolders));
   }
 
   override mimeFromPath(path: Platform.DevToolsPath.UrlString): string {

package/front_end/models/persistence/IsolatedFileSystemManager.ts

@@ -53,16 +53,16 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 let isolatedFileSystemManagerInstance: IsolatedFileSystemManager|null;
 
 export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
-  private readonly fileSystemsInternal: Map<Platform.DevToolsPath.UrlString, PlatformFileSystem>;
+  readonly #fileSystems: Map<Platform.DevToolsPath.UrlString, PlatformFileSystem>;
   private readonly callbacks: Map<number, (arg0: Platform.DevToolsPath.RawPathString[]) => void>;
   private readonly progresses: Map<number, Common.Progress.Progress>;
-  private readonly workspaceFolderExcludePatternSettingInternal: Common.Settings.RegExpSetting;
+  readonly #workspaceFolderExcludePatternSetting: Common.Settings.RegExpSetting;
   private fileSystemRequestResolve: ((arg0: IsolatedFileSystem|null) => void)|null;
   private readonly fileSystemsLoadedPromise: Promise<IsolatedFileSystem[]>;
   private constructor() {
     super();
 
-    this.fileSystemsInternal = new Map();
+    this.#fileSystems = new Map();
     this.callbacks = new Map();
     this.progresses = new Map();
 
@@ -116,7 +116,7 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
       defaultExcludedFolders = defaultExcludedFolders.concat(defaultLinuxExcludedFolders);
     }
     const defaultExcludedFoldersPattern = defaultExcludedFolders.join('|');
-    this.workspaceFolderExcludePatternSettingInternal = Common.Settings.Settings.instance().createRegExpSetting(
+    this.#workspaceFolderExcludePatternSetting = Common.Settings.Settings.instance().createRegExpSetting(
         'workspace-folder-exclude-pattern', defaultExcludedFoldersPattern, Host.Platform.isWin() ? 'i' : '');
 
     this.fileSystemRequestResolve = null;
@@ -194,7 +194,7 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
       if (!fileSystem) {
         return null;
       }
-      this.fileSystemsInternal.set(fileSystemURL, fileSystem);
+      this.#fileSystems.set(fileSystemURL, fileSystem);
       fileSystem.addEventListener(PlatformFileSystemEvents.FILE_SYSTEM_ERROR, this.#onFileSystemError, this);
       if (dispatchEvent) {
         this.dispatchEventToListeners(Events.FileSystemAdded, fileSystem);
@@ -204,7 +204,7 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
   }
 
   addPlatformFileSystem(fileSystemURL: Platform.DevToolsPath.UrlString, fileSystem: PlatformFileSystem): void {
-    this.fileSystemsInternal.set(fileSystemURL, fileSystem);
+    this.#fileSystems.set(fileSystemURL, fileSystem);
     fileSystem.addEventListener(PlatformFileSystemEvents.FILE_SYSTEM_ERROR, this.#onFileSystemError, this);
     this.dispatchEventToListeners(Events.FileSystemAdded, fileSystem);
   }
@@ -238,11 +238,11 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
   private onFileSystemRemoved(event: Common.EventTarget.EventTargetEvent<Platform.DevToolsPath.RawPathString>): void {
     const embedderPath = event.data;
     const fileSystemPath = Common.ParsedURL.ParsedURL.rawPathToUrlString(embedderPath);
-    const isolatedFileSystem = this.fileSystemsInternal.get(fileSystemPath);
+    const isolatedFileSystem = this.#fileSystems.get(fileSystemPath);
     if (!isolatedFileSystem) {
       return;
     }
-    this.fileSystemsInternal.delete(fileSystemPath);
+    this.#fileSystems.delete(fileSystemPath);
     isolatedFileSystem.removeEventListener(PlatformFileSystemEvents.FILE_SYSTEM_ERROR, this.#onFileSystemError, this);
     isolatedFileSystem.fileSystemRemoved();
     this.dispatchEventToListeners(Events.FileSystemRemoved, isolatedFileSystem);
@@ -265,8 +265,8 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
           new Platform.MapUtilities.Multimap<Platform.DevToolsPath.UrlString, Platform.DevToolsPath.UrlString>();
       for (const embedderPath of embedderPaths) {
         const filePath = Common.ParsedURL.ParsedURL.rawPathToUrlString(embedderPath);
-        for (const fileSystemPath of this.fileSystemsInternal.keys()) {
-          const fileSystem = this.fileSystemsInternal.get(fileSystemPath);
+        for (const fileSystemPath of this.#fileSystems.keys()) {
+          const fileSystem = this.#fileSystems.get(fileSystemPath);
           if (fileSystem?.isFileExcluded(Common.ParsedURL.ParsedURL.rawPathToEncodedPathString(embedderPath))) {
             continue;
           }
@@ -282,15 +282,15 @@ export class IsolatedFileSystemManager extends Common.ObjectWrapper.ObjectWrappe
   }
 
   fileSystems(): PlatformFileSystem[] {
-    return [...this.fileSystemsInternal.values()];
+    return [...this.#fileSystems.values()];
   }
 
   fileSystem(fileSystemPath: Platform.DevToolsPath.UrlString): PlatformFileSystem|null {
-    return this.fileSystemsInternal.get(fileSystemPath) || null;
+    return this.#fileSystems.get(fileSystemPath) || null;
   }
 
   workspaceFolderExcludePatternSetting(): Common.Settings.RegExpSetting {
-    return this.workspaceFolderExcludePatternSettingInternal;
+    return this.#workspaceFolderExcludePatternSetting;
   }
 
   registerCallback(callback: (arg0: Platform.DevToolsPath.RawPathString[]) => void): number {

package/front_end/models/trace/EventsSerializer.ts

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as Handlers from './handlers/handlers.js';
 import * as Helpers from './helpers/helpers.js';
+import type {ParsedTrace} from './ModelImpl.js';
 import * as Types from './types/types.js';
 
 export class EventsSerializer {
@@ -29,7 +29,7 @@ export class EventsSerializer {
     return key;
   }
 
-  eventForKey(key: Types.File.SerializableKey, parsedTrace: Handlers.Types.ParsedTrace): Types.Events.Event {
+  eventForKey(key: Types.File.SerializableKey, parsedTrace: ParsedTrace): Types.Events.Event {
     const eventValues = Types.File.traceEventKeyToValues(key);
 
     if (EventsSerializer.isProfileCallKey(eventValues)) {
@@ -37,7 +37,7 @@ export class EventsSerializer {
     }
 
     if (EventsSerializer.isLegacyTimelineFrameKey(eventValues)) {
-      const event = parsedTrace.Frames.frames.at(eventValues.rawIndex);
+      const event = parsedTrace.data.Frames.frames.at(eventValues.rawIndex);
       if (!event) {
         throw new Error(`Could not find frame with index ${eventValues.rawIndex}`);
       }
@@ -75,14 +75,14 @@ export class EventsSerializer {
     return key.type === Types.File.EventKeyType.SYNTHETIC_EVENT;
   }
 
-  #getModifiedProfileCallByKeyValues(key: Types.File.ProfileCallKeyValues, parsedTrace: Handlers.Types.ParsedTrace):
+  #getModifiedProfileCallByKeyValues(key: Types.File.ProfileCallKeyValues, parsedTrace: ParsedTrace):
       Types.Events.SyntheticProfileCall {
     const cacheResult = this.#modifiedProfileCallByKey.get(key);
     if (cacheResult) {
       return cacheResult;
     }
     const profileCallsInThread =
-        parsedTrace.Renderer.processes.get(key.processID)?.threads.get(key.threadID)?.profileCalls;
+        parsedTrace.data.Renderer.processes.get(key.processID)?.threads.get(key.threadID)?.profileCalls;
     if (!profileCallsInThread) {
       throw new Error(`Unknown profile call serializable key: ${(key)}`);
     }