chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/front_end/models/bindings/DebuggerLanguagePlugins.ts

@@ -221,30 +221,30 @@ class SourceScopeRemoteObject extends SDK.RemoteObject.RemoteObjectImpl {
 }
 
 export class SourceScope implements SDK.DebuggerModel.ScopeChainEntry {
-  readonly #callFrameInternal: SDK.DebuggerModel.CallFrame;
-  readonly #typeInternal: string;
-  readonly #typeNameInternal: string;
-  readonly #iconInternal: string|undefined;
-  readonly #objectInternal: SourceScopeRemoteObject;
+  readonly #callFrame: SDK.DebuggerModel.CallFrame;
+  readonly #type: string;
+  readonly #typeName: string;
+  readonly #icon: string|undefined;
+  readonly #object: SourceScopeRemoteObject;
   constructor(
       callFrame: SDK.DebuggerModel.CallFrame, stopId: StopId, type: string, typeName: string, icon: string|undefined,
       plugin: DebuggerLanguagePlugin) {
     if (icon && new URL(icon).protocol !== 'data:') {
       throw new Error('The icon must be a data:-URL');
     }
-    this.#callFrameInternal = callFrame;
-    this.#typeInternal = type;
-    this.#typeNameInternal = typeName;
-    this.#iconInternal = icon;
-    this.#objectInternal = new SourceScopeRemoteObject(callFrame, stopId, plugin);
+    this.#callFrame = callFrame;
+    this.#type = type;
+    this.#typeName = typeName;
+    this.#icon = icon;
+    this.#object = new SourceScopeRemoteObject(callFrame, stopId, plugin);
   }
 
   async getVariableValue(name: string): Promise<SDK.RemoteObject.RemoteObject|null> {
-    for (let v = 0; v < this.#objectInternal.variables.length; ++v) {
-      if (this.#objectInternal.variables[v].name !== name) {
+    for (let v = 0; v < this.#object.variables.length; ++v) {
+      if (this.#object.variables[v].name !== name) {
         continue;
       }
-      const properties = await this.#objectInternal.getAllProperties(false, false);
+      const properties = await this.#object.getAllProperties(false, false);
       if (!properties.properties) {
         continue;
       }
@@ -257,15 +257,15 @@ export class SourceScope implements SDK.DebuggerModel.ScopeChainEntry {
   }
 
   callFrame(): SDK.DebuggerModel.CallFrame {
-    return this.#callFrameInternal;
+    return this.#callFrame;
   }
 
   type(): string {
-    return this.#typeInternal;
+    return this.#type;
   }
 
   typeName(): string {
-    return this.#typeNameInternal;
+    return this.#typeName;
   }
 
   name(): string|undefined {
@@ -277,7 +277,7 @@ export class SourceScope implements SDK.DebuggerModel.ScopeChainEntry {
   }
 
   object(): SourceScopeRemoteObject {
-    return this.#objectInternal;
+    return this.#object;
   }
 
   description(): string {
@@ -285,7 +285,7 @@ export class SourceScope implements SDK.DebuggerModel.ScopeChainEntry {
   }
 
   icon(): string|undefined {
-    return this.#iconInternal;
+    return this.#icon;
   }
 
   extraProperties(): SDK.RemoteObject.RemoteObjectProperty[] {

package/front_end/models/bindings/FileUtils.ts

@@ -47,27 +47,27 @@ export interface ChunkedReader {
 
 export class ChunkedFileReader implements ChunkedReader {
   #file: File|null;
-  readonly #fileSizeInternal: number;
-  #loadedSizeInternal: number;
+  readonly #fileSize: number;
+  #loadedSize: number;
   #streamReader: ReadableStreamDefaultReader<Uint8Array<ArrayBuffer>>|null;
   readonly #chunkSize: number;
   readonly #chunkTransferredCallback: ((arg0: ChunkedReader) => void)|undefined;
   readonly #decoder: TextDecoder;
   #isCanceled: boolean;
-  #errorInternal: DOMException|null;
+  #error: DOMException|null;
   #transferFinished!: (arg0: boolean) => void;
   #output?: Common.StringOutputStream.OutputStream;
   #reader?: FileReader|null;
 
   constructor(file: File, chunkSize?: number, chunkTransferredCallback?: ((arg0: ChunkedReader) => void)) {
     this.#file = file;
-    this.#fileSizeInternal = file.size;
-    this.#loadedSizeInternal = 0;
+    this.#fileSize = file.size;
+    this.#loadedSize = 0;
     this.#chunkSize = (chunkSize) ? chunkSize : Number.MAX_VALUE;
     this.#chunkTransferredCallback = chunkTransferredCallback;
     this.#decoder = new TextDecoder();
     this.#isCanceled = false;
-    this.#errorInternal = null;
+    this.#error = null;
     this.#streamReader = null;
   }
 
@@ -99,11 +99,11 @@ export class ChunkedFileReader implements ChunkedReader {
   }
 
   loadedSize(): number {
-    return this.#loadedSizeInternal;
+    return this.#loadedSize;
   }
 
   fileSize(): number {
-    return this.#fileSizeInternal;
+    return this.#fileSize;
   }
 
   fileName(): string {
@@ -114,7 +114,7 @@ export class ChunkedFileReader implements ChunkedReader {
   }
 
   error(): DOMException|null {
-    return this.#errorInternal;
+    return this.#error;
   }
 
   private onChunkLoaded(event: Event): void {
@@ -132,8 +132,8 @@ export class ChunkedFileReader implements ChunkedReader {
     }
 
     const buffer = (this.#reader.result as ArrayBuffer);
-    this.#loadedSizeInternal += buffer.byteLength;
-    const endOfFile = this.#loadedSizeInternal === this.#fileSizeInternal;
+    this.#loadedSize += buffer.byteLength;
+    const endOfFile = this.#loadedSize === this.#fileSize;
     void this.decodeChunkBuffer(buffer, endOfFile);
   }
 
@@ -164,7 +164,7 @@ export class ChunkedFileReader implements ChunkedReader {
     this.#file = null;
     this.#reader = null;
     await this.#output.close();
-    this.#transferFinished(!this.#errorInternal);
+    this.#transferFinished(!this.#error);
   }
 
   private async loadChunk(): Promise<void> {
@@ -181,8 +181,8 @@ export class ChunkedFileReader implements ChunkedReader {
       void this.decodeChunkBuffer(value.buffer, false);
     }
     if (this.#reader) {
-      const chunkStart = this.#loadedSizeInternal;
-      const chunkEnd = Math.min(this.#fileSizeInternal, chunkStart + this.#chunkSize);
+      const chunkStart = this.#loadedSize;
+      const chunkEnd = Math.min(this.#fileSize, chunkStart + this.#chunkSize);
       const nextPart = this.#file.slice(chunkStart, chunkEnd);
       this.#reader.readAsArrayBuffer(nextPart);
     }
@@ -190,7 +190,7 @@ export class ChunkedFileReader implements ChunkedReader {
 
   private onError(event: Event): void {
     const eventTarget = (event.target as FileReader);
-    this.#errorInternal = eventTarget.error;
+    this.#error = eventTarget.error;
     this.#transferFinished(false);
   }
 }

package/front_end/models/bindings/ResourceScriptMapping.ts

@@ -308,9 +308,9 @@ export class ResourceScriptFile extends Common.ObjectWrapper.ObjectWrapper<Resou
   readonly uiSourceCode: Workspace.UISourceCode.UISourceCode;
   readonly script: SDK.Script.Script|null;
   #scriptSource?: string|null;
-  #isDivergingFromVMInternal?: boolean;
-  #hasDivergedFromVMInternal?: boolean;
-  #isMergingToVMInternal?: boolean;
+  #isDivergingFromVM?: boolean;
+  #hasDivergedFromVM?: boolean;
+  #isMergingToVM?: boolean;
   #updateMutex = new Common.Mutex.Mutex();
   constructor(
       resourceScriptMapping: ResourceScriptMapping, uiSourceCode: Workspace.UISourceCode.UISourceCode,
@@ -414,9 +414,9 @@ export class ResourceScriptFile extends Common.ObjectWrapper.ObjectWrapper<Resou
     // Do not interleave "divergeFromVM" with "mergeToVM" calls.
     const release = await this.#updateMutex.acquire();
     const diverged = this.isDiverged();
-    if (diverged && !this.#hasDivergedFromVMInternal) {
+    if (diverged && !this.#hasDivergedFromVM) {
       await this.divergeFromVM();
-    } else if (!diverged && this.#hasDivergedFromVMInternal) {
+    } else if (!diverged && this.#hasDivergedFromVM) {
       await this.mergeToVM();
     }
     release();
@@ -424,34 +424,34 @@ export class ResourceScriptFile extends Common.ObjectWrapper.ObjectWrapper<Resou
 
   private async divergeFromVM(): Promise<void> {
     if (this.script) {
-      this.#isDivergingFromVMInternal = true;
+      this.#isDivergingFromVM = true;
       await this.#resourceScriptMapping.debuggerWorkspaceBinding.updateLocations(this.script);
-      this.#isDivergingFromVMInternal = undefined;
-      this.#hasDivergedFromVMInternal = true;
+      this.#isDivergingFromVM = undefined;
+      this.#hasDivergedFromVM = true;
       this.dispatchEventToListeners(ResourceScriptFile.Events.DID_DIVERGE_FROM_VM);
     }
   }
 
   private async mergeToVM(): Promise<void> {
     if (this.script) {
-      this.#hasDivergedFromVMInternal = undefined;
-      this.#isMergingToVMInternal = true;
+      this.#hasDivergedFromVM = undefined;
+      this.#isMergingToVM = true;
       await this.#resourceScriptMapping.debuggerWorkspaceBinding.updateLocations(this.script);
-      this.#isMergingToVMInternal = undefined;
+      this.#isMergingToVM = undefined;
       this.dispatchEventToListeners(ResourceScriptFile.Events.DID_MERGE_TO_VM);
     }
   }
 
   hasDivergedFromVM(): boolean {
-    return Boolean(this.#hasDivergedFromVMInternal);
+    return Boolean(this.#hasDivergedFromVM);
   }
 
   isDivergingFromVM(): boolean {
-    return Boolean(this.#isDivergingFromVMInternal);
+    return Boolean(this.#isDivergingFromVM);
   }
 
   isMergingToVM(): boolean {
-    return Boolean(this.#isMergingToVMInternal);
+    return Boolean(this.#isMergingToVM);
   }
 
   checkMapping(): void {

package/front_end/models/elements/ElementUpdateRecord.ts

@@ -37,9 +37,9 @@ import type * as SDK from '../../core/sdk/sdk.js';
 export class ElementUpdateRecord {
   private modifiedAttributes?: Set<string>;
   private removedAttributes?: Set<string>;
-  private hasChangedChildrenInternal?: boolean;
-  private hasRemovedChildrenInternal?: boolean;
-  private charDataModifiedInternal?: boolean;
+  #hasChangedChildren?: boolean;
+  #hasRemovedChildren?: boolean;
+  #charDataModified?: boolean;
 
   attributeModified(attrName: string): void {
     if (this.removedAttributes?.has(attrName)) {
@@ -62,20 +62,20 @@ export class ElementUpdateRecord {
   }
 
   nodeInserted(_node: SDK.DOMModel.DOMNode): void {
-    this.hasChangedChildrenInternal = true;
+    this.#hasChangedChildren = true;
   }
 
   nodeRemoved(_node: SDK.DOMModel.DOMNode): void {
-    this.hasChangedChildrenInternal = true;
-    this.hasRemovedChildrenInternal = true;
+    this.#hasChangedChildren = true;
+    this.#hasRemovedChildren = true;
   }
 
   charDataModified(): void {
-    this.charDataModifiedInternal = true;
+    this.#charDataModified = true;
   }
 
   childrenModified(): void {
-    this.hasChangedChildrenInternal = true;
+    this.#hasChangedChildren = true;
   }
 
   isAttributeModified(attributeName: string): boolean {
@@ -88,14 +88,14 @@ export class ElementUpdateRecord {
   }
 
   isCharDataModified(): boolean {
-    return Boolean(this.charDataModifiedInternal);
+    return Boolean(this.#charDataModified);
   }
 
   hasChangedChildren(): boolean {
-    return Boolean(this.hasChangedChildrenInternal);
+    return Boolean(this.#hasChangedChildren);
   }
 
   hasRemovedChildren(): boolean {
-    return Boolean(this.hasRemovedChildrenInternal);
+    return Boolean(this.#hasRemovedChildren);
   }
 }