chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/docs/cookbook/release_management.md

@@ -17,21 +17,23 @@ their commit hash, which should suffice for the projected future.
 For each Chromium release branch, we create a mirror branch with the same name
 on our repo. Rough outline:
 
-1.  Chromium cuts a branch e.g. 3879
-1.  Bots create Chromium/3879 branch on the DevTools frontend repo
+1.  Chromium cuts a branch e.g. `3879`
+1.  Bots create the `chromium/3879` branch on the `devtools-frontend` repo
 1.  The end
 
 ## Handling of Beta/Stable branches
 
-Generally speaking, beta/stable branches are the same as Canary branches. There
-is a special waterfall though, that runs tests on the beta/stable branches.
+Generally speaking, Beta/Stable branches are the same as Canary branches.
+However, there is a special waterfall that runs tests on the
+[Beta](https://ci.chromium.org/p/devtools-frontend/g/beta/console) and
+[Stable](https://ci.chromium.org/p/devtools-frontend/g/stable/console) branches.
 
-When Chromium updates to a new major version we need to update the branch number
-in
-[infra/config](https://chromium.googlesource.com/devtools/devtools-frontend/+/refs/heads/infra/config)
-branch of devtools-frontend. Specifically, in file buckets/ci.start, promote the
-existing beta branch to stable section and modify beta section with the
-corresponding branch number for the new Chromium milestone.
+To make this possible, whenever Chromium updates to a new major version, we
+update the branch number in the
+[`infra/config`](https://chromium.googlesource.com/devtools/devtools-frontend/+/refs/heads/infra/config)
+branch of `devtools-frontend`. Specifically, in `buckets/ci.start`, promote the
+existing `beta` branch to the `stable` section and modify the `beta` section
+with the corresponding branch number for the new Chromium milestone.
 
 ```python
 generate_ci_configs(
@@ -48,13 +50,13 @@ generate_ci_configs(
       ...
 ```
 
-After editing the above mentioned file run `lucicfg generate main.star` to have
-the change propagated to the cfg files. Example:
+After editing the above mentioned file, run `lucicfg generate main.star` to have
+the change propagated to the `*.cfg` files. Example:
 [CL](https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2104476)
 
 ## Rolling/Integrating into Chromium
 
 The
 [Skia autoroller](https://skia.googlesource.com/buildbot/+/main/autoroll/README.md)
-is used. The DevTools-Frontend auto-roller state can be seen and controlled
+is used. The `devtools-frontend` auto-roller state can be seen and controlled
 [here](https://autoroll.skia.org/r/devtools-frontend-chromium?tab=status).

package/docs/get_the_code.md

@@ -291,16 +291,125 @@ you could run the hosted DevTools with the following command:
 $ google-chrome http://localhost:8000/inspector.html?ws=localhost:9222/devtools/page/BADADD4E55BADADD4E55BADADD4E5511
 ```
 
+## Chromium checkout
+
+You can also work on the DevTools front-end within a full Chromium checkout.
+This workflow is particularly useful if you are working on a feature or a bug
+that spans back-end (Chromium C++ code) and front-end (DevTools TypeScript
+code), but it's also useful for Chromies that need to make small patches to
+DevTools front-end and don't want to go through the process of setting up a
+dedicated [`devtools-frontend` standalone checkout](#standalone-checkout).
+
+### Checking out source
+
+Follow [instructions](https://www.chromium.org/developers/how-tos/get-the-code)
+to check out Chromium. The DevTools front-end code is located inside the
+`third_party/devtools-frontend/src/` folder (after running `gclient sync`).
+
+### Build
+
+The [instructions](https://www.chromium.org/developers/how-tos/get-the-code) on
+the Chromium page apply as well here. In particular use
+
+```bash
+autoninja -C out/Default chrome
+```
+
+to build Chromium with the bundled DevTools front-end. You can also use
+
+```bash
+autoninja -C out/Default devtools_frontend_resources
+```
+
+to only build the DevTools front-end resources, which can afterwards be found in
+the `out/Default/gen/third_party/devtools-frontend/src/front_end` folder.
+
+### Run
+
+Launch Chromium with the bundled DevTools front-end using
+
+```bash
+out/Default/chrome
+```
+
+or if you are only iterating on a small set of changes to the DevTools front-end
+and used the `devtools_frontend_resources` build target, you can run Chrome with
+the generated DevTools front-end artifacts using
+
+```bash
+out/Default/chrome --custom-devtools-frontend=file://$(realpath out/Default/gen/third_party/devtools-frontend/src/front_end)
+```
+
+afterwards, which can be quite a bit faster than building and linking the full
+Chromium binary.
+
+### Testing
+
+To run the test suite, use `npm test` from within the DevTools front-end folder:
+
+```bash
+cd third_party/devtools-frontend/src
+npm test
+```
+
+### Juggling the git submodules
+
+Working on DevTools within a Chromium checkout means working across two separate
+repositories (at the same time), which can be a bit tricky. Especially if you
+are working on a change that spans across the boundary of the front-end and the
+back-end, you'll need to cook two separate CLs. There are several ways to go
+about this, and in here, we'll outline one somewhat well-lit path. You start by
+creating a branch in both Chromium and DevTools:
+
+```bash
+git new-branch my-change-backend
+pushd third_party/devtools-frontend/src
+git new-branch my-change-frontend
+popd
+```
+
+Now you go about developing your patch, and commit individually to Chromium and
+DevTools repositories. When you're done, you can upload the changes individually
+using `git cl upload`:
+
+```bash
+git cl upload
+pushd third_party/devtools-frontend/src
+git cl upload
+popd
+```
+
+The tricky part is to get the checkout back into a well-defined state, which can
+be accomplished using:
+
+```bash
+git checkout main
+git -C third_party/devtools-frontend/src checkout \
+  `gclient getdep -r src/third_party/devtools-frontend/src`
+gclient sync
+```
+
+When you need to rebase your changes, also make sure to run the above commands
+and afterwards rebase the changes in the repositories separately:
+
+```bash
+git checkout my-change-backend
+git rebase
+pushd third_party/devtools-frontend/src
+git checkout my-change-frontend
+git rebase
+popd
+```
+
 ## Integrated checkout
 
 **This solution is experimental, please report any trouble that you run into!**
 
-The integrated workflow offers the best of both worlds, and allows for working on both Chromium and DevTools frontend
-side-by-side. This is strongly recommended for folks working primarily on DevTools.
+The integrated workflow offers the best of both worlds, and allows for working
+on both Chromium and DevTools frontend side-by-side.
 
-This workflow will ensure that your local setup is equivalent to how Chromium infrastructure tests your change.
-
-A full [Chromium checkout](#Chromium-checkout) is a pre-requisite for the following steps.
+A full [Chromium checkout](#Chromium-checkout) is a pre-requisite for the
+following steps.
 
 ### Untrack the existing devtools-frontend submodule
 
@@ -326,12 +435,6 @@ In the `custom_deps` section, insert this line:
 "src/third_party/devtools-frontend/src": None,
 ```
 
-Following this step, there are two approaches to manage your standalone checkout
-
-### Single gclient project
-
-**Note: it's not possible anymore to manage the two projects in separate gclient projects.**
-
 For the integrated checkout, create a single gclient project that automatically gclient sync's all dependencies for both
 repositories. After checking out chromium, modify the .gclient file for `chromium/src` to add the DevTools project:
 
@@ -363,27 +466,3 @@ ln -s src/third_party/devtools-frontend/src devtools-frontend
 If you did run `gclient sync` first, remove the devtools-frontend directory and start over.
 
 Run `gclient sync` after creating the link to fetch the dependencies for the standalone checkout.
-
-## Chromium checkout
-
-DevTools frontend can also be developed as part of the full Chromium checkout.
-This workflow can be used to make small patches to DevTools as a Chromium engineer.
-However, it is different to our infrastructure setup and how to execute general maintenance work, and therefore discouraged.
-
-### Checking out source
-
-Follow [instructions](https://www.chromium.org/developers/how-tos/get-the-code) to check out Chromium. DevTools frontend can be found under `third_party/devtools-frontend/src/`.
-
-### Build
-
-Refer to [instructions](https://www.chromium.org/developers/how-tos/get-the-code) to build Chromium.
-To only build DevTools frontend, use `devtools_frontend_resources` as build target.
-The resulting build artifacts for DevTools frontend can be found in `out/Default/gen/third_party/devtools-frontend/src/front_end`.
-
-### Run
-
-Run Chrome with bundled DevTools frontend:
-
-```bash
-out/Default/chrome
-```

package/front_end/core/common/Color.ts

@@ -1952,25 +1952,21 @@ export class Nickname extends ShortFormatColorBase {
 
 export class Legacy implements Color {
   readonly #rawParams: Color3D;
-  #rgbaInternal: Color4D;
+  #rgba: Color4D;
   readonly #authoredText: string|null;
-  #formatInternal: LegacyColor;
+  #format: LegacyColor;
   readonly channels: [ColorChannel, ColorChannel, ColorChannel, ColorChannel] =
       [ColorChannel.R, ColorChannel.G, ColorChannel.B, ColorChannel.ALPHA];
 
   static readonly #conversions: ColorConversions<Legacy> = {
-    [Format.HEX]: (self: Legacy) => new Legacy(self.#rgbaInternal, Format.HEX),
-    [Format.HEXA]: (self: Legacy) => new Legacy(self.#rgbaInternal, Format.HEXA),
-    [Format.RGB]: (self: Legacy) => new Legacy(self.#rgbaInternal, Format.RGB),
-    [Format.RGBA]: (self: Legacy) => new Legacy(self.#rgbaInternal, Format.RGBA),
-    [Format.HSL]: (self: Legacy) =>
-        new HSL(...rgbToHsl([self.#rgbaInternal[0], self.#rgbaInternal[1], self.#rgbaInternal[2]]), self.alpha),
-    [Format.HSLA]: (self: Legacy) =>
-        new HSL(...rgbToHsl([self.#rgbaInternal[0], self.#rgbaInternal[1], self.#rgbaInternal[2]]), self.alpha),
-    [Format.HWB]: (self: Legacy) =>
-        new HWB(...rgbToHwb([self.#rgbaInternal[0], self.#rgbaInternal[1], self.#rgbaInternal[2]]), self.alpha),
-    [Format.HWBA]: (self: Legacy) =>
-        new HWB(...rgbToHwb([self.#rgbaInternal[0], self.#rgbaInternal[1], self.#rgbaInternal[2]]), self.alpha),
+    [Format.HEX]: (self: Legacy) => new Legacy(self.#rgba, Format.HEX),
+    [Format.HEXA]: (self: Legacy) => new Legacy(self.#rgba, Format.HEXA),
+    [Format.RGB]: (self: Legacy) => new Legacy(self.#rgba, Format.RGB),
+    [Format.RGBA]: (self: Legacy) => new Legacy(self.#rgba, Format.RGBA),
+    [Format.HSL]: (self: Legacy) => new HSL(...rgbToHsl([self.#rgba[0], self.#rgba[1], self.#rgba[2]]), self.alpha),
+    [Format.HSLA]: (self: Legacy) => new HSL(...rgbToHsl([self.#rgba[0], self.#rgba[1], self.#rgba[2]]), self.alpha),
+    [Format.HWB]: (self: Legacy) => new HWB(...rgbToHwb([self.#rgba[0], self.#rgba[1], self.#rgba[2]]), self.alpha),
+    [Format.HWBA]: (self: Legacy) => new HWB(...rgbToHwb([self.#rgba[0], self.#rgba[1], self.#rgba[2]]), self.alpha),
     [Format.LCH]: (self: Legacy) =>
         new LCH(...ColorConverter.labToLch(...ColorConverter.xyzd50ToLab(...self.#toXyzd50())), self.alpha),
     [Format.OKLCH]: (self: Legacy) => new Oklch(...ColorConverter.xyzd50ToOklch(...self.#toXyzd50()), self.alpha),
@@ -1997,7 +1993,7 @@ export class Legacy implements Color {
   };
 
   #toXyzd50(): Color3D {
-    const [r, g, b] = this.#rgbaInternal;
+    const [r, g, b] = this.#rgba;
     return ColorConverter.srgbToXyzd50(r, g, b);
   }
 
@@ -2005,7 +2001,7 @@ export class Legacy implements Color {
     switch (this.format()) {
       case Format.HEXA:
       case Format.RGBA:
-        return this.#rgbaInternal[3];
+        return this.#rgba[3];
       default:
         return null;
     }
@@ -2022,7 +2018,7 @@ export class Legacy implements Color {
 
   shortHex(): ShortHex|null {
     for (let i = 0; i < 4; ++i) {
-      const c = Math.round(this.#rgbaInternal[i] * 255);
+      const c = Math.round(this.#rgba[i] * 255);
       // Check if the two digits of each are identical: #aabbcc => #abc
       if (c % 0x11) {
         return null;
@@ -2033,10 +2029,10 @@ export class Legacy implements Color {
 
   constructor(rgba: Color3D|Color4DOr3D, format: LegacyColor, authoredText?: string) {
     this.#authoredText = authoredText || null;
-    this.#formatInternal = format;
+    this.#format = format;
     this.#rawParams = [rgba[0], rgba[1], rgba[2]];
 
-    this.#rgbaInternal = [
+    this.#rgba = [
       clamp(rgba[0], {min: 0, max: 1}),
       clamp(rgba[1], {min: 0, max: 1}),
       clamp(rgba[2], {min: 0, max: 1}),
@@ -2099,11 +2095,11 @@ export class Legacy implements Color {
   }
 
   format(): LegacyColor {
-    return this.#formatInternal;
+    return this.#format;
   }
 
   hasAlpha(): boolean {
-    return this.#rgbaInternal[3] !== 1;
+    return this.#rgba[3] !== 1;
   }
 
   detectHEXFormat(): Format {
@@ -2115,11 +2111,11 @@ export class Legacy implements Color {
     if (format) {
       return this.as(format).asString();
     }
-    return this.#stringify(format, this.#rgbaInternal[0], this.#rgbaInternal[1], this.#rgbaInternal[2]);
+    return this.#stringify(format, this.#rgba[0], this.#rgba[1], this.#rgba[2]);
   }
   #stringify(format: LegacyColor|undefined, r: number, g: number, b: number): string {
     if (!format) {
-      format = this.#formatInternal;
+      format = this.#format;
     }
 
     function toHexValue(value: number): string {
@@ -2132,7 +2128,7 @@ export class Legacy implements Color {
       case Format.RGBA: {
         const start = Platform.StringUtilities.sprintf('rgb(%d %d %d', toRgbValue(r), toRgbValue(g), toRgbValue(b));
         if (this.hasAlpha()) {
-          return start + Platform.StringUtilities.sprintf(' / %d%)', Math.round(this.#rgbaInternal[3] * 100));
+          return start + Platform.StringUtilities.sprintf(' / %d%)', Math.round(this.#rgba[3] * 100));
         }
         return start + ')';
       }
@@ -2140,7 +2136,7 @@ export class Legacy implements Color {
       case Format.HEXA: {
         if (this.hasAlpha()) {
           return Platform.StringUtilities
-              .sprintf('#%s%s%s%s', toHexValue(r), toHexValue(g), toHexValue(b), toHexValue(this.#rgbaInternal[3]))
+              .sprintf('#%s%s%s%s', toHexValue(r), toHexValue(g), toHexValue(b), toHexValue(this.#rgba[3]))
               .toLowerCase();
         }
         return Platform.StringUtilities.sprintf('#%s%s%s', toHexValue(r), toHexValue(g), toHexValue(b)).toLowerCase();
@@ -2162,20 +2158,20 @@ export class Legacy implements Color {
   }
   isGamutClipped(): boolean {
     return !equals(
-        this.#rawParams.map(toRgbValue),
-        [this.#rgbaInternal[0], this.#rgbaInternal[1], this.#rgbaInternal[2]].map(toRgbValue), WIDE_RANGE_EPSILON);
+        this.#rawParams.map(toRgbValue), [this.#rgba[0], this.#rgba[1], this.#rgba[2]].map(toRgbValue),
+        WIDE_RANGE_EPSILON);
   }
 
   rgba(): Color4D {
-    return [...this.#rgbaInternal];
+    return [...this.#rgba];
   }
 
   canonicalRGBA(): Color4D {
     const rgba = new Array(4);
     for (let i = 0; i < 3; ++i) {
-      rgba[i] = Math.round(this.#rgbaInternal[i] * 255);
+      rgba[i] = Math.round(this.#rgba[i] * 255);
     }
-    rgba[3] = this.#rgbaInternal[3];
+    rgba[3] = this.#rgba[3];
     return rgba as Color4D;
   }
 
@@ -2200,10 +2196,10 @@ export class Legacy implements Color {
 
   invert(): Legacy {
     const rgba: Color4D = [0, 0, 0, 0];
-    rgba[0] = 1 - this.#rgbaInternal[0];
-    rgba[1] = 1 - this.#rgbaInternal[1];
-    rgba[2] = 1 - this.#rgbaInternal[2];
-    rgba[3] = this.#rgbaInternal[3];
+    rgba[0] = 1 - this.#rgba[0];
+    rgba[1] = 1 - this.#rgba[1];
+    rgba[2] = 1 - this.#rgba[2];
+    rgba[3] = this.#rgba[3];
     return new Legacy(rgba, Format.RGBA);
   }
 
@@ -2212,38 +2208,38 @@ export class Legacy implements Color {
    * Note: We override with an alpha of 50% to enhance the dimming effect.
    */
   grayscale(): Legacy {
-    const [r, g, b] = this.#rgbaInternal;
+    const [r, g, b] = this.#rgba;
     const gray = r * 0.299 + g * 0.587 + b * 0.114;
     return new Legacy([gray, gray, gray, 0.5], Format.RGBA);
   }
 
   setAlpha(alpha: number): Legacy {
-    const rgba: Color4D = [...this.#rgbaInternal];
+    const rgba: Color4D = [...this.#rgba];
     rgba[3] = alpha;
     return new Legacy(rgba, Format.RGBA);
   }
 
   blendWith(fgColor: Legacy): Legacy {
-    const rgba: Color4D = blendColors(fgColor.#rgbaInternal, this.#rgbaInternal);
+    const rgba: Color4D = blendColors(fgColor.#rgba, this.#rgba);
     return new Legacy(rgba, Format.RGBA);
   }
 
   blendWithAlpha(alpha: number): Legacy {
-    const rgba: Color4D = [...this.#rgbaInternal];
+    const rgba: Color4D = [...this.#rgba];
     rgba[3] *= alpha;
     return new Legacy(rgba, Format.RGBA);
   }
 
   setFormat(format: LegacyColor): void {
-    this.#formatInternal = format;
+    this.#format = format;
   }
 
   equal(other: Color): boolean {
-    const legacy = other.as(this.#formatInternal);
-    return equals(toRgbValue(this.#rgbaInternal[0]), toRgbValue(legacy.#rgbaInternal[0]), WIDE_RANGE_EPSILON) &&
-        equals(toRgbValue(this.#rgbaInternal[1]), toRgbValue(legacy.#rgbaInternal[1]), WIDE_RANGE_EPSILON) &&
-        equals(toRgbValue(this.#rgbaInternal[2]), toRgbValue(legacy.#rgbaInternal[2]), WIDE_RANGE_EPSILON) &&
-        equals(this.#rgbaInternal[3], legacy.#rgbaInternal[3]);
+    const legacy = other.as(this.#format);
+    return equals(toRgbValue(this.#rgba[0]), toRgbValue(legacy.#rgba[0]), WIDE_RANGE_EPSILON) &&
+        equals(toRgbValue(this.#rgba[1]), toRgbValue(legacy.#rgba[1]), WIDE_RANGE_EPSILON) &&
+        equals(toRgbValue(this.#rgba[2]), toRgbValue(legacy.#rgba[2]), WIDE_RANGE_EPSILON) &&
+        equals(this.#rgba[3], legacy.#rgba[3]);
   }
 }
 

package/front_end/core/common/Console.ts

@@ -8,13 +8,13 @@ import {reveal} from './Revealer.js';
 let consoleInstance: Console|undefined;
 
 export class Console extends ObjectWrapper<EventTypes> {
-  readonly #messagesInternal: Message[];
+  readonly #messages: Message[];
   /**
    * Instantiable via the instance() factory below.
    */
   constructor() {
     super();
-    this.#messagesInternal = [];
+    this.#messages = [];
   }
 
   static instance(opts?: {forceNew: boolean}): Console {
@@ -39,7 +39,7 @@ export class Console extends ObjectWrapper<EventTypes> {
    */
   addMessage(text: string, level = MessageLevel.INFO, show = false, source?: FrontendMessageSource): void {
     const message = new Message(text, level, Date.now(), show, source);
-    this.#messagesInternal.push(message);
+    this.#messages.push(message);
     this.dispatchEventToListeners(Events.MESSAGE_ADDED, message);
   }
 
@@ -62,7 +62,7 @@ export class Console extends ObjectWrapper<EventTypes> {
   }
 
   messages(): Message[] {
-    return this.#messagesInternal;
+    return this.#messages;
   }
 
   show(): void {

package/front_end/core/common/ParsedURL.ts

@@ -95,8 +95,8 @@ export class ParsedURL {
   folderPathComponents: string;
   lastPathComponent: string;
   readonly blobInnerScheme: string|undefined;
-  #displayNameInternal?: string;
-  #dataURLDisplayNameInternal?: string;
+  #displayName?: string;
+  #dataURLDisplayName?: string;
 
   constructor(url: string) {
     this.isValid = false;
@@ -494,8 +494,8 @@ export class ParsedURL {
   }
 
   get displayName(): string {
-    if (this.#displayNameInternal) {
-      return this.#displayNameInternal;
+    if (this.#displayName) {
+      return this.#displayName;
     }
 
     if (this.isDataURL()) {
@@ -508,25 +508,25 @@ export class ParsedURL {
       return this.url;
     }
 
-    this.#displayNameInternal = this.lastPathComponent;
-    if (!this.#displayNameInternal) {
-      this.#displayNameInternal = (this.host || '') + '/';
+    this.#displayName = this.lastPathComponent;
+    if (!this.#displayName) {
+      this.#displayName = (this.host || '') + '/';
     }
-    if (this.#displayNameInternal === '/') {
-      this.#displayNameInternal = this.url;
+    if (this.#displayName === '/') {
+      this.#displayName = this.url;
     }
-    return this.#displayNameInternal;
+    return this.#displayName;
   }
 
   dataURLDisplayName(): string {
-    if (this.#dataURLDisplayNameInternal) {
-      return this.#dataURLDisplayNameInternal;
+    if (this.#dataURLDisplayName) {
+      return this.#dataURLDisplayName;
     }
     if (!this.isDataURL()) {
       return '';
     }
-    this.#dataURLDisplayNameInternal = Platform.StringUtilities.trimEndWithMaxLength(this.url, 20);
-    return this.#dataURLDisplayNameInternal;
+    this.#dataURLDisplayName = Platform.StringUtilities.trimEndWithMaxLength(this.url, 20);
+    return this.#dataURLDisplayName;
   }
 
   isAboutBlank(): boolean {

package/front_end/core/common/ResourceType.ts

@@ -159,17 +159,17 @@ const str_ = i18n.i18n.registerUIStrings('core/common/ResourceType.ts', UIString
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export class ResourceType {
-  readonly #nameInternal: string;
-  readonly #titleInternal: () => Platform.UIString.LocalizedString;
-  readonly #categoryInternal: ResourceCategory;
-  readonly #isTextTypeInternal: boolean;
+  readonly #name: string;
+  readonly #title: () => Platform.UIString.LocalizedString;
+  readonly #category: ResourceCategory;
+  readonly #isTextType: boolean;
 
   constructor(
       name: string, title: () => Platform.UIString.LocalizedString, category: ResourceCategory, isTextType: boolean) {
-    this.#nameInternal = name;
-    this.#titleInternal = title;
-    this.#categoryInternal = category;
-    this.#isTextTypeInternal = isTextType;
+    this.#name = name;
+    this.#title = title;
+    this.#category = category;
+    this.#isTextType = isTextType;
   }
 
   static fromMimeType(mimeType: string|null): ResourceType {
@@ -286,23 +286,23 @@ export class ResourceType {
   }
 
   name(): string {
-    return this.#nameInternal;
+    return this.#name;
   }
 
   title(): string {
-    return this.#titleInternal();
+    return this.#title();
   }
 
   category(): ResourceCategory {
-    return this.#categoryInternal;
+    return this.#category;
   }
 
   isTextType(): boolean {
-    return this.#isTextTypeInternal;
+    return this.#isTextType;
   }
 
   isScript(): boolean {
-    return this.#nameInternal === 'script' || this.#nameInternal === 'sm-script';
+    return this.#name === 'script' || this.#name === 'sm-script';
   }
 
   hasScripts(): boolean {
@@ -310,7 +310,7 @@ export class ResourceType {
   }
 
   isStyleSheet(): boolean {
-    return this.#nameInternal === 'stylesheet' || this.#nameInternal === 'sm-stylesheet';
+    return this.#name === 'stylesheet' || this.#name === 'sm-stylesheet';
   }
 
   hasStyleSheets(): boolean {
@@ -318,7 +318,7 @@ export class ResourceType {
   }
 
   isDocument(): boolean {
-    return this.#nameInternal === 'document';
+    return this.#name === 'document';
   }
 
   isDocumentOrScriptOrStyleSheet(): boolean {
@@ -326,23 +326,23 @@ export class ResourceType {
   }
 
   isFont(): boolean {
-    return this.#nameInternal === 'font';
+    return this.#name === 'font';
   }
 
   isImage(): boolean {
-    return this.#nameInternal === 'image';
+    return this.#name === 'image';
   }
 
   isFromSourceMap(): boolean {
-    return this.#nameInternal.startsWith('sm-');
+    return this.#name.startsWith('sm-');
   }
 
   isWebbundle(): boolean {
-    return this.#nameInternal === 'webbundle';
+    return this.#name === 'webbundle';
   }
 
   toString(): string {
-    return this.#nameInternal;
+    return this.#name;
   }
 
   canonicalMimeType(): string {