chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/front_end/panels/common/GdpSignUpDialog.ts

@@ -3,9 +3,11 @@
 // found in the LICENSE file.
 import '../../ui/components/switch/switch.js';
 
+import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
+import * as Badges from '../../models/badges/badges.js';
 import * as Geometry from '../../models/geometry/geometry.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as Snackbars from '../../ui/components/snackbars/snackbars.js';
@@ -200,6 +202,9 @@ export class GdpSignUpDialog extends UI.Widget.VBox {
         this.#keepMeUpdated ? Host.GdpClient.EmailPreference.ENABLED : Host.GdpClient.EmailPreference.DISABLED;
     const result = await Host.GdpClient.GdpClient.instance().createProfile({user, emailPreference});
     if (result) {
+      Common.Settings.Settings.instance().moduleSetting('receive-gdp-badges').set(true);
+      await Badges.UserBadges.instance().initialize();
+      Badges.UserBadges.instance().recordAction(Badges.BadgeAction.GDP_SIGN_UP_COMPLETE);
       this.#dialog.hide();
     } else {
       Snackbars.Snackbar.Snackbar.show({message: i18nString(UIStrings.signUpFailed)}, this.#dialog.contentElement);

package/front_end/panels/common/badgeNotification.css

@@ -16,37 +16,54 @@
 
   .container {
     display: flex;
-    flex-direction: column;
-    align-items: flex-start;
+    align-items: center;
     overflow: hidden;
-    width: var(--sys-size-33);
+    width: 485px;
     background: var(--sys-color-inverse-surface);
     box-shadow: var(--sys-elevation-level3);
     border-radius: var(--sys-shape-corner-small);
-    font: var(--sys-typescale-body4-medium);
+    font: var(--sys-typescale-body4-regular);
     animation: slideIn 100ms cubic-bezier(0, 0, 0.3, 1);
     box-sizing: border-box;
     max-width: 100%;
     padding: var(--sys-size-5) var(--sys-size-6) var(--sys-size-6) var(--sys-size-6);
   }
 
+  .action-and-text-container {
+    display: flex;
+    flex-direction: column;
+    gap: var(--sys-size-3);
+  }
+
   .long-action-container {
     margin-left: auto;
+    /*
+    * Buttons have a 24px total height, which includes padding for the hover area.
+    * We apply a -3px vertical margin to compensate for this extra space.
+    * This ensures the component aligns based on the visual text height,
+    * not the full clickable bounding box.
+    */
+    margin-block: -3px;
   }
 
   .label-container {
     display: flex;
     width: 100%;
     align-items: center;
-    gap: var(--sys-size-5);
+    padding-block: var(--sys-size-3);
+    line-height: 18px;
+  }
+
+  .badge-container {
+    margin-right: 10px;
+    min-width: 64px;
+    height: 64px;
   }
 
   .badge-image {
-    margin-right: var(--sys-size-6);
-    width: 42px;
-    height: 42px;
+    width: 100%;
+    height: 100%;
     border-radius: var(--sys-shape-corner-full);
-    background: var(--sys-color-surface);
   }
 
   .badge-link {

package/front_end/panels/console/ConsoleContextSelector.ts

@@ -32,19 +32,19 @@ export class ConsoleContextSelector implements SDK.TargetManager.SDKModelObserve
                                                UI.SoftDropDown.Delegate<SDK.RuntimeModel.ExecutionContext> {
   readonly items: UI.ListModel.ListModel<SDK.RuntimeModel.ExecutionContext>;
   private readonly dropDown: UI.SoftDropDown.SoftDropDown<SDK.RuntimeModel.ExecutionContext>;
-  private readonly toolbarItemInternal: UI.Toolbar.ToolbarItem;
+  readonly #toolbarItem: UI.Toolbar.ToolbarItem;
 
   constructor() {
     this.items = new UI.ListModel.ListModel();
     this.dropDown = new UI.SoftDropDown.SoftDropDown(this.items, this, 'javascript-context');
     this.dropDown.setRowHeight(36);
-    this.toolbarItemInternal = new UI.Toolbar.ToolbarItem(this.dropDown.element);
-    this.toolbarItemInternal.setEnabled(false);
-    this.toolbarItemInternal.setTitle(i18nString(UIStrings.javascriptContextNotSelected));
+    this.#toolbarItem = new UI.Toolbar.ToolbarItem(this.dropDown.element);
+    this.#toolbarItem.setEnabled(false);
+    this.#toolbarItem.setTitle(i18nString(UIStrings.javascriptContextNotSelected));
     this.items.addEventListener(
-        UI.ListModel.Events.ITEMS_REPLACED, () => this.toolbarItemInternal.setEnabled(Boolean(this.items.length)));
+        UI.ListModel.Events.ITEMS_REPLACED, () => this.#toolbarItem.setEnabled(Boolean(this.items.length)));
 
-    this.toolbarItemInternal.element.classList.add('toolbar-has-dropdown');
+    this.#toolbarItem.element.classList.add('toolbar-has-dropdown');
 
     SDK.TargetManager.TargetManager.instance().addModelListener(
         SDK.RuntimeModel.RuntimeModel, SDK.RuntimeModel.Events.ExecutionContextCreated, this.onExecutionContextCreated,
@@ -70,7 +70,7 @@ export class ConsoleContextSelector implements SDK.TargetManager.SDKModelObserve
   }
 
   toolbarItem(): UI.Toolbar.ToolbarItem {
-    return this.toolbarItemInternal;
+    return this.#toolbarItem;
   }
 
   highlightedItemChanged(
@@ -256,10 +256,10 @@ export class ConsoleContextSelector implements SDK.TargetManager.SDKModelObserve
   }
 
   itemSelected(item: SDK.RuntimeModel.ExecutionContext|null): void {
-    this.toolbarItemInternal.element.classList.toggle('highlight', !this.isTopContext(item) && this.hasTopContext());
+    this.#toolbarItem.element.classList.toggle('highlight', !this.isTopContext(item) && this.hasTopContext());
     const title = item ? i18nString(UIStrings.javascriptContextS, {PH1: this.titleFor(item)}) :
                          i18nString(UIStrings.javascriptContextNotSelected);
-    this.toolbarItemInternal.setTitle(title);
+    this.#toolbarItem.setTitle(title);
     UI.Context.Context.instance().setFlavor(SDK.RuntimeModel.ExecutionContext, item);
   }
 

package/front_end/panels/console/ConsolePrompt.ts

@@ -48,7 +48,7 @@ const AI_CODE_COMPLETION_CHARACTER_LIMIT = 20_000;
 export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, typeof UI.Widget.Widget>(
     UI.Widget.Widget) {
   private addCompletionsFromHistory: boolean;
-  private historyInternal: TextEditor.AutocompleteHistory.AutocompleteHistory;
+  #history: TextEditor.AutocompleteHistory.AutocompleteHistory;
   private initialText: string;
   private editor: TextEditor.TextEditor.TextEditor;
   private readonly eagerPreviewElement: HTMLDivElement;
@@ -109,7 +109,7 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
     });
     this.registerRequiredCSS(consolePromptStyles);
     this.addCompletionsFromHistory = true;
-    this.historyInternal = new TextEditor.AutocompleteHistory.AutocompleteHistory(
+    this.#history = new TextEditor.AutocompleteHistory.AutocompleteHistory(
         Common.Settings.Settings.instance().createLocalSetting('console-history', []));
 
     this.initialText = '';
@@ -186,7 +186,7 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
       }
     });
     editorContainerElement.appendChild(this.editor);
-    this.#editorHistory = new TextEditor.TextEditorHistory.TextEditorHistory(this.editor, this.historyInternal);
+    this.#editorHistory = new TextEditor.TextEditorHistory.TextEditorHistory(this.editor, this.#history);
 
     if (this.hasFocus()) {
       this.focus();
@@ -244,6 +244,9 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
     const cursor = selection.main.head;
     const currentExecutionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
     let prefix = query.substring(0, cursor);
+    if (prefix.trim().length === 0) {
+      return;
+    }
     if (currentExecutionContext) {
       const consoleModel = currentExecutionContext.target().model(SDK.ConsoleModel.ConsoleModel);
       if (consoleModel) {
@@ -307,7 +310,7 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
   }
 
   history(): TextEditor.AutocompleteHistory.AutocompleteHistory {
-    return this.historyInternal;
+    return this.#history;
   }
 
   clearAutocomplete(): void {
@@ -526,7 +529,7 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
       this.teaser = undefined;
     }
     this.aiCodeCompletion = new AiCodeCompletion.AiCodeCompletion.AiCodeCompletion(
-        {aidaClient: this.aidaClient}, this.editor, AiCodeCompletion.AiCodeCompletion.Panel.CONSOLE);
+        {aidaClient: this.aidaClient}, this.editor, AiCodeCompletion.AiCodeCompletion.Panel.CONSOLE, ['\n\n']);
     this.aiCodeCompletion.addEventListener(AiCodeCompletion.AiCodeCompletion.Events.RESPONSE_RECEIVED, event => {
       this.aiCodeCompletionCitations = event.data.citations;
       this.dispatchEventToListeners(Events.AI_CODE_COMPLETION_RESPONSE_RECEIVED, event.data);

package/front_end/panels/console/ConsoleView.ts

@@ -275,7 +275,7 @@ const CITATIONS_TOOLTIP_ID = 'console-ai-code-completion-citations-tooltip';
 export class ConsoleView extends UI.Widget.VBox implements
     UI.SearchableView.Searchable, ConsoleViewportProvider,
     SDK.TargetManager.SDKModelObserver<SDK.ConsoleModel.ConsoleModel> {
-  private readonly searchableViewInternal: UI.SearchableView.SearchableView;
+  readonly #searchableView: UI.SearchableView.SearchableView;
   private readonly sidebar: ConsoleSidebar;
   private isSidebarOpen: boolean;
   private filter: ConsoleViewFilter;
@@ -343,10 +343,10 @@ export class ConsoleView extends UI.Widget.VBox implements
     this.setMinimumSize(0, 35);
     this.registerRequiredCSS(consoleViewStyles, objectValueStyles, CodeHighlighter.codeHighlighterStyles);
 
-    this.searchableViewInternal = new UI.SearchableView.SearchableView(this, null);
-    this.searchableViewInternal.element.classList.add('console-searchable-view');
-    this.searchableViewInternal.setPlaceholder(i18nString(UIStrings.findStringInLogs));
-    this.searchableViewInternal.setMinimalSearchQuerySize(0);
+    this.#searchableView = new UI.SearchableView.SearchableView(this, null);
+    this.#searchableView.element.classList.add('console-searchable-view');
+    this.#searchableView.setPlaceholder(i18nString(UIStrings.findStringInLogs));
+    this.#searchableView.setMinimalSearchQuerySize(0);
     this.sidebar = new ConsoleSidebar();
     this.sidebar.addEventListener(Events.FILTER_SELECTED, this.onFilterChanged.bind(this));
     this.isSidebarOpen = false;
@@ -356,7 +356,7 @@ export class ConsoleView extends UI.Widget.VBox implements
     this.consoleToolbarContainer.role = 'toolbar';
     this.splitWidget = new UI.SplitWidget.SplitWidget(
         true /* isVertical */, false /* secondIsSidebar */, 'console.sidebar.width', 100);
-    this.splitWidget.setMainWidget(this.searchableViewInternal);
+    this.splitWidget.setMainWidget(this.#searchableView);
     this.splitWidget.setSidebarWidget(this.sidebar);
     this.splitWidget.show(this.element);
     this.splitWidget.hideSidebar();
@@ -387,7 +387,7 @@ export class ConsoleView extends UI.Widget.VBox implements
       this.filter.setLevelMenuOverridden(this.isSidebarOpen);
       this.onFilterChanged();
     });
-    this.contentsElement = this.searchableViewInternal.element;
+    this.contentsElement = this.#searchableView.element;
     this.element.classList.add('console-view');
 
     this.visibleViewMessages = [];
@@ -695,7 +695,7 @@ export class ConsoleView extends UI.Widget.VBox implements
   }
 
   searchableView(): UI.SearchableView.SearchableView {
-    return this.searchableViewInternal;
+    return this.#searchableView;
   }
 
   clearHistory(): void {
@@ -962,7 +962,7 @@ export class ConsoleView extends UI.Widget.VBox implements
           viewMessage,
           !shouldGroupSimilar /* crbug.com/1082963: prevent collapse of same messages when "Group similar" is false */);
       this.updateFilterStatus();
-      this.searchableViewInternal.updateSearchMatchesCount(this.regexMatchRanges.length);
+      this.#searchableView.updateSearchMatchesCount(this.regexMatchRanges.length);
     } else {
       this.needsFullUpdate = true;
     }
@@ -1318,7 +1318,7 @@ export class ConsoleView extends UI.Widget.VBox implements
       }
     }
     this.updateFilterStatus();
-    this.searchableViewInternal.updateSearchMatchesCount(this.regexMatchRanges.length);
+    this.#searchableView.updateSearchMatchesCount(this.regexMatchRanges.length);
     this.jumpToMatch(this.currentMatchRangeIndex);  // Re-highlight current match.
     this.viewport.invalidate();
     this.messagesCountElement.setAttribute(
@@ -1507,7 +1507,7 @@ export class ConsoleView extends UI.Widget.VBox implements
 
   performSearch(searchConfig: UI.SearchableView.SearchConfig, shouldJump: boolean, jumpBackwards?: boolean): void {
     this.onSearchCanceled();
-    this.searchableViewInternal.updateSearchMatchesCount(0);
+    this.#searchableView.updateSearchMatchesCount(0);
 
     this.searchRegex = searchConfig.toSearchRegex(true).regex;
 
@@ -1554,7 +1554,7 @@ export class ConsoleView extends UI.Widget.VBox implements
       this.searchMessage(index);
     }
 
-    this.searchableViewInternal.updateSearchMatchesCount(this.regexMatchRanges.length);
+    this.#searchableView.updateSearchMatchesCount(this.regexMatchRanges.length);
     if (typeof this.searchShouldJumpBackwards !== 'undefined' && this.regexMatchRanges.length) {
       this.jumpToMatch(this.searchShouldJumpBackwards ? -1 : 0);
       delete this.searchShouldJumpBackwards;
@@ -1611,7 +1611,7 @@ export class ConsoleView extends UI.Widget.VBox implements
 
     index = Platform.NumberUtilities.mod(index, this.regexMatchRanges.length);
     this.currentMatchRangeIndex = index;
-    this.searchableViewInternal.updateCurrentMatchIndex(index);
+    this.#searchableView.updateCurrentMatchIndex(index);
     matchRange = this.regexMatchRanges[index];
     const message = this.visibleViewMessages[matchRange.messageIndex];
     const highlightNode = message.searchHighlightNode(matchRange.matchIndex);

package/front_end/panels/console/ConsoleViewport.ts

@@ -45,7 +45,7 @@ export class ConsoleViewport {
   element: HTMLElement;
   private topGapElement: HTMLElement;
   private topGapElementActive: boolean;
-  private contentElementInternal: HTMLElement;
+  #contentElement: HTMLElement;
   private bottomGapElement: HTMLElement;
   private bottomGapElementActive: boolean;
   private provider: ConsoleViewportProvider;
@@ -63,7 +63,7 @@ export class ConsoleViewport {
     childList: boolean,
     subtree: boolean,
   };
-  private stickToBottomInternal: boolean;
+  #stickToBottom: boolean;
   private selectionIsBackward: boolean;
   private lastSelectedElement?: HTMLElement|null;
   private cachedProviderElements?: Array<ConsoleViewportElement|null>;
@@ -75,7 +75,7 @@ export class ConsoleViewport {
     this.topGapElement.style.height = '0px';
     this.topGapElement.style.color = 'transparent';
     this.topGapElementActive = false;
-    this.contentElementInternal = this.element.createChild('div');
+    this.#contentElement = this.element.createChild('div');
     this.bottomGapElement = this.element.createChild('div');
     this.bottomGapElement.style.height = '0px';
     this.bottomGapElement.style.color = 'transparent';
@@ -93,11 +93,11 @@ export class ConsoleViewport {
     this.element.addEventListener('scroll', this.onScroll.bind(this), false);
     this.element.addEventListener('copy', (this.onCopy.bind(this) as EventListener), false);
     this.element.addEventListener('dragstart', (this.onDragStart.bind(this) as (arg0: Event) => unknown), false);
-    this.contentElementInternal.addEventListener('focusin', (this.onFocusIn.bind(this) as EventListener), false);
-    this.contentElementInternal.addEventListener('focusout', (this.onFocusOut.bind(this) as EventListener), false);
-    this.contentElementInternal.addEventListener('keydown', (this.onKeyDown.bind(this) as EventListener), false);
+    this.#contentElement.addEventListener('focusin', (this.onFocusIn.bind(this) as EventListener), false);
+    this.#contentElement.addEventListener('focusout', (this.onFocusOut.bind(this) as EventListener), false);
+    this.#contentElement.addEventListener('keydown', (this.onKeyDown.bind(this) as EventListener), false);
     this.virtualSelectedIndex = -1;
-    this.contentElementInternal.tabIndex = -1;
+    this.#contentElement.tabIndex = -1;
 
     this.firstActiveIndex = -1;
     this.lastActiveIndex = -1;
@@ -113,18 +113,18 @@ export class ConsoleViewport {
     // if they change the scroll height.
     this.observer = new MutationObserver(this.refresh.bind(this));
     this.observerConfig = {childList: true, subtree: true};
-    this.stickToBottomInternal = false;
+    this.#stickToBottom = false;
     this.selectionIsBackward = false;
   }
 
   stickToBottom(): boolean {
-    return this.stickToBottomInternal;
+    return this.#stickToBottom;
   }
 
   setStickToBottom(value: boolean): void {
-    this.stickToBottomInternal = value;
-    if (this.stickToBottomInternal) {
-      this.observer.observe(this.contentElementInternal, this.observerConfig);
+    this.#stickToBottom = value;
+    if (this.#stickToBottom) {
+      this.observer.observe(this.#contentElement, this.observerConfig);
     } else {
       this.observer.disconnect();
     }
@@ -168,7 +168,7 @@ export class ConsoleViewport {
     let focusLastChild = false;
     // Make default selection when moving from external (e.g. prompt) to the container.
     if (this.virtualSelectedIndex === -1 && this.isOutsideViewport((event.relatedTarget as Element | null)) &&
-        event.target === this.contentElementInternal && this.itemCount) {
+        event.target === this.#contentElement && this.itemCount) {
       focusLastChild = true;
       this.virtualSelectedIndex = this.itemCount - 1;
 
@@ -187,7 +187,7 @@ export class ConsoleViewport {
   }
 
   private isOutsideViewport(element: Element|null): boolean {
-    return element !== null && !element.isSelfOrDescendant(this.contentElementInternal);
+    return element !== null && !element.isSelfOrDescendant(this.#contentElement);
   }
 
   private onDragStart(event: DragEvent): boolean {
@@ -242,7 +242,7 @@ export class ConsoleViewport {
     const selectedElement = this.renderedElementAt(this.virtualSelectedIndex);
     const changed = this.lastSelectedElement !== selectedElement;
     const containerHasFocus =
-        this.contentElementInternal === Platform.DOMUtilities.deepActiveElement(this.element.ownerDocument);
+        this.#contentElement === Platform.DOMUtilities.deepActiveElement(this.element.ownerDocument);
     if (this.lastSelectedElement && changed) {
       this.lastSelectedElement.classList.remove('console-selected');
     }
@@ -260,16 +260,16 @@ export class ConsoleViewport {
         selectedElement.focus({preventScroll: true});
       }
     }
-    if (this.itemCount && !this.contentElementInternal.hasFocus()) {
-      this.contentElementInternal.tabIndex = 0;
+    if (this.itemCount && !this.#contentElement.hasFocus()) {
+      this.#contentElement.tabIndex = 0;
     } else {
-      this.contentElementInternal.tabIndex = -1;
+      this.#contentElement.tabIndex = -1;
     }
     this.lastSelectedElement = selectedElement;
   }
 
   contentElement(): Element {
-    return this.contentElementInternal;
+    return this.#contentElement;
   }
 
   invalidate(): void {
@@ -462,8 +462,8 @@ export class ConsoleViewport {
   refresh(): void {
     this.observer.disconnect();
     this.innerRefresh();
-    if (this.stickToBottomInternal) {
-      this.observer.observe(this.contentElementInternal, this.observerConfig);
+    if (this.#stickToBottom) {
+      this.observer.observe(this.#contentElement, this.observerConfig);
     }
   }
 
@@ -477,7 +477,7 @@ export class ConsoleViewport {
         this.renderedItems[i].willHide();
       }
       this.renderedItems = [];
-      this.contentElementInternal.removeChildren();
+      this.#contentElement.removeChildren();
       this.topGapElement.style.height = '0px';
       this.bottomGapElement.style.height = '0px';
       this.firstActiveIndex = -1;
@@ -497,7 +497,7 @@ export class ConsoleViewport {
     // When the viewport is scrolled to the bottom, using the cumulative heights estimate is not
     // precise enough to determine next visible indices. This stickToBottom check avoids extra
     // calls to refresh in those cases.
-    if (this.stickToBottomInternal) {
+    if (this.#stickToBottom) {
       this.firstActiveIndex = Math.max(this.itemCount - Math.ceil(activeHeight / this.provider.minimumRowHeight()), 0);
       this.lastActiveIndex = this.itemCount - 1;
     } else {
@@ -520,16 +520,16 @@ export class ConsoleViewport {
       this.bottomGapElement.style.height = bottomGapHeight + 'px';
       this.topGapElementActive = Boolean(topGapHeight);
       this.bottomGapElementActive = Boolean(bottomGapHeight);
-      this.contentElementInternal.style.setProperty('height', '10000000px');
+      this.#contentElement.style.setProperty('height', '10000000px');
     }
 
     this.partialViewportUpdate(prepare.bind(this));
-    this.contentElementInternal.style.removeProperty('height');
+    this.#contentElement.style.removeProperty('height');
     // Should be the last call in the method as it might force layout.
     if (shouldRestoreSelection) {
       this.restoreSelection(selection);
     }
-    if (this.stickToBottomInternal) {
+    if (this.#stickToBottom) {
       this.element.scrollTop = 10000000;
     }
   }
@@ -555,7 +555,7 @@ export class ConsoleViewport {
     }
 
     const wasShown = [];
-    let anchor: (ChildNode|null) = this.contentElementInternal.firstChild;
+    let anchor: (ChildNode|null) = this.#contentElement.firstChild;
     for (const viewportElement of itemsToRender) {
       const element = viewportElement.element();
       if (element !== anchor) {
@@ -563,7 +563,7 @@ export class ConsoleViewport {
         if (shouldCallWasShown) {
           wasShown.push(viewportElement);
         }
-        this.contentElementInternal.insertBefore(element, anchor);
+        this.#contentElement.insertBefore(element, anchor);
       } else {
         anchor = anchor.nextSibling;
       }
@@ -574,7 +574,7 @@ export class ConsoleViewport {
     this.renderedItems = Array.from(itemsToRender);
 
     if (hadFocus) {
-      this.contentElementInternal.focus();
+      this.#contentElement.focus();
     }
     this.updateFocusedItem();
   }

package/front_end/panels/coverage/CoverageModel.ts

@@ -674,48 +674,48 @@ function locationCompare(a: string, b: string): number {
 }
 
 export class URLCoverageInfo extends Common.ObjectWrapper.ObjectWrapper<URLCoverageInfo.EventTypes> {
-  private readonly urlInternal: Platform.DevToolsPath.UrlString;
+  readonly #url: Platform.DevToolsPath.UrlString;
   private coverageInfoByLocation: Map<string, CoverageInfo>;
-  private sizeInternal: number;
-  private usedSizeInternal: number;
-  private typeInternal!: CoverageType;
-  private isContentScriptInternal: boolean;
+  #size: number;
+  #usedSize: number;
+  #type!: CoverageType;
+  #isContentScript: boolean;
   sourcesURLCoverageInfo = new Map<Platform.DevToolsPath.UrlString, SourceURLCoverageInfo>();
   sourceSegments: SourceSegment[]|undefined;
 
   constructor(url: Platform.DevToolsPath.UrlString) {
     super();
 
-    this.urlInternal = url;
+    this.#url = url;
     this.coverageInfoByLocation = new Map();
-    this.sizeInternal = 0;
-    this.usedSizeInternal = 0;
-    this.isContentScriptInternal = false;
+    this.#size = 0;
+    this.#usedSize = 0;
+    this.#isContentScript = false;
   }
 
   url(): Platform.DevToolsPath.UrlString {
-    return this.urlInternal;
+    return this.#url;
   }
 
   type(): CoverageType {
-    return this.typeInternal;
+    return this.#type;
   }
 
   size(): number {
-    return this.sizeInternal;
+    return this.#size;
   }
 
   usedSize(): number {
-    return this.usedSizeInternal;
+    return this.#usedSize;
   }
 
   unusedSize(): number {
-    return this.sizeInternal - this.usedSizeInternal;
+    return this.#size - this.#usedSize;
   }
 
   usedPercentage(): number {
     // Per convention, empty files are reported as 100 % uncovered
-    if (this.sizeInternal === 0) {
+    if (this.#size === 0) {
       return 0;
     }
     if (!this.unusedSize() || !this.size()) {
@@ -726,14 +726,14 @@ export class URLCoverageInfo extends Common.ObjectWrapper.ObjectWrapper<URLCover
 
   unusedPercentage(): number {
     // Per convention, empty files are reported as 100 % uncovered
-    if (this.sizeInternal === 0) {
+    if (this.#size === 0) {
       return 1;
     }
     return this.unusedSize() / this.size();
   }
 
   isContentScript(): boolean {
-    return this.isContentScriptInternal;
+    return this.#isContentScript;
   }
 
   entries(): IterableIterator<CoverageInfo> {
@@ -752,8 +752,8 @@ export class URLCoverageInfo extends Common.ObjectWrapper.ObjectWrapper<URLCover
   }
 
   addToSizes(usedSize: number, size: number): void {
-    this.usedSizeInternal += usedSize;
-    this.sizeInternal += size;
+    this.#usedSize += usedSize;
+    this.#size += size;
 
     if (usedSize !== 0 || size !== 0) {
       this.dispatchEventToListeners(URLCoverageInfo.Events.SizesChanged);
@@ -772,9 +772,9 @@ export class URLCoverageInfo extends Common.ObjectWrapper.ObjectWrapper<URLCover
 
     if ((type & CoverageType.JAVA_SCRIPT) && !this.coverageInfoByLocation.size &&
         contentProvider instanceof SDK.Script.Script) {
-      this.isContentScriptInternal = (contentProvider).isContentScript();
+      this.#isContentScript = (contentProvider).isContentScript();
     }
-    this.typeInternal |= type;
+    this.#type |= type;
 
     if (entry) {
       entry.addCoverageType(type);
@@ -783,7 +783,7 @@ export class URLCoverageInfo extends Common.ObjectWrapper.ObjectWrapper<URLCover
 
     if ((type & CoverageType.JAVA_SCRIPT) && !this.coverageInfoByLocation.size &&
         contentProvider instanceof SDK.Script.Script) {
-      this.isContentScriptInternal = (contentProvider).isContentScript();
+      this.#isContentScript = (contentProvider).isContentScript();
     }
 
     entry = new CoverageInfo(contentProvider, contentLength, lineOffset, columnOffset, type, this);

package/front_end/panels/elements/ClassesPaneWidget.ts

@@ -93,7 +93,7 @@ export class ClassesPaneWidget extends UI.Widget.Widget {
     }
 
     const eventTarget = (event.target as HTMLElement);
-    let text: ''|string = (eventTarget.textContent as string);
+    let text = eventTarget.textContent;
     if (Platform.KeyboardUtilities.isEscKey(event)) {
       if (!Platform.StringUtilities.isWhitespace(text)) {
         event.consume(true);