chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/front_end/panels/application/ApplicationPanelSidebar.ts

@@ -1048,7 +1048,7 @@ export class BackgroundServiceTreeElement extends ApplicationPanelTreeElement {
   private serviceName: Protocol.BackgroundService.ServiceName;
   private view: BackgroundServiceView|null;
   private model: BackgroundServiceModel|null;
-  private selectedInternal: boolean;
+  #selected: boolean;
 
   constructor(storagePanel: ResourcesPanel, serviceName: Protocol.BackgroundService.ServiceName) {
     super(
@@ -1058,7 +1058,7 @@ export class BackgroundServiceTreeElement extends ApplicationPanelTreeElement {
     this.serviceName = serviceName;
 
     /* Whether the element has been selected. */
-    this.selectedInternal = false;
+    this.#selected = false;
 
     this.view = null;
 
@@ -1091,7 +1091,7 @@ export class BackgroundServiceTreeElement extends ApplicationPanelTreeElement {
   initialize(model: BackgroundServiceModel|null): void {
     this.model = model;
     // Show the view if the model was initialized after selection.
-    if (this.selectedInternal && !this.view) {
+    if (this.#selected && !this.view) {
       this.onselect(false);
     }
   }
@@ -1109,7 +1109,7 @@ export class BackgroundServiceTreeElement extends ApplicationPanelTreeElement {
 
   override onselect(selectedByUser?: boolean): boolean {
     super.onselect(selectedByUser);
-    this.selectedInternal = true;
+    this.#selected = true;
 
     if (!this.model) {
       return false;
@@ -1843,30 +1843,30 @@ export class ExtensionStorageTreeParentElement extends ApplicationPanelTreeEleme
 
 export class CookieTreeElement extends ApplicationPanelTreeElement {
   private readonly target: SDK.Target.Target;
-  private readonly cookieDomainInternal: string;
+  readonly #cookieDomain: string;
 
   constructor(
       storagePanel: ResourcesPanel, frame: SDK.ResourceTreeModel.ResourceTreeFrame,
       cookieUrl: Common.ParsedURL.ParsedURL) {
     super(storagePanel, cookieUrl.securityOrigin() || i18nString(UIStrings.localFiles), false, 'cookies-for-frame');
     this.target = frame.resourceTreeModel().target();
-    this.cookieDomainInternal = cookieUrl.securityOrigin();
-    this.tooltip = i18nString(UIStrings.cookiesUsedByFramesFromS, {PH1: this.cookieDomainInternal});
+    this.#cookieDomain = cookieUrl.securityOrigin();
+    this.tooltip = i18nString(UIStrings.cookiesUsedByFramesFromS, {PH1: this.#cookieDomain});
     const icon = IconButton.Icon.create('cookie');
     // Note that we cannot use `cookieDomainInternal` here since it contains scheme.
     if (IssuesManager.RelatedIssue.hasThirdPartyPhaseoutCookieIssueForDomain(cookieUrl.domain())) {
       icon.name = 'warning-filled';
-      this.tooltip = i18nString(UIStrings.thirdPartyPhaseout, {PH1: this.cookieDomainInternal});
+      this.tooltip = i18nString(UIStrings.thirdPartyPhaseout, {PH1: this.#cookieDomain});
     }
     this.setLeadingIcons([icon]);
   }
 
   override get itemURL(): Platform.DevToolsPath.UrlString {
-    return 'cookies://' + this.cookieDomainInternal as Platform.DevToolsPath.UrlString;
+    return 'cookies://' + this.#cookieDomain as Platform.DevToolsPath.UrlString;
   }
 
   cookieDomain(): string {
-    return this.cookieDomainInternal;
+    return this.#cookieDomain;
   }
 
   override onattach(): void {
@@ -1877,14 +1877,14 @@ export class CookieTreeElement extends ApplicationPanelTreeElement {
   private handleContextMenuEvent(event: Event): void {
     const contextMenu = new UI.ContextMenu.ContextMenu(event);
     contextMenu.defaultSection().appendItem(
-        i18nString(UIStrings.clear), () => this.resourcesPanel.clearCookies(this.target, this.cookieDomainInternal),
+        i18nString(UIStrings.clear), () => this.resourcesPanel.clearCookies(this.target, this.#cookieDomain),
         {jslogContext: 'clear'});
     void contextMenu.show();
   }
 
   override onselect(selectedByUser?: boolean): boolean {
     super.onselect(selectedByUser);
-    this.resourcesPanel.showCookies(this.target, this.cookieDomainInternal);
+    this.resourcesPanel.showCookies(this.target, this.#cookieDomain);
     Host.userMetrics.panelShown(Host.UserMetrics.PanelCodes[Host.UserMetrics.PanelCodes.cookies]);
     return false;
   }

package/front_end/panels/application/DOMStorageModel.ts

@@ -38,14 +38,14 @@ import type * as Protocol from '../../generated/protocol.js';
 
 export class DOMStorage extends Common.ObjectWrapper.ObjectWrapper<DOMStorage.EventTypes> {
   private readonly model: DOMStorageModel;
-  private readonly storageKeyInternal: string;
-  private readonly isLocalStorageInternal: boolean;
+  readonly #storageKey: string;
+  readonly #isLocalStorage: boolean;
 
   constructor(model: DOMStorageModel, storageKey: string, isLocalStorage: boolean) {
     super();
     this.model = model;
-    this.storageKeyInternal = storageKey;
-    this.isLocalStorageInternal = isLocalStorage;
+    this.#storageKey = storageKey;
+    this.#isLocalStorage = isLocalStorage;
   }
 
   static storageId(storageKey: string, isLocalStorage: boolean): Protocol.DOMStorage.StorageId {
@@ -53,15 +53,15 @@ export class DOMStorage extends Common.ObjectWrapper.ObjectWrapper<DOMStorage.Ev
   }
 
   get id(): Protocol.DOMStorage.StorageId {
-    return DOMStorage.storageId(this.storageKeyInternal, this.isLocalStorageInternal);
+    return DOMStorage.storageId(this.#storageKey, this.#isLocalStorage);
   }
 
   get storageKey(): string|null {
-    return this.storageKeyInternal;
+    return this.#storageKey;
   }
 
   get isLocalStorage(): boolean {
-    return this.isLocalStorageInternal;
+    return this.#isLocalStorage;
   }
 
   getItems(): Promise<Protocol.DOMStorage.Item[]|null> {
@@ -113,16 +113,16 @@ export namespace DOMStorage {
 }
 
 export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
-  private readonly storageKeyManagerInternal: SDK.StorageKeyManager.StorageKeyManager|null;
-  private storagesInternal: Record<string, DOMStorage>;
+  readonly #storageKeyManager: SDK.StorageKeyManager.StorageKeyManager|null;
+  #storages: Record<string, DOMStorage>;
   readonly agent: ProtocolProxyApi.DOMStorageApi;
   private enabled?: boolean;
 
   constructor(target: SDK.Target.Target) {
     super(target);
 
-    this.storageKeyManagerInternal = target.model(SDK.StorageKeyManager.StorageKeyManager);
-    this.storagesInternal = {};
+    this.#storageKeyManager = target.model(SDK.StorageKeyManager.StorageKeyManager);
+    this.#storages = {};
     this.agent = target.domstorageAgent();
   }
 
@@ -132,13 +132,13 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
     }
 
     this.target().registerDOMStorageDispatcher(new DOMStorageDispatcher(this));
-    if (this.storageKeyManagerInternal) {
-      this.storageKeyManagerInternal.addEventListener(
+    if (this.#storageKeyManager) {
+      this.#storageKeyManager.addEventListener(
           SDK.StorageKeyManager.Events.STORAGE_KEY_ADDED, this.storageKeyAdded, this);
-      this.storageKeyManagerInternal.addEventListener(
+      this.#storageKeyManager.addEventListener(
           SDK.StorageKeyManager.Events.STORAGE_KEY_REMOVED, this.storageKeyRemoved, this);
 
-      for (const storageKey of this.storageKeyManagerInternal.storageKeys()) {
+      for (const storageKey of this.#storageKeyManager.storageKeys()) {
         this.addStorageKey(storageKey);
       }
     }
@@ -153,7 +153,7 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
     }
     for (const isLocal of [true, false]) {
       const key = this.storageKey(storageKey, isLocal);
-      const storage = this.storagesInternal[key];
+      const storage = this.#storages[key];
       if (!storage) {
         return;
       }
@@ -170,9 +170,9 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
   private addStorageKey(storageKey: string): void {
     for (const isLocal of [true, false]) {
       const key = this.storageKey(storageKey, isLocal);
-      console.assert(!this.storagesInternal[key]);
+      console.assert(!this.#storages[key]);
       const storage = new DOMStorage(this, storageKey, isLocal);
-      this.storagesInternal[key] = storage;
+      this.#storages[key] = storage;
       this.dispatchEventToListeners(Events.DOM_STORAGE_ADDED, storage);
     }
   }
@@ -184,11 +184,11 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
   private removeStorageKey(storageKey: string): void {
     for (const isLocal of [true, false]) {
       const key = this.storageKey(storageKey, isLocal);
-      const storage = this.storagesInternal[key];
+      const storage = this.#storages[key];
       if (!storage) {
         continue;
       }
-      delete this.storagesInternal[key];
+      delete this.#storages[key];
       this.dispatchEventToListeners(Events.DOM_STORAGE_REMOVED, storage);
     }
   }
@@ -238,13 +238,13 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
 
   storageForId(storageId: Protocol.DOMStorage.StorageId): DOMStorage {
     console.assert(Boolean(storageId.storageKey));
-    return this.storagesInternal[this.storageKey(storageId.storageKey || '', storageId.isLocalStorage)];
+    return this.#storages[this.storageKey(storageId.storageKey || '', storageId.isLocalStorage)];
   }
 
   storages(): DOMStorage[] {
     const result = [];
-    for (const id in this.storagesInternal) {
-      result.push(this.storagesInternal[id]);
+    for (const id in this.#storages) {
+      result.push(this.#storages[id]);
     }
     return result;
   }

package/front_end/panels/application/ExtensionStorageModel.ts

@@ -9,17 +9,17 @@ import * as Protocol from '../../generated/protocol.js';
 
 export class ExtensionStorage extends Common.ObjectWrapper.ObjectWrapper<Record<string, never>> {
   readonly #model: ExtensionStorageModel;
-  readonly #extensionIdInternal: string;
-  readonly #nameInternal: string;
-  readonly #storageAreaInternal: Protocol.Extensions.StorageArea;
+  readonly #extensionId: string;
+  readonly #name: string;
+  readonly #storageArea: Protocol.Extensions.StorageArea;
 
   constructor(
       model: ExtensionStorageModel, extensionId: string, name: string, storageArea: Protocol.Extensions.StorageArea) {
     super();
     this.#model = model;
-    this.#extensionIdInternal = extensionId;
-    this.#nameInternal = name;
-    this.#storageAreaInternal = storageArea;
+    this.#extensionId = extensionId;
+    this.#name = name;
+    this.#storageArea = storageArea;
   }
 
   get model(): ExtensionStorageModel {
@@ -27,11 +27,11 @@ export class ExtensionStorage extends Common.ObjectWrapper.ObjectWrapper<Record<
   }
 
   get extensionId(): string {
-    return this.#extensionIdInternal;
+    return this.#extensionId;
   }
 
   get name(): string {
-    return this.#nameInternal;
+    return this.#name;
   }
 
   // Returns a key that uniquely identifies this extension ID and storage area,
@@ -42,13 +42,13 @@ export class ExtensionStorage extends Common.ObjectWrapper.ObjectWrapper<Record<
   }
 
   get storageArea(): Protocol.Extensions.StorageArea {
-    return this.#storageAreaInternal;
+    return this.#storageArea;
   }
 
   async getItems(keys?: string[]): Promise<Record<string, unknown>> {
     const params: Protocol.Extensions.GetStorageItemsRequest = {
-      id: this.#extensionIdInternal,
-      storageArea: this.#storageAreaInternal,
+      id: this.#extensionId,
+      storageArea: this.#storageArea,
     };
     if (keys) {
       params.keys = keys;
@@ -62,7 +62,7 @@ export class ExtensionStorage extends Common.ObjectWrapper.ObjectWrapper<Record<
 
   async setItem(key: string, value: unknown): Promise<void> {
     const response = await this.#model.agent.invoke_setStorageItems(
-        {id: this.#extensionIdInternal, storageArea: this.#storageAreaInternal, values: {[key]: value}});
+        {id: this.#extensionId, storageArea: this.#storageArea, values: {[key]: value}});
     if (response.getError()) {
       throw new Error(response.getError());
     }
@@ -70,15 +70,15 @@ export class ExtensionStorage extends Common.ObjectWrapper.ObjectWrapper<Record<
 
   async removeItem(key: string): Promise<void> {
     const response = await this.#model.agent.invoke_removeStorageItems(
-        {id: this.#extensionIdInternal, storageArea: this.#storageAreaInternal, keys: [key]});
+        {id: this.#extensionId, storageArea: this.#storageArea, keys: [key]});
     if (response.getError()) {
       throw new Error(response.getError());
     }
   }
 
   async clear(): Promise<void> {
-    const response = await this.#model.agent.invoke_clearStorageItems(
-        {id: this.#extensionIdInternal, storageArea: this.#storageAreaInternal});
+    const response =
+        await this.#model.agent.invoke_clearStorageItems({id: this.#extensionId, storageArea: this.#storageArea});
     if (response.getError()) {
       throw new Error(response.getError());
     }
@@ -95,16 +95,16 @@ export class ExtensionStorage extends Common.ObjectWrapper.ObjectWrapper<Record<
 }
 
 export class ExtensionStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
-  readonly #runtimeModelInternal: SDK.RuntimeModel.RuntimeModel|null;
-  #storagesInternal: Map<string, Map<Protocol.Extensions.StorageArea, ExtensionStorage>>;
+  readonly #runtimeModel: SDK.RuntimeModel.RuntimeModel|null;
+  #storages: Map<string, Map<Protocol.Extensions.StorageArea, ExtensionStorage>>;
   readonly agent: ProtocolProxyApi.ExtensionsApi;
   #enabled?: boolean;
 
   constructor(target: SDK.Target.Target) {
     super(target);
 
-    this.#runtimeModelInternal = target.model(SDK.RuntimeModel.RuntimeModel);
-    this.#storagesInternal = new Map();
+    this.#runtimeModel = target.model(SDK.RuntimeModel.RuntimeModel);
+    this.#storages = new Map();
     this.agent = target.extensionsAgent();
   }
 
@@ -113,26 +113,26 @@ export class ExtensionStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
       return;
     }
 
-    if (this.#runtimeModelInternal) {
-      this.#runtimeModelInternal.addEventListener(
+    if (this.#runtimeModel) {
+      this.#runtimeModel.addEventListener(
           SDK.RuntimeModel.Events.ExecutionContextCreated, this.#onExecutionContextCreated, this);
-      this.#runtimeModelInternal.addEventListener(
+      this.#runtimeModel.addEventListener(
           SDK.RuntimeModel.Events.ExecutionContextDestroyed, this.#onExecutionContextDestroyed, this);
-      this.#runtimeModelInternal.executionContexts().forEach(this.#executionContextCreated, this);
+      this.#runtimeModel.executionContexts().forEach(this.#executionContextCreated, this);
     }
 
     this.#enabled = true;
   }
 
   #getStoragesForExtension(id: string): Map<Protocol.Extensions.StorageArea, ExtensionStorage> {
-    const existingStorages = this.#storagesInternal.get(id);
+    const existingStorages = this.#storages.get(id);
 
     if (existingStorages) {
       return existingStorages;
     }
 
     const newStorages = new Map();
-    this.#storagesInternal.set(id, newStorages);
+    this.#storages.set(id, newStorages);
     return newStorages;
   }
 
@@ -148,7 +148,7 @@ export class ExtensionStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
       storage.getItems([])
           .then(() => {
             // The extension may have been removed in the meantime.
-            if (this.#storagesInternal.get(id) !== storages) {
+            if (this.#storages.get(id) !== storages) {
               return;
             }
             // The storage area may have been added in the meantime.
@@ -167,7 +167,7 @@ export class ExtensionStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
   }
 
   #removeExtension(id: string): void {
-    const storages = this.#storagesInternal.get(id);
+    const storages = this.#storages.get(id);
 
     if (!storages) {
       return;
@@ -180,7 +180,7 @@ export class ExtensionStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
       this.dispatchEventToListeners(Events.EXTENSION_STORAGE_REMOVED, storage);
     }
 
-    this.#storagesInternal.delete(id);
+    this.#storages.delete(id);
   }
 
   #executionContextCreated(context: SDK.RuntimeModel.ExecutionContext): void {
@@ -203,7 +203,7 @@ export class ExtensionStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
     const extensionId = this.#extensionIdForContext(context);
     if (extensionId) {
       // Ignore event if there is still another context for this extension.
-      if (this.#runtimeModelInternal?.executionContexts().some(c => this.#extensionIdForContext(c) === extensionId)) {
+      if (this.#runtimeModel?.executionContexts().some(c => this.#extensionIdForContext(c) === extensionId)) {
         return;
       }
 
@@ -216,12 +216,12 @@ export class ExtensionStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
   }
 
   storageForIdAndArea(id: string, storageArea: Protocol.Extensions.StorageArea): ExtensionStorage|undefined {
-    return this.#storagesInternal.get(id)?.get(storageArea);
+    return this.#storages.get(id)?.get(storageArea);
   }
 
   storages(): ExtensionStorage[] {
     const result = [];
-    for (const storages of this.#storagesInternal.values()) {
+    for (const storages of this.#storages.values()) {
       result.push(...storages.values());
     }
     return result;

package/front_end/panels/application/IndexedDBModel.ts

@@ -39,6 +39,7 @@ export class IndexedDBModel extends SDK.SDKModel.SDKModel<EventTypes> implements
   private readonly storageBucketModel: SDK.StorageBucketsModel.StorageBucketsModel|null;
   private readonly indexedDBAgent: ProtocolProxyApi.IndexedDBApi;
   private readonly storageAgent: ProtocolProxyApi.StorageApi;
+  // Used in web tests
   private readonly databasesInternal: Map<DatabaseId, Database>;
   private databaseNamesByStorageKeyAndBucket: Map<string, Map<string, Set<DatabaseId>>>;
   private readonly updatedStorageBuckets: Set<Protocol.Storage.StorageBucket>;

package/front_end/panels/application/PreloadingTreeElement.ts

@@ -35,7 +35,7 @@ class PreloadingTreeElementBase<View extends PreloadingRuleSetView|PreloadingAtt
   #viewConstructor: {new(model: SDK.PreloadingModel.PreloadingModel): View};
   protected view?: View;
   #path: Platform.DevToolsPath.UrlString;
-  #selectedInternal: boolean;
+  #selected: boolean;
 
   constructor(
       panel: ResourcesPanel, viewConstructor: {new(model: SDK.PreloadingModel.PreloadingModel): View},
@@ -47,7 +47,7 @@ class PreloadingTreeElementBase<View extends PreloadingRuleSetView|PreloadingAtt
 
     const icon = IconButton.Icon.create('speculative-loads');
     this.setLeadingIcons([icon]);
-    this.#selectedInternal = false;
+    this.#selected = false;
 
     // TODO(https://crbug.com/1384419): Set link
   }
@@ -60,14 +60,14 @@ class PreloadingTreeElementBase<View extends PreloadingRuleSetView|PreloadingAtt
     this.#model = model;
 
     // Show the view if the model was initialized after selection.
-    if (this.#selectedInternal && !this.view) {
+    if (this.#selected && !this.view) {
       this.onselect(false);
     }
   }
 
   override onselect(selectedByUser?: boolean): boolean {
     super.onselect(selectedByUser);
-    this.#selectedInternal = true;
+    this.#selected = true;
 
     if (!this.#model) {
       return false;
@@ -86,7 +86,7 @@ class PreloadingTreeElementBase<View extends PreloadingRuleSetView|PreloadingAtt
 export class PreloadingSummaryTreeElement extends ExpandableApplicationPanelTreeElement {
   #model?: SDK.PreloadingModel.PreloadingModel;
   #view?: PreloadingSummaryView;
-  #selectedInternal: boolean;
+  #selected: boolean;
 
   #ruleSet: PreloadingRuleSetTreeElement|null = null;
   #attempt: PreloadingAttemptTreeElement|null = null;
@@ -96,7 +96,7 @@ export class PreloadingSummaryTreeElement extends ExpandableApplicationPanelTree
 
     const icon = IconButton.Icon.create('speculative-loads');
     this.setLeadingIcons([icon]);
-    this.#selectedInternal = false;
+    this.#selected = false;
 
     // TODO(https://crbug.com/1384419): Set link
   }
@@ -125,14 +125,14 @@ export class PreloadingSummaryTreeElement extends ExpandableApplicationPanelTree
     this.#attempt.initialize(model);
 
     // Show the view if the model was initialized after selection.
-    if (this.#selectedInternal && !this.#view) {
+    if (this.#selected && !this.#view) {
       this.onselect(false);
     }
   }
 
   override onselect(selectedByUser?: boolean): boolean {
     super.onselect(selectedByUser);
-    this.#selectedInternal = true;
+    this.#selected = true;
 
     if (!this.#model) {
       return false;

package/front_end/panels/application/ServiceWorkersView.ts

@@ -8,7 +8,6 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
-import * as Logs from '../../models/logs/logs.js';
 import * as NetworkForward from '../../panels/network/forward/forward.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
@@ -259,31 +258,6 @@ export class ServiceWorkersView extends UI.Widget.VBox implements
     this.eventListeners = new Map();
     SDK.TargetManager.TargetManager.instance().observeModels(SDK.ServiceWorkerManager.ServiceWorkerManager, this);
     this.updateListVisibility();
-
-    const drawerChangeHandler = (event: Event): void => {
-      // @ts-expect-error: No support for custom event listener
-      const isDrawerOpen = event.detail?.isDrawerOpen;
-      if (this.manager && !isDrawerOpen) {
-        const {serviceWorkerNetworkRequestsPanelStatus: {isOpen, openedAt}} = this.manager;
-        if (isOpen) {
-          const networkLocation = UI.ViewManager.ViewManager.instance().locationNameForViewId('network');
-          UI.ViewManager.ViewManager.instance().showViewInLocation('network', networkLocation, false);
-          void Common.Revealer.reveal(NetworkForward.UIFilter.UIRequestFilter.filters([]));
-
-          const currentTime = Date.now();
-          const timeDifference = currentTime - openedAt;
-          if (timeDifference < 2000) {
-            Host.userMetrics.actionTaken(Host.UserMetrics.Action.ServiceWorkerNetworkRequestClosedQuickly);
-          }
-
-          this.manager.serviceWorkerNetworkRequestsPanelStatus = {
-            isOpen: false,
-            openedAt: 0,
-          };
-        }
-      }
-    };
-    document.body.addEventListener(UI.InspectorView.Events.DRAWER_CHANGE, drawerChangeHandler);
   }
 
   modelAdded(serviceWorkerManager: SDK.ServiceWorkerManager.ServiceWorkerManager): void {
@@ -750,10 +724,6 @@ export class Section {
   }
 
   private networkRequestsClicked(): void {
-    const applicationTabLocation = UI.ViewManager.ViewManager.instance().locationNameForViewId('resources');
-    const networkTabLocation = applicationTabLocation === 'drawer-view' ? 'panel' : 'drawer-view';
-    UI.ViewManager.ViewManager.instance().showViewInLocation('network', networkTabLocation);
-
     void Common.Revealer.reveal(NetworkForward.UIFilter.UIRequestFilter.filters([
       {
         filterType: NetworkForward.UIFilter.FilterType.Is,
@@ -761,29 +731,6 @@ export class Section {
       },
     ]));
 
-    const requests = Logs.NetworkLog.NetworkLog.instance().requests();
-    let lastRequest: SDK.NetworkRequest.NetworkRequest|null = null;
-    if (Array.isArray(requests)) {
-      for (const request of requests) {
-        if (!lastRequest && request.fetchedViaServiceWorker) {
-          lastRequest = request;
-        }
-        if (request.fetchedViaServiceWorker && lastRequest &&
-            lastRequest.responseReceivedTime < request.responseReceivedTime) {
-          lastRequest = request;
-        }
-      }
-    }
-    if (lastRequest) {
-      const requestLocation = NetworkForward.UIRequestLocation.UIRequestLocation.tab(
-          lastRequest, NetworkForward.UIRequestLocation.UIRequestTabs.TIMING, {clearFilter: false});
-      void Common.Revealer.reveal(requestLocation);
-    }
-
-    this.manager.serviceWorkerNetworkRequestsPanelStatus = {
-      isOpen: true,
-      openedAt: Date.now(),
-    };
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.ServiceWorkerNetworkRequestClicked);
   }
 

package/front_end/panels/application/preloading/components/PreloadingDisabledInfobar.ts

@@ -118,11 +118,11 @@ export class PreloadingDisabledInfobar extends LegacyWrapper.LegacyWrapper.Wrapp
 
   async #render(): Promise<void> {
     await RenderCoordinator.write('PreloadingDisabledInfobar render', () => {
-      Lit.render(this.#renderInternal(), this.#shadow, {host: this});
+      Lit.render(this.#renderTemplate(), this.#shadow, {host: this});
     });
   }
 
-  #renderInternal(): Lit.LitTemplate {
+  #renderTemplate(): Lit.LitTemplate {
     const forceEnabled =
         this.#data.disabledByHoldbackPrefetchSpeculationRules || this.#data.disabledByHoldbackPrerenderSpeculationRules;
     const disabled =

package/front_end/panels/application/preloading/components/UsedPreloadingView.ts

@@ -155,11 +155,11 @@ export class UsedPreloadingView extends LegacyWrapper.LegacyWrapper.WrappableCom
 
   async #render(): Promise<void> {
     await RenderCoordinator.write('UsedPreloadingView render', () => {
-      Lit.render(this.#renderInternal(), this.#shadow, {host: this});
+      Lit.render(this.#renderTemplate(), this.#shadow, {host: this});
     });
   }
 
-  #renderInternal(): Lit.LitTemplate {
+  #renderTemplate(): Lit.LitTemplate {
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     return html`

package/front_end/panels/common/BadgeNotification.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Badges from '../../models/badges/badges.js';
@@ -11,6 +12,7 @@ import * as Lit from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import badgeNotificationStyles from './badgeNotification.css.js';
+import * as GdpSignUpDialog from './GdpSignUpDialog.js';
 
 const {html, render} = Lit;
 
@@ -108,12 +110,16 @@ const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLElement)
   render(html`
     <style>${badgeNotificationStyles}</style>
     <div class="container">
+      <div class="badge-container">
+        <img class="badge-image" src=${input.imageUri}>
+      </div>
+      <div class="action-and-text-container">
         <div class="label-container">
-            <img class="badge-image" src=${input.imageUri}>
             <div class="message">${input.message}</div>
             ${crossButton}
         </div>
         <div class="long-action-container">${actionButtons}</div>
+      </div>
     </div>
   `, target);
 };
@@ -190,7 +196,13 @@ export class BadgeNotification extends UI.Widget.Widget {
           label: i18nString(UIStrings.remindMeLater),
           onClick: () => {/* TODO(ergunsh): Implement */},
         },
-        {label: i18nString(UIStrings.createProfile), onClick: () => { /* TODO(ergunsh): Implement */ }}
+        {
+          label: i18nString(UIStrings.createProfile),
+          onClick: () => {
+            this.#close();
+            GdpSignUpDialog.GdpSignUpDialog.show();
+          }
+        }
       ],
       imageUri: badge.imageUri,
     });
@@ -202,9 +214,17 @@ export class BadgeNotification extends UI.Widget.Widget {
       actions: [
         {
           label: i18nString(UIStrings.badgeSettings),
-          onClick: () => {/* TODO(ergunsh): Implement */},
+          onClick: () => {
+            this.#close();
+            void Common.Revealer.reveal(Common.Settings.moduleSetting('receive-gdp-badges'));
+          },
         },
-        {label: i18nString(UIStrings.viewProfile), onClick: () => { /* TODO(ergunsh): Implement */ }}
+        {
+          label: i18nString(UIStrings.viewProfile),
+          onClick: () => {
+            UI.UIUtils.openInNewTab(Host.GdpClient.GOOGLE_DEVELOPER_PROGRAM_PROFILE_LINK);
+          }
+        }
       ],
       imageUri: badge.imageUri,
     });