chrome-devtools-frontend 1.0.1512349 → 1.0.1513662

package/front_end/models/trace/handlers/Threads.ts

@@ -7,7 +7,7 @@ import type * as Types from '../types/types.js';
 
 import type {AuctionWorkletsData} from './AuctionWorkletsHandler.js';
 import type * as Renderer from './RendererHandler.js';
-import type {ParsedTrace} from './types.js';
+import type {HandlerData} from './types.js';
 
 export interface ThreadData {
   pid: Types.Events.ProcessID;
@@ -82,7 +82,7 @@ export function threadsInRenderer(
   return foundThreads;
 }
 
-const threadsInTraceCache = new WeakMap<ParsedTrace, readonly ThreadData[]>();
+const threadsInHandlerDataCache = new WeakMap<HandlerData, readonly ThreadData[]>();
 
 /**
  * Given trace parsed data, this helper will return a high level array of
@@ -92,24 +92,24 @@ const threadsInTraceCache = new WeakMap<ParsedTrace, readonly ThreadData[]>();
  * for both trace types.
  * The resulting data is cached per-trace, so you can safely call this multiple times.
  */
-export function threadsInTrace(parsedTrace: ParsedTrace): readonly ThreadData[] {
-  const cached = threadsInTraceCache.get(parsedTrace);
+export function threadsInTrace(handlerData: HandlerData): readonly ThreadData[] {
+  const cached = threadsInHandlerDataCache.get(handlerData);
   if (cached) {
     return cached;
   }
 
   // If we have Renderer threads, we prefer to use those.
-  const threadsFromRenderer = threadsInRenderer(parsedTrace.Renderer, parsedTrace.AuctionWorklets);
+  const threadsFromRenderer = threadsInRenderer(handlerData.Renderer, handlerData.AuctionWorklets);
   if (threadsFromRenderer.length) {
-    threadsInTraceCache.set(parsedTrace, threadsFromRenderer);
+    threadsInHandlerDataCache.set(handlerData, threadsFromRenderer);
     return threadsFromRenderer;
   }
 
   // If it's a CPU Profile trace, there will be no Renderer threads.
   // We can fallback to using the data from the SamplesHandler.
   const foundThreads: ThreadData[] = [];
-  if (parsedTrace.Samples.profilesInProcess.size) {
-    for (const [pid, process] of parsedTrace.Samples.profilesInProcess) {
+  if (handlerData.Samples.profilesInProcess.size) {
+    for (const [pid, process] of handlerData.Samples.profilesInProcess) {
       for (const [tid, thread] of process) {
         if (!thread.profileTree) {
           // Drop threads where we could not create the tree; this indicates
@@ -128,12 +128,12 @@ export function threadsInTrace(parsedTrace: ParsedTrace): readonly ThreadData[]
           processIsOnMainFrame: false,
           tree: thread.profileTree,
           type: ThreadType.CPU_PROFILE,
-          entryToNode: parsedTrace.Samples.entryToNode,
+          entryToNode: handlerData.Samples.entryToNode,
         });
       }
     }
   }
 
-  threadsInTraceCache.set(parsedTrace, foundThreads);
+  threadsInHandlerDataCache.set(handlerData, foundThreads);
   return foundThreads;
 }

package/front_end/models/trace/handlers/helpers.ts

@@ -7,7 +7,7 @@ import * as ThirdPartyWeb from '../../../third_party/third-party-web/third-party
 import * as Types from '../types/types.js';
 
 import type {TraceEventsForNetworkRequest} from './NetworkRequestsHandler.js';
-import type {ParsedTrace} from './types.js';
+import type {HandlerData} from './types.js';
 
 export type Entity = typeof ThirdPartyWeb.ThirdPartyWeb.entities[number]&{
   isUnrecognized?: boolean,
@@ -41,7 +41,7 @@ export function getEntityForUrl(url: string, entityMappings: EntityMappings): En
 }
 
 export function getNonResolvedURL(
-    entry: Types.Events.Event, parsedTrace?: ParsedTrace): Platform.DevToolsPath.UrlString|null {
+    entry: Types.Events.Event, handlerData?: HandlerData): Platform.DevToolsPath.UrlString|null {
   if (Types.Events.isProfileCall(entry)) {
     return entry.callFrame.url as Platform.DevToolsPath.UrlString;
   }
@@ -63,17 +63,17 @@ export function getNonResolvedURL(
     return entry.args.beginData.url as Platform.DevToolsPath.UrlString;
   }
 
-  if (parsedTrace) {
+  if (handlerData) {
     // DecodeImage events use the URL from the relevant PaintImage event.
     if (Types.Events.isDecodeImage(entry)) {
-      const paintEvent = parsedTrace.ImagePainting.paintImageForEvent.get(entry);
-      return paintEvent ? getNonResolvedURL(paintEvent, parsedTrace) : null;
+      const paintEvent = handlerData.ImagePainting.paintImageForEvent.get(entry);
+      return paintEvent ? getNonResolvedURL(paintEvent, handlerData) : null;
     }
 
     // DrawLazyPixelRef events use the URL from the relevant PaintImage event.
     if (Types.Events.isDrawLazyPixelRef(entry) && entry.args?.LazyPixelRef) {
-      const paintEvent = parsedTrace.ImagePainting.paintImageByDrawLazyPixelRef.get(entry.args.LazyPixelRef);
-      return paintEvent ? getNonResolvedURL(paintEvent, parsedTrace) : null;
+      const paintEvent = handlerData.ImagePainting.paintImageByDrawLazyPixelRef.get(entry.args.LazyPixelRef);
+      return paintEvent ? getNonResolvedURL(paintEvent, handlerData) : null;
     }
   }
 
@@ -85,8 +85,8 @@ export function getNonResolvedURL(
   // Many events don't have a url, but are associated with a request. Use the
   // request's url.
   const requestId = (entry.args?.data as {requestId?: string})?.requestId;
-  if (parsedTrace && requestId) {
-    const url = parsedTrace.NetworkRequests.byId.get(requestId)?.args.data.url;
+  if (handlerData && requestId) {
+    const url = handlerData.NetworkRequests.byId.get(requestId)?.args.data.url;
     if (url) {
       return url as Platform.DevToolsPath.UrlString;
     }

package/front_end/models/trace/handlers/types.ts

@@ -58,14 +58,14 @@ export type HandlersWithMeta<T extends Record<string, Handler>> = {
   [K in keyof T]: T[K];
 };
 
-// Represents the final parsed data from all of the handlers. If you instantiate a
+// Represents the final data from all of the handlers. If you instantiate a
 // TraceProcessor with a subset of handlers, you should instead use
 // `EnabledHandlerDataWithMeta<>`.
-export type ParsedTrace = Readonly<EnabledHandlerDataWithMeta<typeof ModelHandlers>>;
+export type HandlerData = Readonly<EnabledHandlerDataWithMeta<typeof ModelHandlers>>;
 
 type DeepWriteable<T> = {
   -readonly[P in keyof T]: DeepWriteable<T[P]>
 };
-export type ParsedTraceMutable = DeepWriteable<ParsedTrace>;
+export type HandlerDataMutable = DeepWriteable<HandlerData>;
 
 export type Handlers = typeof ModelHandlers;

package/front_end/models/trace/insights/CLSCulprits.ts

@@ -387,8 +387,7 @@ function getNextEvent(sourceEvents: Types.Events.Event[], targetEvent: Types.Eve
  * and within this prePaint event a layout shift(s) occurs.
  */
 function getIframeRootCauses(
-    parsedTrace: Handlers.Types.ParsedTrace,
-    iframeCreatedEvents: readonly Types.Events.RenderFrameImplCreateChildFrame[],
+    data: Handlers.Types.HandlerData, iframeCreatedEvents: readonly Types.Events.RenderFrameImplCreateChildFrame[],
     prePaintEvents: Types.Events.PrePaint[],
     shiftsByPrePaint: Map<Types.Events.PrePaint, Types.Events.SyntheticLayoutShift[]>,
     rootCausesByShift: Map<Types.Events.SyntheticLayoutShift, LayoutShiftRootCausesData>,
@@ -421,7 +420,7 @@ function getIframeRootCauses(
         const frame = domEvent.args.frame;
 
         let url;
-        const processes = parsedTrace.Meta.rendererProcessesByFrame.get(frame);
+        const processes = data.Meta.rendererProcessesByFrame.get(frame);
         if (processes && processes.size > 0) {
           url = [...processes.values()][0]?.[0].frame.url;
         }
@@ -590,23 +589,22 @@ function finalize(partialModel: PartialInsightModel<CLSCulpritsInsightModel>): C
   };
 }
 
-export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): CLSCulpritsInsightModel {
+export function generateInsight(data: Handlers.Types.HandlerData, context: InsightSetContext): CLSCulpritsInsightModel {
   const isWithinContext = (event: Types.Events.Event): boolean => Helpers.Timing.eventIsInBounds(event, context.bounds);
 
-  const compositeAnimationEvents = parsedTrace.Animations.animations.filter(isWithinContext);
-  const iframeEvents = parsedTrace.LayoutShifts.renderFrameImplCreateChildFrameEvents.filter(isWithinContext);
-  const networkRequests = parsedTrace.NetworkRequests.byTime.filter(isWithinContext);
-  const domLoadingEvents = parsedTrace.LayoutShifts.domLoadingEvents.filter(isWithinContext);
-  const unsizedImageEvents = parsedTrace.LayoutShifts.layoutImageUnsizedEvents.filter(isWithinContext);
+  const compositeAnimationEvents = data.Animations.animations.filter(isWithinContext);
+  const iframeEvents = data.LayoutShifts.renderFrameImplCreateChildFrameEvents.filter(isWithinContext);
+  const networkRequests = data.NetworkRequests.byTime.filter(isWithinContext);
+  const domLoadingEvents = data.LayoutShifts.domLoadingEvents.filter(isWithinContext);
+  const unsizedImageEvents = data.LayoutShifts.layoutImageUnsizedEvents.filter(isWithinContext);
 
   const clusterKey = context.navigation ? context.navigationId : Types.Events.NO_NAVIGATION;
-  const clusters = parsedTrace.LayoutShifts.clustersByNavigationId.get(clusterKey) ?? [];
+  const clusters = data.LayoutShifts.clustersByNavigationId.get(clusterKey) ?? [];
   const clustersByScore = clusters.toSorted((a, b) => b.clusterCumulativeScore - a.clusterCumulativeScore);
   const worstCluster = clustersByScore.at(0);
   const layoutShifts = clusters.flatMap(cluster => cluster.events);
-  const prePaintEvents = parsedTrace.LayoutShifts.prePaintEvents.filter(isWithinContext);
-  const paintImageEvents = parsedTrace.LayoutShifts.paintImageEvents.filter(isWithinContext);
+  const prePaintEvents = data.LayoutShifts.prePaintEvents.filter(isWithinContext);
+  const paintImageEvents = data.LayoutShifts.paintImageEvents.filter(isWithinContext);
 
   // Get root causes.
   const rootCausesByShift = new Map<Types.Events.SyntheticLayoutShift, LayoutShiftRootCausesData>();
@@ -617,7 +615,7 @@ export function generateInsight(
   }
 
   // Populate root causes for rootCausesByShift.
-  getIframeRootCauses(parsedTrace, iframeEvents, prePaintEvents, shiftsByPrePaint, rootCausesByShift, domLoadingEvents);
+  getIframeRootCauses(data, iframeEvents, prePaintEvents, shiftsByPrePaint, rootCausesByShift, domLoadingEvents);
   getFontRootCauses(networkRequests, prePaintEvents, shiftsByPrePaint, rootCausesByShift);
   getUnsizedImageRootCauses(unsizedImageEvents, paintImageEvents, shiftsByPrePaint, rootCausesByShift);
   const animationFailures =

package/front_end/models/trace/insights/Cache.ts

@@ -12,6 +12,7 @@ import {metricSavingsForWastedBytes} from './Common.js';
 import {linearInterpolation} from './Statistics.js';
 import {
   InsightCategory,
+  InsightKeys,
   type InsightModel,
   type InsightSetContext,
   type PartialInsightModel,
@@ -62,7 +63,7 @@ const IGNORE_THRESHOLD_IN_PERCENT = 0.925;
 
 function finalize(partialModel: PartialInsightModel<CacheInsightModel>): CacheInsightModel {
   return {
-    insightKey: 'Cache',
+    insightKey: InsightKeys.CACHE,
     strings: UIStrings,
     title: i18nString(UIStrings.title),
     description: i18nString(UIStrings.description),
@@ -188,10 +189,13 @@ export interface CacheableRequest {
   wastedBytes: number;
 }
 
-export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): CacheInsightModel {
+export function isCacheInsight(model: InsightModel): model is CacheInsightModel {
+  return model.insightKey === InsightKeys.CACHE;
+}
+
+export function generateInsight(data: Handlers.Types.HandlerData, context: InsightSetContext): CacheInsightModel {
   const isWithinContext = (event: Types.Events.Event): boolean => Helpers.Timing.eventIsInBounds(event, context.bounds);
-  const contextRequests = parsedTrace.NetworkRequests.byTime.filter(isWithinContext);
+  const contextRequests = data.NetworkRequests.byTime.filter(isWithinContext);
 
   const results: CacheableRequest[] = [];
   let totalWastedBytes = 0;

package/front_end/models/trace/insights/DOMSize.ts

@@ -104,8 +104,11 @@ function finalize(partialModel: PartialInsightModel<DOMSizeInsightModel>): DOMSi
   };
 }
 
-export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): DOMSizeInsightModel {
+export function isDomSizeInsight(model: InsightModel): model is DOMSizeInsightModel {
+  return model.insightKey === InsightKeys.DOM_SIZE;
+}
+
+export function generateInsight(data: Handlers.Types.HandlerData, context: InsightSetContext): DOMSizeInsightModel {
   const isWithinContext = (event: Types.Events.Event): boolean => Helpers.Timing.eventIsInBounds(event, context.bounds);
 
   const mainTid = context.navigation?.tid;
@@ -113,7 +116,7 @@ export function generateInsight(
   const largeLayoutUpdates: Types.Events.Layout[] = [];
   const largeStyleRecalcs: Types.Events.UpdateLayoutTree[] = [];
 
-  const threads = Handlers.Threads.threadsInRenderer(parsedTrace.Renderer, parsedTrace.AuctionWorklets);
+  const threads = Handlers.Threads.threadsInRenderer(data.Renderer, data.AuctionWorklets);
   for (const thread of threads) {
     if (thread.type !== Handlers.Threads.ThreadType.MAIN_THREAD) {
       continue;
@@ -129,7 +132,7 @@ export function generateInsight(
       continue;
     }
 
-    const rendererThread = parsedTrace.Renderer.processes.get(thread.pid)?.threads.get(thread.tid);
+    const rendererThread = data.Renderer.processes.get(thread.pid)?.threads.get(thread.tid);
     if (!rendererThread) {
       continue;
     }
@@ -185,7 +188,7 @@ export function generateInsight(
     }),
   ].sort((a, b) => b.duration - a.duration).slice(0, 5);
 
-  const domStatsEvents = parsedTrace.DOMStats.domStatsByFrameId.get(context.frameId)?.filter(isWithinContext) ?? [];
+  const domStatsEvents = data.DOMStats.domStatsByFrameId.get(context.frameId)?.filter(isWithinContext) ?? [];
   let maxDOMStats: Types.Events.DOMStats|undefined;
   for (const domStats of domStatsEvents) {
     // While recording a cross-origin navigation, there can be overlapping dom stats from before & after

package/front_end/models/trace/insights/DocumentLatency.ts

@@ -190,12 +190,12 @@ function finalize(partialModel: PartialInsightModel<DocumentLatencyInsightModel>
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): DocumentLatencyInsightModel {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): DocumentLatencyInsightModel {
   if (!context.navigation) {
     return finalize({});
   }
 
-  const documentRequest = parsedTrace.NetworkRequests.byId.get(context.navigationId);
+  const documentRequest = data.NetworkRequests.byId.get(context.navigationId);
   if (!documentRequest) {
     return finalize({warnings: [InsightWarning.NO_DOCUMENT_REQUEST]});
   }

package/front_end/models/trace/insights/DuplicatedJavaScript.ts

@@ -65,8 +65,8 @@ export function isDuplicatedJavaScript(model: InsightModel): model is Duplicated
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): DuplicatedJavaScriptInsightModel {
-  const scripts = parsedTrace.Scripts.scripts.filter(script => {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): DuplicatedJavaScriptInsightModel {
+  const scripts = data.Scripts.scripts.filter(script => {
     if (script.frame !== context.frameId) {
       return false;
     }
@@ -108,7 +108,7 @@ export function generateInsight(
     duplicationGroupedByNodeModules,
     scriptsWithDuplication: [...new Set(scriptsWithDuplication)],
     scripts,
-    mainDocumentUrl: context.navigation?.args.data?.url ?? parsedTrace.Meta.mainFrameURL,
+    mainDocumentUrl: context.navigation?.args.data?.url ?? data.Meta.mainFrameURL,
     metricSavings: metricSavingsForWastedBytes(wastedBytesByRequestId, context),
     wastedBytes: wastedBytesByRequestId.values().reduce((acc, cur) => acc + cur, 0),
   });

package/front_end/models/trace/insights/FontDisplay.ts

@@ -60,17 +60,16 @@ export function isFontDisplayInsight(model: InsightModel): model is FontDisplayI
   return model.insightKey === InsightKeys.FONT_DISPLAY;
 }
 
-export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): FontDisplayInsightModel {
+export function generateInsight(data: Handlers.Types.HandlerData, context: InsightSetContext): FontDisplayInsightModel {
   const fonts: RemoteFont[] = [];
-  for (const remoteFont of parsedTrace.LayoutShifts.remoteFonts) {
+  for (const remoteFont of data.LayoutShifts.remoteFonts) {
     const event = remoteFont.beginRemoteFontLoadEvent;
     if (!Helpers.Timing.eventIsInBounds(event, context.bounds)) {
       continue;
     }
 
     const requestId = `${event.pid}.${event.args.id}`;
-    const request = parsedTrace.NetworkRequests.byId.get(requestId);
+    const request = data.NetworkRequests.byId.get(requestId);
     if (!request) {
       continue;
     }

package/front_end/models/trace/insights/ForcedReflow.ts

@@ -78,7 +78,7 @@ function getCallFrameId(callFrame: Types.Events.CallFrame|Protocol.Runtime.CallF
 }
 
 function getLargestTopLevelFunctionData(
-    forcedReflowEvents: Types.Events.Event[], traceParsedData: Handlers.Types.ParsedTrace): ForcedReflowAggregatedData|
+    forcedReflowEvents: Types.Events.Event[], traceParsedData: Handlers.Types.HandlerData): ForcedReflowAggregatedData|
     undefined {
   const entryToNodeMap = traceParsedData.Renderer.entryToNode;
   const dataByTopLevelFunction = new Map<string, ForcedReflowAggregatedData>();
@@ -150,7 +150,7 @@ function finalize(partialModel: PartialInsightModel<ForcedReflowInsightModel>):
   };
 }
 
-function getBottomCallFrameForEvent(event: Types.Events.Event, traceParsedData: Handlers.Types.ParsedTrace):
+function getBottomCallFrameForEvent(event: Types.Events.Event, traceParsedData: Handlers.Types.HandlerData):
     Types.Events.CallFrame|Protocol.Runtime.CallFrame|null {
   const profileStackTrace = Extras.StackTraceForEvent.get(event, traceParsedData);
   const eventStackTrace = Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event);
@@ -163,7 +163,7 @@ export function isForcedReflowInsight(model: InsightModel): model is ForcedReflo
 }
 
 export function generateInsight(
-    traceParsedData: Handlers.Types.ParsedTrace, context: InsightSetContext): ForcedReflowInsightModel {
+    traceParsedData: Handlers.Types.HandlerData, context: InsightSetContext): ForcedReflowInsightModel {
   const isWithinContext = (event: Types.Events.Event): boolean => {
     const frameId = Helpers.Trace.frameIDForEvent(event);
     if (frameId !== context.frameId) {

package/front_end/models/trace/insights/INPBreakdown.ts

@@ -79,8 +79,8 @@ function finalize(partialModel: PartialInsightModel<INPBreakdownInsightModel>):
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): INPBreakdownInsightModel {
-  const interactionEvents = parsedTrace.UserInteractions.interactionEventsWithNoNesting.filter(event => {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): INPBreakdownInsightModel {
+  const interactionEvents = data.UserInteractions.interactionEventsWithNoNesting.filter(event => {
     return Helpers.Timing.eventIsInBounds(event, context.bounds);
   });
 

package/front_end/models/trace/insights/ImageDelivery.ts

@@ -183,19 +183,19 @@ function estimateGIFPercentSavings(request: Types.Events.SyntheticNetworkRequest
 }
 
 function getDisplayedSize(
-    parsedTrace: Handlers.Types.ParsedTrace, paintImage: Types.Events.PaintImage): {width: number, height: number} {
+    data: Handlers.Types.HandlerData, paintImage: Types.Events.PaintImage): {width: number, height: number} {
   // Note: for traces made prior to metadata.hostDPR (which means no data in
   // paintEventToCorrectedDisplaySize), the displayed size unexpectedly ignores any
   // emulated DPR and so the results may be very misleading.
-  return parsedTrace.ImagePainting.paintEventToCorrectedDisplaySize.get(paintImage) ?? {
+  return data.ImagePainting.paintEventToCorrectedDisplaySize.get(paintImage) ?? {
     width: paintImage.args.data.width,
     height: paintImage.args.data.height,
   };
 }
 
-function getPixelCounts(parsedTrace: Handlers.Types.ParsedTrace, paintImage: Types.Events.PaintImage):
+function getPixelCounts(data: Handlers.Types.HandlerData, paintImage: Types.Events.PaintImage):
     {displayedPixels: number, filePixels: number} {
-  const {width, height} = getDisplayedSize(parsedTrace, paintImage);
+  const {width, height} = getDisplayedSize(data, paintImage);
   return {
     filePixels: paintImage.args.data.srcWidth * paintImage.args.data.srcHeight,
     displayedPixels: width * height,
@@ -203,10 +203,10 @@ function getPixelCounts(parsedTrace: Handlers.Types.ParsedTrace, paintImage: Typ
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): ImageDeliveryInsightModel {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): ImageDeliveryInsightModel {
   const isWithinContext = (event: Types.Events.Event): boolean => Helpers.Timing.eventIsInBounds(event, context.bounds);
 
-  const contextRequests = parsedTrace.NetworkRequests.byTime.filter(isWithinContext);
+  const contextRequests = data.NetworkRequests.byTime.filter(isWithinContext);
 
   const optimizableImages: OptimizableImage[] = [];
   for (const request of contextRequests) {
@@ -220,7 +220,7 @@ export function generateInsight(
 
     // If the request was redirected, the image paints will have the pre-redirect URL.
     const url = request.args.data.redirects[0]?.url ?? request.args.data.url;
-    const imagePaints = parsedTrace.ImagePainting.paintImageEventForUrl.get(url)?.filter(isWithinContext);
+    const imagePaints = data.ImagePainting.paintImageEventForUrl.get(url)?.filter(isWithinContext);
 
     // This will filter out things like preloaded image requests where an image file is downloaded
     // but never rendered on the page.
@@ -229,15 +229,15 @@ export function generateInsight(
     }
 
     const largestImagePaint = imagePaints.reduce((prev, curr) => {
-      const prevPixels = getPixelCounts(parsedTrace, prev).displayedPixels;
-      const currPixels = getPixelCounts(parsedTrace, curr).displayedPixels;
+      const prevPixels = getPixelCounts(data, prev).displayedPixels;
+      const currPixels = getPixelCounts(data, curr).displayedPixels;
       return prevPixels > currPixels ? prev : curr;
     });
 
     const {
       filePixels: imageFilePixels,
       displayedPixels: largestImageDisplayPixels,
-    } = getPixelCounts(parsedTrace, largestImagePaint);
+    } = getPixelCounts(data, largestImagePaint);
 
     // Decoded body length is almost always the right one to be using because of the below:
     //     `encodedDataLength = decodedBodyLength + headers`.
@@ -284,7 +284,7 @@ export function generateInsight(
         // optimization added here.
         imageByteSavings += Math.round(wastedPixelRatio * (imageBytes - imageByteSavingsFromFormat));
 
-        const {width, height} = getDisplayedSize(parsedTrace, largestImagePaint);
+        const {width, height} = getDisplayedSize(data, largestImagePaint);
 
         optimizations.push({
           type: ImageOptimizationType.RESPONSIVE_SIZE,

package/front_end/models/trace/insights/LCPBreakdown.ts

@@ -193,14 +193,14 @@ function finalize(partialModel: PartialInsightModel<LCPBreakdownInsightModel>):
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): LCPBreakdownInsightModel {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): LCPBreakdownInsightModel {
   if (!context.navigation) {
     return finalize({});
   }
 
-  const networkRequests = parsedTrace.NetworkRequests;
+  const networkRequests = data.NetworkRequests;
 
-  const frameMetrics = parsedTrace.PageLoadMetrics.metricScoresByFrameId.get(context.frameId);
+  const frameMetrics = data.PageLoadMetrics.metricScoresByFrameId.get(context.frameId);
   if (!frameMetrics) {
     throw new Error('no frame metrics');
   }
@@ -219,7 +219,7 @@ export function generateInsight(
   const lcpMs = Helpers.Timing.microToMilli(metricScore.timing);
   // This helps position things on the timeline's UI accurately for a trace.
   const lcpTs = metricScore.event?.ts ? Helpers.Timing.microToMilli(metricScore.event?.ts) : undefined;
-  const lcpRequest = parsedTrace.LargestImagePaint.lcpRequestByNavigationId.get(context.navigationId);
+  const lcpRequest = data.LargestImagePaint.lcpRequestByNavigationId.get(context.navigationId);
 
   const docRequest = networkRequests.byId.get(context.navigationId);
   if (!docRequest) {

package/front_end/models/trace/insights/LCPDiscovery.ts

@@ -95,14 +95,14 @@ function finalize(partialModel: PartialInsightModel<LCPDiscoveryInsightModel>):
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): LCPDiscoveryInsightModel {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): LCPDiscoveryInsightModel {
   if (!context.navigation) {
     return finalize({});
   }
 
-  const networkRequests = parsedTrace.NetworkRequests;
+  const networkRequests = data.NetworkRequests;
 
-  const frameMetrics = parsedTrace.PageLoadMetrics.metricScoresByFrameId.get(context.frameId);
+  const frameMetrics = data.PageLoadMetrics.metricScoresByFrameId.get(context.frameId);
   if (!frameMetrics) {
     throw new Error('no frame metrics');
   }
@@ -122,7 +122,7 @@ export function generateInsight(
     return finalize({warnings: [InsightWarning.NO_DOCUMENT_REQUEST]});
   }
 
-  const lcpRequest = parsedTrace.LargestImagePaint.lcpRequestByNavigationId.get(context.navigationId);
+  const lcpRequest = data.LargestImagePaint.lcpRequestByNavigationId.get(context.navigationId);
   if (!lcpRequest) {
     return finalize({lcpEvent});
   }

package/front_end/models/trace/insights/LegacyJavaScript.ts

@@ -77,8 +77,8 @@ export function isLegacyJavaScript(model: InsightModel): model is LegacyJavaScri
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): LegacyJavaScriptInsightModel {
-  const scripts = parsedTrace.Scripts.scripts.filter(script => {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): LegacyJavaScriptInsightModel {
+  const scripts = data.Scripts.scripts.filter(script => {
     if (script.frame !== context.frameId) {
       return false;
     }

package/front_end/models/trace/insights/ModernHTTP.ts

@@ -227,14 +227,13 @@ function finalize(partialModel: PartialInsightModel<ModernHTTPInsightModel>): Mo
   };
 }
 
-export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): ModernHTTPInsightModel {
+export function generateInsight(data: Handlers.Types.HandlerData, context: InsightSetContext): ModernHTTPInsightModel {
   const isWithinContext = (event: Types.Events.Event): boolean => Helpers.Timing.eventIsInBounds(event, context.bounds);
 
-  const contextRequests = parsedTrace.NetworkRequests.byTime.filter(isWithinContext);
+  const contextRequests = data.NetworkRequests.byTime.filter(isWithinContext);
 
-  const entityMappings = parsedTrace.NetworkRequests.entityMappings;
-  const firstPartyUrl = context.navigation?.args.data?.documentLoaderURL ?? parsedTrace.Meta.mainFrameURL;
+  const entityMappings = data.NetworkRequests.entityMappings;
+  const firstPartyUrl = context.navigation?.args.data?.documentLoaderURL ?? data.Meta.mainFrameURL;
   const firstPartyEntity = Handlers.Helpers.getEntityForUrl(firstPartyUrl, entityMappings);
   const http1Requests = determineHttp1Requests(contextRequests, entityMappings, firstPartyEntity ?? null);
 

package/front_end/models/trace/insights/NetworkDependencyTree.ts

@@ -460,11 +460,11 @@ export function handleLinkResponseHeader(linkHeaderValue: string): Array<{url: s
 
 // Export the function for test purpose.
 export function generatePreconnectedOrigins(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContextWithNavigation,
+    data: Handlers.Types.HandlerData, context: InsightSetContextWithNavigation,
     contextRequests: Types.Events.SyntheticNetworkRequest[],
     preconnectCandidates: PreconnectCandidate[]): PreconnectedOrigin[] {
   const preconnectedOrigins: PreconnectedOrigin[] = [];
-  for (const event of parsedTrace.NetworkRequests.linkPreconnectEvents) {
+  for (const event of data.NetworkRequests.linkPreconnectEvents) {
     preconnectedOrigins.push({
       node_id: event.args.data.node_id,
       frame: event.args.data.frame,
@@ -480,7 +480,7 @@ export function generatePreconnectedOrigins(
     });
   }
 
-  const documentRequest = parsedTrace.NetworkRequests.byId.get(context.navigationId);
+  const documentRequest = data.NetworkRequests.byId.get(context.navigationId);
   documentRequest?.args.data.responseHeaders?.forEach(header => {
     if (header.name.toLowerCase() === 'link') {
       const preconnectedOriginsFromResponseHeader = handleLinkResponseHeader(header.value);  // , documentRequest);
@@ -538,7 +538,7 @@ function socketStartTimeIsBelowThreshold(
 }
 
 function candidateRequestsByOrigin(
-    parsedTrace: Handlers.Types.ParsedTrace, mainResource: Types.Events.SyntheticNetworkRequest,
+    data: Handlers.Types.HandlerData, mainResource: Types.Events.SyntheticNetworkRequest,
     contextRequests: Types.Events.SyntheticNetworkRequest[],
     lcpGraphURLs: Set<string>): Map<string, Types.Events.SyntheticNetworkRequest[]> {
   const origins = new Map<string, Types.Events.SyntheticNetworkRequest[]>();
@@ -549,7 +549,7 @@ function candidateRequestsByOrigin(
     }
 
     // Filter out all resources that are loaded by the document. Connections are already early.
-    if (parsedTrace.NetworkRequests.eventToInitiator.get(request) === mainResource) {
+    if (data.NetworkRequests.eventToInitiator.get(request) === mainResource) {
       return;
     }
 
@@ -586,13 +586,13 @@ function candidateRequestsByOrigin(
 
 // Export the function for test purpose.
 export function generatePreconnectCandidates(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContextWithNavigation,
+    data: Handlers.Types.HandlerData, context: InsightSetContextWithNavigation,
     contextRequests: Types.Events.SyntheticNetworkRequest[]): PreconnectCandidate[] {
   if (!context.lantern) {
     return [];
   }
 
-  const documentRequest = parsedTrace.NetworkRequests.byId.get(context.navigationId);
+  const documentRequest = data.NetworkRequests.byId.get(context.navigationId);
   if (!documentRequest) {
     return [];
   }
@@ -613,7 +613,7 @@ export function generatePreconnectCandidates(
     }
   });
 
-  const groupedOrigins = candidateRequestsByOrigin(parsedTrace, documentRequest, contextRequests, lcpGraphURLs);
+  const groupedOrigins = candidateRequestsByOrigin(data, documentRequest, contextRequests, lcpGraphURLs);
 
   let maxWastedLcp = Types.Timing.Milli(0);
   let maxWastedFcp = Types.Timing.Milli(0);
@@ -671,7 +671,7 @@ export function isNetworkDependencyTree(model: InsightModel): model is NetworkDe
 }
 
 export function generateInsight(
-    parsedTrace: Handlers.Types.ParsedTrace, context: InsightSetContext): NetworkDependencyTreeInsightModel {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): NetworkDependencyTreeInsightModel {
   if (!context.navigation) {
     return finalize({
       rootNodes: [],
@@ -690,11 +690,11 @@ export function generateInsight(
   } = generateNetworkDependencyTree(context);
 
   const isWithinContext = (event: Types.Events.Event): boolean => Helpers.Timing.eventIsInBounds(event, context.bounds);
-  const contextRequests = parsedTrace.NetworkRequests.byTime.filter(isWithinContext);
+  const contextRequests = data.NetworkRequests.byTime.filter(isWithinContext);
 
-  const preconnectCandidates = generatePreconnectCandidates(parsedTrace, context, contextRequests);
+  const preconnectCandidates = generatePreconnectCandidates(data, context, contextRequests);
 
-  const preconnectedOrigins = generatePreconnectedOrigins(parsedTrace, context, contextRequests, preconnectCandidates);
+  const preconnectedOrigins = generatePreconnectedOrigins(data, context, contextRequests, preconnectCandidates);
 
   return finalize({
     rootNodes,