@vellumai/assistant 0.7.0 → 0.7.1

package/src/memory/v2/skill-store.ts

@@ -2,11 +2,13 @@
 // Memory v2 — Skill catalog → embedded skill entries
 // ---------------------------------------------------------------------------
 //
-// Mirrors v1's `seedSkillGraphNodes` (capability-seed.ts) for the v2 pipeline:
-// enumerate the enabled-skill catalog, render each skill's prose statement via
-// `buildSkillContent`, embed dense + sparse, upsert into the dedicated
+// Mirrors v1's `seedSkillGraphNodes` + `seedUninstalledCatalogSkillMemories`
+// (capability-seed.ts) for the v2 pipeline: enumerate the enabled-skill
+// catalog AND uninstalled catalog skills, render each skill's prose statement
+// via `buildSkillContent`, embed dense + sparse, upsert into the dedicated
 // `memory_v2_skills` Qdrant collection, and prune stale points from prior
-// catalog state.
+// catalog state. Including uninstalled catalog skills ensures their activation
+// hints are discoverable by intent so the model can auto-install them.
 //
 // Unlike v1, skill entries are kept in a small in-process cache so the render
 // path can fetch a `SkillEntry` synchronously by id without round-tripping to
@@ -17,7 +19,11 @@ import { isAssistantFeatureFlagEnabled } from "../../config/assistant-feature-fl
 import { getConfig } from "../../config/loader.js";
 import { resolveSkillStates } from "../../config/skill-state.js";
 import { loadSkillCatalog } from "../../config/skills.js";
-import { fromSkillSummary } from "../../skills/skill-memory.js";
+import { getCatalog } from "../../skills/catalog-cache.js";
+import {
+  fromCatalogSkill,
+  fromSkillSummary,
+} from "../../skills/skill-memory.js";
 import { getLogger } from "../../util/logger.js";
 import {
   embedWithBackend,
@@ -55,6 +61,9 @@ let entries: Map<string, SkillEntry> | null = null;
  *      already enforces this, but we mirror v1's enforcement point so the v2
  *      collection never holds an embedding for a flag-gated skill if the two
  *      ever drift.
+ *   3b. Fetch the full remote catalog and seed any uninstalled skills so their
+ *      activation hints are discoverable by semantic search. Best-effort: if
+ *      the catalog fetch fails, only installed skills are seeded.
  *   4. Embed all `content` strings in a single dense `embedWithBackend` call,
  *      and a per-skill synchronous `generateSparseEmbedding`.
  *   5. Upsert one Qdrant point per skill via `upsertSkillEmbedding` (keyed
@@ -70,6 +79,13 @@ export async function seedV2SkillEntries(): Promise<void> {
     const resolved = resolveSkillStates(catalog, config);
     const enabled = resolved.filter((r) => r.state === "enabled");
 
+    // Track every locally-installed skill id (regardless of enabled/disabled
+    // state) so the catalog-seeding loop below treats them all as "installed"
+    // and never re-seeds a disabled skill from `getCatalog()` as if it were
+    // uninstalled. Mirrors v1's `seedUninstalledCatalogSkillMemories`, which
+    // keys off `loadSkillCatalog()` (the installed set) for the same reason.
+    const installedIds = new Set<string>(catalog.map((s) => s.id));
+
     // Build the input list, applying the mcp-setup description augmentation
     // and the defense-in-depth feature-flag filter.
     const seeds: SkillEntry[] = [];
@@ -82,6 +98,28 @@ export async function seedV2SkillEntries(): Promise<void> {
       seeds.push({ id: summary.id, content });
     }
 
+    // Seed uninstalled catalog skills so their activation hints are
+    // discoverable by intent (mirrors v1's seedUninstalledCatalogSkillMemories).
+    // Track whether the catalog was available so we can guard pruning below.
+    let catalogAvailable = false;
+    try {
+      const fullCatalog = await getCatalog();
+      catalogAvailable = fullCatalog.length > 0;
+      for (const entry of fullCatalog) {
+        if (installedIds.has(entry.id)) continue;
+        const flagKey = entry.metadata?.vellum?.["feature-flag"];
+        if (flagKey && !isAssistantFeatureFlagEnabled(flagKey, config))
+          continue;
+        const content = buildSkillContent(fromCatalogSkill(entry));
+        seeds.push({ id: entry.id, content });
+      }
+    } catch (err) {
+      log.warn(
+        { err },
+        "Failed to fetch catalog for uninstalled skill seeding — continuing with installed skills only",
+      );
+    }
+
     // Embed all content strings in one batched call. Sparse vectors are
     // computed in-process (no network).
     const { vectors: denseVectors } = await embedWithBackend(
@@ -102,8 +140,18 @@ export async function seedV2SkillEntries(): Promise<void> {
       nextEntries.set(seed.id, seed);
     }
 
-    // Prune any points whose id is no longer in the active set.
-    await pruneSkillsExcept(seeds.map((s) => s.id));
+    // Prune stale points. When the catalog is unavailable (empty array from
+    // network failure or cold cache), we cannot enumerate which uninstalled
+    // catalog skills should exist, so skip pruning entirely to avoid
+    // aggressively removing previously-seeded catalog skill embeddings.
+    // Mirrors v1's safeguard in capability-seed.ts (lines 124–143).
+    if (catalogAvailable) {
+      await pruneSkillsExcept(seeds.map((s) => s.id));
+    } else {
+      log.info(
+        "Catalog unavailable — skipping skill pruning to preserve prior catalog embeddings",
+      );
+    }
 
     // Atomically replace the cache only after every step above succeeds.
     entries = nextEntries;

package/src/memory/v2/static-context.ts

@@ -0,0 +1,62 @@
+// ---------------------------------------------------------------------------
+// Memory v2 — Static context loader for user-message auto-injection
+// ---------------------------------------------------------------------------
+//
+// Reads the four top-level memory files (essentials/threads/recent/buffer)
+// and returns a concatenated, header-wrapped block ready to splice into the
+// current user message via the injector chain.
+//
+// Pairs with the v2 per-turn activation block (`prependMemoryV2Block` in
+// `conversation-graph-memory.ts`) — that block carries activated concept
+// pages selected by the activation pipeline; this static block carries the
+// always-relevant aggregate views written by consolidation and the user.
+// Both land on the user message so the system prompt stays cache-stable.
+//
+// Refresh cadence is owned by the caller: the agent loop only passes the
+// content through when `mode === "full"` (first turn / post-compaction),
+// matching the existing PKB auto-inject pattern.
+
+import { isAssistantFeatureFlagEnabled } from "../../config/assistant-feature-flags.js";
+import { loadConfig } from "../../config/loader.js";
+import { readPromptFile } from "../../prompts/system-prompt.js";
+import { getWorkspacePromptPath } from "../../util/platform.js";
+
+interface MemoryV2StaticBlock {
+  heading: string;
+  file: string;
+}
+
+const MEMORY_V2_STATIC_BLOCKS: readonly MemoryV2StaticBlock[] = [
+  { heading: "## Essentials", file: "memory/essentials.md" },
+  { heading: "## Threads", file: "memory/threads.md" },
+  { heading: "## Recent", file: "memory/recent.md" },
+  { heading: "## Buffer", file: "memory/buffer.md" },
+];
+
+/**
+ * Build the v2 static memory block, gated on `memory-v2-enabled` +
+ * `config.memory.v2.enabled`. Empty/missing files are skipped; returns
+ * `null` when the gate is off or every file is empty.
+ */
+export function readMemoryV2StaticContent(): string | null {
+  let config;
+  try {
+    config = loadConfig();
+  } catch {
+    return null;
+  }
+  if (
+    !isAssistantFeatureFlagEnabled("memory-v2-enabled", config) ||
+    !config.memory.v2.enabled
+  ) {
+    return null;
+  }
+
+  const sections: string[] = [];
+  for (const { heading, file } of MEMORY_V2_STATIC_BLOCKS) {
+    const content = readPromptFile(getWorkspacePromptPath(file));
+    if (!content) continue;
+    sections.push(`${heading}\n\n${content}`);
+  }
+  return sections.length > 0 ? sections.join("\n\n") : null;
+}

package/src/memory/v2/types.ts

@@ -20,9 +20,12 @@ import { z } from "zod";
 /**
  * YAML frontmatter at the top of a concept page (`memory/concepts/<slug>.md`).
  *
- * `edges` is a derived view of `memory/edges.json` — it is regenerated by
- * the rebuild-edges backfill job and is not the source of truth for the graph
- * topology. `ref_files` lists paths to attached media (images, audio, etc.).
+ * `edges` is the canonical list of *outgoing* directed edges from this page.
+ * Each entry is the slug of another concept page; an entry of `B` in A's
+ * `edges:` means "activating A pulls in B" — activation flows A → B but not
+ * B → A. The full graph is the union of every page's `edges:` list — there
+ * is no separate edges-index file. `ref_files` lists paths to attached media
+ * (images, audio, etc.).
  */
 export const ConceptPageFrontmatterSchema = z.object({
   edges: z.array(z.string()).default([]),
@@ -34,8 +37,10 @@ export type ConceptPageFrontmatter = z.infer<
 >;
 
 /**
- * A single concept page on disk. The slug is the filename minus `.md` and
- * also the stable identity used in edges and activation state.
+ * A single concept page on disk. The slug is the relative path from
+ * `memory/concepts/` minus `.md`, using forward slashes — so `alice` and
+ * `people/alice` are both valid slugs. The slug is the stable identity used
+ * in edges and activation state.
  */
 export const ConceptPageSchema = z.object({
   slug: z.string(),
@@ -45,21 +50,6 @@ export const ConceptPageSchema = z.object({
 
 export type ConceptPage = z.infer<typeof ConceptPageSchema>;
 
-// ---------------------------------------------------------------------------
-// Edges index (`memory/edges.json`)
-// ---------------------------------------------------------------------------
-
-/**
- * Source of truth for v2 graph topology. Edges are unweighted, undirected,
- * and stored as canonicalized 2-tuples (alphabetical-first slug first).
- */
-export const EdgesIndexSchema = z.object({
-  version: z.literal(1),
-  edges: z.array(z.tuple([z.string(), z.string()])),
-});
-
-export type EdgesIndex = z.infer<typeof EdgesIndexSchema>;
-
 // ---------------------------------------------------------------------------
 // Activation state (per-conversation, persisted in SQLite)
 // ---------------------------------------------------------------------------

package/src/memory/validation.ts

@@ -1,19 +1,8 @@
-import { z } from "zod";
-
 /**
  * Unit interval [0, 1] — used for confidence and importance fields on memory items.
  * Coerces out-of-range numbers to the nearest bound rather than rejecting,
  * since LLM-generated values occasionally exceed the range.
  */
-const unitInterval = z
-  .number()
-  .transform((v) => Math.min(1, Math.max(0, v)));
-
-/** Zod schema for validating confidence/importance values on memory items. */
-export const memoryItemScores = z.object({
-  confidence: unitInterval,
-  importance: unitInterval,
-});
 
 /** Clamp a numeric value to [0, 1]. */
 export function clampUnitInterval(value: number): number {

package/src/messaging/draft-store.ts

@@ -62,12 +62,6 @@ export function createDraft(opts: {
   return draft;
 }
 
-export function getDraft(platform: string, id: string): Draft | null {
-  const path = getDraftPath(platform, id);
-  if (!pathExists(path)) return null;
-  return JSON.parse(readFileSync(path, "utf-8")) as Draft;
-}
-
 export function listDrafts(platform: string): Draft[] {
   const dir = getDraftsDir(platform);
   const files = readdirSync(dir).filter((f) => f.endsWith(".json"));

package/src/messaging/provider-types.ts

@@ -41,6 +41,12 @@ export interface SearchResult {
   nextCursor?: string;
 }
 
+export interface HistoryPageResult {
+  messages: Message[];
+  hasMore: boolean;
+  nextCursor?: string;
+}
+
 export interface SendResult {
   id: string;
   timestamp: number;
@@ -66,6 +72,8 @@ export interface HistoryOptions {
   limit?: number;
   before?: string;
   after?: string;
+  cursor?: string;
+  inclusive?: boolean;
 }
 
 export interface SearchOptions {

package/src/messaging/provider.ts

@@ -11,6 +11,7 @@ import type {
   ConnectionInfo,
   Conversation,
   HistoryOptions,
+  HistoryPageResult,
   ListOptions,
   Message,
   SearchOptions,
@@ -60,6 +61,12 @@ export interface MessagingProvider {
     threadId: string,
     options?: HistoryOptions,
   ): Promise<Message[]>;
+  getThreadRepliesPage?(
+    connection: OAuthConnection | undefined,
+    conversationId: string,
+    threadId: string,
+    options?: HistoryOptions,
+  ): Promise<HistoryPageResult>;
   markRead?(
     connection: OAuthConnection | undefined,
     conversationId: string,

package/src/messaging/providers/gmail/client.ts

@@ -3,12 +3,7 @@ import type {
   OAuthConnectionResponse,
 } from "../../../oauth/connection.js";
 import type {
-  GmailAttachment,
   GmailDraft,
-  GmailFilter,
-  GmailFilterAction,
-  GmailFilterCriteria,
-  GmailFiltersListResponse,
   GmailLabel,
   GmailLabelsListResponse,
   GmailMessage,
@@ -17,7 +12,6 @@ import type {
   GmailModifyRequest,
   GmailProfile,
   GmailThread,
-  GmailVacationSettings,
 } from "./types.js";
 
 const GMAIL_BATCH_URL = "https://www.googleapis.com/batch/gmail/v1";
@@ -237,7 +231,7 @@ export async function listMessages(
 }
 
 /** Get a single message by ID. */
-export async function getMessage(
+async function getMessage(
   connection: OAuthConnection,
   messageId: string,
   format: GmailMessageFormat = "full",
@@ -591,17 +585,6 @@ export async function batchModifyMessages(
   });
 }
 
-/** Move a message to trash. */
-export async function trashMessage(
-  connection: OAuthConnection,
-  messageId: string,
-): Promise<GmailMessage> {
-  return request<GmailMessage>(connection, `/messages/${messageId}/trash`, {
-    method: "POST",
-    retryable: true,
-  });
-}
-
 /** List all labels. */
 export async function listLabels(
   connection: OAuthConnection,
@@ -659,17 +642,6 @@ export async function createDraftRaw(
   });
 }
 
-/** Send an existing draft by ID. */
-export async function sendDraft(
-  connection: OAuthConnection,
-  draftId: string,
-): Promise<GmailMessage> {
-  return request<GmailMessage>(connection, "/drafts/send", {
-    method: "POST",
-    body: JSON.stringify({ id: draftId }),
-  });
-}
-
 /** Send an email. */
 export async function sendMessage(
   connection: OAuthConnection,
@@ -707,95 +679,3 @@ export async function getProfile(
 ): Promise<GmailProfile> {
   return request<GmailProfile>(connection, "/profile");
 }
-
-/** Get attachment data for a message. */
-export async function getAttachment(
-  connection: OAuthConnection,
-  messageId: string,
-  attachmentId: string,
-): Promise<GmailAttachment> {
-  return request<GmailAttachment>(
-    connection,
-    `/messages/${messageId}/attachments/${attachmentId}`,
-  );
-}
-
-/** Send an email with a pre-built raw MIME payload (for multipart/attachments). */
-export async function sendMessageRaw(
-  connection: OAuthConnection,
-  raw: string,
-  threadId?: string,
-): Promise<GmailMessage> {
-  const payload: Record<string, unknown> = { raw };
-  if (threadId) payload.threadId = threadId;
-  return request<GmailMessage>(connection, "/messages/send", {
-    method: "POST",
-    body: JSON.stringify(payload),
-  });
-}
-
-/** Create a user label. */
-export async function createLabel(
-  connection: OAuthConnection,
-  name: string,
-  opts?: {
-    messageListVisibility?: "show" | "hide";
-    labelListVisibility?: "labelShow" | "labelShowIfUnread" | "labelHide";
-  },
-): Promise<GmailLabel> {
-  return request<GmailLabel>(connection, "/labels", {
-    method: "POST",
-    body: JSON.stringify({ name, ...opts }),
-  });
-}
-
-/** List all Gmail filters. */
-export async function listFilters(
-  connection: OAuthConnection,
-): Promise<GmailFilter[]> {
-  const resp = await request<GmailFiltersListResponse>(
-    connection,
-    "/settings/filters",
-  );
-  return resp.filter ?? [];
-}
-
-/** Create a Gmail filter. */
-export async function createFilter(
-  connection: OAuthConnection,
-  criteria: GmailFilterCriteria,
-  action: GmailFilterAction,
-): Promise<GmailFilter> {
-  return request<GmailFilter>(connection, "/settings/filters", {
-    method: "POST",
-    body: JSON.stringify({ criteria, action }),
-  });
-}
-
-/** Delete a Gmail filter. */
-export async function deleteFilter(
-  connection: OAuthConnection,
-  filterId: string,
-): Promise<void> {
-  await request<void>(connection, `/settings/filters/${filterId}`, {
-    method: "DELETE",
-  });
-}
-
-/** Get vacation auto-reply settings. */
-export async function getVacation(
-  connection: OAuthConnection,
-): Promise<GmailVacationSettings> {
-  return request<GmailVacationSettings>(connection, "/settings/vacation");
-}
-
-/** Update vacation auto-reply settings. */
-export async function updateVacation(
-  connection: OAuthConnection,
-  settings: GmailVacationSettings,
-): Promise<GmailVacationSettings> {
-  return request<GmailVacationSettings>(connection, "/settings/vacation", {
-    method: "PUT",
-    body: JSON.stringify(settings),
-  });
-}

package/src/messaging/providers/outlook/client.ts

@@ -162,23 +162,6 @@ export async function listMessages(
   );
 }
 
-/** Get a single message by ID. */
-export async function getMessage(
-  connection: OAuthConnection,
-  messageId: string,
-  select?: string,
-): Promise<OutlookMessage> {
-  const query: Record<string, string> = {};
-  if (select) query["$select"] = select;
-
-  return request<OutlookMessage>(
-    connection,
-    `/v1.0/me/messages/${encodeURIComponent(messageId)}`,
-    undefined,
-    Object.keys(query).length > 0 ? query : undefined,
-  );
-}
-
 /** Search messages using Microsoft Graph KQL syntax. */
 export async function searchMessages(
   connection: OAuthConnection,
@@ -278,38 +261,6 @@ export async function markMessageRead(
   );
 }
 
-/** Patch arbitrary fields on a message (e.g. to update recipients on a draft). */
-export async function patchMessage(
-  connection: OAuthConnection,
-  messageId: string,
-  fields: Record<string, unknown>,
-): Promise<OutlookMessage> {
-  return request<OutlookMessage>(
-    connection,
-    `/v1.0/me/messages/${encodeURIComponent(messageId)}`,
-    {
-      method: "PATCH",
-      body: JSON.stringify(fields),
-    },
-  );
-}
-
-/** Move a message to a different folder (e.g. for archiving). */
-export async function moveMessage(
-  connection: OAuthConnection,
-  messageId: string,
-  destinationFolderId: string,
-): Promise<OutlookMessage> {
-  return request<OutlookMessage>(
-    connection,
-    `/v1.0/me/messages/${encodeURIComponent(messageId)}/move`,
-    {
-      method: "POST",
-      body: JSON.stringify({ destinationId: destinationFolderId }),
-    },
-  );
-}
-
 /** Create a draft message in the user's Drafts folder. */
 export async function createDraft(
   connection: OAuthConnection,
@@ -389,30 +340,6 @@ export async function createForwardDraft(
 }
 
 /** Max concurrent individual getMessage requests for batch fetching. */
-const BATCH_CONCURRENCY = 5;
-
-/** Fetch multiple messages with concurrency limiting. */
-export async function batchGetMessages(
-  connection: OAuthConnection,
-  messageIds: string[],
-  select?: string,
-): Promise<OutlookMessage[]> {
-  if (messageIds.length === 0) return [];
-
-  if (messageIds.length === 1) {
-    return [await getMessage(connection, messageIds[0], select)];
-  }
-
-  const results: OutlookMessage[] = [];
-  for (let i = 0; i < messageIds.length; i += BATCH_CONCURRENCY) {
-    const wave = messageIds.slice(i, i + BATCH_CONCURRENCY);
-    const waveResults = await Promise.all(
-      wave.map((id) => getMessage(connection, id, select)),
-    );
-    results.push(...waveResults);
-  }
-  return results;
-}
 
 /** List attachments on a message. */
 export async function listAttachments(