@vellumai/assistant 0.7.0 → 0.7.1

package/src/__tests__/get-skill-detail-audit.test.ts

@@ -188,12 +188,7 @@ import { getSkill } from "../daemon/handlers/skills.js";
 // Helpers
 // ---------------------------------------------------------------------------
 
-const dummyCtx = {
-  debounceTimers: { schedule: () => {} },
-  setSuppressConfigReload: () => {},
-  updateConfigFingerprint: () => {},
-  broadcast: () => {},
-} as unknown as Parameters<typeof getSkill>[1];
+
 
 // ---------------------------------------------------------------------------
 // Tests
@@ -245,7 +240,7 @@ describe("getSkill — skillssh audit enrichment", () => {
       },
     });
 
-    const result = await getSkill("acme/tools/lint", dummyCtx);
+    const result = await getSkill("acme/tools/lint");
 
     // Should succeed
     expect("skill" in result).toBe(true);
@@ -303,7 +298,7 @@ describe("getSkill — skillssh audit enrichment", () => {
       new Error("audit service unavailable"),
     );
 
-    const result = await getSkill("org/repo/my-tool", dummyCtx);
+    const result = await getSkill("org/repo/my-tool");
 
     // Should still succeed — audit failure is non-fatal
     expect("skill" in result).toBe(true);

package/src/__tests__/guardian-binding-drift-heal.test.ts

@@ -8,10 +8,10 @@ mock.module("../util/logger.js", () => ({
 }));
 
 import { findGuardianForChannel } from "../contacts/contact-store.js";
-import { createGuardianBinding } from "../contacts/contacts-write.js";
 import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { healGuardianBindingDrift } from "../runtime/guardian-vellum-migration.js";
+import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
 
 initializeDb();
 

package/src/__tests__/guardian-dispatch.test.ts

@@ -64,10 +64,10 @@ import {
   createPendingQuestion,
 } from "../calls/call-store.js";
 import { dispatchGuardianQuestion } from "../calls/guardian-dispatch.js";
-import { createGuardianBinding } from "../contacts/contacts-write.js";
 import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { conversations } from "../memory/schema.js";
+import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
 
 initializeDb();
 

package/src/__tests__/guardian-grant-minting.test.ts

@@ -19,6 +19,11 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
+const _conversationMocks = new Map<string, unknown>();
+mock.module("../daemon/conversation-store.js", () => ({
+  findConversation: (id: string) => _conversationMocks.get(id),
+}));
+
 import { GRANT_TTL_MS } from "../approvals/guardian-decision-primitive.js";
 import type { Conversation } from "../daemon/conversation.js";
 import type { TrustContext } from "../daemon/trust-context.js";
@@ -93,13 +98,13 @@ function registerPendingInteraction(
   input: Record<string, unknown> = TOOL_INPUT,
 ): ReturnType<typeof mock> {
   const handleConfirmationResponse = mock(() => {});
-  const mockSession = {
+  const _mockSession = {
     handleConfirmationResponse,
     ensureActorScopedHistory: async () => {},
   } as unknown as Conversation;
+  _conversationMocks.set(conversationId, _mockSession);
 
   pendingInteractions.register(requestId, {
-    conversation: mockSession,
     conversationId,
     kind: "confirmation",
     confirmationDetails: {

package/src/__tests__/guardian-routing-invariants.test.ts

@@ -20,6 +20,11 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../config/env.js", () => ({ isHttpAuthDisabled: () => true }));
 
+const _conversationMocks = new Map<string, unknown>();
+mock.module("../daemon/conversation-store.js", () => ({
+  findConversation: (id: string) => _conversationMocks.get(id),
+}));
+
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
     new Proxy({} as Record<string, unknown>, {
@@ -105,13 +110,13 @@ function registerPendingToolApprovalInteraction(
   toolName: string = "shell",
 ): ReturnType<typeof mock> {
   const handleConfirmationResponse = mock(() => {});
-  const mockSession = {
+  const _mockSession = {
     handleConfirmationResponse,
     ensureActorScopedHistory: async () => {},
   } as unknown as import("../daemon/conversation.js").Conversation;
+  _conversationMocks.set(conversationId, _mockSession);
 
   pendingInteractions.register(requestId, {
-    conversation: mockSession,
     conversationId,
     kind: "confirmation",
     confirmationDetails: {

package/src/__tests__/guardian-routing-state.test.ts

@@ -15,7 +15,6 @@ mock.module("../util/logger.js", () => ({
 }));
 
 import { upsertContact } from "../contacts/contact-store.js";
-import { createGuardianBinding } from "../contacts/contacts-write.js";
 import type { TrustContext } from "../daemon/trust-context.js";
 import { getDb } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
@@ -30,6 +29,7 @@ import {
   handleChannelInbound,
   setAdapterProcessMessage,
 } from "./helpers/channel-test-adapter.js";
+import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
 
 initializeDb();
 

package/src/__tests__/handlers-skills-memory-v2-reseed.test.ts

@@ -67,15 +67,27 @@ mock.module("../config/assistant-feature-flags.js", () => ({
 // run in the same Bun process because `mock.module` replacements persist
 // across files.
 mock.module("../config/loader.js", () => ({
+  API_KEY_PROVIDERS: [],
+  applyNestedDefaults: (c: unknown) => c,
+  deepMergeMissing: (a: unknown) => a,
+  deepMergeOverwrite: (a: unknown) => a,
+  mergeDefaultWorkspaceConfig: () => {},
   getConfig: () => ({
     memory: { v2: { enabled: flagsState.configV2Enabled } },
   }),
+  getConfigReadOnly: () => ({
+    memory: { v2: { enabled: flagsState.configV2Enabled } },
+  }),
   loadConfig: () => ({
     memory: { v2: { enabled: flagsState.configV2Enabled } },
   }),
+  saveConfig: () => {},
   invalidateConfigCache: () => {},
   loadRawConfig: () => ({}),
   saveRawConfig: () => {},
+  getNestedValue: () => undefined,
+  setNestedValue: () => {},
+  _appendQuarantineBulletin: () => {},
 }));
 
 mock.module("../config/skill-state.js", () => ({
@@ -116,12 +128,17 @@ mock.module("../skills/install-meta.js", () => ({
 }));
 
 mock.module("../providers/provider-send-message.js", () => ({
+  ContextOverflowError: class extends Error {},
+  isContextOverflowError: () => false,
+  resolveConfiguredProvider: async () => null,
+  getConfiguredProvider: async () => null,
   createTimeout: () => ({
     signal: AbortSignal.timeout(1000),
     cleanup: () => {},
   }),
   extractText: () => "",
-  getConfiguredProvider: async () => null,
+  extractAllText: () => "",
+  extractToolUse: () => [],
   userMessage: () => ({}),
 }));
 
@@ -160,6 +177,7 @@ mock.module("../memory/graph/capability-seed.js", () => ({
 
 mock.module("../memory/v2/skill-store.js", () => ({
   seedV2SkillEntries: mock(async () => {}),
+  getSkillCapability: () => null,
 }));
 
 mock.module("../daemon/memory-v2-startup.js", () => ({
@@ -181,6 +199,16 @@ mock.module("../daemon/handlers/shared.js", () => ({
   },
 }));
 
+mock.module("../daemon/config-watcher.js", () => ({
+  ConfigWatcher: class {},
+  getConfigWatcher: () => ({
+    suppressConfigReload: false,
+    timers: { schedule: (_k: string, _ms: number, fn: () => void) => fn() },
+    updateFingerprint: () => {},
+  }),
+  cleanupSettingsChanged: () => false,
+}));
+
 // Import after mocking
 const { installSkill } = await import("../daemon/handlers/skills.js");
 
@@ -188,13 +216,6 @@ const { installSkill } = await import("../daemon/handlers/skills.js");
 // Helpers
 // ---------------------------------------------------------------------------
 
-const dummyCtx = {
-  debounceTimers: { schedule: () => {} },
-  setSuppressConfigReload: () => {},
-  updateConfigFingerprint: () => {},
-  broadcast: () => {},
-} as unknown as Parameters<typeof installSkill>[1];
-
 // ---------------------------------------------------------------------------
 // Tests
 // ---------------------------------------------------------------------------
@@ -213,7 +234,7 @@ describe("v2 skill re-seed gating in skill handlers", () => {
   });
 
   test("flag + config both on → maybeSeedMemoryV2Skills invoked after seedSkillGraphNodes", async () => {
-    const result = await installSkill({ slug: "bundled-skill" }, dummyCtx);
+    const result = await installSkill({ slug: "bundled-skill" });
 
     expect(result.success).toBe(true);
     expect(mockSeedSkillGraphNodes).toHaveBeenCalledTimes(1);
@@ -224,7 +245,7 @@ describe("v2 skill re-seed gating in skill handlers", () => {
   test("flag off → seed mock observes the disabled flag and skips", async () => {
     flagsState.flagEnabled = false;
 
-    const result = await installSkill({ slug: "bundled-skill" }, dummyCtx);
+    const result = await installSkill({ slug: "bundled-skill" });
 
     expect(result.success).toBe(true);
     expect(mockSeedSkillGraphNodes).toHaveBeenCalledTimes(1);
@@ -235,7 +256,7 @@ describe("v2 skill re-seed gating in skill handlers", () => {
   test("config.memory.v2.enabled off → seed mock observes config and skips", async () => {
     flagsState.configV2Enabled = false;
 
-    const result = await installSkill({ slug: "bundled-skill" }, dummyCtx);
+    const result = await installSkill({ slug: "bundled-skill" });
 
     expect(result.success).toBe(true);
     expect(mockSeedSkillGraphNodes).toHaveBeenCalledTimes(1);

package/src/__tests__/handlers-user-message-approval-consumption.test.ts

@@ -11,10 +11,7 @@ import { afterAll, beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../config/env.js", () => ({ isHttpAuthDisabled: () => true }));
 
-import type { HandlerContext } from "../daemon/handlers/shared.js";
 import type { ConfirmationResponse } from "../daemon/message-protocol.js";
-import type { ServerMessage } from "../daemon/message-protocol.js";
-import { DebouncerMap } from "../util/debounce.js";
 
 const resolveCanonicalGuardianRequestMock = mock(
   () => null as { id: string } | null,
@@ -100,7 +97,7 @@ mock.module("../memory/conversation-crud.js", () => ({
 mock.module("../config/loader.js", () => ({
   getConfig: () => ({
     daemon: { standaloneRecording: false },
-    secretDetection: { customPatterns: [], entropyThreshold: 3.5 },
+    secretDetection: {},
   }),
   loadConfig: () => ({}),
   loadRawConfig: () => ({}),
@@ -149,83 +146,6 @@ import {
 } from "../daemon/conversation-store.js";
 import { handleConfirmationResponse } from "../daemon/handlers/conversations.js";
 
-interface TestConversation {
-  messages: Array<{ role: string; content: unknown[] }>;
-  setChannelCapabilities: (caps: unknown) => void;
-  isProcessing: () => boolean;
-  hasPendingConfirmation: (requestId: string) => boolean;
-  hasAnyPendingConfirmation: () => boolean;
-  getQueueDepth: () => number;
-  denyAllPendingConfirmations: () => void;
-  enqueueMessage: (...args: unknown[]) => {
-    queued: boolean;
-    requestId: string;
-  };
-  traceEmitter: { emit: (...args: unknown[]) => void };
-  setTurnChannelContext: (ctx: unknown) => void;
-  setTurnInterfaceContext: (ctx: unknown) => void;
-  setAssistantId: (assistantId: string) => void;
-  setTrustContext: (ctx: unknown) => void;
-  setAuthContext: (ctx: unknown) => void;
-  setCommandIntent: (intent: unknown) => void;
-  updateClient: (
-    sendToClient: (msg: ServerMessage) => void,
-    hasNoClient?: boolean,
-  ) => void;
-  emitActivityState: (...args: unknown[]) => void;
-  emitConfirmationStateChanged: (...args: unknown[]) => void;
-  processMessage: (...args: unknown[]) => Promise<string>;
-}
-
-function createContext(conversationObj: TestConversation): {
-  ctx: HandlerContext;
-  sent: ServerMessage[];
-} {
-  const sent: ServerMessage[] = [];
-  const ctx: HandlerContext = {
-    sharedRequestTimestamps: [],
-    debounceTimers: new DebouncerMap({ defaultDelayMs: 100 }),
-    suppressConfigReload: false,
-    setSuppressConfigReload: () => {},
-    updateConfigFingerprint: () => {},
-    send: (msg) => {
-      sent.push(msg);
-    },
-    broadcast: () => {},
-    clearAllConversations: () => 0,
-    getOrCreateConversation: async () => conversationObj as any,
-    touchConversation: () => {},
-  };
-  return { ctx, sent };
-}
-
-function makeConversation(
-  overrides: Partial<TestConversation> = {},
-): TestConversation {
-  return {
-    messages: [],
-    setChannelCapabilities: () => {},
-    isProcessing: () => false,
-    hasPendingConfirmation: () => true,
-    hasAnyPendingConfirmation: () => true,
-    getQueueDepth: () => 0,
-    denyAllPendingConfirmations: mock(() => {}),
-    enqueueMessage: mock(() => ({ queued: true, requestId: "queued-id" })),
-    traceEmitter: { emit: () => {} },
-    setTurnChannelContext: () => {},
-    setTurnInterfaceContext: () => {},
-    setAssistantId: () => {},
-    setTrustContext: () => {},
-    setAuthContext: () => {},
-    setCommandIntent: () => {},
-    updateClient: () => {},
-    emitActivityState: () => {},
-    emitConfirmationStateChanged: () => {},
-    processMessage: async () => "msg-id",
-    ...overrides,
-  };
-}
-
 describe("handleConfirmationResponse canonical status sync", () => {
   beforeEach(() => {
     clearConversations();
@@ -248,7 +168,6 @@ describe("handleConfirmationResponse canonical status sync", () => {
         requestId === "req-confirm-allow",
       handleConfirmationResponse: mock(() => {}),
     };
-    const { ctx } = createContext(makeConversation());
     setConversation("conv-1", conversationObj as any);
 
     const msg: ConfirmationResponse = {
@@ -257,7 +176,7 @@ describe("handleConfirmationResponse canonical status sync", () => {
       decision: "allow",
     };
 
-    handleConfirmationResponse(msg, ctx);
+    handleConfirmationResponse(msg);
 
     expect(
       (conversationObj.handleConfirmationResponse as any).mock.calls.length,

package/src/__tests__/headless-browser-mode.test.ts

@@ -55,7 +55,7 @@ function makeFakeCdp(
 
 mock.module("../tools/browser/cdp-client/factory.js", () => ({
   getCdpClient: (
-    context: { hostBrowserProxy?: unknown; conversationId: string },
+    context: { conversationId: string },
     options?: { mode?: string },
   ) => {
     factoryModeCalls.push(options?.mode);
@@ -70,9 +70,7 @@ mock.module("../tools/browser/cdp-client/factory.js", () => ({
           ? "cdp-inspect"
           : mode === "local"
             ? "local"
-            : context.hostBrowserProxy
-              ? "extension"
-              : "local";
+            : "local";
     return makeFakeCdp(kind, context.conversationId);
   },
 }));
@@ -632,16 +630,13 @@ describe("browser_mode wiring through tool execution", () => {
     factoryModeCalls.length = 0;
     const overridden = await executeBrowserScreenshot(
       { browser_mode: "extension" },
-      { ...ctx, hostBrowserProxy: {} as never },
+      ctx,
     );
     expect(overridden.isError).toBe(false);
     expect(factoryModeCalls).toEqual(["extension"]);
 
     factoryModeCalls.length = 0;
-    const afterOverride = await executeBrowserScreenshot(
-      {},
-      { ...ctx, hostBrowserProxy: {} as never },
-    );
+    const afterOverride = await executeBrowserScreenshot({}, ctx);
     expect(afterOverride.isError).toBe(false);
     expect(factoryModeCalls).toEqual(["extension"]);
   });

package/src/__tests__/headless-browser-navigate.test.ts

@@ -14,7 +14,7 @@ mock.module("../util/logger.js", () => ({
 // Programmable send handler + call log shared across tests. Each test
 // resets these in `beforeEach` via `resetCdp()`. The mocked
 // `getCdpClient` mirrors the real factory's routing decision (local
-// vs extension is driven by `context.hostBrowserProxy`) so individual
+// vs extension is driven by `mockExtensionAvailable`) so individual
 // tests can exercise either transport without process-wide coupling.
 //
 // Note: bun's `mock.module` is process-global, but `scripts/test.sh`
@@ -46,13 +46,22 @@ function makeFakeCdp(kind: "local" | "extension", conversationId: string) {
   };
 }
 
+let mockExtensionAvailable = false;
+
+mock.module("../daemon/host-browser-proxy.js", () => ({
+  HostBrowserProxy: {
+    get instance() {
+      return mockExtensionAvailable
+        ? { isAvailable: () => true, request: mock(async () => ({})) }
+        : undefined;
+    },
+  },
+}));
+
 mock.module("../tools/browser/cdp-client/factory.js", () => ({
-  getCdpClient: (context: {
-    hostBrowserProxy?: unknown;
-    conversationId: string;
-  }) =>
+  getCdpClient: (context: { conversationId: string }) =>
     makeFakeCdp(
-      context.hostBrowserProxy ? "extension" : "local",
+      mockExtensionAvailable ? "extension" : "local",
       context.conversationId,
     ),
 }));
@@ -263,7 +272,7 @@ describe("executeBrowserNavigate", () => {
       ctx,
     );
     expect(result.isError).toBe(false);
-    expect(result.content).toContain("Status: unknown");
+    expect(result.content).toContain("Final URL:");
   });
 
   test("blocks DNS-resolved private addresses by default", async () => {
@@ -288,7 +297,7 @@ describe("executeBrowserNavigate", () => {
       ctx,
     );
     expect(result.isError).toBe(false);
-    expect(result.content).toContain("Status: unknown");
+    expect(result.content).toContain("Final URL:");
   });
 
   // ── Happy path (CDP navigate) ──────────────────────────────────
@@ -302,7 +311,6 @@ describe("executeBrowserNavigate", () => {
     expect(result.isError).toBe(false);
     expect(result.content).toContain("Requested URL:");
     expect(result.content).toContain("Final URL:");
-    expect(result.content).toContain("Status: unknown");
     expect(result.content).toContain("Title: Example");
 
     // Page.navigate was called with the expected URL
@@ -576,13 +584,8 @@ describe("executeBrowserNavigate", () => {
 
   test("extension path skips Playwright route interception", async () => {
     parseUrlResult = new URL("https://example.com/page");
-    // Supplying a non-null hostBrowserProxy on the context routes the
-    // mocked getCdpClient to the extension path (it mirrors the real
-    // factory's routing logic).
-    const extensionCtx: ToolContext = {
-      ...ctx,
-      hostBrowserProxy: {} as unknown as ToolContext["hostBrowserProxy"],
-    };
+    mockExtensionAvailable = true;
+    const extensionCtx: ToolContext = { ...ctx };
     // Reset page call trackers to verify they are not touched.
     const routeCallsBefore = mockPage.route.mock.calls.length;
     const unrouteCallsBefore = mockPage.unroute.mock.calls.length;
@@ -648,10 +651,8 @@ describe("executeBrowserNavigate", () => {
       return {};
     };
 
-    const extensionCtx: ToolContext = {
-      ...ctx,
-      hostBrowserProxy: {} as unknown as ToolContext["hostBrowserProxy"],
-    };
+    mockExtensionAvailable = true;
+    const extensionCtx: ToolContext = { ...ctx };
     const result = await executeBrowserNavigate(
       { url: "https://public.example.com/start" },
       extensionCtx,