@vellumai/assistant 0.7.0 → 0.7.1

package/src/runtime/routes/migration-routes.ts

@@ -15,12 +15,15 @@
  */
 
 import { createReadStream } from "node:fs";
+import { hostname } from "node:os";
 import { PassThrough, Readable } from "node:stream";
 import { Database } from "bun:sqlite";
 
 import { z } from "zod";
 
+import { getPlatformAssistantId } from "../../config/env.js";
 import { invalidateConfigCache } from "../../config/loader.js";
+import { getAssistantName } from "../../daemon/identity-helpers.js";
 import { getDb, resetDb } from "../../memory/db-connection.js";
 import { validateMigrationState } from "../../memory/migrations/validate-migration-state.js";
 import { credentialKey } from "../../security/credential-key.js";
@@ -40,6 +43,8 @@ import {
   getWorkspaceDir,
   getWorkspaceHooksDir,
 } from "../../util/platform.js";
+import { APP_VERSION } from "../../version.js";
+import { DAEMON_INTERNAL_ASSISTANT_ID } from "../assistant-scope.js";
 import {
   validateGcsSignedUrl,
   type ValidateGcsSignedUrlOptions,
@@ -48,6 +53,13 @@ import {
   JobAlreadyInProgressError,
   migrationJobs,
 } from "../migrations/job-registry.js";
+import { getOriginMode } from "../migrations/origin-mode.js";
+import type {
+  VBundleAssistantInfo,
+  VBundleCompatibility,
+  VBundleExportOptions,
+  VBundleOriginInfo,
+} from "../migrations/vbundle-builder.js";
 import { streamExportVBundle } from "../migrations/vbundle-builder.js";
 import {
   analyzeImport,
@@ -136,6 +148,110 @@ export async function reconcileVellumMetadataFromCes(warningSink: {
 
 const log = getLogger("migration-routes");
 
+/**
+ * Fields the export pipeline must populate on the v1 manifest.
+ *
+ * Centralized so both the synchronous-bytes and async-to-gcs handlers
+ * compute the same values (and a future caller doesn't accidentally drift).
+ */
+interface ExportManifestInputs {
+  assistant: VBundleAssistantInfo;
+  origin: VBundleOriginInfo;
+  compatibility: VBundleCompatibility;
+  exportOptions: VBundleExportOptions;
+}
+
+/**
+ * Resolve the `assistant.id` for an export.
+ *
+ * Mirrors `platform/client.ts`'s precedence: in-memory override (set at
+ * daemon startup or by secret-routes) → credential store → daemon-internal
+ * fallback. The schema requires `id` to be non-empty, so we fall back to
+ * `DAEMON_INTERNAL_ASSISTANT_ID` rather than the empty string.
+ */
+async function resolveAssistantId(): Promise<string> {
+  const inMemory = getPlatformAssistantId();
+  if (inMemory) return inMemory;
+  try {
+    const stored = await getSecureKeyAsync(
+      credentialKey("vellum", "platform_assistant_id"),
+    );
+    if (stored) return stored;
+  } catch (err) {
+    log.warn(
+      { err },
+      "Failed to read platform_assistant_id from credential store; falling back to daemon-internal id",
+    );
+  }
+  return DAEMON_INTERNAL_ASSISTANT_ID;
+}
+
+/**
+ * Decide the truthful `secrets_redacted` flag for an export.
+ *
+ * The export entry points pass every collected credential through to the
+ * builder unfiltered, so the bundle is NOT redacted whenever any
+ * credentials made it in. Only flip to true when the credential list is
+ * empty AND every credential read succeeded — i.e. there genuinely are
+ * no secrets in the bundle.
+ *
+ * Two failure modes both force `false`:
+ *   - `storeUnreachable`: the top-level `listSecureKeysAsync()` call
+ *     failed, so we never even discovered which accounts exist.
+ *   - `perAccountUnreachable`: the LIST call succeeded but one or more
+ *     individual `getSecureKeyResultAsync(account)` reads returned
+ *     `unreachable: true`. Those accounts were silently skipped from the
+ *     `credentials` array, so a `credentialCount === 0` outcome could
+ *     reflect "we couldn't read them" rather than "no secrets exist".
+ *     Claiming a clean redaction in that case would be a lie.
+ *
+ * NOTE: a managed-mode bundle with `secrets_redacted: false` will fail
+ * the validator's cross-field refine. That surfaces an existing
+ * platform-side enforcement gap — the runtime emits the truthful value
+ * and lets the schema flag it.
+ */
+export function computeSecretsRedacted(
+  credentialCount: number,
+  storeUnreachable: boolean,
+  perAccountUnreachable: boolean,
+): boolean {
+  return credentialCount === 0 && !storeUnreachable && !perAccountUnreachable;
+}
+
+/**
+ * Compute the v1 manifest inputs that aren't tied to per-call options.
+ *
+ * `walkDirectoryForMetadata` skips `embedding-models`, `data/qdrant`,
+ * `signals`, and `deprecated` — `logs` is NOT in the skip list, so log
+ * files end up in `manifest.contents`. Browser state and memory vectors
+ * (qdrant) are skipped, so those flags are false.
+ */
+async function buildExportManifestInputs(): Promise<ExportManifestInputs> {
+  const assistantId = await resolveAssistantId();
+  const assistantName = getAssistantName() ?? "Assistant";
+  const originMode = await getOriginMode();
+  return {
+    assistant: {
+      id: assistantId,
+      name: assistantName,
+      runtime_version: APP_VERSION,
+    },
+    origin: {
+      mode: originMode,
+      hostname: hostname(),
+    },
+    compatibility: {
+      min_runtime_version: APP_VERSION,
+      max_runtime_version: null,
+    },
+    exportOptions: {
+      include_logs: true,
+      include_browser_state: false,
+      include_memory_vectors: false,
+    },
+  };
+}
+
 /**
  * POST /v1/migrations/validate
  *
@@ -188,18 +304,21 @@ export async function handleMigrationValidate({
  *
  * Auth: Requires settings.write scope. Allowed for actor, svc_gateway, svc_daemon, local.
  */
-export async function handleMigrationExport({
-  body,
-}: RouteHandlerArgs): Promise<RouteResponse> {
-  const description =
-    typeof body?.description === "string" ? body.description : undefined;
-
+export async function handleMigrationExport(
+  _args: RouteHandlerArgs,
+): Promise<RouteResponse> {
+  // The legacy `description` field is no longer carried on the v1
+  // manifest. Older clients still POST it; we silently ignore it.
   let cleanup: (() => Promise<void>) | undefined;
 
   try {
     // Read all stored credentials to include in the export bundle
     const credentialList = await listSecureKeysAsync();
     const credentials: Array<{ account: string; value: string }> = [];
+    // Track per-account read failures separately from the top-level LIST
+    // failure. A single skipped account means we cannot truthfully claim
+    // the bundle is fully redacted — we don't know what we missed.
+    let perAccountUnreachable = false;
     if (credentialList.unreachable) {
       log.warn(
         "Credential store is unreachable — export will not include credentials",
@@ -208,6 +327,7 @@ export async function handleMigrationExport({
       for (const account of credentialList.accounts) {
         const result = await getSecureKeyResultAsync(account);
         if (result.unreachable) {
+          perAccountUnreachable = true;
           log.warn(
             { account },
             "Credential store unreachable when reading credential — skipping",
@@ -218,10 +338,17 @@ export async function handleMigrationExport({
       }
     }
 
+    const manifestInputs = await buildExportManifestInputs();
+    const secretsRedacted = computeSecretsRedacted(
+      credentials.length,
+      credentialList.unreachable,
+      perAccountUnreachable,
+    );
+
     const result = await streamExportVBundle({
       workspaceDir: getWorkspaceDir(),
-      source: "runtime-export",
-      description,
+      ...manifestInputs,
+      secretsRedacted,
       credentials,
       checkpoint: () => {
         const dbPath = getDbPath();
@@ -262,8 +389,12 @@ export async function handleMigrationExport({
       "Content-Type": "application/octet-stream",
       "Content-Disposition": `attachment; filename="${filename}"`,
       "Content-Length": String(size),
-      "X-Vbundle-Schema-Version": manifest.schema_version,
-      "X-Vbundle-Manifest-Sha256": manifest.manifest_sha256,
+      // `schema_version` is now an integer; clients that parse this header
+      // continue to work, but the value flips from "1.0" to "1".
+      "X-Vbundle-Schema-Version": String(manifest.schema_version),
+      // Header name preserved for cross-version client compat; populated
+      // from the renamed manifest `checksum` field.
+      "X-Vbundle-Manifest-Sha256": manifest.checksum,
       "X-Vbundle-Credentials-Included": String(credentials.length),
     });
   } catch (err) {
@@ -288,15 +419,23 @@ const MigrationExportToGcsBody = z.object({
 });
 
 /**
- * Collected credentials plus a warning marker if the credential store was
+ * Collected credentials plus warning markers if the credential store was
  * unreachable. The caller surfaces the warning in logs; production callers
  * fail closed on errors (a thrown exception → 500) to avoid shipping a
  * bundle with partial credentials. An unreachable store is NOT an error —
  * `handleMigrationExport` treats that case as "export without credentials".
+ *
+ * - `unreachable`: the top-level `listSecureKeysAsync()` call failed.
+ * - `perAccountUnreachable`: the LIST succeeded but one or more individual
+ *   `getSecureKeyResultAsync(account)` calls returned `unreachable: true`.
+ *   Those accounts were silently skipped from `credentials`, so the count
+ *   here understates reality. The flag is what tells `computeSecretsRedacted`
+ *   it cannot claim a clean redaction.
  */
 interface CollectedCredentials {
   credentials: Array<{ account: string; value: string }>;
   unreachable: boolean;
+  perAccountUnreachable: boolean;
 }
 
 /**
@@ -311,12 +450,18 @@ async function collectExportCredentials(): Promise<CollectedCredentials> {
     log.warn(
       "Credential store is unreachable — export will not include credentials",
     );
-    return { credentials: [], unreachable: true };
+    return {
+      credentials: [],
+      unreachable: true,
+      perAccountUnreachable: false,
+    };
   }
   const credentials: Array<{ account: string; value: string }> = [];
+  let perAccountUnreachable = false;
   for (const account of credentialList.accounts) {
     const result = await getSecureKeyResultAsync(account);
     if (result.unreachable) {
+      perAccountUnreachable = true;
       log.warn(
         { account },
         "Credential store unreachable when reading credential — skipping",
@@ -325,7 +470,7 @@ async function collectExportCredentials(): Promise<CollectedCredentials> {
       credentials.push({ account, value: result.value });
     }
   }
-  return { credentials, unreachable: false };
+  return { credentials, unreachable: false, perAccountUnreachable };
 }
 
 /**
@@ -355,9 +500,7 @@ async function collectExportCredentials(): Promise<CollectedCredentials> {
  *
  * Auth: settings.write scope (matches `migrations/export`).
  */
-export async function handleMigrationExportToGcs({
-  body,
-}: RouteHandlerArgs) {
+export async function handleMigrationExportToGcs({ body }: RouteHandlerArgs) {
   // ── 1. Parse JSON body ────────────────────────────────────────────────
   const parsed = MigrationExportToGcsBody.safeParse(body);
   if (!parsed.success) {
@@ -399,9 +542,29 @@ export async function handleMigrationExportToGcs({
     );
   }
 
-  const description = parsed.data.description;
   const uploadUrl = parsed.data.upload_url;
 
+  // Compute the v1 manifest inputs once outside the async job runner so we
+  // surface failures (e.g. credential-store probe) as a synchronous 500
+  // before the caller starts polling.
+  let manifestInputs: ExportManifestInputs;
+  try {
+    manifestInputs = await buildExportManifestInputs();
+  } catch (err) {
+    log.error({ err }, "Failed to assemble export manifest inputs");
+    throw new InternalError(
+      err instanceof Error
+        ? err.message
+        : "Failed to assemble export manifest inputs",
+    );
+  }
+
+  const secretsRedacted = computeSecretsRedacted(
+    collected.credentials.length,
+    collected.unreachable,
+    collected.perAccountUnreachable,
+  );
+
   // ── 4. Enqueue the job. The runner captures the collected credentials.
   let job;
   try {
@@ -410,8 +573,8 @@ export async function handleMigrationExportToGcs({
       try {
         const result = await streamExportVBundle({
           workspaceDir: getWorkspaceDir(),
-          source: "runtime-export",
-          description,
+          ...manifestInputs,
+          secretsRedacted,
           credentials: collected.credentials,
           checkpoint: () => {
             const dbPath = getDbPath();
@@ -493,7 +656,7 @@ export async function handleMigrationExportToGcs({
 
         return {
           size,
-          sha256: manifest.manifest_sha256,
+          sha256: manifest.checksum,
           schemaVersion: manifest.schema_version,
           credentialsIncluded: collected.credentials.length,
         };
@@ -557,9 +720,7 @@ async function extractFileData(
       const formData = await syntheticReq.formData();
       const file = formData.get("file");
       if (!file || !(file instanceof Blob)) {
-        throw new BadRequestError(
-          'Multipart upload requires a "file" field',
-        );
+        throw new BadRequestError('Multipart upload requires a "file" field');
       }
       return new Uint8Array(await file.arrayBuffer());
     } catch (err) {
@@ -910,7 +1071,7 @@ class GcsImportError extends Error {
  * The signed URL is never echoed into errors or logs — only the extracted
  * `host`/`path` are.
  */
-export async function runGcsImport(
+async function runGcsImport(
   url: string,
   _correlationId?: string,
 ): Promise<ImportSummary> {
@@ -1303,9 +1464,7 @@ function throwGcsImportError(err: unknown): never {
  *
  * Auth: Requires settings.write scope. Allowed for actor, svc_gateway, svc_daemon, local.
  */
-export async function handleMigrationImportFromGcs({
-  body,
-}: RouteHandlerArgs) {
+export async function handleMigrationImportFromGcs({ body }: RouteHandlerArgs) {
   const parsed = MigrationImportFromGcsBody.safeParse(body);
   if (!parsed.success) {
     throw new BadRequestError(
@@ -1652,8 +1811,7 @@ export const ROUTES: RouteDefinition[] = [
     }),
     additionalResponses: {
       "502": {
-        description:
-          "Upstream fetch failed (URL body only).",
+        description: "Upstream fetch failed (URL body only).",
       },
     },
     responseBody: z.object({
@@ -1710,8 +1868,7 @@ export const ROUTES: RouteDefinition[] = [
     }),
     additionalResponses: {
       "409": {
-        description:
-          "Another import job is already pending or running.",
+        description: "Another import job is already pending or running.",
       },
     },
     handler: handleMigrationImportFromGcs,

package/src/runtime/routes/playground/guard.ts

@@ -15,7 +15,7 @@ import { RouteError } from "../errors.js";
  */
 const PLAYGROUND_DISABLED_CODE = "playground_disabled";
 
-export function isPlaygroundEnabled(): boolean {
+function isPlaygroundEnabled(): boolean {
   return isAssistantFeatureFlagEnabled("compaction-playground", getConfig());
 }
 

package/src/runtime/routes/playground/index.ts

@@ -6,8 +6,6 @@ import { ROUTES as SEED_CONVERSATION_ROUTES } from "./seed-conversation.js";
 import { ROUTES as SEEDED_CONVERSATIONS_ROUTES } from "./seeded-conversations.js";
 import { ROUTES as STATE_ROUTES } from "./state.js";
 
-export { assertPlaygroundEnabled } from "./guard.js";
-
 export const ROUTES: RouteDefinition[] = [
   ...FORCE_COMPACT_ROUTES,
   ...INJECT_FAILURES_ROUTES,

package/src/runtime/routes/recording-routes.ts

@@ -14,7 +14,6 @@
 
 import { z } from "zod";
 
-import { broadcastToAllClients } from "../../acp/index.js";
 import {
   getActiveRestartToken,
   handleRecordingPause,
@@ -24,7 +23,6 @@ import {
   handleRecordingStop,
   isRecordingIdle,
 } from "../../daemon/handlers/recording.js";
-import type { HandlerContext } from "../../daemon/handlers/shared.js";
 import type {
   RecordingOptions,
   RecordingStatus,
@@ -40,17 +38,6 @@ import type { RouteDefinition, RouteHandlerArgs } from "./types.js";
 
 const log = getLogger("recording-routes");
 
-// ---------------------------------------------------------------------------
-// Broadcast shim — recording handlers only use ctx.broadcast()
-// ---------------------------------------------------------------------------
-
-function getBroadcastCtx(): HandlerContext {
-  if (!broadcastToAllClients) {
-    throw new InternalError("Broadcast not initialized");
-  }
-  return { broadcast: broadcastToAllClients } as HandlerContext;
-}
-
 // ---------------------------------------------------------------------------
 // Handlers
 // ---------------------------------------------------------------------------
@@ -60,11 +47,9 @@ async function handleStartRecording({ body }: RouteHandlerArgs) {
     throw new BadRequestError("conversationId is required");
   }
 
-  const ctx = getBroadcastCtx();
   const recordingId = handleRecordingStart(
     body.conversationId,
     body.options as RecordingOptions | undefined,
-    ctx,
   );
 
   if (!recordingId) {
@@ -90,8 +75,7 @@ async function handleStopRecording({ body }: RouteHandlerArgs) {
     throw new BadRequestError("conversationId is required");
   }
 
-  const ctx = getBroadcastCtx();
-  const recordingId = handleRecordingStop(body.conversationId, ctx);
+  const recordingId = handleRecordingStop(body.conversationId);
 
   if (!recordingId) {
     log.debug(
@@ -114,8 +98,7 @@ async function handlePauseRecording({ body }: RouteHandlerArgs) {
     throw new BadRequestError("conversationId is required");
   }
 
-  const ctx = getBroadcastCtx();
-  const recordingId = handleRecordingPause(body.conversationId, ctx);
+  const recordingId = handleRecordingPause(body.conversationId);
 
   if (!recordingId) {
     log.debug(
@@ -138,8 +121,7 @@ async function handleResumeRecording({ body }: RouteHandlerArgs) {
     throw new BadRequestError("conversationId is required");
   }
 
-  const ctx = getBroadcastCtx();
-  const recordingId = handleRecordingResume(body.conversationId, ctx);
+  const recordingId = handleRecordingResume(body.conversationId);
 
   if (!recordingId) {
     log.debug(
@@ -198,10 +180,8 @@ async function handlePostRecordingStatus({ body }: RouteHandlerArgs) {
     type: "recording_status",
   };
 
-  const ctx = getBroadcastCtx();
-
   try {
-    await handleRecordingStatusCore(msg, ctx);
+    await handleRecordingStatusCore(msg);
   } catch (err) {
     log.error(
       { err, conversationId: body.conversationId, status: body.status },

package/src/runtime/routes/rename-conversation-routes.ts

@@ -16,7 +16,6 @@ import {
 import { getLogger } from "../../util/logger.js";
 import { buildAssistantEvent } from "../assistant-event.js";
 import { assistantEventHub } from "../assistant-event-hub.js";
-import { DAEMON_INTERNAL_ASSISTANT_ID } from "../assistant-scope.js";
 import { BadRequestError, NotFoundError } from "./errors.js";
 import type { RouteDefinition } from "./types.js";
 
@@ -46,9 +45,7 @@ export const ROUTES: RouteDefinition[] = [
 
       const conversation = getConversation(conversationId);
       if (!conversation) {
-        throw new NotFoundError(
-          `Conversation ${conversationId} not found`,
-        );
+        throw new NotFoundError(`Conversation ${conversationId} not found`);
       }
 
       updateConversationTitle(conversationId, title, 0);
@@ -56,7 +53,6 @@ export const ROUTES: RouteDefinition[] = [
       assistantEventHub
         .publish(
           buildAssistantEvent(
-            DAEMON_INTERNAL_ASSISTANT_ID,
             {
               type: "conversation_title_updated",
               conversationId,
@@ -71,7 +67,7 @@ export const ROUTES: RouteDefinition[] = [
 
       assistantEventHub
         .publish(
-          buildAssistantEvent(DAEMON_INTERNAL_ASSISTANT_ID, {
+          buildAssistantEvent({
             type: "conversation_list_invalidated",
             reason: "renamed",
           }),

package/src/runtime/routes/schedule-routes.ts

@@ -8,6 +8,7 @@
 import { z } from "zod";
 
 import { getOrCreateConversation } from "../../daemon/conversation-store.js";
+import { INTERNAL_GUARDIAN_TRUST_CONTEXT } from "../../daemon/trust-context.js";
 import { bootstrapConversation } from "../../memory/conversation-bootstrap.js";
 import { getConversation } from "../../memory/conversation-crud.js";
 import { runScript } from "../../schedule/run-script.js";
@@ -28,10 +29,6 @@ import { BadRequestError, InternalError, NotFoundError } from "./errors.js";
 import type { RouteDefinition, RouteHandlerArgs } from "./types.js";
 
 const log = getLogger("schedule-routes");
-const SCHEDULE_GUARDIAN_TRUST_CONTEXT = {
-  sourceChannel: "vellum",
-  trustClass: "guardian",
-} as const;
 
 // ---------------------------------------------------------------------------
 // Handlers (transport-agnostic)
@@ -382,7 +379,7 @@ async function handleRunScheduleNow(id: string) {
         { taskId, workingDir: process.cwd(), source: "schedule" },
         async (conversationId, message, taskRunId) => {
           const conversation = await getOrCreateConversation(conversationId, {
-            trustContext: SCHEDULE_GUARDIAN_TRUST_CONTEXT,
+            trustContext: INTERNAL_GUARDIAN_TRUST_CONTEXT,
           });
           conversation.taskRunId = taskRunId;
           try {
@@ -479,7 +476,7 @@ async function handleRunScheduleNow(id: string) {
       "Executing schedule manually (run now)",
     );
     const activeConversation = await getOrCreateConversation(conversationId, {
-      trustContext: SCHEDULE_GUARDIAN_TRUST_CONTEXT,
+      trustContext: INTERNAL_GUARDIAN_TRUST_CONTEXT,
     });
     activeConversation.taskRunId = undefined;
     await activeConversation.processMessage(