@vellumai/assistant 0.7.0 → 0.7.1

package/src/memory/v2/__tests__/page-store.test.ts

@@ -1,14 +1,17 @@
 /**
  * Tests for `assistant/src/memory/v2/page-store.ts`.
  *
- * Coverage matrix (from PR 8 acceptance criteria):
+ * Coverage matrix:
  *   - slugify: lowercase / kebab-case / ascii / 80-char cap / empty fallback.
+ *   - validateSlug: accept set, reject set (path-traversal, malformed shapes).
  *   - readPage / writePage round-trip: frontmatter survives, body preserved.
  *   - readPage on missing file: returns null.
  *   - writePage atomicity: a fault between temp-write and rename leaves the
  *     prior file intact (or the new one) — never a half-written page.
- *   - listPages: excludes non-.md entries, returns slugs only, missing dir → [].
- *   - deletePage: idempotent on missing file.
+ *   - writePage creates parent directories for nested slugs.
+ *   - listPages: walks subdirectories, returns nested slugs in `/`-form,
+ *     excludes hidden dirs / non-.md / temp files, missing dir → [].
+ *   - deletePage / pageExists: nested-slug round-trip, idempotent on missing.
  *
  * Tests use temp workspaces under `os.tmpdir()` per the cross-cutting safety
  * rule in the v2 plan; they never touch `~/.vellum/`.
@@ -33,6 +36,7 @@ import {
   pageExists,
   readPage,
   slugify,
+  validateSlug,
   writePage,
 } from "../page-store.js";
 import type { ConceptPage } from "../types.js";
@@ -90,6 +94,12 @@ describe("slugify", () => {
     expect(slugify("café résumé")).toMatch(/^[a-z0-9-]+$/);
   });
 
+  test("collapses '/' to hyphen — slugify produces a single segment", () => {
+    // Path-shaped slugs are constructed by writing to nested paths, not by
+    // passing slash-bearing input through slugify.
+    expect(slugify("People/Alice")).toBe("people-alice");
+  });
+
   test("caps slug length at 80 chars and re-trims trailing hyphen", () => {
     const long = "a".repeat(120);
     const slug = slugify(long);
@@ -109,6 +119,56 @@ describe("slugify", () => {
   });
 });
 
+// ---------------------------------------------------------------------------
+// validateSlug
+// ---------------------------------------------------------------------------
+
+describe("validateSlug", () => {
+  test.each([
+    ["alice"],
+    ["a"],
+    ["alice-preferences"],
+    ["people/alice"],
+    ["procs/git-flow"],
+    ["arcs/2025-04-cutover"],
+    ["a/b/c/d/e"],
+    ["people/colleagues/alice"],
+  ])("accepts %p", (slug) => {
+    expect(() => validateSlug(slug)).not.toThrow();
+  });
+
+  test.each([
+    ["empty string", ""],
+    ["leading slash", "/alice"],
+    ["trailing slash", "alice/"],
+    ["double slash", "people//alice"],
+    ["dot-dot segment", "people/../alice"],
+    ["pure dot-dot", ".."],
+    ["leading dot segment", ".hidden/alice"],
+    ["backslash", "people\\alice"],
+    ["null byte", "alice\0evil"],
+    ["whitespace", "alice bob"],
+    ["uppercase", "Alice"],
+    ["non-ascii", "café"],
+    ["leading hyphen", "-alice"],
+    ["non-alphanumeric", "alice!"],
+  ])("rejects %s (%p)", (_label, slug) => {
+    expect(() => validateSlug(slug)).toThrow(/Invalid concept-page slug/);
+  });
+
+  test("rejects slugs longer than 200 chars", () => {
+    expect(() => validateSlug("a".repeat(201))).toThrow(
+      /Invalid concept-page slug/,
+    );
+  });
+
+  test("rejects segments longer than 80 chars even if total is under 200", () => {
+    expect(() => validateSlug("a".repeat(81))).toThrow(
+      /Invalid concept-page slug/,
+    );
+  });
+});
+
 // ---------------------------------------------------------------------------
 // readPage / writePage round-trip
 // ---------------------------------------------------------------------------
@@ -188,6 +248,50 @@ describe("writePage + readPage round-trip", () => {
     const read = await readPage(workspaceDir, page1.slug);
     expect(read!.body).toBe("second version\n");
   });
+
+  test("writePage creates parent directories for nested slugs", async () => {
+    const page = makePage({ slug: "people/alice" });
+    await writePage(workspaceDir, page);
+
+    const filePath = join(
+      workspaceDir,
+      "memory",
+      "concepts",
+      "people",
+      "alice.md",
+    );
+    expect(existsSync(filePath)).toBe(true);
+
+    const read = await readPage(workspaceDir, "people/alice");
+    expect(read!.slug).toBe("people/alice");
+    expect(read!.body).toBe(page.body);
+  });
+
+  test("writePage round-trips deeply nested slugs", async () => {
+    const page = makePage({ slug: "people/colleagues/alice" });
+    await writePage(workspaceDir, page);
+
+    const read = await readPage(workspaceDir, "people/colleagues/alice");
+    expect(read!.slug).toBe("people/colleagues/alice");
+    expect(read!.frontmatter.edges).toEqual(page.frontmatter.edges);
+    expect(read!.body).toBe(page.body);
+  });
+
+  test("writePage rejects malicious slugs and writes nothing at the escape target", async () => {
+    await expect(
+      writePage(workspaceDir, makePage({ slug: "../escape" })),
+    ).rejects.toThrow(/Invalid concept-page slug/);
+
+    // `../escape` would resolve to `<workspace>/memory/escape.md`. Confirm
+    // the validation throw fired before any I/O — no file at that target.
+    expect(existsSync(join(workspaceDir, "memory", "escape.md"))).toBe(false);
+  });
+
+  test("readPage rejects malicious slugs", async () => {
+    await expect(readPage(workspaceDir, "../escape")).rejects.toThrow(
+      /Invalid concept-page slug/,
+    );
+  });
 });
 
 // ---------------------------------------------------------------------------
@@ -239,6 +343,40 @@ describe("writePage atomicity", () => {
     expect(orphanTmps).toEqual([]);
   });
 
+  test("nested-slug write that fails leaves no orphan tmp in nested folder", async () => {
+    // Seed a nested page so the parent dir exists.
+    const original = makePage({
+      slug: "people/alice",
+      body: "original body\n",
+    });
+    await writePage(workspaceDir, original);
+
+    const targetPath = join(
+      workspaceDir,
+      "memory",
+      "concepts",
+      "people",
+      "alice.md",
+    );
+    rmSync(targetPath);
+    mkdirSync(targetPath);
+    writeFileSync(join(targetPath, "blocker"), "x", "utf-8");
+
+    await expect(
+      writePage(
+        workspaceDir,
+        makePage({ slug: "people/alice", body: "interrupted\n" }),
+      ),
+    ).rejects.toThrow();
+
+    rmSync(targetPath, { recursive: true, force: true });
+
+    const peopleDir = join(workspaceDir, "memory", "concepts", "people");
+    const remaining = readdirSync(peopleDir);
+    const orphanTmps = remaining.filter((name) => name.includes(".tmp."));
+    expect(orphanTmps).toEqual([]);
+  });
+
   test("successful write produces no orphan tmp files", async () => {
     await writePage(workspaceDir, makePage());
 
@@ -274,15 +412,51 @@ describe("listPages", () => {
     expect(slugs).toEqual(["alice"]);
   });
 
-  test("excludes subdirectories (only files count)", async () => {
+  test("walks subdirectories and returns nested slugs in '/'-form", async () => {
     await writePage(workspaceDir, makePage({ slug: "alice" }));
+    await writePage(workspaceDir, makePage({ slug: "people/bob" }));
+    await writePage(workspaceDir, makePage({ slug: "people/carol" }));
+    await writePage(workspaceDir, makePage({ slug: "arcs/2025-04/cutover" }));
 
-    mkdirSync(join(workspaceDir, "memory", "concepts", "subdir"), {
-      recursive: true,
-    });
+    const slugs = await listPages(workspaceDir);
+    expect(slugs).toEqual([
+      "alice",
+      "arcs/2025-04/cutover",
+      "people/bob",
+      "people/carol",
+    ]);
+  });
+
+  test("skips hidden subdirectories and non-.md files inside nested dirs", async () => {
+    await writePage(workspaceDir, makePage({ slug: "people/alice" }));
+
+    const conceptsDir = join(workspaceDir, "memory", "concepts");
+    mkdirSync(join(conceptsDir, ".git"), { recursive: true });
+    writeFileSync(join(conceptsDir, ".git", "config.md"), "fake", "utf-8");
+    writeFileSync(join(conceptsDir, "people", "notes.txt"), "ignore", "utf-8");
 
     const slugs = await listPages(workspaceDir);
-    expect(slugs).toEqual(["alice"]);
+    expect(slugs).toEqual(["people/alice"]);
+  });
+
+  test("skips orphaned .tmp.* files at any depth", async () => {
+    const conceptsDir = join(workspaceDir, "memory", "concepts");
+    await writePage(workspaceDir, makePage({ slug: "people/alice" }));
+
+    // Synthesize an orphan tmp file at root and inside the people/ subdir.
+    writeFileSync(
+      join(conceptsDir, "alice.md.tmp.123.abc-def"),
+      "stranded",
+      "utf-8",
+    );
+    writeFileSync(
+      join(conceptsDir, "people", "bob.md.tmp.123.abc-def"),
+      "stranded",
+      "utf-8",
+    );
+
+    const slugs = await listPages(workspaceDir);
+    expect(slugs).toEqual(["people/alice"]);
   });
 
   test("returns [] when the concepts directory does not exist", async () => {
@@ -316,6 +490,15 @@ describe("deletePage", () => {
     expect(await readPage(workspaceDir, page.slug)).toBeNull();
   });
 
+  test("removes nested pages", async () => {
+    const page = makePage({ slug: "people/alice" });
+    await writePage(workspaceDir, page);
+    expect(await pageExists(workspaceDir, "people/alice")).toBe(true);
+
+    await deletePage(workspaceDir, "people/alice");
+    expect(await pageExists(workspaceDir, "people/alice")).toBe(false);
+  });
+
   test("is idempotent — deleting a missing page does not throw", async () => {
     await deletePage(workspaceDir, "never-existed");
     // Second call still does not throw.

package/src/memory/v2/__tests__/prompts-consolidation.test.ts

@@ -0,0 +1,181 @@
+/**
+ * Tests for `assistant/src/memory/v2/prompts/consolidation.ts` —
+ * specifically `resolveConsolidationPrompt` which loads an optional
+ * file-based override and falls back to the bundled prompt when the
+ * override is missing/empty/unreadable.
+ */
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { homedir, tmpdir } from "node:os";
+import { join } from "node:path";
+import {
+  afterAll,
+  afterEach,
+  beforeAll,
+  beforeEach,
+  describe,
+  expect,
+  mock,
+  test,
+} from "bun:test";
+
+const warnCalls: Array<{ data: unknown; msg: string }> = [];
+const recordingLogger = {
+  warn: (data: unknown, msg: string) => {
+    warnCalls.push({ data, msg });
+  },
+  info: () => {},
+  debug: () => {},
+  error: () => {},
+  trace: () => {},
+  fatal: () => {},
+  child: () => recordingLogger,
+};
+
+mock.module("../../../util/logger.js", () => ({
+  getLogger: () => recordingLogger,
+}));
+
+let tmpWorkspace: string;
+let previousWorkspaceEnv: string | undefined;
+
+beforeAll(() => {
+  tmpWorkspace = mkdtempSync(join(tmpdir(), "memory-v2-prompt-test-"));
+  previousWorkspaceEnv = process.env.VELLUM_WORKSPACE_DIR;
+  process.env.VELLUM_WORKSPACE_DIR = tmpWorkspace;
+});
+
+afterAll(() => {
+  if (previousWorkspaceEnv === undefined) {
+    delete process.env.VELLUM_WORKSPACE_DIR;
+  } else {
+    process.env.VELLUM_WORKSPACE_DIR = previousWorkspaceEnv;
+  }
+  rmSync(tmpWorkspace, { recursive: true, force: true });
+});
+
+const { CONSOLIDATION_PROMPT, CUTOFF_PLACEHOLDER, resolveConsolidationPrompt } =
+  await import("../prompts/consolidation.js");
+
+const CUTOFF = "2026-05-01T12:00:00.000Z";
+
+const bundledPrompt = (): string =>
+  (CONSOLIDATION_PROMPT as string).replaceAll(CUTOFF_PLACEHOLDER, CUTOFF);
+
+beforeEach(() => {
+  warnCalls.length = 0;
+  mkdirSync(tmpWorkspace, { recursive: true });
+});
+
+afterEach(() => {
+  for (const entry of ["custom-prompt.md", "empty.md", "no-placeholder.md"]) {
+    rmSync(join(tmpWorkspace, entry), { force: true });
+  }
+});
+
+describe("resolveConsolidationPrompt — no override", () => {
+  test("returns the bundled prompt with {{CUTOFF}} substituted when overridePath is null", () => {
+    const result = resolveConsolidationPrompt(null, CUTOFF);
+    expect(result).toContain("You are running memory consolidation");
+    expect(result).toContain(CUTOFF);
+    expect(result).not.toContain(CUTOFF_PLACEHOLDER);
+    expect(warnCalls).toHaveLength(0);
+  });
+});
+
+describe("resolveConsolidationPrompt — with override", () => {
+  test("loads an absolute path verbatim and substitutes {{CUTOFF}}", () => {
+    const path = join(tmpWorkspace, "custom-prompt.md");
+    writeFileSync(path, "Custom prompt at {{CUTOFF}}\n");
+
+    const result = resolveConsolidationPrompt(path, CUTOFF);
+
+    expect(result).toBe(`Custom prompt at ${CUTOFF}\n`);
+    expect(warnCalls).toHaveLength(0);
+  });
+
+  test("resolves a relative path against the workspace dir", () => {
+    writeFileSync(
+      join(tmpWorkspace, "custom-prompt.md"),
+      "Workspace-relative {{CUTOFF}}\n",
+    );
+
+    const result = resolveConsolidationPrompt("custom-prompt.md", CUTOFF);
+
+    expect(result).toBe(`Workspace-relative ${CUTOFF}\n`);
+    expect(warnCalls).toHaveLength(0);
+  });
+
+  test("expands a leading ~/ to the home directory", () => {
+    const filename = `.vellum-prompt-test-${process.pid}.md`;
+    const path = join(homedir(), filename);
+    writeFileSync(path, "Home dir {{CUTOFF}}\n");
+    try {
+      const result = resolveConsolidationPrompt(`~/${filename}`, CUTOFF);
+      expect(result).toBe(`Home dir ${CUTOFF}\n`);
+      expect(warnCalls).toHaveLength(0);
+    } finally {
+      rmSync(path, { force: true });
+    }
+  });
+
+  test("returns the file body verbatim when {{CUTOFF}} is absent", () => {
+    const body = "No placeholder here. Just a plain prompt.\n";
+    writeFileSync(join(tmpWorkspace, "no-placeholder.md"), body);
+
+    const result = resolveConsolidationPrompt("no-placeholder.md", CUTOFF);
+
+    expect(result).toBe(body);
+    expect(warnCalls).toHaveLength(0);
+  });
+
+  test("substitutes every {{CUTOFF}} occurrence (replaceAll, not replace)", () => {
+    writeFileSync(
+      join(tmpWorkspace, "custom-prompt.md"),
+      "{{CUTOFF}} ... {{CUTOFF}} ... {{CUTOFF}}",
+    );
+
+    const result = resolveConsolidationPrompt("custom-prompt.md", CUTOFF);
+
+    expect(result).toBe(`${CUTOFF} ... ${CUTOFF} ... ${CUTOFF}`);
+    expect(result).not.toContain(CUTOFF_PLACEHOLDER);
+  });
+});
+
+describe("resolveConsolidationPrompt — failure modes", () => {
+  test("falls back to bundled prompt and logs a warning when the file is missing", () => {
+    const result = resolveConsolidationPrompt(
+      "/this/path/does/not/exist.md",
+      CUTOFF,
+    );
+
+    expect(result).toBe(bundledPrompt());
+    expect(warnCalls).toHaveLength(1);
+    const data = warnCalls[0].data as Record<string, unknown>;
+    expect(data.code).toBe("ENOENT");
+    expect(data.fallback).toBe("bundled");
+  });
+
+  test("falls back to bundled prompt when the file is empty", () => {
+    const path = join(tmpWorkspace, "empty.md");
+    writeFileSync(path, "");
+
+    const result = resolveConsolidationPrompt(path, CUTOFF);
+
+    expect(result).toBe(bundledPrompt());
+    expect(warnCalls).toHaveLength(1);
+    const data = warnCalls[0].data as Record<string, unknown>;
+    expect(data.reason).toBe("empty_override");
+  });
+
+  test("falls back to bundled prompt when the file is whitespace-only", () => {
+    const path = join(tmpWorkspace, "empty.md");
+    writeFileSync(path, "   \n\n\t\n");
+
+    const result = resolveConsolidationPrompt(path, CUTOFF);
+
+    expect(result).toBe(bundledPrompt());
+    expect(warnCalls).toHaveLength(1);
+    const data = warnCalls[0].data as Record<string, unknown>;
+    expect(data.reason).toBe("empty_override");
+  });
+});

package/src/memory/v2/__tests__/skill-store.test.ts

@@ -19,6 +19,7 @@ import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 import { makeMockLogger } from "../../../__tests__/helpers/mock-logger.js";
 import type { ResolvedSkill } from "../../../config/skill-state.js";
 import type { SkillSummary } from "../../../config/skills.js";
+import type { CatalogSkill } from "../../../skills/catalog-install.js";
 
 mock.module("../../../util/logger.js", () => ({
   getLogger: () => makeMockLogger(),
@@ -31,6 +32,8 @@ mock.module("../../../util/logger.js", () => ({
 interface TestState {
   catalog: SkillSummary[];
   resolved: ResolvedSkill[];
+  fullCatalog: CatalogSkill[];
+  fullCatalogThrows: Error | null;
   flagsEnabled: Record<string, boolean>;
   embedThrows: Error | null;
   embedReturn: number[][];
@@ -49,6 +52,8 @@ interface TestState {
 const state: TestState = {
   catalog: [],
   resolved: [],
+  fullCatalog: [],
+  fullCatalogThrows: null,
   flagsEnabled: {},
   embedThrows: null,
   embedReturn: [],
@@ -104,6 +109,13 @@ mock.module("../skill-qdrant.js", () => ({
   },
 }));
 
+mock.module("../../../skills/catalog-cache.js", () => ({
+  getCatalog: async () => {
+    if (state.fullCatalogThrows) throw state.fullCatalogThrows;
+    return state.fullCatalog;
+  },
+}));
+
 // Imported AFTER all mocks are wired so the module under test sees the stubs.
 const { seedV2SkillEntries, getSkillCapability, _resetSkillStoreForTests } =
   await import("../skill-store.js");
@@ -128,6 +140,8 @@ function makeSummary(overrides: Partial<SkillSummary> = {}): SkillSummary {
 function resetState(): void {
   state.catalog = [];
   state.resolved = [];
+  state.fullCatalog = [];
+  state.fullCatalogThrows = null;
   state.flagsEnabled = {};
   state.embedThrows = null;
   state.embedReturn = [];
@@ -196,6 +210,63 @@ describe("seedV2SkillEntries", () => {
     expect(state.upsertCalls[0].id).toBe("example-skill-a");
   });
 
+  test("does not re-seed an installed-but-disabled skill from the remote catalog", async () => {
+    // Regression for https://github.com/vellum-ai/vellum-assistant/pull/28635
+    // (Codex P1): if `seenIds` is built only from enabled skills, a locally
+    // installed-but-disabled skill falls through to the catalog loop and gets
+    // embedded as if it were a discoverable uninstalled skill — contradicting
+    // the user's explicit disablement.
+    const enabledSkill = makeSummary({ id: "example-skill-a" });
+    const disabledSkill = makeSummary({ id: "example-skill-b" });
+    state.catalog = [enabledSkill, disabledSkill];
+    state.resolved = [
+      { summary: enabledSkill, state: "enabled" },
+      { summary: disabledSkill, state: "disabled" },
+    ];
+    // The remote catalog also contains the disabled skill (same id) — the
+    // seed function must NOT pull it back in via `getCatalog()`.
+    state.fullCatalog = [
+      {
+        id: "example-skill-b",
+        name: "example-skill-b",
+        description: "Disabled skill that also lives in the remote catalog",
+      },
+    ];
+    state.embedReturn = [[0.1, 0.2, 0.3]];
+
+    await seedV2SkillEntries();
+
+    expect(state.upsertCalls).toHaveLength(1);
+    expect(state.upsertCalls[0].id).toBe("example-skill-a");
+  });
+
+  test("seeds genuinely uninstalled catalog skills alongside enabled installed skills", async () => {
+    const installed = makeSummary({ id: "example-skill-a" });
+    state.catalog = [installed];
+    state.resolved = [{ summary: installed, state: "enabled" }];
+    state.fullCatalog = [
+      {
+        id: "example-skill-a",
+        name: "example-skill-a",
+        description: "Installed (must not duplicate)",
+      },
+      {
+        id: "uninstalled-skill",
+        name: "uninstalled-skill",
+        description: "Discoverable from the catalog",
+      },
+    ];
+    state.embedReturn = [
+      [0.1, 0.2, 0.3],
+      [0.4, 0.5, 0.6],
+    ];
+
+    await seedV2SkillEntries();
+
+    const ids = state.upsertCalls.map((c) => c.id).sort();
+    expect(ids).toEqual(["example-skill-a", "uninstalled-skill"]);
+  });
+
   test("skips skills whose declared feature flag is disabled", async () => {
     const flagged = makeSummary({
       id: "example-skill-a",
@@ -224,6 +295,12 @@ describe("seedV2SkillEntries", () => {
       { summary: skillA, state: "enabled" },
       { summary: skillB, state: "enabled" },
     ];
+    // Remote catalog must be non-empty so catalogAvailable is true and
+    // pruning is not skipped.
+    state.fullCatalog = [
+      { id: "example-skill-a", name: "example-skill-a", description: "A" },
+      { id: "example-skill-b", name: "example-skill-b", description: "B" },
+    ];
     state.embedReturn = [
       [0.1, 0.2, 0.3],
       [0.4, 0.5, 0.6],
@@ -250,6 +327,12 @@ describe("seedV2SkillEntries", () => {
       { summary: unflagged, state: "enabled" },
     ];
     state.flagsEnabled = { "off-flag": false };
+    // Remote catalog must be non-empty so catalogAvailable is true and
+    // pruning is not skipped.
+    state.fullCatalog = [
+      { id: "example-skill-a", name: "example-skill-a", description: "A" },
+      { id: "example-skill-b", name: "example-skill-b", description: "B" },
+    ];
     state.embedReturn = [[0.4, 0.5, 0.6]];
 
     await seedV2SkillEntries();
@@ -320,17 +403,46 @@ describe("seedV2SkillEntries", () => {
     expect(after).toEqual(before);
   });
 
-  test("no enabled skills yields empty cache and a single empty prune call", async () => {
+  test("no enabled skills yields empty cache and no prune when catalog is empty", async () => {
     state.catalog = [];
     state.resolved = [];
+    // fullCatalog defaults to [] — catalog unavailable, so pruning is skipped.
 
     await seedV2SkillEntries();
 
     expect(state.upsertCalls).toHaveLength(0);
-    expect(state.pruneCalls).toHaveLength(1);
-    expect([...state.pruneCalls[0]]).toEqual([]);
+    expect(state.pruneCalls).toHaveLength(0);
     expect(getSkillCapability("anything")).toBeNull();
   });
+
+  test("no enabled skills prunes when catalog is available", async () => {
+    state.catalog = [];
+    state.resolved = [];
+    state.fullCatalog = [
+      { id: "remote-only", name: "remote-only", description: "Remote skill" },
+    ];
+    state.embedReturn = [[0.1, 0.2, 0.3]];
+
+    await seedV2SkillEntries();
+
+    expect(state.upsertCalls).toHaveLength(1);
+    expect(state.upsertCalls[0].id).toBe("remote-only");
+    expect(state.pruneCalls).toHaveLength(1);
+    expect([...state.pruneCalls[0]]).toEqual(["remote-only"]);
+  });
+
+  test("skips pruning when catalog fetch returns empty (network failure guard)", async () => {
+    const skillA = makeSummary({ id: "example-skill-a" });
+    state.catalog = [skillA];
+    state.resolved = [{ summary: skillA, state: "enabled" }];
+    state.fullCatalog = []; // Simulates cold cache / network failure
+    state.embedReturn = [[0.1, 0.2, 0.3]];
+
+    await seedV2SkillEntries();
+
+    expect(state.upsertCalls).toHaveLength(1);
+    expect(state.pruneCalls).toHaveLength(0);
+  });
 });
 
 describe("getSkillCapability", () => {