@vellumai/assistant 0.7.0 → 0.7.1

package/src/tools/browser/browser-execution.ts

@@ -1,4 +1,5 @@
 import { getConfig } from "../../config/loader.js";
+import { HostBrowserProxy } from "../../daemon/host-browser-proxy.js";
 import type { ImageContent } from "../../providers/types.js";
 import { getLogger } from "../../util/logger.js";
 import { truncate } from "../../util/truncate.js";
@@ -721,8 +722,19 @@ export async function executeBrowserNavigate(
     }
 
     // Read the current URL BEFORE calling navigateAndWait so we can
-    // detect the "page never moved" case on timeout.
-    const urlBeforeNav = await getCurrentUrl(cdp, context.signal);
+    // detect the "page never moved" case on timeout. This may fail if
+    // the active tab is on a chrome:// or other privileged URL where
+    // Runtime.evaluate is blocked — in that case we proceed without the
+    // baseline and skip the "page never moved" timeout heuristic.
+    let urlBeforeNav = "";
+    try {
+      urlBeforeNav = await getCurrentUrl(cdp, context.signal);
+    } catch {
+      log.debug(
+        { conversationId: context.conversationId },
+        "Could not read current URL before navigation (tab may be on a privileged page)",
+      );
+    }
 
     // Navigate via CDP Page.navigate + document.readyState polling.
     // navigateAndWait returns { finalUrl, timedOut }; HTTP status is
@@ -843,18 +855,9 @@ export async function executeBrowserNavigate(
 
     const safeFinalUrl = sanitizeUrlForOutput(new URL(finalUrl));
     const title = await getPageTitle(cdp, context.signal);
-    // HTTP status is not available on the CDP path: `Page.navigate`
-    // resolves the frame id and (on failure) an error text, but does
-    // not carry the response status code. Both the local and extension
-    // paths therefore print "unknown" here. A future phase may subscribe
-    // to `Network.responseReceived` events during the navigation window
-    // if the status is needed again.
-    const status: number | null = null;
-
     const lines: string[] = [
       `Requested URL: ${safeRequestedUrl}`,
       `Final URL: ${safeFinalUrl}`,
-      `Status: ${status ?? "unknown"}`,
       `Title: ${title || "(none)"}`,
     ];
 
@@ -2099,43 +2102,6 @@ function extensionSetupActions(): string[] {
   ];
 }
 
-function macOSHostBrowserSetupActions(): string[] {
-  return [
-    "Ensure the Vellum desktop app is running and connected to the assistant.",
-    "Open Google Chrome on the desktop machine so the host browser proxy can attach.",
-    "If the desktop client is not running, launch it and wait for the SSE connection to establish.",
-  ];
-}
-
-function macOSHostBrowserReconnectActions(): string[] {
-  return [
-    "Verify the Vellum desktop app is still running and has an active network connection.",
-    "If the desktop client was recently restarted, send a new message to re-establish the SSE bridge.",
-    "Ensure Chrome is open on the desktop machine for the host browser proxy to target.",
-  ];
-}
-
-function macOSHostBrowserProbeFailureActions(error: CdpError): string[] {
-  const actions: string[] = [
-    "Ensure Google Chrome is running on the desktop machine.",
-  ];
-  const message = error.message.toLowerCase();
-  if (message.includes("timeout") || message.includes("timed out")) {
-    actions.push(
-      "The desktop client may be unresponsive — try restarting the Vellum desktop app.",
-    );
-  }
-  if (message.includes("transport") || message.includes("disconnected")) {
-    actions.push(
-      "The SSE bridge between the assistant and the desktop client appears broken. Send a new message to re-establish the connection.",
-    );
-  }
-  actions.push(
-    "Switch Chrome to a regular http(s) tab (not chrome://...) and retry.",
-  );
-  return dedupeStrings(actions);
-}
-
 function cdpInspectSetupActions(): string[] {
   return [
     "Update Chrome to the latest version by going to chrome://settings/help",
@@ -2283,82 +2249,19 @@ async function checkExtensionModeStatus(
   context: ToolContext,
   autoCandidate: boolean,
 ): Promise<BrowserStatusModeResult> {
-  const proxyBound = Boolean(context.hostBrowserProxy);
-  const proxyConnected = context.hostBrowserProxy?.isAvailable() ?? false;
-  const isMacOS = context.transportInterface === "macos";
-  const registryClients = context.connectedBrowserClients ?? [];
-  const extensionClients = registryClients.filter(
-    (c) => c.interfaceId === "chrome-extension",
-  );
-
-  if (!proxyBound) {
-    // No proxy bound to this conversation, but the client registry may
-    // show a connected chrome-extension client with host_browser capability.
-    // Report that so `assistant browser status` from the CLI is accurate.
-    if (extensionClients.length > 0) {
-      return {
-        mode: BROWSER_STATUS_MODE.EXTENSION,
-        available: false,
-        verified: "preflight",
-        autoCandidate,
-        summary:
-          "Extension mode: a Chrome extension client is connected but no host browser proxy is bound to this conversation. " +
-          "Extension browser operations will be available within a conversation turn initiated from the extension.",
-        userActions: [],
-        tradeoffs: modeTradeoffs(BROWSER_STATUS_MODE.EXTENSION),
-        details: {
-          proxyBound,
-          proxyConnected,
-          connectedExtensionClients: extensionClients,
-          transport: "extension-ws",
-        },
-      };
-    }
-
-    return {
-      mode: BROWSER_STATUS_MODE.EXTENSION,
-      available: false,
-      verified: "preflight",
-      autoCandidate,
-      summary: isMacOS
-        ? "Extension mode is unavailable: the macOS host browser proxy is not bound to this conversation. Ensure the desktop client is connected."
-        : "Extension mode is unavailable: no host browser proxy is bound to this conversation.",
-      userActions: isMacOS
-        ? macOSHostBrowserSetupActions()
-        : extensionSetupActions(),
-      tradeoffs: modeTradeoffs(BROWSER_STATUS_MODE.EXTENSION),
-      details: {
-        proxyBound,
-        proxyConnected,
-        transport:
-          isMacOS && !context.hostBrowserRegistryRouted
-            ? "macos-sse"
-            : "extension-ws",
-      },
-    };
-  }
+  const proxy = HostBrowserProxy.instance;
 
-  if (!proxyConnected) {
+  if (!proxy.isAvailable()) {
     return {
       mode: BROWSER_STATUS_MODE.EXTENSION,
       available: false,
       verified: "preflight",
       autoCandidate,
-      summary: isMacOS
-        ? "Extension mode is unavailable: the macOS host browser proxy is bound but the SSE transport is currently disconnected. Verify the desktop client is running and connected."
-        : "Extension mode is unavailable: the extension transport is currently disconnected.",
-      userActions: isMacOS
-        ? macOSHostBrowserReconnectActions()
-        : extensionSetupActions(),
+      summary:
+        "Extension mode is unavailable: the extension transport is currently disconnected.",
+      userActions: extensionSetupActions(),
       tradeoffs: modeTradeoffs(BROWSER_STATUS_MODE.EXTENSION),
-      details: {
-        proxyBound,
-        proxyConnected,
-        transport:
-          isMacOS && !context.hostBrowserRegistryRouted
-            ? "macos-sse"
-            : "extension-ws",
-      },
+      details: { transport: "extension-ws" },
     };
   }
 
@@ -2372,19 +2275,12 @@ async function checkExtensionModeStatus(
       available: true,
       verified: "active_probe",
       autoCandidate,
-      summary: isMacOS
-        ? "Extension mode is ready via macOS host browser proxy and responded to an active CDP probe."
-        : "Extension mode is ready and responded to an active CDP probe.",
+      summary: "Extension mode is ready and responded to an active CDP probe.",
       userActions: [],
       tradeoffs: modeTradeoffs(BROWSER_STATUS_MODE.EXTENSION),
       details: {
-        proxyBound,
-        proxyConnected,
         backendKind: probe.backendKind,
-        transport:
-          isMacOS && !context.hostBrowserRegistryRouted
-            ? "macos-sse"
-            : "extension-ws",
+        transport: "extension-ws",
       },
     };
   }
@@ -2395,24 +2291,18 @@ async function checkExtensionModeStatus(
       available: true,
       verified: "active_probe",
       autoCandidate,
-      summary: isMacOS
-        ? "Extension mode transport is connected via macOS host browser proxy, but the active Chrome tab is a restricted chrome:// page. Switch to a regular website tab if browser actions fail."
-        : "Extension mode transport is connected, but the active Chrome tab is a restricted chrome:// page. Switch to a regular website tab if browser actions fail.",
+      summary:
+        "Extension mode transport is connected, but the active Chrome tab is a restricted chrome:// page. Switch to a regular website tab if browser actions fail.",
       userActions: [
         "Switch Chrome to a regular http(s) tab (not chrome://...) and retry.",
       ],
       tradeoffs: modeTradeoffs(BROWSER_STATUS_MODE.EXTENSION),
       details: {
-        proxyBound,
-        proxyConnected,
         restrictedActiveTab: true,
         errorCode: probe.error.code,
         diagnostic: probe.diagnostic,
         attemptDiagnostics: probe.error.attemptDiagnostics ?? [],
-        transport:
-          isMacOS && !context.hostBrowserRegistryRouted
-            ? "macos-sse"
-            : "extension-ws",
+        transport: "extension-ws",
       },
     };
   }
@@ -2422,23 +2312,17 @@ async function checkExtensionModeStatus(
     available: false,
     verified: "active_probe",
     autoCandidate,
-    summary: isMacOS
-      ? `Extension mode probe failed via macOS host browser proxy: ${probe.error.message}`
-      : `Extension mode probe failed: ${probe.error.message}`,
-    userActions: isMacOS
-      ? macOSHostBrowserProbeFailureActions(probe.error)
-      : probeFailureActions(BROWSER_STATUS_MODE.EXTENSION, probe.error),
+    summary: `Extension mode probe failed: ${probe.error.message}`,
+    userActions: probeFailureActions(
+      BROWSER_STATUS_MODE.EXTENSION,
+      probe.error,
+    ),
     tradeoffs: modeTradeoffs(BROWSER_STATUS_MODE.EXTENSION),
     details: {
-      proxyBound,
-      proxyConnected,
       errorCode: probe.error.code,
       diagnostic: probe.diagnostic,
       attemptDiagnostics: probe.error.attemptDiagnostics ?? [],
-      transport:
-        isMacOS && !context.hostBrowserRegistryRouted
-          ? "macos-sse"
-          : "extension-ws",
+      transport: "extension-ws",
     },
   };
 }