@vellumai/assistant 0.7.0 → 0.7.1

package/src/__tests__/tool-domain-event-publisher.test.ts

@@ -140,42 +140,6 @@ describe("createToolDomainEventPublisher", () => {
     });
   });
 
-  test("maps secret_detected lifecycle event to tool.secret.detected domain event", async () => {
-    const { bus, events } = makeEventsCollector();
-    const publish = createToolDomainEventPublisher(bus);
-
-    await publish({
-      type: "secret_detected",
-      toolName: "file_read",
-      input: { path: "secrets.txt" },
-      workingDir: "/tmp/project",
-      conversationId: "conversation-1",
-      action: "redact",
-      matches: [
-        {
-          type: "AWS Access Key",
-          redactedValue: '<redacted type="AWS Access Key" />',
-        },
-      ],
-      detectedAtMs: 55,
-    });
-
-    expect(events).toHaveLength(1);
-    expect(events[0].type).toBe("tool.secret.detected");
-    expect(events[0].payload).toEqual({
-      conversationId: "conversation-1",
-      toolName: "file_read",
-      action: "redact",
-      matches: [
-        {
-          type: "AWS Access Key",
-          redactedValue: '<redacted type="AWS Access Key" />',
-        },
-      ],
-      detectedAtMs: 55,
-    });
-  });
-
   test("maps allow-decision error lifecycle event to permission.decided + execution.failed", async () => {
     const { bus, events } = makeEventsCollector();
     const publish = createToolDomainEventPublisher(bus);

package/src/__tests__/tool-execute-pipeline.test.ts

@@ -45,8 +45,6 @@ const mockConfig = {
   rateLimit: { maxRequestsPerMinute: 0 },
   secretDetection: {
     enabled: false,
-    action: "warn" as const,
-    entropyThreshold: 4.0,
   },
   permissions: {
     mode: "workspace" as const,
@@ -131,10 +129,6 @@ mock.module("../tools/shared/filesystem/path-policy.js", () => ({
   hostPolicy: () => ({ ok: false }),
 }));
 
-mock.module("../tools/terminal/sandbox.js", () => ({
-  wrapCommand: () => ({ command: "", sandboxed: false }),
-}));
-
 // ── Redaction + token manager so the executor's imports resolve ──────
 mock.module("../security/redaction.js", () => ({
   redactSensitiveFields: (input: Record<string, unknown>) => input,

package/src/__tests__/tool-execution-abort-cleanup.test.ts

@@ -35,8 +35,6 @@ mock.module("../config/loader.js", () => ({
     rateLimit: { maxRequestsPerMinute: 0 },
     secretDetection: {
       enabled: false,
-      action: "warn" as const,
-      entropyThreshold: 4.0,
     },
   }),
   loadConfig: () => ({}),
@@ -53,20 +51,6 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
-// shell.ts requires the sandbox wrapper — provide a pass-through stub.
-mock.module("../tools/terminal/sandbox.js", () => ({
-  wrapCommand: (
-    command: string,
-    _cwd: string,
-    _cfg: unknown,
-    _opts?: unknown,
-  ) => ({
-    command: "bash",
-    args: ["-c", "--", command],
-    sandboxed: false,
-  }),
-}));
-
 // shell.ts uses the script proxy — stub it to avoid network side-effects.
 mock.module("../tools/network/script-proxy/index.js", () => ({
   getOrStartSession: async () => ({

package/src/__tests__/tool-execution-pipeline.benchmark.test.ts

@@ -48,7 +48,7 @@ mock.module("../config/loader.js", () => ({
     timeouts: { permissionTimeoutSec: 5, toolExecutionTimeoutSec: 120 },
     permissions: {},
     skills: { load: { extraDirs: [] } },
-    secretDetection: { enabled: true, entropyThreshold: 4.0, action: "warn" },
+    secretDetection: { enabled: true },
     sandbox: { enabled: false },
     contextWindow: {},
     memory: {},
@@ -120,10 +120,10 @@ mock.module("../ipc/gateway-client.js", () => ({
   ipcClassifyRisk: async (): Promise<
     import("../permissions/ipc-risk-types.js").ClassificationResult
   > => ({
-      risk: "low",
-      reason: "mock",
-      matchType: "registry" as const,
-      scopeOptions: [],
+    risk: "low",
+    reason: "mock",
+    matchType: "registry" as const,
+    scopeOptions: [],
   }),
   ipcCall: async () => undefined,
   ipcCallPersistent: async () => undefined,
@@ -133,10 +133,7 @@ mock.module("../ipc/gateway-client.js", () => ({
 import { check, classifyRisk } from "../permissions/checker.js";
 import { PermissionPrompter } from "../permissions/prompter.js";
 import { RiskLevel } from "../permissions/types.js";
-import {
-  DEFAULT_ENTROPY_CONFIG,
-  scanText,
-} from "../security/secret-scanner.js";
+import { scanText } from "../security/secret-scanner.js";
 import { ToolExecutor } from "../tools/executor.js";
 import type { Tool, ToolContext, ToolExecutionResult } from "../tools/types.js";
 
@@ -371,10 +368,7 @@ describe("Tool execution pipeline benchmark", () => {
     const shortOutput =
       "Build succeeded. 42 tests passed, 0 failed.\nTime: 1.23s";
 
-    const { timings } = benchmarkSync(
-      () => scanText(shortOutput, DEFAULT_ENTROPY_CONFIG),
-      ITERATIONS,
-    );
+    const { timings } = benchmarkSync(() => scanText(shortOutput), ITERATIONS);
 
     const p50 = percentile(timings, 50);
     const p95 = percentile(timings, 95);
@@ -386,10 +380,7 @@ describe("Tool execution pipeline benchmark", () => {
   test("scanText: large output (100KB) within budget", () => {
     const largeOutput = generateLargeOutput(100 * 1024);
 
-    const { timings } = benchmarkSync(
-      () => scanText(largeOutput, DEFAULT_ENTROPY_CONFIG),
-      ITERATIONS,
-    );
+    const { timings } = benchmarkSync(() => scanText(largeOutput), ITERATIONS);
 
     const p50 = percentile(timings, 50);
     const p95 = percentile(timings, 95);
@@ -411,7 +402,7 @@ describe("Tool execution pipeline benchmark", () => {
     ].join("\n");
 
     const { timings, results } = benchmarkSync(
-      () => scanText(outputWithSecrets, DEFAULT_ENTROPY_CONFIG),
+      () => scanText(outputWithSecrets),
       ITERATIONS,
     );
 
@@ -438,7 +429,6 @@ describe("Tool execution pipeline benchmark", () => {
       // Phase 3: Secret scanning on output
       scanText(
         "diff --git a/file.ts b/file.ts\n+const x = 42;\n-const x = 41;",
-        DEFAULT_ENTROPY_CONFIG,
       );
 
       timings.push(performance.now() - start);

package/src/__tests__/tool-executor-lifecycle-events.test.ts

@@ -29,8 +29,6 @@ const mockConfig = {
   rateLimit: { maxRequestsPerMinute: 0 },
   secretDetection: {
     enabled: false,
-    action: "warn" as const,
-    entropyThreshold: 4.0,
   },
   permissions: {
     mode: "workspace" as const,
@@ -158,15 +156,14 @@ mock.module("../tools/shared/filesystem/path-policy.js", () => ({
   hostPolicy: () => ({ ok: false }),
 }));
 
-mock.module("../tools/terminal/sandbox.js", () => ({
-  wrapCommand: () => ({ command: "", sandboxed: false }),
-}));
-
 import { PermissionPrompter } from "../permissions/prompter.js";
 import { ToolExecutor } from "../tools/executor.js";
 import { ToolError } from "../util/errors.js";
 
-function makeContext(events: ToolLifecycleEvent[], extra: Record<string, unknown> = {}) {
+function makeContext(
+  events: ToolLifecycleEvent[],
+  extra: Record<string, unknown> = {},
+) {
   return {
     workingDir: "/tmp/project",
     conversationId: "conversation-1",

package/src/__tests__/tool-executor.test.ts

@@ -1,10 +1,4 @@
-import {
-  beforeEach,
-  describe,
-  expect,
-  mock,
-  test,
-} from "bun:test";
+import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 import type {
   AllowlistOption,
@@ -12,10 +6,7 @@ import type {
   ScopeOption,
 } from "../permissions/types.js";
 import { RiskLevel } from "../permissions/types.js";
-import type {
-  Tool,
-  ToolExecutionResult,
-} from "../tools/types.js";
+import type { Tool, ToolExecutionResult } from "../tools/types.js";
 
 const mockConfig = {
   provider: "anthropic",
@@ -41,8 +32,6 @@ const mockConfig = {
   rateLimit: { maxRequestsPerMinute: 0 },
   secretDetection: {
     enabled: false,
-    action: "warn" as const,
-    entropyThreshold: 4.0,
   },
   permissions: {},
 };
@@ -159,10 +148,6 @@ mock.module("../tools/shared/filesystem/path-policy.js", () => ({
   hostPolicy: () => ({ ok: false }),
 }));
 
-mock.module("../tools/terminal/sandbox.js", () => ({
-  wrapCommand: () => ({ command: "", sandboxed: false }),
-}));
-
 import { PermissionPrompter } from "../permissions/prompter.js";
 import { isSideEffectTool, ToolExecutor } from "../tools/executor.js";
 import type { ToolContext } from "../tools/types.js";
@@ -415,7 +400,11 @@ describe("ToolExecutor policy context plumbing", () => {
     };
 
     const executor = new ToolExecutor(makePrompter());
-    const result = await executor.execute("no_target_tool", {}, makeContext({ requireFreshApproval: true }));
+    const result = await executor.execute(
+      "no_target_tool",
+      {},
+      makeContext({ requireFreshApproval: true }),
+    );
 
     expect(result.isError).toBe(false);
     expect(lastCheckArgs).toBeDefined();
@@ -924,7 +913,11 @@ describe("integration regressions — prompt payload (PR 11)", () => {
     } as unknown as PermissionPrompter;
 
     const executor = new ToolExecutor(prompter);
-    await executor.execute("bash", { command: "npm install" }, makeContext({ forcePromptSideEffects: true }));
+    await executor.execute(
+      "bash",
+      { command: "npm install" },
+      makeContext({ forcePromptSideEffects: true }),
+    );
 
     // Verify that the prompter received allowlist options
     expect(capturedAllowlist).toBeDefined();

package/src/__tests__/tool-metrics-listener.test.ts

@@ -130,41 +130,6 @@ describe("registerToolMetricsLoggingListener", () => {
     expect(infoCalls[1][1]).toBe("Tool permission denied");
   });
 
-  test("logs secret detection warnings with aggregate details", async () => {
-    const bus = new EventBus<AssistantDomainEvents>();
-    registerToolMetricsLoggingListener(bus, {
-      logger: testLogger,
-      debugEnabled: () => debugEnabled,
-      truncate,
-    });
-
-    await bus.emit("tool.secret.detected", {
-      conversationId: "conversation-1",
-      toolName: "file_read",
-      action: "warn",
-      matches: [
-        {
-          type: "AWS Access Key",
-          redactedValue: '<redacted type="AWS Access Key" />',
-        },
-        {
-          type: "GitHub Token",
-          redactedValue: '<redacted type="GitHub Token" />',
-        },
-      ],
-      detectedAtMs: 130,
-    });
-
-    expect(warnCalls).toHaveLength(1);
-    expect(warnCalls[0][1]).toBe("Secrets detected in tool output");
-    const payload = warnCalls[0][0] as Record<string, unknown>;
-    expect(payload.matchCount).toBe(2);
-    expect(payload.types as string[]).toEqual([
-      "AWS Access Key",
-      "GitHub Token",
-    ]);
-  });
-
   test("logs execution failures as errors", async () => {
     const bus = new EventBus<AssistantDomainEvents>();
     registerToolMetricsLoggingListener(bus, {

package/src/__tests__/tool-side-effects-slack-dm.test.ts

@@ -54,6 +54,7 @@ mock.module("../memory/app-store.js", () => ({
   writeAppFile: mock(() => {}),
   editAppFile: mock(() => ({})),
   inlineDistAssets: mock((_, html: string) => html),
+  addAppConversationId: mock(() => false),
 }));
 mock.module("../services/published-app-updater.js", () => ({
   updatePublishedAppDeployment: mock(() => Promise.resolve()),

package/src/__tests__/tool-trace-listener.test.ts

@@ -158,23 +158,6 @@ describe("registerToolTraceListener", () => {
     });
   });
 
-  test("emits secret_detected trace with warning status", async () => {
-    await bus.emit("tool.secret.detected", {
-      conversationId: "conv-1",
-      requestId: "req-6",
-      toolName: "file_read",
-      action: "redact",
-      matches: [{ type: "AWS Key", redactedValue: "<redacted />" }],
-      detectedAtMs: 6000,
-    });
-
-    expect(traces).toHaveLength(1);
-    expect(traces[0].kind).toBe("secret_detected");
-    expect(traces[0].summary).toBe("Secret detected in file_read output");
-    expect(traces[0].opts?.status).toBe("warning");
-    expect(traces[0].opts?.attributes).toEqual({ toolName: "file_read" });
-  });
-
   test("passes requestId from domain event payload", async () => {
     await bus.emit("tool.execution.started", {
       conversationId: "conv-1",

package/src/__tests__/transfer-progress-screen.test.ts

@@ -113,12 +113,23 @@ function makeValidateSuccess(): ValidateResponse {
     is_valid: true,
     errors: [],
     manifest: {
-      schema_version: "1.0",
-      created_at: "2025-01-01T00:00:00Z",
-      source: "test",
-      description: "Test bundle",
-      files: [{ path: "config.json", sha256: "abc123", size: 1024 }],
-      manifest_sha256: "manifest-hash",
+      schema_version: 1,
+      bundle_id: "00000000-0000-4000-8000-000000000000",
+      created_at: "2026-03-01T00:00:00Z",
+      assistant: { id: "self", name: "Test", runtime_version: "0.0.0-test" },
+      origin: { mode: "self-hosted-local" },
+      compatibility: {
+        min_runtime_version: "0.0.0-test",
+        max_runtime_version: null,
+      },
+      contents: [{ path: "config.json", sha256: "abc123", size_bytes: 1024 }],
+      checksum: "manifest-hash",
+      secrets_redacted: false,
+      export_options: {
+        include_logs: false,
+        include_browser_state: false,
+        include_memory_vectors: false,
+      },
     },
   };
 }
@@ -145,10 +156,23 @@ function makePreflightSuccess(): ImportPreflightResponse {
     ],
     conflicts: [],
     manifest: {
-      schema_version: "1.0",
-      created_at: "2025-01-01T00:00:00Z",
-      files: [{ path: "config.json", sha256: "abc123", size: 1024 }],
-      manifest_sha256: "manifest-hash",
+      schema_version: 1,
+      bundle_id: "00000000-0000-4000-8000-000000000000",
+      created_at: "2026-03-01T00:00:00Z",
+      assistant: { id: "self", name: "Test", runtime_version: "0.0.0-test" },
+      origin: { mode: "self-hosted-local" },
+      compatibility: {
+        min_runtime_version: "0.0.0-test",
+        max_runtime_version: null,
+      },
+      contents: [{ path: "config.json", sha256: "abc123", size_bytes: 1024 }],
+      checksum: "manifest-hash",
+      secrets_redacted: false,
+      export_options: {
+        include_logs: false,
+        include_browser_state: false,
+        include_memory_vectors: false,
+      },
     },
   };
 }
@@ -174,10 +198,23 @@ function makeImportSuccess(): ImportCommitResponse {
       },
     ],
     manifest: {
-      schema_version: "1.0",
-      created_at: "2025-01-01T00:00:00Z",
-      files: [{ path: "config.json", sha256: "abc123", size: 1024 }],
-      manifest_sha256: "manifest-hash",
+      schema_version: 1,
+      bundle_id: "00000000-0000-4000-8000-000000000000",
+      created_at: "2026-03-01T00:00:00Z",
+      assistant: { id: "self", name: "Test", runtime_version: "0.0.0-test" },
+      origin: { mode: "self-hosted-local" },
+      compatibility: {
+        min_runtime_version: "0.0.0-test",
+        max_runtime_version: null,
+      },
+      contents: [{ path: "config.json", sha256: "abc123", size_bytes: 1024 }],
+      checksum: "manifest-hash",
+      secrets_redacted: false,
+      export_options: {
+        include_logs: false,
+        include_browser_state: false,
+        include_memory_vectors: false,
+      },
     },
     warnings: ["Backup created for config.json"],
   };
@@ -362,8 +399,8 @@ describe("deriveTransferScreenState -- importing", () => {
       exportResult: {
         ok: true,
         filename: "export.vbundle",
-        schemaVersion: "1.0",
-        manifestSha256: "abc",
+        schemaVersion: 1,
+        checksum: "abc",
       },
     };
     const screen = deriveTransferScreenState(state);
@@ -588,8 +625,8 @@ describe("deriveTransferScreenState -- error", () => {
       exportResult: {
         ok: true,
         filename: "export.vbundle",
-        schemaVersion: "1.0",
-        manifestSha256: "abc",
+        schemaVersion: 1,
+        checksum: "abc",
       },
       importResult: {
         success: false,
@@ -681,7 +718,7 @@ describe("retryTransferFlow", () => {
         status: 200,
         headers: {
           "Content-Disposition": 'attachment; filename="export.vbundle"',
-          "X-Vbundle-Schema-Version": "1.0",
+          "X-Vbundle-Schema-Version": "1",
           "X-Vbundle-Manifest-Sha256": "abc",
         },
       });
@@ -751,7 +788,7 @@ describe("retryTransferFlow", () => {
         status: 200,
         headers: {
           "Content-Disposition": 'attachment; filename="export.vbundle"',
-          "X-Vbundle-Schema-Version": "1.0",
+          "X-Vbundle-Schema-Version": "1",
           "X-Vbundle-Manifest-Sha256": "abc",
         },
       });
@@ -793,7 +830,7 @@ describe("executeTransferFlow", () => {
         status: 200,
         headers: {
           "Content-Disposition": 'attachment; filename="export.vbundle"',
-          "X-Vbundle-Schema-Version": "1.0",
+          "X-Vbundle-Schema-Version": "1",
           "X-Vbundle-Manifest-Sha256": "abc",
         },
       });
@@ -915,7 +952,7 @@ describe("executeTransferFlow", () => {
         status: 200,
         headers: {
           "Content-Disposition": 'attachment; filename="export.vbundle"',
-          "X-Vbundle-Schema-Version": "1.0",
+          "X-Vbundle-Schema-Version": "1",
           "X-Vbundle-Manifest-Sha256": "abc",
         },
       });
@@ -959,8 +996,8 @@ describe("goBackToPreflight", () => {
       exportResult: {
         ok: true,
         filename: "export.vbundle",
-        schemaVersion: "1.0",
-        manifestSha256: "abc",
+        schemaVersion: 1,
+        checksum: "abc",
       },
       importResult: makeImportSuccess(),
     };
@@ -998,7 +1035,7 @@ describe("executeTransferFlow -- onStateChange callbacks", () => {
         status: 200,
         headers: {
           "Content-Disposition": 'attachment; filename="export.vbundle"',
-          "X-Vbundle-Schema-Version": "1.0",
+          "X-Vbundle-Schema-Version": "1",
           "X-Vbundle-Manifest-Sha256": "abc",
         },
       });
@@ -1139,7 +1176,7 @@ describe("transfer screen edge cases", () => {
         status: 200,
         headers: {
           "Content-Disposition": 'attachment; filename="export.vbundle"',
-          "X-Vbundle-Schema-Version": "1.0",
+          "X-Vbundle-Schema-Version": "1",
           "X-Vbundle-Manifest-Sha256": "abc",
         },
       });