@vellumai/assistant 0.7.0 → 0.7.1

package/src/daemon/daemon-control.ts

@@ -207,7 +207,7 @@ export function isDaemonRunning(): boolean {
   return true;
 }
 
-export async function getDaemonStatus(): Promise<{
+async function getDaemonStatus(): Promise<{
   running: boolean;
   pid?: number;
 }> {
@@ -287,7 +287,7 @@ function releaseStartupLock(): void {
 // NOTE: startDaemon() is the assistant-side daemon lifecycle manager.
 // It should eventually converge with cli/src/lib/local.ts::startLocalDaemon
 // which is the CLI-side equivalent.
-export async function startDaemon(): Promise<{
+async function startDaemon(): Promise<{
   pid: number;
   alreadyRunning: boolean;
 }> {
@@ -339,7 +339,7 @@ export async function startDaemon(): Promise<{
   }
 }
 
-export async function startDaemonLocked(): Promise<{
+async function startDaemonLocked(): Promise<{
   pid: number;
   alreadyRunning: boolean;
 }> {
@@ -447,74 +447,6 @@ export type StopResult =
   | { stopped: true }
   | { stopped: false; reason: "not_running" | "stop_failed" };
 
-export async function stopDaemon(): Promise<StopResult> {
-  const pid = readPid();
-  if (pid == null || !isProcessRunning(pid)) {
-    cleanupPidFile();
-    return { stopped: false, reason: "not_running" };
-  }
-
-  // Guard against stale PID reuse: if the PID has been recycled by the OS
-  // and now belongs to an unrelated process, clean up the PID file but
-  // never signal it.
-  if (!isVellumDaemonProcess(pid)) {
-    log.info(
-      { pid },
-      "PID file references a non-vellum process (stale PID reuse) — cleaning up PID file only",
-    );
-    cleanupPidFile();
-    return { stopped: false, reason: "not_running" };
-  }
-
-  process.kill(pid, "SIGTERM");
-
-  const timeouts = readDaemonTimeouts();
-
-  // Wait for process to exit
-  const maxWait = timeouts.stopTimeoutMs;
-  const interval = 100;
-  let waited = 0;
-  while (waited < maxWait) {
-    if (!isProcessRunning(pid)) {
-      cleanupPidFile();
-      return { stopped: true };
-    }
-    await new Promise((r) => setTimeout(r, interval));
-    waited += interval;
-  }
-
-  // Force kill
-  try {
-    process.kill(pid, "SIGKILL");
-  } catch (err) {
-    log.debug({ err, pid }, "SIGKILL failed, process already exited");
-  }
-
-  // Wait for the process to actually die after SIGKILL. Without this,
-  // startDaemon() can race with the dying process's shutdown handler.
-  const killMaxWait = timeouts.sigkillGracePeriodMs;
-  let killWaited = 0;
-  while (killWaited < killMaxWait && isProcessRunning(pid)) {
-    await new Promise((r) => setTimeout(r, 100));
-    killWaited += 100;
-  }
-
-  // Only clean up if the process has actually exited.
-  // If it's still alive after SIGKILL + timeout, preserve the PID file
-  // so isDaemonRunning() still reports true and prevents a duplicate
-  // daemon from being spawned.
-  if (!isProcessRunning(pid)) {
-    cleanupPidFile();
-    return { stopped: true };
-  }
-
-  log.warn(
-    { pid },
-    "Daemon process still running after SIGKILL + timeout, leaving PID file intact",
-  );
-  return { stopped: false, reason: "stop_failed" };
-}
-
 export async function ensureDaemonRunning(): Promise<void> {
   const status = await getDaemonStatus();
   if (status.running) return;

package/src/daemon/daemon-skill-host.ts

@@ -13,7 +13,7 @@
  * — pino's `(meta, msg)` log methods vs the contract's `(msg, meta)`,
  * `getAssistantName()` returning `null` vs the contract's `undefined`,
  * `getProviderKeyAsync()` returning `undefined` vs the contract's `null`,
- * `buildAssistantEvent()` taking an assistantId first arg, etc. — the
+ * `buildAssistantEvent()` signature differences, etc. — the
  * adaptation happens inside this file so the contract stays narrow and the
  * underlying daemon APIs stay unchanged.
  */
@@ -69,7 +69,6 @@ import { resolveStreamingTranscriber as sttResolveStreamingTranscriber } from ".
 import { wakeAgentForOpportunity } from "../runtime/agent-wake.js";
 import { buildAssistantEvent } from "../runtime/assistant-event.js";
 import { assistantEventHub } from "../runtime/assistant-event-hub.js";
-import { DAEMON_INTERNAL_ASSISTANT_ID } from "../runtime/assistant-scope.js";
 import { getDaemonRuntimeMode } from "../runtime/runtime-mode.js";
 import { registerSkillRoute } from "../runtime/skill-route-registry.js";
 import { getProviderKeyAsync } from "../security/secure-keys.js";
@@ -118,7 +117,6 @@ function buildIdentityFacet(): IdentityFacet {
   return {
     // Contract uses `undefined`; delegate returns `null`. Normalize here.
     getAssistantName: () => getAssistantName() ?? undefined,
-    internalAssistantId: DAEMON_INTERNAL_ASSISTANT_ID,
   };
 }
 
@@ -204,15 +202,14 @@ function buildEventsFacet(): EventsFacet {
     publish: (event: AssistantEvent) =>
       assistantEventHub.publish(event as never),
     subscribe: (filter: Filter, cb: AssistantEventCallback): Subscription =>
-      assistantEventHub.subscribe(filter, cb as never),
-    // `buildAssistantEvent` takes `(assistantId, message, conversationId?)`.
-    // Skills always publish as the internal assistant, so curry that arg.
+      assistantEventHub.subscribe({
+        type: "process",
+        filter,
+        callback: cb,
+      }),
+    // `buildAssistantEvent` takes `(message, conversationId?)`.
     buildEvent: (message: ServerMessage, conversationId?: string) =>
-      buildAssistantEvent(
-        DAEMON_INTERNAL_ASSISTANT_ID,
-        message as never,
-        conversationId,
-      ) as AssistantEvent,
+      buildAssistantEvent(message as never, conversationId) as AssistantEvent,
   };
 }
 

package/src/daemon/dictation-profile-store.ts

@@ -5,15 +5,8 @@
  * atomic-write pattern (write .tmp → rename → chmod).
  */
 
-import {
-  chmodSync,
-  existsSync,
-  mkdirSync,
-  readFileSync,
-  renameSync,
-  writeFileSync,
-} from "node:fs";
-import { dirname, join } from "node:path";
+import { existsSync, readFileSync } from "node:fs";
+import { join } from "node:path";
 
 import { getLogger } from "../util/logger.js";
 import { getWorkspaceDir } from "../util/platform.js";
@@ -250,18 +243,6 @@ function loadFromDisk(): DictationProfilesConfig {
   }
 }
 
-function saveToDisk(config: DictationProfilesConfig): void {
-  const path = getStorePath();
-  const dir = dirname(path);
-  if (!existsSync(dir)) {
-    mkdirSync(dir, { recursive: true });
-  }
-  const tmpPath = path + ".tmp." + process.pid;
-  writeFileSync(tmpPath, JSON.stringify(config, null, 2), { mode: 0o600 });
-  renameSync(tmpPath, path);
-  chmodSync(path, 0o600);
-}
-
 // --- Public API ---
 
 export function loadConfig(): DictationProfilesConfig {
@@ -271,11 +252,6 @@ export function loadConfig(): DictationProfilesConfig {
   return cachedConfig;
 }
 
-export function saveConfig(config: DictationProfilesConfig): void {
-  cachedConfig = config;
-  saveToDisk(config);
-}
-
 function isProfileEnabled(profile: DictationProfile): boolean {
   return profile.enabled !== false;
 }

package/src/daemon/first-greeting.ts

@@ -2,18 +2,21 @@ import { existsSync } from "node:fs";
 
 import { getWorkspacePromptPath } from "../util/platform.js";
 
+type Tone = "grounded" | "warm" | "energetic" | "poetic";
+
 export interface OnboardingGreetingContext {
   tools: string[];
   tasks: string[];
+  /** Valid values: "grounded" | "warm" | "energetic" | "poetic" */
   tone: string;
   userName?: string;
   assistantName?: string;
 }
 
 export const CANNED_FIRST_GREETING = [
-  "Hey — brand new, no name, no memories, no idea who you are yet. I'll get sharper the more we work together.",
+  "Hey,",
   "",
-  "What can I do for you? Or I can ask you some questions to get started.",
+  "We can get into whatever you've got, or just talk first — that tends to go better. Up to you.",
 ].join("\n");
 
 /**
@@ -45,174 +48,59 @@ export function getCannedFirstGreeting(
   return CANNED_FIRST_GREETING;
 }
 
-const TOOL_LABELS: Record<string, string> = {
-  gmail: "Gmail",
-  outlook: "Outlook",
-  "google-calendar": "Google Calendar",
-  slack: "Slack",
-  notion: "Notion",
-  linear: "Linear",
-  jira: "Jira",
-  github: "GitHub",
-  figma: "Figma",
-  "google-drive": "Google Drive",
-  excel: "Excel",
-  "apple-notes": "Apple Notes",
+const TONE_INTRO_CLOSE: Record<Tone, string> = {
+  grounded: "",
+  warm: "Good to meet you.",
+  energetic: "Let's see what you've got.",
+  poetic: "",
 };
 
-const TASK_PRIORITY: string[] = [
-  "code-building",
-  "project-management",
-  "writing",
-  "research",
-  "scheduling",
-  "personal",
-];
-
-interface Guess {
-  text: string;
-  preferredTools: string[];
+function buildIntroLine(
+  name?: string,
+  assistant?: string,
+  tone: Tone = "grounded",
+): string {
+  const greeting = name ? `Hey ${name},` : "Hey,";
+  const who = assistant ? `I'm ${assistant}.` : "";
+  const close = assistant ? TONE_INTRO_CLOSE[tone] : "";
+  return [greeting, who, close].filter(Boolean).join(" ");
 }
 
-const SINGLE_GUESSES: Record<string, Guess> = {
-  "code-building": {
-    text: "shipping something or debugging",
-    preferredTools: ["github", "linear", "jira"],
-  },
-  writing: {
-    text: "drafting something or cleaning up docs",
-    preferredTools: ["notion", "google-drive", "apple-notes"],
-  },
-  research: {
-    text: "digging into a topic or making sense of something",
-    preferredTools: ["notion", "google-drive"],
-  },
-  "project-management": {
-    text: "planning the week, writing a spec, or pushing something forward",
-    preferredTools: ["notion", "linear", "google-drive"],
-  },
-  scheduling: {
-    text: "planning the week or prepping for meetings",
-    preferredTools: ["google-calendar", "outlook", "linear"],
-  },
-  personal: {
-    text: "juggling travel, bills, or household stuff",
-    preferredTools: ["gmail", "google-calendar", "apple-notes"],
-  },
+const TONE_INVITE: Record<Tone, string> = {
+  grounded:
+    "We can get into whatever you've got, or just talk first — that tends to go better. Up to you.",
+  warm: "We can start on something specific, or just talk for a bit first — honestly that tends to work out better. Either way, I'm here.",
+  energetic:
+    "We can jump straight into whatever you've got, or take a few minutes to just talk first. What sounds right?",
+  poetic:
+    "We can start with whatever's in front of you, or just talk for a bit first. Either way.",
 };
 
-const COMBO_GUESSES: Record<string, Guess> = {
-  "code-building+project-management": {
-    text: "shipping code or figuring out what to ship next",
-    preferredTools: ["github", "linear", "jira"],
-  },
-  "code-building+writing": {
-    text: "shipping code or writing something up",
-    preferredTools: ["github", "linear", "jira"],
-  },
-  "project-management+writing": {
-    text: "writing a spec or pushing something forward",
-    preferredTools: ["notion", "linear", "google-drive"],
-  },
-  "research+writing": {
-    text: "drafting something or digging into a topic",
-    preferredTools: ["notion", "google-drive"],
-  },
-  "project-management+scheduling": {
-    text: "planning the week or prepping for something",
-    preferredTools: ["google-calendar", "outlook", "linear"],
-  },
-};
-
-function comboKey(a: string, b: string): string {
-  return [a, b].sort().join("+");
-}
-
-function highestPriorityTask(tasks: string[]): string | undefined {
-  for (const t of TASK_PRIORITY) {
-    if (tasks.includes(t)) return t;
-  }
-  return tasks[0];
-}
-
-function buildIntroLine(userName?: string, assistantName?: string): string {
-  const namepart = userName ? `Hey ${userName},` : "Hey,";
-  const who = assistantName
-    ? `I'm ${assistantName}. Brand new, and I'll get sharper the more we work together.`
-    : "brand new, and I'll get sharper the more we work together.";
-  return `${namepart} ${who}`;
+function buildInvite(tone: Tone = "grounded"): string {
+  return TONE_INVITE[tone];
 }
 
-function pickRelevantTools(
-  preferredTools: string[],
-  userTools: string[],
-): string[] {
-  const userSet = new Set(userTools);
-  const matched: string[] = [];
-  for (const t of preferredTools) {
-    if (userSet.has(t)) {
-      matched.push(TOOL_LABELS[t] ?? t);
-      if (matched.length === 2) break;
-    }
-  }
-  return matched;
-}
-
-function buildSpecificGuess(tasks: string[], tools: string[]): string {
-  let guess: Guess | undefined;
-
-  if (tasks.length === 2) {
-    guess = COMBO_GUESSES[comboKey(tasks[0], tasks[1])];
-  }
-
-  if (!guess) {
-    const top = highestPriorityTask(tasks);
-    guess = top ? SINGLE_GUESSES[top] : undefined;
-  }
-
-  if (!guess) return "";
-
-  const relevant = pickRelevantTools(guess.preferredTools, tools);
-
-  if (relevant.length === 2) {
-    return `You mentioned using ${relevant[0]} and ${relevant[1]} — probably ${guess.text}? Am I on the right track, or something else on your mind?`;
-  }
-  if (relevant.length === 1) {
-    return `You mentioned using ${relevant[0]} — probably ${guess.text}? Am I on the right track, or something else on your mind?`;
-  }
+const VALID_TONES = new Set<string>([
+  "grounded",
+  "warm",
+  "energetic",
+  "poetic",
+]);
 
-  return `Probably ${guess.text}? Am I on the right track, or something else on your mind?`;
+function resolveTone(raw?: string): Tone {
+  return raw && VALID_TONES.has(raw) ? (raw as Tone) : "grounded";
 }
 
 function buildPersonalizedGreeting(ctx: OnboardingGreetingContext): string {
-  const userName = ctx.userName?.trim();
-  const assistantName = ctx.assistantName?.trim();
-
-  const hasName = userName && userName.length > 0;
-  const hasTasks = ctx.tasks.length > 0;
-  const hasTools = ctx.tools.length > 0;
+  const name = ctx.userName?.trim();
+  const assistant = ctx.assistantName?.trim();
+  const tone = resolveTone(ctx.tone);
 
-  const hasAssistantName = assistantName && assistantName.length > 0;
-
-  if (!hasName && !hasTasks && !hasTools && !hasAssistantName) {
+  if (!name && !assistant && !VALID_TONES.has(ctx.tone)) {
     return CANNED_FIRST_GREETING;
   }
 
-  const intro = buildIntroLine(hasName ? userName : undefined, assistantName);
-
-  let secondParagraph: string;
-
-  if (ctx.tasks.length >= 4) {
-    secondParagraph =
-      "Looks like you wear a lot of hats. Where should we start?";
-  } else if (ctx.tasks.length === 0) {
-    secondParagraph =
-      "What's on your plate? Or if it's easier, I can ask you a few questions to get oriented.";
-  } else {
-    secondParagraph =
-      buildSpecificGuess(ctx.tasks, ctx.tools) ||
-      "What's on your plate? Or if it's easier, I can ask you a few questions to get oriented.";
-  }
-
-  return [intro, "", secondParagraph].join("\n");
+  const intro = buildIntroLine(name, assistant, tone);
+  const invite = buildInvite(tone);
+  return [intro, "", invite].join("\n");
 }

package/src/daemon/handlers/config-channels.ts

@@ -12,6 +12,7 @@ import { revokeMember } from "../../contacts/contacts-write.js";
 import type { ChannelStatus } from "../../contacts/types.js";
 import { getBindingByChannelChat } from "../../memory/external-conversation-store.js";
 import { resolveGuardianName } from "../../prompts/user-reference.js";
+import { broadcastMessage } from "../../runtime/assistant-event-hub.js";
 import { DAEMON_INTERNAL_ASSISTANT_ID } from "../../runtime/assistant-scope.js";
 import {
   type ChannelReadinessService,
@@ -49,7 +50,7 @@ import type {
   ChannelVerificationSessionRequest,
   ChannelVerificationSessionResponse,
 } from "../message-protocol.js";
-import { type HandlerContext, log } from "./shared.js";
+import { log } from "./shared.js";
 
 // -- Transport-agnostic result type (omits the `type` discriminant) --
 
@@ -522,14 +523,13 @@ export async function verifyTrustedContact(
 
 export async function handleChannelVerificationSession(
   msg: ChannelVerificationSessionRequest,
-  ctx: HandlerContext,
 ): Promise<void> {
   const channel = msg.channel ?? "telegram";
 
   try {
     if (msg.action === "create_session") {
       if (msg.purpose === "trusted_contact" && !msg.contactChannelId) {
-        ctx.send({
+        broadcastMessage({
           type: "channel_verification_session_response",
           success: false,
           error: "contactChannelId is required for trusted_contact purpose",
@@ -540,7 +540,7 @@ export async function handleChannelVerificationSession(
           msg.contactChannelId!,
           DAEMON_INTERNAL_ASSISTANT_ID,
         );
-        ctx.send({
+        broadcastMessage({
           type: "channel_verification_session_response",
           ...result,
         });
@@ -556,7 +556,7 @@ export async function handleChannelVerificationSession(
           deliverVerificationSlack(userId, text, aid);
         }
         const { _pendingSlackDm: _, ...publicResult } = result;
-        ctx.send({
+        broadcastMessage({
           type: "channel_verification_session_response",
           ...publicResult,
         });
@@ -566,28 +566,28 @@ export async function handleChannelVerificationSession(
           msg.rebind,
           msg.conversationId,
         );
-        ctx.send({
+        broadcastMessage({
           type: "channel_verification_session_response",
           ...result,
         });
       }
     } else if (msg.action === "status") {
       const result = getVerificationStatus(channel);
-      ctx.send({
+      broadcastMessage({
         type: "channel_verification_session_response",
         ...result,
       });
     } else if (msg.action === "cancel_session") {
       cancelOutbound({ channel });
       revokePendingSessions(channel);
-      ctx.send({
+      broadcastMessage({
         type: "channel_verification_session_response",
         success: true,
         channel,
       });
     } else if (msg.action === "revoke") {
       const result = revokeVerificationForChannel(channel);
-      ctx.send({
+      broadcastMessage({
         type: "channel_verification_session_response",
         ...result,
       });
@@ -601,12 +601,12 @@ export async function handleChannelVerificationSession(
         deliverVerificationSlack(userId, text, aid);
       }
       const { _pendingSlackDm: _, ...publicResult } = result;
-      ctx.send({
+      broadcastMessage({
         type: "channel_verification_session_response",
         ...publicResult,
       });
     } else {
-      ctx.send({
+      broadcastMessage({
         type: "channel_verification_session_response",
         success: false,
         error: `Unknown action: ${String(msg.action)}`,
@@ -616,7 +616,7 @@ export async function handleChannelVerificationSession(
   } catch (err) {
     const message = err instanceof Error ? err.message : String(err);
     log.error({ err }, "Failed to handle channel verification session");
-    ctx.send({
+    broadcastMessage({
       type: "channel_verification_session_response",
       success: false,
       error: message,