@vellumai/assistant 0.7.0 → 0.7.1

package/src/__tests__/conversation-starter-routes.test.ts

@@ -281,7 +281,10 @@ describe("GET /v1/conversation-starters", () => {
       category: "productivity",
       createdAt: now - 1,
     });
-    setCheckpoint("conversation_starters:last_gen_at:default", String(now));
+    setCheckpoint(
+      "conversation_starters:last_gen_at:default",
+      String(now - 90_000),
+    );
     setCheckpoint("conversation_starters:item_count_at_last_gen:default", "1");
     insertMemoryItem();
 
@@ -313,7 +316,10 @@ describe("GET /v1/conversation-starters", () => {
       category: "communication",
       createdAt: now - 1,
     });
-    setCheckpoint("conversation_starters:last_gen_at:default", String(now));
+    setCheckpoint(
+      "conversation_starters:last_gen_at:default",
+      String(now - 90_000),
+    );
     setCheckpoint("conversation_starters:item_count_at_last_gen:default", "1");
     insertMemoryItem();
 
@@ -331,6 +337,77 @@ describe("GET /v1/conversation-starters", () => {
     expect(countStarterJobs()).toBe(1);
   });
 
+  test("does not re-enqueue for invalid items when within cooldown period", async () => {
+    const now = Date.now();
+    // Generation happened 30 seconds ago (within the 60s cooldown)
+    const recentGenAt = now - 30_000;
+    insertStarter({
+      label: "Let me check calendar",
+      prompt: "Let me check what Alice has today.",
+      category: "productivity",
+      createdAt: now,
+    });
+    insertStarter({
+      label: "Plan my morning",
+      prompt: "Can you help me plan my morning?",
+      category: "productivity",
+      createdAt: now - 1,
+    });
+    setCheckpoint(
+      "conversation_starters:last_gen_at:default",
+      String(recentGenAt),
+    );
+    setCheckpoint("conversation_starters:item_count_at_last_gen:default", "1");
+    insertMemoryItem();
+
+    const result = (await dispatch("conversation-starters")) as {
+      starters: unknown[];
+      total: number;
+      status: string;
+    };
+
+    // The invalid "assistant-voice" starter triggers invalidItemCount > 0,
+    // but the cooldown prevents re-enqueueing — status should be "ready".
+    expect(result.status).toBe("ready");
+    expect(result.total).toBe(1);
+    expect(countStarterJobs()).toBe(0);
+  });
+
+  test("re-enqueues for invalid items after cooldown expires", async () => {
+    const now = Date.now();
+    // Generation happened 90 seconds ago (past the 60s cooldown)
+    const oldGenAt = now - 90_000;
+    insertStarter({
+      label: "Let me check calendar",
+      prompt: "Let me check what Alice has today.",
+      category: "productivity",
+      createdAt: now,
+    });
+    insertStarter({
+      label: "Plan my morning",
+      prompt: "Can you help me plan my morning?",
+      category: "productivity",
+      createdAt: now - 1,
+    });
+    setCheckpoint(
+      "conversation_starters:last_gen_at:default",
+      String(oldGenAt),
+    );
+    setCheckpoint("conversation_starters:item_count_at_last_gen:default", "1");
+    insertMemoryItem();
+
+    const result = (await dispatch("conversation-starters")) as {
+      starters: unknown[];
+      total: number;
+      status: string;
+    };
+
+    // Past the cooldown — should re-enqueue and return refreshing.
+    expect(result.status).toBe("refreshing");
+    expect(result.total).toBe(1);
+    expect(countStarterJobs()).toBe(1);
+  });
+
   test("returns empty status when no memory items exist", async () => {
     const result = (await dispatch("conversation-starters")) as {
       starters: unknown[];

package/src/__tests__/conversation-surfaces-standalone-payloads.test.ts

@@ -17,7 +17,14 @@
  * and dispatches them in ChatActionHandler → ChatViewModel+SurfaceHandling.
  */
 
-import { describe, expect, test } from "bun:test";
+import { describe, expect, mock, test } from "bun:test";
+
+import type { ServerMessage } from "../daemon/message-protocol.js";
+
+let broadcastImpl: (msg: ServerMessage) => void = () => {};
+mock.module("../runtime/assistant-event-hub.js", () => ({
+  broadcastMessage: (msg: ServerMessage) => broadcastImpl(msg),
+}));
 
 import {
   buildCompletionSummary,
@@ -25,7 +32,6 @@ import {
   showStandaloneSurface,
   type SurfaceConversationContext,
 } from "../daemon/conversation-surfaces.js";
-import type { ServerMessage } from "../daemon/message-protocol.js";
 
 // ── Helpers ──────────────────────────────────────────────────────────
 
@@ -40,6 +46,7 @@ function createMockContext(
   enqueuedMessages: Array<{ content: string; requestId: string }>;
 } {
   const sentMessages: ServerMessage[] = [];
+  broadcastImpl = (msg: ServerMessage) => sentMessages.push(msg);
   const enqueuedMessages: Array<{ content: string; requestId: string }> = [];
 
   return {
@@ -54,7 +61,6 @@ function createMockContext(
       : undefined,
     traceEmitter: { emit: () => {} },
     sendToClient: (msg: ServerMessage) => sentMessages.push(msg),
-    broadcastToAllClients: (msg: ServerMessage) => sentMessages.push(msg),
     pendingSurfaceActions: new Map(),
     lastSurfaceAction: new Map(),
     surfaceState: new Map(),
@@ -67,8 +73,9 @@ function createMockContext(
     hasNoClient: overrides?.hasNoClient ?? false,
     isProcessing: () => false,
     enqueueMessage: (content, _attachments, _onEvent, requestId) => {
-      enqueuedMessages.push({ content, requestId });
-      return { queued: false, requestId };
+      const resolvedId = requestId ?? "mock-request-id";
+      enqueuedMessages.push({ content, requestId: resolvedId });
+      return { queued: false, requestId: resolvedId };
     },
     getQueueDepth: () => 0,
     processMessage: async () => "msg-id",

package/src/__tests__/conversation-surfaces-standalone.test.ts

@@ -1,4 +1,12 @@
-import { afterEach, beforeEach, describe, expect, test } from "bun:test";
+import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
+
+import type { ServerMessage } from "../daemon/message-protocol.js";
+import type { InteractiveUiResult } from "../runtime/interactive-ui.js";
+
+let broadcastImpl: (msg: ServerMessage) => void = () => {};
+mock.module("../runtime/assistant-event-hub.js", () => ({
+  broadcastMessage: (msg: ServerMessage) => broadcastImpl(msg),
+}));
 
 import {
   canShowInteractiveUi,
@@ -7,8 +15,6 @@ import {
   showStandaloneSurface,
   type SurfaceConversationContext,
 } from "../daemon/conversation-surfaces.js";
-import type { ServerMessage } from "../daemon/message-protocol.js";
-import type { InteractiveUiResult } from "../runtime/interactive-ui.js";
 
 // ── Helpers ──────────────────────────────────────────────────────────
 
@@ -28,6 +34,7 @@ function createMockContext(
   enqueuedMessages: Array<{ content: string; requestId: string }>;
 } {
   const sentMessages: ServerMessage[] = [];
+  broadcastImpl = (msg: ServerMessage) => sentMessages.push(msg);
   const enqueuedMessages: Array<{ content: string; requestId: string }> = [];
 
   return {
@@ -44,7 +51,6 @@ function createMockContext(
       emit: () => {},
     },
     sendToClient: (msg: ServerMessage) => sentMessages.push(msg),
-    broadcastToAllClients: (msg: ServerMessage) => sentMessages.push(msg),
     pendingSurfaceActions: new Map(),
     lastSurfaceAction: new Map(),
     surfaceState: new Map(),
@@ -58,8 +64,9 @@ function createMockContext(
     hasNoClient: overrides?.hasNoClient ?? false,
     isProcessing: () => false,
     enqueueMessage: (content, _attachments, _onEvent, requestId) => {
-      enqueuedMessages.push({ content, requestId });
-      return { queued: false, requestId };
+      const resolvedId = requestId ?? "mock-request-id";
+      enqueuedMessages.push({ content, requestId: resolvedId });
+      return { queued: false, requestId: resolvedId };
     },
     getQueueDepth: () => 0,
     processMessage: async () => "msg-id",
@@ -291,9 +298,8 @@ describe("showStandaloneSurface", () => {
 
   test("timeout still resolves when emit throws", async () => {
     const ctx = createMockContext();
-    // Override broadcastToAllClients to throw on ui_surface_complete
     let showEmitted = false;
-    ctx.broadcastToAllClients = (msg: ServerMessage) => {
+    broadcastImpl = (msg: ServerMessage) => {
       const type = (msg as unknown as Record<string, unknown>).type;
       if (type === "ui_surface_show") {
         showEmitted = true;
@@ -518,14 +524,13 @@ describe("standalone surface cleanup on conversation dispose", () => {
 
     // Simulate conversation dispose — cancel all pending with dismiss
     // notifications, matching the Conversation.dispose() implementation.
-    const emit = ctx.broadcastToAllClients ?? ctx.sendToClient.bind(ctx);
     for (const [surfaceId, entry] of ctx.pendingStandaloneSurfaces!) {
       clearTimeout(entry.timer);
-      emit({
+      broadcastImpl({
         type: "ui_surface_dismiss",
         conversationId: ctx.conversationId,
         surfaceId,
-      });
+      } as ServerMessage);
       entry.resolve({ status: "cancelled", surfaceId });
     }
     ctx.pendingStandaloneSurfaces!.clear();
@@ -568,14 +573,13 @@ describe("standalone surface cleanup on conversation dispose", () => {
     ctx.sentMessages.length = 0;
 
     // Simulate the dispose path (matching Conversation.dispose())
-    const emit = ctx.broadcastToAllClients ?? ctx.sendToClient.bind(ctx);
     for (const [surfaceId, entry] of ctx.pendingStandaloneSurfaces!) {
       clearTimeout(entry.timer);
-      emit({
+      broadcastImpl({
         type: "ui_surface_dismiss",
         conversationId: ctx.conversationId,
         surfaceId,
-      });
+      } as ServerMessage);
       entry.resolve({ status: "cancelled", surfaceId });
     }
     ctx.pendingStandaloneSurfaces!.clear();

package/src/__tests__/conversation-surfaces-state-update.test.ts

@@ -46,8 +46,9 @@ function makeContext(opts?: {
     currentTurnSurfaces: [],
     isProcessing: () => false,
     enqueueMessage: (content, _attachments, _onEvent, requestId) => {
-      enqueueCalls.push({ content, requestId });
-      return { queued: false, requestId };
+      const resolvedId = requestId ?? "mock-request-id";
+      enqueueCalls.push({ content, requestId: resolvedId });
+      return { queued: false, requestId: resolvedId };
     },
     getQueueDepth: () => 0,
     processMessage: async (content, _attachments, _onEvent, requestId) => {

package/src/__tests__/conversation-tool-setup-app-refresh.test.ts

@@ -25,6 +25,11 @@ import type { ToolExecutionResult } from "../tools/types.js";
 
 const refreshSpy = mock(() => {});
 const updatePublishedSpy = mock(() => Promise.resolve());
+const broadcastSpy = mock(() => {});
+
+mock.module("../runtime/assistant-event-hub.js", () => ({
+  broadcastMessage: broadcastSpy,
+}));
 
 // Mock session-surfaces so refreshSurfacesForApp is captured
 mock.module("../daemon/conversation-surfaces.js", () => ({
@@ -120,6 +125,7 @@ const noopLifecycleHandler = mock(() => {});
 describe("session-tool-setup app refresh side effects", () => {
   beforeEach(() => {
     refreshSpy.mockClear();
+    broadcastSpy.mockClear();
     updatePublishedSpy.mockClear();
   });
 
@@ -132,7 +138,6 @@ describe("session-tool-setup app refresh side effects", () => {
         content: '{"id":"app-1"}',
         isError: false,
       });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -140,7 +145,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_refresh", { app_id: "app-1" });
@@ -153,7 +157,6 @@ describe("session-tool-setup app refresh side effects", () => {
     test("broadcasts app_files_changed with correct appId", async () => {
       const ctx = makeCtx();
       const executor = makeFakeExecutor({ content: "{}", isError: false });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -161,7 +164,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_refresh", { app_id: "app-42" });
@@ -183,7 +185,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        mock(() => {}),
       );
 
       await toolFn("app_refresh", { app_id: "app-publish" });
@@ -202,7 +203,6 @@ describe("session-tool-setup app refresh side effects", () => {
         content: "Error: not found",
         isError: true,
       });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -210,7 +210,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_refresh", { app_id: "app-err" });
@@ -223,7 +222,6 @@ describe("session-tool-setup app refresh side effects", () => {
     test("skips side effects when app_id is missing", async () => {
       const ctx = makeCtx();
       const executor = makeFakeExecutor({ content: "{}", isError: false });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -231,7 +229,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_refresh", {});
@@ -250,7 +247,6 @@ describe("session-tool-setup app refresh side effects", () => {
         content: JSON.stringify({ id: "new-app-1", name: "My App" }),
         isError: false,
       });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -258,7 +254,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_create", { name: "My App", html: "<h1>hi</h1>" });
@@ -273,7 +268,6 @@ describe("session-tool-setup app refresh side effects", () => {
     test("skips side effects when app_create result is an error", async () => {
       const ctx = makeCtx();
       const executor = makeFakeExecutor({ content: "Error", isError: true });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -281,7 +275,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_create", { name: "Bad", html: "" });
@@ -305,7 +298,6 @@ describe("session-tool-setup app refresh side effects", () => {
         }),
         isError: false,
       });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -313,7 +305,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_create", { name: "Busted", html: "" });
@@ -334,7 +325,6 @@ describe("session-tool-setup app refresh side effects", () => {
     test("broadcasts app_files_changed after app_delete", async () => {
       const ctx = makeCtx();
       const executor = makeFakeExecutor({ content: "{}", isError: false });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -342,7 +332,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_delete", { app_id: "del-app-1" });
@@ -357,7 +346,6 @@ describe("session-tool-setup app refresh side effects", () => {
     test("skips side effects when app_delete result is an error", async () => {
       const ctx = makeCtx();
       const executor = makeFakeExecutor({ content: "Error", isError: true });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -365,7 +353,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       await toolFn("app_delete", { app_id: "del-err" });
@@ -384,7 +371,6 @@ describe("session-tool-setup app refresh side effects", () => {
       // hooks as core tools.
       const ctx = makeCtx();
       const executor = makeFakeExecutor({ content: "{}", isError: false });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -392,12 +378,12 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       // Simulate calling app_refresh by name (as the agent loop does)
       for (const toolName of ["app_refresh"]) {
         refreshSpy.mockClear();
+    broadcastSpy.mockClear();
         broadcastSpy.mockClear();
         updatePublishedSpy.mockClear();
 
@@ -418,7 +404,6 @@ describe("session-tool-setup app refresh side effects", () => {
     test("other tool names do not trigger app refresh side effects", async () => {
       const ctx = makeCtx();
       const executor = makeFakeExecutor({ content: "{}", isError: false });
-      const broadcastSpy = mock(() => {});
 
       const toolFn = createToolExecutor(
         executor as unknown as ToolExecutor,
@@ -426,7 +411,6 @@ describe("session-tool-setup app refresh side effects", () => {
         noopSecretPrompter,
         ctx,
         noopLifecycleHandler,
-        broadcastSpy,
       );
 
       for (const toolName of [
@@ -439,6 +423,7 @@ describe("session-tool-setup app refresh side effects", () => {
         "app_file_write",
       ]) {
         refreshSpy.mockClear();
+    broadcastSpy.mockClear();
         broadcastSpy.mockClear();
         updatePublishedSpy.mockClear();
 
@@ -451,28 +436,5 @@ describe("session-tool-setup app refresh side effects", () => {
     });
   });
 
-  // ── broadcastToAllClients optional ──────────────────────────────────
-
-  describe("broadcastToAllClients is optional", () => {
-    test("side effects work without broadcastToAllClients callback", async () => {
-      const ctx = makeCtx();
-      const executor = makeFakeExecutor({ content: "{}", isError: false });
-
-      // No broadcast callback provided
-      const toolFn = createToolExecutor(
-        executor as unknown as ToolExecutor,
-        noopPrompter,
-        noopSecretPrompter,
-        ctx,
-        noopLifecycleHandler,
-      );
-
-      // Should not throw even though broadcastToAllClients is undefined
-      const result = await toolFn("app_refresh", { app_id: "app-no-bc" });
 
-      expect(result.isError).toBe(false);
-      expect(refreshSpy).toHaveBeenCalledTimes(1);
-      expect(updatePublishedSpy).toHaveBeenCalledTimes(1);
-    });
-  });
 });