@openui5/sap.m 1.97.1 → 1.99.1

package/src/sap/m/IllustrationPool.js

@@ -0,0 +1,392 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+sap.ui.define([
+	"sap/base/Log",
+	"./library",
+	'sap/ui/core/Core',
+	"sap/ui/thirdparty/jquery"
+],
+	function(Log, mLibrary, Core, jQuery) {
+		"use strict";
+
+		/**
+		 * STATIC MEMBERS
+		 */
+		var SAP_ILLUSTRATION_POOL_ID = 'sap-ui-illustration-pool',
+			SAP_ILLUSTRATION_PATTERNS_NAME = '-Patterns',
+			SAP_ILLUSTRATION_SET_NAME = 'sapIllus',
+			SAP_ILLUSTRATION_SET_PATH = sap.ui.require.toUrl("sap/m/themes/base/illustrations/"),
+			SAP_ILLUSTRATION_SET_SYMBOLS = Object.keys(mLibrary.IllustratedMessageType);
+
+		/*
+		 * A map of registered sets
+		 * key: set name
+		 * value: configuration object containing
+		 *   key: sPath
+		 *   value: string path of the illustration set
+		 *   key: aSymbols
+		 *   value: array of the symbols names which the illustration set supports
+		 *   key: bIsPending
+		 *   value: boolean of whether or not the Illustration Set is loading
+		 */
+
+		var oSetRegistry = Object.create(null);
+
+		oSetRegistry[SAP_ILLUSTRATION_SET_NAME] = {
+			sPath: SAP_ILLUSTRATION_SET_PATH,
+			aSymbols: SAP_ILLUSTRATION_SET_SYMBOLS,
+			bIsPending: false
+		};
+
+		var aSymbolsInDOM = [], // Array with IDs of the symbols which are already in the DOM
+			oAssetRegistry = Object.create(null), // Object with IDs of the assets which are loaded or being loaded
+			oLoadedSymbols = Object.create(null), // Object which stores the loaded HTML raw data for a given asset for future reuse (might not be in the DOM yet)
+			oRequiredAssets = Object.create(null); // Object which stores the last required asset ID for a given instance
+
+		/**
+		 * <code>IllustrationPool</code> loads the illustration assets (SVGs) via XMLHttpRequest requests.
+		 *
+		 * The successfully loaded data is kept in the DOM (div with ID <code>sap-illustration-pool</code>)
+		 * in the <code>sap-ui-static</code> DOM element.
+		 *
+		 * To load a given asset, register its illustration set through the
+		 * {@link sap.m.IllustrationPool.registerIllustrationSet registerIllustrationSet} API of <code>IllustrationPool</code>.
+		 * The exception being the <code>sapIllus</code>, which is the default illustration set
+		 * that is registered by default.
+		 *
+		 * The default behavior of <code>IllustrationPool</code> is to load/require an asset only
+		 * when it's needed by using the {@link sap.m.IllustrationPool.loadAsset} API.
+		 * When registering the new illustration set, you are given the option to load all of its assets.
+		 *
+		 * If some of the assets are not loaded initially, you can load the rest of them on
+		 * a later state with the {@link sap.m.IllustrationPool.loadRestOfTheAssets} API.
+		 *
+		 * @namespace
+		 * @since 1.98
+		 * @public
+		 * @alias sap.m.IllustrationPool
+		 */
+		var IllustrationPool = {};
+
+		/**
+		 * PUBLIC METHODS
+		 */
+
+		/**
+		 * Loads an SVG asset depending on the input asset ID.
+		 *
+		 * @param {string} sAssetId The string ID of the asset being loaded
+		 * @param {string} sInstanceId the ID of the Illustration instance which is requiring the asset
+		 * @static
+		 * @public
+		 */
+		IllustrationPool.loadAsset = function (sAssetId, sInstanceId) {
+			var sSet;
+
+			if (sAssetId === "") {
+				Log.error("ID of the asset can not be blank/empty.");
+				return;
+			}
+
+			// if the the asset is required by an instance - cache its ID
+			if (sInstanceId) {
+				oRequiredAssets[sInstanceId] = sAssetId;
+			}
+
+			if (oAssetRegistry[sAssetId]) {
+				Log.info("The asset with ID '" + sAssetId + "' is either loaded or being loaded.");
+				// if the the asset is required by an instance and it's loaded - update the DOM pool
+				if (sInstanceId && oLoadedSymbols[sAssetId]) {
+					IllustrationPool._updateDOMPool();
+				}
+				return;
+			}
+
+			sSet = sAssetId.split("-")[0];
+
+			if (!oSetRegistry[sSet]) {
+				Log.error("The illustration set '" + sSet + "' is not registered. Please register it before requiring one of its assets.");
+				return;
+			}
+
+			oAssetRegistry[sAssetId] = true;
+
+			IllustrationPool._requireSVG(sSet, sAssetId, sInstanceId);
+		};
+
+		/**
+		 * Loads the rest of the SVG assets for a given illustration set.
+		 *
+		 * @param {string} sIllustrationSet The illustration set, the rest of the assets should be loaded for
+		 * @static
+		 * @public
+		 */
+		IllustrationPool.loadRestOfTheAssets = function(sIllustrationSet) {
+			var aSymbols;
+
+			if (!oSetRegistry[sIllustrationSet]) {
+				throw new Error("The illustration set '" + sIllustrationSet + "' is not registered. Please register it before requiring rest of its assets.");
+			}
+
+			aSymbols = oSetRegistry[sIllustrationSet].aSymbols;
+
+			if (Array.isArray(aSymbols)) {
+				aSymbols.forEach(function(sSymbol) {
+					IllustrationPool.loadAsset(sIllustrationSet + "-Spot-" + sSymbol);
+					IllustrationPool.loadAsset(sIllustrationSet + "-Dialog-" + sSymbol);
+					IllustrationPool.loadAsset(sIllustrationSet + "-Scene-" + sSymbol);
+				});
+			}
+		};
+
+		/**
+		 * Registers an illustration set, which is needed before loading any of its assets.
+		 *
+		 * @param {object} oConfig object containing the name and the path of the Illustration Set
+		 * @param {string} oConfig.setFamily Name of the Illustration Set
+		 * @param {string} oConfig.setURI URL Path of the Illustration Set
+		 * @param {boolean} bLoadAllResources whether or not all of the assets for the Illustration Set
+		 * should be loaded once the metadata is loaded
+		 * @static
+		 * @public
+		 */
+		IllustrationPool.registerIllustrationSet = function(oConfig, bLoadAllResources) {
+			var sName = oConfig.setFamily,
+				sPath = oConfig.setURI;
+
+			if (oSetRegistry[sName]) {
+				if (oSetRegistry[sName].bIsPending) {
+					Log.warning("Illustration Set is currently being loaded.");
+				} else {
+					Log.warning("Illustration Set already registered.");
+				}
+				return;
+			}
+
+			// add trailing slash if necessary for more convenience
+			if (sPath.substr(sPath.length - 1) !== "/") {
+				sPath += "/";
+			}
+
+			oSetRegistry[sName] = Object.create(null);
+			oSetRegistry[sName].sPath = sPath;
+			oSetRegistry[sName].bIsPending = true;
+
+			IllustrationPool._loadMetadata(sName, sPath, bLoadAllResources);
+		};
+
+		/**
+		 * PRIVATE METHODS
+		 */
+
+		/**
+		 * Adds an asset to the Illustration Pool's DOM element inner HTML.
+		 *
+		 * @param {string} sHTML string containing the raw HTML of an asset
+		 * @param {string} sId string containing the ID of an asset
+		 * @static
+		 * @private
+		 */
+		IllustrationPool._addAssetToDOMPool = function(sHTML, sId) {
+			IllustrationPool._getDOMPool().insertAdjacentHTML("beforeend", sHTML);
+			if (sId) {
+				aSymbolsInDOM.push(sId);
+			}
+		};
+
+		/**
+		 * Returns the DOM for the Illustration Pool.
+		 * It also loads the mandatory patterns for the default Illustration Set once the DOM is created.
+		 *
+		 * @return {Object} DOM reference of the Illustration Pool
+		 * @static
+		 * @private
+		 */
+		IllustrationPool._getDOMPool = function() {
+			var oDOMPool = document.getElementById(SAP_ILLUSTRATION_POOL_ID);
+
+			if (oDOMPool === null) {
+				oDOMPool = document.createElement("div");
+				oDOMPool.id = SAP_ILLUSTRATION_POOL_ID;
+
+				Core.getStaticAreaRef().appendChild(oDOMPool);
+
+				// Load the patterns for the default illustration set after the DOM Pool is created
+				IllustrationPool.loadAsset(SAP_ILLUSTRATION_SET_NAME + SAP_ILLUSTRATION_PATTERNS_NAME);
+			}
+
+			return oDOMPool;
+		};
+
+		/**
+		 * Loads the metadata of an Illustration Set.
+		 *
+		 * @param {string} sName the name of the Illustration Set for which the metadata is being loaded
+		 * @param {string} sPath the path of the Illustration Set for which the metadata is being loaded
+		 * @param {boolean} bLoadAllResources whether or not all of the assets for the Illustration Set should be loaded
+		 * @return {Promise} Promise which resolves when the metadata is loaded
+		 * @static
+		 * @private
+		 */
+		IllustrationPool._loadMetadata = function(sName, sPath, bLoadAllResources) {
+			var sMetadataPath = sPath + "metadata.json";
+
+			return new Promise(function (fnResolve) {
+				jQuery.ajax(sMetadataPath, {
+					type: "GET",
+					dataType: "json",
+					success: function (oMetadataJSON) {
+						Log.info("Metadata for illustration set (" + sName + ") successfully loaded");
+						IllustrationPool._metadataLoaded(sName, oMetadataJSON, bLoadAllResources);
+						fnResolve(oMetadataJSON); // passing the json in the resolve for testing purposes
+					},
+					error: function (jqXHR, sStatus) {
+						if (sStatus !== "abort") { // log an error if it isn't aborted
+							Log.error("Metadata from: " + sMetadataPath + " file path could not be loaded");
+							delete oSetRegistry[sName];
+							fnResolve();
+						}
+					}
+				});
+			});
+		};
+
+		/**
+		 * Hook which is triggered when the metadata for an Illustration Set is loaded.
+		 *
+		 * @param {string} sName the name of the Illustration Set for which the metadata is loaded
+		 * @param {object} oMetadataJSON the loaded metadata object
+		 * @param {boolean} bLoadAllResources whether or not all of the assets for the Illustration Set should be loaded
+		 * @static
+		 * @private
+		 */
+		IllustrationPool._metadataLoaded = function(sName, oMetadataJSON, bLoadAllResources) {
+			var aSymbols = oMetadataJSON.symbols,
+				bHasPatterns = oMetadataJSON.requireCustomPatterns;
+
+			oSetRegistry[sName].aSymbols = aSymbols;
+
+			// Load the patterns (if available) as soon as possible, since they can be used in any of the symbols.
+			if (bHasPatterns) {
+				IllustrationPool.loadAsset(sName + SAP_ILLUSTRATION_PATTERNS_NAME);
+			}
+
+			if (bLoadAllResources) {
+				IllustrationPool.loadRestOfTheAssets(sName);
+			}
+
+			oSetRegistry[sName].bIsPending = false;
+		};
+
+		/**
+		 * Removes an asset from the Illustration Pool's DOM element inner HTML.
+		 *
+		 * @param {string} sId string containing the ID of the asset which should be removed from the Illustration Pool's DOM
+		 * @static
+		 * @private
+		 */
+		IllustrationPool._removeAssetFromDOMPool = function(sId) {
+			var oDOMPool = document.getElementById(SAP_ILLUSTRATION_POOL_ID),
+				oAssetDOM;
+
+			if (oDOMPool !== null) {
+				oAssetDOM = document.getElementById(sId);
+				if (oAssetDOM !== null) {
+					oDOMPool.removeChild(oAssetDOM);
+					aSymbolsInDOM.splice(aSymbolsInDOM.indexOf(sId), 1);
+				}
+			}
+		};
+
+		/**
+		 * Loads an SVG asset.
+		 *
+		 * @param {string} sSet the name of the Illustration Set for which the asset is being loaded
+		 * @param {string} sId the ID of the asset being loaded
+		 * @param {string} sInstanceId the ID of the Illustration instance which is requiring the asset
+		 * @return {Promise} Promise which resolves when the SVG asset is loaded
+		 * @static
+		 * @private
+		 */
+		IllustrationPool._requireSVG = function(sSet, sId, sInstanceId) {
+			return new Promise(function (fnResolve) {
+				jQuery.ajax(oSetRegistry[sSet].sPath + sId + ".svg", {
+					type: "GET",
+					dataType: "html",
+					success: function (sHTML) {
+						// if asset is a symbol, and not a pattern
+						if (sId.indexOf(SAP_ILLUSTRATION_PATTERNS_NAME) === -1) {
+							// cache the loaded symbol
+							oLoadedSymbols[sId] = sHTML;
+
+							// update the DOM if the asset is required by an instance
+							if (sInstanceId) {
+								IllustrationPool._updateDOMPool();
+							}
+						} else {
+							// add the pattern immediately
+							IllustrationPool._addAssetToDOMPool(sHTML);
+						}
+
+						fnResolve(sHTML);
+					},
+					error: function (jqXHR, sStatus) {
+						if (sStatus !== "abort") { // log an error if it isn't aborted
+							delete oAssetRegistry[sId];
+							Log.error(sId + " asset could not be loaded");
+							fnResolve();
+						}
+					}
+				});
+			});
+		};
+
+		/**
+		 * Updates the IllustrationPool's DOM node. Adds the currently required assets (if they are
+		 * not already there) and removes the ones which are not needed.
+		 *
+		 * @static
+		 * @private
+		 */
+		IllustrationPool._updateDOMPool = function() {
+			var oAssetsToKeep = Object.create(null),
+				oAssetsToAdd = Object.create(null),
+				sCurrAsset,
+				iCurrIndexInDOM;
+
+			for (var sCurrInstance in oRequiredAssets) {
+				sCurrAsset = oRequiredAssets[sCurrInstance];
+				iCurrIndexInDOM = aSymbolsInDOM.indexOf(sCurrAsset);
+				// if the asset is not already in the DOM, remember its ID and add it later, if it's loaded
+				if (iCurrIndexInDOM === -1) {
+					oAssetsToAdd[sCurrAsset] = true;
+				} else {
+					// if the asset is already in the DOM, remember its ID to help remove the not needed ones later
+					oAssetsToKeep[sCurrAsset] = true;
+				}
+			}
+
+			// remove the symbols which are not used and are not required
+			for (var i = 0; i < aSymbolsInDOM.length; i++) {
+				sCurrAsset = aSymbolsInDOM[i];
+				if (!oAssetsToKeep[sCurrAsset]) {
+					IllustrationPool._removeAssetFromDOMPool(sCurrAsset);
+					i--;
+				}
+			}
+
+			for (var sId in oAssetsToAdd) {
+				sCurrAsset = oLoadedSymbols[sId];
+				// add the missing required asset to the DOM only if it's loaded
+				if (sCurrAsset) {
+					IllustrationPool._addAssetToDOMPool(sCurrAsset, sId);
+				}
+			}
+		};
+
+		return IllustrationPool;
+
+	}, /* bExport= */ true);

package/src/sap/m/IllustrationRenderer.js

@@ -0,0 +1,43 @@
+/*!
+ * OpenUI5
+ * (c) Copyright 2009-2022 SAP SE or an SAP affiliate company.
+ * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
+ */
+
+sap.ui.define(["sap/ui/Device"], function (Device) {
+	"use strict";
+
+	/**
+	 * Illustration renderer.
+	 * @namespace
+	 */
+	var IllustrationRenderer = {
+		apiVersion: 2
+	};
+
+	/**
+	 * Renders the HTML for the given control, using the provided {@link sap.ui.core.RenderManager}.
+	 *
+	 * @param {sap.ui.core.RenderManager} oRm The RenderManager that can be used for writing to the Render-Output-Buffer
+	 * @param {sap.m.Illustration} oIllustration An object representation of the control that should be rendered
+	 */
+	IllustrationRenderer.render = function (oRm, oIllustration) {
+		var sSymbolId = oIllustration._sSymbolId;
+
+		oRm.openStart("svg", oIllustration);
+		oRm.class("sapMIllustration");
+		oRm.openEnd();
+
+			oRm.openStart("use");
+			oRm.attr('href', "#" + sSymbolId);
+			oRm.attr('width', "100%");
+			oRm.attr('height', "100%");
+			oRm.openEnd();
+			oRm.close("use");
+
+		oRm.close("svg");
+	};
+
+	return IllustrationRenderer;
+
+}, /* bExport= */ true);

package/src/sap/m/Image.js

@@ -57,7 +57,7 @@ sap.ui.define([
 	 * @implements sap.ui.core.IFormContent
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.99.1
 	 *
 	 * @public
 	 * @alias sap.m.Image

package/src/sap/m/ImageContent.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.99.1
 	 * @since 1.38
 	 *
 	 * @public
@@ -158,7 +158,7 @@ sap.ui.define([
 	/**
 	 * Returns the alternative text
 	 *
-	 * @returns {String} The alternative text
+	 * @returns {string} The alternative text
 	 */
 	ImageContent.prototype.getAltText = function () {
 		var oContent = this.getAggregation("_content");

package/src/sap/m/ImageRenderer.js

@@ -29,7 +29,7 @@ sap.ui.define(['sap/m/library', "sap/base/security/encodeCSS", "sap/ui/core/libr
 	 * Renders the HTML for the given control, using the provided {@link sap.ui.core.RenderManager}.
 	 *
 	 * @param {sap.ui.core.RenderManager} oRm The RenderManager that can be used for writing to the Render-Output-Buffer
-	 * @param {sap.ui.core.Control} oImage The control that should be rendered
+	 * @param {sap.m.Image} oImage The control that should be rendered
 	 */
 	ImageRenderer.render = function(oRm, oImage) {
 		var sMode = oImage.getMode(),

package/src/sap/m/Input.js

@@ -159,7 +159,7 @@ function(
 	 *
 	 * @extends sap.m.InputBase
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.99.1
 	 *
 	 * @constructor
 	 * @public
@@ -218,7 +218,8 @@ function(
 			showSuggestion : {type : "boolean", group : "Behavior", defaultValue : false},
 
 			/**
-			 * If set to true, direct text input is disabled and the control will trigger the event "valueHelpRequest" for all user interactions. The properties "showValueHelp", "editable", and "enabled" must be set to true, otherwise the property will have no effect
+			 * If set to true, direct text input is disabled and the control will trigger the event "valueHelpRequest" for all user interactions. The properties "showValueHelp", "editable", and "enabled" must be set to true, otherwise the property will have no effect.
+			 * In this scenario, the <code>showItems</code> API will not work.
 			 * @since 1.21.0
 			 */
 			valueHelpOnly : {type : "boolean", group : "Behavior", defaultValue : false},
@@ -1207,18 +1208,29 @@ function(
 			this._fireValueHelpRequestForValueHelpOnly();
 		}
 
-		if (this.isMobileDevice()
-			 && this.getEditable()
-			 && this.getEnabled()
-			 && this.getShowSuggestion()
-			 && (!this._bClearButtonPressed)
-			 && oEvent.target.id !== this.getId() + "-vhi") {
+		if (this.shouldSuggetionsPopoverOpenOnMobile(oEvent)) {
 				this._openSuggestionsPopover();
 		}
 
 		this._bClearButtonPressed = false;
 	};
 
+	/**
+	 * A helper function calculating if the SuggestionsPopover should be opened on mobile.
+	 *
+	 * @protected
+	 * @param {jQuery.Event} oEvent Ontap event.
+	 * @returns {boolean} If the popover should be openened.
+	 */
+	Input.prototype.shouldSuggetionsPopoverOpenOnMobile = function(oEvent) {
+		return this.isMobileDevice()
+			&& this.getEditable()
+			&& this.getEnabled()
+			&& this.getShowSuggestion()
+			&& (!this._bClearButtonPressed)
+			&& oEvent.target.id !== this.getId() + "-vhi";
+	};
+
 	/**
 	 * Sets a custom filter function for suggestions. The default is to check whether the first item text begins with the typed value. For one and two-value suggestions this callback function will operate on sap.ui.core.Item types, for tabular suggestions the function will operate on sap.m.ColumnListItem types.
 	 *
@@ -1293,7 +1305,6 @@ function(
 	 * If no custom filter is set or default filtering is forced, this function will apply the default filter to the column item.
 	 *
 	 * @private
-	 * @param {sap.m.ColumnListItem} oColumnListItem The sap.m.ColumnListItem that is selected
 	 * @param {boolean} bForceDefaultFiltering Whether or not to apply the default filter even if custom one is set
 	 *
 	 * @returns {function} The row filtering function(s) to execute on the selected row item.
@@ -1883,7 +1894,7 @@ function(
 	 *
 	 * Adds the aria-desribedby text with the number of available suggestions.
 	 *
-	 * @param {Integer} iNumItems
+	 * @param {int} iNumItems
 	 * @private
 	 */
 	Input.prototype._applySuggestionAcc = function(iNumItems) {
@@ -1912,6 +1923,8 @@ function(
 
 	/**
 	 * Helper function that refreshes list all items.
+	 *
+	 * @returns {null|undefined} null or undefined
 	 */
 	Input.prototype._refreshListItems = function () {
 		var bShowSuggestion = this.getShowSuggestion(),
@@ -1938,7 +1951,7 @@ function(
 		oFilterResults = this._getFilteredSuggestionItems(sTypedChars);
 		iSuggestionsLength = oFilterResults.items.length;
 
-		if (iSuggestionsLength > 0) {
+		if (iSuggestionsLength > 0 && !this.getValueHelpOnly()) {
 			this._openSuggestionPopup(this.getValue().length >= this.getStartSuggestion());
 		} else {
 			this._hideSuggestionPopup();
@@ -2978,6 +2991,7 @@ function(
 
 	/**
 	 * Opens the <code>SuggestionsPopover</code> with the available items.
+	 * <b>Note:</b> When <code>valueHelpOnly</code> property is set to true, the <code>SuggestionsPopover</code> will not open.
 	 *
 	 * @param {function} fnFilter Function to filter the items shown in the SuggestionsPopover
 	 * @returns {void}
@@ -2991,7 +3005,7 @@ function(
 			fnFilterStore = this._getFilterFunction();
 
 		// in case of a non-editable or disabled, the popup cannot be opened
-		if (!this.getEnabled() || !this.getEditable()) {
+		if (!this.getEnabled() || !this.getEditable() || this.getValueHelpOnly()) {
 			return;
 		}
 
@@ -3120,7 +3134,7 @@ function(
 	 * Gets filtered items.
 	 * Table/List item agnostic.
 	 *
-	 * @param {String} sValue The value, to be used as a filter
+	 * @param {string} sValue The value, to be used as a filter
 	 * @returns {Object} A filtering result object, containing the matching items and list groups
 	 * @private
 	 */
@@ -3154,7 +3168,7 @@ function(
 	 *
 	 * @private
 	 * @param {Array} aTabularRows Array of table rows
-	 * @param {String} sValue The value, to be used as a filter
+	 * @param {string} sValue The value, to be used as a filter
 	 * @returns {Object} A filtering result object, containing the matching items and list groups
 	 */
 	Input.prototype.filterTabularItems = function (aTabularRows, sValue) {

package/src/sap/m/InputBase.js

@@ -64,7 +64,7 @@ function(
 	 * @implements sap.ui.core.IFormContent
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.99.1
 	 *
 	 * @constructor
 	 * @public
@@ -749,9 +749,9 @@ function(
 		return this.$("inner").getSelectedText();
 	};
 
-	/**
-	 * Overwrite setProperty function to know value property changes via API
-	 * @overwrite
+	/*
+	 * Override setProperty function to know value property changes via API
+	 * @override
 	 */
 	InputBase.prototype.setProperty = function(sPropertyName, oValue, bSuppressInvalidate) {
 		if (sPropertyName == "value") {
@@ -843,11 +843,10 @@ function(
 	};
 
 	/**
-	 * If there is <code>sap.m.FormattedText</code> aggragation for value state message
+	 * If there is <code>sap.m.FormattedText</code> aggregation for value state message
 	 * return the links in it, if any.
 	 *
-	 * @param {jQuery.Event} oEvent The event object.
-	 * @returns {array} Links in a value state message containing <code>sap.m.FormattedText</code>
+	 * @returns {sap.m.Link[]} Links in a value state message containing <code>sap.m.FormattedText</code>
 	 * @private
 	 */
 	InputBase.prototype._aValueStateLinks = function() {
@@ -875,7 +874,6 @@ function(
 	 * If ValueStateText is sap.m.FormattedText containing
 	 * link(s) - close ValueStateMessage after press on <code>sap.m.Link</code>
 	 *
-	 * @param {jQuery.Event} oEvent The event object.
 	 * @private
 	 */
 	InputBase.prototype._attachValueStateLinkPress = function() {