@mycadet/assistant 0.12.9 → 0.12.11

package/src/onboarding/__tests__/onboarding-events-store.test.ts

@@ -1,158 +0,0 @@
-import { beforeEach, describe, expect, test } from "bun:test";
-
-import { getTelemetrySqlite } from "../../persistence/db-connection.js";
-import {
-  pendingOutboxPayloads,
-  resetOutboxTable,
-  setShareAnalytics,
-  withTelemetryDbUnavailable,
-} from "../../telemetry/__tests__/outbox-test-harness.js";
-import { ACTIVATION_FUNNEL_VERSION } from "../../telemetry/activation-funnel.js";
-import type { OnboardingTelemetryEvent } from "../../telemetry/types.js";
-import { APP_VERSION } from "../../version.js";
-import {
-  recordActivationEvent,
-  recordOnboardingEvent,
-} from "../onboarding-events-store.js";
-
-/** Pending onboarding outbox payloads, parsed, in `(created_at, id)` order. */
-function pendingOnboardingPayloads(): OnboardingTelemetryEvent[] {
-  return pendingOutboxPayloads<OnboardingTelemetryEvent>("onboarding", 10);
-}
-
-describe("onboarding-events-store: recordActivationEvent", () => {
-  beforeEach(() => {
-    setShareAnalytics(true);
-    resetOutboxTable();
-  });
-
-  test("stores the full wire payload with the deterministic activation daemon_event_id", () => {
-    const event = recordActivationEvent({
-      stepName: "activation_moment_1_complete",
-      sessionId: "conv-1",
-    });
-    expect(event).not.toBeNull();
-
-    const payloads = pendingOnboardingPayloads();
-    expect(payloads).toHaveLength(1);
-    expect(payloads[0]).toEqual({
-      type: "onboarding",
-      daemon_event_id: `${ACTIVATION_FUNNEL_VERSION}:conv-1:activation_moment_1_complete`,
-      recorded_at: event!.createdAt,
-      screen: "activation_moment_1_complete",
-      ab_variant: "variant-a",
-      session_id: "conv-1",
-      step_name: "activation_moment_1_complete",
-      step_index: 1,
-      completed_at: new Date(event!.createdAt).toISOString(),
-      funnel_version: ACTIVATION_FUNNEL_VERSION,
-      assistant_version: APP_VERSION,
-    });
-  });
-
-  test("outbox row id stays a UUID distinct from the payload daemon_event_id", () => {
-    const event = recordActivationEvent({
-      stepName: "activation_moment_1_complete",
-      sessionId: "conv-telemetry",
-    });
-    expect(event).not.toBeNull();
-
-    const raw = getTelemetrySqlite()!
-      .query(`SELECT id, name FROM telemetry_events`)
-      .all() as Array<{ id: string; name: string }>;
-    expect(raw).toEqual([{ id: event!.id, name: "onboarding" }]);
-    const payload = pendingOnboardingPayloads()[0]!;
-    expect(payload.daemon_event_id).not.toBe(event!.id);
-  });
-
-  test("honors an explicit abVariant override", () => {
-    recordActivationEvent({
-      stepName: "activation_moment_2_complete",
-      sessionId: "conv-2",
-      abVariant: "variant-b",
-    });
-
-    const payloads = pendingOnboardingPayloads();
-    expect(payloads).toHaveLength(1);
-    expect(payloads[0]!.ab_variant).toBe("variant-b");
-    expect(payloads[0]!.step_index).toBe(2);
-  });
-
-  test("returns null and writes no row when share_analytics is disabled", () => {
-    setShareAnalytics(false);
-    const event = recordActivationEvent({
-      stepName: "activation_moment_1_complete",
-      sessionId: "conv-3",
-    });
-    expect(event).toBeNull();
-
-    expect(pendingOnboardingPayloads()).toHaveLength(0);
-  });
-
-  test("returns null when the telemetry database is unavailable", () => {
-    withTelemetryDbUnavailable(() => {
-      const event = recordActivationEvent({
-        stepName: "activation_moment_1_complete",
-        sessionId: "conv-4",
-      });
-      expect(event).toBeNull();
-    });
-
-    expect(pendingOnboardingPayloads()).toHaveLength(0);
-  });
-});
-
-describe("onboarding-events-store: recordOnboardingEvent", () => {
-  beforeEach(() => {
-    setShareAnalytics(true);
-    resetOutboxTable();
-  });
-
-  test("stores a pre-chat wire payload with daemon_event_id = row id and no funnel fields", () => {
-    const event = recordOnboardingEvent({
-      screen: "tools",
-      tools: ["gmail", "calendar"],
-      tone: "warm",
-      googleConnected: true,
-    });
-    expect(event).not.toBeNull();
-
-    const payloads = pendingOnboardingPayloads();
-    expect(payloads).toHaveLength(1);
-    expect(payloads[0]).toEqual({
-      type: "onboarding",
-      daemon_event_id: event!.id,
-      recorded_at: event!.createdAt,
-      screen: "tools",
-      tools: ["gmail", "calendar"],
-      tone: "warm",
-      google_connected: true,
-      assistant_version: APP_VERSION,
-    });
-
-    const raw = getTelemetrySqlite()!
-      .query(`SELECT id, name, conversation_id FROM telemetry_events`)
-      .all() as Array<{
-      id: string;
-      name: string;
-      conversation_id: string | null;
-    }>;
-    expect(raw).toEqual([
-      { id: event!.id, name: "onboarding", conversation_id: null },
-    ]);
-  });
-
-  test("returns null and writes no row when share_analytics is disabled", () => {
-    setShareAnalytics(false);
-    expect(recordOnboardingEvent({ screen: "tools" })).toBeNull();
-    expect(pendingOnboardingPayloads()).toHaveLength(0);
-  });
-
-  test("returns null when the telemetry database is unavailable", () => {
-    withTelemetryDbUnavailable(() => {
-      expect(recordOnboardingEvent({ screen: "tools" })).toBeNull();
-    });
-
-    expect(pendingOnboardingPayloads()).toHaveLength(0);
-  });
-});

package/src/onboarding/onboarding-events-store.ts

@@ -1,296 +0,0 @@
-import {
-  ACTIVATION_AB_VARIANT,
-  ACTIVATION_FUNNEL_VERSION,
-  activationStepIndex,
-  type ActivationStepName,
-  buildActivationDaemonEventId,
-} from "../telemetry/activation-funnel.js";
-import {
-  LIVE_VOICE_FUNNEL_VERSION,
-  LIVE_VOICE_STEPS,
-  type LiveVoiceSessionOutcome,
-  type LiveVoiceStepName,
-} from "../telemetry/live-voice-funnel.js";
-import {
-  PHONE_CALL_FUNNEL_VERSION,
-  PHONE_CALL_STEPS,
-  type PhoneCallOutcome,
-  type PhoneCallStepName,
-} from "../telemetry/phone-call-funnel.js";
-import { recordTelemetryOutboxEvent } from "../telemetry/telemetry-events-outbox.js";
-import type { OnboardingTelemetryEvent } from "../telemetry/types.js";
-import { getLogger } from "../util/logger.js";
-import { APP_VERSION } from "../version.js";
-
-const log = getLogger("onboarding-events-store");
-
-/** Identity of a recorded outbox row; the full payload lives in the outbox. */
-export interface OnboardingEvent {
-  id: string;
-  createdAt: number;
-}
-
-export interface RecordOnboardingEventParams {
-  screen: string;
-  tools?: string[];
-  tasks?: string[];
-  tone?: string;
-  googleConnected?: boolean;
-  googleScopes?: string[];
-  abVariant?: string;
-  sessionId?: string | null;
-  stepName?: string | null;
-  stepIndex?: number | null;
-  completedAt?: string | null;
-  funnelVersion?: string | null;
-  outcome?: string | null;
-}
-
-/**
- * Build the wire event stored in the outbox payload at record time.
- * `assistant_version` is therefore record-time: the binary that recorded the
- * event, not the one that later flushes it.
- */
-function buildOnboardingTelemetryEvent(
-  id: string,
-  createdAt: number,
-  params: RecordOnboardingEventParams,
-): OnboardingTelemetryEvent {
-  return {
-    type: "onboarding",
-    // Wire-only override for activation rows: a deterministic id keyed on
-    // funnel_version/session/step lets dbt collapse a moment that fires more
-    // than once. Keyed on the params' funnelVersion (frozen into the payload
-    // now) so rows recorded under an older version — flushed offline or after
-    // an upgrade — keep a stable id and still collapse with already-ingested
-    // rows. The outbox row id stays `id`, so flush acks are unaffected.
-    daemon_event_id:
-      params.sessionId && params.stepName && params.funnelVersion
-        ? buildActivationDaemonEventId(
-            params.sessionId,
-            params.stepName,
-            params.funnelVersion,
-          )
-        : id,
-    recorded_at: createdAt,
-    screen: params.screen,
-    ...(params.tools ? { tools: params.tools } : {}),
-    ...(params.tasks ? { tasks: params.tasks } : {}),
-    ...(params.tone ? { tone: params.tone } : {}),
-    ...(params.googleConnected != null
-      ? { google_connected: params.googleConnected }
-      : {}),
-    ...(params.googleScopes ? { google_scopes: params.googleScopes } : {}),
-    ...(params.abVariant ? { ab_variant: params.abVariant } : {}),
-    // Activation funnel fields — only present on activation rows.
-    ...(params.sessionId ? { session_id: params.sessionId } : {}),
-    ...(params.stepName ? { step_name: params.stepName } : {}),
-    ...(params.stepIndex != null ? { step_index: params.stepIndex } : {}),
-    ...(params.completedAt ? { completed_at: params.completedAt } : {}),
-    ...(params.funnelVersion ? { funnel_version: params.funnelVersion } : {}),
-    ...(params.outcome ? { outcome: params.outcome } : {}),
-    assistant_version: APP_VERSION,
-  };
-}
-
-/**
- * Record an onboarding event (pre-chat selections and Google connect status).
- * Returns null when usage data collection is disabled or the telemetry
- * database is unavailable.
- */
-export function recordOnboardingEvent(
-  params: RecordOnboardingEventParams,
-): OnboardingEvent | null {
-  return recordTelemetryOutboxEvent("onboarding", (id, createdAt) =>
-    buildOnboardingTelemetryEvent(id, createdAt, params),
-  );
-}
-
-/**
- * Record an activation-funnel milestone event. Reuses the onboarding telemetry
- * substrate (`screen` carries the step name). Returns null when usage data
- * collection is disabled or the telemetry database is unavailable.
- */
-export function recordActivationEvent(params: {
-  stepName: ActivationStepName;
-  sessionId: string;
-  abVariant?: string;
-}): OnboardingEvent | null {
-  return recordTelemetryOutboxEvent("onboarding", (id, createdAt) =>
-    buildOnboardingTelemetryEvent(id, createdAt, {
-      screen: params.stepName,
-      abVariant: params.abVariant ?? ACTIVATION_AB_VARIANT,
-      sessionId: params.sessionId,
-      stepName: params.stepName,
-      stepIndex: activationStepIndex(params.stepName),
-      completedAt: new Date(createdAt).toISOString(),
-      funnelVersion: ACTIVATION_FUNNEL_VERSION,
-    }),
-  );
-}
-
-/**
- * Record a live-voice session milestone (started / ended). Reuses the same
- * onboarding telemetry substrate as {@link recordActivationEvent}, keyed by the
- * live-voice session id so the two events pair up downstream. See
- * `telemetry/live-voice-funnel.ts` for why duration and turn count are derived
- * from that pairing rather than carried as fields.
- *
- * `screen` carries the end reason on the ended event and the originating
- * client and entry point on the started one (see `liveVoiceStartScreen`).
- * Returns null when usage data collection is disabled or the telemetry
- * database is unavailable.
- *
- * **Never throws.** These fire from `LiveVoiceSession.start()` and `.close()`,
- * and from the call store's create and status writes, which are the user's
- * call itself: the outbox insert raises on a telemetry DB that is missing,
- * locked, or mid-migration, and an uncaught raise there would fail the session
- * rather than the measurement. A dropped row costs a gap in a chart; a raised
- * one costs the user their conversation.
- */
-function recordVoiceFunnelEventSafely(
-  record: () => OnboardingEvent | null,
-): OnboardingEvent | null {
-  try {
-    return record();
-  } catch (err) {
-    log.warn(
-      { err },
-      "Failed to record live-voice session telemetry; continuing",
-    );
-    return null;
-  }
-}
-
-/**
- * Build one voice funnel row. The live-voice and phone-call funnels differ
- * only in their version stamp and step vocabulary, so they share the row
- * shape: same substrate, same session-keyed pairing, same duration math.
- */
-function recordVoiceFunnelEvent(params: {
-  funnelVersion: string;
-  stepName: string;
-  stepIndex: number;
-  sessionId: string;
-  screen: string;
-  outcome?: string;
-}): OnboardingEvent | null {
-  return recordVoiceFunnelEventSafely(() =>
-    recordTelemetryOutboxEvent("onboarding", (id, createdAt) =>
-      buildOnboardingTelemetryEvent(id, createdAt, {
-        screen: params.screen,
-        sessionId: params.sessionId,
-        stepName: params.stepName,
-        stepIndex: params.stepIndex,
-        completedAt: new Date(createdAt).toISOString(),
-        funnelVersion: params.funnelVersion,
-        ...(params.outcome ? { outcome: params.outcome } : {}),
-      }),
-    ),
-  );
-}
-
-export function recordLiveVoiceSessionEvent(params: {
-  stepName: LiveVoiceStepName;
-  stepIndex: number;
-  sessionId: string;
-  screen?: string;
-  outcome?: LiveVoiceSessionOutcome;
-}): OnboardingEvent | null {
-  return recordVoiceFunnelEvent({
-    funnelVersion: LIVE_VOICE_FUNNEL_VERSION,
-    stepName: params.stepName,
-    stepIndex: params.stepIndex,
-    sessionId: params.sessionId,
-    screen: params.screen ?? params.stepName,
-    ...(params.outcome ? { outcome: params.outcome } : {}),
-  });
-}
-
-/**
- * Record the "a live-voice session was attempted" milestone, with where it
- * was attempted from.
- */
-export function recordLiveVoiceSessionStarted(params: {
-  sessionId: string;
-  screen: string;
-}): OnboardingEvent | null {
-  return recordLiveVoiceSessionEvent({
-    stepName: LIVE_VOICE_STEPS.sessionStarted.stepName,
-    stepIndex: LIVE_VOICE_STEPS.sessionStarted.stepIndex,
-    sessionId: params.sessionId,
-    screen: params.screen,
-  });
-}
-
-/** Record the "a live-voice session ended" milestone, with how it ended. */
-export function recordLiveVoiceSessionEnded(params: {
-  sessionId: string;
-  screen: string;
-  outcome: LiveVoiceSessionOutcome;
-}): OnboardingEvent | null {
-  return recordLiveVoiceSessionEvent({
-    stepName: LIVE_VOICE_STEPS.sessionEnded.stepName,
-    stepIndex: LIVE_VOICE_STEPS.sessionEnded.stepIndex,
-    sessionId: params.sessionId,
-    screen: params.screen,
-    outcome: params.outcome,
-  });
-}
-
-/**
- * Record a phone-call milestone (started / ended) on the same substrate as the
- * live-voice pair, keyed by the call session id so the two events pair up
- * downstream. See `telemetry/phone-call-funnel.ts` for why duration and turn
- * count are derived from that pairing rather than carried as fields.
- *
- * Returns null when usage data collection is disabled or the telemetry
- * database is unavailable, and never throws: these fire from the call store's
- * writes, on the call's own path.
- */
-function recordPhoneCallEvent(params: {
-  stepName: PhoneCallStepName;
-  stepIndex: number;
-  callSessionId: string;
-  screen: string;
-  outcome?: PhoneCallOutcome;
-}): OnboardingEvent | null {
-  return recordVoiceFunnelEvent({
-    funnelVersion: PHONE_CALL_FUNNEL_VERSION,
-    stepName: params.stepName,
-    stepIndex: params.stepIndex,
-    sessionId: params.callSessionId,
-    screen: params.screen,
-    ...(params.outcome ? { outcome: params.outcome } : {}),
-  });
-}
-
-/**
- * Record the "a phone call was attempted" milestone, with how it was placed.
- */
-export function recordPhoneCallStarted(params: {
-  callSessionId: string;
-  screen: string;
-}): OnboardingEvent | null {
-  return recordPhoneCallEvent({
-    stepName: PHONE_CALL_STEPS.callStarted.stepName,
-    stepIndex: PHONE_CALL_STEPS.callStarted.stepIndex,
-    callSessionId: params.callSessionId,
-    screen: params.screen,
-  });
-}
-
-/** Record the "a phone call ended" milestone, with how it ended. */
-export function recordPhoneCallEnded(params: {
-  callSessionId: string;
-  screen: string;
-  outcome: PhoneCallOutcome;
-}): OnboardingEvent | null {
-  return recordPhoneCallEvent({
-    stepName: PHONE_CALL_STEPS.callEnded.stepName,
-    stepIndex: PHONE_CALL_STEPS.callEnded.stepIndex,
-    callSessionId: params.callSessionId,
-    screen: params.screen,
-    outcome: params.outcome,
-  });
-}

package/src/persistence/__tests__/raw-query-telemetry.test.ts

@@ -1,76 +0,0 @@
-/**
- * Tests for {@link rawTelemetryRun} — the raw-write helper for the dedicated
- * telemetry connection (`assistant-telemetry.db`), mirroring
- * `rawMemoryRun`/`rawLogsRun`. Writes must land on the telemetry connection,
- * not the main DB, and return the changed-row count.
- */
-
-import { describe, expect, test } from "bun:test";
-
-import { getSqlite, getTelemetrySqlite } from "../db-connection.js";
-import { initializeDb } from "../db-init.js";
-import { rawTelemetryRun } from "../raw-query.js";
-
-await initializeDb();
-
-const telemetry = getTelemetrySqlite();
-if (!telemetry) {
-  throw new Error("telemetry database unavailable in test");
-}
-
-telemetry.exec(/*sql*/ `
-  CREATE TABLE IF NOT EXISTS raw_telemetry_run_test (
-    id TEXT PRIMARY KEY,
-    value INTEGER NOT NULL
-  )
-`);
-
-describe("rawTelemetryRun", () => {
-  test("inserts on the telemetry connection and returns the changed-row count", () => {
-    const changes = rawTelemetryRun(
-      "test:insert",
-      "INSERT INTO raw_telemetry_run_test (id, value) VALUES (?, ?)",
-      "row-1",
-      42,
-    );
-    expect(changes).toBe(1);
-
-    // The row is visible through the telemetry connection…
-    const row = telemetry
-      .query("SELECT id, value FROM raw_telemetry_run_test WHERE id = ?")
-      .get("row-1");
-    expect(row).toEqual({ id: "row-1", value: 42 });
-
-    // …and the table does not exist on the main connection at all.
-    const onMain = getSqlite()
-      .query("SELECT name FROM sqlite_master WHERE type = 'table' AND name = ?")
-      .get("raw_telemetry_run_test");
-    expect(onMain).toBeNull();
-  });
-
-  test("delete returns the changed-row count", () => {
-    rawTelemetryRun(
-      "test:insert",
-      "INSERT INTO raw_telemetry_run_test (id, value) VALUES (?, ?), (?, ?)",
-      "row-2",
-      1,
-      "row-3",
-      2,
-    );
-
-    const deleted = rawTelemetryRun(
-      "test:delete",
-      "DELETE FROM raw_telemetry_run_test WHERE id IN (?, ?)",
-      "row-2",
-      "row-3",
-    );
-    expect(deleted).toBe(2);
-
-    const noMatch = rawTelemetryRun(
-      "test:delete",
-      "DELETE FROM raw_telemetry_run_test WHERE id = ?",
-      "missing",
-    );
-    expect(noMatch).toBe(0);
-  });
-});

package/src/persistence/lifecycle-events-store.test.ts

@@ -1,134 +0,0 @@
-import { beforeEach, describe, expect, test } from "bun:test";
-
-import {
-  resetOutboxTable,
-  setShareAnalytics,
-  withTelemetryDbUnavailable,
-} from "../telemetry/__tests__/outbox-test-harness.js";
-import { APP_VERSION } from "../version.js";
-import { getTelemetrySqlite } from "./db-connection.js";
-import {
-  buildLifecycleTelemetryEvent,
-  recordLifecycleEvent,
-} from "./lifecycle-events-store.js";
-
-interface RawOutboxRow {
-  id: string;
-  name: string;
-  created_at: number;
-  conversation_id: string | null;
-  payload: string;
-}
-
-function outboxRows(): RawOutboxRow[] {
-  return getTelemetrySqlite()!
-    .query(
-      `SELECT id, name, created_at, conversation_id, payload
-       FROM telemetry_events ORDER BY created_at, id`,
-    )
-    .all() as RawOutboxRow[];
-}
-
-describe("lifecycle-events-store", () => {
-  beforeEach(() => {
-    setShareAnalytics(true);
-    resetOutboxTable();
-  });
-
-  test("record writes a telemetry_events outbox row carrying the wire payload", () => {
-    const event = recordLifecycleEvent("app_open");
-    expect(event).not.toBeNull();
-    expect(event!.eventName).toBe("app_open");
-    expect(event!.createdAt).toBeGreaterThan(0);
-
-    const rows = outboxRows();
-    expect(rows).toHaveLength(1);
-    expect(rows[0]).toMatchObject({
-      id: event!.id,
-      name: "lifecycle",
-      created_at: event!.createdAt,
-      conversation_id: null,
-    });
-    expect(JSON.parse(rows[0]!.payload)).toEqual({
-      type: "lifecycle",
-      daemon_event_id: event!.id,
-      event_name: "app_open",
-      recorded_at: event!.createdAt,
-      assistant_version: APP_VERSION,
-    });
-  });
-
-  test("carries the optional attributes onto the wire payload", () => {
-    const event = recordLifecycleEvent("permission_prompt:bash", {
-      toolName: "bash",
-      riskLevel: "high",
-      riskThreshold: "low",
-      surface: "slack",
-      conversationId: "conv-xyz",
-    });
-    expect(event).not.toBeNull();
-
-    const rows = outboxRows();
-    expect(rows).toHaveLength(1);
-    // The conversation is stamped on the row too, so deleting the conversation
-    // deletes the pending event with it.
-    expect(rows[0]!.conversation_id).toBe("conv-xyz");
-    expect(JSON.parse(rows[0]!.payload)).toEqual({
-      type: "lifecycle",
-      daemon_event_id: event!.id,
-      event_name: "permission_prompt:bash",
-      recorded_at: event!.createdAt,
-      assistant_version: APP_VERSION,
-      tool_name: "bash",
-      risk_level: "high",
-      risk_threshold: "low",
-      surface: "slack",
-      conversation_id: "conv-xyz",
-    });
-  });
-
-  test("omits attributes that are unset or empty", () => {
-    // The wire schema requires at least one character, and one failing field
-    // makes the server drop the whole event.
-    const event = recordLifecycleEvent("permission_prompt:bash", {
-      toolName: "bash",
-      riskLevel: "high",
-      surface: "",
-    });
-
-    expect(JSON.parse(outboxRows()[0]!.payload)).toEqual({
-      type: "lifecycle",
-      daemon_event_id: event!.id,
-      event_name: "permission_prompt:bash",
-      recorded_at: event!.createdAt,
-      assistant_version: APP_VERSION,
-      tool_name: "bash",
-      risk_level: "high",
-    });
-    expect(outboxRows()[0]!.conversation_id).toBeNull();
-  });
-
-  test("buildLifecycleTelemetryEvent stamps the record-time binary version", () => {
-    expect(buildLifecycleTelemetryEvent("id-1", "hatch", 1234)).toEqual({
-      type: "lifecycle",
-      daemon_event_id: "id-1",
-      event_name: "hatch",
-      recorded_at: 1234,
-      assistant_version: APP_VERSION,
-    });
-  });
-
-  test("returns null and writes no row when share_analytics is disabled", () => {
-    setShareAnalytics(false);
-    expect(recordLifecycleEvent("app_open")).toBeNull();
-    expect(outboxRows()).toHaveLength(0);
-  });
-
-  test("degrades when the telemetry database is unavailable", () => {
-    withTelemetryDbUnavailable(() => {
-      expect(recordLifecycleEvent("app_open")).toBeNull();
-    });
-
-    expect(outboxRows()).toHaveLength(0);
-  });
-});