@mycadet/assistant 0.12.9 → 0.12.11

package/src/plugins/defaults/memory/memory-retrospective-skill-card.ts

@@ -56,15 +56,11 @@ import {
   upsertSkillCardInsertJob,
 } from "../../../persistence/jobs-store.js";
 import { publishConversationMessagesChanged } from "../../../runtime/sync/resource-sync-events.js";
-import { recordWatchdogEvent } from "../../../telemetry/watchdog-events-store.js";
 import { getLogger } from "./logging.js";
 import { SKILL_CARD_MESSAGE_KIND } from "./memory-retrospective-constants.js";
 
 const log = getLogger("memory-retrospective-skill-card");
 
-/** Watchdog check_name for the per-card delivery counter. */
-const SKILL_CARD_DELIVERED_CHECK_NAME = "skill_card_delivered";
-
 /**
  * A skill authored by a retrospective run, as recorded by the scaffold
  * executor at creation time. All values are the executor's post-normalization
@@ -351,20 +347,6 @@ async function insertOrDeferSkillCard(
     );
   }
   publishConversationMessagesChanged(sourceConversationId);
-  // Central delivery counter (admin analytics groups on the watchdog
-  // check_name): one event per delivered card, value = skills on it. The
-  // dedup early-return above keeps retried deliveries from double-counting.
-  // Never throws — the card is already inserted.
-  try {
-    recordWatchdogEvent({
-      checkName: SKILL_CARD_DELIVERED_CHECK_NAME,
-      value: skills.length,
-      detail: { skill_count: skills.length },
-    });
-  } catch {
-    // recordWatchdogEvent already no-ops on opt-out and a missing telemetry
-    // DB; anything past that is not worth surfacing here.
-  }
   log.info(
     {
       sourceConversationId,

package/src/plugins/defaults/memory/package.json

@@ -9,6 +9,6 @@
     "node": ">=20.12.0"
   },
   "peerDependencies": {
-    "@mycadet/plugin-api": "^0.8.0"
+    "@mycadet/plugin-api": "^0.12.7"
   }
 }

package/src/plugins/defaults/memory/paths.ts

@@ -1,7 +1,7 @@
 /**
  * The memory plugin's single host-path channel. Every module in this plugin
  * resolves filesystem locations here rather than importing host
- * `util/platform` directly, so the host import below is the plugin's sole
+ * `util/layout` directly, so the host import below is the plugin's sole
  * path escape (tracked by `plugin-import-boundary-guard.test.ts`), mirroring
  * `logging.ts`.
  *
@@ -12,13 +12,13 @@
  * a paths facet on the contract, or `InitContext`-provided roots — a
  * one-file change. `getMemoryWorkerPidPath` is the PID-file coordination
  * point shared between the memory worker process entry (`worker.ts`) and its
- * control module (`worker-control.ts`), so it lives in host `util/platform`
+ * control module (`worker-control.ts`), so it lives in host `util/layout`
  * where both — and any out-of-process consumer — resolve the same path.
  */
-// A namespace import (not named imports) so tests that mock `util/platform`
+// A namespace import (not named imports) so tests that mock `util/layout`
 // with a subset of its exports don't fail this module's import link — each
 // forward resolves its function at call time.
-import * as hostPlatform from "../../../util/platform.js";
+import * as hostPlatform from "../../../util/layout.js";
 
 export function getWorkspaceDir(): string {
   return hostPlatform.getWorkspaceDir();

package/src/plugins/defaults/memory/src/__tests__/memory-worker-routes.test.ts

@@ -11,7 +11,7 @@
 
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
-import { getMemoryWorkerPidPath } from "../../../../../util/platform.js";
+import { getMemoryWorkerPidPath } from "../../../../../util/layout.js";
 
 class FakeSpawnError extends Error {}
 

package/src/plugins/defaults/memory/src/memory-v2-routes.ts

@@ -8,7 +8,7 @@ import { join } from "node:path";
 import { z } from "zod";
 
 import { getUserSelectableProfilesForProvider } from "../../../../config/default-profile-catalog.js";
-import { loadConfig } from "../../../../config/loader.js";
+import { getConfig } from "../../../../config/loader.js";
 import { usesConceptPageMemory } from "../../../../config/memory-v3-gate.js";
 import type { AssistantConfig } from "../../../../config/types.js";
 import { getDb } from "../../../../persistence/db-connection.js";
@@ -63,7 +63,7 @@ export const MEMORY_V2_DISABLED_CODE = "MEMORY_V2_DISABLED";
  * config" empty state.
  */
 function requireMemoryV2Enabled(): void {
-  if (!usesConceptPageMemory(loadConfig().memory)) {
+  if (!usesConceptPageMemory(getConfig().memory)) {
     throw new RouteError(
       "Concept-page memory is not active — enable memory.v3.live (or memory.v2.enabled) to use this command.",
       MEMORY_V2_DISABLED_CODE,
@@ -135,7 +135,7 @@ async function handleValidate({
 
   const workspaceDir = getWorkspaceDir();
   const maxPageChars = resolveSubstrateTuning(
-    loadConfig().memory,
+    getConfig().memory,
   ).max_page_chars;
 
   const slugs = await listPages(workspaceDir);
@@ -514,7 +514,7 @@ export async function handleSimulateRouter({
       ? rawRouterPromptOverride
       : undefined;
 
-  const liveConfig = loadConfig();
+  const liveConfig = getConfig();
   const mergedConfig = applySimulateOverrides(liveConfig, configOverrides);
   const effectiveRouter = mergedConfig.memory.v2.router;
 
@@ -663,7 +663,7 @@ export async function handleCompareRetrievers({
   const { limit, strategy, conversationIds, ks, includeNotInjected } =
     MemoryV2CompareRetrieversParams.parse(body);
 
-  const config = loadConfig();
+  const config = getConfig();
   const workspaceDir = getWorkspaceDir();
   const pageIndex = await getPageIndex(workspaceDir);
   const db = getDb();

package/src/plugins/defaults/memory/src/memory-v3-routes.ts

@@ -19,7 +19,6 @@ import { z } from "zod";
 
 import { getConfig } from "../../../../config/loader.js";
 import type { AssistantConfig } from "../../../../config/types.js";
-import { getTelemetrySqlite } from "../../../../persistence/db-connection.js";
 import {
   ACTOR_PRINCIPALS,
   type RoutePolicy,
@@ -27,7 +26,6 @@ import {
 import type { RouteDefinition } from "../../../../runtime/routes/types.js";
 import { getLogger } from "../logging.js";
 import { backfillAllSections } from "../v3/maintain-job.js";
-import { MEMORY_V3_INJECTION_GATE_CHECK_NAME } from "../v3/orchestrate.js";
 import { invalidateLanes } from "../v3/shadow-plugin.js";
 
 const log = getLogger("memory-v3-routes");
@@ -103,211 +101,6 @@ const WRITE_POLICY: RoutePolicy = {
   allowedPrincipalTypes: ACTOR_PRINCIPALS,
 };
 
-// ---------------------------------------------------------------------------
-// gate-stats
-// ---------------------------------------------------------------------------
-
-const DEFAULT_LOOKBACK_DAYS = 30;
-const MAX_LOOKBACK_DAYS = 90;
-const MS_PER_DAY = 24 * 60 * 60 * 1000;
-
-/** Corpus size buckets for gate-stats aggregation (in concept pages). */
-const CORPUS_BUCKETS = [
-  { label: "0–9", min: 0, max: 9 },
-  { label: "10–49", min: 10, max: 49 },
-  { label: "50–199", min: 50, max: 199 },
-  { label: "200+", min: 200, max: Infinity },
-] as const;
-
-type BucketLabel = (typeof CORPUS_BUCKETS)[number]["label"];
-
-interface BucketAcc {
-  total: number;
-  scored: number;
-  passed: number;
-  /** Passes that came from scored runs — the numerator for scoredPassRate. */
-  scoredPassed: number;
-  reasons: Record<string, number>;
-}
-
-function corpusBucketLabel(pageCount: number): BucketLabel {
-  for (const b of CORPUS_BUCKETS) {
-    if (pageCount <= b.max) {
-      return b.label;
-    }
-  }
-  return "200+";
-}
-
-interface GatePayloadDetail {
-  pass?: boolean;
-  reason?: string;
-  scored?: boolean;
-  real_concept_page_count?: number;
-}
-
-const GateStatsBucketSchema = z.object({
-  pageCountRange: z
-    .string()
-    .describe("Concept page count range (e.g. '10–49')"),
-  total: z
-    .number()
-    .describe("All gate runs in this bucket (scored + pass-open)"),
-  scored: z
-    .number()
-    .describe("Runs that weighed scores (dense lane available)"),
-  passed: z.number().describe("Runs that passed the gate"),
-  scoredPassRate: z
-    .number()
-    .nullable()
-    .describe(
-      "scoredPasses / scored (contested decisions only); null when no scored runs in bucket",
-    ),
-  reasons: z
-    .record(z.string(), z.number())
-    .describe("Gate reason code → run count (dense_pass, fail_no_signal, …)"),
-});
-
-export const GateStatsResponseSchema = z.object({
-  lookbackDays: z.number().describe("Lookback window applied"),
-  totalRuns: z.number().describe("Total gate runs found in the window"),
-  buckets: z
-    .array(GateStatsBucketSchema)
-    .describe("Stats by concept page count range, lean→large"),
-  unknownPageCount: z
-    .object({
-      total: z.number(),
-      passed: z.number(),
-      reasons: z.record(z.string(), z.number()),
-    })
-    .describe("Runs with no real_concept_page_count in telemetry detail"),
-});
-
-export type GateStatsResponse = z.infer<typeof GateStatsResponseSchema>;
-
-/**
- * Aggregate memory v3 injection gate runs from the telemetry outbox for the
- * given lookback window. Groups runs by concept page count bucket and computes
- * pass rates and reason distributions per bucket.
- *
- * Pass-open shortcuts (dense disabled/unavailable, gate threw) are included in
- * `total` but not in `scored`, so `scoredPassRate` reflects only contested gate
- * decisions — the signal that actually reveals whether the gate thresholds are
- * calibrated correctly.
- */
-export function handleMemoryV3GateStats(
-  lookbackDays: number = DEFAULT_LOOKBACK_DAYS,
-  db: ReturnType<typeof getTelemetrySqlite> = getTelemetrySqlite(),
-): GateStatsResponse {
-  const days = Math.min(
-    Math.max(1, Math.floor(lookbackDays)),
-    MAX_LOOKBACK_DAYS,
-  );
-  const since = Date.now() - days * MS_PER_DAY;
-
-  const emptyBuckets = (): GateStatsResponse["buckets"] =>
-    CORPUS_BUCKETS.map((b) => ({
-      pageCountRange: b.label,
-      total: 0,
-      scored: 0,
-      passed: 0,
-      scoredPassRate: null,
-      reasons: {},
-    }));
-  if (!db) {
-    return {
-      lookbackDays: days,
-      totalRuns: 0,
-      buckets: emptyBuckets(),
-      unknownPageCount: { total: 0, passed: 0, reasons: {} },
-    };
-  }
-
-  const rows = db
-    .query(
-      /*sql*/ `
-      SELECT payload FROM telemetry_events
-      WHERE name = 'watchdog'
-        AND created_at >= ?
-        AND json_extract(payload, '$.check_name') = ?
-    `,
-    )
-    .all(since, MEMORY_V3_INJECTION_GATE_CHECK_NAME) as Array<{
-    payload: string;
-  }>;
-
-  const bucketMap = new Map<BucketLabel, BucketAcc>(
-    CORPUS_BUCKETS.map((b) => [
-      b.label,
-      { total: 0, scored: 0, passed: 0, scoredPassed: 0, reasons: {} },
-    ]),
-  );
-  const unknown: BucketAcc = {
-    total: 0,
-    scored: 0,
-    passed: 0,
-    scoredPassed: 0,
-    reasons: {},
-  };
-
-  for (const row of rows) {
-    let detail: GatePayloadDetail;
-    try {
-      const parsed = JSON.parse(row.payload) as { detail?: GatePayloadDetail };
-      detail = parsed.detail ?? {};
-    } catch {
-      continue;
-    }
-
-    const pageCount =
-      typeof detail.real_concept_page_count === "number"
-        ? detail.real_concept_page_count
-        : null;
-
-    const acc =
-      pageCount !== null
-        ? (bucketMap.get(corpusBucketLabel(pageCount)) ?? unknown)
-        : unknown;
-
-    acc.total += 1;
-    if (detail.scored === true) {
-      acc.scored += 1;
-      if (detail.pass === true) {
-        acc.scoredPassed += 1;
-      }
-    }
-    if (detail.pass === true) {
-      acc.passed += 1;
-    }
-    const reason =
-      typeof detail.reason === "string" ? detail.reason : "unknown";
-    acc.reasons[reason] = (acc.reasons[reason] ?? 0) + 1;
-  }
-
-  const buckets = CORPUS_BUCKETS.map((b) => {
-    const acc = bucketMap.get(b.label)!;
-    return {
-      pageCountRange: b.label,
-      total: acc.total,
-      scored: acc.scored,
-      passed: acc.passed,
-      scoredPassRate: acc.scored > 0 ? acc.scoredPassed / acc.scored : null,
-      reasons: acc.reasons,
-    };
-  });
-
-  return {
-    lookbackDays: days,
-    totalRuns: rows.length,
-    buckets,
-    unknownPageCount: {
-      total: unknown.total,
-      passed: unknown.passed,
-      reasons: unknown.reasons,
-    },
-  };
-}
-
 export const ROUTES: RouteDefinition[] = [
   {
     operationId: "memory_v3_rebuild_index",

package/src/plugins/defaults/memory/src/memory-worker-routes.ts

@@ -18,8 +18,8 @@ import { getMemoryBackendStatus } from "../../../../persistence/embeddings/embed
 import { ACTOR_PRINCIPALS } from "../../../../runtime/auth/route-policy.js";
 import { InternalError } from "../../../../runtime/routes/errors.js";
 import type { RouteDefinition } from "../../../../runtime/routes/types.js";
+import { getMemoryWorkerPidPath } from "../../../../util/layout.js";
 import { getLogger } from "../../../../util/logger.js";
-import { getMemoryWorkerPidPath } from "../../../../util/platform.js";
 import {
   MemoryWorkerSpawnError,
   probeMemoryWorker,

package/src/plugins/defaults/memory/startup.ts

@@ -41,15 +41,11 @@ import {
   clearRebuildSentinel,
   initQdrantClient,
 } from "../../../persistence/embeddings/qdrant-client.js";
-import {
-  createQdrantManager,
-  describeQdrantStartFailure,
-} from "../../../persistence/embeddings/qdrant-manager.js";
+import { createQdrantManager } from "../../../persistence/embeddings/qdrant-manager.js";
 import {
   enqueueMemoryJob,
   isMemoryEnabled,
 } from "../../../persistence/jobs-store.js";
-import { recordWatchdogEvent } from "../../../telemetry/watchdog-events-store.js";
 import { resolveQdrantUrl } from "./embeddings.js";
 import { startMemoryJobsWorker } from "./jobs-worker.js";
 import { getLogger } from "./logging.js";
@@ -96,23 +92,6 @@ export async function runMemoryStartup(config: AssistantConfig): Promise<void> {
           { err },
           "Qdrant failed to start after all attempts — memory features will be unavailable",
         );
-        // Fleet-wide record of the failure: the step, the exit code and
-        // Qdrant's own reason line, bounded to telemetry-safe metadata by
-        // `describeQdrantStartFailure`. Observational only: the outbox insert
-        // can throw on a locked or half-migrated telemetry DB, and this path
-        // must still reach the worker start below.
-        try {
-          recordWatchdogEvent({
-            checkName: "qdrant_start_failed",
-            value: attempt,
-            detail: { attempts: attempt, ...describeQdrantStartFailure(err) },
-          });
-        } catch (telemetryErr) {
-          log.warn(
-            { err: telemetryErr },
-            "Qdrant start failure could not be recorded to telemetry",
-          );
-        }
       }
     }
   }