@mycadet/assistant 0.12.9 → 0.12.11

package/src/config/__tests__/default-profile-catalog.test.ts

@@ -10,7 +10,6 @@ import {
   getEffectiveProfiles,
   getEffectiveProfilesForProvider,
   getUserSelectableProfilesForProvider,
-  MANAGED_PROFILE_TEMPLATES,
   PROFILE_IMPLS,
   resolveDefaultProfileForProvider,
 } from "../default-profile-catalog.js";
@@ -32,11 +31,11 @@ import {
   type ProfileEntry,
 } from "../schemas/llm.js";
 
-/** Thin managed-source stubs: a workspace that carries only ownership
- * markers for the defaults, no profile content. */
+/** Thin managed stubs: a workspace that carries only the cadet-provider
+ * marker for the defaults, no profile content. */
 function managedStubs(): Record<string, ProfileEntry> {
   return Object.fromEntries(
-    DEFAULT_PROFILE_KEYS.map((key) => [key, { source: "managed" as const }]),
+    DEFAULT_PROFILE_KEYS.map((key) => [key, { provider: "cadet" as const }]),
   );
 }
 
@@ -48,7 +47,6 @@ describe("getEffectiveProfiles", () => {
       expect(typeof body.model).toBe("string");
       expect(body.provider).toBe("cadet");
       expect(body.provider_connection).toBeUndefined();
-      expect(body.source).toBe("managed");
     }
   });
 
@@ -80,35 +78,6 @@ describe("getEffectiveProfiles", () => {
     ).toBeUndefined();
   });
 
-  test("the Auto profile is the cloud Balanced body relabeled, managed-only, and flag-gated", () => {
-    const auto = CODE_DEFAULT_PROFILE_ENTRIES.auto;
-    const balanced = CODE_DEFAULT_PROFILE_ENTRIES.balanced;
-    expect(auto.label).toBe("Auto");
-    expect(auto.model).toBe(balanced.model);
-    expect(auto.provider).toBe(balanced.provider);
-    expect(auto.fallbackProfile).toBeUndefined();
-    // Not seeded unconditionally: the flag reconcile writes the stub.
-    expect(Object.keys(MANAGED_PROFILE_TEMPLATES)).not.toContain("auto");
-    expect(
-      resolveDefaultProfileForProvider(undefined, "auto", undefined),
-    ).toBeUndefined();
-    const stub: Record<string, ProfileEntry> = { auto: { source: "managed" } };
-    expect(
-      resolveDefaultProfileForProvider(stub, "auto", undefined)?.model,
-    ).toBe(balanced.model);
-    expect(
-      resolveDefaultProfileForProvider(stub, "auto", {
-        provider: "anthropic",
-        provider_connection: "anthropic-personal",
-      }),
-    ).toBeUndefined();
-    expect(
-      Object.keys(
-        getConversationProfilesForProvider(LLMSchema.parse({ profiles: stub })),
-      ),
-    ).toContain("auto");
-  });
-
   test("the conversation view drops the cloud Jev profile but keeps it selectable for call sites", () => {
     expect(
       Object.keys(getConversationProfilesForProvider(undefined)),
@@ -150,15 +119,14 @@ describe("getEffectiveProfiles", () => {
     expect(getEffectiveProfile({}, OS_BETA_PROFILE_KEY)).toBeUndefined();
   });
 
-  test("a cloud-source entry resolves to the code body with only label/status/topP from disk", () => {
+  test("a cadet-provider entry resolves to the code body with only label/status/topP from disk", () => {
     const workspace: Record<string, ProfileEntry> = {
       balanced: {
-        source: "managed",
+        provider: "cadet",
         label: "Balanced (Managed)",
         status: "disabled",
         topP: 0.7,
         // Stale content drift on disk must lose to the code default body.
-        provider: "anthropic",
         model: "claude-sonnet-4-6",
         maxTokens: 1,
       },
@@ -180,7 +148,6 @@ describe("getEffectiveProfiles", () => {
   test("a user-owned profile sharing a default name wins verbatim", () => {
     const workspace: Record<string, ProfileEntry> = {
       balanced: {
-        source: "user",
         provider: "anthropic",
         model: "claude-sonnet-4-6",
         maxTokens: 1000,
@@ -297,9 +264,8 @@ describe("resolver integration", () => {
   test("a disabled managed default does not divert resolution to the custom-* clone", () => {
     const llm = LLMSchema.parse({
       profiles: {
-        balanced: { source: "managed", status: "disabled" },
+        balanced: { provider: "cadet", status: "disabled" },
         "custom-balanced": {
-          source: "user",
           provider: "anthropic",
           model: "claude-sonnet-4-6",
           maxTokens: 1000,
@@ -324,7 +290,6 @@ describe("resolver integration", () => {
     const llm = LLMSchema.parse({
       profiles: {
         "latency-optimized": {
-          source: "user",
           provider: "anthropic",
           model: "claude-opus-4-6",
           provider_connection: "anthropic-personal",
@@ -366,7 +331,6 @@ describe("resolver integration", () => {
       const llm = LLMSchema.parse({
         profiles: {
           [key]: {
-            source: "user",
             provider: "anthropic",
             model: "claude-opus-4-6",
             provider_connection: "anthropic-personal",
@@ -414,7 +378,7 @@ describe("schema validation", () => {
     expect(() =>
       LLMSchema.parse({
         activeProfile: OS_BETA_PROFILE_KEY,
-        profiles: { [OS_BETA_PROFILE_KEY]: { source: "managed" } },
+        profiles: { [OS_BETA_PROFILE_KEY]: { provider: "cadet" } },
       }),
     ).not.toThrow();
     expect(() =>
@@ -485,7 +449,6 @@ describe("resolveDefaultProfileForProvider", () => {
         } else {
           expect(entry?.provider_connection).toBeDefined();
         }
-        expect(entry?.source).toBe("managed");
       }
     }
   });
@@ -507,7 +470,6 @@ describe("resolveDefaultProfileForProvider", () => {
       expect(entry?.provider).toBe("chatgpt");
       expect(entry?.model).toBe(model);
       expect(entry?.provider_connection).toBeUndefined();
-      expect(entry?.source).toBe("managed");
     }
     // Budget and Fast both opt fully out of reasoning.
     expect(effective["cost-optimized"]?.effort).toBe("none");
@@ -526,7 +488,6 @@ describe("resolveDefaultProfileForProvider", () => {
     // No intent table for `together`: the intent falls back to the
     // provider's catalog defaultModel.
     expect(entry?.model).toBe(resolveModelIntent("together", "balanced"));
-    expect(entry?.source).toBe("managed");
   });
 
   test("maxTokens clamps to the resolved model's catalog output cap", () => {
@@ -599,7 +560,7 @@ describe("resolveDefaultProfileForProvider", () => {
 
   test("a user-source workspace entry shadows the provider-resolved default", () => {
     const workspace: Record<string, ProfileEntry> = {
-      balanced: { source: "user", provider: "openai", model: "gpt-5.5" },
+      balanced: { provider: "openai", model: "gpt-5.5" },
     };
     const entry = resolveDefaultProfileForProvider(
       workspace,
@@ -631,10 +592,10 @@ describe("resolveDefaultProfileForProvider", () => {
     }
   });
 
-  test("a cloud-source stub contributes only label/status/topP over the provider-resolved body", () => {
+  test("a cadet-provider stub contributes only label/status/topP over the provider-resolved body", () => {
     const workspace: Record<string, ProfileEntry> = {
       balanced: {
-        source: "managed",
+        provider: "cadet",
         label: "Balanced (BYOK)",
         status: "disabled",
         topP: 0.7,
@@ -664,7 +625,7 @@ describe("resolveDefaultProfileForProvider", () => {
 
   test("non-matrix names pass through like getEffectiveProfile", () => {
     const workspace: Record<string, ProfileEntry> = {
-      "custom-mine": { source: "user", provider: "openai", model: "gpt-5.4" },
+      "custom-mine": { provider: "openai", model: "gpt-5.4" },
     };
     expect(
       resolveDefaultProfileForProvider(
@@ -687,7 +648,7 @@ describe("resolveDefaultProfileForProvider", () => {
       ),
     ).toBeUndefined();
     const workspace: Record<string, ProfileEntry> = {
-      [OS_BETA_PROFILE_KEY]: { source: "managed" },
+      [OS_BETA_PROFILE_KEY]: { provider: "cadet" },
     };
     const entry = resolveDefaultProfileForProvider(
       workspace,

package/src/config/__tests__/deployment-context-defaults.test.ts

@@ -53,7 +53,7 @@ afterAll(() => {
 });
 
 import { enableMemoryV3LiveForNewWorkspacesMigration } from "../../workspace/migrations/105-enable-memory-v3-live-for-new-workspaces.js";
-import { invalidateConfigCache, loadConfig } from "../loader.js";
+import { getConfig, invalidateConfigCache } from "../loader.js";
 
 // ---------------------------------------------------------------------------
 // Helpers
@@ -74,7 +74,7 @@ let originalIsPlatform: string | undefined;
 // Tests
 // ---------------------------------------------------------------------------
 
-describe("deployment-context embedding-provider default (via loadConfig)", () => {
+describe("deployment-context embedding-provider default (via getConfig)", () => {
   beforeEach(() => {
     ensureTestDir();
     const resetPaths = [
@@ -109,7 +109,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
     writeConfig({});
     process.env.IS_CLOUD = "true";
 
-    const config = loadConfig();
+    const config = getConfig();
 
     // In-memory effective config reflects the cloud intent.
     expect(config.memory.embeddings.provider).toBe("gemini");
@@ -138,7 +138,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
     }
     process.env.IS_CLOUD = "true";
 
-    const config = loadConfig();
+    const config = getConfig();
 
     // In-memory effective config still reflects the cloud intent.
     expect(config.memory.embeddings.provider).toBe("gemini");
@@ -180,14 +180,14 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
     // provider leaf absent), the cloud default re-applies in memory rather
     // than being lost to a persisted "auto" read back as an explicit choice.
     invalidateConfigCache();
-    expect(loadConfig().memory.embeddings.provider).toBe("gemini");
+    expect(getConfig().memory.embeddings.provider).toBe("gemini");
   });
 
   test("IS_CLOUD='1' also fills provider=gemini in memory", () => {
     writeConfig({});
     process.env.IS_CLOUD = "1";
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.memory.embeddings.provider).toBe("gemini");
   });
@@ -198,7 +198,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
     });
     process.env.IS_CLOUD = "true";
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.memory.embeddings.provider).toBe("local");
     expect(config.memory.qdrant.vectorSize).toBe(384);
@@ -214,7 +214,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
     writeConfig({});
     delete process.env.IS_CLOUD;
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.memory.embeddings.provider).toBe("auto");
     expect(config.memory.qdrant.vectorSize).toBe(384);
@@ -226,7 +226,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
     }
     delete process.env.IS_CLOUD;
 
-    const config = loadConfig();
+    const config = getConfig();
 
     // In-memory effective config still carries the full tuning (schema defaults).
     expect(config.memory.v3.gate.denseThreshold).toBe(0.66);
@@ -253,7 +253,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
     }
     delete process.env.IS_CLOUD;
 
-    loadConfig();
+    getConfig();
     enableMemoryV3LiveForNewWorkspacesMigration.run(WORKSPACE_DIR, {
       isNewWorkspace: true,
     });
@@ -295,7 +295,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
         `{\n  "memory": {\n    "v3": {\n      "live": true\n    }\n  },\n  "llm": {\n    "activeProf`,
       );
 
-      const config = loadConfig();
+      const config = getConfig();
 
       // The corrupt file was quarantined and the reseeded config carries the
       // tier forward, both in-memory (this boot runs v3) and on disk
@@ -311,7 +311,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
         `{\n  "memory": {\n    "v3": {\n      "live": false\n    }\n  },\n  "llm": {\n    "activeProf`,
       );
 
-      const config = loadConfig();
+      const config = getConfig();
 
       // Never carry `false` forward: an absent leaf is the only way to keep
       // "no decision recorded" representable for migration 105.
@@ -331,7 +331,7 @@ describe("deployment-context embedding-provider default (via loadConfig)", () =>
         JSON.stringify({ memory: { v3: { live: true } } }, null, 2),
       );
 
-      const config = loadConfig();
+      const config = getConfig();
 
       expect(config.memory.v3.live).toBe(true);
       expect(readV3Raw()).toEqual({ live: true });

package/src/config/__tests__/loader-callsite-strip-fallback.test.ts

@@ -32,7 +32,7 @@ afterAll(() => {
 });
 
 import { resolveCallSiteConfig } from "../llm-resolver.js";
-import { invalidateConfigCache, loadConfig } from "../loader.js";
+import { getConfig, invalidateConfigCache } from "../loader.js";
 
 function writeConfig(obj: unknown): void {
   writeFileSync(CONFIG_PATH, JSON.stringify(obj, null, 2) + "\n");
@@ -84,7 +84,7 @@ describe("config recovery prunes call-site overrides emptied by a strip", () =>
     // `{profile:"balanced"}` default — silently resolving to the active profile.
     writeConfig(baseLlm({ memoryV3SelectL2: { profile: "ghost-profile" } }));
 
-    const config = loadConfig();
+    const config = getConfig();
 
     // The emptied call-site entry must be pruned entirely, not left as `{}`.
     expect(config.llm.callSites?.memoryV3SelectL2).toBeUndefined();
@@ -105,7 +105,7 @@ describe("config recovery prunes call-site overrides emptied by a strip", () =>
       }),
     );
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.llm.callSites?.memoryV3SelectL2).toBeUndefined();
     expect(config.llm.callSites?.memoryRouter).toEqual({ profile: "balanced" });
@@ -119,7 +119,7 @@ describe("config recovery prunes call-site overrides emptied by a strip", () =>
       baseLlm({ memoryV3SelectL2: { profile: "missing", temperature: 0.5 } }),
     );
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.llm.callSites?.memoryV3SelectL2).toEqual({
       temperature: 0.5,

package/src/config/__tests__/loader-last-known-good.test.ts

@@ -6,7 +6,7 @@
  *
  * The strip-and-reparse cleanup (including sparse-array compaction) repairs
  * every known real-world config shape, so no config.json fixture reliably
- * reaches the ladder through `loadConfig` — the ladder is defense-in-depth
+ * reaches the ladder through `getConfig` — the ladder is defense-in-depth
  * for schema shapes the cleanup does not anticipate. The ladder tests here
  * therefore drive `_recoverFromInvalidConfigForTests` directly, while the
  * file-based tests assert the cleanup's healing behavior end-to-end.
@@ -48,9 +48,9 @@ afterAll(() => {
 import {
   _recoverFromInvalidConfigForTests,
   _resetLastKnownGoodConfigForTests,
+  getConfig,
   getConfigReadOnly,
   invalidateConfigCache,
-  loadConfig,
 } from "../loader.js";
 
 function writeConfig(obj: unknown): void {
@@ -90,7 +90,7 @@ describe("config recovery ladder for cleanup-resistant invalid config", () => {
   test("keeps the last-known-good config when recovery runs after a good load", () => {
     // A valid load captures the last-known-good snapshot for this process.
     writeConfig({ maxStepsPerSession: 123 });
-    expect(loadConfig().maxStepsPerSession).toBe(123);
+    expect(getConfig().maxStepsPerSession).toBe(123);
 
     // Recovery for an irreparable config returns the snapshot — the whole
     // config is NOT reset to schema defaults (which would be 50).
@@ -123,7 +123,7 @@ describe("config recovery ladder for cleanup-resistant invalid config", () => {
     // the sibling value is preserved and the recovery ladder is never reached.
     writeConfig({ maxStepsPerSession: 9999, tools: { exclude: ["keep-me"] } });
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.maxStepsPerSession).toBe(50);
     expect(config.tools.exclude).toEqual(["keep-me"]);
@@ -135,14 +135,14 @@ describe("config recovery ladder for cleanup-resistant invalid config", () => {
     // rung runs, the valid element survives, and sibling sections keep their
     // values from the file (not from the last-known-good snapshot).
     writeConfig({ maxStepsPerSession: 42 });
-    expect(loadConfig().maxStepsPerSession).toBe(42);
+    expect(getConfig().maxStepsPerSession).toBe(42);
 
     writeConfig({
       maxStepsPerSession: 123,
       tools: { exclude: ["valid-tool", 456] },
     });
     invalidateConfigCache();
-    const healed = loadConfig();
+    const healed = getConfig();
 
     expect(healed.maxStepsPerSession).toBe(123);
     expect(healed.tools.exclude).toEqual(["valid-tool"]);
@@ -150,7 +150,7 @@ describe("config recovery ladder for cleanup-resistant invalid config", () => {
 
   test("invalidateConfigCache does not clear the last-known-good safety net", () => {
     writeConfig({ maxStepsPerSession: 77 });
-    expect(loadConfig().maxStepsPerSession).toBe(77);
+    expect(getConfig().maxStepsPerSession).toBe(77);
 
     // A bare cache invalidation must not drop the safety net.
     invalidateConfigCache();
@@ -165,7 +165,7 @@ describe("config recovery ladder for cleanup-resistant invalid config", () => {
 
   test("getConfigReadOnly returns schema defaults for a top-level `null` config without throwing", () => {
     // `JSON.parse("null")` is valid JSON, so it reaches validateWithSchema as a
-    // non-object top-level value. `loadConfig` quarantines non-object files
+    // non-object top-level value. `getConfig` quarantines non-object files
     // before validation, so `getConfigReadOnly` (which validates the parsed
     // value directly) is the path that exercises the recovery ladder's
     // non-object guard. It must degrade to schema defaults, not throw on
@@ -193,7 +193,7 @@ describe("config recovery ladder for cleanup-resistant invalid config", () => {
     // First load with no config.json seeds the file and fills the
     // deployment-context cloud OAuth service modes in memory; the
     // last-known-good snapshot is refreshed AFTER that fill.
-    const seeded = loadConfig();
+    const seeded = getConfig();
     expect(seeded.services["outlook-oauth"].mode).toBe("managed");
 
     // Recovery keeps the last-known-good EFFECTIVE config, so the cloud mode

package/src/config/__tests__/loader-sparse-array-cleanup.test.ts

@@ -31,7 +31,7 @@ afterAll(() => {
   mock.restore();
 });
 
-import { invalidateConfigCache, loadConfig } from "../loader.js";
+import { getConfig, invalidateConfigCache } from "../loader.js";
 
 function writeConfig(obj: unknown): void {
   writeFileSync(CONFIG_PATH, JSON.stringify(obj, null, 2) + "\n");
@@ -64,7 +64,7 @@ describe("config recovery compacts arrays after stripping invalid elements", ()
       maxStepsPerSession: 77,
     });
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.tools.exclude).toEqual(["tool-a", "tool-b"]);
     // The rest of the config survives — cleanup succeeded, so recovery never
@@ -77,7 +77,7 @@ describe("config recovery compacts arrays after stripping invalid elements", ()
       tools: { exclude: [1, "tool-a", 2, "tool-b", 3] },
     });
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.tools.exclude).toEqual(["tool-a", "tool-b"]);
   });
@@ -91,7 +91,7 @@ describe("config recovery compacts arrays after stripping invalid elements", ()
       maxStepsPerSession: 66,
     });
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.tools.exclude).toEqual([]);
     expect(config.maxStepsPerSession).toBe(66);
@@ -107,7 +107,7 @@ describe("config recovery compacts arrays after stripping invalid elements", ()
       maxStepsPerSession: 66,
     });
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.skills.allowBundled).toBeNull();
     expect(config.maxStepsPerSession).toBe(66);
@@ -122,7 +122,7 @@ describe("config recovery compacts arrays after stripping invalid elements", ()
       maxStepsPerSession: 66,
     });
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.skills.allowBundled).toBeNull();
     expect(config.maxStepsPerSession).toBe(66);
@@ -138,7 +138,7 @@ describe("config recovery compacts arrays after stripping invalid elements", ()
       maxStepsPerSession: "not-a-number",
     });
 
-    const config = loadConfig();
+    const config = getConfig();
 
     expect(config.skills.allowBundled).toEqual([]);
   });

package/src/config/__tests__/plugin-resident-skill-discovery.test.ts

@@ -14,7 +14,7 @@ import { existsSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { beforeEach, describe, expect, test } from "bun:test";
 
-import { getWorkspacePluginsDir } from "../../util/platform.js";
+import { getWorkspacePluginsDir } from "../../util/layout.js";
 import { loadSkillCatalog } from "../skills.js";
 
 function writePlugin(

package/src/config/__tests__/profile-materialization.test.ts

@@ -248,20 +248,18 @@ describe("completeCustomProfile", () => {
     expect(completeCustomProfile(fullDefault, mix)).toBe(mix);
   });
 
-  test("passes cloud profiles through untouched", () => {
-    const managed: ProfileEntry = { source: "managed", topP: 0.9 };
+  test("passes cadet-provider profiles through untouched", () => {
+    const managed: ProfileEntry = { provider: "cadet", topP: 0.9 };
     expect(completeCustomProfile(fullDefault, managed)).toBe(managed);
   });
 
   test("preserves metadata fields", () => {
     const completed = completeCustomProfile(fullDefault, {
-      source: "user",
       label: "Fast drafts",
       description: "cheap and quick",
       status: "disabled",
       model: "claude-haiku-4-5-20251001",
     });
-    expect(completed.source).toBe("user");
     expect(completed.label).toBe("Fast drafts");
     expect(completed.description).toBe("cheap and quick");
     expect(completed.status).toBe("disabled");

package/src/config/__tests__/sync-gated-profiles.test.ts

@@ -94,14 +94,13 @@ describe("reconcileFlagGatedProfiles", () => {
     const raw = readConfig();
     // On disk: a thin managed stub — profile content is code-owned.
     const osBeta = raw.llm.profiles["os-beta"]!;
-    expect(osBeta).toEqual({ source: "managed" });
+    expect(osBeta).toEqual({ provider: "cadet" });
 
     // Through the effective view the stub resolves to the catalog body.
     const effective = getEffectiveProfile(raw.llm.profiles, "os-beta")!;
     expect(effective.model).toBe("MiniMaxAI/MiniMax-M3");
     expect(effective.provider_connection).toBeUndefined();
     expect(effective.provider).toBe("cadet");
-    expect(effective.source).toBe("managed");
     expect(effective.label).toBe("OS Beta");
     expect(effective.effort).toBe("low");
     expect(effective.topP).toBe(0.95);
@@ -120,7 +119,6 @@ describe("reconcileFlagGatedProfiles", () => {
     const osBeta = profiles["os-beta"]!;
     expect(osBeta.status).toBe("disabled");
     expect(osBeta.label).toBe("OS Beta (Managed)");
-    expect(osBeta.source).toBe("managed");
     // Content stays code-owned; the effective view supplies it.
     expect(osBeta.effort).toBeUndefined();
     expect(getEffectiveProfile(profiles, "os-beta")?.effort).toBe("low");
@@ -203,7 +201,6 @@ describe("reconcileFlagGatedProfiles", () => {
 
     const raw = readConfig();
     raw.llm.profiles["my-mix"] = {
-      source: "user",
       label: "My Mix",
       mix: [
         { profile: "balanced", weight: 70 },
@@ -225,7 +222,6 @@ describe("reconcileFlagGatedProfiles", () => {
       { profile: "balanced", weight: 70 },
       { profile: "quality-optimized", weight: 20 },
     ]);
-    expect(mix.source).toBe("user");
     expect(mix.label).toBe("My Mix");
 
     invalidateConfigCache();
@@ -240,7 +236,6 @@ describe("reconcileFlagGatedProfiles", () => {
 
     const raw = readConfig();
     raw.llm.profiles["experiment"] = {
-      source: "user",
       label: "Experiment",
       mix: [
         { profile: "balanced", weight: 50 },
@@ -339,104 +334,4 @@ describe("reconcileFlagGatedProfiles", () => {
 
     expect(LLMSchema.safeParse(after.llm).success).toBe(true);
   });
-
-  test("a user-owned os-beta profile is never touched", () => {
-    process.env.IS_CLOUD = "true";
-    writeConfig({
-      llm: {
-        default: { provider: "anthropic" },
-        profiles: {
-          "os-beta": {
-            source: "user",
-            label: "Mine",
-            provider: "anthropic",
-            model: "claude-x",
-            provider_connection: "anthropic-personal",
-          },
-        },
-        profileOrder: ["os-beta"],
-      },
-    });
-    invalidateConfigCache();
-    const before = readFileSync(CONFIG_PATH, "utf-8");
-
-    setOverridesForTesting({ "os-beta": true });
-    expect(reconcileFlagGatedProfiles()).toBe(false);
-    expect(readFileSync(CONFIG_PATH, "utf-8")).toBe(before);
-
-    setOverridesForTesting({ "os-beta": false });
-    expect(reconcileFlagGatedProfiles()).toBe(false);
-    expect(readFileSync(CONFIG_PATH, "utf-8")).toBe(before);
-  });
-
-  test("auto-profile flag on materializes the cloud auto profile at the head of the order", () => {
-    process.env.IS_CLOUD = "true";
-    seedBalancedConfig();
-    setOverridesForTesting({ "auto-profile": true });
-
-    expect(reconcileFlagGatedProfiles()).toBe(true);
-
-    const raw = readConfig();
-    expect(raw.llm.profiles.auto).toEqual({ source: "managed" });
-    expect(raw.llm.profileOrder[0]).toBe("auto");
-    const effective = getEffectiveProfile(raw.llm.profiles, "auto")!;
-    expect(effective.label).toBe("Auto");
-    expect(effective.model).toBe(
-      getEffectiveProfile(raw.llm.profiles, "balanced")!.model,
-    );
-    expect(LLMSchema.safeParse(raw.llm).success).toBe(true);
-  });
-
-  test("auto-profile flag on in BYOK mode writes a plain stub that the effective view hides", () => {
-    seedBalancedConfig();
-    setOverridesForTesting({ "auto-profile": true });
-
-    expect(reconcileFlagGatedProfiles()).toBe(true);
-
-    const raw = readConfig();
-    expect(raw.llm.profiles.auto).toEqual({ source: "managed" });
-    expect(getEffectiveProfile(raw.llm.profiles, "auto")).toBeDefined();
-  });
-
-  test("auto-profile flag off removes the cloud auto profile and repoints its references", () => {
-    process.env.IS_CLOUD = "true";
-    seedBalancedConfig();
-    setOverridesForTesting({ "auto-profile": true });
-    reconcileFlagGatedProfiles();
-
-    const raw = readConfig();
-    raw.llm.activeProfile = "auto";
-    (raw.llm as Record<string, unknown>).callSites = {
-      subagentSpawn: { profile: "auto" },
-    };
-    writeConfig(raw);
-    invalidateConfigCache();
-
-    setOverridesForTesting({ "auto-profile": false });
-    expect(reconcileFlagGatedProfiles()).toBe(true);
-
-    const after = readConfig();
-    expect(after.llm.profiles.auto).toBeUndefined();
-    expect(after.llm.profileOrder.includes("auto")).toBe(false);
-    expect(after.llm.activeProfile).toBe("balanced");
-    expect((after.llm as Record<string, unknown>).callSites).toEqual({
-      subagentSpawn: {},
-    });
-  });
-
-  test("os-beta and auto-profile reconcile independently in one pass", () => {
-    process.env.IS_CLOUD = "true";
-    seedBalancedConfig();
-    setOverridesForTesting({ "os-beta": true, "auto-profile": true });
-    expect(reconcileFlagGatedProfiles()).toBe(true);
-    let order = readConfig().llm.profileOrder;
-    expect(order[0]).toBe("auto");
-    expect(order.indexOf("os-beta")).toBe(order.indexOf("balanced") + 1);
-
-    setOverridesForTesting({ "os-beta": false, "auto-profile": true });
-    expect(reconcileFlagGatedProfiles()).toBe(true);
-    order = readConfig().llm.profileOrder;
-    expect(order[0]).toBe("auto");
-    expect(order.includes("os-beta")).toBe(false);
-  });
 });

package/src/config/acp-agent-write.ts

@@ -11,7 +11,7 @@ import { isPlainObject } from "../util/object.js";
  * `config set acp.agents.<id>.model null`. The deep-merge assigns that literal
  * `null` because the stored value is a scalar, and a SET writes it verbatim by
  * design. Both `command` and `model` are optional strings in `AcpConfigSchema`,
- * so a persisted `null` makes every later `loadConfig()` warn and take its
+ * so a persisted `null` makes every later `getConfig()` warn and take its
  * salvage path, dropping the whole `acp` section with the agents defined in it.
  * Clearing means removing the key, so drop it here on every write path.
  *