@mycadet/assistant 0.12.9 → 0.12.11

package/src/cli/commands/__tests__/ps.test.ts

@@ -12,6 +12,8 @@ import { beforeEach, describe, expect, mock, test } from "bun:test";
 
 import { Command } from "commander";
 
+import { MAX_COMMAND_LABEL_LENGTH } from "../../../util/process-tree.js";
+
 // ---------------------------------------------------------------------------
 // Mock state
 // ---------------------------------------------------------------------------
@@ -264,3 +266,68 @@ describe("ps command — failures", () => {
     expect(exitCode).toBe(1);
   });
 });
+
+describe("ps command — long labels stay bounded", () => {
+  const longName =
+    "bun x -y @some/org/deeply-nested-mcp-server --stdio --port 8080 --verbose";
+
+  test("caps a command-derived name that runs long, keeping head and tail", async () => {
+    mockResponse = {
+      ok: true,
+      result: {
+        processes: [{ name: longName, status: "running", origin: "workspace" }],
+      },
+    };
+
+    await runPsCommand();
+    const line = logLines.find((l) => l.trimStart().startsWith("bun x"))!;
+
+    // The interpreter survives at the head, the args' tail stays intact ahead
+    // of the origin column, and the middle collapses to one ellipsis so no
+    // column runs unbounded.
+    expect(line).toBeDefined();
+    expect(line.trimStart().startsWith(longName.slice(0, 16))).toBe(true);
+    expect(line).toContain("--stdio --port 8080 --verbose");
+    expect(line).toContain("…");
+    // Bounded end to end: capped label + two-space gutter + origin column.
+    expect(line.trimStart().length).toBeLessThanOrEqual(
+      MAX_COMMAND_LABEL_LENGTH + 2 + "workspace".length,
+    );
+  });
+
+  test("keeps the hierarchy indentation on a capped child label", async () => {
+    mockResponse = {
+      ok: true,
+      result: {
+        processes: [
+          {
+            name: "assistant",
+            status: "running",
+            origin: "workspace",
+            children: [
+              { name: longName, status: "running", origin: "workspace" },
+            ],
+          },
+        ],
+      },
+    };
+
+    await runPsCommand();
+    const line = logLines.find((l) => l.trimStart().startsWith("bun x"))!;
+    expect(line).toMatch(/^ {2}bun x/);
+  });
+
+  test("leaves short labels untouched", async () => {
+    mockResponse = {
+      ok: true,
+      result: {
+        processes: [{ name: "qdrant", status: "running", origin: "workspace" }],
+      },
+    };
+
+    await runPsCommand();
+    const line = logLines.find((l) => l.trimStart().startsWith("qdrant"))!;
+    expect(line).not.toContain("…");
+    expect(line.trimStart().startsWith("qdrant")).toBe(true);
+  });
+});

package/src/cli/commands/auth.help.ts

@@ -31,8 +31,8 @@ Examples:
 Fields:
   cloudUrl         The Cadet Cloud base URL this assistant connects to
   assistantId         This assistant's platform UUID
-  organizationId      The organization this assistant belongs to (from CLOUD_ORGANIZATION_ID)
-  userId              The user who owns this assistant (from CLOUD_USER_ID)
+  organizationId      The organization this assistant belongs to
+  userId              The user who owns this assistant
   authenticated       Whether all prerequisites for platform authentication are met
                       (platform URL and assistant API key both present)
 

package/src/cli/commands/avatar.ts

@@ -4,7 +4,7 @@ import { isAbsolute, join } from "node:path";
 import type { Command } from "commander";
 
 import { cliIpcCall, exitFromIpcResult } from "../../ipc/cli-client.js";
-import { getWorkspaceDir } from "../../util/platform.js";
+import { getWorkspaceDir } from "../../util/layout.js";
 import { applyCommandHelp, subcommand } from "../lib/cli-command-help.js";
 import { registerCommand } from "../lib/register-command.js";
 import { log } from "../logger.js";

package/src/cli/commands/changelog.ts

@@ -22,7 +22,7 @@ import { dirname, join } from "node:path";
 
 import type { Command } from "commander";
 
-import { getWorkspaceDir } from "../../util/platform.js";
+import { getWorkspaceDir } from "../../util/layout.js";
 import { applyCommandHelp, subcommand } from "../lib/cli-command-help.js";
 import { registerCommand } from "../lib/register-command.js";
 import { USER_AGENT } from "../lib/user-agent.js";

package/src/cli/commands/cloud/__tests__/subscription.test.ts

@@ -18,7 +18,7 @@ describe("assistant cloud subscription", () => {
         cancelAt: null,
         selectedCreditTier: "credits_50",
         package: { key: "super", name: "Super", version: 2, customized: false },
-        entitlements: { managedEmail: true, phoneNumber: false },
+        entitlements: { cloudEmail: true, phoneNumber: false },
       },
     };
   });
@@ -32,7 +32,7 @@ describe("assistant cloud subscription", () => {
     expect(parsed.planId).toBe("pro");
     expect(parsed.status).toBe("active");
     expect(parsed.package.name).toBe("Super");
-    expect(parsed.entitlements.managedEmail).toBe(true);
+    expect(parsed.entitlements.cloudEmail).toBe(true);
   });
 
   test("plain text mode does not emit JSON to stdout", async () => {

package/src/cli/commands/cloud/index.help.ts

@@ -136,7 +136,7 @@ Fields:
   selectedCreditTier  The selected Pro credit bundle tier, or null
   package             The named Pro package pin ({ key, name, version,
                       customized }), or null
-  entitlements        Plan-gated features ({ managedEmail, phoneNumber })
+  entitlements        Plan-gated features ({ cloudEmail, phoneNumber })
 
 For the credit balance (not the plan), use 'assistant cloud credits'. For
 plan pricing, use 'assistant cloud plans'.

package/src/cli/commands/cloud/index.ts

@@ -46,7 +46,7 @@ interface CloudSubscriptionResult {
     customized: boolean;
   } | null;
   entitlements: {
-    managedEmail: boolean;
+    cloudEmail: boolean;
     phoneNumber: boolean;
   };
 }
@@ -187,7 +187,7 @@ export function registerCloudCommand(program: Command): void {
               log.info(`Credit tier: ${result.selectedCreditTier}`);
             }
             const ent: string[] = [];
-            if (result.entitlements.managedEmail) {
+            if (result.entitlements.cloudEmail) {
               ent.push("managed email");
             }
             if (result.entitlements.phoneNumber) {

package/src/cli/commands/db/refresh.ts

@@ -20,9 +20,9 @@ import { execFileSync } from "node:child_process";
 
 import type { Command } from "commander";
 
+import { getDbPath } from "../../../util/layout.js";
 import { getLogsDbPath } from "../../../util/logs-db-path.js";
 import { getMemoryDbPath } from "../../../util/memory-db-path.js";
-import { getDbPath } from "../../../util/platform.js";
 import { getTelemetryDbPath } from "../../../util/telemetry-db-path.js";
 import { dim, green, red } from "../../lib/cli-colors.js";
 import { subcommand } from "../../lib/cli-command-help.js";

package/src/cli/commands/db/repair-step-conversation-backfill.ts

@@ -28,7 +28,7 @@ import { Database } from "bun:sqlite";
 import { eq } from "drizzle-orm";
 import { drizzle } from "drizzle-orm/bun-sqlite";
 
-import { getWorkspaceDir } from "../../../util/platform.js";
+import { getWorkspaceDir } from "../../../util/layout.js";
 import type { RepairContext, RepairStep, StepResult } from "./repair-steps.js";
 
 /**

package/src/cli/commands/db/repair.ts

@@ -18,7 +18,7 @@ import { existsSync } from "node:fs";
 
 import type { Command } from "commander";
 
-import { getDbPath } from "../../../util/platform.js";
+import { getDbPath } from "../../../util/layout.js";
 import { dim, green, red } from "../../lib/cli-colors.js";
 import { subcommand } from "../../lib/cli-command-help.js";
 import { shouldOutputJson, writeOutput } from "../../output.js";

package/src/cli/commands/db/status.ts

@@ -31,9 +31,9 @@ import { Database } from "bun:sqlite";
 import type { Command } from "commander";
 
 import type { SchemaContractReport } from "../../../persistence/schema-contract.js";
+import { getDbPath } from "../../../util/layout.js";
 import { getLogsDbPath } from "../../../util/logs-db-path.js";
 import { getMemoryDbPath } from "../../../util/memory-db-path.js";
-import { getDbPath } from "../../../util/platform.js";
 import { getTelemetryDbPath } from "../../../util/telemetry-db-path.js";
 import { red } from "../../lib/cli-colors.js";
 import { subcommand } from "../../lib/cli-command-help.js";

package/src/cli/commands/inference-profiles.ts

@@ -25,7 +25,6 @@ interface ProfileSummary {
   provider: string | null;
   model: string | null;
   status: "active" | "disabled";
-  source: "managed" | "user";
   provider_connection?: string;
   availability: { status: string; message?: string } | null;
   /** Static problem with the stored entry itself; absent when it checks out. */
@@ -180,23 +179,13 @@ export function attachProfilesSubcommand(inference: Command): void {
       return;
     }
     renderTable(
-      [
-        "NAME",
-        "LABEL",
-        "PROVIDER",
-        "MODEL",
-        "STATUS",
-        "SOURCE",
-        "AVAIL",
-        "CONFIG",
-      ],
+      ["NAME", "LABEL", "PROVIDER", "MODEL", "STATUS", "AVAIL", "CONFIG"],
       rows.map((p) => [
         p.name,
         p.label ?? "-",
         p.provider ?? "-",
         p.model ?? "-",
         p.status,
-        p.source,
         p.availability ? p.availability.status : "-",
         p.config_issue ? p.config_issue.code : "ok",
       ]),

package/src/cli/commands/memory/__tests__/memory-v3.test.ts

@@ -2,12 +2,11 @@
  * Tests for the `assistant memory v3` CLI subgroup (section-lane model).
  *
  * Validates:
- *   - Subcommand registration (rebuild-index, backfill-sections, gate-stats)
+ *   - Subcommand registration (rebuild-index, backfill-sections)
  *     under `memory v3`.
  *   - `rebuild-index` and `backfill-sections` route through IPC to the daemon.
  *   - `backfill-sections` passes a long IPC timeout (the one-time full-corpus
  *     embed easily outlasts the default 60s).
- *   - `gate-stats` calls handleMemoryV3GateStats directly — no daemon required.
  *   - Error paths return a non-zero exit code without throwing.
  */
 
@@ -40,47 +39,6 @@ let mockIpcResult: {
 /** Captured log output for assertion. */
 let logOutput: string[] = [];
 
-/** Shared fake gate-stats payload used across gate-stats tests. */
-const fakeGateStats = {
-  lookbackDays: 30,
-  totalRuns: 10,
-  buckets: [
-    {
-      pageCountRange: "0–9",
-      total: 2,
-      scored: 1,
-      passed: 2,
-      scoredPassRate: 1,
-      reasons: { dense_pass: 1, dense_disabled: 1 },
-    },
-    {
-      pageCountRange: "10–49",
-      total: 5,
-      scored: 4,
-      passed: 3,
-      scoredPassRate: 0.75,
-      reasons: { dense_pass: 3, fail_no_signal: 1 },
-    },
-    {
-      pageCountRange: "50–199",
-      total: 2,
-      scored: 2,
-      passed: 1,
-      scoredPassRate: 0.5,
-      reasons: { dense_pass: 1, fail_no_signal: 1 },
-    },
-    {
-      pageCountRange: "200+",
-      total: 1,
-      scored: 1,
-      passed: 0,
-      scoredPassRate: 0,
-      reasons: { fail_no_signal: 1 },
-    },
-  ],
-  unknownPageCount: { total: 0, passed: 0, reasons: {} },
-};
-
 // ---------------------------------------------------------------------------
 // Mocks
 // ---------------------------------------------------------------------------
@@ -111,27 +69,6 @@ mock.module("../../../../util/logger.js", () => ({
 }));
 
 // ---------------------------------------------------------------------------
-// gate-stats direct-invocation mocks
-// ---------------------------------------------------------------------------
-
-/** Args captured from the last handleMemoryV3GateStats call. */
-let lastGateStatsArgs: { lookbackDays: number; db: unknown } | null = null;
-
-/** What handleMemoryV3GateStats returns, or an error to throw. */
-let gateStatsImpl: (() => unknown) | null = null;
-
-mock.module(
-  "../../../../plugins/defaults/memory/src/memory-v3-routes.js",
-  () => ({
-    handleMemoryV3GateStats: (lookbackDays: number, db: unknown) => {
-      lastGateStatsArgs = { lookbackDays, db };
-      if (gateStatsImpl) {
-        return gateStatsImpl();
-      }
-      return fakeGateStats;
-    },
-  }),
-);
 
 mock.module("../../../../persistence/db-connection.js", () => ({
   getTelemetrySqlite: () => ({}),
@@ -204,8 +141,6 @@ beforeEach(() => {
     ok: true,
     result: { articles: 3, sections: 12, failures: 0 },
   };
-  lastGateStatsArgs = null;
-  gateStatsImpl = null;
   logOutput = [];
   process.exitCode = 0;
 });
@@ -226,7 +161,6 @@ describe("subcommand registration", () => {
       "backfill-sections",
       "eval",
       "eval-tally",
-      "gate-stats",
       "rebuild-index",
     ]);
   });
@@ -310,52 +244,3 @@ describe("memory v3 backfill-sections", () => {
 });
 
 // ---------------------------------------------------------------------------
-// gate-stats (direct invocation — no daemon required)
-// ---------------------------------------------------------------------------
-
-describe("memory v3 gate-stats", () => {
-  test("calls handleMemoryV3GateStats directly with default lookback (no IPC)", async () => {
-    const { exitCode } = await runCommand(["memory", "v3", "gate-stats"]);
-
-    expect(exitCode).toBe(0);
-    // Must NOT have gone through IPC.
-    expect(lastIpcCall).toBeNull();
-    // Must have called the handler directly with the default lookback.
-    expect(lastGateStatsArgs!.lookbackDays).toBe(30);
-  });
-
-  test("forwards --lookback-days directly to handleMemoryV3GateStats", async () => {
-    await runCommand(["memory", "v3", "gate-stats", "--lookback-days", "7"]);
-
-    expect(lastIpcCall).toBeNull();
-    expect(lastGateStatsArgs!.lookbackDays).toBe(7);
-  });
-
-  test("prints formatted table on success (no --json)", async () => {
-    await runCommand(["memory", "v3", "gate-stats"]);
-
-    expect(logOutput.some((l) => l.includes("Gate-stats"))).toBe(true);
-    expect(logOutput.some((l) => l.includes("10–49"))).toBe(true);
-    expect(logOutput.some((l) => l.includes("75.0%"))).toBe(true);
-  });
-
-  test("emits raw JSON with --json", async () => {
-    await runCommand(["memory", "v3", "gate-stats", "--json"]);
-
-    const raw = logOutput.join("");
-    const parsed = JSON.parse(raw) as typeof fakeGateStats;
-    expect(parsed.totalRuns).toBe(10);
-    expect(parsed.buckets).toHaveLength(4);
-  });
-
-  test("exits with code 1 when handleMemoryV3GateStats throws", async () => {
-    gateStatsImpl = () => {
-      throw new Error("telemetry DB locked");
-    };
-
-    const { exitCode } = await runCommand(["memory", "v3", "gate-stats"]);
-
-    expect(exitCode).toBe(1);
-    expect(logOutput.some((l) => l.includes("telemetry DB locked"))).toBe(true);
-  });
-});

package/src/cli/commands/memory/index.help.ts

@@ -600,9 +600,7 @@ safely.
 
 Examples:
   $ assistant memory v3 rebuild-index
-  $ assistant memory v3 backfill-sections
-  $ assistant memory v3 gate-stats
-  $ assistant memory v3 gate-stats --lookback-days 7 --json`,
+  $ assistant memory v3 backfill-sections`,
       subcommands: [
         {
           name: "rebuild-index",
@@ -712,46 +710,6 @@ Examples:
   $ assistant memory v3 eval --snapshot .mv3/snapshot/concepts --staging .mv3/staging --out .mv3/eval
   $ assistant memory v3 eval --snapshot .mv3/snapshot/concepts --staging .mv3/staging --out .mv3/eval --turns-file .mv3/eval/key.json
   $ assistant memory v3 eval --snapshot .mv3/snapshot/concepts --staging .mv3/staging --out .mv3/eval --exclude-conversation <migration-conv-id>`,
-        },
-        {
-          name: "gate-stats",
-          description:
-            "Show injection gate pass rates bucketed by corpus size (read-only)",
-          options: [
-            {
-              flags: "--lookback-days <n>",
-              description: "Days of telemetry to aggregate (1–90, default 30)",
-              defaultValue: "30",
-            },
-            {
-              flags: "--json",
-              description: "Emit raw JSON instead of a formatted table",
-            },
-          ],
-          helpText: `
-Reads the memory v3 injection gate telemetry outbox and prints pass rates
-and reason distributions grouped by concept page count bucket
-(0–9 / 10–49 / 50–199 / 200+). Scored runs (dense lane was available and
-actually weighed scores) are reported separately from pass-open shortcuts
-(dense disabled / unavailable / gate threw) so scoredPassRate reflects
-only contested gate decisions — the signal relevant for threshold calibration.
-
-Coverage is limited to runs still pending platform flush. In a healthy system
-the outbox holds only the last few minutes to hours of events, so
---lookback-days is an upper bound, not a guarantee; long-window aggregation
-lives on the cloud side on top of flushed watchdog events.
-
-Reads the telemetry database directly — the assistant does not need to be
-running.
-
-Intended use: verify that gate firing rates shift as expected after a
-config or threshold change, and check whether the bm25-auto-calibration
-flag is worth enabling for large corpora.
-
-Examples:
-  $ assistant memory v3 gate-stats
-  $ assistant memory v3 gate-stats --lookback-days 7
-  $ assistant memory v3 gate-stats --json | jq '.buckets[] | select(.pageCountRange == "200+")'`,
         },
         {
           name: "eval-tally",

package/src/cli/commands/memory/memory-v3.ts

@@ -25,7 +25,6 @@ import type {
   MemoryEvalTallyResult,
 } from "../../../plugins/defaults/memory/src/memory-eval-routes.js";
 import type {
-  GateStatsResponse,
   MemoryV3BackfillSectionsResult,
   MemoryV3RebuildIndexResult,
 } from "../../../plugins/defaults/memory/src/memory-v3-routes.js";
@@ -53,36 +52,6 @@ function collectRepeatable(value: string, acc: string[]): string[] {
   return [...acc, value];
 }
 
-/** Render gate-stats as a human-readable table. */
-function formatGateStats(r: GateStatsResponse): string {
-  const lines: string[] = [
-    `Gate-stats (last ${r.lookbackDays} day${r.lookbackDays === 1 ? "" : "s"}, ${r.totalRuns} run${r.totalRuns === 1 ? "" : "s"})`,
-    "",
-    `Bucket     Total  Scored  Passed  ScoredPassRate  Top reasons`,
-  ];
-  for (const b of r.buckets) {
-    const rate =
-      b.scoredPassRate !== null
-        ? `${(b.scoredPassRate * 100).toFixed(1)}%`
-        : "n/a";
-    const topReasons = Object.entries(b.reasons)
-      .sort(([, a], [, bv]) => (bv as number) - (a as number))
-      .slice(0, 3)
-      .map(([k, v]) => `${k}: ${v}`)
-      .join(", ");
-    lines.push(
-      `${b.pageCountRange.padEnd(10)} ${String(b.total).padStart(5)}  ${String(b.scored).padStart(6)}  ${String(b.passed).padStart(6)}  ${rate.padStart(14)}  ${topReasons}`,
-    );
-  }
-  if (r.unknownPageCount.total > 0) {
-    lines.push("");
-    lines.push(
-      `Unknown page count: ${r.unknownPageCount.total} total, ${r.unknownPageCount.passed} passed`,
-    );
-  }
-  return lines.join("\n");
-}
-
 /**
  * Read the `turn` ids from a prior run's `key.json` or `packets.json` (both are
  * arrays of objects carrying a `turn` field). Used to pin `--turns-file` so a
@@ -302,37 +271,4 @@ export function registerMemoryV3Command(memory: Command): void {
       log.info(formatTally(payload));
     },
   );
-
-  // ── gate-stats ────────────────────────────────────────────────────────
-  // Reads the telemetry DB directly — no daemon required.
-
-  subcommand(v3, "gate-stats").action(
-    async (opts: { lookbackDays: string; json?: boolean }) => {
-      const lookbackDays = Number(opts.lookbackDays);
-      const [{ handleMemoryV3GateStats }, { getTelemetrySqlite }] =
-        await Promise.all([
-          import("../../../plugins/defaults/memory/src/memory-v3-routes.js"),
-          import("../../../persistence/db-connection.js"),
-        ]);
-      let payload;
-      try {
-        payload = handleMemoryV3GateStats(
-          Number.isFinite(lookbackDays) ? lookbackDays : 30,
-          getTelemetrySqlite(),
-        );
-      } catch (err) {
-        log.error(
-          "Failed to read gate stats: %s",
-          err instanceof Error ? err.message : String(err),
-        );
-        process.exitCode = 1;
-        return;
-      }
-      if (opts.json === true) {
-        log.info(JSON.stringify(payload, null, 2));
-        return;
-      }
-      log.info(formatGateStats(payload));
-    },
-  );
 }