@mycadet/assistant 0.12.9 → 0.12.11

package/src/cli/lib/__tests__/local-plugin-upgrade.test.ts

@@ -1,251 +0,0 @@
-import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { afterEach, describe, expect, test } from "bun:test";
-
-import type { FetchLike } from "../fetch-like.js";
-import { installPlugin, readInstallMeta } from "../install-from-github.js";
-import type { PluginCatalog } from "../search-plugins.js";
-import { PluginMergeBaselineError, upgradePlugin } from "../upgrade-plugin.js";
-
-const roots: string[] = [];
-
-afterEach(() => {
-  for (const root of roots.splice(0)) {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-function packageMaterializer(calls: string[]) {
-  return (path: string, version: string, destination: string): number => {
-    calls.push(`${path}@${version}`);
-    mkdirSync(destination, { recursive: true });
-    writeFileSync(
-      join(destination, "plugin.json"),
-      JSON.stringify({
-        $schema: "https://agent-plugins.org/schemas/1.0.0/plugin.schema.json",
-        name: "fathom",
-        version,
-      }),
-    );
-    writeFileSync(
-      join(destination, "mcp.json"),
-      JSON.stringify({
-        $schema: "https://agent-plugins.org/schemas/1.0.0/mcp.schema.json",
-        mcpServers: {
-          fathom: {
-            type: "streamable-http",
-            url: "https://api.fathom.ai/mcp",
-          },
-        },
-      }),
-    );
-    return 2;
-  };
-}
-
-function marketplaceFetch(version: string): FetchLike {
-  return (async () =>
-    new Response(
-      JSON.stringify({
-        name: "mycadet",
-        plugins: [
-          {
-            name: "fathom",
-            source: {
-              source: "local",
-              path: "plugins/mcp-catalog/fathom",
-              version,
-            },
-          },
-        ],
-      }),
-      { status: 200 },
-    )) as FetchLike;
-}
-
-function localCatalog(version: string): PluginCatalog {
-  return {
-    ref: "bundled",
-    matches: [
-      {
-        name: "fathom",
-        path: `local:plugins/mcp-catalog/fathom@${version}`,
-        category: null,
-        source: {
-          kind: "local",
-          path: "plugins/mcp-catalog/fathom",
-          version,
-        },
-      },
-    ],
-  };
-}
-
-async function installBundledPlugin(version = "1.0.0") {
-  const root = mkdtempSync(join(tmpdir(), "local-plugin-upgrade-"));
-  roots.push(root);
-  const pluginsDir = join(root, "plugins");
-  const calls: string[] = [];
-  const materializeLocalPackage = packageMaterializer(calls);
-  const installed = await installPlugin(
-    {
-      name: "fathom",
-      trustedSource: {
-        kind: "local",
-        path: "plugins/mcp-catalog/fathom",
-        version,
-      },
-    },
-    {
-      fetch: marketplaceFetch(version),
-      workspacePluginsDir: pluginsDir,
-      materializeLocalPackage,
-    },
-  );
-  return { calls, installed, materializeLocalPackage, pluginsDir };
-}
-
-describe("bundled plugin upgrades", () => {
-  test("ignores a newer live manifest version the current binary cannot materialize", async () => {
-    const fixture = await installBundledPlugin();
-
-    const result = await upgradePlugin(
-      { name: "fathom", strategy: "theirs" },
-      {
-        fetch: marketplaceFetch("9.0.0"),
-        workspacePluginsDir: fixture.pluginsDir,
-        materializeLocalPackage: fixture.materializeLocalPackage,
-        localCatalog: localCatalog("1.0.0"),
-        beforeSwap: async () => {},
-      },
-    );
-
-    expect(result.outcome).toBe("already-up-to-date");
-    expect(fixture.calls).toEqual(["plugins/mcp-catalog/fathom@1.0.0"]);
-  });
-
-  test("materializes the exact inspected path and version", async () => {
-    const fixture = await installBundledPlugin();
-
-    const result = await upgradePlugin(
-      { name: "fathom", strategy: "theirs" },
-      {
-        fetch: marketplaceFetch("1.1.0"),
-        workspacePluginsDir: fixture.pluginsDir,
-        materializeLocalPackage: fixture.materializeLocalPackage,
-        localCatalog: localCatalog("1.1.0"),
-        beforeSwap: async () => {},
-      },
-    );
-
-    expect(result.outcome).toBe("upgraded");
-    expect(fixture.calls).toEqual([
-      "plugins/mcp-catalog/fathom@1.0.0",
-      "plugins/mcp-catalog/fathom@1.1.0",
-    ]);
-    expect(readInstallMeta(result.target)?.source).toEqual({
-      kind: "local",
-      path: "plugins/mcp-catalog/fathom",
-      version: "1.1.0",
-    });
-    expect(result.strategy).toBe("theirs");
-  });
-
-  test("refuses a theirs upgrade when the installed package has local edits", async () => {
-    const fixture = await installBundledPlugin();
-    writeFileSync(
-      join(fixture.installed.target, "mcp.json"),
-      '{"edited":true}',
-    );
-
-    for (const dryRun of [false, true]) {
-      await expect(
-        upgradePlugin(
-          { name: "fathom", strategy: "theirs", dryRun },
-          {
-            fetch: marketplaceFetch("1.1.0"),
-            workspacePluginsDir: fixture.pluginsDir,
-            materializeLocalPackage: fixture.materializeLocalPackage,
-            localCatalog: localCatalog("1.1.0"),
-            beforeSwap: async () => {},
-          },
-        ),
-      ).rejects.toBeInstanceOf(PluginMergeBaselineError);
-    }
-
-    expect(fixture.calls).toEqual(["plugins/mcp-catalog/fathom@1.0.0"]);
-  });
-
-  test("refuses a theirs upgrade when a clean install cannot be proven", async () => {
-    const fixture = await installBundledPlugin();
-    const meta = readInstallMeta(fixture.installed.target);
-    expect(meta).not.toBeNull();
-    writeFileSync(
-      join(fixture.installed.target, "install-meta.json"),
-      `${JSON.stringify({ ...meta, fingerprint: null }, null, 2)}\n`,
-    );
-
-    await expect(
-      upgradePlugin(
-        { name: "fathom", strategy: "theirs" },
-        {
-          fetch: marketplaceFetch("1.1.0"),
-          workspacePluginsDir: fixture.pluginsDir,
-          materializeLocalPackage: fixture.materializeLocalPackage,
-          localCatalog: localCatalog("1.1.0"),
-          beforeSwap: async () => {},
-        },
-      ),
-    ).rejects.toBeInstanceOf(PluginMergeBaselineError);
-
-    expect(fixture.calls).toEqual(["plugins/mcp-catalog/fathom@1.0.0"]);
-  });
-
-  test("preserves explicit overwrite behavior for edited bundled packages", async () => {
-    const fixture = await installBundledPlugin();
-    writeFileSync(
-      join(fixture.installed.target, "mcp.json"),
-      '{"edited":true}',
-    );
-
-    const result = await upgradePlugin(
-      { name: "fathom", strategy: "overwrite" },
-      {
-        fetch: marketplaceFetch("1.1.0"),
-        workspacePluginsDir: fixture.pluginsDir,
-        materializeLocalPackage: fixture.materializeLocalPackage,
-        localCatalog: localCatalog("1.1.0"),
-        beforeSwap: async () => {},
-      },
-    );
-
-    expect(result.outcome).toBe("upgraded");
-    expect(result.strategy).toBe("overwrite");
-    expect(fixture.calls).toEqual([
-      "plugins/mcp-catalog/fathom@1.0.0",
-      "plugins/mcp-catalog/fathom@1.1.0",
-    ]);
-  });
-
-  test("keeps explicit ours and assistant strategies unavailable for bundled packages", async () => {
-    const fixture = await installBundledPlugin();
-
-    for (const strategy of ["ours", "assistant"] as const) {
-      await expect(
-        upgradePlugin(
-          { name: "fathom", strategy },
-          {
-            fetch: marketplaceFetch("1.1.0"),
-            workspacePluginsDir: fixture.pluginsDir,
-            materializeLocalPackage: fixture.materializeLocalPackage,
-            localCatalog: localCatalog("1.1.0"),
-            beforeSwap: async () => {},
-          },
-        ),
-      ).rejects.toBeInstanceOf(PluginMergeBaselineError);
-    }
-
-    expect(fixture.calls).toEqual(["plugins/mcp-catalog/fathom@1.0.0"]);
-  });
-});

package/src/cli/lib/__tests__/plugin-catalog-local.test.ts

@@ -1,113 +0,0 @@
-/**
- * Tests for the offline (bundled) plugin catalog reader.
- *
- * The catalog is projected from the manifest bundled into the package at build
- * time — no network, no filesystem path resolution.
- */
-
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-import { describe, expect, test } from "bun:test";
-
-import bundledManifest from "../bundled-marketplace.json" with { type: "json" };
-import {
-  buildBundledPluginCatalog,
-  readBundledPluginCatalog,
-  resolveBundledPluginSource,
-} from "../plugin-catalog-local.js";
-import { marketplaceManifestSchema } from "../plugin-marketplace.js";
-import { marketplaceMatch } from "../search-plugins.js";
-
-const canonicalManifest = JSON.parse(
-  readFileSync(
-    join(import.meta.dir, "../../../../../plugins/marketplace.json"),
-    "utf8",
-  ),
-) as unknown;
-
-describe("buildBundledPluginCatalog", () => {
-  test("yields one match per unique manifest name, sorted alphabetically", () => {
-    const catalog = buildBundledPluginCatalog();
-
-    expect(catalog.ref).toBe("bundled");
-    // The catalog dedupes by name (first occurrence wins — see
-    // `projectMarketplaceEntries`), so the match count tracks the number of
-    // distinct names, not the raw entry count. The cloud-generated manifest
-    // can carry multiple entries under one name (e.g. a repin that appends a
-    // new ref, or an icon-curation pass), and the reader collapses them.
-    const uniqueNames = new Set(bundledManifest.plugins.map((p) => p.name));
-    expect(catalog.matches.length).toBe(uniqueNames.size);
-
-    const names = catalog.matches.map((m) => m.name);
-    expect(names).toEqual([...names].sort((a, b) => a.localeCompare(b)));
-    expect(new Set(names).size).toBe(names.length);
-  });
-
-  test("projects each entry to the expected match shape", () => {
-    const catalog = buildBundledPluginCatalog();
-    const match = catalog.matches.find((m) => m.name === "caveman");
-
-    expect(match).toEqual({
-      name: "caveman",
-      path: "github:JuliusBrussee/caveman@63a91ecadbf4c4719a4602a5abb00883f9966034",
-      description:
-        "Ultra-compressed communication mode that strips filler words to cut token usage.",
-      category: "productivity",
-      homepage: "https://github.com/JuliusBrussee/caveman",
-      license: "MIT",
-      icon: "🦴",
-      source: {
-        kind: "github",
-        repo: "JuliusBrussee/caveman",
-        path: undefined,
-        ref: "63a91ecadbf4c4719a4602a5abb00883f9966034",
-      },
-    });
-  });
-
-  test("projects the OpenSEO subdirectory pin from the canonical catalog", () => {
-    const parsed = marketplaceManifestSchema.parse(canonicalManifest);
-    const entry = parsed.plugins.find((plugin) => plugin.name === "openseo");
-    expect(entry).toBeDefined();
-    expect(marketplaceMatch(entry!)).toEqual({
-      name: "openseo",
-      path: "github:every-app/open-seo/plugins/openseo@c469a48ae90ab58413b198fe3d1ac1aa90a9b070",
-      description:
-        "Keyword research, competitor analysis, site audits, backlinks, and rank tracking with real SEO data, plus guided workflow skills and the hosted OpenSEO MCP server.",
-      category: "marketing",
-      homepage: "https://openseo.so",
-      license: "MIT",
-      icon: "🔎",
-      source: {
-        kind: "github",
-        repo: "every-app/open-seo",
-        path: "plugins/openseo",
-        ref: "c469a48ae90ab58413b198fe3d1ac1aa90a9b070",
-      },
-    });
-  });
-
-  test("throws on a malformed manifest", () => {
-    expect(() => buildBundledPluginCatalog({ plugins: [{}] })).toThrow();
-  });
-});
-
-describe("readBundledPluginCatalog", () => {
-  test("returns a stable memoized reference across calls", () => {
-    expect(readBundledPluginCatalog()).toBe(readBundledPluginCatalog());
-  });
-});
-
-describe("resolveBundledPluginSource", () => {
-  test("hides a QA integration while its feature flag is off", () => {
-    expect(resolveBundledPluginSource("gamma", () => false)).toBeNull();
-  });
-
-  test("resolves a QA integration while its feature flag is on", () => {
-    expect(resolveBundledPluginSource("gamma", () => true)).toEqual({
-      kind: "local",
-      path: "plugins/mcp-catalog/gamma",
-      version: "1.0.2",
-    });
-  });
-});