@mycadet/assistant 0.12.9 → 0.12.11

package/src/__tests__/byok-default-profile-ensure.test.ts

@@ -81,7 +81,6 @@ function eraHatchBody(
   ) as Record<string, unknown>;
   return {
     ...body,
-    source: "managed",
     label: `${body.label} (Custom Provider)`,
     model,
   };
@@ -107,17 +106,17 @@ function uneditedByokConfig(): Record<string, unknown> {
       },
       profiles: {
         balanced: {
-          source: "managed",
+          provider: "cadet",
           status: "disabled",
           label: "Balanced (Managed)",
         },
         "quality-optimized": {
-          source: "managed",
+          provider: "cadet",
           status: "disabled",
           label: "Quality (Managed)",
         },
         "cost-optimized": {
-          source: "managed",
+          provider: "cadet",
           status: "disabled",
           label: "Speed (Managed)",
         },
@@ -125,7 +124,6 @@ function uneditedByokConfig(): Record<string, unknown> {
         "custom-quality-optimized": hatchBody("quality-optimized", "anthropic"),
         "custom-cost-optimized": hatchBody("cost-optimized", "anthropic"),
         "my-mix": {
-          source: "user",
           label: "My Mix",
           mix: [
             { profile: "custom-balanced", weight: 1 },
@@ -198,7 +196,6 @@ describe("ensureByokDefaultProfiles", () => {
       "balanced",
       { provider: "anthropic" },
     );
-    expect(resolved?.source).toBe("managed");
     expect(resolved?.status).toBeUndefined();
     expect(resolved?.provider).toBe("anthropic");
     expect(resolved?.provider_connection).toBe("anthropic-personal");
@@ -417,7 +414,7 @@ describe("ensureByokDefaultProfiles", () => {
     expectSecondRunNoop();
   });
 
-  test("stubs carrying the migration-097 thinking stamp are deleted (real-world shape)", () => {
+  test("stubs carrying the repair thinking stamp are deleted (real-world shape)", () => {
     const config = uneditedByokConfig();
     const profs = (config.llm as Record<string, unknown>).profiles as Record<
       string,
@@ -508,7 +505,7 @@ describe("ensureByokDefaultProfiles", () => {
 
     expect(profiles()["custom-balanced"]).toBeUndefined();
     expect(profiles().balanced).toEqual({
-      source: "managed",
+      provider: "cadet",
       label: "My Balanced",
     });
     expect(llm().activeProfile).toBe("balanced");
@@ -558,7 +555,7 @@ describe("ensureByokDefaultProfiles", () => {
 
     expect(profiles()["custom-balanced"]).toBeUndefined();
     expect(profiles().balanced).toEqual({
-      source: "managed",
+      provider: "cadet",
       status: "disabled",
     });
     expectSecondRunNoop();
@@ -572,7 +569,7 @@ describe("ensureByokDefaultProfiles", () => {
         default: { provider: "anthropic" },
         profiles: {
           "quality-optimized": {
-            source: "managed",
+            provider: "cadet",
             status: "active",
             label: "Quality (Managed)",
           },
@@ -588,13 +585,13 @@ describe("ensureByokDefaultProfiles", () => {
 
   test("a label-only hatch stub with no status key is deleted", () => {
     // Installs that predate #30367's status seeding got only the label
-    // rewrite, and migration 126 thinned them to { source, label }.
+    // rewrite: thin provider-marked stubs with no status key.
     writeConfig({
       llm: {
         default: { provider: "anthropic" },
         profiles: {
-          balanced: { source: "managed", label: "Balanced (Managed)" },
-          "cost-optimized": { source: "managed", label: "Speed (Managed)" },
+          balanced: { provider: "cadet", label: "Balanced (Managed)" },
+          "cost-optimized": { provider: "cadet", label: "Speed (Managed)" },
         },
       },
     });
@@ -610,7 +607,7 @@ describe("ensureByokDefaultProfiles", () => {
     const config = uneditedByokConfig();
     const profileMap = (config.llm as Record<string, unknown>)
       .profiles as Record<string, Record<string, unknown>>;
-    profileMap.balanced = { source: "managed", label: "Balanced (Managed)" };
+    profileMap.balanced = { provider: "cadet", label: "Balanced (Managed)" };
     profileMap["custom-balanced"] = {
       ...profileMap["custom-balanced"],
       status: "disabled",
@@ -621,7 +618,7 @@ describe("ensureByokDefaultProfiles", () => {
 
     expect(profiles()["custom-balanced"]).toBeUndefined();
     expect(profiles().balanced).toEqual({
-      source: "managed",
+      provider: "cadet",
       status: "disabled",
     });
     expectSecondRunNoop();
@@ -641,7 +638,7 @@ describe("ensureByokDefaultProfiles", () => {
 
     expect(profiles()["custom-quality-optimized"]).toBeUndefined();
     expect(profiles()["quality-optimized"]).toEqual({
-      source: "managed",
+      provider: "cadet",
       status: "disabled",
     });
     // The advisor pointed at the now-disabled default, so the same write
@@ -691,7 +688,6 @@ describe("ensureByokDefaultProfiles", () => {
         activeProfile: "custom-cost-optimized",
         profiles: {
           "custom-cost-optimized": {
-            source: "user",
             label: "Speed",
             description: "Fastest responses at lower cost",
             maxTokens: 8192,
@@ -769,7 +765,6 @@ describe("ensureByokDefaultProfiles", () => {
       "balanced",
       { provider: "cadet" },
     );
-    expect(resolved?.source).toBe("managed");
     expect(resolved?.status).toBeUndefined();
     expectSecondRunNoop();
   });
@@ -838,7 +833,6 @@ describe("ensureByokDefaultProfiles", () => {
         },
         profiles: {
           balanced: {
-            source: "user",
             provider: "openai",
             model: "gpt-5.4",
           },
@@ -883,19 +877,19 @@ describe("ensureByokDefaultProfiles", () => {
         },
         profiles: {
           balanced: {
-            source: "managed",
+            provider: "cadet",
             status: "active",
             label: "Balanced (Managed)",
             thinking: { enabled: true, streamThinking: true },
           },
           "quality-optimized": {
-            source: "managed",
+            provider: "cadet",
             status: "active",
             label: "Quality (Managed)",
             thinking: { enabled: true, streamThinking: true },
           },
           "cost-optimized": {
-            source: "managed",
+            provider: "cadet",
             status: "active",
             label: "Speed (Managed)",
           },
@@ -909,7 +903,7 @@ describe("ensureByokDefaultProfiles", () => {
           ),
           "custom-cost-optimized": hatchBody("cost-optimized", "anthropic"),
           "os-beta": {
-            source: "managed",
+            provider: "cadet",
             status: "active",
             label: "OS Beta (Managed)",
           },
@@ -953,7 +947,7 @@ describe("ensureByokDefaultProfiles", () => {
     expectSecondRunNoop();
   });
 
-  test("a cloud-source default entry with body keys is left alone", () => {
+  test("a cadet-provider default entry with body keys is left alone", () => {
     writeConfig({
       llm: {
         default: {
@@ -961,7 +955,7 @@ describe("ensureByokDefaultProfiles", () => {
         },
         profiles: {
           balanced: {
-            source: "managed",
+            provider: "cadet",
             status: "disabled",
             label: "Balanced (Managed)",
             model: "gpt-5.4",
@@ -1093,7 +1087,7 @@ describe("ensureByokDefaultProfiles", () => {
     const profileMap = (config.llm as Record<string, unknown>)
       .profiles as Record<string, Record<string, unknown>>;
     profileMap["quality-optimized"] = {
-      source: "managed",
+      provider: "cadet",
       status: "active",
       label: "Quality (Managed)",
     };
@@ -1107,7 +1101,7 @@ describe("ensureByokDefaultProfiles", () => {
 
     expect(profiles()["custom-quality-optimized"]).toBeUndefined();
     expect(profiles()["quality-optimized"]).toEqual({
-      source: "managed",
+      provider: "cadet",
       status: "disabled",
     });
     expectSecondRunNoop();

package/src/__tests__/call-conversation-messages.test.ts

@@ -102,7 +102,6 @@ describe("call-conversation-messages", () => {
     const conversationId = "conv-call-msg-failed";
     ensureConversation(conversationId);
     const session = createCallSession({
-      direction: "inbound",
       conversationId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -123,7 +122,6 @@ describe("call-conversation-messages", () => {
     const conversationId = "conv-call-msg-cancelled";
     ensureConversation(conversationId);
     const session = createCallSession({
-      direction: "inbound",
       conversationId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -144,7 +142,6 @@ describe("call-conversation-messages", () => {
     const conversationId = "conv-call-msg-completed";
     ensureConversation(conversationId);
     const session = createCallSession({
-      direction: "inbound",
       conversationId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -174,7 +171,6 @@ describe("call-conversation-messages", () => {
     const conversationId = "conv-call-msg-fallback";
     ensureConversation(conversationId);
     const session = createCallSession({
-      direction: "inbound",
       conversationId,
       provider: "twilio",
       fromNumber: "+12025550101",
@@ -212,7 +208,6 @@ describe("call-conversation-messages", () => {
     const conversationId = "conv-call-msg-schema";
     ensureConversation(conversationId);
     const session = createCallSession({
-      direction: "inbound",
       conversationId,
       provider: "twilio",
       fromNumber: "+12025550101",

package/src/__tests__/call-recovery.test.ts

@@ -54,14 +54,9 @@ function resetTables() {
   ensuredConvIds = new Set();
 }
 
-function createTestCallSession(
-  opts: Omit<Parameters<typeof createCallSession>[0], "direction"> & {
-    direction?: Parameters<typeof createCallSession>[0]["direction"];
-  },
-) {
+function createTestCallSession(opts: Parameters<typeof createCallSession>[0]) {
   ensureConversation(opts.conversationId);
-  // Direction only shapes the funnel stamp; these suites test other things.
-  return createCallSession({ direction: "inbound", ...opts });
+  return createCallSession({ ...opts });
 }
 
 /** Backdate a session's createdAt so it appears older than the grace period. */

package/src/__tests__/call-routes-http.test.ts

@@ -327,7 +327,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-get-1");
 
     const session = createCallSession({
-      direction: "outbound",
       conversationId: "conv-get-1",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -379,7 +378,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-cancel-1");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-cancel-1",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -409,7 +407,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-cancel-2");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-cancel-2",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -450,7 +447,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-answer-badjson");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-answer-badjson",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -473,7 +469,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-answer-1");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-answer-1",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -500,7 +495,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-answer-2");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-answer-2",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -523,7 +517,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-answer-3");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-answer-3",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -555,7 +548,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-instr-badjson");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-instr-badjson",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -578,7 +570,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-instr-empty");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-instr-empty",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -605,7 +596,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-instr-missing");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-instr-missing",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -650,7 +640,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-instr-ended");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-instr-ended",
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -679,7 +668,6 @@ describe("runtime call routes — HTTP layer", () => {
     ensureConversation("conv-instr-no-orch");
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: "conv-instr-no-orch",
       provider: "twilio",
       fromNumber: "+15550001111",

package/src/__tests__/call-store.test.ts

@@ -53,14 +53,9 @@ function resetTables() {
 }
 
 /** Wrapper that ensures the FK conversation row exists before creating a session. */
-function createTestCallSession(
-  opts: Omit<Parameters<typeof createCallSession>[0], "direction"> & {
-    direction?: Parameters<typeof createCallSession>[0]["direction"];
-  },
-) {
+function createTestCallSession(opts: Parameters<typeof createCallSession>[0]) {
   ensureConversation(opts.conversationId);
-  // Direction only shapes the funnel stamp; these suites test other things.
-  return createCallSession({ direction: "inbound", ...opts });
+  return createCallSession({ ...opts });
 }
 
 describe("call-store", () => {

package/src/__tests__/catalog-files.test.ts

@@ -152,7 +152,7 @@ beforeEach(() => {
   fetchCalls = [];
   mockCatalog = [];
   mockRepoSkillsDir = undefined;
-  mockCloudBaseUrl = "https://platform.test";
+  mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
 });
 
 afterEach(() => {
@@ -314,7 +314,7 @@ describe("readCatalogSkillFiles (dev mode)", () => {
     // called against the preview endpoint.
     expect(fetchCalls.length).toBe(1);
     expect(fetchCalls[0]!.url).toBe(
-      "https://platform.test/v1/skills/my-skill/files/",
+      "https://test-cloud.mycadet.ai/v1/skills/my-skill/files/",
     );
   });
 
@@ -354,7 +354,9 @@ describe("readCatalogSkillFiles (dev mode)", () => {
     expect(fetchCalls.length).toBe(1);
     const url = fetchCalls[0]!.url;
     expect(
-      url.startsWith("https://platform.test/v1/skills/my-skill/files/content/"),
+      url.startsWith(
+        "https://test-cloud.mycadet.ai/v1/skills/my-skill/files/content/",
+      ),
     ).toBe(true);
   });
 
@@ -430,7 +432,7 @@ describe("readCatalogSkillFiles (platform mode)", () => {
     // URL + headers
     expect(fetchCalls.length).toBe(1);
     expect(fetchCalls[0]!.url).toBe(
-      "https://platform.test/v1/skills/remote-skill/files/",
+      "https://test-cloud.mycadet.ai/v1/skills/remote-skill/files/",
     );
     const headers = (fetchCalls[0]!.init?.headers ?? {}) as Record<
       string,
@@ -734,7 +736,7 @@ describe("readCatalogSkillFileContent (platform mode)", () => {
     const url = fetchCalls[0]!.url;
     expect(
       url.startsWith(
-        "https://platform.test/v1/skills/remote-skill/files/content/",
+        "https://test-cloud.mycadet.ai/v1/skills/remote-skill/files/content/",
       ),
     ).toBe(true);
     expect(url).toContain("path=SKILL.md");

package/src/__tests__/checker.test.ts

@@ -74,7 +74,7 @@ import { _clearGlobalCacheForTesting } from "../permissions/gateway-threshold-re
 import { RiskLevel } from "../permissions/types.js";
 import { registerSkillTools, registerTool } from "../tools/registry.js";
 import type { Tool } from "../tools/types.js";
-import * as platformModule from "../util/platform.js";
+import * as platformModule from "../util/layout.js";
 
 /** Default gateway thresholds matching the old config fallback defaults. */
 const DEFAULT_GATEWAY_THRESHOLDS = {

package/src/__tests__/cli-memory-v2-reembed-skills.test.ts

@@ -4,7 +4,7 @@
  *
  * The CLI half mocks `cliIpcCall` and asserts the subcommand dispatches
  * to `memory_v2_reembed_skills` with an empty body. The route half uses
- * the real `loadConfig` — `memory.v2.enabled` is toggled via a per-test
+ * the real `getConfig` — `memory.v2.enabled` is toggled via a per-test
  * `config.json` fixture in the temp workspace. We mock only
  * `seedV2SkillEntries` so we can assert it was invoked without actually
  * embedding skills.
@@ -17,10 +17,10 @@ import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 import { Command } from "commander";
 
 import { invalidateConfigCache } from "../config/loader.js";
-import { getWorkspaceDir } from "../util/platform.js";
+import { getWorkspaceDir } from "../util/layout.js";
 
 // ---------------------------------------------------------------------------
-// Module-level mocks — kept minimal. `loadConfig` and `getLogger` use their
+// Module-level mocks — kept minimal. `getConfig` and `getLogger` use their
 // real implementations because we have first-class test hooks (a per-test
 // workspace `config.json` for config) that exercise the same code paths
 // the route handler runs in production.
@@ -106,7 +106,7 @@ async function runCommand(args: string[]): Promise<{ exitCode: number }> {
 
 /**
  * Override `memory.v2.enabled` (and any other config paths) by writing a
- * workspace `config.json` that the real `loadConfig` will pick up.
+ * workspace `config.json` that the real `getConfig` will pick up.
  */
 function writeWorkspaceConfig(json: Record<string, unknown>): void {
   const workspace = getWorkspaceDir();

package/src/__tests__/cloud-client-verify-credential.test.ts

@@ -9,10 +9,6 @@ let fetchImpl: (
 ) => Promise<Response> = async () => new Response("{}", { status: 200 });
 const fetchCalls: Array<{ url: string; init?: RequestInit }> = [];
 
-mock.module("../cloud/feature-gate.js", () => ({
-  areCloudFeaturesEnabled: () => true,
-}));
-
 mock.module("../providers/cloud-proxy/context.js", () => ({
   resolveCloudProxyContext: async () => ({
     enabled: true,

package/src/__tests__/cloud-credential-catalog-cli.test.ts

@@ -89,7 +89,7 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("returns empty descriptors when API key is missing", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.delete(ASSISTANT_API_KEY);
 
     const result = await fetchCloudCatalog();
@@ -98,7 +98,7 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("returns empty descriptors when assistant ID is missing", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.set(ASSISTANT_API_KEY, "sk-test-key");
     mockCloudAssistantId = "";
 
@@ -108,12 +108,12 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("parses platform catalog response into descriptors with correct handles", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.set(ASSISTANT_API_KEY, "sk-test-key");
     mockCloudAssistantId = "ast-uuid-1234";
 
     mockFetchResponses.set(
-      "https://platform.example.com/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
+      "https://test-cloud.mycadet.ai/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
       {
         status: 200,
         body: [
@@ -156,12 +156,12 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("handles empty connections list from platform", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.set(ASSISTANT_API_KEY, "sk-test-key");
     mockCloudAssistantId = "ast-uuid-1234";
 
     mockFetchResponses.set(
-      "https://platform.example.com/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
+      "https://test-cloud.mycadet.ai/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
       {
         status: 200,
         body: [],
@@ -174,12 +174,12 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("handles platform returning HTTP error gracefully", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.set(ASSISTANT_API_KEY, "sk-test-key");
     mockCloudAssistantId = "ast-uuid-1234";
 
     mockFetchResponses.set(
-      "https://platform.example.com/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
+      "https://test-cloud.mycadet.ai/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
       {
         status: 500,
         body: { detail: "Internal server error" },
@@ -193,12 +193,12 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("handles platform returning unexpected format gracefully", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.set(ASSISTANT_API_KEY, "sk-test-key");
     mockCloudAssistantId = "ast-uuid-1234";
 
     mockFetchResponses.set(
-      "https://platform.example.com/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
+      "https://test-cloud.mycadet.ai/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
       {
         status: 200,
         body: { unexpected: "shape" },
@@ -211,12 +211,12 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("defaults missing optional fields in catalog entries", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.set(ASSISTANT_API_KEY, "sk-test-key");
     mockCloudAssistantId = "ast-uuid-1234";
 
     mockFetchResponses.set(
-      "https://platform.example.com/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
+      "https://test-cloud.mycadet.ai/v1/assistants/ast-uuid-1234/oauth/managed/catalog/",
       {
         status: 200,
         body: [
@@ -242,7 +242,7 @@ describe("fetchCloudCatalog", () => {
   });
 
   test("error messages never contain sensitive details", async () => {
-    mockCloudBaseUrl = "https://platform.example.com";
+    mockCloudBaseUrl = "https://test-cloud.mycadet.ai";
     secureKeys.set(ASSISTANT_API_KEY, "sk-super-secret-key-12345");
     mockCloudAssistantId = "ast-uuid-1234";
 
@@ -251,7 +251,7 @@ describe("fetchCloudCatalog", () => {
     const errorFetch: typeof fetch = Object.assign(
       async () => {
         throw new Error(
-          "Connect failed to https://platform.example.com/v1/assistants/ast-uuid-1234/oauth/managed/catalog/ with Bearer sk-super-secret-key-12345",
+          "Connect failed to https://test-cloud.mycadet.ai/v1/assistants/ast-uuid-1234/oauth/managed/catalog/ with Bearer sk-super-secret-key-12345",
         );
       },
       { preconnect: savedFetch.preconnect },