@mycadet/assistant 0.12.9 → 0.12.11

package/src/__tests__/activation-early-marking.test.ts

@@ -1,114 +0,0 @@
-/**
- * Early activation-session marking.
- *
- * The agent loop resolves TOOLS before the SYSTEM PROMPT, so the activation
- * marker must be written before tool resolution on the first activation-rail
- * turn — otherwise the `activation` skill is not preactivated and the emit
- * handler is gated off for the very turn that emits Moment 1. The marking lives
- * in `applyBootstrapTemplate`, which is called from `setOnboardingContext` (the
- * earliest point the conversation knows its bootstrap selection) as well as
- * from `buildSystemPrompt` as an idempotent backstop.
- *
- * These tests exercise `applyBootstrapTemplate` directly against the real
- * DB-backed `isActivationSession` and a real workspace BOOTSTRAP.md, proving the
- * marker is set INDEPENDENT of any `buildSystemPrompt` render.
- */
-
-import { copyFileSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { beforeEach, describe, expect, test } from "bun:test";
-
-const TEST_DIR = process.env.CADET_WORKSPACE_DIR!;
-
-const { applyBootstrapTemplate } = await import("../prompts/system-prompt.js");
-const { isActivationSession } =
-  await import("../plugins/defaults/memory/activation-session-store.js");
-const { ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE } =
-  await import("../telemetry/activation-funnel.js");
-const { getMemorySqlite } = await import("../persistence/db-connection.js");
-const { initializeDb } = await import("../persistence/db-init.js");
-
-await initializeDb();
-
-/** Seed the workspace BOOTSTRAP.md with the unmodified generic template so the
- *  one-shot reseed inside `applyBootstrapTemplate` fires. */
-function seedGenericBootstrap(): void {
-  mkdirSync(TEST_DIR, { recursive: true });
-  const generic = readFileSync(
-    join(import.meta.dirname, "..", "prompts", "templates", "BOOTSTRAP.md"),
-    "utf-8",
-  );
-  writeFileSync(join(TEST_DIR, "BOOTSTRAP.md"), generic, "utf-8");
-}
-
-describe("applyBootstrapTemplate — early activation marking", () => {
-  beforeEach(() => {
-    getMemorySqlite()!.exec("DELETE FROM activation_sessions");
-  });
-
-  test("marks the conversation when the activation-rail template is applied", () => {
-    seedGenericBootstrap();
-    expect(isActivationSession("rail-conv")).toBe(false);
-
-    // No buildSystemPrompt call — marking must happen here.
-    applyBootstrapTemplate(ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE, "rail-conv");
-
-    expect(isActivationSession("rail-conv")).toBe(true);
-  });
-
-  test("does not mark when a non-rail bootstrap template is applied", () => {
-    seedGenericBootstrap();
-
-    applyBootstrapTemplate("BOOTSTRAP-REFERENCE.md", "non-rail-conv");
-
-    expect(isActivationSession("non-rail-conv")).toBe(false);
-  });
-
-  test("does not mark when no conversation id is supplied", () => {
-    seedGenericBootstrap();
-
-    applyBootstrapTemplate(ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE);
-
-    // Nothing to assert by id; confirm the table stayed empty.
-    const { n } = getMemorySqlite()!
-      .query("SELECT COUNT(*) AS n FROM activation_sessions")
-      .get() as { n: number };
-    expect(n).toBe(0);
-  });
-
-  test("does not mark when BOOTSTRAP.md is customized to something else", () => {
-    mkdirSync(TEST_DIR, { recursive: true });
-    // A user-customized BOOTSTRAP.md is neither the generic template (so the
-    // reseed no-ops) nor the activation-rail template — the rail is not active.
-    writeFileSync(
-      join(TEST_DIR, "BOOTSTRAP.md"),
-      "# My custom bootstrap\n",
-      "utf-8",
-    );
-
-    applyBootstrapTemplate(ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE, "custom-conv");
-
-    expect(isActivationSession("custom-conv")).toBe(false);
-  });
-
-  test("marks idempotently when BOOTSTRAP.md already holds the rail template", () => {
-    mkdirSync(TEST_DIR, { recursive: true });
-    // Simulate a later turn: BOOTSTRAP.md already holds the rail template, so
-    // the reseed no-ops but marking still fires (idempotent backstop).
-    copyFileSync(
-      join(
-        import.meta.dirname,
-        "..",
-        "prompts",
-        "templates",
-        ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE,
-      ),
-      join(TEST_DIR, "BOOTSTRAP.md"),
-    );
-
-    applyBootstrapTemplate(ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE, "rail-conv-2");
-    applyBootstrapTemplate(ACTIVATION_RAIL_BOOTSTRAP_TEMPLATE, "rail-conv-2");
-
-    expect(isActivationSession("rail-conv-2")).toBe(true);
-  });
-});

package/src/__tests__/auth-fallback-events-store.test.ts

@@ -1,99 +0,0 @@
-import { beforeEach, describe, expect, test } from "bun:test";
-
-import {
-  type AuthFallbackCount,
-  recordAuthFallbackCounts,
-} from "../security/auth-fallback-events-store.js";
-import {
-  pendingOutboxRows,
-  resetOutboxTable,
-  setShareAnalytics,
-  withTelemetryDbUnavailable,
-} from "../telemetry/__tests__/outbox-test-harness.js";
-import type { AuthFallbackTelemetryEvent } from "../telemetry/types.js";
-import { APP_VERSION } from "../version.js";
-
-const SAMPLE: AuthFallbackCount[] = [
-  {
-    guard: "edge",
-    path: "/v1/messages",
-    failureKind: "missing_authorization",
-    count: 7,
-  },
-  {
-    guard: "edge-scoped",
-    path: "/v1/files",
-    failureKind: "insufficient_scope",
-    count: 2,
-  },
-];
-
-describe("auth-fallback-events-store", () => {
-  beforeEach(() => {
-    setShareAnalytics(true);
-    resetOutboxTable();
-  });
-
-  test("records one outbox row per count entry with the full wire payload", () => {
-    const recorded = recordAuthFallbackCounts(1000, 2000, SAMPLE);
-    expect(recorded).toBe(2);
-
-    const rows = pendingOutboxRows("auth_fallback");
-    expect(rows.length).toBe(2);
-    const payloads = rows.map(
-      (r) => JSON.parse(r.payload) as AuthFallbackTelemetryEvent,
-    );
-    const byGuard = Object.fromEntries(payloads.map((p) => [p.guard, p]));
-    expect(byGuard["edge"]).toEqual({
-      type: "auth_fallback",
-      daemon_event_id: expect.any(String),
-      recorded_at: expect.any(Number),
-      guard: "edge",
-      path: "/v1/messages",
-      failure_kind: "missing_authorization",
-      count: 7,
-      window_start: 1000,
-      window_end: 2000,
-      assistant_version: APP_VERSION,
-    });
-    expect(byGuard["edge-scoped"]).toMatchObject({
-      path: "/v1/files",
-      failure_kind: "insufficient_scope",
-      count: 2,
-    });
-    // The wire daemon_event_id matches the outbox row id, and recorded_at
-    // matches the row's created_at (record-time stamping).
-    rows.forEach((row, i) => {
-      expect(payloads[i].daemon_event_id).toBe(row.id);
-      expect(payloads[i].recorded_at).toBe(row.createdAt);
-    });
-  });
-
-  test("honors a confirmed share_analytics opt-out (records nothing)", () => {
-    setShareAnalytics(false);
-    const recorded = recordAuthFallbackCounts(1000, 2000, SAMPLE);
-    expect(recorded).toBe(0);
-    expect(pendingOutboxRows("auth_fallback").length).toBe(0);
-  });
-
-  test("records while consent is unknown (a cold cache never drops data)", () => {
-    setShareAnalytics("unknown");
-    const recorded = recordAuthFallbackCounts(1000, 2000, SAMPLE);
-    expect(recorded).toBe(2);
-    expect(pendingOutboxRows("auth_fallback").length).toBe(2);
-  });
-
-  test("empty counts batch is a no-op", () => {
-    expect(recordAuthFallbackCounts(1000, 2000, [])).toBe(0);
-    expect(pendingOutboxRows("auth_fallback").length).toBe(0);
-  });
-
-  test("records all-or-nothing: db unavailable returns 0 with no rows", () => {
-    withTelemetryDbUnavailable(() => {
-      expect(recordAuthFallbackCounts(1000, 2000, SAMPLE)).toBe(0);
-    });
-    // No partial batch: the gateway's `recorded === 0` retry contract means
-    // any committed remnant would later double-count.
-    expect(pendingOutboxRows("auth_fallback").length).toBe(0);
-  });
-});

package/src/__tests__/config-get-vision-flag.test.ts

@@ -1,139 +0,0 @@
-/**
- * Verifies that `GET /v1/config` enriches each profile in `llm.profiles`
- * with `supportsVision` resolved from the model catalog.
- */
-
-import { describe, expect, mock, test } from "bun:test";
-
-// ---------------------------------------------------------------------------
-// Mocks for handleGetConfig's transitive deps
-// ---------------------------------------------------------------------------
-
-mock.module("../providers/registry.js", () => ({
-  initializeProviders: async () => {},
-}));
-
-mock.module("../persistence/embeddings/embedding-backend.js", () => ({
-  clearEmbeddingBackendCache: () => {},
-}));
-
-import { ROUTES } from "../runtime/routes/conversation-query-routes.js";
-import { setConfig } from "./helpers/set-config.js";
-
-const configGetRoute = ROUTES.find((r) => r.operationId === "config_get")!;
-
-/** Seed `llm.profiles` into the real workspace config the handler reads. */
-function seedProfiles(profiles: Record<string, unknown>): void {
-  setConfig("llm", { profiles });
-}
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-describe("GET /v1/config profile vision enrichment", () => {
-  test("profile with a non-vision model gets supportsVision: false", () => {
-    seedProfiles({
-      "test-no-vision": {
-        provider: "fireworks",
-        model: "accounts/fireworks/models/glm-5p3",
-      },
-    });
-
-    const result = configGetRoute.handler({}) as {
-      llm?: {
-        profiles?: Record<string, { supportsVision?: boolean }>;
-      };
-    };
-
-    expect(result?.llm?.profiles?.["test-no-vision"]?.supportsVision).toBe(
-      false,
-    );
-  });
-
-  test("profile with a vision-capable model gets supportsVision: true", () => {
-    seedProfiles({
-      "test-vision": {
-        provider: "anthropic",
-        model: "claude-opus-4-6",
-      },
-    });
-
-    const result = configGetRoute.handler({}) as {
-      llm?: {
-        profiles?: Record<string, { supportsVision?: boolean }>;
-      };
-    };
-
-    expect(result?.llm?.profiles?.["test-vision"]?.supportsVision).toBe(true);
-  });
-
-  test("profile with an unknown model defaults supportsVision to true (fail-open)", () => {
-    seedProfiles({
-      "test-unknown": {
-        provider: "anthropic",
-        model: "some-unknown-model-xyz",
-      },
-    });
-
-    const result = configGetRoute.handler({}) as {
-      llm?: {
-        profiles?: Record<string, { supportsVision?: boolean }>;
-      };
-    };
-
-    expect(result?.llm?.profiles?.["test-unknown"]?.supportsVision).toBe(true);
-  });
-
-  test("an image modality override of supported:true stamps supportsVision true", () => {
-    seedProfiles({
-      gateway: {
-        provider: "openai-compatible",
-        model: "qwen2.5-vl",
-        inputModalities: { image: { enabled: true, supported: true } },
-      },
-    });
-
-    const result = configGetRoute.handler({}) as {
-      llm?: {
-        profiles?: Record<string, { supportsVision?: boolean }>;
-      };
-    };
-
-    expect(result?.llm?.profiles?.gateway?.supportsVision).toBe(true);
-  });
-
-  test("an image modality override of supported:false stamps supportsVision false", () => {
-    seedProfiles({
-      gateway: {
-        provider: "openai-compatible",
-        model: "qwen2.5-vl",
-        inputModalities: { image: { enabled: true, supported: false } },
-      },
-    });
-
-    const result = configGetRoute.handler({}) as {
-      llm?: {
-        profiles?: Record<string, { supportsVision?: boolean }>;
-      };
-    };
-
-    expect(result?.llm?.profiles?.gateway?.supportsVision).toBe(false);
-  });
-
-  test("profile without provider/model is left without supportsVision", () => {
-    seedProfiles({
-      "test-empty": {},
-    });
-
-    const result = configGetRoute.handler({}) as {
-      llm?: {
-        profiles?: Record<string, { supportsVision?: boolean }>;
-      };
-    };
-
-    expect(
-      result?.llm?.profiles?.["test-empty"]?.supportsVision,
-    ).toBeUndefined();
-  });
-});