@mycadet/assistant 0.12.9 → 0.12.11

package/src/__tests__/notification-guardian-path.test.ts

@@ -160,7 +160,6 @@ describe("ASK_GUARDIAN notification path", () => {
     ensureConversation(convId);
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: convId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -221,7 +220,6 @@ describe("ASK_GUARDIAN notification path", () => {
     };
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: convId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -265,7 +263,6 @@ describe("ASK_GUARDIAN notification path", () => {
     };
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: convId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -311,7 +308,6 @@ describe("ASK_GUARDIAN notification path", () => {
     };
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: convId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -342,7 +338,6 @@ describe("ASK_GUARDIAN notification path", () => {
     ensureConversation(convId);
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: convId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -375,7 +370,6 @@ describe("ASK_GUARDIAN notification path", () => {
     const sharedConvId = "conv-guardian-shared-thread";
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: convId,
       provider: "twilio",
       fromNumber: "+15550001111",
@@ -469,7 +463,6 @@ describe("ASK_GUARDIAN notification path", () => {
     };
 
     const session = createCallSession({
-      direction: "inbound",
       conversationId: convId,
       provider: "twilio",
       fromNumber: "+15550001111",

package/src/__tests__/onboarding-persona-write.test.ts

@@ -3,7 +3,7 @@
  *
  * The function writes a cloud `## Onboarding Context` section to the
  * guardian persona file (with a fallback chain). These tests stub
- * `util/platform.js` and `contacts/contact-store.js` to control the
+ * `util/layout.js` and `contacts/contact-store.js` to control the
  * write target and verify idempotency, fallback, and field omission.
  */
 

package/src/__tests__/openai-provider.test.ts

@@ -1369,13 +1369,13 @@ describe("custom baseURL initialization", () => {
 
   test("OpenAIProvider forwards a custom baseURL", () => {
     const managed = new OpenAIProvider("ast-key-123", "gpt-4o", {
-      baseURL: "https://platform.example.com/v1/runtime-proxy/openai",
+      baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/openai",
     });
 
     expect(managed.name).toBe("openai");
     expectOpenAIConstructorOptions({
       apiKey: "ast-key-123",
-      baseURL: "https://platform.example.com/v1/runtime-proxy/openai",
+      baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/openai",
       timeout: DEFAULT_SDK_TIMEOUT_MS,
     });
   });
@@ -1407,14 +1407,14 @@ describe("custom baseURL initialization", () => {
       "ast-key-123",
       "accounts/fireworks/models/llama-v3p1-70b-instruct",
       {
-        baseURL: "https://platform.example.com/v1/runtime-proxy/fireworks",
+        baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/fireworks",
       },
     );
 
     expect(managed.name).toBe("fireworks");
     expectOpenAIConstructorOptions({
       apiKey: "ast-key-123",
-      baseURL: "https://platform.example.com/v1/runtime-proxy/fireworks",
+      baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/fireworks",
       timeout: DEFAULT_SDK_TIMEOUT_MS,
     });
   });
@@ -1434,13 +1434,13 @@ describe("custom baseURL initialization", () => {
 
   test("OpenRouterProvider forwards a custom baseURL", () => {
     const managed = new OpenRouterProvider("ast-key-123", "openai/gpt-4o", {
-      baseURL: "https://platform.example.com/v1/runtime-proxy/openrouter",
+      baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/openrouter",
     });
 
     expect(managed.name).toBe("openrouter");
     expectOpenAIConstructorOptions({
       apiKey: "ast-key-123",
-      baseURL: "https://platform.example.com/v1/runtime-proxy/openrouter",
+      baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/openrouter",
       timeout: DEFAULT_SDK_TIMEOUT_MS,
     });
   });
@@ -1457,13 +1457,13 @@ describe("custom baseURL initialization", () => {
 
   test("MinimaxProvider forwards a custom baseURL", () => {
     const managed = new MinimaxProvider("ast-key-123", "MiniMax-M2.7", {
-      baseURL: "https://platform.example.com/v1/runtime-proxy/minimax",
+      baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/minimax",
     });
 
     expect(managed.name).toBe("minimax");
     expectOpenAIConstructorOptions({
       apiKey: "ast-key-123",
-      baseURL: "https://platform.example.com/v1/runtime-proxy/minimax",
+      baseURL: "https://test-cloud.mycadet.ai/v1/runtime-proxy/minimax",
       timeout: DEFAULT_SDK_TIMEOUT_MS,
     });
   });

package/src/__tests__/path-policy.test.ts

@@ -26,7 +26,7 @@ import {
   sandboxPolicyWithHostFallback,
   sandboxReadPolicy,
 } from "../tools/shared/filesystem/path-policy.js";
-import { getWorkspaceSkillsDir } from "../util/platform.js";
+import { getWorkspaceSkillsDir } from "../util/layout.js";
 
 // The classifier reads REAL roots: managed = the per-process workspace skills
 // dir (writable, from the test preload), bundled = the repo's bundled-skills

package/src/__tests__/persona-resolver.test.ts

@@ -3,7 +3,7 @@
  * `resolveGuardianPersonaPath` and `ensureGuardianPersonaFile`.
  *
  * The module under test reads/writes files under `getWorkspaceDir()`,
- * so these tests stub `util/platform.js` to point at an ephemeral temp
+ * so these tests stub `util/layout.js` to point at an ephemeral temp
  * directory and stub `contacts/contact-store.js` to control which
  * guardian (if any) is returned by the resolver.
  */

package/src/__tests__/plugin-app-serve-routes.test.ts

@@ -12,7 +12,7 @@ import type {
   RouteDefinition,
   RouteHandlerArgs,
 } from "../runtime/routes/types.js";
-import { getWorkspacePluginsDir } from "../util/platform.js";
+import { getWorkspacePluginsDir } from "../util/layout.js";
 
 let workspaceDir: string;
 

package/src/__tests__/plugin-effective-enabled-set.test.ts

@@ -50,7 +50,7 @@ import {
   resetPluginRegistryForTests,
 } from "../plugins/registry.js";
 import type { HookFunction, Plugin } from "../plugins/types.js";
-import { getWorkspacePluginsDir } from "../util/platform.js";
+import { getWorkspacePluginsDir } from "../util/layout.js";
 
 // Point the workspace at an empty temp dir so `getHooksFor` -> `getUserHooksFor`
 // finds no user-land plugins; the in-process hook tests then observe only the

package/src/__tests__/plugin-import-boundary-guard.test.ts

@@ -152,14 +152,13 @@ const BASELINE: Record<string, readonly string[]> = {
     "../../../../runtime/routes/types.js",
     "../../../../security/secret-scanner.js",
     "../../../../skills/catalog-cache.js",
-    "../../../../telemetry/watchdog-events-store.js",
     "../../../../tools/skills/delete-cloud.js",
     "../../../../util/json.js",
+    "../../../../util/layout.js",
     "../../../../util/logger.js",
-    "../../../../util/platform.js",
     "../../../api/remember-tool.js",
     "../../../channels/types.js",
-    "../../../config/cloud-rehydration.js",
+    "../../../config/cloud-identity.js",
     "../../../config/loader.js",
     "../../../config/memory-v3-gate.js",
     "../../../config/schema.js",
@@ -215,15 +214,14 @@ const BASELINE: Record<string, readonly string[]> = {
     "../../../runtime/capabilities.js",
     "../../../runtime/services/auto-analysis-guard.js",
     "../../../runtime/sync/resource-sync-events.js",
-    "../../../telemetry/watchdog-events-store.js",
     "../../../tools/registry.js",
     "../../../tools/types.js",
     "../../../types.js",
     "../../../util/abort-reasons.js",
     "../../../util/errors.js",
+    "../../../util/layout.js",
     "../../../util/log-redact.js",
     "../../../util/logger.js",
-    "../../../util/platform.js",
     "../../../util/process-liveness.js",
     "../../../util/promise-guard.js",
     "../../../util/retry.js",
@@ -277,7 +275,7 @@ const BASELINE: Record<string, readonly string[]> = {
     "../../../daemon/now-scratchpad.js",
     "../../../daemon/trust-context-types.js",
     "../../../daemon/trust-context.js",
-    "../../../util/platform.js",
+    "../../../util/layout.js",
     "../../types.js",
     "../injection-presence.js",
     "../injector-order.js",

package/src/__tests__/plugin-import-boundary-reverse-guard.test.ts

@@ -91,8 +91,6 @@ const BASELINE: Record<string, readonly string[]> = {
     "src/daemon/conversation-agent-loop-handlers.ts",
     "src/daemon/conversation-agent-loop.ts",
     "src/daemon/conversation-runtime-assembly.ts",
-    "src/daemon/conversation-surfaces.ts",
-    "src/daemon/conversation-tool-setup.ts",
     "src/daemon/conversation-turn-finalize.ts",
     "src/daemon/conversation.ts",
     "src/daemon/embedding-reconcile.ts",
@@ -103,7 +101,6 @@ const BASELINE: Record<string, readonly string[]> = {
     "src/permissions/checker.ts",
     "src/persistence/conversation-crud.ts",
     "src/persistence/steps.ts",
-    "src/prompts/system-prompt.ts",
     "src/runtime/routes/consolidation-routes.ts",
     "src/runtime/routes/conversation-query-routes.ts",
     "src/runtime/routes/conversation-routes.ts",

package/src/__tests__/provider-cloud-proxy-integration.test.ts

@@ -111,10 +111,6 @@ mock.module("../config/env.js", () => ({
 // credentials are seeded under their real credentialKey lookups.
 const secureKeys = useMemorySecureKeyMap();
 
-mock.module("../cloud/feature-gate.js", () => ({
-  areCloudFeaturesEnabled: () => true,
-}));
-
 import { LLMSchema } from "../config/schemas/llm.js";
 import type { ProvidersConfig } from "../providers/registry.js";
 import {
@@ -152,7 +148,7 @@ function makeProvidersConfig(
 // Helpers
 // ---------------------------------------------------------------------------
 
-const PLATFORM_BASE = "https://platform.example.com";
+const PLATFORM_BASE = "https://test-cloud.mycadet.ai";
 const MANAGED_API_KEY = "ast-managed-key-123";
 const PLATFORM_ASSISTANT_ID = "assistant-abc123";
 

package/src/__tests__/provider-connections-backfill.test.ts

@@ -79,7 +79,7 @@ test("managed mode still stamps cadet when no user connection exists", () => {
   expect(backfilledConnection("byok")).toBe("cadet");
 });
 
-test("managed-owned entries keep the cadet stamp even when a user connection exists", () => {
+test("cadet-provider entries take no connection stamp; user entries bind their own", () => {
   process.env.IS_CLOUD = "true";
   const created = createConnection(getDb(), {
     name: "anthropic-personal",
@@ -89,20 +89,18 @@ test("managed-owned entries keep the cadet stamp even when a user connection exi
   expect(created.ok).toBe(true);
   seedConfig({
     balanced: {
-      source: "managed",
-      provider: "anthropic",
+      provider: "cadet",
       model: "claude-sonnet-4-6",
     },
-    // Legacy seeders wrote canonical entries without `source` — still
-    // managed-owned (workspace migration 109's rule).
+    // A cadet-provider entry is managed-owned: the cadet stamp survives any
+    // user connection.
     "quality-optimized": {
-      provider: "anthropic",
+      provider: "cadet",
       model: "claude-opus-4-8",
     },
-    // An explicit user source on a canonical name is a shadow the user took
+    // A non-cadet provider on a canonical name is a shadow the user took
     // ownership of — the preference applies.
     "cost-optimized": {
-      source: "user",
       provider: "anthropic",
       model: "claude-haiku-4-5-20251001",
     },
@@ -111,8 +109,10 @@ test("managed-owned entries keep the cadet stamp even when a user connection exi
 
   runProviderConnectionsBackfill(getDb());
 
-  expect(backfilledConnection("balanced")).toBe("cadet");
-  expect(backfilledConnection("quality-optimized")).toBe("cadet");
+  // The cadet provider is its own routing identity — no connection stamp;
+  // dispatch resolves the row per-request.
+  expect(backfilledConnection("balanced")).toBeUndefined();
+  expect(backfilledConnection("quality-optimized")).toBeUndefined();
   expect(backfilledConnection("cost-optimized")).toBe("anthropic-personal");
   expect(backfilledConnection("byok")).toBe("anthropic-personal");
 });

package/src/__tests__/prune-old-conversations-job.test.ts

@@ -1,15 +1,11 @@
 import { beforeEach, describe, expect, test } from "bun:test";
 
 import type { AssistantConfig } from "../config/schema.js";
-import { getDb, getTelemetryDb } from "../persistence/db-connection.js";
+import { getDb } from "../persistence/db-connection.js";
 import { initializeDb } from "../persistence/db-init.js";
 import { pruneOldConversationsJob } from "../persistence/job-handlers/cleanup.js";
 import type { MemoryJob } from "../persistence/jobs-store.js";
-import {
-  conversations,
-  telemetryEvents,
-  toolInvocations,
-} from "../persistence/schema/index.js";
+import { conversations, toolInvocations } from "../persistence/schema/index.js";
 
 // Prune fires the `conversation-deleted` hook per pruned id; the memory
 // plugin's hook is what purges the relocated per-conversation tables. That
@@ -44,24 +40,9 @@ function seedConversation(id: string, updatedAt: number): void {
       createdAt: updatedAt,
     })
     .run();
-  // Pending conversation-scoped telemetry rows live in the telemetry_events
-  // outbox on the dedicated telemetry DB.
-  getTelemetryDb()!
-    .insert(telemetryEvents)
-    .values({
-      id: `te-${id}`,
-      name: "skill_loaded",
-      createdAt: updatedAt,
-      conversationId: id,
-      payload: "{}",
-    })
-    .run();
 }
 
-function countRows(conversationId: string): {
-  invocations: number;
-  telemetryRows: number;
-} {
+function countRows(conversationId: string): { invocations: number } {
   const db = getDb();
   return {
     invocations: db
@@ -69,31 +50,25 @@ function countRows(conversationId: string): {
       .from(toolInvocations)
       .all()
       .filter((r) => r.conversationId === conversationId).length,
-    telemetryRows: getTelemetryDb()!
-      .select()
-      .from(telemetryEvents)
-      .all()
-      .filter((r) => r.conversationId === conversationId).length,
   };
 }
 
 describe("pruneOldConversationsJob", () => {
   beforeEach(() => {
     const db = getDb();
-    getTelemetryDb()!.delete(telemetryEvents).run();
     db.delete(toolInvocations).run();
     db.delete(conversations).run();
   });
 
-  test("deletes non-cascading rows — including pending telemetry_events — for pruned conversations only", () => {
+  test("deletes non-cascading rows for pruned conversations only", () => {
     const staleUpdatedAt = Date.now() - 60 * 86_400_000;
     seedConversation(STALE_ID, staleUpdatedAt);
     seedConversation(FRESH_ID, Date.now());
 
     pruneOldConversationsJob(JOB, CONFIG);
 
-    expect(countRows(STALE_ID)).toEqual({ invocations: 0, telemetryRows: 0 });
-    expect(countRows(FRESH_ID)).toEqual({ invocations: 1, telemetryRows: 1 });
+    expect(countRows(STALE_ID)).toEqual({ invocations: 0 });
+    expect(countRows(FRESH_ID)).toEqual({ invocations: 1 });
     const remaining = getDb().select().from(conversations).all();
     expect(remaining.map((c) => c.id)).toEqual([FRESH_ID]);
   });

package/src/__tests__/resolve-app.test.ts

@@ -9,7 +9,7 @@ import { afterEach, beforeEach, describe, expect, test } from "bun:test";
 
 import { createApp } from "../apps/app-store.js";
 import { resolveAppQuery } from "../apps/resolve-app.js";
-import { getWorkspacePluginsDir } from "../util/platform.js";
+import { getWorkspacePluginsDir } from "../util/layout.js";
 
 let workspaceDir: string;
 let previousWorkspaceDir: string | undefined;

package/src/__tests__/run-due-schedules.test.ts

@@ -64,7 +64,7 @@ import {
   upsertDeclaredSchedule,
 } from "../schedule/schedule-store.js";
 import { runDueSchedulesOnce } from "../schedule/scheduler.js";
-import { getWorkspacePluginsDir } from "../util/platform.js";
+import { getWorkspacePluginsDir } from "../util/layout.js";
 import { setOverridesForTesting } from "./feature-flag-test-helpers.js";
 
 await initializeDb();

package/src/__tests__/scaffold-managed-skill-tool.test.ts

@@ -13,21 +13,6 @@ import type { SkillSource } from "../config/skills.js";
 const TEST_DIR = process.env.CADET_WORKSPACE_DIR!;
 const mockRefreshSkillCapabilityMemories = mock(() => {});
 
-const watchdogEvents: Array<{
-  checkName: string;
-  value?: number | null;
-  detail?: Record<string, unknown> | null;
-}> = [];
-mock.module("../telemetry/watchdog-events-store.js", () => ({
-  recordWatchdogEvent: (record: {
-    checkName: string;
-    value?: number | null;
-    detail?: Record<string, unknown> | null;
-  }) => {
-    watchdogEvents.push(record);
-  },
-}));
-
 mock.module("../daemon/skill-memory-refresh.js", () => ({
   refreshSkillCapabilityMemories: mockRefreshSkillCapabilityMemories,
 }));
@@ -150,7 +135,6 @@ beforeEach(() => {
   mockRefreshSkillCapabilityMemories.mockClear();
   skillCardJobUpserts = [];
   skillCardUpsertThrows = false;
-  watchdogEvents.length = 0;
   recordedUpdates = [];
 });
 
@@ -311,16 +295,6 @@ describe("scaffold_cloud_skill tool", () => {
     expect(skill).toBeDefined();
     expect(skill!.name).toBe("Test Skill");
     expect(mockRefreshSkillCapabilityMemories).toHaveBeenCalledTimes(1);
-
-    // A genuine create emits the central authoring counter, attributed to
-    // the user for a non-retrospective origin.
-    expect(watchdogEvents).toEqual([
-      {
-        checkName: "skill_authored",
-        value: 1,
-        detail: { authored_by: "user" },
-      },
-    ]);
   });
 
   test("accepts legacy add_to_index input without returning index metadata", async () => {
@@ -381,12 +355,6 @@ describe("scaffold_cloud_skill tool", () => {
       makeContext(),
     );
     expect(result3.isError).toBe(false);
-
-    // Only the original create counts — the overwrite refined an existing
-    // skill and must not emit a second authoring event.
-    expect(
-      watchdogEvents.filter((e) => e.checkName === "skill_authored"),
-    ).toHaveLength(1);
   });
 
   test("rejects missing required fields", async () => {
@@ -1031,15 +999,6 @@ describe("scaffold_cloud_skill tool", () => {
 
     expect(result.isError).toBe(false);
     expect(installMetaFor("retro-skill")?.author).toBe("assistant");
-    // The central authoring counter attributes the create to the
-    // retrospective.
-    expect(watchdogEvents).toEqual([
-      {
-        checkName: "skill_authored",
-        value: 1,
-        detail: { authored_by: "retrospective" },
-      },
-    ]);
   });
 
   test('tags author "user" for a normal (non-retrospective) scaffold', async () => {
@@ -1210,12 +1169,6 @@ describe("scaffold_cloud_skill tool", () => {
         ),
       ),
     ).toBe(true);
-
-    // Only the V1 create counts toward authoring — the V2 refinement of an
-    // existing skill emits no second event.
-    expect(
-      watchdogEvents.filter((e) => e.checkName === "skill_authored"),
-    ).toHaveLength(1);
   });
 
   // ── Conversation lineage (retrospective-authored skills) ───────────────────
@@ -1768,7 +1721,6 @@ describe("background skill update notification", () => {
       installedAt: new Date().toISOString(),
       author: "assistant",
     });
-    watchdogEvents.length = 0;
     skillCardJobUpserts = [];
     recordedUpdates = [];
     recordUpdateFails = false;
@@ -1869,11 +1821,6 @@ describe("background skill update notification", () => {
         "utf-8",
       ),
     ).toContain("Refined steps.");
-    expect(watchdogEvents).toContainEqual(
-      expect.objectContaining({
-        checkName: "skill_update_receipt_record_failed",
-      }),
-    );
   });
 
   test("the entry body is the pass's change_summary, so the receipt says what changed", async () => {

package/src/__tests__/schedule-routes.test.ts

@@ -89,7 +89,7 @@ import {
   listSchedules,
   upsertDeclaredSchedule,
 } from "../schedule/schedule-store.js";
-import { getWorkspacePluginsDir } from "../util/platform.js";
+import { getWorkspacePluginsDir } from "../util/layout.js";
 import { setOverridesForTesting } from "./feature-flag-test-helpers.js";
 
 await initializeDb();

package/src/__tests__/schedule-store.test.ts

@@ -52,7 +52,7 @@ import {
   upsertDeclaredSchedule,
 } from "../schedule/schedule-store.js";
 import { UserError } from "../util/errors.js";
-import { getWorkspacePluginsDir } from "../util/platform.js";
+import { getWorkspacePluginsDir } from "../util/layout.js";
 
 await initializeDb();
 

package/src/__tests__/secret-routes-cloud-proxy.test.ts

@@ -20,7 +20,7 @@ let providerRefreshCalls = 0;
 let identitySyncCalls = 0;
 let avatarSyncCalls = 0;
 
-const CLOUD_BASE_URL = "https://platform.example.com";
+const CLOUD_BASE_URL = "https://test-cloud.mycadet.ai";
 const ASSISTANT_API_KEY_PATH = credentialKey("cadet", "assistant_api_key");
 const MANAGED_PROVIDERS = [
   "anthropic",

package/src/__tests__/skill-load-plugin-scope.test.ts

@@ -13,7 +13,7 @@ import { join } from "node:path";
 import { beforeAll, describe, expect, test } from "bun:test";
 
 import { skillLoadTool } from "../tools/skills/load.js";
-import { getWorkspaceDir } from "../util/platform.js";
+import { getWorkspaceDir } from "../util/layout.js";
 
 function writeSkill(
   root: string,

package/src/__tests__/surface-completion-compaction-boundary.test.ts

@@ -9,7 +9,7 @@ import { getDb } from "../persistence/db-connection.js";
 import { initializeDb } from "../persistence/db-init.js";
 import { conversations, messages } from "../persistence/schema/index.js";
 import { findPersistedSurfaceState } from "../runtime/routes/surface-conversation-resolver.js";
-import { getDbPath } from "../util/platform.js";
+import { getDbPath } from "../util/layout.js";
 import { assertNotLiveDb } from "./assert-not-live-db.js";
 
 await initializeDb();

package/src/__tests__/tool-approval-handler.test.ts

@@ -106,7 +106,7 @@ const auditCalls = {
   prompted: [] as any[],
   decided: [] as any[],
 };
-mock.module("../telemetry/tool-audit.js", () => ({
+mock.module("../persistence/tool-audit.js", () => ({
   recordToolDenied: (e: any) => auditCalls.denied.push(e),
   recordToolError: (e: any) => auditCalls.error.push(e),
   recordToolExecuted: (e: any) => auditCalls.executed.push(e),