@devo-bmad-custom/agent-orchestration 1.0.0

package/src/bmb/workflows/workflow/steps-e/step-e-03-fix-validation.md

@@ -0,0 +1,254 @@
+---
+name: 'step-e-03-fix-validation'
+description: 'Systematically fix validation issues from validation report'
+
+# File References
+nextStepFile: './step-e-05-apply-edit.md'
+editPlan: '{bmb_creations_output_folder}/edit-plan-{workflow_name}.md'
+targetWorkflowPath: '{targetWorkflowPath}'
+validationReport: '{targetWorkflowPath}/validation-report-{workflow_name}.md'
+
+# Standards References
+architecture: '../data/architecture.md'
+stepFileRules: '../data/step-file-rules.md'
+frontmatterStandards: '../data/frontmatter-standards.md'
+menuHandlingStandards: '../data/menu-handling-standards.md'
+outputFormatStandards: '../data/output-format-standards.md'
+stepTypePatterns: '../data/step-type-patterns.md'
+---
+
+# Edit Step 3: Fix Validation Issues
+
+## STEP GOAL:
+
+Systematically fix all issues identified in the validation report, working through each issue with user approval and loading relevant standards.
+
+## MANDATORY EXECUTION RULES (READ FIRST):
+
+### Universal Rules:
+
+- 🛑 NEVER make changes without user approval
+- 📖 CRITICAL: Read the complete step file before taking any action
+- 📋 YOU ARE A FACILITATOR, not an autonomous editor
+- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
+
+### Step-Specific Rules:
+
+- 🎯 Focus on fixing validation issues systematically
+- 🚫 FORBIDDEN to skip issues or fix without approval
+- 💬 Explain each issue and proposed fix
+- 📋 Load relevant standards for each fix type
+
+## EXECUTION PROTOCOLS:
+
+- 🎯 Work through issues systematically
+- 💾 Document each fix in edit plan
+- 📖 Load appropriate standards for each issue type
+- 🚫 FORBIDDEN to proceed without user approval for each fix
+
+## CONTEXT BOUNDARIES:
+
+- Validation report provides list of issues
+- Edit plan documents fix goals
+- Focus: Fix each issue with standards adherence
+- This is systematic remediation, not creative editing
+
+## MANDATORY SEQUENCE
+
+**CRITICAL:** Follow this sequence exactly. Do not skip or shortcut.
+
+### 1. Read Context Files
+
+**Load these files first:**
+1. `{editPlan}` - Review fix goals
+2. `{validationReport}` - Get full list of issues
+
+### 2. Organize Issues by Type
+
+**From validation report, categorize issues:**
+
+| Issue Type | Standard File | Count |
+|------------|---------------|-------|
+| workflow.md violations | {architecture} | |
+| Step file structure | {stepFileRules} | |
+| Frontmatter issues | {frontmatterStandards} | |
+| Menu handling | {menuHandlingStandards} | |
+| Output format | {outputFormatStandards} | |
+| Step type issues | {stepTypePatterns} | |
+
+### 3. Work Through Issues Systematically
+
+**For EACH issue in order of severity (Critical → Warning):**
+
+#### A. Load Relevant Standard
+
+**Before proposing fix, load the relevant standard file:**
+- If workflow.md issue → Load {architecture}
+- If step file issue → Load {stepFileRules}
+- If frontmatter issue → Load {frontmatterStandards}
+- If menu issue → Load {menuHandlingStandards}
+- If output issue → Load {outputFormatStandards}
+- If step type issue → Load {stepTypePatterns}
+
+#### B. Explain the Issue
+
+"**Issue: [{issue type}] {file}:{location if applicable}**
+
+**What the validation found:**
+{Quote the validation finding}
+
+**Why this is a problem:**
+{Explain the impact based on the standard}
+
+**Standard reference:**
+{Cite the specific standard from the loaded file}"
+
+#### C. Propose Fix
+
+"**Proposed fix:**
+{Specific change needed}
+
+**This will:**
+- ✅ Fix the compliance issue
+- ✅ Align with: {specific standard}
+- ⚠️ Potential impact: {any side effects}
+
+**Should I apply this fix?**"
+
+#### D. Get User Approval
+
+Wait for user response:
+- **Yes/Y** - Apply the fix
+- **No/N** - Skip this issue (document why)
+- **Modify** - User suggests alternative approach
+- **Explain** - Provide more detail
+
+#### E. Apply Fix (If Approved)
+
+**Load the target file, make the change:**
+
+```markdown
+**Applying fix to: {file}**
+
+**Before:**
+{show relevant section}
+
+**After:**
+{show modified section}
+
+**Fix applied.** ✅"
+```
+
+**Update editPlan:**
+```markdown
+### Fixes Applied
+
+**[{issue type}]** {file}
+- ✅ Fixed: {description}
+- Standard: {standard reference}
+- User approved: Yes
+```
+
+### 4. Handle Skip/Modify Responses
+
+**IF user skips an issue:**
+
+"**Issue skipped.**
+
+Documenting in edit plan:
+- [{issue type}] {file} - SKIPPED per user request
+- Reason: {user's reason if provided}
+
+**Note:** This issue will remain in the validation report.
+
+Continue to next issue?"
+
+**IF user wants to modify the fix:**
+
+Discuss alternative approach, get agreement, then apply modified fix.
+
+### 5. After All Issues Complete
+
+**Present summary:**
+
+"**Validation Fix Summary:**
+
+**Total Issues Found:** {count}
+**Fixed:** {count}
+**Skipped:** {count}
+**Modified:** {count}
+
+**Remaining Issues:** {list any skipped or remaining warnings}
+
+**Files Modified:**
+- {file1}
+- {file2}
+- etc."
+
+### 6. Check for Direct Edit Goals
+
+**Load editPlan and check:**
+
+**IF edit plan includes direct change goals (beyond validation fixes):**
+
+"Your edit plan also includes direct changes. After we apply these validation fixes, we'll proceed to those changes."
+
+Update editPlan frontmatter:
+```yaml
+validationFixesComplete: true
+```
+
+Then route to {nextStepFile} for direct edits.
+
+**ELSE (no direct changes - validation fixes only):**
+
+"Validation fixes are complete! Would you like to:
+
+1. **[R]e-run validation** - Verify all fixes are working
+2. **[C]omplete** - Finish editing with these fixes
+3. **[M]ake additional changes** - Add more edits"
+
+#### Menu Handling Logic:
+
+- IF R: Run validation workflow, then return to this step
+- IF AR: Execute {project-root}/_bmad/core/tasks/review-adversarial-general.xml — pass the current editPlan (or plan document in context) as the content to review; display findings with recommendations; then redisplay this menu
+- IF C: Route to step-e-07-complete.md
+- IF M: Route to step-e-02-discover-edits.md
+- IF Any other: help user, then redisplay menu
+
+### 7. Present MENU OPTIONS (If Proceeding)
+
+Display: "**Validation Fixes Applied. Select an Option:** [AR] Adversarial Review [C] Continue"
+
+#### Menu Handling Logic:
+
+- IF AR: Execute {project-root}/_bmad/core/tasks/review-adversarial-general.xml — pass the current editPlan (or plan document in context) as the content to review; display findings with recommendations; then redisplay this menu
+- IF C: Update editPlan stepsCompleted, then load, read entirely, then execute appropriate next step
+- IF Any other: help user respond, then redisplay menu
+
+## CRITICAL STEP COMPLETION NOTE
+
+ONLY WHEN all validation issues are addressed (fixed, skipped, or documented) and user confirms, will you then route to the appropriate next step.
+
+---
+
+## 🚨 SYSTEM SUCCESS/FAILURE METRICS
+
+### ✅ SUCCESS:
+
+- All issues presented to user systematically
+- Relevant standards loaded for each issue
+- User approval obtained for each fix
+- Fixes applied correctly
+- Edit plan updated with all changes
+- Files properly modified
+
+### ❌ SYSTEM FAILURE:
+
+- Skipping issues without user approval
+- Not loading relevant standards
+- Making changes without user confirmation
+- Not documenting fixes in edit plan
+- Applying fixes incorrectly
+
+**Master Rule:** Work through issues systematically. Load standards for each issue type. Get explicit approval before applying any fix.

package/src/bmb/workflows/workflow/steps-e/step-e-04-direct-edit.md

@@ -0,0 +1,277 @@
+---
+name: 'step-e-04-direct-edit'
+description: 'Apply direct user-requested changes to workflow'
+
+# File References
+nextStepFile: './step-e-05-apply-edit.md'
+editPlan: '{bmb_creations_output_folder}/edit-plan-{workflow_name}.md'
+targetWorkflowPath: '{targetWorkflowPath}'
+
+# Standards References
+architecture: '../data/architecture.md'
+stepFileRules: '../data/step-file-rules.md'
+frontmatterStandards: '../data/frontmatter-standards.md'
+menuHandlingStandards: '../data/menu-handling-standards.md'
+outputFormatStandards: '../data/output-format-standards.md'
+stepTypePatterns: '../data/step-type-patterns.md'
+workflowTypeCriteria: '../data/workflow-type-criteria.md'
+inputDiscoveryStandards: '../data/input-discovery-standards.md'
+csvDataFileStandards: '../data/csv-data-file-standards.md'
+intentVsPrescriptive: '../data/intent-vs-prescriptive-spectrum.md'
+---
+
+# Edit Step 4: Direct Edit
+
+## STEP GOAL:
+
+Apply direct user-requested changes to the workflow, loading relevant standards and checking for non-compliance during editing.
+
+## MANDATORY EXECUTION RULES (READ FIRST):
+
+### Universal Rules:
+
+- 🛑 NEVER make changes without user approval
+- 📖 CRITICAL: Read the complete step file before taking any action
+- 📋 YOU ARE A FACILITATOR, not an autonomous editor
+- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
+
+### Step-Specific Rules:
+
+- 🎯 Focus on user-requested changes
+- 🚫 FORBIDDEN to make changes without approval
+- 💬 Check for non-compliance while editing
+- 📋 Load relevant standards for each change type
+
+## EXECUTION PROTOCOLS:
+
+- 🎯 Work through each requested change
+- 💾 Document each change in edit plan
+- 📖 Load appropriate standards for each change type
+- 🚫 IF non-compliance found: offer to fix before proceeding
+
+## CONTEXT BOUNDARIES:
+
+- Edit plan contains direct change goals
+- Focus: Apply user's requested changes
+- Must check for compliance issues during edits
+
+## MANDATORY SEQUENCE
+
+**CRITICAL:** Follow this sequence exactly. Do not skip or shortcut.
+
+### 1. Read Edit Plan
+
+**Load the editPlan:**
+Read `{editPlan}` to review direct change goals from step 2.
+
+### 2. For Each Direct Change Goal
+
+**Work through each change systematically:**
+
+#### A. Identify Change Type and Load Standards
+
+**For workflow.md changes:**
+- Load {architecture}
+
+**For step file changes:**
+- Load {stepFileRules}
+- Load {stepTypePatterns}
+- Load {intentVsPrescriptive}
+
+**For frontmatter changes:**
+- Load {frontmatterStandards}
+
+**For menu changes:**
+- Load {menuHandlingStandards}
+
+**For output/template changes:**
+- Load {outputFormatStandards}
+
+**For data file changes:**
+- Load {csvDataFileStandards}
+
+**For workflow type changes:**
+- Load {workflowTypeCriteria}
+
+**For discovery/input changes:**
+- Load {inputDiscoveryStandards}
+
+#### B. Load Target File and Check Compliance
+
+**Load the file to be edited and review against standards:**
+
+"**Loading: {filename}**
+**Standard: {standard file loaded}**
+
+**Checking file against standards before making your change...**"
+
+**IF NON-COMPLIANCE FOUND:**
+
+"**⚠️ Compliance Issue Detected**
+
+Before I apply your change, I noticed this file is not fully compliant with {standard}:
+
+**Issue:** {describe the non-compliance}
+
+**This could cause:** {explain impact}
+
+**Should I fix this compliance issue before applying your change?**
+
+1. **[F]ix first** - Fix compliance, then apply your change
+2. **[C]ontinue anyway** - Apply your change without fixing
+3. **[E]xplain more** - More details about the issue
+
+#### Menu Handling Logic:
+
+- IF F: Fix compliance first, then proceed to apply change
+- IF AR: Execute {project-root}/_bmad/core/tasks/review-adversarial-general.xml — pass the current editPlan (or plan document in context) as the content to review; display findings with recommendations; then redisplay this menu
+- IF C: Document user accepted risk, proceed with change
+- IF E: Provide more details, then redisplay menu
+- IF Any other: help user, then redisplay menu"
+
+**IF COMPLIANT:**
+
+"**File is compliant.** Proceeding with your change."
+
+#### C. Present Current State and Proposed Change
+
+"**Current state of: {filename}**
+
+{show relevant section}
+
+**Your requested change:**
+{summarize the change from edit plan}
+
+**Proposed modification:**
+{show how the change will be made}
+
+**Should I apply this change?**"
+
+Wait for user approval.
+
+#### D. Apply Change (If Approved)
+
+**Load the file, make the change:**
+
+```markdown
+**Applying change to: {filename}**
+
+**Before:**
+{show relevant section}
+
+**After:**
+{show modified section}
+
+**Change applied.** ✅"
+```
+
+**Update editPlan:**
+```markdown
+### Direct Changes Applied
+
+**[{change type}]** {filename}
+- ✅ Changed: {description}
+- User approved: Yes
+- Compliance check: Passed/Fixed/Accepted risk
+```
+
+### 3. Handle Common Change Patterns
+
+#### Adding a New Step
+
+1. Load {stepFileRules}, {stepTypePatterns}, {intentVsPrescriptive}
+2. Check existing step numbering
+3. Determine appropriate step type
+4. Create step file with proper structure
+5. Update nextStepFile references in adjacent steps
+6. Verify menu handling compliance
+
+#### Removing a Step
+
+1. Load {architecture}
+2. Check if step is referenced by other steps
+3. Update nextStepFile in previous step
+4. Confirm with user about impact
+5. Remove step file
+6. Verify no broken references
+
+#### Modifying workflow.md
+
+1. Load {architecture}
+2. Check for progressive disclosure compliance (no step listings!)
+3. Update goal/role/routing as requested
+4. Ensure last section is routing
+5. Verify frontmatter completeness
+
+#### Adding/Modifying Data Files
+
+1. Load {csvDataFileStandards}
+2. Check file size (warn if >500 lines)
+3. Verify CSV format if applicable
+4. Ensure proper headers
+5. Update step frontmatter references
+
+#### Adding/Modifying Templates
+
+1. Load {outputFormatStandards}
+2. Determine template type
+3. Ensure variable consistency
+4. Update step frontmatter references
+
+### 4. After All Changes Complete
+
+**Present summary:**
+
+"**Direct Edit Summary:**
+
+**Total Changes Requested:** {count}
+**Applied:** {count}
+**Skipped:** {count}
+**Modified:** {count}
+
+**Compliance Issues Found During Editing:** {count}
+- Fixed: {count}
+- User accepted risk: {count}
+
+**Files Modified:**
+- {file1}
+- {file2}
+- etc."
+
+### 5. Present MENU OPTIONS
+
+Display: "**Direct Edits Applied. Select an Option:** [AR] Adversarial Review [C] Continue"
+
+#### Menu Handling Logic:
+
+- IF AR: Execute {project-root}/_bmad/core/tasks/review-adversarial-general.xml — pass the current editPlan (or plan document in context) as the content to review; display findings with recommendations; then redisplay this menu
+- IF C: Update editPlan stepsCompleted, then load, read entirely, then execute {nextStepFile}
+- IF Any other: help user respond, then redisplay menu
+
+## CRITICAL STEP COMPLETION NOTE
+
+ONLY WHEN all direct changes are applied (or documented) and user confirms, will you then load and read fully `{nextStepFile}` to execute.
+
+---
+
+## 🚨 SYSTEM SUCCESS/FAILURE METRICS
+
+### ✅ SUCCESS:
+
+- All requested changes presented to user
+- Relevant standards loaded for each change
+- Compliance checked before each change
+- User approval obtained for each change
+- Non-compliance found and offered fix
+- Changes applied correctly
+- Edit plan updated
+
+### ❌ SYSTEM FAILURE:
+
+- Not loading relevant standards
+- Not checking compliance before editing
+- Making changes without user approval
+- Missing non-compliance issues
+- Not documenting changes
+
+**Master Rule:** Load standards for each change type. Check compliance BEFORE applying changes. Offer to fix non-compliance when found.

package/src/bmb/workflows/workflow/steps-e/step-e-05-apply-edit.md

@@ -0,0 +1,154 @@
+---
+name: 'step-e-05-apply-edit'
+description: 'Offer validation after edits, complete or continue editing'
+
+# File References
+nextStepFile: './step-e-06-validate-after.md'
+completeStep: './step-e-07-complete.md'
+editPlan: '{bmb_creations_output_folder}/edit-plan-{workflow_name}.md'
+targetWorkflowPath: '{targetWorkflowPath}'
+validationWorkflow: '../steps-v/step-01-validate.md'
+---
+
+# Edit Step 5: Post-Edit Options
+
+## STEP GOAL:
+
+Present options after edits are applied: run validation, make more edits, or complete.
+
+## MANDATORY EXECUTION RULES (READ FIRST):
+
+### Universal Rules:
+
+- 📖 CRITICAL: Read the complete step file before taking any action
+- 📋 YOU ARE A FACILITATOR, not an autonomous editor
+- ✅ YOU MUST ALWAYS SPEAK OUTPUT In your Agent communication style with the config `{communication_language}`
+
+### Step-Specific Rules:
+
+- 🎯 Focus on next steps after edits
+- 💬 Present clear options
+- 🚪 Route based on user choice
+
+## EXECUTION PROTOCOLS:
+
+- 🎯 Present post-edit options
+- 💾 Update edit plan if needed
+- 📖 Route to appropriate next step
+
+## CONTEXT BOUNDARIES:
+
+- Edits have been applied (validation fixes, direct changes, or both)
+- Focus: What's next?
+- This is a routing step
+
+## MANDATORY SEQUENCE
+
+**CRITICAL:** Follow this sequence exactly. Do not skip or shortcut.
+
+### 1. Read Edit Plan
+
+**Load the editPlan:**
+Read `{editPlan}` to understand what edits were applied.
+
+### 2. Present Edit Summary
+
+"**Edit Session Summary:**
+
+**Workflow:** {workflow_name}
+**Path:** {targetWorkflowPath}
+
+**Edits Applied:**
+{Summarize from edit plan}
+
+**Files Modified:**
+{List files changed}
+
+**Compliance Status:**
+{Any compliance issues found and fixed}
+
+---
+
+**What would you like to do next?**
+
+**[V]alidate** - Run comprehensive validation to verify all changes
+**[M]ore edits** - Make additional changes
+**[C]omplete** - Finish editing (without validation)
+**[R]eview changes** - See detailed change log"
+
+### 3. Menu Handling Logic
+
+- **IF V:** Load, read entirely, then execute {validationWorkflow}. After validation completes, return to this step.
+- **IF M:** Route to step-e-02-discover-edits.md for more changes
+- **IF C:** Load, read entirely, then execute {completeStep}
+- **IF R:** Present detailed edit log from editPlan, then redisplay this menu
+- **IF Any other:** help user respond, then redisplay menu
+
+### 4. Update Edit Plan (If Completing Without Validation)
+
+**IF user selects [C] Complete:**
+
+Update editPlan frontmatter:
+```yaml
+completionDate: '{current-date}'
+validationAfterEdit: skipped
+completionStatus: complete_without_validation
+```
+
+Document in editPlan:
+```markdown
+## Completion
+
+**Completed:** {current-date}
+**Validation:** Skipped per user request
+**Recommendation:** Run validation before using workflow in production
+```
+
+### 5. Handle Validation Return
+
+**IF validation was run and completed:**
+
+Load and review validation report. Present findings:
+
+"**Validation Complete:**
+
+**Overall Status:** {status}
+**New Issues:** {count}
+**Remaining Issues:** {count}
+
+**Would you like to:**
+
+1. **[F]ix new issues** - Return to fix-validation step
+2. **[M]ore edits** - Make additional changes
+3. **[C]omplete** - Finish with current validation status"
+
+#### Menu Handling Logic:
+
+- IF F: Route to step-e-03-fix-validation.md
+- IF M: Route to step-e-02-discover-edits.md
+- IF C: Load, read entirely, then execute {completeStep}
+- IF Any other: help user, then redisplay menu
+
+## CRITICAL STEP COMPLETION NOTE
+
+This is a routing step. Route user to appropriate next step based on their choice. Always offer validation before completing.
+
+---
+
+## 🚨 SYSTEM SUCCESS/FAILURE METRICS
+
+### ✅ SUCCESS:
+
+- Edit summary presented clearly
+- All options explained
+- User routed to appropriate next step
+- Validation offered before completion
+- Edit plan updated if completing
+
+### ❌ SYSTEM FAILURE:
+
+- Not offering validation
+- Routing to wrong step
+- Not updating edit plan when completing
+
+**Master Rule:** Always offer validation after edits. Route correctly based on user choice.