spikard 0.5.0 → 0.6.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (135) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE +1 -1
  3. data/README.md +674 -674
  4. data/ext/spikard_rb/Cargo.toml +17 -17
  5. data/ext/spikard_rb/extconf.rb +13 -10
  6. data/ext/spikard_rb/src/lib.rs +6 -6
  7. data/lib/spikard/app.rb +405 -405
  8. data/lib/spikard/background.rb +27 -27
  9. data/lib/spikard/config.rb +396 -396
  10. data/lib/spikard/converters.rb +13 -13
  11. data/lib/spikard/handler_wrapper.rb +113 -113
  12. data/lib/spikard/provide.rb +214 -214
  13. data/lib/spikard/response.rb +173 -173
  14. data/lib/spikard/schema.rb +243 -243
  15. data/lib/spikard/sse.rb +111 -111
  16. data/lib/spikard/streaming_response.rb +44 -44
  17. data/lib/spikard/testing.rb +256 -256
  18. data/lib/spikard/upload_file.rb +131 -131
  19. data/lib/spikard/version.rb +5 -5
  20. data/lib/spikard/websocket.rb +59 -59
  21. data/lib/spikard.rb +43 -43
  22. data/sig/spikard.rbs +366 -366
  23. data/vendor/crates/spikard-bindings-shared/Cargo.toml +63 -63
  24. data/vendor/crates/spikard-bindings-shared/examples/config_extraction.rs +132 -132
  25. data/vendor/crates/spikard-bindings-shared/src/config_extractor.rs +752 -752
  26. data/vendor/crates/spikard-bindings-shared/src/conversion_traits.rs +194 -194
  27. data/vendor/crates/spikard-bindings-shared/src/di_traits.rs +246 -246
  28. data/vendor/crates/spikard-bindings-shared/src/error_response.rs +401 -401
  29. data/vendor/crates/spikard-bindings-shared/src/handler_base.rs +238 -238
  30. data/vendor/crates/spikard-bindings-shared/src/lib.rs +24 -24
  31. data/vendor/crates/spikard-bindings-shared/src/lifecycle_base.rs +292 -292
  32. data/vendor/crates/spikard-bindings-shared/src/lifecycle_executor.rs +616 -616
  33. data/vendor/crates/spikard-bindings-shared/src/response_builder.rs +305 -305
  34. data/vendor/crates/spikard-bindings-shared/src/test_client_base.rs +248 -248
  35. data/vendor/crates/spikard-bindings-shared/src/validation_helpers.rs +351 -351
  36. data/vendor/crates/spikard-bindings-shared/tests/comprehensive_coverage.rs +454 -454
  37. data/vendor/crates/spikard-bindings-shared/tests/error_response_edge_cases.rs +383 -383
  38. data/vendor/crates/spikard-bindings-shared/tests/handler_base_integration.rs +280 -280
  39. data/vendor/crates/spikard-core/Cargo.toml +40 -40
  40. data/vendor/crates/spikard-core/src/bindings/mod.rs +3 -3
  41. data/vendor/crates/spikard-core/src/bindings/response.rs +133 -133
  42. data/vendor/crates/spikard-core/src/debug.rs +127 -127
  43. data/vendor/crates/spikard-core/src/di/container.rs +702 -702
  44. data/vendor/crates/spikard-core/src/di/dependency.rs +273 -273
  45. data/vendor/crates/spikard-core/src/di/error.rs +118 -118
  46. data/vendor/crates/spikard-core/src/di/factory.rs +534 -534
  47. data/vendor/crates/spikard-core/src/di/graph.rs +506 -506
  48. data/vendor/crates/spikard-core/src/di/mod.rs +192 -192
  49. data/vendor/crates/spikard-core/src/di/resolved.rs +405 -405
  50. data/vendor/crates/spikard-core/src/di/value.rs +281 -281
  51. data/vendor/crates/spikard-core/src/errors.rs +69 -69
  52. data/vendor/crates/spikard-core/src/http.rs +415 -415
  53. data/vendor/crates/spikard-core/src/lib.rs +29 -29
  54. data/vendor/crates/spikard-core/src/lifecycle.rs +1186 -1186
  55. data/vendor/crates/spikard-core/src/metadata.rs +389 -389
  56. data/vendor/crates/spikard-core/src/parameters.rs +2525 -2525
  57. data/vendor/crates/spikard-core/src/problem.rs +344 -344
  58. data/vendor/crates/spikard-core/src/request_data.rs +1154 -1154
  59. data/vendor/crates/spikard-core/src/router.rs +510 -510
  60. data/vendor/crates/spikard-core/src/schema_registry.rs +183 -183
  61. data/vendor/crates/spikard-core/src/type_hints.rs +304 -304
  62. data/vendor/crates/spikard-core/src/validation/error_mapper.rs +696 -688
  63. data/vendor/crates/spikard-core/src/validation/mod.rs +457 -457
  64. data/vendor/crates/spikard-http/Cargo.toml +62 -64
  65. data/vendor/crates/spikard-http/examples/sse-notifications.rs +148 -148
  66. data/vendor/crates/spikard-http/examples/websocket-chat.rs +92 -92
  67. data/vendor/crates/spikard-http/src/auth.rs +296 -296
  68. data/vendor/crates/spikard-http/src/background.rs +1860 -1860
  69. data/vendor/crates/spikard-http/src/bindings/mod.rs +3 -3
  70. data/vendor/crates/spikard-http/src/bindings/response.rs +1 -1
  71. data/vendor/crates/spikard-http/src/body_metadata.rs +8 -8
  72. data/vendor/crates/spikard-http/src/cors.rs +1005 -1005
  73. data/vendor/crates/spikard-http/src/debug.rs +128 -128
  74. data/vendor/crates/spikard-http/src/di_handler.rs +1668 -1668
  75. data/vendor/crates/spikard-http/src/handler_response.rs +901 -901
  76. data/vendor/crates/spikard-http/src/handler_trait.rs +838 -830
  77. data/vendor/crates/spikard-http/src/handler_trait_tests.rs +290 -290
  78. data/vendor/crates/spikard-http/src/lib.rs +534 -534
  79. data/vendor/crates/spikard-http/src/lifecycle/adapter.rs +230 -230
  80. data/vendor/crates/spikard-http/src/lifecycle.rs +1193 -1193
  81. data/vendor/crates/spikard-http/src/middleware/mod.rs +560 -540
  82. data/vendor/crates/spikard-http/src/middleware/multipart.rs +912 -912
  83. data/vendor/crates/spikard-http/src/middleware/urlencoded.rs +513 -513
  84. data/vendor/crates/spikard-http/src/middleware/validation.rs +768 -735
  85. data/vendor/crates/spikard-http/src/openapi/mod.rs +309 -309
  86. data/vendor/crates/spikard-http/src/openapi/parameter_extraction.rs +535 -535
  87. data/vendor/crates/spikard-http/src/openapi/schema_conversion.rs +1363 -1363
  88. data/vendor/crates/spikard-http/src/openapi/spec_generation.rs +665 -665
  89. data/vendor/crates/spikard-http/src/query_parser.rs +793 -793
  90. data/vendor/crates/spikard-http/src/response.rs +720 -720
  91. data/vendor/crates/spikard-http/src/server/handler.rs +1650 -1650
  92. data/vendor/crates/spikard-http/src/server/lifecycle_execution.rs +234 -234
  93. data/vendor/crates/spikard-http/src/server/mod.rs +1593 -1502
  94. data/vendor/crates/spikard-http/src/server/request_extraction.rs +789 -770
  95. data/vendor/crates/spikard-http/src/server/routing_factory.rs +629 -599
  96. data/vendor/crates/spikard-http/src/sse.rs +1409 -1409
  97. data/vendor/crates/spikard-http/src/testing/form.rs +52 -52
  98. data/vendor/crates/spikard-http/src/testing/multipart.rs +64 -60
  99. data/vendor/crates/spikard-http/src/testing/test_client.rs +311 -283
  100. data/vendor/crates/spikard-http/src/testing.rs +406 -377
  101. data/vendor/crates/spikard-http/src/websocket.rs +1404 -1375
  102. data/vendor/crates/spikard-http/tests/background_behavior.rs +832 -832
  103. data/vendor/crates/spikard-http/tests/common/handlers.rs +309 -309
  104. data/vendor/crates/spikard-http/tests/common/mod.rs +26 -26
  105. data/vendor/crates/spikard-http/tests/di_integration.rs +192 -192
  106. data/vendor/crates/spikard-http/tests/doc_snippets.rs +5 -5
  107. data/vendor/crates/spikard-http/tests/lifecycle_execution.rs +1093 -1093
  108. data/vendor/crates/spikard-http/tests/multipart_behavior.rs +656 -656
  109. data/vendor/crates/spikard-http/tests/server_config_builder.rs +314 -314
  110. data/vendor/crates/spikard-http/tests/sse_behavior.rs +620 -620
  111. data/vendor/crates/spikard-http/tests/websocket_behavior.rs +663 -663
  112. data/vendor/crates/spikard-rb/Cargo.toml +48 -48
  113. data/vendor/crates/spikard-rb/build.rs +199 -199
  114. data/vendor/crates/spikard-rb/src/background.rs +63 -63
  115. data/vendor/crates/spikard-rb/src/config/mod.rs +5 -5
  116. data/vendor/crates/spikard-rb/src/config/server_config.rs +285 -285
  117. data/vendor/crates/spikard-rb/src/conversion.rs +554 -554
  118. data/vendor/crates/spikard-rb/src/di/builder.rs +100 -100
  119. data/vendor/crates/spikard-rb/src/di/mod.rs +375 -375
  120. data/vendor/crates/spikard-rb/src/handler.rs +618 -618
  121. data/vendor/crates/spikard-rb/src/integration/mod.rs +3 -3
  122. data/vendor/crates/spikard-rb/src/lib.rs +1806 -1810
  123. data/vendor/crates/spikard-rb/src/lifecycle.rs +275 -275
  124. data/vendor/crates/spikard-rb/src/metadata/mod.rs +5 -5
  125. data/vendor/crates/spikard-rb/src/metadata/route_extraction.rs +442 -447
  126. data/vendor/crates/spikard-rb/src/runtime/mod.rs +5 -5
  127. data/vendor/crates/spikard-rb/src/runtime/server_runner.rs +324 -324
  128. data/vendor/crates/spikard-rb/src/server.rs +305 -308
  129. data/vendor/crates/spikard-rb/src/sse.rs +231 -231
  130. data/vendor/crates/spikard-rb/src/testing/client.rs +538 -551
  131. data/vendor/crates/spikard-rb/src/testing/mod.rs +7 -7
  132. data/vendor/crates/spikard-rb/src/testing/sse.rs +143 -143
  133. data/vendor/crates/spikard-rb/src/testing/websocket.rs +608 -635
  134. data/vendor/crates/spikard-rb/src/websocket.rs +377 -374
  135. metadata +15 -1
@@ -1,656 +1,656 @@
1
- #![allow(clippy::pedantic, clippy::nursery, clippy::all)]
2
- //! Behavioral tests for multipart form data handling in spikard-http
3
- //!
4
- //! These tests verify observable behavior of the multipart parser through real HTTP requests
5
- //! and response outcomes, not parsing internals. They test edge cases, error conditions,
6
- //! and unusual input patterns to ensure robust handling of form data.
7
-
8
- mod common;
9
-
10
- use axum::body::Body;
11
- use axum::extract::FromRequest;
12
- use axum::extract::Multipart;
13
- use axum::http::Request;
14
-
15
- /// Helper to create a multipart body with proper RFC 7578 formatting
16
- fn create_multipart_body(boundary: &str, parts: Vec<String>) -> Vec<u8> {
17
- let mut body = Vec::new();
18
- for part in parts {
19
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
20
- body.extend_from_slice(part.as_bytes());
21
- body.extend_from_slice(b"\r\n");
22
- }
23
- body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
24
- body
25
- }
26
-
27
- /// Test 1: Large file upload (>1MB) streaming behavior
28
- /// Verifies that large files are properly handled and marked as binary/streaming
29
- #[tokio::test]
30
- async fn test_large_file_upload_streaming_behavior() {
31
- let boundary = "multipart-boundary";
32
-
33
- let large_file_size = 1024 * 1024 + 512;
34
- let large_file_content: Vec<u8> = (0..large_file_size).map(|i| (i % 256) as u8).collect();
35
-
36
- let mut body = Vec::new();
37
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
38
- body.extend_from_slice(b"Content-Disposition: form-data; name=\"large_upload\"; filename=\"large_file.bin\"\r\nContent-Type: application/octet-stream\r\n\r\n");
39
- body.extend_from_slice(&large_file_content);
40
- body.extend_from_slice(b"\r\n");
41
- body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
42
-
43
- let request = Request::builder()
44
- .method("POST")
45
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
46
- .body(Body::from(body))
47
- .unwrap();
48
-
49
- let multipart = Multipart::from_request(request, &()).await.unwrap();
50
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
51
- .await
52
- .unwrap();
53
-
54
- let obj = result.as_object().unwrap();
55
- assert!(obj.contains_key("large_upload"));
56
-
57
- let file_obj = &obj["large_upload"];
58
-
59
- assert!(file_obj["filename"].is_string());
60
- assert_eq!(file_obj["filename"], "large_file.bin");
61
- assert!(file_obj["size"].is_number());
62
- assert_eq!(file_obj["size"], large_file_size);
63
-
64
- let content = file_obj["content"].as_str().unwrap();
65
- assert!(content.contains("<binary data"));
66
- assert!(content.contains("bytes"));
67
- }
68
-
69
- /// Test 2: Boundary string appearing in file data
70
- /// Verifies that boundary strings within file content don't break parsing
71
- #[tokio::test]
72
- async fn test_boundary_string_in_file_data() {
73
- let boundary = "boundary123";
74
-
75
- let file_content = "This file contains --boundary123 in the data\nBut it should not confuse the parser";
76
- let parts = vec![format!(
77
- "Content-Disposition: form-data; name=\"file\"; filename=\"tricky.txt\"\r\nContent-Type: text/plain\r\n\r\n{}",
78
- file_content
79
- )];
80
-
81
- let body = create_multipart_body(boundary, parts);
82
-
83
- let request = Request::builder()
84
- .method("POST")
85
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
86
- .body(Body::from(body))
87
- .unwrap();
88
-
89
- let multipart = Multipart::from_request(request, &()).await.unwrap();
90
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
91
- .await
92
- .unwrap();
93
-
94
- let obj = result.as_object().unwrap();
95
- assert!(obj.contains_key("file"));
96
-
97
- let returned_content = obj["file"]["content"].as_str().unwrap();
98
- assert_eq!(returned_content, file_content);
99
- assert!(returned_content.contains("--boundary123"));
100
- }
101
-
102
- /// Test 3: Mixed file and form field ordering
103
- /// Verifies that files and fields can be interleaved and all are captured correctly
104
- #[tokio::test]
105
- async fn test_mixed_file_and_form_field_ordering() {
106
- let boundary = "mixed-boundary";
107
- let parts = vec![
108
- "Content-Disposition: form-data; name=\"field1\"\r\n\r\nValue 1".to_string(),
109
- "Content-Disposition: form-data; name=\"upload1\"; filename=\"file1.txt\"\r\nContent-Type: text/plain\r\n\r\nFile 1 content".to_string(),
110
- "Content-Disposition: form-data; name=\"field2\"\r\n\r\nValue 2".to_string(),
111
- "Content-Disposition: form-data; name=\"upload2\"; filename=\"file2.txt\"\r\nContent-Type: text/plain\r\n\r\nFile 2 content".to_string(),
112
- "Content-Disposition: form-data; name=\"field3\"\r\n\r\nValue 3".to_string(),
113
- ];
114
-
115
- let body = create_multipart_body(boundary, parts);
116
-
117
- let request = Request::builder()
118
- .method("POST")
119
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
120
- .body(Body::from(body))
121
- .unwrap();
122
-
123
- let multipart = Multipart::from_request(request, &()).await.unwrap();
124
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
125
- .await
126
- .unwrap();
127
-
128
- let obj = result.as_object().unwrap();
129
-
130
- assert_eq!(obj["field1"], "Value 1");
131
- assert_eq!(obj["field2"], "Value 2");
132
- assert_eq!(obj["field3"], "Value 3");
133
-
134
- assert!(obj["upload1"].is_object());
135
- assert!(obj["upload2"].is_object());
136
- assert_eq!(obj["upload1"]["filename"], "file1.txt");
137
- assert_eq!(obj["upload2"]["filename"], "file2.txt");
138
- }
139
-
140
- /// Test 4: Invalid UTF-8 in text fields
141
- /// Verifies graceful handling of non-UTF8 data in text fields with lossy conversion
142
- #[tokio::test]
143
- async fn test_invalid_utf8_in_text_fields() {
144
- let boundary = "boundary123";
145
- let mut body = Vec::new();
146
-
147
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
148
- body.extend_from_slice(b"Content-Disposition: form-data; name=\"text_field\"\r\n\r\n");
149
-
150
- body.extend_from_slice(b"Valid UTF-8: ");
151
-
152
- body.extend_from_slice(&[0xFF, 0xFE, 0xFD]);
153
-
154
- body.extend_from_slice(b" and more valid");
155
-
156
- body.extend_from_slice(b"\r\n");
157
- body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
158
-
159
- let request = Request::builder()
160
- .method("POST")
161
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
162
- .body(Body::from(body))
163
- .unwrap();
164
-
165
- let multipart = Multipart::from_request(request, &()).await.unwrap();
166
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
167
- .await
168
- .unwrap();
169
-
170
- let obj = result.as_object().unwrap();
171
-
172
- assert!(obj.contains_key("text_field"));
173
- let text_value = obj["text_field"].as_str().unwrap();
174
-
175
- assert!(text_value.contains("Valid UTF-8:"));
176
- assert!(text_value.contains("and more valid"));
177
- }
178
-
179
- /// Test 5: Malformed multipart bodies (missing headers)
180
- /// Verifies that the parser handles structural errors gracefully
181
- #[tokio::test]
182
- async fn test_malformed_multipart_missing_content_disposition() {
183
- let boundary = "boundary123";
184
- let mut body = Vec::new();
185
-
186
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
187
- body.extend_from_slice(b"\r\n");
188
- body.extend_from_slice(b"orphaned content");
189
- body.extend_from_slice(b"\r\n");
190
- body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
191
-
192
- let request = Request::builder()
193
- .method("POST")
194
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
195
- .body(Body::from(body))
196
- .unwrap();
197
-
198
- let multipart = Multipart::from_request(request, &()).await.unwrap();
199
-
200
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart).await;
201
-
202
- if let Ok(parsed) = result {
203
- assert!(parsed.is_object());
204
- }
205
- }
206
-
207
- /// Test 6: Duplicate field names aggregation
208
- /// Verifies that multiple values with same field name are properly aggregated into arrays
209
- #[tokio::test]
210
- async fn test_duplicate_field_names_aggregation() {
211
- let boundary = "boundary123";
212
- let parts = vec![
213
- "Content-Disposition: form-data; name=\"tags\"\r\n\r\nrust".to_string(),
214
- "Content-Disposition: form-data; name=\"tags\"\r\n\r\nweb".to_string(),
215
- "Content-Disposition: form-data; name=\"tags\"\r\n\r\napi".to_string(),
216
- "Content-Disposition: form-data; name=\"tags\"\r\n\r\nserver".to_string(),
217
- ];
218
-
219
- let body = create_multipart_body(boundary, parts);
220
-
221
- let request = Request::builder()
222
- .method("POST")
223
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
224
- .body(Body::from(body))
225
- .unwrap();
226
-
227
- let multipart = Multipart::from_request(request, &()).await.unwrap();
228
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
229
- .await
230
- .unwrap();
231
-
232
- let obj = result.as_object().unwrap();
233
- assert!(obj.contains_key("tags"));
234
-
235
- let tags = &obj["tags"];
236
- assert!(
237
- tags.is_array(),
238
- "Multiple values with same name should be aggregated into array"
239
- );
240
-
241
- let tags_array = tags.as_array().unwrap();
242
- assert_eq!(tags_array.len(), 4, "All 4 tag values should be present");
243
- assert_eq!(tags_array[0], "rust");
244
- assert_eq!(tags_array[1], "web");
245
- assert_eq!(tags_array[2], "api");
246
- assert_eq!(tags_array[3], "server");
247
- }
248
-
249
- /// Test 7: Upload timeout behavior with streaming files
250
- /// Verifies that streaming large files doesn't cause handlers to timeout
251
- /// (Tests observable streaming behavior, not timeout mechanics)
252
- #[tokio::test]
253
- async fn test_large_streaming_file_completes() {
254
- let boundary = "stream-boundary";
255
-
256
- let streaming_file_size = 1024 * 1024 + 256 * 1024;
257
- let streaming_file: Vec<u8> = (0..streaming_file_size).map(|i| ((i >> 8) % 256) as u8).collect();
258
-
259
- let mut body = Vec::new();
260
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
261
- body.extend_from_slice(b"Content-Disposition: form-data; name=\"stream_upload\"; filename=\"stream.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
262
- body.extend_from_slice(&streaming_file);
263
- body.extend_from_slice(b"\r\n");
264
- body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
265
-
266
- let request = Request::builder()
267
- .method("POST")
268
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
269
- .body(Body::from(body))
270
- .unwrap();
271
-
272
- let multipart = Multipart::from_request(request, &()).await.unwrap();
273
-
274
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart).await;
275
-
276
- assert!(result.is_ok(), "Large streaming file should parse without timeout");
277
-
278
- let parsed = result.unwrap();
279
- let obj = parsed.as_object().unwrap();
280
- assert!(obj.contains_key("stream_upload"));
281
-
282
- assert_eq!(obj["stream_upload"]["size"], streaming_file_size);
283
- }
284
-
285
- /// Test 8: Multiple files with same field name
286
- /// Verifies that multiple file uploads with identical field names are aggregated correctly
287
- #[tokio::test]
288
- async fn test_multiple_file_uploads_same_field_name() {
289
- let boundary = "boundary123";
290
- let parts = vec![
291
- "Content-Disposition: form-data; name=\"attachments\"; filename=\"file1.txt\"\r\nContent-Type: text/plain\r\n\r\nFirst file content".to_string(),
292
- "Content-Disposition: form-data; name=\"attachments\"; filename=\"file2.txt\"\r\nContent-Type: text/plain\r\n\r\nSecond file content".to_string(),
293
- "Content-Disposition: form-data; name=\"attachments\"; filename=\"file3.txt\"\r\nContent-Type: text/plain\r\n\r\nThird file content".to_string(),
294
- ];
295
-
296
- let body = create_multipart_body(boundary, parts);
297
-
298
- let request = Request::builder()
299
- .method("POST")
300
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
301
- .body(Body::from(body))
302
- .unwrap();
303
-
304
- let multipart = Multipart::from_request(request, &()).await.unwrap();
305
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
306
- .await
307
- .unwrap();
308
-
309
- let obj = result.as_object().unwrap();
310
- assert!(obj.contains_key("attachments"));
311
-
312
- let attachments = &obj["attachments"];
313
- assert!(
314
- attachments.is_array(),
315
- "Multiple files with same name should be aggregated"
316
- );
317
-
318
- let files = attachments.as_array().unwrap();
319
- assert_eq!(files.len(), 3, "All 3 file uploads should be present");
320
-
321
- assert_eq!(files[0]["filename"], "file1.txt");
322
- assert_eq!(files[0]["content"], "First file content");
323
-
324
- assert_eq!(files[1]["filename"], "file2.txt");
325
- assert_eq!(files[1]["content"], "Second file content");
326
-
327
- assert_eq!(files[2]["filename"], "file3.txt");
328
- assert_eq!(files[2]["content"], "Third file content");
329
- }
330
-
331
- /// Test 9: Empty file upload
332
- /// Verifies that empty files are handled correctly
333
- #[tokio::test]
334
- async fn test_empty_file_upload() {
335
- let boundary = "boundary123";
336
- let parts = vec![
337
- "Content-Disposition: form-data; name=\"empty_file\"; filename=\"empty.txt\"\r\nContent-Type: text/plain\r\n\r\n".to_string(),
338
- ];
339
-
340
- let body = create_multipart_body(boundary, parts);
341
-
342
- let request = Request::builder()
343
- .method("POST")
344
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
345
- .body(Body::from(body))
346
- .unwrap();
347
-
348
- let multipart = Multipart::from_request(request, &()).await.unwrap();
349
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
350
- .await
351
- .unwrap();
352
-
353
- let obj = result.as_object().unwrap();
354
- assert!(obj.contains_key("empty_file"));
355
-
356
- let file_obj = &obj["empty_file"];
357
- assert_eq!(file_obj["size"], 0, "Empty file should have size 0");
358
- assert_eq!(file_obj["content"], "", "Empty file should have empty content");
359
- assert_eq!(file_obj["filename"], "empty.txt");
360
- }
361
-
362
- /// Test 10: File with binary null bytes
363
- /// Verifies that binary data with null bytes is preserved correctly
364
- #[tokio::test]
365
- async fn test_binary_file_with_null_bytes() {
366
- let boundary = "boundary123";
367
- let mut body = Vec::new();
368
-
369
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
370
- body.extend_from_slice(b"Content-Disposition: form-data; name=\"binary\"; filename=\"binary.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
371
-
372
- body.extend_from_slice(&[0x00, 0x01, 0x02, 0x03, 0xFF, 0xFE, 0xFD, 0xFC]);
373
-
374
- body.extend_from_slice(b"\r\n");
375
- body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
376
-
377
- let request = Request::builder()
378
- .method("POST")
379
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
380
- .body(Body::from(body))
381
- .unwrap();
382
-
383
- let multipart = Multipart::from_request(request, &()).await.unwrap();
384
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
385
- .await
386
- .unwrap();
387
-
388
- let obj = result.as_object().unwrap();
389
- assert!(obj.contains_key("binary"));
390
-
391
- let file_obj = &obj["binary"];
392
- assert_eq!(file_obj["size"], 8, "Binary file size should be 8 bytes");
393
- assert_eq!(file_obj["content_type"], "application/octet-stream");
394
- }
395
-
396
- /// Test 11: Mixed JSON and binary file uploads
397
- /// Verifies that JSON form fields are parsed while binary files are preserved
398
- #[tokio::test]
399
- async fn test_mixed_json_and_binary_files() {
400
- let boundary = "boundary123";
401
- let parts = vec![
402
- "Content-Disposition: form-data; name=\"metadata\"\r\n\r\n{\"version\":1,\"timestamp\":1234567890}".to_string(),
403
- "Content-Disposition: form-data; name=\"image\"; filename=\"photo.bin\"\r\nContent-Type: application/octet-stream\r\n\r\nBINARY_IMAGE_DATA_HERE".to_string(),
404
- "Content-Disposition: form-data; name=\"config\"\r\n\r\n[1,2,3,4,5]".to_string(),
405
- ];
406
-
407
- let body = create_multipart_body(boundary, parts);
408
-
409
- let request = Request::builder()
410
- .method("POST")
411
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
412
- .body(Body::from(body))
413
- .unwrap();
414
-
415
- let multipart = Multipart::from_request(request, &()).await.unwrap();
416
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
417
- .await
418
- .unwrap();
419
-
420
- let obj = result.as_object().unwrap();
421
-
422
- assert!(obj["metadata"].is_object());
423
- assert_eq!(obj["metadata"]["version"], 1);
424
-
425
- assert!(obj["config"].is_array());
426
- assert_eq!(obj["config"][0], 1);
427
- assert_eq!(obj["config"][4], 5);
428
-
429
- assert!(obj["image"].is_object());
430
- assert_eq!(obj["image"]["filename"], "photo.bin");
431
- assert_eq!(obj["image"]["content"], "BINARY_IMAGE_DATA_HERE");
432
- }
433
-
434
- /// Test 12: Very large field name
435
- /// Verifies that extremely long field names are handled correctly
436
- #[tokio::test]
437
- async fn test_very_large_field_name() {
438
- let boundary = "boundary123";
439
- let long_field_name = "field_".repeat(200);
440
- let parts = vec![format!(
441
- "Content-Disposition: form-data; name=\"{}\"\r\n\r\nvalue",
442
- long_field_name
443
- )];
444
-
445
- let body = create_multipart_body(boundary, parts);
446
-
447
- let request = Request::builder()
448
- .method("POST")
449
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
450
- .body(Body::from(body))
451
- .unwrap();
452
-
453
- let multipart = Multipart::from_request(request, &()).await.unwrap();
454
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
455
- .await
456
- .unwrap();
457
-
458
- let obj = result.as_object().unwrap();
459
- assert!(obj.contains_key(&long_field_name));
460
- assert_eq!(obj[&long_field_name], "value");
461
- }
462
-
463
- /// Test 13: Content-Type with charset parameter
464
- /// Verifies that Content-Type headers with parameters are preserved
465
- #[tokio::test]
466
- async fn test_content_type_with_charset_parameter() {
467
- let boundary = "boundary123";
468
- let parts = vec![
469
- "Content-Disposition: form-data; name=\"text_file\"; filename=\"utf8.txt\"\r\nContent-Type: text/plain; charset=utf-8\r\n\r\nUTF-8 encoded content: Ñ é ü".to_string(),
470
- ];
471
-
472
- let body = create_multipart_body(boundary, parts);
473
-
474
- let request = Request::builder()
475
- .method("POST")
476
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
477
- .body(Body::from(body))
478
- .unwrap();
479
-
480
- let multipart = Multipart::from_request(request, &()).await.unwrap();
481
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
482
- .await
483
- .unwrap();
484
-
485
- let obj = result.as_object().unwrap();
486
- let file_obj = &obj["text_file"];
487
-
488
- let content_type = file_obj["content_type"].as_str().unwrap();
489
- assert!(content_type.contains("text/plain"));
490
- }
491
-
492
- /// Test 14: CRLF line endings preservation in file content
493
- /// Verifies that CRLF sequences within file content are preserved
494
- #[tokio::test]
495
- async fn test_crlf_line_endings_in_file_content() {
496
- let boundary = "boundary123";
497
- let content_with_crlf = "Line 1\r\nLine 2\r\nLine 3\r\n";
498
- let parts = vec![format!(
499
- "Content-Disposition: form-data; name=\"multiline\"; filename=\"text.txt\"\r\nContent-Type: text/plain\r\n\r\n{}",
500
- content_with_crlf
501
- )];
502
-
503
- let body = create_multipart_body(boundary, parts);
504
-
505
- let request = Request::builder()
506
- .method("POST")
507
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
508
- .body(Body::from(body))
509
- .unwrap();
510
-
511
- let multipart = Multipart::from_request(request, &()).await.unwrap();
512
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
513
- .await
514
- .unwrap();
515
-
516
- let obj = result.as_object().unwrap();
517
- let file_content = obj["multiline"]["content"].as_str().unwrap();
518
-
519
- assert!(file_content.contains("Line 1\r\nLine 2"));
520
- }
521
-
522
- /// Test 15: File upload with default Content-Type when missing
523
- /// Verifies that missing Content-Type defaults to application/octet-stream
524
- #[tokio::test]
525
- async fn test_default_content_type_when_missing() {
526
- let boundary = "boundary123";
527
- let parts = vec![
528
- "Content-Disposition: form-data; name=\"no_type\"; filename=\"mystery.bin\"\r\n\r\nFile content without explicit type".to_string(),
529
- ];
530
-
531
- let body = create_multipart_body(boundary, parts);
532
-
533
- let request = Request::builder()
534
- .method("POST")
535
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
536
- .body(Body::from(body))
537
- .unwrap();
538
-
539
- let multipart = Multipart::from_request(request, &()).await.unwrap();
540
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
541
- .await
542
- .unwrap();
543
-
544
- let obj = result.as_object().unwrap();
545
- let file_obj = &obj["no_type"];
546
-
547
- assert_eq!(
548
- file_obj["content_type"], "application/octet-stream",
549
- "Missing Content-Type should default to application/octet-stream"
550
- );
551
- }
552
-
553
- /// Test 16: Unicode characters in filenames
554
- /// Verifies that Unicode filenames are properly handled and preserved
555
- #[tokio::test]
556
- async fn test_unicode_characters_in_filenames() {
557
- let boundary = "boundary123";
558
- let parts = vec![
559
- "Content-Disposition: form-data; name=\"file\"; filename=\"файл_文件_🎯.txt\"\r\nContent-Type: text/plain\r\n\r\nUnicode filename test".to_string(),
560
- ];
561
-
562
- let body = create_multipart_body(boundary, parts);
563
-
564
- let request = Request::builder()
565
- .method("POST")
566
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
567
- .body(Body::from(body))
568
- .unwrap();
569
-
570
- let multipart = Multipart::from_request(request, &()).await.unwrap();
571
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
572
- .await
573
- .unwrap();
574
-
575
- let obj = result.as_object().unwrap();
576
- let filename = obj["file"]["filename"].as_str().unwrap();
577
-
578
- assert!(filename.contains("файл"));
579
- assert!(filename.contains("文件"));
580
- }
581
-
582
- /// Test 17: All single-value fields when no duplicates
583
- /// Verifies that fields with single values are not converted to arrays
584
- #[tokio::test]
585
- async fn test_single_value_fields_not_arrays() {
586
- let boundary = "boundary123";
587
- let parts = vec![
588
- "Content-Disposition: form-data; name=\"username\"\r\n\r\njohn_doe".to_string(),
589
- "Content-Disposition: form-data; name=\"email\"\r\n\r\njohn@example.com".to_string(),
590
- "Content-Disposition: form-data; name=\"age\"\r\n\r\n30".to_string(),
591
- ];
592
-
593
- let body = create_multipart_body(boundary, parts);
594
-
595
- let request = Request::builder()
596
- .method("POST")
597
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
598
- .body(Body::from(body))
599
- .unwrap();
600
-
601
- let multipart = Multipart::from_request(request, &()).await.unwrap();
602
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
603
- .await
604
- .unwrap();
605
-
606
- let obj = result.as_object().unwrap();
607
-
608
- assert!(obj["username"].is_string());
609
- assert!(obj["email"].is_string());
610
- assert!(obj["age"].is_string());
611
- }
612
-
613
- /// Test 18: File around the 1MB streaming threshold
614
- /// Verifies correct handling at the boundary of streaming threshold
615
- #[tokio::test]
616
- async fn test_file_around_1mb_threshold() {
617
- let boundary = "boundary123";
618
-
619
- let small_file_size = 1024 * 1024 - 1024;
620
- let small_file: Vec<u8> = (0..small_file_size).map(|i| (i % 256) as u8).collect();
621
-
622
- let large_file_size = 1024 * 1024 + 512;
623
- let large_file: Vec<u8> = (0..large_file_size).map(|i| ((i >> 8) % 256) as u8).collect();
624
-
625
- let mut body = Vec::new();
626
-
627
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
628
- body.extend_from_slice(b"Content-Disposition: form-data; name=\"small\"; filename=\"small.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
629
- body.extend_from_slice(&small_file);
630
- body.extend_from_slice(b"\r\n");
631
-
632
- body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
633
- body.extend_from_slice(b"Content-Disposition: form-data; name=\"large\"; filename=\"large.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
634
- body.extend_from_slice(&large_file);
635
- body.extend_from_slice(b"\r\n");
636
-
637
- body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
638
-
639
- let request = Request::builder()
640
- .method("POST")
641
- .header("content-type", format!("multipart/form-data; boundary={}", boundary))
642
- .body(Body::from(body))
643
- .unwrap();
644
-
645
- let multipart = Multipart::from_request(request, &()).await.unwrap();
646
- let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
647
- .await
648
- .unwrap();
649
-
650
- let obj = result.as_object().unwrap();
651
-
652
- assert_eq!(obj["small"]["size"], small_file_size);
653
-
654
- let large_content = obj["large"]["content"].as_str().unwrap();
655
- assert!(large_content.contains("<binary data") || large_content.len() > 100);
656
- }
1
+ #![allow(clippy::pedantic, clippy::nursery, clippy::all)]
2
+ //! Behavioral tests for multipart form data handling in spikard-http
3
+ //!
4
+ //! These tests verify observable behavior of the multipart parser through real HTTP requests
5
+ //! and response outcomes, not parsing internals. They test edge cases, error conditions,
6
+ //! and unusual input patterns to ensure robust handling of form data.
7
+
8
+ mod common;
9
+
10
+ use axum::body::Body;
11
+ use axum::extract::FromRequest;
12
+ use axum::extract::Multipart;
13
+ use axum::http::Request;
14
+
15
+ /// Helper to create a multipart body with proper RFC 7578 formatting
16
+ fn create_multipart_body(boundary: &str, parts: Vec<String>) -> Vec<u8> {
17
+ let mut body = Vec::new();
18
+ for part in parts {
19
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
20
+ body.extend_from_slice(part.as_bytes());
21
+ body.extend_from_slice(b"\r\n");
22
+ }
23
+ body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
24
+ body
25
+ }
26
+
27
+ /// Test 1: Large file upload (>1MB) streaming behavior
28
+ /// Verifies that large files are properly handled and marked as binary/streaming
29
+ #[tokio::test]
30
+ async fn test_large_file_upload_streaming_behavior() {
31
+ let boundary = "multipart-boundary";
32
+
33
+ let large_file_size = 1024 * 1024 + 512;
34
+ let large_file_content: Vec<u8> = (0..large_file_size).map(|i| (i % 256) as u8).collect();
35
+
36
+ let mut body = Vec::new();
37
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
38
+ body.extend_from_slice(b"Content-Disposition: form-data; name=\"large_upload\"; filename=\"large_file.bin\"\r\nContent-Type: application/octet-stream\r\n\r\n");
39
+ body.extend_from_slice(&large_file_content);
40
+ body.extend_from_slice(b"\r\n");
41
+ body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
42
+
43
+ let request = Request::builder()
44
+ .method("POST")
45
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
46
+ .body(Body::from(body))
47
+ .unwrap();
48
+
49
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
50
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
51
+ .await
52
+ .unwrap();
53
+
54
+ let obj = result.as_object().unwrap();
55
+ assert!(obj.contains_key("large_upload"));
56
+
57
+ let file_obj = &obj["large_upload"];
58
+
59
+ assert!(file_obj["filename"].is_string());
60
+ assert_eq!(file_obj["filename"], "large_file.bin");
61
+ assert!(file_obj["size"].is_number());
62
+ assert_eq!(file_obj["size"], large_file_size);
63
+
64
+ let content = file_obj["content"].as_str().unwrap();
65
+ assert!(content.contains("<binary data"));
66
+ assert!(content.contains("bytes"));
67
+ }
68
+
69
+ /// Test 2: Boundary string appearing in file data
70
+ /// Verifies that boundary strings within file content don't break parsing
71
+ #[tokio::test]
72
+ async fn test_boundary_string_in_file_data() {
73
+ let boundary = "boundary123";
74
+
75
+ let file_content = "This file contains --boundary123 in the data\nBut it should not confuse the parser";
76
+ let parts = vec![format!(
77
+ "Content-Disposition: form-data; name=\"file\"; filename=\"tricky.txt\"\r\nContent-Type: text/plain\r\n\r\n{}",
78
+ file_content
79
+ )];
80
+
81
+ let body = create_multipart_body(boundary, parts);
82
+
83
+ let request = Request::builder()
84
+ .method("POST")
85
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
86
+ .body(Body::from(body))
87
+ .unwrap();
88
+
89
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
90
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
91
+ .await
92
+ .unwrap();
93
+
94
+ let obj = result.as_object().unwrap();
95
+ assert!(obj.contains_key("file"));
96
+
97
+ let returned_content = obj["file"]["content"].as_str().unwrap();
98
+ assert_eq!(returned_content, file_content);
99
+ assert!(returned_content.contains("--boundary123"));
100
+ }
101
+
102
+ /// Test 3: Mixed file and form field ordering
103
+ /// Verifies that files and fields can be interleaved and all are captured correctly
104
+ #[tokio::test]
105
+ async fn test_mixed_file_and_form_field_ordering() {
106
+ let boundary = "mixed-boundary";
107
+ let parts = vec![
108
+ "Content-Disposition: form-data; name=\"field1\"\r\n\r\nValue 1".to_string(),
109
+ "Content-Disposition: form-data; name=\"upload1\"; filename=\"file1.txt\"\r\nContent-Type: text/plain\r\n\r\nFile 1 content".to_string(),
110
+ "Content-Disposition: form-data; name=\"field2\"\r\n\r\nValue 2".to_string(),
111
+ "Content-Disposition: form-data; name=\"upload2\"; filename=\"file2.txt\"\r\nContent-Type: text/plain\r\n\r\nFile 2 content".to_string(),
112
+ "Content-Disposition: form-data; name=\"field3\"\r\n\r\nValue 3".to_string(),
113
+ ];
114
+
115
+ let body = create_multipart_body(boundary, parts);
116
+
117
+ let request = Request::builder()
118
+ .method("POST")
119
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
120
+ .body(Body::from(body))
121
+ .unwrap();
122
+
123
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
124
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
125
+ .await
126
+ .unwrap();
127
+
128
+ let obj = result.as_object().unwrap();
129
+
130
+ assert_eq!(obj["field1"], "Value 1");
131
+ assert_eq!(obj["field2"], "Value 2");
132
+ assert_eq!(obj["field3"], "Value 3");
133
+
134
+ assert!(obj["upload1"].is_object());
135
+ assert!(obj["upload2"].is_object());
136
+ assert_eq!(obj["upload1"]["filename"], "file1.txt");
137
+ assert_eq!(obj["upload2"]["filename"], "file2.txt");
138
+ }
139
+
140
+ /// Test 4: Invalid UTF-8 in text fields
141
+ /// Verifies graceful handling of non-UTF8 data in text fields with lossy conversion
142
+ #[tokio::test]
143
+ async fn test_invalid_utf8_in_text_fields() {
144
+ let boundary = "boundary123";
145
+ let mut body = Vec::new();
146
+
147
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
148
+ body.extend_from_slice(b"Content-Disposition: form-data; name=\"text_field\"\r\n\r\n");
149
+
150
+ body.extend_from_slice(b"Valid UTF-8: ");
151
+
152
+ body.extend_from_slice(&[0xFF, 0xFE, 0xFD]);
153
+
154
+ body.extend_from_slice(b" and more valid");
155
+
156
+ body.extend_from_slice(b"\r\n");
157
+ body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
158
+
159
+ let request = Request::builder()
160
+ .method("POST")
161
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
162
+ .body(Body::from(body))
163
+ .unwrap();
164
+
165
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
166
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
167
+ .await
168
+ .unwrap();
169
+
170
+ let obj = result.as_object().unwrap();
171
+
172
+ assert!(obj.contains_key("text_field"));
173
+ let text_value = obj["text_field"].as_str().unwrap();
174
+
175
+ assert!(text_value.contains("Valid UTF-8:"));
176
+ assert!(text_value.contains("and more valid"));
177
+ }
178
+
179
+ /// Test 5: Malformed multipart bodies (missing headers)
180
+ /// Verifies that the parser handles structural errors gracefully
181
+ #[tokio::test]
182
+ async fn test_malformed_multipart_missing_content_disposition() {
183
+ let boundary = "boundary123";
184
+ let mut body = Vec::new();
185
+
186
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
187
+ body.extend_from_slice(b"\r\n");
188
+ body.extend_from_slice(b"orphaned content");
189
+ body.extend_from_slice(b"\r\n");
190
+ body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
191
+
192
+ let request = Request::builder()
193
+ .method("POST")
194
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
195
+ .body(Body::from(body))
196
+ .unwrap();
197
+
198
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
199
+
200
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart).await;
201
+
202
+ if let Ok(parsed) = result {
203
+ assert!(parsed.is_object());
204
+ }
205
+ }
206
+
207
+ /// Test 6: Duplicate field names aggregation
208
+ /// Verifies that multiple values with same field name are properly aggregated into arrays
209
+ #[tokio::test]
210
+ async fn test_duplicate_field_names_aggregation() {
211
+ let boundary = "boundary123";
212
+ let parts = vec![
213
+ "Content-Disposition: form-data; name=\"tags\"\r\n\r\nrust".to_string(),
214
+ "Content-Disposition: form-data; name=\"tags\"\r\n\r\nweb".to_string(),
215
+ "Content-Disposition: form-data; name=\"tags\"\r\n\r\napi".to_string(),
216
+ "Content-Disposition: form-data; name=\"tags\"\r\n\r\nserver".to_string(),
217
+ ];
218
+
219
+ let body = create_multipart_body(boundary, parts);
220
+
221
+ let request = Request::builder()
222
+ .method("POST")
223
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
224
+ .body(Body::from(body))
225
+ .unwrap();
226
+
227
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
228
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
229
+ .await
230
+ .unwrap();
231
+
232
+ let obj = result.as_object().unwrap();
233
+ assert!(obj.contains_key("tags"));
234
+
235
+ let tags = &obj["tags"];
236
+ assert!(
237
+ tags.is_array(),
238
+ "Multiple values with same name should be aggregated into array"
239
+ );
240
+
241
+ let tags_array = tags.as_array().unwrap();
242
+ assert_eq!(tags_array.len(), 4, "All 4 tag values should be present");
243
+ assert_eq!(tags_array[0], "rust");
244
+ assert_eq!(tags_array[1], "web");
245
+ assert_eq!(tags_array[2], "api");
246
+ assert_eq!(tags_array[3], "server");
247
+ }
248
+
249
+ /// Test 7: Upload timeout behavior with streaming files
250
+ /// Verifies that streaming large files doesn't cause handlers to timeout
251
+ /// (Tests observable streaming behavior, not timeout mechanics)
252
+ #[tokio::test]
253
+ async fn test_large_streaming_file_completes() {
254
+ let boundary = "stream-boundary";
255
+
256
+ let streaming_file_size = 1024 * 1024 + 256 * 1024;
257
+ let streaming_file: Vec<u8> = (0..streaming_file_size).map(|i| ((i >> 8) % 256) as u8).collect();
258
+
259
+ let mut body = Vec::new();
260
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
261
+ body.extend_from_slice(b"Content-Disposition: form-data; name=\"stream_upload\"; filename=\"stream.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
262
+ body.extend_from_slice(&streaming_file);
263
+ body.extend_from_slice(b"\r\n");
264
+ body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
265
+
266
+ let request = Request::builder()
267
+ .method("POST")
268
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
269
+ .body(Body::from(body))
270
+ .unwrap();
271
+
272
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
273
+
274
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart).await;
275
+
276
+ assert!(result.is_ok(), "Large streaming file should parse without timeout");
277
+
278
+ let parsed = result.unwrap();
279
+ let obj = parsed.as_object().unwrap();
280
+ assert!(obj.contains_key("stream_upload"));
281
+
282
+ assert_eq!(obj["stream_upload"]["size"], streaming_file_size);
283
+ }
284
+
285
+ /// Test 8: Multiple files with same field name
286
+ /// Verifies that multiple file uploads with identical field names are aggregated correctly
287
+ #[tokio::test]
288
+ async fn test_multiple_file_uploads_same_field_name() {
289
+ let boundary = "boundary123";
290
+ let parts = vec![
291
+ "Content-Disposition: form-data; name=\"attachments\"; filename=\"file1.txt\"\r\nContent-Type: text/plain\r\n\r\nFirst file content".to_string(),
292
+ "Content-Disposition: form-data; name=\"attachments\"; filename=\"file2.txt\"\r\nContent-Type: text/plain\r\n\r\nSecond file content".to_string(),
293
+ "Content-Disposition: form-data; name=\"attachments\"; filename=\"file3.txt\"\r\nContent-Type: text/plain\r\n\r\nThird file content".to_string(),
294
+ ];
295
+
296
+ let body = create_multipart_body(boundary, parts);
297
+
298
+ let request = Request::builder()
299
+ .method("POST")
300
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
301
+ .body(Body::from(body))
302
+ .unwrap();
303
+
304
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
305
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
306
+ .await
307
+ .unwrap();
308
+
309
+ let obj = result.as_object().unwrap();
310
+ assert!(obj.contains_key("attachments"));
311
+
312
+ let attachments = &obj["attachments"];
313
+ assert!(
314
+ attachments.is_array(),
315
+ "Multiple files with same name should be aggregated"
316
+ );
317
+
318
+ let files = attachments.as_array().unwrap();
319
+ assert_eq!(files.len(), 3, "All 3 file uploads should be present");
320
+
321
+ assert_eq!(files[0]["filename"], "file1.txt");
322
+ assert_eq!(files[0]["content"], "First file content");
323
+
324
+ assert_eq!(files[1]["filename"], "file2.txt");
325
+ assert_eq!(files[1]["content"], "Second file content");
326
+
327
+ assert_eq!(files[2]["filename"], "file3.txt");
328
+ assert_eq!(files[2]["content"], "Third file content");
329
+ }
330
+
331
+ /// Test 9: Empty file upload
332
+ /// Verifies that empty files are handled correctly
333
+ #[tokio::test]
334
+ async fn test_empty_file_upload() {
335
+ let boundary = "boundary123";
336
+ let parts = vec![
337
+ "Content-Disposition: form-data; name=\"empty_file\"; filename=\"empty.txt\"\r\nContent-Type: text/plain\r\n\r\n".to_string(),
338
+ ];
339
+
340
+ let body = create_multipart_body(boundary, parts);
341
+
342
+ let request = Request::builder()
343
+ .method("POST")
344
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
345
+ .body(Body::from(body))
346
+ .unwrap();
347
+
348
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
349
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
350
+ .await
351
+ .unwrap();
352
+
353
+ let obj = result.as_object().unwrap();
354
+ assert!(obj.contains_key("empty_file"));
355
+
356
+ let file_obj = &obj["empty_file"];
357
+ assert_eq!(file_obj["size"], 0, "Empty file should have size 0");
358
+ assert_eq!(file_obj["content"], "", "Empty file should have empty content");
359
+ assert_eq!(file_obj["filename"], "empty.txt");
360
+ }
361
+
362
+ /// Test 10: File with binary null bytes
363
+ /// Verifies that binary data with null bytes is preserved correctly
364
+ #[tokio::test]
365
+ async fn test_binary_file_with_null_bytes() {
366
+ let boundary = "boundary123";
367
+ let mut body = Vec::new();
368
+
369
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
370
+ body.extend_from_slice(b"Content-Disposition: form-data; name=\"binary\"; filename=\"binary.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
371
+
372
+ body.extend_from_slice(&[0x00, 0x01, 0x02, 0x03, 0xFF, 0xFE, 0xFD, 0xFC]);
373
+
374
+ body.extend_from_slice(b"\r\n");
375
+ body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
376
+
377
+ let request = Request::builder()
378
+ .method("POST")
379
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
380
+ .body(Body::from(body))
381
+ .unwrap();
382
+
383
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
384
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
385
+ .await
386
+ .unwrap();
387
+
388
+ let obj = result.as_object().unwrap();
389
+ assert!(obj.contains_key("binary"));
390
+
391
+ let file_obj = &obj["binary"];
392
+ assert_eq!(file_obj["size"], 8, "Binary file size should be 8 bytes");
393
+ assert_eq!(file_obj["content_type"], "application/octet-stream");
394
+ }
395
+
396
+ /// Test 11: Mixed JSON and binary file uploads
397
+ /// Verifies that JSON form fields are parsed while binary files are preserved
398
+ #[tokio::test]
399
+ async fn test_mixed_json_and_binary_files() {
400
+ let boundary = "boundary123";
401
+ let parts = vec![
402
+ "Content-Disposition: form-data; name=\"metadata\"\r\n\r\n{\"version\":1,\"timestamp\":1234567890}".to_string(),
403
+ "Content-Disposition: form-data; name=\"image\"; filename=\"photo.bin\"\r\nContent-Type: application/octet-stream\r\n\r\nBINARY_IMAGE_DATA_HERE".to_string(),
404
+ "Content-Disposition: form-data; name=\"config\"\r\n\r\n[1,2,3,4,5]".to_string(),
405
+ ];
406
+
407
+ let body = create_multipart_body(boundary, parts);
408
+
409
+ let request = Request::builder()
410
+ .method("POST")
411
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
412
+ .body(Body::from(body))
413
+ .unwrap();
414
+
415
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
416
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
417
+ .await
418
+ .unwrap();
419
+
420
+ let obj = result.as_object().unwrap();
421
+
422
+ assert!(obj["metadata"].is_object());
423
+ assert_eq!(obj["metadata"]["version"], 1);
424
+
425
+ assert!(obj["config"].is_array());
426
+ assert_eq!(obj["config"][0], 1);
427
+ assert_eq!(obj["config"][4], 5);
428
+
429
+ assert!(obj["image"].is_object());
430
+ assert_eq!(obj["image"]["filename"], "photo.bin");
431
+ assert_eq!(obj["image"]["content"], "BINARY_IMAGE_DATA_HERE");
432
+ }
433
+
434
+ /// Test 12: Very large field name
435
+ /// Verifies that extremely long field names are handled correctly
436
+ #[tokio::test]
437
+ async fn test_very_large_field_name() {
438
+ let boundary = "boundary123";
439
+ let long_field_name = "field_".repeat(200);
440
+ let parts = vec![format!(
441
+ "Content-Disposition: form-data; name=\"{}\"\r\n\r\nvalue",
442
+ long_field_name
443
+ )];
444
+
445
+ let body = create_multipart_body(boundary, parts);
446
+
447
+ let request = Request::builder()
448
+ .method("POST")
449
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
450
+ .body(Body::from(body))
451
+ .unwrap();
452
+
453
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
454
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
455
+ .await
456
+ .unwrap();
457
+
458
+ let obj = result.as_object().unwrap();
459
+ assert!(obj.contains_key(&long_field_name));
460
+ assert_eq!(obj[&long_field_name], "value");
461
+ }
462
+
463
+ /// Test 13: Content-Type with charset parameter
464
+ /// Verifies that Content-Type headers with parameters are preserved
465
+ #[tokio::test]
466
+ async fn test_content_type_with_charset_parameter() {
467
+ let boundary = "boundary123";
468
+ let parts = vec![
469
+ "Content-Disposition: form-data; name=\"text_file\"; filename=\"utf8.txt\"\r\nContent-Type: text/plain; charset=utf-8\r\n\r\nUTF-8 encoded content: Ñ é ü".to_string(),
470
+ ];
471
+
472
+ let body = create_multipart_body(boundary, parts);
473
+
474
+ let request = Request::builder()
475
+ .method("POST")
476
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
477
+ .body(Body::from(body))
478
+ .unwrap();
479
+
480
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
481
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
482
+ .await
483
+ .unwrap();
484
+
485
+ let obj = result.as_object().unwrap();
486
+ let file_obj = &obj["text_file"];
487
+
488
+ let content_type = file_obj["content_type"].as_str().unwrap();
489
+ assert!(content_type.contains("text/plain"));
490
+ }
491
+
492
+ /// Test 14: CRLF line endings preservation in file content
493
+ /// Verifies that CRLF sequences within file content are preserved
494
+ #[tokio::test]
495
+ async fn test_crlf_line_endings_in_file_content() {
496
+ let boundary = "boundary123";
497
+ let content_with_crlf = "Line 1\r\nLine 2\r\nLine 3\r\n";
498
+ let parts = vec![format!(
499
+ "Content-Disposition: form-data; name=\"multiline\"; filename=\"text.txt\"\r\nContent-Type: text/plain\r\n\r\n{}",
500
+ content_with_crlf
501
+ )];
502
+
503
+ let body = create_multipart_body(boundary, parts);
504
+
505
+ let request = Request::builder()
506
+ .method("POST")
507
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
508
+ .body(Body::from(body))
509
+ .unwrap();
510
+
511
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
512
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
513
+ .await
514
+ .unwrap();
515
+
516
+ let obj = result.as_object().unwrap();
517
+ let file_content = obj["multiline"]["content"].as_str().unwrap();
518
+
519
+ assert!(file_content.contains("Line 1\r\nLine 2"));
520
+ }
521
+
522
+ /// Test 15: File upload with default Content-Type when missing
523
+ /// Verifies that missing Content-Type defaults to application/octet-stream
524
+ #[tokio::test]
525
+ async fn test_default_content_type_when_missing() {
526
+ let boundary = "boundary123";
527
+ let parts = vec![
528
+ "Content-Disposition: form-data; name=\"no_type\"; filename=\"mystery.bin\"\r\n\r\nFile content without explicit type".to_string(),
529
+ ];
530
+
531
+ let body = create_multipart_body(boundary, parts);
532
+
533
+ let request = Request::builder()
534
+ .method("POST")
535
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
536
+ .body(Body::from(body))
537
+ .unwrap();
538
+
539
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
540
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
541
+ .await
542
+ .unwrap();
543
+
544
+ let obj = result.as_object().unwrap();
545
+ let file_obj = &obj["no_type"];
546
+
547
+ assert_eq!(
548
+ file_obj["content_type"], "application/octet-stream",
549
+ "Missing Content-Type should default to application/octet-stream"
550
+ );
551
+ }
552
+
553
+ /// Test 16: Unicode characters in filenames
554
+ /// Verifies that Unicode filenames are properly handled and preserved
555
+ #[tokio::test]
556
+ async fn test_unicode_characters_in_filenames() {
557
+ let boundary = "boundary123";
558
+ let parts = vec![
559
+ "Content-Disposition: form-data; name=\"file\"; filename=\"файл_文件_🎯.txt\"\r\nContent-Type: text/plain\r\n\r\nUnicode filename test".to_string(),
560
+ ];
561
+
562
+ let body = create_multipart_body(boundary, parts);
563
+
564
+ let request = Request::builder()
565
+ .method("POST")
566
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
567
+ .body(Body::from(body))
568
+ .unwrap();
569
+
570
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
571
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
572
+ .await
573
+ .unwrap();
574
+
575
+ let obj = result.as_object().unwrap();
576
+ let filename = obj["file"]["filename"].as_str().unwrap();
577
+
578
+ assert!(filename.contains("файл"));
579
+ assert!(filename.contains("文件"));
580
+ }
581
+
582
+ /// Test 17: All single-value fields when no duplicates
583
+ /// Verifies that fields with single values are not converted to arrays
584
+ #[tokio::test]
585
+ async fn test_single_value_fields_not_arrays() {
586
+ let boundary = "boundary123";
587
+ let parts = vec![
588
+ "Content-Disposition: form-data; name=\"username\"\r\n\r\njohn_doe".to_string(),
589
+ "Content-Disposition: form-data; name=\"email\"\r\n\r\njohn@example.com".to_string(),
590
+ "Content-Disposition: form-data; name=\"age\"\r\n\r\n30".to_string(),
591
+ ];
592
+
593
+ let body = create_multipart_body(boundary, parts);
594
+
595
+ let request = Request::builder()
596
+ .method("POST")
597
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
598
+ .body(Body::from(body))
599
+ .unwrap();
600
+
601
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
602
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
603
+ .await
604
+ .unwrap();
605
+
606
+ let obj = result.as_object().unwrap();
607
+
608
+ assert!(obj["username"].is_string());
609
+ assert!(obj["email"].is_string());
610
+ assert!(obj["age"].is_string());
611
+ }
612
+
613
+ /// Test 18: File around the 1MB streaming threshold
614
+ /// Verifies correct handling at the boundary of streaming threshold
615
+ #[tokio::test]
616
+ async fn test_file_around_1mb_threshold() {
617
+ let boundary = "boundary123";
618
+
619
+ let small_file_size = 1024 * 1024 - 1024;
620
+ let small_file: Vec<u8> = (0..small_file_size).map(|i| (i % 256) as u8).collect();
621
+
622
+ let large_file_size = 1024 * 1024 + 512;
623
+ let large_file: Vec<u8> = (0..large_file_size).map(|i| ((i >> 8) % 256) as u8).collect();
624
+
625
+ let mut body = Vec::new();
626
+
627
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
628
+ body.extend_from_slice(b"Content-Disposition: form-data; name=\"small\"; filename=\"small.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
629
+ body.extend_from_slice(&small_file);
630
+ body.extend_from_slice(b"\r\n");
631
+
632
+ body.extend_from_slice(format!("--{}\r\n", boundary).as_bytes());
633
+ body.extend_from_slice(b"Content-Disposition: form-data; name=\"large\"; filename=\"large.dat\"\r\nContent-Type: application/octet-stream\r\n\r\n");
634
+ body.extend_from_slice(&large_file);
635
+ body.extend_from_slice(b"\r\n");
636
+
637
+ body.extend_from_slice(format!("--{}--\r\n", boundary).as_bytes());
638
+
639
+ let request = Request::builder()
640
+ .method("POST")
641
+ .header("content-type", format!("multipart/form-data; boundary={}", boundary))
642
+ .body(Body::from(body))
643
+ .unwrap();
644
+
645
+ let multipart = Multipart::from_request(request, &()).await.unwrap();
646
+ let result = spikard_http::middleware::multipart::parse_multipart_to_json(multipart)
647
+ .await
648
+ .unwrap();
649
+
650
+ let obj = result.as_object().unwrap();
651
+
652
+ assert_eq!(obj["small"]["size"], small_file_size);
653
+
654
+ let large_content = obj["large"]["content"].as_str().unwrap();
655
+ assert!(large_content.contains("<binary data") || large_content.len() > 100);
656
+ }