spikard 0.5.0 → 0.6.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (135) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE +1 -1
  3. data/README.md +674 -674
  4. data/ext/spikard_rb/Cargo.toml +17 -17
  5. data/ext/spikard_rb/extconf.rb +13 -10
  6. data/ext/spikard_rb/src/lib.rs +6 -6
  7. data/lib/spikard/app.rb +405 -405
  8. data/lib/spikard/background.rb +27 -27
  9. data/lib/spikard/config.rb +396 -396
  10. data/lib/spikard/converters.rb +13 -13
  11. data/lib/spikard/handler_wrapper.rb +113 -113
  12. data/lib/spikard/provide.rb +214 -214
  13. data/lib/spikard/response.rb +173 -173
  14. data/lib/spikard/schema.rb +243 -243
  15. data/lib/spikard/sse.rb +111 -111
  16. data/lib/spikard/streaming_response.rb +44 -44
  17. data/lib/spikard/testing.rb +256 -256
  18. data/lib/spikard/upload_file.rb +131 -131
  19. data/lib/spikard/version.rb +5 -5
  20. data/lib/spikard/websocket.rb +59 -59
  21. data/lib/spikard.rb +43 -43
  22. data/sig/spikard.rbs +366 -366
  23. data/vendor/crates/spikard-bindings-shared/Cargo.toml +63 -63
  24. data/vendor/crates/spikard-bindings-shared/examples/config_extraction.rs +132 -132
  25. data/vendor/crates/spikard-bindings-shared/src/config_extractor.rs +752 -752
  26. data/vendor/crates/spikard-bindings-shared/src/conversion_traits.rs +194 -194
  27. data/vendor/crates/spikard-bindings-shared/src/di_traits.rs +246 -246
  28. data/vendor/crates/spikard-bindings-shared/src/error_response.rs +401 -401
  29. data/vendor/crates/spikard-bindings-shared/src/handler_base.rs +238 -238
  30. data/vendor/crates/spikard-bindings-shared/src/lib.rs +24 -24
  31. data/vendor/crates/spikard-bindings-shared/src/lifecycle_base.rs +292 -292
  32. data/vendor/crates/spikard-bindings-shared/src/lifecycle_executor.rs +616 -616
  33. data/vendor/crates/spikard-bindings-shared/src/response_builder.rs +305 -305
  34. data/vendor/crates/spikard-bindings-shared/src/test_client_base.rs +248 -248
  35. data/vendor/crates/spikard-bindings-shared/src/validation_helpers.rs +351 -351
  36. data/vendor/crates/spikard-bindings-shared/tests/comprehensive_coverage.rs +454 -454
  37. data/vendor/crates/spikard-bindings-shared/tests/error_response_edge_cases.rs +383 -383
  38. data/vendor/crates/spikard-bindings-shared/tests/handler_base_integration.rs +280 -280
  39. data/vendor/crates/spikard-core/Cargo.toml +40 -40
  40. data/vendor/crates/spikard-core/src/bindings/mod.rs +3 -3
  41. data/vendor/crates/spikard-core/src/bindings/response.rs +133 -133
  42. data/vendor/crates/spikard-core/src/debug.rs +127 -127
  43. data/vendor/crates/spikard-core/src/di/container.rs +702 -702
  44. data/vendor/crates/spikard-core/src/di/dependency.rs +273 -273
  45. data/vendor/crates/spikard-core/src/di/error.rs +118 -118
  46. data/vendor/crates/spikard-core/src/di/factory.rs +534 -534
  47. data/vendor/crates/spikard-core/src/di/graph.rs +506 -506
  48. data/vendor/crates/spikard-core/src/di/mod.rs +192 -192
  49. data/vendor/crates/spikard-core/src/di/resolved.rs +405 -405
  50. data/vendor/crates/spikard-core/src/di/value.rs +281 -281
  51. data/vendor/crates/spikard-core/src/errors.rs +69 -69
  52. data/vendor/crates/spikard-core/src/http.rs +415 -415
  53. data/vendor/crates/spikard-core/src/lib.rs +29 -29
  54. data/vendor/crates/spikard-core/src/lifecycle.rs +1186 -1186
  55. data/vendor/crates/spikard-core/src/metadata.rs +389 -389
  56. data/vendor/crates/spikard-core/src/parameters.rs +2525 -2525
  57. data/vendor/crates/spikard-core/src/problem.rs +344 -344
  58. data/vendor/crates/spikard-core/src/request_data.rs +1154 -1154
  59. data/vendor/crates/spikard-core/src/router.rs +510 -510
  60. data/vendor/crates/spikard-core/src/schema_registry.rs +183 -183
  61. data/vendor/crates/spikard-core/src/type_hints.rs +304 -304
  62. data/vendor/crates/spikard-core/src/validation/error_mapper.rs +696 -688
  63. data/vendor/crates/spikard-core/src/validation/mod.rs +457 -457
  64. data/vendor/crates/spikard-http/Cargo.toml +62 -64
  65. data/vendor/crates/spikard-http/examples/sse-notifications.rs +148 -148
  66. data/vendor/crates/spikard-http/examples/websocket-chat.rs +92 -92
  67. data/vendor/crates/spikard-http/src/auth.rs +296 -296
  68. data/vendor/crates/spikard-http/src/background.rs +1860 -1860
  69. data/vendor/crates/spikard-http/src/bindings/mod.rs +3 -3
  70. data/vendor/crates/spikard-http/src/bindings/response.rs +1 -1
  71. data/vendor/crates/spikard-http/src/body_metadata.rs +8 -8
  72. data/vendor/crates/spikard-http/src/cors.rs +1005 -1005
  73. data/vendor/crates/spikard-http/src/debug.rs +128 -128
  74. data/vendor/crates/spikard-http/src/di_handler.rs +1668 -1668
  75. data/vendor/crates/spikard-http/src/handler_response.rs +901 -901
  76. data/vendor/crates/spikard-http/src/handler_trait.rs +838 -830
  77. data/vendor/crates/spikard-http/src/handler_trait_tests.rs +290 -290
  78. data/vendor/crates/spikard-http/src/lib.rs +534 -534
  79. data/vendor/crates/spikard-http/src/lifecycle/adapter.rs +230 -230
  80. data/vendor/crates/spikard-http/src/lifecycle.rs +1193 -1193
  81. data/vendor/crates/spikard-http/src/middleware/mod.rs +560 -540
  82. data/vendor/crates/spikard-http/src/middleware/multipart.rs +912 -912
  83. data/vendor/crates/spikard-http/src/middleware/urlencoded.rs +513 -513
  84. data/vendor/crates/spikard-http/src/middleware/validation.rs +768 -735
  85. data/vendor/crates/spikard-http/src/openapi/mod.rs +309 -309
  86. data/vendor/crates/spikard-http/src/openapi/parameter_extraction.rs +535 -535
  87. data/vendor/crates/spikard-http/src/openapi/schema_conversion.rs +1363 -1363
  88. data/vendor/crates/spikard-http/src/openapi/spec_generation.rs +665 -665
  89. data/vendor/crates/spikard-http/src/query_parser.rs +793 -793
  90. data/vendor/crates/spikard-http/src/response.rs +720 -720
  91. data/vendor/crates/spikard-http/src/server/handler.rs +1650 -1650
  92. data/vendor/crates/spikard-http/src/server/lifecycle_execution.rs +234 -234
  93. data/vendor/crates/spikard-http/src/server/mod.rs +1593 -1502
  94. data/vendor/crates/spikard-http/src/server/request_extraction.rs +789 -770
  95. data/vendor/crates/spikard-http/src/server/routing_factory.rs +629 -599
  96. data/vendor/crates/spikard-http/src/sse.rs +1409 -1409
  97. data/vendor/crates/spikard-http/src/testing/form.rs +52 -52
  98. data/vendor/crates/spikard-http/src/testing/multipart.rs +64 -60
  99. data/vendor/crates/spikard-http/src/testing/test_client.rs +311 -283
  100. data/vendor/crates/spikard-http/src/testing.rs +406 -377
  101. data/vendor/crates/spikard-http/src/websocket.rs +1404 -1375
  102. data/vendor/crates/spikard-http/tests/background_behavior.rs +832 -832
  103. data/vendor/crates/spikard-http/tests/common/handlers.rs +309 -309
  104. data/vendor/crates/spikard-http/tests/common/mod.rs +26 -26
  105. data/vendor/crates/spikard-http/tests/di_integration.rs +192 -192
  106. data/vendor/crates/spikard-http/tests/doc_snippets.rs +5 -5
  107. data/vendor/crates/spikard-http/tests/lifecycle_execution.rs +1093 -1093
  108. data/vendor/crates/spikard-http/tests/multipart_behavior.rs +656 -656
  109. data/vendor/crates/spikard-http/tests/server_config_builder.rs +314 -314
  110. data/vendor/crates/spikard-http/tests/sse_behavior.rs +620 -620
  111. data/vendor/crates/spikard-http/tests/websocket_behavior.rs +663 -663
  112. data/vendor/crates/spikard-rb/Cargo.toml +48 -48
  113. data/vendor/crates/spikard-rb/build.rs +199 -199
  114. data/vendor/crates/spikard-rb/src/background.rs +63 -63
  115. data/vendor/crates/spikard-rb/src/config/mod.rs +5 -5
  116. data/vendor/crates/spikard-rb/src/config/server_config.rs +285 -285
  117. data/vendor/crates/spikard-rb/src/conversion.rs +554 -554
  118. data/vendor/crates/spikard-rb/src/di/builder.rs +100 -100
  119. data/vendor/crates/spikard-rb/src/di/mod.rs +375 -375
  120. data/vendor/crates/spikard-rb/src/handler.rs +618 -618
  121. data/vendor/crates/spikard-rb/src/integration/mod.rs +3 -3
  122. data/vendor/crates/spikard-rb/src/lib.rs +1806 -1810
  123. data/vendor/crates/spikard-rb/src/lifecycle.rs +275 -275
  124. data/vendor/crates/spikard-rb/src/metadata/mod.rs +5 -5
  125. data/vendor/crates/spikard-rb/src/metadata/route_extraction.rs +442 -447
  126. data/vendor/crates/spikard-rb/src/runtime/mod.rs +5 -5
  127. data/vendor/crates/spikard-rb/src/runtime/server_runner.rs +324 -324
  128. data/vendor/crates/spikard-rb/src/server.rs +305 -308
  129. data/vendor/crates/spikard-rb/src/sse.rs +231 -231
  130. data/vendor/crates/spikard-rb/src/testing/client.rs +538 -551
  131. data/vendor/crates/spikard-rb/src/testing/mod.rs +7 -7
  132. data/vendor/crates/spikard-rb/src/testing/sse.rs +143 -143
  133. data/vendor/crates/spikard-rb/src/testing/websocket.rs +608 -635
  134. data/vendor/crates/spikard-rb/src/websocket.rs +377 -374
  135. metadata +15 -1
@@ -1,1093 +1,1093 @@
1
- #![allow(clippy::pedantic, clippy::nursery, clippy::all)]
2
- //! Comprehensive tests for lifecycle hooks execution
3
- //!
4
- //! Tests the execute_with_lifecycle_hooks function covering:
5
- //! - No hooks and empty hooks fast path
6
- //! - Hook execution order and continuation
7
- //! - Short-circuit behavior
8
- //! - Error handling and onError transformation
9
- //! - Success path with onResponse
10
- //! - Response modifications
11
-
12
- mod common;
13
-
14
- use axum::body::Body;
15
- use axum::http::{Request, Response, StatusCode};
16
- use serde_json::json;
17
- use spikard_http::lifecycle::HookResult;
18
- use spikard_http::server::lifecycle_execution::execute_with_lifecycle_hooks;
19
- use spikard_http::{Handler, HandlerResult, RequestData};
20
- use std::collections::HashMap;
21
- use std::future::Future;
22
- use std::pin::Pin;
23
- use std::sync::Arc;
24
-
25
- /// Test request data factory
26
- fn test_request_data() -> RequestData {
27
- RequestData {
28
- path_params: Arc::new(HashMap::new()),
29
- query_params: serde_json::Value::Null,
30
- validated_params: None,
31
- raw_query_params: Arc::new(HashMap::new()),
32
- body: json!({"test": "data"}),
33
- raw_body: None,
34
- headers: Arc::new(HashMap::new()),
35
- cookies: Arc::new(HashMap::new()),
36
- method: "GET".to_string(),
37
- path: "/test".to_string(),
38
- #[cfg(feature = "di")]
39
- dependencies: None,
40
- }
41
- }
42
-
43
- /// Handler that returns 200 OK with custom body
44
- struct OkHandler;
45
-
46
- impl Handler for OkHandler {
47
- fn call(
48
- &self,
49
- _request: Request<Body>,
50
- _request_data: RequestData,
51
- ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
52
- Box::pin(async move {
53
- let response = Response::builder()
54
- .status(StatusCode::OK)
55
- .body(Body::from("OK"))
56
- .unwrap();
57
- Ok(response)
58
- })
59
- }
60
- }
61
-
62
- /// Handler that returns 400 Bad Request error
63
- struct BadRequestHandler;
64
-
65
- impl Handler for BadRequestHandler {
66
- fn call(
67
- &self,
68
- _request: Request<Body>,
69
- _request_data: RequestData,
70
- ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
71
- Box::pin(async move { Err((StatusCode::BAD_REQUEST, "{\"error\": \"Bad Request\"}".to_string())) })
72
- }
73
- }
74
-
75
- #[tokio::test]
76
- async fn test_no_hooks_none_variant() {
77
- let handler = Arc::new(OkHandler);
78
- let request = Request::builder().body(Body::empty()).unwrap();
79
- let request_data = test_request_data();
80
-
81
- let result = execute_with_lifecycle_hooks(request, request_data, handler, None).await;
82
-
83
- assert!(result.is_ok());
84
- let response = result.unwrap();
85
- assert_eq!(response.status(), StatusCode::OK);
86
- }
87
-
88
- #[tokio::test]
89
- async fn test_empty_hooks_list() {
90
- let handler = Arc::new(OkHandler);
91
- let request = Request::builder().body(Body::empty()).unwrap();
92
- let request_data = test_request_data();
93
- let hooks = Arc::new(spikard_http::lifecycle::LifecycleHooks::new());
94
-
95
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(hooks)).await;
96
-
97
- assert!(result.is_ok());
98
- let response = result.unwrap();
99
- assert_eq!(response.status(), StatusCode::OK);
100
- }
101
-
102
- #[tokio::test]
103
- async fn test_pre_validation_hook_continues() {
104
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
105
-
106
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
107
- "continue_hook",
108
- |req| async move { Ok(HookResult::Continue(req)) },
109
- ));
110
-
111
- let handler = Arc::new(OkHandler);
112
- let request = Request::builder().body(Body::empty()).unwrap();
113
- let request_data = test_request_data();
114
-
115
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
116
-
117
- assert!(result.is_ok());
118
- let response = result.unwrap();
119
- assert_eq!(response.status(), StatusCode::OK);
120
- }
121
-
122
- #[tokio::test]
123
- async fn test_pre_validation_hook_short_circuits() {
124
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
125
-
126
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
127
- "short_circuit",
128
- |_req| async move {
129
- let response = Response::builder()
130
- .status(StatusCode::UNAUTHORIZED)
131
- .body(Body::from("{\"error\": \"Unauthorized\"}"))
132
- .unwrap();
133
- Ok(HookResult::ShortCircuit(response))
134
- },
135
- ));
136
-
137
- let handler = Arc::new(OkHandler);
138
- let request = Request::builder().body(Body::empty()).unwrap();
139
- let request_data = test_request_data();
140
-
141
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
142
-
143
- assert!(result.is_ok());
144
- let response = result.unwrap();
145
- assert_eq!(response.status(), StatusCode::UNAUTHORIZED);
146
- }
147
-
148
- #[tokio::test]
149
- async fn test_pre_validation_hook_error_calls_on_error() {
150
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
151
-
152
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
153
- "failing_hook",
154
- |_req| async move { Err("Validation failed".to_string()) },
155
- ));
156
-
157
- hooks.add_on_error(spikard_http::lifecycle::response_hook(
158
- "error_handler",
159
- |mut resp| async move {
160
- resp.headers_mut()
161
- .insert("X-Error-Handled", axum::http::HeaderValue::from_static("true"));
162
- Ok(HookResult::Continue(resp))
163
- },
164
- ));
165
-
166
- let handler = Arc::new(OkHandler);
167
- let request = Request::builder().body(Body::empty()).unwrap();
168
- let request_data = test_request_data();
169
-
170
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
171
-
172
- assert!(result.is_ok());
173
- let response = result.unwrap();
174
- assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
175
- assert_eq!(
176
- response.headers().get("X-Error-Handled").map(|v| v.to_str().unwrap()),
177
- Some("true")
178
- );
179
- }
180
-
181
- #[tokio::test]
182
- async fn test_pre_handler_hook_continues() {
183
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
184
-
185
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
186
- "continue_hook",
187
- |req| async move { Ok(HookResult::Continue(req)) },
188
- ));
189
-
190
- let handler = Arc::new(OkHandler);
191
- let request = Request::builder().body(Body::empty()).unwrap();
192
- let request_data = test_request_data();
193
-
194
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
195
-
196
- assert!(result.is_ok());
197
- let response = result.unwrap();
198
- assert_eq!(response.status(), StatusCode::OK);
199
- }
200
-
201
- #[tokio::test]
202
- async fn test_pre_handler_hook_short_circuits() {
203
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
204
-
205
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
206
- "short_circuit",
207
- |_req| async move {
208
- let response = Response::builder()
209
- .status(StatusCode::FORBIDDEN)
210
- .body(Body::from("{\"error\": \"Forbidden\"}"))
211
- .unwrap();
212
- Ok(HookResult::ShortCircuit(response))
213
- },
214
- ));
215
-
216
- let handler = Arc::new(OkHandler);
217
- let request = Request::builder().body(Body::empty()).unwrap();
218
- let request_data = test_request_data();
219
-
220
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
221
-
222
- assert!(result.is_ok());
223
- let response = result.unwrap();
224
- assert_eq!(response.status(), StatusCode::FORBIDDEN);
225
- }
226
-
227
- #[tokio::test]
228
- async fn test_pre_handler_hook_error_calls_on_error() {
229
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
230
-
231
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
232
- "failing_hook",
233
- |_req| async move { Err("Handler preparation failed".to_string()) },
234
- ));
235
-
236
- hooks.add_on_error(spikard_http::lifecycle::response_hook(
237
- "error_handler",
238
- |mut resp| async move {
239
- resp.headers_mut()
240
- .insert("X-PreHandler-Error", axum::http::HeaderValue::from_static("caught"));
241
- Ok(HookResult::Continue(resp))
242
- },
243
- ));
244
-
245
- let handler = Arc::new(OkHandler);
246
- let request = Request::builder().body(Body::empty()).unwrap();
247
- let request_data = test_request_data();
248
-
249
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
250
-
251
- assert!(result.is_ok());
252
- let response = result.unwrap();
253
- assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
254
- assert_eq!(
255
- response
256
- .headers()
257
- .get("X-PreHandler-Error")
258
- .map(|v| v.to_str().unwrap()),
259
- Some("caught")
260
- );
261
- }
262
-
263
- #[tokio::test]
264
- async fn test_handler_error_calls_on_error() {
265
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
266
-
267
- hooks.add_on_error(spikard_http::lifecycle::response_hook(
268
- "error_logger",
269
- |mut resp| async move {
270
- resp.headers_mut()
271
- .insert("X-Handler-Error", axum::http::HeaderValue::from_static("logged"));
272
- Ok(HookResult::Continue(resp))
273
- },
274
- ));
275
-
276
- let handler = Arc::new(BadRequestHandler);
277
- let request = Request::builder().body(Body::empty()).unwrap();
278
- let request_data = test_request_data();
279
-
280
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
281
-
282
- assert!(result.is_ok());
283
- let response = result.unwrap();
284
- assert_eq!(response.status(), StatusCode::BAD_REQUEST);
285
- assert_eq!(
286
- response.headers().get("X-Handler-Error").map(|v| v.to_str().unwrap()),
287
- Some("logged")
288
- );
289
- }
290
-
291
- #[tokio::test]
292
- async fn test_success_handler_calls_on_response() {
293
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
294
-
295
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
296
- "response_modifier",
297
- |mut resp| async move {
298
- resp.headers_mut()
299
- .insert("X-Response-Modified", axum::http::HeaderValue::from_static("yes"));
300
- Ok(HookResult::Continue(resp))
301
- },
302
- ));
303
-
304
- let handler = Arc::new(OkHandler);
305
- let request = Request::builder().body(Body::empty()).unwrap();
306
- let request_data = test_request_data();
307
-
308
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
309
-
310
- assert!(result.is_ok());
311
- let response = result.unwrap();
312
- assert_eq!(response.status(), StatusCode::OK);
313
- assert_eq!(
314
- response
315
- .headers()
316
- .get("X-Response-Modified")
317
- .map(|v| v.to_str().unwrap()),
318
- Some("yes")
319
- );
320
- }
321
-
322
- #[tokio::test]
323
- async fn test_on_response_hook_error_returns_500() {
324
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
325
-
326
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
327
- "failing_response_hook",
328
- |_resp| async move { Err("Response processing failed".to_string()) },
329
- ));
330
-
331
- let handler = Arc::new(OkHandler);
332
- let request = Request::builder().body(Body::empty()).unwrap();
333
- let request_data = test_request_data();
334
-
335
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
336
-
337
- assert!(result.is_ok());
338
- let response = result.unwrap();
339
- assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
340
- }
341
-
342
- #[tokio::test]
343
- async fn test_on_error_hook_fails_fallback_500() {
344
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
345
-
346
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
347
- "failing_validation",
348
- |_req| async move { Err("Validation error".to_string()) },
349
- ));
350
-
351
- hooks.add_on_error(spikard_http::lifecycle::response_hook(
352
- "failing_error_hook",
353
- |_resp| async move { Err("Error hook failed".to_string()) },
354
- ));
355
-
356
- let handler = Arc::new(OkHandler);
357
- let request = Request::builder().body(Body::empty()).unwrap();
358
- let request_data = test_request_data();
359
-
360
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
361
-
362
- assert!(result.is_ok());
363
- let response = result.unwrap();
364
- assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
365
- }
366
-
367
- #[tokio::test]
368
- async fn test_hook_execution_order_preserved() {
369
- use std::sync::Mutex;
370
-
371
- let execution_log = Arc::new(Mutex::new(Vec::new()));
372
- let execution_log_clone1 = execution_log.clone();
373
- let execution_log_clone2 = execution_log.clone();
374
- let execution_log_clone3 = execution_log.clone();
375
-
376
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
377
-
378
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook("pre_validation", move |req| {
379
- let log = execution_log_clone1.clone();
380
- async move {
381
- log.lock().unwrap().push("pre_validation");
382
- Ok(HookResult::Continue(req))
383
- }
384
- }));
385
-
386
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook("pre_handler", move |req| {
387
- let log = execution_log_clone2.clone();
388
- async move {
389
- log.lock().unwrap().push("pre_handler");
390
- Ok(HookResult::Continue(req))
391
- }
392
- }));
393
-
394
- hooks.add_on_response(spikard_http::lifecycle::response_hook("on_response", move |resp| {
395
- let log = execution_log_clone3.clone();
396
- async move {
397
- log.lock().unwrap().push("on_response");
398
- Ok(HookResult::Continue(resp))
399
- }
400
- }));
401
-
402
- let handler = Arc::new(OkHandler);
403
- let request = Request::builder().body(Body::empty()).unwrap();
404
- let request_data = test_request_data();
405
-
406
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
407
-
408
- assert!(result.is_ok());
409
-
410
- let log = execution_log.lock().unwrap();
411
- assert_eq!(log.as_slice(), &["pre_validation", "pre_handler", "on_response"]);
412
- }
413
-
414
- #[tokio::test]
415
- async fn test_pre_validation_short_circuit_skips_handler_and_on_response() {
416
- use std::sync::Mutex;
417
-
418
- let handler_called = Arc::new(Mutex::new(false));
419
- let response_hook_called = Arc::new(Mutex::new(false));
420
-
421
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
422
-
423
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
424
- "short_circuit",
425
- |_req| async move {
426
- let response = Response::builder()
427
- .status(StatusCode::UNAUTHORIZED)
428
- .body(Body::from("Unauthorized"))
429
- .unwrap();
430
- Ok(HookResult::ShortCircuit(response))
431
- },
432
- ));
433
-
434
- let response_hook_called_clone = response_hook_called.clone();
435
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
436
- "response_tracker",
437
- move |resp| {
438
- let flag = response_hook_called_clone.clone();
439
- async move {
440
- *flag.lock().unwrap() = true;
441
- Ok(HookResult::Continue(resp))
442
- }
443
- },
444
- ));
445
-
446
- struct TrackingHandler {
447
- called: Arc<Mutex<bool>>,
448
- }
449
-
450
- impl Handler for TrackingHandler {
451
- fn call(
452
- &self,
453
- _request: Request<Body>,
454
- _request_data: RequestData,
455
- ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
456
- let called = self.called.clone();
457
- Box::pin(async move {
458
- *called.lock().unwrap() = true;
459
- let response = Response::builder()
460
- .status(StatusCode::OK)
461
- .body(Body::from("OK"))
462
- .unwrap();
463
- Ok(response)
464
- })
465
- }
466
- }
467
-
468
- let handler = Arc::new(TrackingHandler {
469
- called: handler_called.clone(),
470
- });
471
-
472
- let request = Request::builder().body(Body::empty()).unwrap();
473
- let request_data = test_request_data();
474
-
475
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
476
-
477
- assert!(result.is_ok());
478
- assert!(!*handler_called.lock().unwrap(), "Handler should not be called");
479
- assert!(
480
- !*response_hook_called.lock().unwrap(),
481
- "on_response should not be called"
482
- );
483
- }
484
-
485
- #[tokio::test]
486
- async fn test_multiple_hooks_same_phase_executed_in_order() {
487
- use std::sync::Mutex;
488
-
489
- let execution_log = Arc::new(Mutex::new(Vec::new()));
490
- let log1 = execution_log.clone();
491
- let log2 = execution_log.clone();
492
- let log3 = execution_log.clone();
493
-
494
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
495
-
496
- hooks.add_on_response(spikard_http::lifecycle::response_hook("first_hook", move |resp| {
497
- let log = log1.clone();
498
- async move {
499
- log.lock().unwrap().push("first");
500
- Ok(HookResult::Continue(resp))
501
- }
502
- }));
503
-
504
- hooks.add_on_response(spikard_http::lifecycle::response_hook("second_hook", move |resp| {
505
- let log = log2.clone();
506
- async move {
507
- log.lock().unwrap().push("second");
508
- Ok(HookResult::Continue(resp))
509
- }
510
- }));
511
-
512
- hooks.add_on_response(spikard_http::lifecycle::response_hook("third_hook", move |resp| {
513
- let log = log3.clone();
514
- async move {
515
- log.lock().unwrap().push("third");
516
- Ok(HookResult::Continue(resp))
517
- }
518
- }));
519
-
520
- let handler = Arc::new(OkHandler);
521
- let request = Request::builder().body(Body::empty()).unwrap();
522
- let request_data = test_request_data();
523
-
524
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
525
-
526
- assert!(result.is_ok());
527
-
528
- let log = execution_log.lock().unwrap();
529
- assert_eq!(log.as_slice(), &["first", "second", "third"]);
530
- }
531
-
532
- #[tokio::test]
533
- async fn test_hook_can_modify_request() {
534
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
535
-
536
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
537
- "add_header",
538
- |mut req| async move {
539
- req.headers_mut()
540
- .insert("X-Added-By-Hook", axum::http::HeaderValue::from_static("hook-value"));
541
- Ok(HookResult::Continue(req))
542
- },
543
- ));
544
-
545
- struct HeaderCheckHandler;
546
-
547
- impl Handler for HeaderCheckHandler {
548
- fn call(
549
- &self,
550
- request: Request<Body>,
551
- _request_data: RequestData,
552
- ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
553
- Box::pin(async move {
554
- let has_header = request.headers().contains_key("X-Added-By-Hook");
555
- let body = if has_header { "Header found" } else { "Header not found" };
556
-
557
- let response = Response::builder()
558
- .status(StatusCode::OK)
559
- .body(Body::from(body))
560
- .unwrap();
561
- Ok(response)
562
- })
563
- }
564
- }
565
-
566
- let handler = Arc::new(HeaderCheckHandler);
567
- let request = Request::builder().body(Body::empty()).unwrap();
568
- let request_data = test_request_data();
569
-
570
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
571
-
572
- assert!(result.is_ok());
573
- let response = result.unwrap();
574
- assert_eq!(response.status(), StatusCode::OK);
575
- }
576
-
577
- #[tokio::test]
578
- async fn test_error_response_contains_hook_error_message() {
579
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
580
-
581
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
582
- "failing_hook",
583
- |_req| async move { Err("Custom validation error".to_string()) },
584
- ));
585
-
586
- let handler = Arc::new(OkHandler);
587
- let request = Request::builder().body(Body::empty()).unwrap();
588
- let request_data = test_request_data();
589
-
590
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
591
-
592
- assert!(result.is_ok());
593
- let response = result.unwrap();
594
- assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
595
-
596
- let body_bytes = axum::body::to_bytes(response.into_body(), usize::MAX).await.unwrap();
597
- let body_str = String::from_utf8(body_bytes.to_vec()).unwrap();
598
- assert!(body_str.contains("Custom validation error"));
599
- }
600
-
601
- #[tokio::test]
602
- async fn test_chained_hook_modifications() {
603
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
604
-
605
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
606
- "add_header_1",
607
- |mut resp| async move {
608
- resp.headers_mut()
609
- .insert("X-Header-1", axum::http::HeaderValue::from_static("value1"));
610
- Ok(HookResult::Continue(resp))
611
- },
612
- ));
613
-
614
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
615
- "add_header_2",
616
- |mut resp| async move {
617
- resp.headers_mut()
618
- .insert("X-Header-2", axum::http::HeaderValue::from_static("value2"));
619
- Ok(HookResult::Continue(resp))
620
- },
621
- ));
622
-
623
- let handler = Arc::new(OkHandler);
624
- let request = Request::builder().body(Body::empty()).unwrap();
625
- let request_data = test_request_data();
626
-
627
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
628
-
629
- assert!(result.is_ok());
630
- let response = result.unwrap();
631
- assert_eq!(
632
- response.headers().get("X-Header-1").map(|v| v.to_str().unwrap()),
633
- Some("value1")
634
- );
635
- assert_eq!(
636
- response.headers().get("X-Header-2").map(|v| v.to_str().unwrap()),
637
- Some("value2")
638
- );
639
- }
640
-
641
- #[tokio::test]
642
- async fn test_on_response_not_called_when_handler_fails() {
643
- use std::sync::Mutex;
644
-
645
- let response_hook_called = Arc::new(Mutex::new(false));
646
- let response_hook_called_clone = response_hook_called.clone();
647
-
648
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
649
-
650
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
651
- "response_tracker",
652
- move |resp| {
653
- let flag = response_hook_called_clone.clone();
654
- async move {
655
- *flag.lock().unwrap() = true;
656
- Ok(HookResult::Continue(resp))
657
- }
658
- },
659
- ));
660
-
661
- let handler = Arc::new(BadRequestHandler);
662
- let request = Request::builder().body(Body::empty()).unwrap();
663
- let request_data = test_request_data();
664
-
665
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
666
-
667
- assert!(result.is_ok());
668
- assert!(
669
- !*response_hook_called.lock().unwrap(),
670
- "on_response should NOT be called when handler fails"
671
- );
672
- }
673
-
674
- #[tokio::test]
675
- async fn test_on_error_called_when_handler_fails() {
676
- use std::sync::Mutex;
677
-
678
- let error_hook_called = Arc::new(Mutex::new(false));
679
- let error_hook_called_clone = error_hook_called.clone();
680
-
681
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
682
-
683
- hooks.add_on_error(spikard_http::lifecycle::response_hook("error_tracker", move |resp| {
684
- let flag = error_hook_called_clone.clone();
685
- async move {
686
- *flag.lock().unwrap() = true;
687
- Ok(HookResult::Continue(resp))
688
- }
689
- }));
690
-
691
- let handler = Arc::new(BadRequestHandler);
692
- let request = Request::builder().body(Body::empty()).unwrap();
693
- let request_data = test_request_data();
694
-
695
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
696
-
697
- assert!(result.is_ok());
698
- assert!(
699
- *error_hook_called.lock().unwrap(),
700
- "on_error should be called when handler fails"
701
- );
702
- }
703
-
704
- #[tokio::test]
705
- async fn test_on_error_hook_preserves_original_handler_error_status() {
706
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
707
-
708
- hooks.add_on_error(spikard_http::lifecycle::response_hook(
709
- "error_checker",
710
- |resp| async move {
711
- if resp.status() == StatusCode::BAD_REQUEST {
712
- Ok(HookResult::Continue(resp))
713
- } else {
714
- Err("Expected 400 status".to_string())
715
- }
716
- },
717
- ));
718
-
719
- let handler = Arc::new(BadRequestHandler);
720
- let request = Request::builder().body(Body::empty()).unwrap();
721
- let request_data = test_request_data();
722
-
723
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
724
-
725
- assert!(result.is_ok());
726
- let response = result.unwrap();
727
- assert_eq!(response.status(), StatusCode::BAD_REQUEST);
728
- }
729
-
730
- #[tokio::test]
731
- async fn test_all_three_error_paths_call_on_error() {
732
- use std::sync::Mutex;
733
-
734
- let error_hook_count = Arc::new(Mutex::new(0));
735
-
736
- {
737
- let error_hook_count_clone = error_hook_count.clone();
738
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
739
-
740
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook("failing", |_req| async move {
741
- Err("preValidation error".to_string())
742
- }));
743
-
744
- hooks.add_on_error(spikard_http::lifecycle::response_hook("counter", move |resp| {
745
- let count = error_hook_count_clone.clone();
746
- async move {
747
- *count.lock().unwrap() += 1;
748
- Ok(HookResult::Continue(resp))
749
- }
750
- }));
751
-
752
- let handler = Arc::new(OkHandler);
753
- let request = Request::builder().body(Body::empty()).unwrap();
754
- let request_data = test_request_data();
755
-
756
- let _result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
757
- }
758
-
759
- assert_eq!(
760
- *error_hook_count.lock().unwrap(),
761
- 1,
762
- "on_error called for preValidation error"
763
- );
764
-
765
- *error_hook_count.lock().unwrap() = 0;
766
- {
767
- let error_hook_count_clone = error_hook_count.clone();
768
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
769
-
770
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook("failing", |_req| async move {
771
- Err("preHandler error".to_string())
772
- }));
773
-
774
- hooks.add_on_error(spikard_http::lifecycle::response_hook("counter", move |resp| {
775
- let count = error_hook_count_clone.clone();
776
- async move {
777
- *count.lock().unwrap() += 1;
778
- Ok(HookResult::Continue(resp))
779
- }
780
- }));
781
-
782
- let handler = Arc::new(OkHandler);
783
- let request = Request::builder().body(Body::empty()).unwrap();
784
- let request_data = test_request_data();
785
-
786
- let _result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
787
- }
788
-
789
- assert_eq!(
790
- *error_hook_count.lock().unwrap(),
791
- 1,
792
- "on_error called for preHandler error"
793
- );
794
- }
795
-
796
- #[tokio::test]
797
- async fn test_on_error_fallback_response_when_error_hook_fails() {
798
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
799
-
800
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
801
- "failing_validation",
802
- |_req| async move { Err("Validation error".to_string()) },
803
- ));
804
-
805
- hooks.add_on_error(spikard_http::lifecycle::response_hook(
806
- "failing_error_hook",
807
- |_resp| async move { Err("on_error itself failed".to_string()) },
808
- ));
809
-
810
- let handler = Arc::new(OkHandler);
811
- let request = Request::builder().body(Body::empty()).unwrap();
812
- let request_data = test_request_data();
813
-
814
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
815
-
816
- assert!(result.is_ok());
817
- let response = result.unwrap();
818
- assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
819
-
820
- let body_bytes = axum::body::to_bytes(response.into_body(), usize::MAX).await.unwrap();
821
- let body_str = String::from_utf8(body_bytes.to_vec()).unwrap();
822
- assert!(body_str.contains("Hook execution failed"));
823
- }
824
-
825
- #[tokio::test]
826
- async fn test_full_hook_chain_with_success() {
827
- use std::sync::Mutex;
828
-
829
- let execution_log = Arc::new(Mutex::new(Vec::new()));
830
- let log1 = execution_log.clone();
831
- let log2 = execution_log.clone();
832
- let log3 = execution_log.clone();
833
-
834
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
835
-
836
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook("pv", move |req| {
837
- let log = log1.clone();
838
- async move {
839
- log.lock().unwrap().push("preValidation");
840
- Ok(HookResult::Continue(req))
841
- }
842
- }));
843
-
844
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook("ph", move |req| {
845
- let log = log2.clone();
846
- async move {
847
- log.lock().unwrap().push("preHandler");
848
- Ok(HookResult::Continue(req))
849
- }
850
- }));
851
-
852
- hooks.add_on_response(spikard_http::lifecycle::response_hook("or", move |resp| {
853
- let log = log3.clone();
854
- async move {
855
- log.lock().unwrap().push("onResponse");
856
- Ok(HookResult::Continue(resp))
857
- }
858
- }));
859
-
860
- let handler = Arc::new(OkHandler);
861
- let request = Request::builder().body(Body::empty()).unwrap();
862
- let request_data = test_request_data();
863
-
864
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
865
-
866
- assert!(result.is_ok());
867
- let log = execution_log.lock().unwrap();
868
- assert_eq!(log.as_slice(), &["preValidation", "preHandler", "onResponse"]);
869
- }
870
-
871
- #[tokio::test]
872
- async fn test_pre_handler_short_circuit_skips_on_response() {
873
- use std::sync::Mutex;
874
-
875
- let response_hook_called = Arc::new(Mutex::new(false));
876
- let response_hook_called_clone = response_hook_called.clone();
877
-
878
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
879
-
880
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
881
- "short_circuit",
882
- |_req| async move {
883
- let response = Response::builder()
884
- .status(StatusCode::FORBIDDEN)
885
- .body(Body::from("Forbidden"))
886
- .unwrap();
887
- Ok(HookResult::ShortCircuit(response))
888
- },
889
- ));
890
-
891
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
892
- "response_tracker",
893
- move |resp| {
894
- let flag = response_hook_called_clone.clone();
895
- async move {
896
- *flag.lock().unwrap() = true;
897
- Ok(HookResult::Continue(resp))
898
- }
899
- },
900
- ));
901
-
902
- let handler = Arc::new(OkHandler);
903
- let request = Request::builder().body(Body::empty()).unwrap();
904
- let request_data = test_request_data();
905
-
906
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
907
-
908
- assert!(result.is_ok());
909
- let response = result.unwrap();
910
- assert_eq!(response.status(), StatusCode::FORBIDDEN);
911
- assert!(
912
- !*response_hook_called.lock().unwrap(),
913
- "on_response should not be called"
914
- );
915
- }
916
-
917
- #[tokio::test]
918
- async fn test_on_response_hook_can_transform_success_response() {
919
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
920
-
921
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
922
- "transform",
923
- |_old_resp| async move {
924
- let new_response = Response::builder()
925
- .status(StatusCode::CREATED)
926
- .header("X-Transformed", "yes")
927
- .body(Body::from("Transformed"))
928
- .unwrap();
929
- Ok(HookResult::Continue(new_response))
930
- },
931
- ));
932
-
933
- let handler = Arc::new(OkHandler);
934
- let request = Request::builder().body(Body::empty()).unwrap();
935
- let request_data = test_request_data();
936
-
937
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
938
-
939
- assert!(result.is_ok());
940
- let response = result.unwrap();
941
- assert_eq!(response.status(), StatusCode::CREATED);
942
- assert_eq!(
943
- response.headers().get("X-Transformed").map(|v| v.to_str().unwrap()),
944
- Some("yes")
945
- );
946
- }
947
-
948
- #[tokio::test]
949
- async fn test_error_response_body_contains_correct_hook_context() {
950
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
951
-
952
- hooks.add_pre_handler(spikard_http::lifecycle::request_hook("failing", |_req| async move {
953
- Err("Specific handler setup error".to_string())
954
- }));
955
-
956
- let handler = Arc::new(OkHandler);
957
- let request = Request::builder().body(Body::empty()).unwrap();
958
- let request_data = test_request_data();
959
-
960
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
961
-
962
- assert!(result.is_ok());
963
- let response = result.unwrap();
964
- assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
965
-
966
- let body_bytes = axum::body::to_bytes(response.into_body(), usize::MAX).await.unwrap();
967
- let body_str = String::from_utf8(body_bytes.to_vec()).unwrap();
968
-
969
- assert!(body_str.contains("preHandler"));
970
- assert!(body_str.contains("Specific handler setup error"));
971
- }
972
-
973
- #[tokio::test]
974
- async fn test_multiple_error_hooks_execute_in_sequence() {
975
- use std::sync::Mutex;
976
-
977
- let execution_log = Arc::new(Mutex::new(Vec::new()));
978
- let log1 = execution_log.clone();
979
- let log2 = execution_log.clone();
980
-
981
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
982
-
983
- hooks.add_pre_validation(spikard_http::lifecycle::request_hook("failing", |_req| async move {
984
- Err("Validation failed".to_string())
985
- }));
986
-
987
- hooks.add_on_error(spikard_http::lifecycle::response_hook("error_handler_1", move |resp| {
988
- let log = log1.clone();
989
- async move {
990
- log.lock().unwrap().push("error_handler_1");
991
- Ok(HookResult::Continue(resp))
992
- }
993
- }));
994
-
995
- hooks.add_on_error(spikard_http::lifecycle::response_hook("error_handler_2", move |resp| {
996
- let log = log2.clone();
997
- async move {
998
- log.lock().unwrap().push("error_handler_2");
999
- Ok(HookResult::Continue(resp))
1000
- }
1001
- }));
1002
-
1003
- let handler = Arc::new(OkHandler);
1004
- let request = Request::builder().body(Body::empty()).unwrap();
1005
- let request_data = test_request_data();
1006
-
1007
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
1008
-
1009
- assert!(result.is_ok());
1010
- let log = execution_log.lock().unwrap();
1011
- assert_eq!(log.as_slice(), &["error_handler_1", "error_handler_2"]);
1012
- }
1013
-
1014
- #[tokio::test]
1015
- async fn test_handler_result_error_becomes_500_with_on_error_handling() {
1016
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
1017
-
1018
- hooks.add_on_error(spikard_http::lifecycle::response_hook(
1019
- "error_modifier",
1020
- |mut resp| async move {
1021
- resp.headers_mut()
1022
- .insert("X-Error-Detected", axum::http::HeaderValue::from_static("true"));
1023
- Ok(HookResult::Continue(resp))
1024
- },
1025
- ));
1026
-
1027
- let handler = Arc::new(BadRequestHandler);
1028
- let request = Request::builder().body(Body::empty()).unwrap();
1029
- let request_data = test_request_data();
1030
-
1031
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
1032
-
1033
- assert!(result.is_ok());
1034
- let response = result.unwrap();
1035
- assert_eq!(response.status(), StatusCode::BAD_REQUEST);
1036
- assert_eq!(
1037
- response.headers().get("X-Error-Detected").map(|v| v.to_str().unwrap()),
1038
- Some("true")
1039
- );
1040
- }
1041
-
1042
- #[tokio::test]
1043
- async fn test_on_response_with_multiple_sequential_transforms() {
1044
- let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
1045
-
1046
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
1047
- "add_header_1",
1048
- |mut resp| async move {
1049
- resp.headers_mut()
1050
- .insert("X-Step-1", axum::http::HeaderValue::from_static("done"));
1051
- Ok(HookResult::Continue(resp))
1052
- },
1053
- ));
1054
-
1055
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
1056
- "add_header_2",
1057
- |mut resp| async move {
1058
- resp.headers_mut()
1059
- .insert("X-Step-2", axum::http::HeaderValue::from_static("done"));
1060
- Ok(HookResult::Continue(resp))
1061
- },
1062
- ));
1063
-
1064
- hooks.add_on_response(spikard_http::lifecycle::response_hook(
1065
- "add_header_3",
1066
- |mut resp| async move {
1067
- resp.headers_mut()
1068
- .insert("X-Step-3", axum::http::HeaderValue::from_static("done"));
1069
- Ok(HookResult::Continue(resp))
1070
- },
1071
- ));
1072
-
1073
- let handler = Arc::new(OkHandler);
1074
- let request = Request::builder().body(Body::empty()).unwrap();
1075
- let request_data = test_request_data();
1076
-
1077
- let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
1078
-
1079
- assert!(result.is_ok());
1080
- let response = result.unwrap();
1081
- assert_eq!(
1082
- response.headers().get("X-Step-1").map(|v| v.to_str().unwrap()),
1083
- Some("done")
1084
- );
1085
- assert_eq!(
1086
- response.headers().get("X-Step-2").map(|v| v.to_str().unwrap()),
1087
- Some("done")
1088
- );
1089
- assert_eq!(
1090
- response.headers().get("X-Step-3").map(|v| v.to_str().unwrap()),
1091
- Some("done")
1092
- );
1093
- }
1
+ #![allow(clippy::pedantic, clippy::nursery, clippy::all)]
2
+ //! Comprehensive tests for lifecycle hooks execution
3
+ //!
4
+ //! Tests the execute_with_lifecycle_hooks function covering:
5
+ //! - No hooks and empty hooks fast path
6
+ //! - Hook execution order and continuation
7
+ //! - Short-circuit behavior
8
+ //! - Error handling and onError transformation
9
+ //! - Success path with onResponse
10
+ //! - Response modifications
11
+
12
+ mod common;
13
+
14
+ use axum::body::Body;
15
+ use axum::http::{Request, Response, StatusCode};
16
+ use serde_json::json;
17
+ use spikard_http::lifecycle::HookResult;
18
+ use spikard_http::server::lifecycle_execution::execute_with_lifecycle_hooks;
19
+ use spikard_http::{Handler, HandlerResult, RequestData};
20
+ use std::collections::HashMap;
21
+ use std::future::Future;
22
+ use std::pin::Pin;
23
+ use std::sync::Arc;
24
+
25
+ /// Test request data factory
26
+ fn test_request_data() -> RequestData {
27
+ RequestData {
28
+ path_params: Arc::new(HashMap::new()),
29
+ query_params: serde_json::Value::Null,
30
+ validated_params: None,
31
+ raw_query_params: Arc::new(HashMap::new()),
32
+ body: json!({"test": "data"}),
33
+ raw_body: None,
34
+ headers: Arc::new(HashMap::new()),
35
+ cookies: Arc::new(HashMap::new()),
36
+ method: "GET".to_string(),
37
+ path: "/test".to_string(),
38
+ #[cfg(feature = "di")]
39
+ dependencies: None,
40
+ }
41
+ }
42
+
43
+ /// Handler that returns 200 OK with custom body
44
+ struct OkHandler;
45
+
46
+ impl Handler for OkHandler {
47
+ fn call(
48
+ &self,
49
+ _request: Request<Body>,
50
+ _request_data: RequestData,
51
+ ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
52
+ Box::pin(async move {
53
+ let response = Response::builder()
54
+ .status(StatusCode::OK)
55
+ .body(Body::from("OK"))
56
+ .unwrap();
57
+ Ok(response)
58
+ })
59
+ }
60
+ }
61
+
62
+ /// Handler that returns 400 Bad Request error
63
+ struct BadRequestHandler;
64
+
65
+ impl Handler for BadRequestHandler {
66
+ fn call(
67
+ &self,
68
+ _request: Request<Body>,
69
+ _request_data: RequestData,
70
+ ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
71
+ Box::pin(async move { Err((StatusCode::BAD_REQUEST, "{\"error\": \"Bad Request\"}".to_string())) })
72
+ }
73
+ }
74
+
75
+ #[tokio::test]
76
+ async fn test_no_hooks_none_variant() {
77
+ let handler = Arc::new(OkHandler);
78
+ let request = Request::builder().body(Body::empty()).unwrap();
79
+ let request_data = test_request_data();
80
+
81
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, None).await;
82
+
83
+ assert!(result.is_ok());
84
+ let response = result.unwrap();
85
+ assert_eq!(response.status(), StatusCode::OK);
86
+ }
87
+
88
+ #[tokio::test]
89
+ async fn test_empty_hooks_list() {
90
+ let handler = Arc::new(OkHandler);
91
+ let request = Request::builder().body(Body::empty()).unwrap();
92
+ let request_data = test_request_data();
93
+ let hooks = Arc::new(spikard_http::lifecycle::LifecycleHooks::new());
94
+
95
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(hooks)).await;
96
+
97
+ assert!(result.is_ok());
98
+ let response = result.unwrap();
99
+ assert_eq!(response.status(), StatusCode::OK);
100
+ }
101
+
102
+ #[tokio::test]
103
+ async fn test_pre_validation_hook_continues() {
104
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
105
+
106
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
107
+ "continue_hook",
108
+ |req| async move { Ok(HookResult::Continue(req)) },
109
+ ));
110
+
111
+ let handler = Arc::new(OkHandler);
112
+ let request = Request::builder().body(Body::empty()).unwrap();
113
+ let request_data = test_request_data();
114
+
115
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
116
+
117
+ assert!(result.is_ok());
118
+ let response = result.unwrap();
119
+ assert_eq!(response.status(), StatusCode::OK);
120
+ }
121
+
122
+ #[tokio::test]
123
+ async fn test_pre_validation_hook_short_circuits() {
124
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
125
+
126
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
127
+ "short_circuit",
128
+ |_req| async move {
129
+ let response = Response::builder()
130
+ .status(StatusCode::UNAUTHORIZED)
131
+ .body(Body::from("{\"error\": \"Unauthorized\"}"))
132
+ .unwrap();
133
+ Ok(HookResult::ShortCircuit(response))
134
+ },
135
+ ));
136
+
137
+ let handler = Arc::new(OkHandler);
138
+ let request = Request::builder().body(Body::empty()).unwrap();
139
+ let request_data = test_request_data();
140
+
141
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
142
+
143
+ assert!(result.is_ok());
144
+ let response = result.unwrap();
145
+ assert_eq!(response.status(), StatusCode::UNAUTHORIZED);
146
+ }
147
+
148
+ #[tokio::test]
149
+ async fn test_pre_validation_hook_error_calls_on_error() {
150
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
151
+
152
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
153
+ "failing_hook",
154
+ |_req| async move { Err("Validation failed".to_string()) },
155
+ ));
156
+
157
+ hooks.add_on_error(spikard_http::lifecycle::response_hook(
158
+ "error_handler",
159
+ |mut resp| async move {
160
+ resp.headers_mut()
161
+ .insert("X-Error-Handled", axum::http::HeaderValue::from_static("true"));
162
+ Ok(HookResult::Continue(resp))
163
+ },
164
+ ));
165
+
166
+ let handler = Arc::new(OkHandler);
167
+ let request = Request::builder().body(Body::empty()).unwrap();
168
+ let request_data = test_request_data();
169
+
170
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
171
+
172
+ assert!(result.is_ok());
173
+ let response = result.unwrap();
174
+ assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
175
+ assert_eq!(
176
+ response.headers().get("X-Error-Handled").map(|v| v.to_str().unwrap()),
177
+ Some("true")
178
+ );
179
+ }
180
+
181
+ #[tokio::test]
182
+ async fn test_pre_handler_hook_continues() {
183
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
184
+
185
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
186
+ "continue_hook",
187
+ |req| async move { Ok(HookResult::Continue(req)) },
188
+ ));
189
+
190
+ let handler = Arc::new(OkHandler);
191
+ let request = Request::builder().body(Body::empty()).unwrap();
192
+ let request_data = test_request_data();
193
+
194
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
195
+
196
+ assert!(result.is_ok());
197
+ let response = result.unwrap();
198
+ assert_eq!(response.status(), StatusCode::OK);
199
+ }
200
+
201
+ #[tokio::test]
202
+ async fn test_pre_handler_hook_short_circuits() {
203
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
204
+
205
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
206
+ "short_circuit",
207
+ |_req| async move {
208
+ let response = Response::builder()
209
+ .status(StatusCode::FORBIDDEN)
210
+ .body(Body::from("{\"error\": \"Forbidden\"}"))
211
+ .unwrap();
212
+ Ok(HookResult::ShortCircuit(response))
213
+ },
214
+ ));
215
+
216
+ let handler = Arc::new(OkHandler);
217
+ let request = Request::builder().body(Body::empty()).unwrap();
218
+ let request_data = test_request_data();
219
+
220
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
221
+
222
+ assert!(result.is_ok());
223
+ let response = result.unwrap();
224
+ assert_eq!(response.status(), StatusCode::FORBIDDEN);
225
+ }
226
+
227
+ #[tokio::test]
228
+ async fn test_pre_handler_hook_error_calls_on_error() {
229
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
230
+
231
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
232
+ "failing_hook",
233
+ |_req| async move { Err("Handler preparation failed".to_string()) },
234
+ ));
235
+
236
+ hooks.add_on_error(spikard_http::lifecycle::response_hook(
237
+ "error_handler",
238
+ |mut resp| async move {
239
+ resp.headers_mut()
240
+ .insert("X-PreHandler-Error", axum::http::HeaderValue::from_static("caught"));
241
+ Ok(HookResult::Continue(resp))
242
+ },
243
+ ));
244
+
245
+ let handler = Arc::new(OkHandler);
246
+ let request = Request::builder().body(Body::empty()).unwrap();
247
+ let request_data = test_request_data();
248
+
249
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
250
+
251
+ assert!(result.is_ok());
252
+ let response = result.unwrap();
253
+ assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
254
+ assert_eq!(
255
+ response
256
+ .headers()
257
+ .get("X-PreHandler-Error")
258
+ .map(|v| v.to_str().unwrap()),
259
+ Some("caught")
260
+ );
261
+ }
262
+
263
+ #[tokio::test]
264
+ async fn test_handler_error_calls_on_error() {
265
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
266
+
267
+ hooks.add_on_error(spikard_http::lifecycle::response_hook(
268
+ "error_logger",
269
+ |mut resp| async move {
270
+ resp.headers_mut()
271
+ .insert("X-Handler-Error", axum::http::HeaderValue::from_static("logged"));
272
+ Ok(HookResult::Continue(resp))
273
+ },
274
+ ));
275
+
276
+ let handler = Arc::new(BadRequestHandler);
277
+ let request = Request::builder().body(Body::empty()).unwrap();
278
+ let request_data = test_request_data();
279
+
280
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
281
+
282
+ assert!(result.is_ok());
283
+ let response = result.unwrap();
284
+ assert_eq!(response.status(), StatusCode::BAD_REQUEST);
285
+ assert_eq!(
286
+ response.headers().get("X-Handler-Error").map(|v| v.to_str().unwrap()),
287
+ Some("logged")
288
+ );
289
+ }
290
+
291
+ #[tokio::test]
292
+ async fn test_success_handler_calls_on_response() {
293
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
294
+
295
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
296
+ "response_modifier",
297
+ |mut resp| async move {
298
+ resp.headers_mut()
299
+ .insert("X-Response-Modified", axum::http::HeaderValue::from_static("yes"));
300
+ Ok(HookResult::Continue(resp))
301
+ },
302
+ ));
303
+
304
+ let handler = Arc::new(OkHandler);
305
+ let request = Request::builder().body(Body::empty()).unwrap();
306
+ let request_data = test_request_data();
307
+
308
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
309
+
310
+ assert!(result.is_ok());
311
+ let response = result.unwrap();
312
+ assert_eq!(response.status(), StatusCode::OK);
313
+ assert_eq!(
314
+ response
315
+ .headers()
316
+ .get("X-Response-Modified")
317
+ .map(|v| v.to_str().unwrap()),
318
+ Some("yes")
319
+ );
320
+ }
321
+
322
+ #[tokio::test]
323
+ async fn test_on_response_hook_error_returns_500() {
324
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
325
+
326
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
327
+ "failing_response_hook",
328
+ |_resp| async move { Err("Response processing failed".to_string()) },
329
+ ));
330
+
331
+ let handler = Arc::new(OkHandler);
332
+ let request = Request::builder().body(Body::empty()).unwrap();
333
+ let request_data = test_request_data();
334
+
335
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
336
+
337
+ assert!(result.is_ok());
338
+ let response = result.unwrap();
339
+ assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
340
+ }
341
+
342
+ #[tokio::test]
343
+ async fn test_on_error_hook_fails_fallback_500() {
344
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
345
+
346
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
347
+ "failing_validation",
348
+ |_req| async move { Err("Validation error".to_string()) },
349
+ ));
350
+
351
+ hooks.add_on_error(spikard_http::lifecycle::response_hook(
352
+ "failing_error_hook",
353
+ |_resp| async move { Err("Error hook failed".to_string()) },
354
+ ));
355
+
356
+ let handler = Arc::new(OkHandler);
357
+ let request = Request::builder().body(Body::empty()).unwrap();
358
+ let request_data = test_request_data();
359
+
360
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
361
+
362
+ assert!(result.is_ok());
363
+ let response = result.unwrap();
364
+ assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
365
+ }
366
+
367
+ #[tokio::test]
368
+ async fn test_hook_execution_order_preserved() {
369
+ use std::sync::Mutex;
370
+
371
+ let execution_log = Arc::new(Mutex::new(Vec::new()));
372
+ let execution_log_clone1 = execution_log.clone();
373
+ let execution_log_clone2 = execution_log.clone();
374
+ let execution_log_clone3 = execution_log.clone();
375
+
376
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
377
+
378
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook("pre_validation", move |req| {
379
+ let log = execution_log_clone1.clone();
380
+ async move {
381
+ log.lock().unwrap().push("pre_validation");
382
+ Ok(HookResult::Continue(req))
383
+ }
384
+ }));
385
+
386
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook("pre_handler", move |req| {
387
+ let log = execution_log_clone2.clone();
388
+ async move {
389
+ log.lock().unwrap().push("pre_handler");
390
+ Ok(HookResult::Continue(req))
391
+ }
392
+ }));
393
+
394
+ hooks.add_on_response(spikard_http::lifecycle::response_hook("on_response", move |resp| {
395
+ let log = execution_log_clone3.clone();
396
+ async move {
397
+ log.lock().unwrap().push("on_response");
398
+ Ok(HookResult::Continue(resp))
399
+ }
400
+ }));
401
+
402
+ let handler = Arc::new(OkHandler);
403
+ let request = Request::builder().body(Body::empty()).unwrap();
404
+ let request_data = test_request_data();
405
+
406
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
407
+
408
+ assert!(result.is_ok());
409
+
410
+ let log = execution_log.lock().unwrap();
411
+ assert_eq!(log.as_slice(), &["pre_validation", "pre_handler", "on_response"]);
412
+ }
413
+
414
+ #[tokio::test]
415
+ async fn test_pre_validation_short_circuit_skips_handler_and_on_response() {
416
+ use std::sync::Mutex;
417
+
418
+ let handler_called = Arc::new(Mutex::new(false));
419
+ let response_hook_called = Arc::new(Mutex::new(false));
420
+
421
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
422
+
423
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
424
+ "short_circuit",
425
+ |_req| async move {
426
+ let response = Response::builder()
427
+ .status(StatusCode::UNAUTHORIZED)
428
+ .body(Body::from("Unauthorized"))
429
+ .unwrap();
430
+ Ok(HookResult::ShortCircuit(response))
431
+ },
432
+ ));
433
+
434
+ let response_hook_called_clone = response_hook_called.clone();
435
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
436
+ "response_tracker",
437
+ move |resp| {
438
+ let flag = response_hook_called_clone.clone();
439
+ async move {
440
+ *flag.lock().unwrap() = true;
441
+ Ok(HookResult::Continue(resp))
442
+ }
443
+ },
444
+ ));
445
+
446
+ struct TrackingHandler {
447
+ called: Arc<Mutex<bool>>,
448
+ }
449
+
450
+ impl Handler for TrackingHandler {
451
+ fn call(
452
+ &self,
453
+ _request: Request<Body>,
454
+ _request_data: RequestData,
455
+ ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
456
+ let called = self.called.clone();
457
+ Box::pin(async move {
458
+ *called.lock().unwrap() = true;
459
+ let response = Response::builder()
460
+ .status(StatusCode::OK)
461
+ .body(Body::from("OK"))
462
+ .unwrap();
463
+ Ok(response)
464
+ })
465
+ }
466
+ }
467
+
468
+ let handler = Arc::new(TrackingHandler {
469
+ called: handler_called.clone(),
470
+ });
471
+
472
+ let request = Request::builder().body(Body::empty()).unwrap();
473
+ let request_data = test_request_data();
474
+
475
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
476
+
477
+ assert!(result.is_ok());
478
+ assert!(!*handler_called.lock().unwrap(), "Handler should not be called");
479
+ assert!(
480
+ !*response_hook_called.lock().unwrap(),
481
+ "on_response should not be called"
482
+ );
483
+ }
484
+
485
+ #[tokio::test]
486
+ async fn test_multiple_hooks_same_phase_executed_in_order() {
487
+ use std::sync::Mutex;
488
+
489
+ let execution_log = Arc::new(Mutex::new(Vec::new()));
490
+ let log1 = execution_log.clone();
491
+ let log2 = execution_log.clone();
492
+ let log3 = execution_log.clone();
493
+
494
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
495
+
496
+ hooks.add_on_response(spikard_http::lifecycle::response_hook("first_hook", move |resp| {
497
+ let log = log1.clone();
498
+ async move {
499
+ log.lock().unwrap().push("first");
500
+ Ok(HookResult::Continue(resp))
501
+ }
502
+ }));
503
+
504
+ hooks.add_on_response(spikard_http::lifecycle::response_hook("second_hook", move |resp| {
505
+ let log = log2.clone();
506
+ async move {
507
+ log.lock().unwrap().push("second");
508
+ Ok(HookResult::Continue(resp))
509
+ }
510
+ }));
511
+
512
+ hooks.add_on_response(spikard_http::lifecycle::response_hook("third_hook", move |resp| {
513
+ let log = log3.clone();
514
+ async move {
515
+ log.lock().unwrap().push("third");
516
+ Ok(HookResult::Continue(resp))
517
+ }
518
+ }));
519
+
520
+ let handler = Arc::new(OkHandler);
521
+ let request = Request::builder().body(Body::empty()).unwrap();
522
+ let request_data = test_request_data();
523
+
524
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
525
+
526
+ assert!(result.is_ok());
527
+
528
+ let log = execution_log.lock().unwrap();
529
+ assert_eq!(log.as_slice(), &["first", "second", "third"]);
530
+ }
531
+
532
+ #[tokio::test]
533
+ async fn test_hook_can_modify_request() {
534
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
535
+
536
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
537
+ "add_header",
538
+ |mut req| async move {
539
+ req.headers_mut()
540
+ .insert("X-Added-By-Hook", axum::http::HeaderValue::from_static("hook-value"));
541
+ Ok(HookResult::Continue(req))
542
+ },
543
+ ));
544
+
545
+ struct HeaderCheckHandler;
546
+
547
+ impl Handler for HeaderCheckHandler {
548
+ fn call(
549
+ &self,
550
+ request: Request<Body>,
551
+ _request_data: RequestData,
552
+ ) -> Pin<Box<dyn Future<Output = HandlerResult> + Send + '_>> {
553
+ Box::pin(async move {
554
+ let has_header = request.headers().contains_key("X-Added-By-Hook");
555
+ let body = if has_header { "Header found" } else { "Header not found" };
556
+
557
+ let response = Response::builder()
558
+ .status(StatusCode::OK)
559
+ .body(Body::from(body))
560
+ .unwrap();
561
+ Ok(response)
562
+ })
563
+ }
564
+ }
565
+
566
+ let handler = Arc::new(HeaderCheckHandler);
567
+ let request = Request::builder().body(Body::empty()).unwrap();
568
+ let request_data = test_request_data();
569
+
570
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
571
+
572
+ assert!(result.is_ok());
573
+ let response = result.unwrap();
574
+ assert_eq!(response.status(), StatusCode::OK);
575
+ }
576
+
577
+ #[tokio::test]
578
+ async fn test_error_response_contains_hook_error_message() {
579
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
580
+
581
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
582
+ "failing_hook",
583
+ |_req| async move { Err("Custom validation error".to_string()) },
584
+ ));
585
+
586
+ let handler = Arc::new(OkHandler);
587
+ let request = Request::builder().body(Body::empty()).unwrap();
588
+ let request_data = test_request_data();
589
+
590
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
591
+
592
+ assert!(result.is_ok());
593
+ let response = result.unwrap();
594
+ assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
595
+
596
+ let body_bytes = axum::body::to_bytes(response.into_body(), usize::MAX).await.unwrap();
597
+ let body_str = String::from_utf8(body_bytes.to_vec()).unwrap();
598
+ assert!(body_str.contains("Custom validation error"));
599
+ }
600
+
601
+ #[tokio::test]
602
+ async fn test_chained_hook_modifications() {
603
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
604
+
605
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
606
+ "add_header_1",
607
+ |mut resp| async move {
608
+ resp.headers_mut()
609
+ .insert("X-Header-1", axum::http::HeaderValue::from_static("value1"));
610
+ Ok(HookResult::Continue(resp))
611
+ },
612
+ ));
613
+
614
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
615
+ "add_header_2",
616
+ |mut resp| async move {
617
+ resp.headers_mut()
618
+ .insert("X-Header-2", axum::http::HeaderValue::from_static("value2"));
619
+ Ok(HookResult::Continue(resp))
620
+ },
621
+ ));
622
+
623
+ let handler = Arc::new(OkHandler);
624
+ let request = Request::builder().body(Body::empty()).unwrap();
625
+ let request_data = test_request_data();
626
+
627
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
628
+
629
+ assert!(result.is_ok());
630
+ let response = result.unwrap();
631
+ assert_eq!(
632
+ response.headers().get("X-Header-1").map(|v| v.to_str().unwrap()),
633
+ Some("value1")
634
+ );
635
+ assert_eq!(
636
+ response.headers().get("X-Header-2").map(|v| v.to_str().unwrap()),
637
+ Some("value2")
638
+ );
639
+ }
640
+
641
+ #[tokio::test]
642
+ async fn test_on_response_not_called_when_handler_fails() {
643
+ use std::sync::Mutex;
644
+
645
+ let response_hook_called = Arc::new(Mutex::new(false));
646
+ let response_hook_called_clone = response_hook_called.clone();
647
+
648
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
649
+
650
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
651
+ "response_tracker",
652
+ move |resp| {
653
+ let flag = response_hook_called_clone.clone();
654
+ async move {
655
+ *flag.lock().unwrap() = true;
656
+ Ok(HookResult::Continue(resp))
657
+ }
658
+ },
659
+ ));
660
+
661
+ let handler = Arc::new(BadRequestHandler);
662
+ let request = Request::builder().body(Body::empty()).unwrap();
663
+ let request_data = test_request_data();
664
+
665
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
666
+
667
+ assert!(result.is_ok());
668
+ assert!(
669
+ !*response_hook_called.lock().unwrap(),
670
+ "on_response should NOT be called when handler fails"
671
+ );
672
+ }
673
+
674
+ #[tokio::test]
675
+ async fn test_on_error_called_when_handler_fails() {
676
+ use std::sync::Mutex;
677
+
678
+ let error_hook_called = Arc::new(Mutex::new(false));
679
+ let error_hook_called_clone = error_hook_called.clone();
680
+
681
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
682
+
683
+ hooks.add_on_error(spikard_http::lifecycle::response_hook("error_tracker", move |resp| {
684
+ let flag = error_hook_called_clone.clone();
685
+ async move {
686
+ *flag.lock().unwrap() = true;
687
+ Ok(HookResult::Continue(resp))
688
+ }
689
+ }));
690
+
691
+ let handler = Arc::new(BadRequestHandler);
692
+ let request = Request::builder().body(Body::empty()).unwrap();
693
+ let request_data = test_request_data();
694
+
695
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
696
+
697
+ assert!(result.is_ok());
698
+ assert!(
699
+ *error_hook_called.lock().unwrap(),
700
+ "on_error should be called when handler fails"
701
+ );
702
+ }
703
+
704
+ #[tokio::test]
705
+ async fn test_on_error_hook_preserves_original_handler_error_status() {
706
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
707
+
708
+ hooks.add_on_error(spikard_http::lifecycle::response_hook(
709
+ "error_checker",
710
+ |resp| async move {
711
+ if resp.status() == StatusCode::BAD_REQUEST {
712
+ Ok(HookResult::Continue(resp))
713
+ } else {
714
+ Err("Expected 400 status".to_string())
715
+ }
716
+ },
717
+ ));
718
+
719
+ let handler = Arc::new(BadRequestHandler);
720
+ let request = Request::builder().body(Body::empty()).unwrap();
721
+ let request_data = test_request_data();
722
+
723
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
724
+
725
+ assert!(result.is_ok());
726
+ let response = result.unwrap();
727
+ assert_eq!(response.status(), StatusCode::BAD_REQUEST);
728
+ }
729
+
730
+ #[tokio::test]
731
+ async fn test_all_three_error_paths_call_on_error() {
732
+ use std::sync::Mutex;
733
+
734
+ let error_hook_count = Arc::new(Mutex::new(0));
735
+
736
+ {
737
+ let error_hook_count_clone = error_hook_count.clone();
738
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
739
+
740
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook("failing", |_req| async move {
741
+ Err("preValidation error".to_string())
742
+ }));
743
+
744
+ hooks.add_on_error(spikard_http::lifecycle::response_hook("counter", move |resp| {
745
+ let count = error_hook_count_clone.clone();
746
+ async move {
747
+ *count.lock().unwrap() += 1;
748
+ Ok(HookResult::Continue(resp))
749
+ }
750
+ }));
751
+
752
+ let handler = Arc::new(OkHandler);
753
+ let request = Request::builder().body(Body::empty()).unwrap();
754
+ let request_data = test_request_data();
755
+
756
+ let _result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
757
+ }
758
+
759
+ assert_eq!(
760
+ *error_hook_count.lock().unwrap(),
761
+ 1,
762
+ "on_error called for preValidation error"
763
+ );
764
+
765
+ *error_hook_count.lock().unwrap() = 0;
766
+ {
767
+ let error_hook_count_clone = error_hook_count.clone();
768
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
769
+
770
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook("failing", |_req| async move {
771
+ Err("preHandler error".to_string())
772
+ }));
773
+
774
+ hooks.add_on_error(spikard_http::lifecycle::response_hook("counter", move |resp| {
775
+ let count = error_hook_count_clone.clone();
776
+ async move {
777
+ *count.lock().unwrap() += 1;
778
+ Ok(HookResult::Continue(resp))
779
+ }
780
+ }));
781
+
782
+ let handler = Arc::new(OkHandler);
783
+ let request = Request::builder().body(Body::empty()).unwrap();
784
+ let request_data = test_request_data();
785
+
786
+ let _result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
787
+ }
788
+
789
+ assert_eq!(
790
+ *error_hook_count.lock().unwrap(),
791
+ 1,
792
+ "on_error called for preHandler error"
793
+ );
794
+ }
795
+
796
+ #[tokio::test]
797
+ async fn test_on_error_fallback_response_when_error_hook_fails() {
798
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
799
+
800
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook(
801
+ "failing_validation",
802
+ |_req| async move { Err("Validation error".to_string()) },
803
+ ));
804
+
805
+ hooks.add_on_error(spikard_http::lifecycle::response_hook(
806
+ "failing_error_hook",
807
+ |_resp| async move { Err("on_error itself failed".to_string()) },
808
+ ));
809
+
810
+ let handler = Arc::new(OkHandler);
811
+ let request = Request::builder().body(Body::empty()).unwrap();
812
+ let request_data = test_request_data();
813
+
814
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
815
+
816
+ assert!(result.is_ok());
817
+ let response = result.unwrap();
818
+ assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
819
+
820
+ let body_bytes = axum::body::to_bytes(response.into_body(), usize::MAX).await.unwrap();
821
+ let body_str = String::from_utf8(body_bytes.to_vec()).unwrap();
822
+ assert!(body_str.contains("Hook execution failed"));
823
+ }
824
+
825
+ #[tokio::test]
826
+ async fn test_full_hook_chain_with_success() {
827
+ use std::sync::Mutex;
828
+
829
+ let execution_log = Arc::new(Mutex::new(Vec::new()));
830
+ let log1 = execution_log.clone();
831
+ let log2 = execution_log.clone();
832
+ let log3 = execution_log.clone();
833
+
834
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
835
+
836
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook("pv", move |req| {
837
+ let log = log1.clone();
838
+ async move {
839
+ log.lock().unwrap().push("preValidation");
840
+ Ok(HookResult::Continue(req))
841
+ }
842
+ }));
843
+
844
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook("ph", move |req| {
845
+ let log = log2.clone();
846
+ async move {
847
+ log.lock().unwrap().push("preHandler");
848
+ Ok(HookResult::Continue(req))
849
+ }
850
+ }));
851
+
852
+ hooks.add_on_response(spikard_http::lifecycle::response_hook("or", move |resp| {
853
+ let log = log3.clone();
854
+ async move {
855
+ log.lock().unwrap().push("onResponse");
856
+ Ok(HookResult::Continue(resp))
857
+ }
858
+ }));
859
+
860
+ let handler = Arc::new(OkHandler);
861
+ let request = Request::builder().body(Body::empty()).unwrap();
862
+ let request_data = test_request_data();
863
+
864
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
865
+
866
+ assert!(result.is_ok());
867
+ let log = execution_log.lock().unwrap();
868
+ assert_eq!(log.as_slice(), &["preValidation", "preHandler", "onResponse"]);
869
+ }
870
+
871
+ #[tokio::test]
872
+ async fn test_pre_handler_short_circuit_skips_on_response() {
873
+ use std::sync::Mutex;
874
+
875
+ let response_hook_called = Arc::new(Mutex::new(false));
876
+ let response_hook_called_clone = response_hook_called.clone();
877
+
878
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
879
+
880
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook(
881
+ "short_circuit",
882
+ |_req| async move {
883
+ let response = Response::builder()
884
+ .status(StatusCode::FORBIDDEN)
885
+ .body(Body::from("Forbidden"))
886
+ .unwrap();
887
+ Ok(HookResult::ShortCircuit(response))
888
+ },
889
+ ));
890
+
891
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
892
+ "response_tracker",
893
+ move |resp| {
894
+ let flag = response_hook_called_clone.clone();
895
+ async move {
896
+ *flag.lock().unwrap() = true;
897
+ Ok(HookResult::Continue(resp))
898
+ }
899
+ },
900
+ ));
901
+
902
+ let handler = Arc::new(OkHandler);
903
+ let request = Request::builder().body(Body::empty()).unwrap();
904
+ let request_data = test_request_data();
905
+
906
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
907
+
908
+ assert!(result.is_ok());
909
+ let response = result.unwrap();
910
+ assert_eq!(response.status(), StatusCode::FORBIDDEN);
911
+ assert!(
912
+ !*response_hook_called.lock().unwrap(),
913
+ "on_response should not be called"
914
+ );
915
+ }
916
+
917
+ #[tokio::test]
918
+ async fn test_on_response_hook_can_transform_success_response() {
919
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
920
+
921
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
922
+ "transform",
923
+ |_old_resp| async move {
924
+ let new_response = Response::builder()
925
+ .status(StatusCode::CREATED)
926
+ .header("X-Transformed", "yes")
927
+ .body(Body::from("Transformed"))
928
+ .unwrap();
929
+ Ok(HookResult::Continue(new_response))
930
+ },
931
+ ));
932
+
933
+ let handler = Arc::new(OkHandler);
934
+ let request = Request::builder().body(Body::empty()).unwrap();
935
+ let request_data = test_request_data();
936
+
937
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
938
+
939
+ assert!(result.is_ok());
940
+ let response = result.unwrap();
941
+ assert_eq!(response.status(), StatusCode::CREATED);
942
+ assert_eq!(
943
+ response.headers().get("X-Transformed").map(|v| v.to_str().unwrap()),
944
+ Some("yes")
945
+ );
946
+ }
947
+
948
+ #[tokio::test]
949
+ async fn test_error_response_body_contains_correct_hook_context() {
950
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
951
+
952
+ hooks.add_pre_handler(spikard_http::lifecycle::request_hook("failing", |_req| async move {
953
+ Err("Specific handler setup error".to_string())
954
+ }));
955
+
956
+ let handler = Arc::new(OkHandler);
957
+ let request = Request::builder().body(Body::empty()).unwrap();
958
+ let request_data = test_request_data();
959
+
960
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
961
+
962
+ assert!(result.is_ok());
963
+ let response = result.unwrap();
964
+ assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
965
+
966
+ let body_bytes = axum::body::to_bytes(response.into_body(), usize::MAX).await.unwrap();
967
+ let body_str = String::from_utf8(body_bytes.to_vec()).unwrap();
968
+
969
+ assert!(body_str.contains("preHandler"));
970
+ assert!(body_str.contains("Specific handler setup error"));
971
+ }
972
+
973
+ #[tokio::test]
974
+ async fn test_multiple_error_hooks_execute_in_sequence() {
975
+ use std::sync::Mutex;
976
+
977
+ let execution_log = Arc::new(Mutex::new(Vec::new()));
978
+ let log1 = execution_log.clone();
979
+ let log2 = execution_log.clone();
980
+
981
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
982
+
983
+ hooks.add_pre_validation(spikard_http::lifecycle::request_hook("failing", |_req| async move {
984
+ Err("Validation failed".to_string())
985
+ }));
986
+
987
+ hooks.add_on_error(spikard_http::lifecycle::response_hook("error_handler_1", move |resp| {
988
+ let log = log1.clone();
989
+ async move {
990
+ log.lock().unwrap().push("error_handler_1");
991
+ Ok(HookResult::Continue(resp))
992
+ }
993
+ }));
994
+
995
+ hooks.add_on_error(spikard_http::lifecycle::response_hook("error_handler_2", move |resp| {
996
+ let log = log2.clone();
997
+ async move {
998
+ log.lock().unwrap().push("error_handler_2");
999
+ Ok(HookResult::Continue(resp))
1000
+ }
1001
+ }));
1002
+
1003
+ let handler = Arc::new(OkHandler);
1004
+ let request = Request::builder().body(Body::empty()).unwrap();
1005
+ let request_data = test_request_data();
1006
+
1007
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
1008
+
1009
+ assert!(result.is_ok());
1010
+ let log = execution_log.lock().unwrap();
1011
+ assert_eq!(log.as_slice(), &["error_handler_1", "error_handler_2"]);
1012
+ }
1013
+
1014
+ #[tokio::test]
1015
+ async fn test_handler_result_error_becomes_500_with_on_error_handling() {
1016
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
1017
+
1018
+ hooks.add_on_error(spikard_http::lifecycle::response_hook(
1019
+ "error_modifier",
1020
+ |mut resp| async move {
1021
+ resp.headers_mut()
1022
+ .insert("X-Error-Detected", axum::http::HeaderValue::from_static("true"));
1023
+ Ok(HookResult::Continue(resp))
1024
+ },
1025
+ ));
1026
+
1027
+ let handler = Arc::new(BadRequestHandler);
1028
+ let request = Request::builder().body(Body::empty()).unwrap();
1029
+ let request_data = test_request_data();
1030
+
1031
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
1032
+
1033
+ assert!(result.is_ok());
1034
+ let response = result.unwrap();
1035
+ assert_eq!(response.status(), StatusCode::BAD_REQUEST);
1036
+ assert_eq!(
1037
+ response.headers().get("X-Error-Detected").map(|v| v.to_str().unwrap()),
1038
+ Some("true")
1039
+ );
1040
+ }
1041
+
1042
+ #[tokio::test]
1043
+ async fn test_on_response_with_multiple_sequential_transforms() {
1044
+ let mut hooks = spikard_http::lifecycle::LifecycleHooks::new();
1045
+
1046
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
1047
+ "add_header_1",
1048
+ |mut resp| async move {
1049
+ resp.headers_mut()
1050
+ .insert("X-Step-1", axum::http::HeaderValue::from_static("done"));
1051
+ Ok(HookResult::Continue(resp))
1052
+ },
1053
+ ));
1054
+
1055
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
1056
+ "add_header_2",
1057
+ |mut resp| async move {
1058
+ resp.headers_mut()
1059
+ .insert("X-Step-2", axum::http::HeaderValue::from_static("done"));
1060
+ Ok(HookResult::Continue(resp))
1061
+ },
1062
+ ));
1063
+
1064
+ hooks.add_on_response(spikard_http::lifecycle::response_hook(
1065
+ "add_header_3",
1066
+ |mut resp| async move {
1067
+ resp.headers_mut()
1068
+ .insert("X-Step-3", axum::http::HeaderValue::from_static("done"));
1069
+ Ok(HookResult::Continue(resp))
1070
+ },
1071
+ ));
1072
+
1073
+ let handler = Arc::new(OkHandler);
1074
+ let request = Request::builder().body(Body::empty()).unwrap();
1075
+ let request_data = test_request_data();
1076
+
1077
+ let result = execute_with_lifecycle_hooks(request, request_data, handler, Some(Arc::new(hooks))).await;
1078
+
1079
+ assert!(result.is_ok());
1080
+ let response = result.unwrap();
1081
+ assert_eq!(
1082
+ response.headers().get("X-Step-1").map(|v| v.to_str().unwrap()),
1083
+ Some("done")
1084
+ );
1085
+ assert_eq!(
1086
+ response.headers().get("X-Step-2").map(|v| v.to_str().unwrap()),
1087
+ Some("done")
1088
+ );
1089
+ assert_eq!(
1090
+ response.headers().get("X-Step-3").map(|v| v.to_str().unwrap()),
1091
+ Some("done")
1092
+ );
1093
+ }