foobara 0.5.10 → 0.6.2

data/projects/{entities → typesystem}/projects/model/src/concerns/classes.rb

@@ -42,11 +42,11 @@ module Foobara
                 if existing_class.instance_variable_get(:@foobara_created_via_make_class)
                   existing_module_to_copy_over = existing_class
                   parent_mod = Util.module_for(existing_class)
-                  parent_mod.send(:remove_const, Util.non_full_name(existing_class))
+                  parent_mod.__send__(:remove_const, Util.non_full_name(existing_class))
                 else
-                  # :nocov:
+                  # simplecov:disable
                   return existing_class
-                  # :nocov:
+                  # simplecov:enable
                 end
               end
 
@@ -61,7 +61,7 @@ module Foobara
                 model_module = Util.make_module_p(model_module_name, tag: true)
               end
 
-              const_name = model_name.split("::").last
+              const_name = model_name.split("::")[-1]
 
               model_module.const_set(const_name, anonymous_model_class)
 

data/projects/{entities → typesystem}/projects/model/src/concerns/types.rb

@@ -28,12 +28,12 @@ module Foobara
                 end
               end
             when 1
-              @mutable_override = args.first
+              @mutable_override = args[0]
               set_model_type
             else
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Expected 0 or 1 arguments but got #{args_size}"
-              # :nocov:
+              # simplecov:enable
             end
           end
 
@@ -226,9 +226,9 @@ module Foobara
 
               if method_defined?(method)
                 # TODO: test this code path
-                # :nocov:
+                # simplecov:disable
                 remove_method method
-                # :nocov:
+                # simplecov:enable
               end
             end
 

data/projects/{entities → typesystem}/projects/model/src/extensions/builtin_types/model/casters/hash.rb

@@ -12,7 +12,7 @@ module Foobara
           def cast(attributes)
             symbolized_attributes = super
 
-            model_class.send(build_method(symbolized_attributes), symbolized_attributes)
+            model_class.__send__(build_method(symbolized_attributes), symbolized_attributes)
           end
 
           def model_class

data/projects/{entities → typesystem}/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/attributes_handler_desugarizer.rb

@@ -19,10 +19,10 @@ module Foobara
 
             if sugary_type_declaration.deep_duped?
               # TODO: probably not worth directly testing this path
-              # :nocov:
+              # simplecov:disable
               declaration.is_duped = true
               declaration.is_deep_duped = true
-              # :nocov:
+              # simplecov:enable
             end
 
             declaration = handler.desugarize(declaration)

data/projects/{entities → typesystem}/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/model_class_desugarizer.rb

@@ -27,9 +27,9 @@ module Foobara
                 when ::String, nil
                   model_module
                 else
-                  # :nocov:
+                  # simplecov:disable
                   raise ArgumentError, "expected #{model_module} to be a module or module name"
-                  # :nocov:
+                  # simplecov:enable
                 end
             end
 
@@ -53,9 +53,9 @@ module Foobara
                                  elsif klass.is_a?(::String)
                                    klass
                                  else
-                                   # :nocov:
+                                   # simplecov:disable
                                    raise ArgumentError, "expected #{klass} to be a class or class name"
-                                   # :nocov:
+                                   # simplecov:enable
                                  end
 
               strictish_type_declaration[:model_class] = model_class_name
@@ -70,9 +70,9 @@ module Foobara
               when ::String
                 model_base_class
               else
-                # :nocov:
+                # simplecov:disable
                 raise ArgumentError, "expected #{model_base_class} to be a class or class name"
-                # :nocov:
+                # simplecov:enable
               end
 
             if strictish_type_declaration[:name].is_a?(::Symbol)

data/projects/{entities → typesystem}/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/to_type_transformer.rb

@@ -17,9 +17,9 @@ module Foobara
               if model_type
                 if model_type.foobara_root_namespace == Foobara::Namespace.current.foobara_root_namespace
                   # TODO: test this code path
-                  # :nocov:
+                  # simplecov:disable
                   existing_class
-                  # :nocov:
+                  # simplecov:enable
                 end
               end
             else
@@ -83,9 +83,9 @@ module Foobara
                 existing_model_type = model_class.model_type
 
                 if existing_model_type
-                  # :nocov:
+                  # simplecov:disable
                   raise "Did not expect #{type.declaration_data[:name]} to already exist"
-                  # :nocov:
+                  # simplecov:enable
                 else
                   model_class.model_type = type
 

data/projects/{entities → typesystem}/projects/model/src/extensions/type_declarations/handlers/extend_registered_model_type_declaration.rb

@@ -5,9 +5,9 @@ module Foobara
       class ExtendRegisteredModelTypeDeclaration < ExtendRegisteredTypeDeclaration
         def applicable?(sugary_type_declaration)
           strict_type_declaration = if sugary_type_declaration.strict?
-                                      # :nocov:
+                                      # simplecov:disable
                                       sugary_type_declaration
-                                      # :nocov:
+                                      # simplecov:enable
                                     else
                                       desugarize(sugary_type_declaration.clone)
                                     end

data/projects/{entities → typesystem}/projects/model/src/extensions/type_declarations/handlers/registered_type_declaration/model_class_desugarizer.rb

@@ -10,24 +10,20 @@ module Foobara
           def desugarize(declaration)
             model_class = declaration.declaration_data
 
-            declaration.declaration_data = model_class.model_type.foobara_manifest_reference.to_sym
-
             type = model_class.model_type
 
             if type
+              declaration.declaration_data = type.foobara_manifest_reference.to_sym
               declaration.type = type
               declaration.reference_checked = true
+              declaration.is_absolutified = true
+              declaration.is_strict = true
+              declaration.is_duped = true
+              declaration.is_deep_duped = true
             else
-              # :nocov:
-              declaration.reference_checked = false
-              # :nocov:
+              declaration.claimed_but_error!
             end
 
-            declaration.is_absolutified = true
-            declaration.is_strict = true
-            declaration.is_duped = true
-            declaration.is_deep_duped = true
-
             declaration
           end
 

data/projects/{entities → typesystem}/projects/model/src/model.rb

@@ -18,11 +18,11 @@ module Foobara
         when 0
           @description
         when 1
-          @description = args.first
+          @description = args[0]
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "expected 0 or 1 argument, got #{args.size}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -111,7 +111,7 @@ module Foobara
         if foobara_type&.scoped_path_set?
           foobara_type.scoped_name
         else
-          Util.non_full_name(self) || model_name&.split("::")&.last
+          Util.non_full_name(self) || model_name&.split("::")&.[](-1)
         end
       end
 
@@ -186,9 +186,9 @@ module Foobara
       invalid_options = options.keys - ALLOWED_OPTIONS
 
       unless invalid_options.empty?
-        # :nocov:
+        # simplecov:disable
         raise ArgumentError, "Invalid options #{invalid_options} expected only #{ALLOWED_OPTIONS}"
-        # :nocov:
+        # simplecov:enable
       end
 
       self.skip_validations = options[:skip_validations]
@@ -204,9 +204,9 @@ module Foobara
 
       if attributes.nil?
         if validate
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Cannot use validate option without attributes"
-          # :nocov:
+          # simplecov:enable
         end
       else
         if Thread.inheritable_thread_local_var_get(:foobara_ignore_unexpected_attributes)
@@ -246,9 +246,9 @@ module Foobara
     end
 
     def valid_attribute_name?(attribute_name)
-      # :nocov:
+      # simplecov:disable
       self.class.valid_attribute_name?(attribute_name)
-      # :nocov:
+      # simplecov:enable
     end
 
     def validate_attribute_name!(attribute_name)
@@ -261,7 +261,7 @@ module Foobara
 
     def attributes_with_delegates
       h = self.class.delegates.keys.to_h do |delegated_attribute_name|
-        [delegated_attribute_name, send(delegated_attribute_name)]
+        [delegated_attribute_name, __send__(delegated_attribute_name)]
       end
 
       attributes.merge(h)
@@ -274,9 +274,9 @@ module Foobara
         outcome = cast_attribute(attribute_name, value)
         attributes[attribute_name] = outcome.success? ? outcome.result : value
       else
-        # :nocov:
+        # simplecov:disable
         raise AttributeIsImmutableError, "Cannot write attribute #{attribute_name} because it is not mutable"
-        # :nocov:
+        # simplecov:enable
       end
     end
 

data/projects/{entities → typesystem}/projects/model/src/sensitive_value_removers/model.rb

@@ -12,7 +12,7 @@ module Foobara
           end
 
           Namespace.use(to_type.created_in_namespace) do
-            to_type.target_class.send(build_method, sanitized_attributes)
+            to_type.target_class.__send__(build_method, sanitized_attributes)
           end
         end
 

data/projects/typesystem/projects/namespace/src/ambiguous_registry.rb

@@ -22,15 +22,15 @@ module Foobara
         entry = registry[short_name]
 
         unless entry
-          # :nocov:
+          # simplecov:disable
           raise NotRegisteredError, "Not registered: #{short_name.inspect}"
-          # :nocov:
+          # simplecov:enable
         end
 
         unless entry.delete(scoped)
-          # :nocov:
+          # simplecov:disable
           raise NotRegisteredError, "Not registered: #{short_name.inspect}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -82,7 +82,7 @@ module Foobara
                   "Ambiguous match for #{path.inspect}. Matches the following: #{candidates.inspect}"
           end
 
-          candidates.first
+          candidates[0]
         end
       end
 

data/projects/typesystem/projects/namespace/src/base_registry.rb

@@ -7,9 +7,9 @@ module Foobara
       class NotRegisteredError < StandardError; end
 
       def register(_scoped)
-        # :nocov:
+        # simplecov:disable
         raise "Subclass responsibility"
-        # :nocov:
+        # simplecov:enable
       end
 
       def registered?(path)
@@ -17,15 +17,15 @@ module Foobara
       end
 
       def unregister(_scoped)
-        # :nocov:
+        # simplecov:disable
         raise "Subclass responsibility"
-        # :nocov:
+        # simplecov:enable
       end
 
       def lookup(_path, filter: nil)
-        # :nocov:
+        # simplecov:disable
         raise "Subclass responsibility"
-        # :nocov:
+        # simplecov:enable
       end
 
       # TODO: should return an enumerator
@@ -45,9 +45,9 @@ module Foobara
       end
 
       def each_scoped_without_filter(&)
-        # :nocov:
+        # simplecov:disable
         raise "Subclass responsibility"
-        # :nocov:
+        # simplecov:enable
       end
 
       def apply_filter(object, filter)

data/projects/typesystem/projects/namespace/src/is_namespace.rb

@@ -12,9 +12,9 @@ module Foobara
 
         if defined?(@foobara_categories)
           if @foobara_categories.empty?
-            # :nocov:
+            # simplecov:disable
             remove_instance_variable(:@foobara_categories)
-            # :nocov:
+            # simplecov:enable
           elsif scoped_namespace
             @foobara_categories = scoped_namespace.foobara_categories.merge(@foobara_categories)
           end
@@ -26,9 +26,9 @@ module Foobara
 
         if namespace
           if namespace.foobara_children.include?(self)
-            # :nocov:
+            # simplecov:disable
             raise "Already registered on parent"
-            # :nocov:
+            # simplecov:enable
           end
 
           namespace.foobara_children << self
@@ -88,9 +88,9 @@ module Foobara
           scopedish = foobara_lookup(scopedish)
 
           unless scopedish
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Cannot unregister non-existent #{scopedish}"
-            # :nocov:
+            # simplecov:enable
           end
         end
 
@@ -181,13 +181,13 @@ module Foobara
           end.compact
 
           if candidates.size > 1
-            # :nocov:
+            # simplecov:disable
             raise AmbiguousLookupError,
                   "#{path} is ambiguous. Matches the following: #{candidates.map(&:scoped_full_name)}"
-            # :nocov:
+            # simplecov:enable
           end
 
-          scoped = candidates.first ||
+          scoped = candidates[0] ||
                    foobara_parent_namespace&.foobara_lookup_without_cache(path, filter:, mode:, visited:)
 
           scoped ||= foobara_lookup_without_cache(
@@ -290,12 +290,12 @@ module Foobara
         end.compact
 
         if candidates.size > 1
-          # :nocov:
+          # simplecov:disable
           raise AmbiguousLookupError, "Multiple things matched #{path}"
-          # :nocov:
+          # simplecov:enable
         end
 
-        candidates.first || partial
+        candidates[0] || partial
       end
 
       def foobara_parent_namespace
@@ -306,9 +306,9 @@ module Foobara
         object = foobara_lookup(name, **)
 
         unless object
-          # :nocov:
+          # simplecov:disable
           raise NotFoundError, "Could not find #{name}"
-          # :nocov:
+          # simplecov:enable
         end
 
         object
@@ -356,11 +356,11 @@ module Foobara
 
         if filter
           method = "foobara_#{method}#{"!" if bang}"
-          send(method, *, **, filter:, &)
+          __send__(method, *, **, filter:, &)
         else
-          # :nocov:
+          # simplecov:disable
           super
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -405,9 +405,9 @@ module Foobara
                              when Foobara::Namespace::BaseRegistry::WouldMakeRegistryAmbiguousError
                                Foobara::Namespace::AmbiguousRegistry
                              else
-                               # :nocov:
+                               # simplecov:disable
                                raise ArgumentError, "Not sure how to upgrade a #{error.class}"
-                               # :nocov:
+                               # simplecov:enable
                              end
 
         old_registry = foobara_registry

data/projects/typesystem/projects/namespace/src/namespace/lookup_mode.rb

@@ -48,9 +48,9 @@ module Foobara
       class << self
         def validate!(mode)
           unless ALL.include?(mode)
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Expected #{mode} to be one of #{ALL.map(&:inspect).join(",")}"
-            # :nocov:
+            # simplecov:enable
           end
         end
       end

data/projects/typesystem/projects/namespace/src/namespace.rb

@@ -15,9 +15,9 @@ module Foobara
 
       def use(namespace)
         unless namespace.is_a?(Namespace::IsNamespace)
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Expected #{namespace} to be a namespace"
-          # :nocov:
+          # simplecov:enable
         end
 
         old_namespace = current
@@ -46,9 +46,9 @@ module Foobara
         when Foobara::Scoped
           object.scoped_path
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Expected #{object} to be a string, symbol, array, or Foobara::IsScoped"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -60,7 +60,7 @@ module Foobara
 
       def fire_changed!
         @on_change&.each_pair do |object, method_name|
-          object.send(method_name)
+          object.__send__(method_name)
         end
       end
 

data/projects/typesystem/projects/namespace/src/namespace_helpers.rb

@@ -60,9 +60,9 @@ module Foobara
           if Foobara::Util.super_method_takes_parameters?(self, AutoRegisterInstances, __method__)
             super
           else
-            # :nocov:
+            # simplecov:disable
             super()
-            # :nocov:
+            # simplecov:enable
           end
 
           ns = scoped_namespace || self.class.scoped_default_namespace
@@ -77,9 +77,9 @@ module Foobara
 
         def initialize(*, **, &)
           if Foobara::Util.super_method_takes_parameters?(self, InstancesAreNamespaces, __method__)
-            # :nocov:
+            # simplecov:disable
             super
-            # :nocov:
+            # simplecov:enable
           else
             super()
           end

data/projects/typesystem/projects/namespace/src/prefixless_registry.rb

@@ -23,9 +23,9 @@ module Foobara
         key = to_key(scoped)
 
         unless registry.key?(key)
-          # :nocov:
+          # simplecov:disable
           raise NotRegisteredError, "#{key} is not registered"
-          # :nocov:
+          # simplecov:enable
         end
 
         registry.delete(key)
@@ -33,7 +33,7 @@ module Foobara
 
       def lookup(path, filter = nil)
         if path.size == 1
-          apply_filter(registry[path.first], filter)
+          apply_filter(registry[path[0]], filter)
         end
       end
 

data/projects/typesystem/projects/namespace/src/scoped.rb

@@ -8,15 +8,15 @@ module Foobara
     def scoped_path
       if scoped_unregistered?
         # TODO: can probably delete this defensive check
-        # :nocov:
+        # simplecov:disable
         raise "Cannot use unregistered Scoped object"
-        # :nocov:
+        # simplecov:enable
       end
 
       unless defined?(@scoped_path)
-        # :nocov:
+        # simplecov:disable
         raise NoScopedPathSetError, "No scoped path set. Explicitly set it to nil if that's what you want."
-        # :nocov:
+        # simplecov:enable
       end
 
       @scoped_path
@@ -62,7 +62,7 @@ module Foobara
     end
 
     def scoped_short_name
-      @scoped_short_name ||= scoped_path.last
+      @scoped_short_name ||= scoped_path[-1]
     end
 
     def scoped_short_path
@@ -90,9 +90,9 @@ module Foobara
     def foobara_manifest_reference
       if scoped_unregistered?
         # TODO: can probably delete this defensive check
-        # :nocov:
+        # simplecov:disable
         raise "Cannot use unregistered Scoped object"
-        # :nocov:
+        # simplecov:enable
       end
 
       @foobara_manifest_reference ||= scoped_full_name

data/projects/typesystem/projects/project/src/foobara.rb

@@ -6,10 +6,10 @@ module Foobara
   class << self
     # TODO: let's eliminate this method
     def require_project_file(project, path)
-      # :nocov:
+      # simplecov:disable
       warn "DEPRECATION WARNING: require_project_file is deprecated. Use require_relative instead."
       require_relative("../../#{project}/src/#{path}")
-      # :nocov:
+      # simplecov:enable
     end
 
     attr_accessor :is_installed
@@ -20,9 +20,9 @@ module Foobara
 
     def project(symbol, project_path: nil)
       if all_projects.key?(symbol)
-        # :nocov:
+        # simplecov:disable
         raise ArgumentError, "Project #{symbol} already loaded"
-        # :nocov:
+        # simplecov:enable
       end
 
       project = Project.new(symbol, project_path:)
@@ -51,13 +51,19 @@ module Foobara
     end
 
     def reset_alls
-      raise_if_production!("reset_alls")
+      raise_if_production!
       all_projects.each_value(&:reset_all)
     end
 
-    def raise_if_production!(*)
+    def raise_if_production!(method_name = nil)
+      if method_name
+        warn "DEPRECATION WARNING: Passing method_name is deprecated."
+      else
+        method_name = caller_locations.map(&:label).find { |label| !label.start_with?("block in") }
+      end
+
       if ENV["FOOBARA_ENV"].nil? || ENV["FOOBARA_ENV"] == "production"
-        raise MethodCantBeCalledInProductionError
+        raise MethodCantBeCalledInProductionError, method_name
       end
     end
   end

data/projects/typesystem/projects/project/src/project.rb

@@ -36,7 +36,7 @@ module Foobara
     end
 
     def reset_all
-      Foobara.raise_if_production!("reset_all")
+      Foobara.raise_if_production!
 
       if self.module.respond_to?(:reset_all)
         self.module.reset_all