foobara 0.5.10 → 0.6.2

data/projects/typesystem/projects/types/src/type/concerns/reflection.rb

@@ -25,9 +25,9 @@ module Foobara
                             when Type
                               if remove_sensitive && element_types.sensitive?
                                 # TODO: test this code path
-                                # :nocov:
+                                # simplecov:disable
                                 []
-                                # :nocov:
+                                # simplecov:enable
                               else
                                 [element_types]
                               end
@@ -44,9 +44,9 @@ module Foobara
                                 element_types
                               end
                             else
-                              # :nocov:
+                              # simplecov:disable
                               raise "Not sure how to find dependent types for #{element_types}"
-                              # :nocov:
+                              # simplecov:enable
                             end
             end
 
@@ -99,9 +99,9 @@ module Foobara
             next_type = case path_part
                         when :"#"
                           unless element_type
-                            # :nocov:
+                            # simplecov:disable
                             raise "Expected element_type to be set but is not"
-                            # :nocov:
+                            # simplecov:enable
                           end
 
                           element_type
@@ -109,29 +109,29 @@ module Foobara
                           case element_types
                           when ::Hash
                             unless element_types.key?(path_part)
-                              # :nocov:
+                              # simplecov:disable
                               raise "Expected element type to have key #{path_part} but does not"
-                              # :nocov:
+                              # simplecov:enable
                             end
 
                             element_types[path_part]
                           when Types::Type
                             unless element_types.extends?(BuiltinTypes[:attributes])
-                              # :nocov:
+                              # simplecov:disable
                               raise "Expected element type to be a Type but is not"
-                              # :nocov:
+                              # simplecov:enable
                             end
 
                             # TODO: We assume it's attributes here but maybe we should assert that
                             element_types.element_types[path_part]
                           when nil
-                            # :nocov:
+                            # simplecov:disable
                             raise "Expected element_types to be set but is not"
-                            # :nocov:
+                            # simplecov:enable
                           else
-                            # :nocov:
+                            # simplecov:disable
                             raise "Unsure how to handle path part #{path_part}"
-                            # :nocov:
+                            # simplecov:enable
                           end
                         when Integer
                           if extends?(BuiltinTypes[:tuple])
@@ -139,20 +139,20 @@ module Foobara
                           elsif extends?(BuiltinTypes[:array])
                             element_type
                           else
-                            # :nocov:
+                            # simplecov:disable
                             raise "Unsure how to handle path part #{path_part}"
-                            # :nocov:
+                            # simplecov:enable
                           end
                         else
-                          # :nocov:
+                          # simplecov:disable
                           raise "Bad path part #{path_part}"
-                          # :nocov:
+                          # simplecov:enable
                         end
 
             unless next_type
-              # :nocov:
+              # simplecov:disable
               raise "Expected to find a type at #{path_part}"
-              # :nocov:
+              # simplecov:enable
             end
 
             if path_parts.empty?
@@ -163,7 +163,7 @@ module Foobara
           end
 
           def inspect
-            # :nocov:
+            # simplecov:disable
             name = if scoped_path_set?
                      scoped_full_name
                    else
@@ -171,7 +171,7 @@ module Foobara
                    end
 
             "#<Type:#{name}:0x#{object_id.to_s(16)} #{declaration_data}>"
-            # :nocov:
+            # simplecov:enable
           end
         end
       end

data/projects/typesystem/projects/types/src/type/concerns/supported_processor_registration.rb

@@ -38,15 +38,15 @@ module Foobara
 
           def register_supported_processor_class(processor_class, symbol: processor_class.symbol)
             unless symbol.is_a?(Symbol)
-              # :nocov:
+              # simplecov:disable
               raise "Invalid symbol value #{symbol.inspect}. Should instead be a symbol but was a #{symbol.class.name}"
-              # :nocov:
+              # simplecov:enable
             end
 
             if supported_processor_classes.key?(symbol)
-              # :nocov:
+              # simplecov:disable
               raise "There's already a processor registered for #{symbol}"
-              # :nocov:
+              # simplecov:enable
             end
 
             supported_processor_classes[symbol] = processor_class

data/projects/typesystem/projects/types/src/type.rb

@@ -185,20 +185,20 @@ module Foobara
 
       def target_class
         if target_classes.empty?
-          # :nocov:
+          # simplecov:disable
           # TODO: We really need a better error message when we hit this point in the code path.
           # One thing that can cause this is if you create a custom type called :model but it isn't loaded
           # yet and we accidentally are referring to the builtin :model type.  This error message doesn't reveal
           # that you need to require the custom :model.
           raise "No target classes"
-          # :nocov:
+          # simplecov:enable
         elsif target_classes.size > 1
-          # :nocov:
+          # simplecov:disable
           raise "Cannot use #target_class because this type has multiple target_classes"
-          # :nocov:
+          # simplecov:enable
         end
 
-        target_classes.first
+        target_classes[0]
       end
 
       def extends?(type)
@@ -208,16 +208,16 @@ module Foobara
         when Symbol, String
           concrete_type = created_in_namespace.foobara_lookup_type(type)
           if concrete_type.nil?
-            # :nocov:
+            # simplecov:disable
             raise "No type found for #{type}"
-            # :nocov:
+            # simplecov:enable
           end
 
           extends_type?(concrete_type)
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Expected a Type or a Symbol/String, but got #{type.inspect}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -229,16 +229,16 @@ module Foobara
           concrete_type = created_in_namespace.foobara_lookup_type(type)
 
           if concrete_type.nil?
-            # :nocov:
+            # simplecov:disable
             raise "No type found for #{type}"
-            # :nocov:
+            # simplecov:enable
           end
 
           extends_directly?(concrete_type)
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Expected a Type or a Symbol/String, but got #{type.inspect}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -246,9 +246,9 @@ module Foobara
         return true if self == type
 
         unless type
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Expected a type but got nil"
-          # :nocov:
+          # simplecov:enable
         end
 
         if registered?
@@ -555,22 +555,22 @@ module Foobara
                      when Value::Caster
                        casters
                      when Value::Validator
-                       # :nocov:
+                       # simplecov:disable
                        validators
-                       # :nocov:
+                       # simplecov:enable
                      when Value::Transformer
-                       # :nocov:
+                       # simplecov:disable
                        transformers
-                       # :nocov:
+                       # simplecov:enable
                      when Types::ElementProcessor
-                       # :nocov:
+                       # simplecov:disable
                        element_processors
-                       # :nocov:
+                       # simplecov:enable
                      else
                        # TODO: add validator that these are all fine so we don't have to bother here...
-                       # :nocov:
+                       # simplecov:disable
                        raise "Not sure where to put #{processor}"
-                       # :nocov:
+                       # simplecov:enable
                      end
 
           symbol = processor.symbol
@@ -598,9 +598,9 @@ module Foobara
                   processor_group.delete(member)
                 end
               else
-                # :nocov:
+                # simplecov:disable
                 raise "Type #{name} has multiple processors with symbol #{symbol}"
-                # :nocov:
+                # simplecov:enable
               end
             end
           end

data/projects/typesystem/projects/value/src/caster.rb

@@ -23,9 +23,9 @@ module Foobara
           invalid_options = options.keys - allowed
 
           unless invalid_options.empty?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Invalid options #{invalid_options} expected only #{allowed}"
-            # :nocov:
+            # simplecov:enable
           end
 
           name ||= "#{self.name}::Anon#{SecureRandom.hex}"
@@ -59,15 +59,15 @@ module Foobara
       end
 
       def applicable?(_value)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def applies_message
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def transform(value)
@@ -75,9 +75,9 @@ module Foobara
       end
 
       def cast(_value)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
     end
   end

data/projects/typesystem/projects/value/src/data_error.rb

@@ -15,7 +15,7 @@ module Foobara
       def attribute_name
         # TODO: feels awkward... something is not right
         # how is path actually set?
-        path.last || context[:attribute_name]
+        path[-1] || context[:attribute_name]
       end
 
       def eql?(other)

data/projects/typesystem/projects/value/src/mutator.rb

@@ -12,9 +12,9 @@ module Foobara
       end
 
       def mutate(_value)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def process_value(value)

data/projects/typesystem/projects/value/src/processor/casting.rb

@@ -23,9 +23,9 @@ module Foobara
 
         class << self
           def foobara_manifest
-            # :nocov:
+            # simplecov:disable
             super.merge(processor_type: :casting)
-            # :nocov:
+            # simplecov:enable
           end
 
           def error_classes
@@ -99,9 +99,9 @@ module Foobara
           if error_class == NoApplicableProcessorError
             build_error(*args)
           elsif error_class == MoreThanOneApplicableProcessorError
-            # :nocov:
+            # simplecov:disable
             raise "Matched too many casters for #{args.map(&:inspect).join(",")} with #{opts.inspect}"
-            # :nocov:
+            # simplecov:enable
           else
             super
           end
@@ -110,9 +110,9 @@ module Foobara
         def cast_to
           # TODO: isn't there a way to declare declaration_data_type so we don't have to validate here??
           unless declaration_data.key?(:cast_to)
-            # :nocov:
+            # simplecov:disable
             raise "Missing cast_to"
-            # :nocov:
+            # simplecov:enable
           end
 
           declaration_data[:cast_to]

data/projects/typesystem/projects/value/src/processor/pipeline.rb

@@ -6,9 +6,9 @@ module Foobara
       class Pipeline < Multi
         class << self
           def foobara_manifest
-            # :nocov:
+            # simplecov:disable
             super.merge(processor_type: :pipeline)
-            # :nocov:
+            # simplecov:enable
           end
         end
 

data/projects/typesystem/projects/value/src/processor/runner.rb

@@ -11,7 +11,7 @@ module Foobara
                 if instance_variables.include?(instance_variable)
                   instance_variable_get(instance_variable)
                 else
-                  instance_variable_set(instance_variable, processor.send(method_name, value))
+                  instance_variable_set(instance_variable, processor.__send__(method_name, value))
                 end
               end
             end

data/projects/typesystem/projects/value/src/processor/selection.rb

@@ -10,9 +10,9 @@ module Foobara
 
         class << self
           def foobara_manifest
-            # :nocov:
+            # simplecov:disable
             super.merge(processor_type: :selection)
-            # :nocov:
+            # simplecov:enable
           end
         end
 
@@ -61,7 +61,7 @@ module Foobara
                           )
                         end
 
-                        applicable_processors.first
+                        applicable_processors[0]
                       else
                         processors.find { |processor| processor.applicable?(value) }
                       end

data/projects/typesystem/projects/value/src/processor.rb

@@ -53,9 +53,9 @@ module Foobara
           invalid_keys = rest.keys - allowed_keys
 
           unless invalid_keys.empty?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Invalid keys: #{invalid_keys.join(", ")} expected one of #{allowed_keys.join(", ")}"
-            # :nocov:
+            # simplecov:enable
           end
 
           args = []
@@ -83,9 +83,9 @@ module Foobara
         def instance
           @instance ||= begin
             if requires_parent_declaration_data?
-              # :nocov:
+              # simplecov:disable
               raise "Cannot treat processors dependent on parent declaration data as singletons"
-              # :nocov:
+              # simplecov:enable
             end
 
             requires_declaration_data? ? new(default_declaration_data) : new
@@ -103,9 +103,9 @@ module Foobara
                              end
 
             if error_klasses.sort_by(&:name) != error_klasses2.sort_by(&:name)
-              # :nocov:
+              # simplecov:disable
               raise "Expected #{error_klasses} to equal #{error_klasses2} for #{name}"
-              # :nocov:
+              # simplecov:enable
             end
 
             if superclass < Processor
@@ -120,12 +120,12 @@ module Foobara
           return @error_class if defined?(@error_class)
 
           unless error_classes.size == 1
-            # :nocov:
+            # simplecov:disable
             raise "Expected exactly one error class to be defined for #{name} but has #{error_classes.size}"
-            # :nocov:
+            # simplecov:enable
           end
 
-          @error_class = error_classes.first
+          @error_class = error_classes[0]
         end
 
         def symbol
@@ -154,9 +154,9 @@ module Foobara
         expected_arg_count += 1 if requires_parent_declaration_data?
 
         unless expected_arg_count == args.count
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "#{name} expected #{expected_arg_count} received #{args.count}"
-          # :nocov:
+          # simplecov:enable
         end
 
         if requires_declaration_data?
@@ -164,7 +164,7 @@ module Foobara
         end
 
         if requires_parent_declaration_data?
-          self.parent_declaration_data = args.first
+          self.parent_declaration_data = args[0]
         end
       end
 
@@ -231,9 +231,9 @@ module Foobara
       end
 
       def process_value(_value)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def process_value!(value)
@@ -264,9 +264,9 @@ module Foobara
         **
       )
         unless error_classes.include?(error_class)
-          # :nocov:
+          # simplecov:disable
           raise "invalid error"
-          # :nocov:
+          # simplecov:enable
         end
 
         error_class.new(
@@ -299,9 +299,9 @@ module Foobara
         invalid_opts = opts.keys - valid_opts
 
         unless invalid_opts.empty?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Invalid opts #{invalid_opts.inspect} expected only #{valid_opts.inspect}"
-          # :nocov:
+          # simplecov:enable
         end
 
         declaration_data = if opts.key?(:declaration_data)
@@ -322,9 +322,9 @@ module Foobara
         s = super
 
         if s.size > 400
-          # :nocov:
+          # simplecov:disable
           s = "#{s[0..400]}..."
-          # :nocov:
+          # simplecov:enable
         end
 
         s
@@ -363,9 +363,9 @@ module Foobara
         if method == symbol
           declaration_data
         else
-          # :nocov:
+          # simplecov:disable
           super
-          # :nocov:
+          # simplecov:enable
         end
       end
 

data/projects/typesystem/projects/value/src/transformer.rb

@@ -31,9 +31,9 @@ module Foobara
           invalid_options = options.keys - allowed
 
           unless invalid_options.empty?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Invalid options #{invalid_options} expected only #{allowed}"
-            # :nocov:
+            # simplecov:enable
           end
 
           name ||= "#{self.name}::Anon#{SecureRandom.hex}"
@@ -67,9 +67,9 @@ module Foobara
       end
 
       def transform(_value)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def process_value(value)

data/projects/typesystem/projects/value/src/validator.rb

@@ -13,9 +13,9 @@ module Foobara
 
       # Should a Validator only return one type of error?
       def validation_errors(_value)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def process_value(value)

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.5.10".freeze
-    MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
+    VERSION = "0.6.2".freeze
+    MINIMUM_RUBY_VERSION = [">= 3.4.0", "< 4.1"].freeze
   end
 end