foobara 0.5.10 → 0.6.2

data/projects/command_connectors/src/command_registry.rb

@@ -64,11 +64,11 @@ module Foobara
 
       domain_module.foobara_depends_on.each do |domain_name|
         # TODO: test this code path!!
-        # :nocov:
+        # simplecov:disable
         unless foobara_domain_registered?(domain_name)
           build_and_register_exposed_domain(domain_name)
         end
-        # :nocov:
+        # simplecov:enable
       end
 
       exposed_domain
@@ -81,10 +81,10 @@ module Foobara
 
     def global_organization
       # TODO: test this
-      # :nocov:
+      # simplecov:disable
       foobara_lookup_organization("", mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE) ||
         build_and_register_exposed_organization("")
-      # :nocov:
+      # simplecov:enable
     end
 
     def build_and_register_exposed_organization(full_organization_name)
@@ -121,9 +121,9 @@ module Foobara
       allowed_rule = to_allowed_rule(*)
 
       unless allowed_rule.symbol
-        # :nocov:
+        # simplecov:disable
         raise "Cannot register a rule without a symbol"
-        # :nocov:
+        # simplecov:enable
       end
 
       allowed_rule_registry[allowed_rule.symbol] = allowed_rule
@@ -204,13 +204,19 @@ module Foobara
       end
     end
 
+    # Why are we calling this _name instead of _reference??
+    def create_exposed_domain_if_needed(full_domain_name)
+      foobara_lookup_domain(
+        full_domain_name,
+        mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE
+      ) || build_and_register_exposed_domain(full_domain_name)
+    end
+
     private
 
     def create_exposed_command(command_class, **opts)
       full_domain_name = command_class.domain.scoped_full_name
-      exposed_domain = foobara_lookup_domain(full_domain_name,
-                                             mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE) ||
-                       build_and_register_exposed_domain(full_domain_name)
+      exposed_domain = create_exposed_domain_if_needed(full_domain_name)
 
       if !opts.key?(:allowed_rule) && allow&.key?(command_class)
         opts = opts.merge(allowed_rule: allow[command_class])
@@ -226,13 +232,13 @@ module Foobara
     def to_allowed_rule(*args)
       symbol, object = case args.size
                        when 1
-                         [nil, args.first]
+                         [nil, args[0]]
                        when 2
                          args
                        else
-                         # :nocov:
+                         # simplecov:disable
                          raise ArgumentError, "Expected 1 or 2 arguments, got #{args.size}"
-                         # :nocov:
+                         # simplecov:enable
                        end
 
       case object
@@ -240,9 +246,9 @@ module Foobara
         object
       when ::String
         if symbol
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Was not expecting a symbol and a string"
-          # :nocov:
+          # simplecov:enable
         end
 
         to_allowed_rule(object.to_sym)
@@ -250,9 +256,9 @@ module Foobara
         allowed_rule = allowed_rule_registry[object]
 
         unless allowed_rule
-          # :nocov:
+          # simplecov:disable
           raise "No allowed rule found for #{object}"
-          # :nocov:
+          # simplecov:enable
         end
 
         allowed_rule
@@ -292,9 +298,9 @@ module Foobara
         if object.respond_to?(:call)
           AllowedRule.new(symbol:, &object)
         else
-          # :nocov:
+          # simplecov:disable
           raise "Not sure how to convert #{object} into an AllowedRule object"
-          # :nocov:
+          # simplecov:enable
         end
       end.tap do |rule|
         rule.symbol ||= symbol

data/projects/command_connectors/src/desugarizer.rb

@@ -19,9 +19,9 @@ module Foobara
         if left.is_a?(::Hash) && right.is_a?(::Hash)
           # TODO: remove :nocov: once we have an only: and/or reject: desugarizer with a test that
           # merges them together.
-          # :nocov:
+          # simplecov:disable
           left.merge(right)
-          # :nocov:
+          # simplecov:enable
         else
           Util.array(left) + Util.array(right)
         end

data/projects/command_connectors/src/desugarizers/attributes.rb

@@ -5,15 +5,15 @@ module Foobara
     module Desugarizers
       class Attributes < Desugarizer
         def desugarizer_symbol
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def opts_key
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def applicable?(args_and_opts)
@@ -40,13 +40,13 @@ module Foobara
           transformers = transformers.map do |transformer|
             if transformer.is_a?(::Hash) && transformer.key?(desugarizer_symbol)
               params = transformer[desugarizer_symbol]
-              AttributesTransformers.send(transformer_method, *params)
+              AttributesTransformers.__send__(transformer_method, *params)
             else
               transformer
             end
           end
 
-          transformers = transformers.first unless is_array
+          transformers = transformers[0] unless is_array
 
           opts = opts.merge(opts_key => transformers)
 

data/projects/command_connectors/src/desugarizers/auth.rb

@@ -3,7 +3,7 @@ module Foobara
     module Desugarizers
       class Auth < Desugarizer
         def applicable?(args_and_opts)
-          args_and_opts.last.key?(:auth)
+          args_and_opts[-1].key?(:auth)
         end
 
         def desugarize(args_and_opts)

data/projects/command_connectors/src/desugarizers/set_inputs.rb

@@ -30,13 +30,13 @@ module Foobara
               AttributesTransformers.set(transformer[:set])
             else
               # TODO: add a test for this
-              # :nocov:
+              # simplecov:disable
               transformer
-              # :nocov:
+              # simplecov:enable
             end
           end
 
-          transformers = transformers.first unless is_array
+          transformers = transformers[0] unless is_array
 
           opts = opts.merge(inputs_transformers: transformers)
 

data/projects/command_connectors/src/desugarizers/symbols_to_true.rb

@@ -20,9 +20,9 @@ module Foobara
             if arg.is_a?(::Symbol)
               new_opts[arg] = true
             else
-              # :nocov:
+              # simplecov:disable
               raise "Was not expecting non-symbol arg: #{arg}"
-              # :nocov:
+              # simplecov:enable
             end
           end
 

data/projects/command_connectors/src/request_mutator.rb

@@ -2,9 +2,9 @@ module Foobara
   module CommandConnectors
     class RequestMutator < Foobara::Value::Mutator
       def inputs_type_declaration_from(_inputs_type)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def inputs_type_from(inputs_type)
@@ -13,9 +13,9 @@ module Foobara
       end
 
       def mutate
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       alias request declaration_data

data/projects/command_connectors/src/response_mutator.rb

@@ -2,9 +2,9 @@ module Foobara
   module CommandConnectors
     class ResponseMutator < Foobara::Value::Mutator
       def result_type_declaration_from(_result_type)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def result_type_from(result_type)
@@ -13,9 +13,9 @@ module Foobara
       end
 
       def mutate
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       alias response declaration_data

data/projects/command_connectors/src/transformed_command.rb

@@ -19,6 +19,7 @@ module Foobara
                     :request_mutators,
                     :allowed_rule,
                     :requires_authentication,
+                    :authentication_optional,
                     :authenticator,
                     :subclassed_in_namespace,
                     :suffix,
@@ -39,6 +40,7 @@ module Foobara
         allowed_rule:,
         requires_authentication:,
         authenticator:,
+        authentication_optional: nil,
         suffix: nil,
         capture_unknown_error: false
       )
@@ -56,6 +58,7 @@ module Foobara
           klass.request_mutators = Util.array(request_mutators)
           klass.allowed_rule = allowed_rule
           klass.requires_authentication = requires_authentication
+          klass.authentication_optional = authentication_optional
           klass.authenticator = authenticator
           klass.subclassed_in_namespace = scoped_namespace
           klass.suffix = suffix
@@ -63,15 +66,15 @@ module Foobara
       end
 
       def domain
-        # :nocov:
+        # simplecov:disable
         command_class.domain
-        # :nocov:
+        # simplecov:enable
       end
 
       def organization
-        # :nocov:
+        # simplecov:disable
         command_class.organization
-        # :nocov:
+        # simplecov:enable
       end
 
       def description
@@ -307,9 +310,9 @@ module Foobara
             if type.registered?
               # TODO: if we ever change from attributes-only inputs type
               # then this will be handy
-              # :nocov:
+              # simplecov:disable
               types |= [type]
-              # :nocov:
+              # simplecov:enable
             end
 
             types |= type.types_depended_on
@@ -321,9 +324,9 @@ module Foobara
             if type.registered?
               # TODO: if we ever change from attributes-only inputs type
               # then this will be handy
-              # :nocov:
+              # simplecov:disable
               types |= [type]
-              # :nocov:
+              # simplecov:enable
             end
 
             types |= type.types_depended_on
@@ -447,7 +450,7 @@ module Foobara
         end
 
         @inputs_transformer = if transformers.size == 1
-                                transformers.first
+                                transformers[0]
                               else
                                 Value::Processor::Pipeline.new(processors: transformers)
                               end
@@ -468,7 +471,7 @@ module Foobara
           transformers = transformers_to_processors(response_mutators, result_type_from_transformers, direction: :from)
 
           if transformers.size == 1
-            transformers.first
+            transformers[0]
           else
             Value::Processor::Pipeline.new(processors: transformers)
           end
@@ -490,7 +493,7 @@ module Foobara
           transformers = transformers_to_processors(request_mutators, inputs_type_from_transformers, direction: :to)
 
           if transformers.size == 1
-            transformers.first
+            transformers[0]
           else
             Value::Processor::Pipeline.new(processors: transformers)
           end
@@ -515,7 +518,7 @@ module Foobara
           transformers = transformers_to_processors(result_transformers, command_class.result_type, direction: :from)
 
           if transformers.size == 1
-            transformers.first
+            transformers[0]
           else
             Value::Processor::Pipeline.new(processors: transformers)
           end
@@ -540,9 +543,9 @@ module Foobara
           elsif transformer.respond_to?(:call)
             Value::Transformer.create(transform: transformer)
           else
-            # :nocov:
+            # simplecov:disable
             raise "Not sure how to apply #{transformer}"
-            # :nocov:
+            # simplecov:enable
           end
         end
       end
@@ -575,7 +578,7 @@ module Foobara
               klass.foobara_manifest_reference
               # TODO: Delete this nocov block
               # TODO: make anonymous scoped path's have better names instead of random hexadecimal
-              # :nocov:
+              # simplecov:disable
             elsif processor.respond_to?(:symbol) && processor.symbol
               processor.symbol
             else
@@ -587,14 +590,14 @@ module Foobara
               end
 
               "Anonymous#{Util.non_full_name(name)}"
-              # :nocov:
+              # simplecov:enable
             end
           elsif processor.is_a?(::Proc)
             "Proc"
           else
-            # :nocov:
+            # simplecov:disable
             "Unknown"
-            # :nocov:
+            # simplecov:enable
           end
         end
       end
@@ -610,15 +613,15 @@ module Foobara
     end
 
     def full_command_name
-      # :nocov:
+      # simplecov:disable
       self.class.full_command_name
-      # :nocov:
+      # simplecov:enable
     end
 
     def command_name
-      # :nocov:
+      # simplecov:disable
       self.class.command_name
-      # :nocov:
+      # simplecov:enable
     end
 
     def command_class
@@ -630,15 +633,15 @@ module Foobara
     end
 
     def inputs_transformers
-      # :nocov:
+      # simplecov:disable
       self.class.inputs_transformers
-      # :nocov:
+      # simplecov:enable
     end
 
     def result_transformers
-      # :nocov:
+      # simplecov:disable
       self.class.result_transformers
-      # :nocov:
+      # simplecov:enable
     end
 
     def errors_transformers
@@ -729,7 +732,7 @@ module Foobara
       transformers = self.class.transformers_to_processors(serializers, nil, declaration_data: self)
 
       if transformers.size == 1
-        transformers.first
+        transformers[0]
       else
         Value::Processor::Pipeline.new(processors: transformers)
       end
@@ -742,7 +745,7 @@ module Foobara
                                                                                      declaration_data: self)
 
       if transformers.size == 1
-        transformers.first
+        transformers[0]
       else
         Value::Processor::Pipeline.new(processors: transformers)
       end
@@ -759,7 +762,7 @@ module Foobara
       )
 
       if transformers.size == 1
-        transformers.first
+        transformers[0]
       else
         Value::Processor::Pipeline.new(processors: transformers)
       end
@@ -790,11 +793,11 @@ module Foobara
       if auth_mapped_method?(method_name)
         auth_mapped_value_for(method_name)
       elsif command.respond_to?(method_name)
-        command.send(method_name, ...)
+        command.__send__(method_name, ...)
       else
-        # :nocov:
+        # simplecov:disable
         super
-        # :nocov:
+        # simplecov:enable
       end
     end
 
@@ -851,9 +854,9 @@ module Foobara
               source = if allowed_rule.block.respond_to?("source") && defined?(MethodSource)
                          begin
                            # This only works when pry is loaded
-                           # :nocov:
+                           # simplecov:disable
                            allowed_rule.block.source
-                           # :nocov:
+                           # simplecov:enable
                          rescue MethodSource::SourceNotFoundError
                            # This path is hit if the way the source code is extracted
                            # doesn't result in valid Ruby, for example, as part of a hash such as:
@@ -900,9 +903,9 @@ module Foobara
       if capture_unknown_error
         self.outcome = Outcome.error(CommandConnector::UnknownError.for(e))
       else
-        # :nocov:
+        # simplecov:disable
         raise
-        # :nocov:
+        # simplecov:enable
       end
     end
 

data/projects/command_connectors/src/transformers/auth_errors_transformer.rb

@@ -26,9 +26,9 @@ module Foobara
         end
 
         def transform(_request)
-          # :nocov:
+          # simplecov:disable
           raise "Not expected to be called"
-          # :nocov:
+          # simplecov:enable
         end
       end
     end

data/projects/command_connectors/src/transformers/entity_to_primary_key_inputs_transformer.rb

@@ -75,9 +75,9 @@ module Foobara
               attributes_type = to_type.target_class.attributes_type
               EntityToPrimaryKeyInputsTransformer.new(to: attributes_type).from_type_declaration
             else
-              # :nocov:
+              # simplecov:disable
               raise "Not sure how to handle #{to_type}"
-              # :nocov:
+              # simplecov:enable
             end
           else
             to_type

data/projects/command_connectors/src/transformers/load_delegated_attributes_entities_pre_commit_transformer.rb

@@ -20,7 +20,7 @@ module Foobara
           case object
           when Entity
             object.class.delegates.each_key do |delegated_attribute_name|
-              object.send(delegated_attribute_name)
+              object.__send__(delegated_attribute_name)
             end
           when Array
             object.each do |element|

data/projects/domain_mapper/src/domain_mapper.rb

@@ -86,7 +86,7 @@ module Foobara
       # TODO: should this be somewhere more general-purpose?
       def args_to_type(*args, **opts, &block)
         if args.size == 1 && opts.empty? && block.nil?
-          object_to_type(args.first)
+          object_to_type(args[0])
         else
           domain.foobara_type_from_declaration(*args, **opts, &block)
         end
@@ -121,9 +121,9 @@ module Foobara
     end
 
     def map
-      # :nocov:
-      raise "subclass responsibility"
-      # :nocov:
+      # simplecov:disable
+      raise NotImplementedError
+      # simplecov:enable
     end
   end
 end

data/projects/domain_mapper/src/domain_mapper_lookups.rb

@@ -8,9 +8,9 @@ module Foobara
         invalid_keys = opts.keys - [:value]
 
         if invalid_keys.any?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Invalid keys: #{invalid_keys.join(", ")}. expected one of: #{valid_keys.join(", ")}"
-          # :nocov:
+          # simplecov:enable
         end
 
         if opts.key?(:value)
@@ -83,7 +83,7 @@ module Foobara
           end
         end
 
-        value = candidates.first
+        value = candidates[0]
 
         return value if value
 

data/projects/entities/projects/detached_entity/lib/foobara/detached_entity.rb

@@ -20,7 +20,7 @@ module Foobara
       end
 
       def reset_all
-        Foobara.raise_if_production!("reset_all")
+        Foobara.raise_if_production!
         install!
       end
     end