foobara 0.5.10 → 0.6.2

data/projects/entities/projects/detached_entity/src/concerns/associations.rb

@@ -59,13 +59,13 @@ module Foobara
                 values
               else
                 if values.size > 1
-                  # :nocov:
+                  # simplecov:disable
                   raise "Multiple records found for #{name} association but only expected 0 or 1."
-                  # :nocov:
+                  # simplecov:enable
                 end
 
                 unless values.empty?
-                  values.first
+                  values[0]
                 end
               end
             end
@@ -73,7 +73,7 @@ module Foobara
 
           def association_for(association_filters)
             if association_filters.size == 1
-              data_path = association_filters.first.to_s
+              data_path = association_filters[0].to_s
 
               if deep_associations.key?(data_path)
                 return data_path
@@ -85,15 +85,15 @@ module Foobara
             end
 
             if result.empty?
-              # :nocov:
+              # simplecov:disable
               raise "Could not find association matching #{association_filters}"
-              # :nocov:
+              # simplecov:enable
             elsif result.size > 1
-              # :nocov:
+              # simplecov:disable
               raise "Multiple associations matched by #{association_filters}"
-              # :nocov:
+              # simplecov:enable
             else
-              result.first
+              result[0]
             end
           end
 
@@ -121,9 +121,9 @@ module Foobara
                 entity_class == filter || entity_class < filter
               end
             else
-              # :nocov:
+              # simplecov:disable
               raise "Not sure how to apply filter #{filter}"
-              # :nocov:
+              # simplecov:enable
             end
           end
 
@@ -168,9 +168,9 @@ module Foobara
 
               if remove_sensitive
                 # TODO: test this code path
-                # :nocov:
+                # simplecov:disable
                 element_types = element_types&.reject(&:sensitive?)
-                # :nocov:
+                # simplecov:enable
               end
 
               element_types&.each&.with_index do |element_type, index|
@@ -196,19 +196,19 @@ module Foobara
               target_class = type.target_class
 
               method = target_class.respond_to?(:foobara_attributes_type) ? :foobara_attributes_type : :attributes_type
-              attributes_type = target_class.send(method)
+              attributes_type = target_class.__send__(method)
 
               if !remove_sensitive || !attributes_type.sensitive?
                 construct_associations(attributes_type, path, result, initial: false)
               end
             elsif type.extends?(BuiltinTypes[:associative_array])
               # not going to bother testing this for now
-              # :nocov:
+              # simplecov:disable
               if contains_associations?(type)
                 raise "Associative array types with associations in them are not currently supported. " \
                       "Use attributes type if you can or set the key_type and/or value_type to duck type"
               end
-              # :nocov:
+              # simplecov:enable
             end
 
             result
@@ -228,9 +228,9 @@ module Foobara
 
               if remove_sensitive
                 # TODO: test this code path
-                # :nocov:
+                # simplecov:disable
                 element_types = element_types&.reject(&:sensitive?)
-                # :nocov:
+                # simplecov:enable
               end
 
               contains_associations?(element_types, false)

data/projects/entities/projects/detached_entity/src/concerns/initialization.rb

@@ -20,9 +20,9 @@ module Foobara
           invalid_options = options.keys - ALLOWED_OPTIONS
 
           unless invalid_options.empty?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Invalid options #{invalid_options} expected only #{ALLOWED_OPTIONS}"
-            # :nocov:
+            # simplecov:enable
           end
 
           if options[:unloaded]

data/projects/entities/projects/detached_entity/src/concerns/primary_key.rb

@@ -11,15 +11,15 @@ module Foobara
         module ClassMethods
           def primary_key(attribute_name)
             if primary_key_attribute
-              # :nocov:
+              # simplecov:disable
               raise "Primary key already set to #{primary_key_attribute}"
-              # :nocov:
+              # simplecov:enable
             end
 
             if attribute_name.nil? || attribute_name.empty?
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Primary key can't be blank"
-              # :nocov:
+              # simplecov:enable
             end
 
             @foobara_primary_key_attribute = attribute_name.to_sym

data/projects/entities/projects/detached_entity/src/concerns/types.rb

@@ -5,9 +5,9 @@ module Foobara
         include Concern
 
         def full_entity_name
-          # :nocov:
+          # simplecov:disable
           self.class.full_entity_name
-          # :nocov:
+          # simplecov:enable
         end
 
         def entity_name

data/projects/entities/projects/detached_entity/src/detached_entity_type.rb

@@ -28,18 +28,18 @@ module Foobara
           # TODO: No longer is hit in this test suite but ActiveRecordType needs this class
           # and potentially this snippet of code in order to do the right thing.
           # TODO: test that out and delete this method if possible.
-          # :nocov:
+          # simplecov:disable
           declaration_data = declaration_data.merge(type: :detached_entity)
-          # :nocov:
+          # simplecov:enable
         end
 
         if self.class.model_base_class_requires_conversion?(declaration_data[:model_base_class])
           # TODO: No longer is hit in this test suite but ActiveRecordType needs this class
           # and potentially this snippet of code in order to do the right thing.
           # TODO: test that out and delete this method if possible.
-          # :nocov:
+          # simplecov:disable
           declaration_data = declaration_data.merge(model_base_class: "Foobara::DetachedEntity")
-          # :nocov:
+          # simplecov:enable
         end
 
         # TODO: remove private attributes, add delegated attributes

data/projects/entities/projects/detached_entity/src/extensions/builtin_types/detached_entity/casters/primary_key.rb

@@ -26,7 +26,7 @@ module Foobara
           end
 
           def transform(primary_key)
-            entity_class.send(build_method, primary_key)
+            entity_class.__send__(build_method, primary_key)
           end
 
           def applies_message

data/projects/entities/projects/detached_entity/src/extensions/builtin_types/detached_entity/validators/model_instance_is_valid.rb

@@ -26,9 +26,9 @@ module Foobara
               model_type = type_for_declaration(parent_declaration_data[:type])
               model_type.target_class
             else
-              # :nocov:
+              # simplecov:disable
               raise "Missing :model_class in parent_declaration_data for #{parent_declaration_data}"
-              # :nocov:
+              # simplecov:enable
             end
           end
 

data/projects/entities/projects/detached_entity/src/extensions/type_declarations/handlers/registered_type_declaration/validate_primary_key_present.rb

@@ -0,0 +1,30 @@
+module Foobara
+  module TypeDeclarations
+    module Handlers
+      class RegisteredTypeDeclaration < TypeDeclarationHandler
+        class ValidatePrimaryKeyPresent < TypeDeclarations::TypeDeclarationValidator
+          # TODO: seems like maybe we could actually check against types now...
+          # like make a type for primary_key: :symbol ??
+          class MissingPrimaryKeyError < TypeDeclarationError; end
+
+          def validation_errors(type_declaration)
+            if type_declaration.claimed_but_error?
+              klass = type_declaration.declaration_data
+
+              if klass.is_a?(::Class) && klass < ::Foobara::DetachedEntity
+                if klass.model_type.nil? && klass.primary_key_attribute.nil?
+                  build_error(
+                    message: "#{klass} doesn't have a primary key attribute set yet. " \
+                             "Did you forget something like `primary_key :id` in #{klass}?"
+                  )
+                end
+              end
+            end
+          end
+
+          def error_context(_value) ={}
+        end
+      end
+    end
+  end
+end

data/projects/entities/projects/detached_entity/src/remove_sensitive_values_transformer_extensions.rb

@@ -44,9 +44,9 @@ module Foobara
               already_sanitized << existing_type
               next
             else
-              # :nocov:
+              # simplecov:disable
               raise "Did not expect to be re-sanitizing #{entity_type.full_type_symbol}"
-              # :nocov:
+              # simplecov:enable
             end
 
           end

data/projects/entities/projects/entity/lib/foobara/entity.rb

@@ -23,7 +23,7 @@ module Foobara
       end
 
       def reset_all
-        Foobara.raise_if_production!("reset_all")
+        Foobara.raise_if_production!
         Entity::Concerns::Callbacks.reset_all
 
         install!

data/projects/entities/projects/entity/src/concerns/attributes.rb

@@ -26,21 +26,21 @@ module Foobara
 
             if attribute_name == primary_key_attribute
               if value.nil?
-                # :nocov:
+                # simplecov:disable
                 raise "Primary key cannot be set to a blank value"
-                # :nocov:
+                # simplecov:enable
               end
 
               if value.is_a?(::String) && value.empty?
-                # :nocov:
+                # simplecov:disable
                 raise "Primary key cannot be set to a blank value"
-                # :nocov:
+                # simplecov:enable
               end
 
               if value.is_a?(::Symbol) && value.to_s.empty?
-                # :nocov:
+                # simplecov:disable
                 raise "Primary key cannot be set to a blank value"
-                # :nocov:
+                # simplecov:enable
               end
 
               write_attribute!(attribute_name, value)

data/projects/entities/projects/entity/src/concerns/callbacks.rb

@@ -8,7 +8,7 @@ module Foobara
 
         class << self
           def reset_all
-            Foobara.raise_if_production!("reset_all")
+            Foobara.raise_if_production!
             Entity.instance_variable_set("@class_callback_registry", nil)
           end
         end

data/projects/entities/projects/entity/src/concerns/initialization.rb

@@ -29,9 +29,9 @@ module Foobara
 
             # TODO: is this possible?
             if record_id.nil?
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Primary key cannot be blank"
-              # :nocov:
+              # simplecov:enable
             end
 
             # check if tracked already...
@@ -58,9 +58,9 @@ module Foobara
             record = current_transaction_table.find_tracked(record_id)
 
             if record&.loaded?
-              # :nocov:
+              # simplecov:disable
               raise "Already loaded for #{attributes}. Bug maybe?"
-              # :nocov:
+              # simplecov:enable
             end
 
             record = __private_new__
@@ -68,9 +68,9 @@ module Foobara
             record.successfully_loaded(attributes)
 
             unless record.primary_key
-              # :nocov:
+              # simplecov:disable
               raise "Expected primary key #{primary_key_attribute} to be present!"
-              # :nocov:
+              # simplecov:enable
             end
 
             record.fire(:initialized)
@@ -104,9 +104,9 @@ module Foobara
 
         def successfully_loaded(attributes)
           if hard_deleted?
-            # :nocov:
+            # simplecov:disable
             raise "Not expecting to load a hard deleted record"
-            # :nocov:
+            # simplecov:enable
           end
 
           # TODO: why would we proceed if this is the case? Maybe raise?

data/projects/entities/projects/entity/src/concerns/mutations.rb

@@ -50,13 +50,13 @@ module Foobara
 
               object
             elsif type.extends?(BuiltinTypes[:tuple])
-              # :nocov:
+              # simplecov:disable
               raise "Tuple not yet supported"
-              # :nocov:
+              # simplecov:enable
             elsif type.extends?(BuiltinTypes[:associative_array])
-              # :nocov:
+              # simplecov:disable
               raise "Associated array not yet supported"
-              # :nocov:
+              # simplecov:enable
             elsif type.extends?(BuiltinTypes[:array])
               element_type = type.element_type
 

data/projects/entities/projects/entity/src/concerns/persistence.rb

@@ -62,7 +62,7 @@ module Foobara
 
           attribute_name = if attribute_name_or_attributes.is_a?(::Hash)
                              if attribute_name_or_attributes.keys.size == 1
-                               attribute_name_or_attributes.keys.first.to_sym
+                               attribute_name_or_attributes.keys[0].to_sym
                              end
                            elsif attribute_name_or_attributes
                              attribute_name_or_attributes.to_sym
@@ -75,9 +75,9 @@ module Foobara
           transaction = Foobara::Persistence::EntityBase::Transaction.open_transaction_for(self)
 
           unless transaction
-            # :nocov:
+            # simplecov:disable
             raise NoCurrentTransactionError, "Trying to load a #{entity_name} outside of a transaction."
-            # :nocov:
+            # simplecov:enable
           end
 
           unless transaction.loading?(self)

data/projects/entities/projects/entity/src/concerns/queries.rb

@@ -57,7 +57,7 @@ module Foobara
 
             if load_paths
               if load_paths.is_a?(::Array)
-                first = load_paths.first
+                first = load_paths[0]
 
                 if first.is_a?(::Symbol) || (first.is_a?(::String) && !first.include?("."))
                   load_paths = [load_paths]
@@ -99,8 +99,8 @@ module Foobara
           end
 
           def load_many(*record_ids)
-            if record_ids.size == 1 && record_ids.first.is_a?(::Array)
-              record_ids = record_ids.first
+            if record_ids.size == 1 && record_ids[0].is_a?(::Array)
+              record_ids = record_ids[0]
             end
 
             current_transaction_table.load_many(record_ids)
@@ -125,11 +125,11 @@ module Foobara
 
             unless containing_records.empty?
               if containing_records.size == 1
-                containing_records.first
+                containing_records[0]
               else
-                # :nocov:
+                # simplecov:disable
                 raise "Expected only one record to own #{record} but found #{containing_records.size}"
-                # :nocov:
+                # simplecov:enable
               end
             end
           end
@@ -155,7 +155,7 @@ module Foobara
             end until owning_entity_class
 
             if attribute_path.size == 1
-              attribute_path = attribute_path.first
+              attribute_path = attribute_path[0]
             end
 
             if owning_entity_class == self

data/projects/entities/projects/entity/src/extensions/domain/domain_module_extension.rb

@@ -34,15 +34,15 @@ module Foobara
                                             when 1, 2
                                               arg, other = args
 
-                                              if args.first.is_a?(::String)
+                                              if args[0].is_a?(::String)
                                                 [other, arg]
                                               else
                                                 args
                                               end
                                             else
-                                              # :nocov:
+                                              # simplecov:disable
                                               raise ArgumentError, "Too many arguments"
-                                              # :nocov:
+                                              # simplecov:enable
                                             end
 
             if model_base_class
@@ -59,7 +59,7 @@ module Foobara
             attributes_type = handler.type_for_declaration(attributes_type_declaration)
 
             # TODO: reuse the model_base_class primary key if it has one...
-            primary_key = attributes_type.element_types.keys.first
+            primary_key = attributes_type.element_types.keys[0]
 
             model_module = unless scoped_full_path.empty?
                              scoped_full_name

data/projects/entities/projects/entity/src/new_prepend.rb

@@ -11,9 +11,9 @@ module Foobara
 
       # rubocop:disable Lint/DuplicateMethods
       def new(...)
-        # :nocov:
+        # simplecov:disable
         raise "Cannot initialize a #{name}. Use .create, .thunk, .loaded, or .build instead."
-        # :nocov:
+        # simplecov:enable
       end
       # rubocop:enable Lint/DuplicateMethods
     end

data/projects/entities/projects/entity/src/not_found_error.rb

@@ -1,6 +1,6 @@
 module Foobara
   class Entity < DetachedEntity
-    class NotFoundError < Foobara::RuntimeError
+    class NotFoundError < Foobara::DataError
       class << self
         def not_found_error_class_name(data_path)
           error_class_name = data_path.path.map { |part| part == :"#" ? "Collection" : Util.classify(part) }.join
@@ -13,8 +13,8 @@ module Foobara
           # TODO: how would we avoid name collisions here??
           Util.make_class("#{mod.name}::#{error_class_name}", self) do
             # TODO: use Concern to change these into attr_accessor instead
-            singleton_class.define_method :data_path do
-              data_path
+            singleton_class.define_method :symbol do
+              :not_found
             end
 
             singleton_class.define_method :entity_class do
@@ -39,7 +39,7 @@ module Foobara
             data_path: data_path.to_s
           }
 
-          new(context:, message:)
+          new(context:, message:, path: data_path)
         end
 
         def data_path
@@ -54,15 +54,15 @@ module Foobara
       end
 
       def primary_key_attribute
-        # :nocov:
+        # simplecov:disable
         entity_class.primary_key_attribute
-        # :nocov:
+        # simplecov:enable
       end
 
       def full_entity_name
-        # :nocov:
+        # simplecov:disable
         entity_class.full_entity_name
-        # :nocov:
+        # simplecov:enable
       end
 
       def criteria

data/projects/entities/projects/entity/src/sensitive_value_removers/entity.rb

@@ -8,23 +8,26 @@ module Foobara
           elsif record.persisted?
             # We will assume that we do not need to clean up the primary key itself as
             # we will assume we don't allow sensitive primary keys for now.
-            thunkish = to_type.target_class.send(build_method, record.class.primary_key_attribute => record.primary_key)
+            thunkish = to_type.target_class.__send__(
+              build_method,
+              record.class.primary_key_attribute => record.primary_key
+            )
             thunkish.skip_validations = true
             thunkish.mutable = false
             thunkish
           else
-            # :nocov:
+            # simplecov:disable
             raise "Not sure what to do with a record that isn't loaded, created, or persisted"
-            # :nocov:
+            # simplecov:enable
           end
         end
 
         def build_method
           if to_type.extends?(BuiltinTypes[:entity])
             # TODO: figure out a way to test this path
-            # :nocov:
+            # simplecov:disable
             :build
-            # :nocov:
+            # simplecov:enable
           else
             :new
           end

data/projects/entities/projects/in_memory_crud_driver_minimal/src/in_memory_minimal.rb

@@ -50,9 +50,9 @@ module Foobara
             record_id = record_id_for(attributes)
 
             unless exists?(record_id)
-              # :nocov:
+              # simplecov:disable
               raise CannotUpdateError.new(record_id, "does not exist")
-              # :nocov:
+              # simplecov:enable
             end
 
             records[record_id] = Util.deep_dup(attributes)
@@ -61,9 +61,9 @@ module Foobara
 
           def hard_delete(record_id)
             unless exists?(record_id)
-              # :nocov:
+              # simplecov:disable
               raise CannotUpdateError.new(record_id, "does not exist")
-              # :nocov:
+              # simplecov:enable
             end
 
             records.delete(record_id)

data/projects/entities/projects/model_attribute_helpers/lib/foobara/model_attribute_helpers.rb

@@ -8,8 +8,6 @@ module Foobara
       def install!
         Model.include Concerns::AttributeHelpers
         Model.include Concerns::AttributeHelperAliases
-        Entity.include Concerns::AttributeHelpers
-        Entity.include Concerns::AttributeHelperAliases
       end
     end
   end

data/projects/entities/projects/model_attribute_helpers/src/attribute_helper_aliases.rb

@@ -20,7 +20,7 @@ module Foobara
             :type_declaration_value_at
           ].each do |method_name|
             define_method method_name do |*args, **opts, &block|
-              send("foobara_#{method_name}", *args, **opts, &block)
+              __send__("foobara_#{method_name}", *args, **opts, &block)
             end
           end
         end

data/projects/entities/projects/model_attribute_helpers/src/attribute_helpers.rb

@@ -170,9 +170,9 @@ module Foobara
                 )
               end
             else
-              # :nocov:
+              # simplecov:disable
               raise "Bad path part #{path_part}"
-              # :nocov:
+              # simplecov:enable
             end
           end
         end

data/projects/entities/projects/nested_transactionable/lib/foobara/nested_transactionable.rb

@@ -34,9 +34,9 @@ module Foobara
     end
 
     def relevant_entity_classes
-      # :nocov:
-      raise "subclass responsibility"
-      # :nocov:
+      # simplecov:disable
+      raise NotImplementedError
+      # simplecov:enable
     end
 
     def transactions
@@ -118,9 +118,9 @@ module Foobara
         if transaction.currently_open?
           # Hard to test this because halting and other exceptions rollback the transactions via
           # block form but to be safe keeping this
-          # :nocov:
+          # simplecov:disable
           transaction.rollback!
-          # :nocov:
+          # simplecov:enable
         end
       end
     end

data/projects/entities/projects/persistence/lib/foobara/persistence.rb

@@ -4,7 +4,7 @@ module Foobara
   module Persistence
     class << self
       def reset_all
-        Foobara.raise_if_production!("reset_all")
+        Foobara.raise_if_production!
         @tables_for_entity_class_name = @bases = @default_crud_driver = @default_base = nil
         EntityBase::Transaction::Concerns::EntityCallbackHandling.reset_all
         EntityBase::Transaction.reset_all