foobara 0.5.10 → 0.6.2

data/projects/entities_plumbing/src/extensions/command_pattern_implementation/concerns/entity_reflection.rb

@@ -0,0 +1,39 @@
+module Foobara
+  module CommandPatternImplementation
+    module Concerns
+      module EntityReflection
+        include Concern
+
+        module ClassMethods
+          def types_depended_on
+            # These lookups are duplicative of the overriden method as well as other methods.
+            # Likely there's some way to DRY this up
+            remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
+
+            if defined?(@types_depended_on) && @types_depended_on.key?(remove_sensitive)
+              return @types_depended_on[remove_sensitive]
+            end
+
+            @types_depended_on ||= {}
+            @types_depended_on[remove_sensitive] = begin
+              types = super
+
+              unless depends_on_entities.empty?
+                entity_types = depends_on_entities.map(&:entity_type)
+
+                if remove_sensitive
+                  entity_types = entity_types.reject(&:sensitive?)
+                end
+
+                types |= entity_types
+                types |= entity_types.map(&:types_depended_on).inject(:|)
+              end
+
+              types
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/projects/entities_plumbing/src/extensions/command_pattern_implementation/concerns/runtime.rb

@@ -0,0 +1,39 @@
+module Foobara
+  module CommandPatternImplementation
+    module Concerns
+      module Runtime
+        def validate_records
+          self.class.inputs_association_paths&.each do |data_path|
+            if data_path.last == :"#"
+              records = data_path.values_at(@inputs)
+
+              records.each.with_index do |record, index|
+                if record&.persisted? && !record.loaded?
+                  begin
+                    record.class.load(record)
+                  rescue Foobara::Entity::NotFoundError => e
+                    e.prepend_path!(index)
+                    e.prepend_path!(data_path.path[..-2])
+
+                    add_input_error(e)
+                  end
+                end
+              end
+            else
+              record = data_path.value_at(@inputs)
+
+              if record&.persisted? && !record.loaded?
+                begin
+                  record.class.load(record)
+                rescue Foobara::Entity::NotFoundError => e
+                  e.prepend_path!(data_path)
+                  add_input_error(e)
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/projects/manifest/src/base_manifest.rb

@@ -55,17 +55,17 @@ module Foobara
         self.manifest_path = manifest_path
 
         if relevant_manifest.nil?
-          # :nocov:
+          # simplecov:disable
           raise InvalidPath, "invalid path #{manifest_path}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
       def path
-        # :nocov:
+        # simplecov:disable
         warn "[DEPRECATION] `path` is deprecated. Please use `manifest_path` instead."
         manifest_path
-        # :nocov:
+        # simplecov:enable
       end
 
       def domain
@@ -91,11 +91,11 @@ module Foobara
       end
 
       def parent_category
-        self[:parent]&.first
+        self[:parent]&.[](0)
       end
 
       def parent_name
-        self[:parent]&.last
+        self[:parent]&.[](-1)
       end
 
       def scoped_category
@@ -103,7 +103,7 @@ module Foobara
       end
 
       def relevant_manifest
-        @relevant_manifest ||= Foobara::DataPath.values_at(manifest_path, root_manifest).first
+        @relevant_manifest ||= Foobara::DataPath.values_at(manifest_path, root_manifest)[0]
       end
 
       def find_type(type_declaration)
@@ -126,9 +126,9 @@ module Foobara
         elsif optional_key?(method_name)
           self.class.optional_key_defaults[method_name.to_sym]
         else
-          # :nocov:
+          # simplecov:disable
           super
-          # :nocov:
+          # simplecov:enable
         end
       end
 

data/projects/manifest/src/model.rb

@@ -28,14 +28,14 @@ module Foobara
             type.attribute_declarations.each_pair do |attribute_name, element_type|
               associations(element_type, path.append(attribute_name), result, initial: false)
             end
-          # :nocov:
+          # simplecov:disable
           elsif type.associative_array?
             if contains_associations?(type)
               raise "Associative array types with associations in them are not currently supported. " \
                     "Use attributes type if you can or set the key_type and/or value_type to duck type"
             end
           end
-          # :nocov:
+          # simplecov:enable
 
           result
         end
@@ -87,9 +87,9 @@ module Foobara
         when Type
           type.entity?
         else
-          # :nocov:
+          # simplecov:disable
           raise "not sure how to proceed with #{type}"
-          # :nocov:
+          # simplecov:enable
         end
       end
     end

data/projects/manifest/src/type.rb

@@ -64,12 +64,12 @@ module Foobara
 
       def target_class
         if target_classes.size != 1
-          # :nocov:
+          # simplecov:disable
           raise "Can only use #target_class for types with one target class but #{name} has #{target_classes.size}"
-          # :nocov:
+          # simplecov:enable
         end
 
-        target_classes.first
+        target_classes[0]
       end
 
       def types_depended_on

data/projects/manifest/src/type_declaration.rb

@@ -130,9 +130,9 @@ module Foobara
         raise "not an detached_entity" unless detached_entity?
 
         if to_type.primitive?
-          # :nocov:
+          # simplecov:disable
           raise "detached_entity extension instead of an detached_entity"
-          # :nocov:
+          # simplecov:enable
         end
 
         type = to_type
@@ -152,9 +152,9 @@ module Foobara
         raise "not an entity" unless entity?
 
         if to_type.primitive?
-          # :nocov:
+          # simplecov:disable
           raise "entity extension instead of an entity"
-          # :nocov:
+          # simplecov:enable
         end
 
         type = to_type

data/projects/model_plumbing/lib/foobara/model_plumbing.rb

@@ -5,6 +5,8 @@ module Foobara
         Model.on_reregister do
           GlobalDomain.foobara_each_command(&:handle_reregistered_types!)
         end
+
+        CommandPatternImplementation.include Foobara::CommandPatternImplementation::Concerns::ModelInputsType
         Foobara::DomainMapper.singleton_class.prepend(Foobara::ModelPlumbing::DomainMapperExtension)
       end
     end

data/projects/model_plumbing/src/extensions/command_pattern_implementation/concerns/model_inputs_type.rb

@@ -0,0 +1,35 @@
+module Foobara
+  module CommandPatternImplementation
+    module Concerns
+      module ModelInputsType
+        include Concern
+
+        module ClassMethods
+          def inputs(*args, **opts, &)
+            if args.size == 1 && opts.empty?
+              type = args.first
+
+              if type.is_a?(::Class) && (type == Model || type < Model)
+                type = type.model_type
+              end
+
+              unless skip_model_to_attributes_conversion?(type)
+                if type.extends?(BuiltinTypes[:model])
+                  return super(type.element_types)
+                end
+              end
+            end
+
+            super
+          end
+
+          private
+
+          def skip_model_to_attributes_conversion?(type)
+            !type.is_a?(Foobara::Type)
+          end
+        end
+      end
+    end
+  end
+end

data/projects/typesystem/projects/builtin_types/lib/foobara/builtin_types.rb

@@ -2,6 +2,7 @@ require "foobara/type_declarations"
 
 require "date"
 require "time"
+# TODO: get this out of here
 require "bigdecimal"
 
 module Foobara
@@ -67,7 +68,7 @@ module Foobara
       end
 
       def reset_all
-        Foobara.raise_if_production!("reset_all")
+        Foobara.raise_if_production!
 
         builtin_types.each do |builtin_type|
           builtin_type.foobara_each do |scoped|

data/projects/typesystem/projects/builtin_types/src/builtin_types.rb

@@ -42,9 +42,9 @@ module Foobara
         transformers = []
         transformer_classes&.each do |transformer_class|
           if transformer_class.respond_to?(:requires_type?) && transformer_class.requires_type?
-            # :nocov:
+            # simplecov:disable
             processor_classes_requiring_type << transformer_class
-            # :nocov:
+            # simplecov:enable
           else
             transformers << transformer_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
           end
@@ -57,9 +57,9 @@ module Foobara
         validators = []
         validator_classes&.each do |validator_class|
           if validator_class.respond_to?(:requires_type?) && validator_class.requires_type?
-            # :nocov:
+            # simplecov:disable
             processor_classes_requiring_type << validator_class
-            # :nocov:
+            # simplecov:enable
           else
             validators << validator_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
           end
@@ -164,9 +164,9 @@ module Foobara
           handler_class_to_extend = TypeDeclarations::Handlers.const_get(handler_name)
 
           unless handler_class_to_extend
-            # :nocov:
+            # simplecov:disable
             raise "Couldn't find handler class for #{handler_name}"
-            # :nocov:
+            # simplecov:enable
           end
 
           handler_to_extend = global_type_declaration_handler_registry.type_declaration_handler_for_handler_class(
@@ -174,9 +174,9 @@ module Foobara
           )
 
           unless handler_to_extend
-            # :nocov:
+            # simplecov:disable
             raise "Could not find a handler for #{handler_class_to_extend}"
-            # :nocov:
+            # simplecov:enable
           end
 
           desugarizer_module = Util.constant_value(handler_module, :Desugarizers)

data/projects/typesystem/projects/builtin_types/src/duck/supported_validators/one_of/type_declaration_extension/extend_registered_type_declaration/desugarizers/module_desugarizer.rb

@@ -19,9 +19,9 @@ module Foobara
                     rawish_type_declaration[:one_of] = begin
                       one_of.sort
                     rescue
-                      # :nocov:
+                      # simplecov:disable
                       one_of.sort_by(&:inspect)
-                      # :nocov:
+                      # simplecov:enable
                     end
 
                     rawish_type_declaration

data/projects/typesystem/projects/builtin_types/src/email/validator_base.rb

@@ -28,9 +28,9 @@ module Foobara
         end
 
         def regex
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def negate_regex?
@@ -46,7 +46,7 @@ module Foobara
         end
 
         def validation_errors(email)
-          build_error if email.send(negate_regex? ? :=~ : :!~, regex)
+          build_error if email.__send__(negate_regex? ? :=~ : :!~, regex)
         end
       end
 

data/projects/typesystem/projects/callback/src/block/concerns/block_parameter_required.rb

@@ -9,9 +9,9 @@ module Foobara
             super
 
             unless takes_block?
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "#{type} callback must take a block argument"
-              # :nocov:
+              # simplecov:enable
             end
           end
         end

data/projects/typesystem/projects/callback/src/block/concerns/keyword_argumentable_block.rb

@@ -20,9 +20,9 @@ module Foobara
 
             if has_keyword_args? && has_positional_args?
               # TODO: raise a real error
-              # :nocov:
+              # simplecov:disable
               raise "Expect #{type} block to either take a positional arg or keyword args but not both"
-              # :nocov:
+              # simplecov:enable
             end
           end
         end

data/projects/typesystem/projects/callback/src/block/concerns/single_argument_block.rb

@@ -9,10 +9,10 @@ module Foobara
             super
 
             if has_keyword_args?
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError,
                     "Expect #{type} block to only receive one or zero arguments. It cannot take keyword arguments."
-              # :nocov:
+              # simplecov:enable
             end
           end
         end

data/projects/typesystem/projects/callback/src/block.rb

@@ -43,14 +43,14 @@ module Foobara
       def validate_original_block!
         unless has_one_or_zero_positional_args?
           # TODO: raise a real error
-          # :nocov:
+          # simplecov:disable
           raise "Can't pass multiple arguments to a callback. Only 1 or 0 arguments."
-          # :nocov:
+          # simplecov:enable
         end
       end
 
       def takes_block?
-        @takes_block ||= original_block.parameters.last&.first&.==(:block) || false
+        @takes_block ||= original_block.parameters[-1]&.[](0)&.==(:block) || false
       end
 
       def has_one_or_zero_positional_args?
@@ -58,7 +58,7 @@ module Foobara
       end
 
       def has_keyword_args?
-        @has_keyword_args ||= param_types.any? { |type| [:keyreq, :keyrest].include?(type) }
+        @has_keyword_args ||= param_types.intersect?([:keyreq, :keyrest])
       end
 
       def has_positional_args?

data/projects/typesystem/projects/callback/src/registry/base.rb

@@ -8,9 +8,9 @@ module Foobara
 
         def register_callback(type, *, **, &callback_block)
           unless block_given?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Must provide a callback block to register"
-            # :nocov:
+            # simplecov:enable
           end
 
           validate_type!(type)
@@ -21,15 +21,15 @@ module Foobara
         end
 
         def specific_callback_set_for(*_args, **_opts)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def unioned_callback_set_for(*_args, **_opts)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def before(...)
@@ -79,9 +79,9 @@ module Foobara
         def validate_type!(type)
           unless allowed_types.include?(type)
             # TODO: raise a real error
-            # :nocov:
+            # simplecov:disable
             raise "bad type #{type} expected one of #{allowed_types}"
-            # :nocov:
+            # simplecov:enable
           end
         end
       end

data/projects/typesystem/projects/callback/src/registry/conditioned.rb

@@ -38,9 +38,9 @@ module Foobara
 
         def validate_conditions!(**conditions)
           unless conditions.is_a?(Hash)
-            # :nocov:
+            # simplecov:disable
             raise InvalidConditions, "Expected a hash"
-            # :nocov:
+            # simplecov:enable
           end
 
           conditions.each_pair do |condition_name, condition_value|

data/projects/typesystem/projects/callback/src/registry/multiple_action.rb

@@ -73,26 +73,26 @@ module Foobara
           when 0
             nil
           when 1
-            action = actions.first
+            action = actions[0]
             validate_action!(action)
             action
           else
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Can either pass an action or not but can't pass multiple"
-            # :nocov:
+            # simplecov:enable
           end
         end
 
         def normalize_actions(actions, validate = true)
-          first = actions.first
+          first = actions[0]
 
           if first.is_a?(Array)
             if actions.size == 1
               normalize_actions(first, validate)
             else
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Not expecting an array of arrays, expected an array of actions"
-              # :nocov:
+              # simplecov:enable
             end
           elsif actions.empty?
             [nil]

data/projects/typesystem/projects/callback/src/runner.rb

@@ -46,14 +46,14 @@ module Foobara
         else
           # TODO: raise better errors
           if callback_set.has_before_callbacks?
-            # :nocov:
+            # simplecov:disable
             raise
-            # :nocov:
+            # simplecov:enable
           end
           if callback_set.has_around_callbacks?
-            # :nocov:
+            # simplecov:disable
             raise
-            # :nocov:
+            # simplecov:enable
           end
         end
 

data/projects/typesystem/projects/callback/src/set.rb

@@ -7,7 +7,7 @@ module Foobara
         self.callbacks = {}
 
         callback_hash.each do |type, blocks|
-          send("#{type}=", blocks.dup)
+          __send__("#{type}=", blocks.dup)
         end
       end
 
@@ -33,7 +33,7 @@ module Foobara
       end
 
       def [](type)
-        send(type)
+        __send__(type)
       end
 
       Block.types.each do |type|
@@ -46,11 +46,11 @@ module Foobara
         end
 
         define_method "each_#{type}" do |&block|
-          send(type).each(&block)
+          __send__(type).each(&block)
         end
 
         define_method "has_#{type}_callbacks?" do
-          !send(type).empty?
+          !__send__(type).empty?
         end
       end
     end

data/projects/typesystem/projects/common/src/data_path.rb

@@ -103,7 +103,7 @@ module Foobara
 
     def prepend!(*prepend_parts)
       if prepend_parts.size == 1
-        arg = prepend_parts.first
+        arg = prepend_parts[0]
 
         if arg.is_a?(Array)
           prepend_parts = arg
@@ -122,7 +122,7 @@ module Foobara
 
     def append!(*append_parts)
       if append_parts.size == 1
-        arg = append_parts.first
+        arg = append_parts[0]
 
         if arg.is_a?(Array)
           append_parts = arg
@@ -174,12 +174,12 @@ module Foobara
         raise TooManyValuesAtPathError.new(path, values)
       end
 
-      values.first
+      values[0]
     end
 
     def set_value_at(object, value, parts = path)
       owner = value_at(object, parts[0..-2])
-      index = parts.last
+      index = parts[-1]
 
       if owner.is_a?(::Hash)
         if owner.key?(index.to_s)
@@ -192,11 +192,11 @@ module Foobara
       else
         method = "#{index}="
         if owner.respond_to?(method)
-          owner.send(method, value)
+          owner.__send__(method, value)
         else
-          # :nocov:
+          # simplecov:disable
           raise BadPathError, "Bad path: #{parts}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -206,7 +206,7 @@ module Foobara
     # Helper method that determines if the path points to an array and none of the atoms along the way are also arrays.
     # And that there's at least one atom (we are going to consider a collection to be "named" not an anonymous array.)
     def simple_collection?
-      path.size > 1 && path.last == :"#" && path[0..-2].none? { |part| part == :"#" }
+      path.size > 1 && path[-1] == :"#" && path[0..-2].none? { |part| part == :"#" }
     end
 
     def ==(other)
@@ -214,7 +214,7 @@ module Foobara
     end
 
     def last
-      path.last
+      path[-1]
     end
 
     def empty?
@@ -250,10 +250,10 @@ module Foobara
           key_parts.to_sym
         end
       else
-        # :nocov:
+        # simplecov:disable
         raise ArgumentError,
               "expected nil, a symbol, or a string, an integer, or an array of such values but was a #{key_parts.class}"
-        # :nocov:
+        # simplecov:enable
       end
     end
 
@@ -274,15 +274,15 @@ module Foobara
                         object[path_part]
                       end
                     else
-                      object.send(path_part)
+                      object.__send__(path_part)
                     end
                   end
                 when Integer
                   objects.map { |value| value[path_part] }
                 else
-                  # :nocov:
+                  # simplecov:disable
                   raise "Bad path part: #{path_part.inspect}"
-                  # :nocov:
+                  # simplecov:enable
                 end.compact
 
       _values_at(objects, parts)