foobara 0.5.10 → 0.6.2

data/projects/entities/projects/persistence/src/entity_attributes_crud_driver.rb

@@ -78,9 +78,9 @@ module Foobara
             match = /^Cannot(\w+)Error$/.match(Util.non_full_name(self.class))
 
             unless match
-              # :nocov:
+              # simplecov:disable
               raise "Bad error name for #{self.class.name}"
-              # :nocov:
+              # simplecov:enable
             end
 
             Util.underscore(match[1])
@@ -121,15 +121,15 @@ module Foobara
 
         # CRUD
         def select(_query_declaration)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def all(page_size: nil)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def first
@@ -137,9 +137,9 @@ module Foobara
         end
 
         def find(_record_id)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def find!(record_id)
@@ -184,9 +184,7 @@ module Foobara
 
         def find_all_by_attribute_containing_any_of(attribute_name, values)
           all.select do |attributes|
-            attributes[attribute_name]&.any? do |attribute_value|
-              values.include?(attribute_value)
-            end
+            attributes[attribute_name]&.intersect?(values)
           end
         end
 
@@ -228,51 +226,51 @@ module Foobara
         end
 
         def insert(_attributes)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def insert_many(attributes_array)
           # TODO: add a test for a driver that doesn't override this and remove these :nocov: comments
-          # :nocov:
+          # simplecov:disable
           attributes_array.each.lazy.map do |attributes|
             insert(attributes)
           end
-          # :nocov:
+          # simplecov:enable
         end
 
         def update(_record)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def hard_delete(_record_id)
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def hard_delete_many(record_ids)
           # TODO: add a test for a driver that doesn't override this and remove these :nocov: comments
-          # :nocov:
+          # simplecov:disable
           record_ids.each.lazy.map do |record_id|
             delete(record_id)
           end
-          # :nocov:
+          # simplecov:enable
         end
 
         def hard_delete_all!
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def count
-          # :nocov:
-          raise "subclass responsibility"
-          # :nocov:
+          # simplecov:disable
+          raise NotImplementedError
+          # simplecov:enable
         end
 
         def exists?(record_id)
@@ -301,12 +299,12 @@ module Foobara
             end
           elsif type.extends?(BuiltinTypes[:tuple])
             # TODO: test this code path
-            # :nocov:
+            # simplecov:disable
             object.map.with_index do |value, index|
               element_type = type.element_types[index]
               restore_attributes(value, element_type)
             end
-            # :nocov:
+            # simplecov:enable
           elsif type.extends?(BuiltinTypes[:array])
             element_type = type.element_type
             object.map { |value| restore_attributes(value, element_type) }
@@ -333,9 +331,9 @@ module Foobara
               outcome.result
             else
               # TODO: figure out how to test this code path
-              # :nocov:
+              # simplecov:disable
               object
-              # :nocov:
+              # simplecov:enable
             end
           end
         end

data/projects/entities/projects/persistence/src/entity_base/transaction/concerns/entity_callback_handling.rb

@@ -10,7 +10,7 @@ module Foobara
           module EntityCallbackHandling
             class << self
               def reset_all
-                Foobara.raise_if_production!("reset_all")
+                Foobara.raise_if_production!
                 install!
               end
 
@@ -25,10 +25,10 @@ module Foobara
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.updated(record)
@@ -38,17 +38,17 @@ module Foobara
                   transaction = Transaction.open_transaction_for(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot modify #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.updated(record)
@@ -58,17 +58,17 @@ module Foobara
                   transaction = Transaction.open_transaction_for(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot modify #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.hard_deleted(record)
@@ -78,17 +78,17 @@ module Foobara
                   transaction = Transaction.open_transaction_for(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot modify #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.unhard_deleted(record)
@@ -97,17 +97,17 @@ module Foobara
                 Entity.after_initialized_loaded do |record:, **|
                   transaction = Persistence.current_transaction(record)
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot initialize #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot initialize #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
                   # TODO: we need a way to not blow up here in case of non-block form of transaction
                   transaction.track_loaded(record)
@@ -122,10 +122,10 @@ module Foobara
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot initialize #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
                   # TODO: we need a way to not blow up here in case of non-block form of transaction
                   transaction.track_created(record)
@@ -135,17 +135,17 @@ module Foobara
                   transaction = Persistence.current_transaction(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot initialize #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot initialize #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
                   # TODO: we need a way to not blow up here in case of non-block form of transaction
                   transaction.track_unloaded_thunk(record)

data/projects/entities/projects/persistence/src/entity_base/transaction/concerns/state_transitions.rb

@@ -32,10 +32,10 @@ module Foobara
               end
               entity_attributes_crud_driver.flush_transaction(raw_tx)
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             # Should communicate somehow that this is only in-memory.
@@ -46,10 +46,10 @@ module Foobara
               end
               entity_attributes_crud_driver.revert_transaction(raw_tx)
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             def commit!
@@ -62,10 +62,10 @@ module Foobara
                 each_table(&:transaction_closed)
               end
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             def commit_nested!
@@ -75,10 +75,10 @@ module Foobara
                 each_table(&:transaction_closed)
               end
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             # TODO: this belongs elsewhere

data/projects/entities/projects/persistence/src/entity_base/transaction/concerns/transaction_tracking.rb

@@ -23,7 +23,7 @@ module Foobara
               end
 
               def reset_all
-                Foobara.raise_if_production!("reset_all")
+                Foobara.raise_if_production!
                 @open_transactions = nil
               end
 

data/projects/entities/projects/persistence/src/entity_base/transaction.rb

@@ -58,9 +58,9 @@ module Foobara
           end
 
           unless entity_base == entity_class.entity_base
-            # :nocov:
+            # simplecov:disable
             raise "#{entity_class} is from a different entity base! Cannot proceed."
-            # :nocov:
+            # simplecov:enable
           end
 
           table = tables[entity_class]
@@ -70,9 +70,9 @@ module Foobara
           else
             if defined?(@ordered_tables)
               # TODO: test this path
-              # :nocov:
+              # simplecov:disable
               remove_instance_variable(:@ordered_tables)
-              # :nocov:
+              # simplecov:enable
             end
 
             tables[entity_class] = TransactionTable.new(self, entity_class)
@@ -102,17 +102,17 @@ module Foobara
         def load(record_or_entity_class, record_id = nil)
           entity_or_id = if record_or_entity_class.is_a?(Entity)
                            if record_id
-                             # :nocov:
+                             # simplecov:disable
                              raise ArgumentError, "Do not give a record_id when also giving a record"
-                             # :nocov:
+                             # simplecov:enable
                            end
 
                            record_or_entity_class
                          else
                            unless record_id
-                             # :nocov:
+                             # simplecov:disable
                              raise ArgumentError, "Must give a record_id when passing in an entity class"
-                             # :nocov:
+                             # simplecov:enable
                            end
 
                            record_id
@@ -148,7 +148,7 @@ module Foobara
         end
 
         def load_aggregate(record)
-          load_aggregates([record]).first
+          load_aggregates([record])[0]
         end
 
         def track_unloaded_thunk(entity)

data/projects/entities/projects/persistence/src/entity_base/transaction_table/concerns/record_tracking.rb

@@ -16,9 +16,9 @@ module Foobara
 
             def loading(record)
               if loading?(record)
-                # :nocov:
+                # simplecov:disable
                 raise "Already loading #{record}"
-                # :nocov:
+                # simplecov:enable
               end
 
               begin
@@ -69,9 +69,9 @@ module Foobara
 
               # TODO: is this check redundant? Maybe have the entity explode directly instead?
               if hard_deleted?(record)
-                # :nocov:
+                # simplecov:disable
                 raise "Cannot update a hard deleted record"
-                # :nocov:
+                # simplecov:enable
               end
 
               unless created?(record)