foobara 0.5.10 → 0.6.2

data/projects/typesystem/projects/common/src/error.rb

@@ -27,14 +27,14 @@ module Foobara
         when 0
           Util.non_full_name_underscore(self).gsub(/_error$/, "").to_sym
         when 1
-          arg = args.first
+          arg = args[0]
           singleton_class.define_method :symbol do
             arg
           end
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "expected 0 or 1 argument, got #{args_size}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -58,14 +58,14 @@ module Foobara
         when 0
           Util.humanize(symbol.to_s)
         when 1
-          arg = args.first
+          arg = args[0]
           singleton_class.define_method :message do
             arg
           end
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "expected 0 or 1 argument, got #{args_size}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -79,14 +79,14 @@ module Foobara
         when 0
           {}
         when 1
-          arg = args.first
+          arg = args[0]
           singleton_class.define_method :context_type_declaration do
             arg
           end
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "expected 0 or 1 argument, got #{args_size}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -249,9 +249,9 @@ module Foobara
       self.is_fatal = is_fatal
 
       if !self.message.is_a?(String) || self.message.empty?
-        # :nocov:
+        # simplecov:disable
         raise "Bad error message, expected a string"
-        # :nocov:
+        # simplecov:enable
       end
 
       backtrace_when_initialized = caller[1..]

data/projects/typesystem/projects/common/src/error_collection.rb

@@ -19,31 +19,31 @@ module Foobara
     end
 
     def errors
-      # :nocov:
+      # simplecov:disable
       warn "DEPRECATED: Do not call ErrorCollection#errors instead just use the collection directly."
       self
-      # :nocov:
+      # simplecov:enable
     end
 
     def error_array
-      # :nocov:
+      # simplecov:disable
       warn "DEPRECATED: Do not call ErrorCollection#error_array instead just use the collection directly."
       self
-      # :nocov:
+      # simplecov:enable
     end
 
     def each_error(&)
-      # :nocov:
+      # simplecov:disable
       warn "DEPRECATED: This method will be deprecated in the coming version"
       each(&)
-      # :nocov:
+      # simplecov:enable
     end
 
     def has_error?(error)
       unless error.is_a?(Error)
-        # :nocov:
+        # simplecov:disable
         raise ArgumentError, "Can only check if an Error instance is in the collection"
-        # :nocov:
+        # simplecov:enable
       end
 
       include?(error)
@@ -58,17 +58,17 @@ module Foobara
                    error_or_collection_or_error_hash.key?(:message)
                   Error.new(**error_or_collection_or_error_hash)
                 else
-                  # :nocov:
+                  # simplecov:disable
                   raise ArgumentError,
                         "if passing a hash of error args it must include symbol and message at least"
-                  # :nocov:
+                  # simplecov:enable
                 end
               else
-                # :nocov:
+                # simplecov:disable
                 raise ArgumentError, "Not sure how to convert #{error_or_collection_or_error_hash.inspect} " \
                                      "into an error. Can handle a hash of error " \
                                      "args or 3 arguments for symbol, message, and context, or, of course, an Error"
-                # :nocov:
+                # simplecov:enable
               end
 
       if has_error?(error)
@@ -101,10 +101,10 @@ module Foobara
     end
 
     def to_h
-      # :nocov:
+      # simplecov:disable
       warn "DEPRECATED: Use #errors_hash instead"
       errors_hash
-      # :nocov:
+      # simplecov:enable
     end
   end
 end

data/projects/typesystem/projects/common/src/error_key.rb

@@ -74,10 +74,12 @@ module Foobara
 
     def prepend_path!(*prepend_parts)
       if prepend_parts.size == 1
-        arg = prepend_parts.first
+        arg = prepend_parts[0]
 
         if arg.is_a?(Array)
           prepend_parts = arg
+        elsif arg.is_a?(DataPath)
+          prepend_parts = arg.path
         end
       end
 
@@ -155,9 +157,9 @@ module Foobara
       when String
         key_parts.to_sym
       else
-        # :nocov:
+        # simplecov:disable
         raise ArgumentError, "expected nil, a symbol, or a string, an integer, or an array of such values "
-        # :nocov:
+        # simplecov:enable
       end
     end
   end

data/projects/typesystem/projects/common/src/outcome.rb

@@ -23,9 +23,9 @@ module Foobara
         errors = errors.flatten
 
         if errors.empty?
-          # :nocov:
+          # simplecov:disable
           raise "No errors given"
-          # :nocov:
+          # simplecov:enable
         end
 
         new.tap do |outcome|
@@ -56,9 +56,9 @@ module Foobara
     end
 
     def has_error
-      # :nocov:
+      # simplecov:disable
       error_collection.has_error
-      # :nocov:
+      # simplecov:enable
     end
 
     def add_errors(*errors)
@@ -88,7 +88,7 @@ module Foobara
     def raise!
       return if success?
 
-      error = error_collection.first
+      error = error_collection[0]
       original_backtrace = error.backtrace_when_initialized
 
       if error_collection.size > 1

data/projects/typesystem/projects/common/src/possible_error.rb

@@ -70,10 +70,10 @@ module Foobara
           if processor.scoped_path_set?
             # Unclear why nothing in the test suite passes through here.
             # TODO: either test this or delete it.
-            # :nocov:
+            # simplecov:disable
             to_include << processor
             processor_reference = processor.foobara_manifest_reference
-            # :nocov:
+            # simplecov:enable
           end
         end
 

data/projects/typesystem/projects/concerns/src/concern.rb

@@ -56,7 +56,7 @@ module Foobara
               if instance_variable_defined?(var_name)
                 instance_variable_get(var_name)
               else
-                superclass.send(name)
+                superclass.__send__(name)
               end
             end
 
@@ -77,9 +77,9 @@ module Foobara
 
       def foobara_class_methods_module_for(klass)
         unless klass.name
-          # :nocov:
+          # simplecov:disable
           raise "This does not work with anonymous classes"
-          # :nocov:
+          # simplecov:enable
         end
 
         if klass.const_defined?(:ClassMethods, false)

data/projects/typesystem/projects/delegate/src/extensions/module.rb

@@ -1,16 +1,16 @@
 class Module
-  # :nocov:
+  # simplecov:disable
   def foobara_delegate(*method_names, to:, allow_nil: false)
     warn "[DEPRECATION] `foobara_delegate` is deprecated and will be removed in future versions"
 
     method_names.each do |method_name|
       define_method method_name do |*args, **opts, &block|
-        target = to.is_a?(::Symbol) || to.is_a?(::String) ? send(to) : to
+        target = to.is_a?(::Symbol) || to.is_a?(::String) ? __send__(to) : to
         return nil if target.nil? && allow_nil
 
-        target.send(method_name, *args, **opts, &block)
+        target.__send__(method_name, *args, **opts, &block)
       end
     end
   end
-  # :nocov:
+  # simplecov:enable
 end

data/projects/typesystem/projects/domain/lib/foobara/domain.rb

@@ -3,9 +3,9 @@ module Foobara
     class << self
       def install!
         if @installed
-          # :nocov:
+          # simplecov:disable
           raise "Already registered Domain"
-          # :nocov:
+          # simplecov:enable
         end
 
         # TODO: delete this?

data/projects/typesystem/projects/domain/src/domain.rb

@@ -11,9 +11,9 @@ module Foobara
           domain = Namespace.global.foobara_lookup_domain(object)
 
           unless domain
-            # :nocov:
+            # simplecov:disable
             raise NoSuchDomain, "Couldn't determine domain for #{object}"
-            # :nocov:
+            # simplecov:enable
           end
 
           domain
@@ -28,9 +28,9 @@ module Foobara
             to_domain(object.scoped_namespace)
           end
         else
-          # :nocov:
+          # simplecov:disable
           raise NoSuchDomain, "Couldn't determine domain for #{object}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -84,7 +84,7 @@ module Foobara
           if new_class.const_defined?(const_name)
             to_replace = new_class.const_get(const_name)
             if to_replace != value
-              new_class.send(:remove_const, const_name)
+              new_class.__send__(:remove_const, const_name)
               new_class.const_set(const_name, value)
             end
           else

data/projects/typesystem/projects/domain/src/domain_module_extension.rb

@@ -20,28 +20,28 @@ module Foobara
         def foobara_domain_map(*args, to: nil, strict: false, criteria: nil, should_raise: false, **opts)
           case args.size
           when 1
-            value = args.first
+            value = args[0]
           when 0
             if opts.empty?
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Expected at least one argument"
-              # :nocov:
+              # simplecov:enable
             else
               value = opts
               opts = {}
             end
           else
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Expected 1 argument but got #{args.size}"
-            # :nocov:
+            # simplecov:enable
           end
 
           invalid_keys = opts.keys - [:from]
 
           if invalid_keys.any?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Invalid options: #{invalid_keys.join(", ")}"
-            # :nocov:
+            # simplecov:enable
           end
 
           from = if opts.key?(:from)
@@ -91,9 +91,9 @@ module Foobara
             return parent if parent&.foobara_organization?
 
             # TODO: we really should test this path
-            # :nocov:
+            # simplecov:disable
             parent = parent.foobara_parent_namespace
-            # :nocov:
+            # simplecov:enable
           end || GlobalOrganization
         end
 
@@ -110,8 +110,8 @@ module Foobara
         end
 
         def foobara_type_from_declaration(*args, **opts, &block)
-          if opts.empty? && block.nil? && args.size == 1 && args.first.is_a?(Types::Type)
-            return args.first
+          if opts.empty? && block.nil? && args.size == 1 && args[0].is_a?(Types::Type)
+            return args[0]
           end
 
           Foobara::Namespace.use self do
@@ -132,8 +132,8 @@ module Foobara
         end
 
         def foobara_register_type(type_symbol, *type_declaration_bits, &block)
-          type = if block.nil? && type_declaration_bits.size == 1 && type_declaration_bits.first.is_a?(Types::Type)
-                   type_declaration_bits.first
+          type = if block.nil? && type_declaration_bits.size == 1 && type_declaration_bits[0].is_a?(Types::Type)
+                   type_declaration_bits[0]
                  else
                    foobara_type_from_declaration(*type_declaration_bits, &block)
                  end
@@ -157,12 +157,12 @@ module Foobara
               type.type_symbol = new_type_symbol
 
               foobara_register(type)
-              # :nocov:
+              # simplecov:disable
             elsif old_type != type
               # TODO: delete this check if it's not really helping
 
               raise "Didn't expect to find an old type"
-              # :nocov:
+              # simplecov:enable
             end
           else
             type.scoped_path = new_scoped_path
@@ -172,16 +172,16 @@ module Foobara
 
             if old_type && old_type != type
               # TODO: delete this check if it's not really helping
-              # :nocov:
+              # simplecov:disable
               raise "Didn't expect to find an old type"
-              # :nocov:
+              # simplecov:enable
             end
 
             if foobara_registered?(type, mode: Namespace::LookupMode::DIRECT)
               # TODO: delete this check if it's not really helping
-              # :nocov:
+              # simplecov:disable
               raise "Already registered: #{type.inspect}"
-              # :nocov:
+              # simplecov:enable
             end
 
             foobara_register(type)
@@ -201,7 +201,7 @@ module Foobara
           end
 
           if domains.length == 1
-            domains = Util.array(domains.first)
+            domains = Util.array(domains[0])
           end
 
           domains.each do |domain|
@@ -210,9 +210,9 @@ module Foobara
             domain_name = domain.foobara_full_domain_name
 
             if foobara_depends_on.include?(domain_name)
-              # :nocov:
+              # simplecov:disable
               raise AlreadyRegisteredDomainDependency, "Already registered #{domain_name} as a dependency of #{self}"
-              # :nocov:
+              # simplecov:enable
             end
 
             foobara_depends_on_namespaces << domain

data/projects/typesystem/projects/domain/src/extensions/foobara.rb

@@ -1,6 +1,14 @@
 module Foobara
   class << self
     def manifest
+      # simplecov:disable
+      warn "Foobara.manifest is deprecated in favor of CommandConnector#foobara_manifest" \
+           "\nIf this breaks a legit use case for Foobara.manifest please let us know and we will consider keeping it!"
+      debug_manifest
+      # simplecov:enable
+    end
+
+    private def debug_manifest
       to_include = Namespace.global.foobara_all_organization.to_set
 
       TypeDeclarations.with_manifest_context(to_include:) do
@@ -13,27 +21,27 @@ module Foobara
           to_include.delete(object)
 
           unless object.scoped_path_set?
-            # :nocov:
+            # simplecov:disable
             raise "no scoped path set for #{object}"
-            # :nocov:
+            # simplecov:enable
           end
 
           manifest_reference = object.foobara_manifest_reference.to_sym
           category_symbol = Namespace.global.foobara_category_symbol_for(object)
 
           unless category_symbol
-            # :nocov:
+            # simplecov:disable
             raise "no category symbol for #{object}"
-            # :nocov:
+            # simplecov:enable
           end
 
           if included.key?(manifest_reference)
             if included[manifest_reference] == category_symbol
               next
             else
-              # :nocov:
+              # simplecov:disable
               raise "Collision for #{manifest_reference}: #{included[manifest_reference]} and #{category_symbol}"
-              # :nocov:
+              # simplecov:enable
             end
           end
 

data/projects/typesystem/projects/domain/src/module_extension.rb

@@ -12,9 +12,9 @@ module Foobara
 
       def foobara_domain!
         if foobara_organization?
-          # :nocov:
+          # simplecov:disable
           raise CannotBeOrganizationAndDomainAtSameTime
-          # :nocov:
+          # simplecov:enable
         end
 
         unless is_a?(Namespace::IsNamespace)
@@ -30,9 +30,9 @@ module Foobara
 
       def foobara_organization!
         if foobara_domain?
-          # :nocov:
+          # simplecov:disable
           raise CannotBeOrganizationAndDomainAtSameTime
-          # :nocov:
+          # simplecov:enable
         end
 
         include(OrganizationModuleExtension)

data/projects/typesystem/projects/domain/src/organization.rb

@@ -12,9 +12,9 @@ module Foobara
           organization = Namespace.global.foobara_lookup_organization(object)
 
           unless organization
-            # :nocov:
+            # simplecov:disable
             raise NoSuchOrganization, "Couldn't determine organization for #{object}"
-            # :nocov:
+            # simplecov:enable
           end
 
           organization
@@ -31,17 +31,17 @@ module Foobara
             end
           end
         else
-          # :nocov:
+          # simplecov:disable
           raise NoSuchOrganization, "Couldn't determine organization for #{object}"
-          # :nocov:
+          # simplecov:enable
         end
       end
 
       def create(full_organization_name)
         if Organization.to_organization(full_organization_name)
-          # :nocov:
+          # simplecov:disable
           raise OrganizationAlreadyExistsError, "Organization #{full_organization_name} already exists"
-          # :nocov:
+          # simplecov:enable
         end
       rescue Organization::NoSuchOrganization
         Util.make_module_p(full_organization_name) { foobara_organization! }

data/projects/typesystem/projects/enumerated/src/accessors.rb

@@ -18,10 +18,10 @@ module Foobara
             values_source = begin
               Util.const_get_up_hierarchy(self, module_name)
             rescue NameError
-              # :nocov:
+              # simplecov:disable
               raise CannotDetermineModuleAutomatically,
                     "could not find a module for #{module_name}. Maybe consider passing it in explicitly."
-              # :nocov:
+              # simplecov:enable
             end
           end
 
@@ -29,9 +29,9 @@ module Foobara
 
           attribute_name = attribute_name.to_sym
 
-          # :nocov:
+          # simplecov:disable
           unless respond_to?(:enumerated_type_metadata)
-            # :nocov:
+            # simplecov:enable
             class << self
               attr_accessor :enumerated_type_metadata
             end

data/projects/typesystem/projects/enumerated/src/values.rb

@@ -15,9 +15,9 @@ module Foobara
 
         def normalize_value(value)
           unless Values.valid_value_type?(value)
-            # :nocov:
+            # simplecov:disable
             raise BadValueType, "Expected nil, String, or Symbol, but got #{value} which is a #{value.class}"
-            # :nocov:
+            # simplecov:enable
           end
 
           value&.to_sym
@@ -38,17 +38,17 @@ module Foobara
         def validate_symbol_map_types(symbol_map)
           symbol_map.each_pair do |name, value|
             unless valid_name_type?(name)
-              # :nocov:
+              # simplecov:disable
               raise BadNameType, "name is #{name} which is a #{name.class} but expected String, or Symbol"
-              # :nocov:
+              # simplecov:enable
             end
 
             unless valid_value_type?(value)
-              # :nocov:
+              # simplecov:disable
               raise BadValueType, "#{
                 name
               } is #{value} which is a #{value.class} but expected nil, String, or Symbol"
-              # :nocov:
+              # simplecov:enable
             end
           end
         end
@@ -66,13 +66,13 @@ module Foobara
 
       def initialize(*args)
         if args.empty?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Expected Module, Hash, or Array"
-        # :nocov:
+        # simplecov:enable
         elsif args.size > 1
           initialize(args)
         else
-          symbol_map = args.first
+          symbol_map = args[0]
 
           case symbol_map
           when ::Hash
@@ -84,9 +84,9 @@ module Foobara
           when ::Array
             initialize(symbol_map.to_h { |name| [name, name] })
           else
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Expected Module, Hash, or Array"
-            # :nocov:
+            # simplecov:enable
           end
         end
       end
@@ -105,9 +105,9 @@ module Foobara
 
       def method_missing(name)
         unless respond_to_missing?(name)
-          # :nocov:
+          # simplecov:disable
           super
-          # :nocov:
+          # simplecov:enable
         end
 
         @symbol_map[name]
@@ -127,7 +127,7 @@ module Foobara
 
         [:all, :all_names, :all_values, :value?].each do |method_name|
           mod.singleton_class.define_method method_name do |*args, **opts, &block|
-            enumerated.send(method_name, *args, **opts, &block)
+            enumerated.__send__(method_name, *args, **opts, &block)
           end
         end
 

data/projects/{entities → typesystem}/projects/model/lib/foobara/model.rb

@@ -30,7 +30,7 @@ module Foobara
       end
 
       def reset_all
-        Foobara.raise_if_production!("reset_all")
+        Foobara.raise_if_production!
         install!
       end
     end