foobara 0.5.10 → 0.6.2

data/projects/typesystem/projects/state_machine/src/callbacks.rb

@@ -12,39 +12,39 @@ module Foobara
       end
 
       def callbacks_for(*, **)
-        # :nocov:
+        # simplecov:disable
         callback_registry.callbacks_for(*, **)
-        # :nocov:
+        # simplecov:enable
       end
 
       def has_callbacks?(*, **)
-        # :nocov:
+        # simplecov:disable
         callback_registry.has_callbacks?(*, **)
-        # :nocov:
+        # simplecov:enable
       end
 
       def has_before_callbacks?(*, **)
-        # :nocov:
+        # simplecov:disable
         callback_registry.has_before_callbacks?(*, **)
-        # :nocov:
+        # simplecov:enable
       end
 
       def has_after_callbacks?(*, **)
-        # :nocov:
+        # simplecov:disable
         callback_registry.has_after_callbacks?(*, **)
-        # :nocov:
+        # simplecov:enable
       end
 
       def has_around_callbacks?(*, **)
-        # :nocov:
+        # simplecov:disable
         callback_registry.has_around_callbacks?(*, **)
-        # :nocov:
+        # simplecov:enable
       end
 
       def has_error_callbacks?(*, **)
-        # :nocov:
+        # simplecov:disable
         callback_registry.has_error_callbacks?(*, **)
-        # :nocov:
+        # simplecov:enable
       end
 
       def register_transition_callback(type, **, &)
@@ -79,9 +79,9 @@ module Foobara
         # 6 before_<transition>_transition_from_<state>
         def create_register_callback_methods
           if register_callback_methods
-            # :nocov:
+            # simplecov:disable
             raise "Do not create register callback methods twice"
-            # :nocov:
+            # simplecov:enable
           end
 
           callback_methods = @register_callback_methods = []

data/projects/typesystem/projects/state_machine/src/state_machine.rb

@@ -63,7 +63,7 @@ module Foobara
 
     def current_state
       if target_attribute
-        owner.send(target_attribute) || self.class.initial_state
+        owner.__send__(target_attribute) || self.class.initial_state
       else
         @current_state
       end
@@ -71,7 +71,7 @@ module Foobara
 
     def current_state=(state)
       if target_attribute
-        owner.send("#{target_attribute}=", state)
+        owner.__send__("#{target_attribute}=", state)
       else
         @current_state = state
       end

data/projects/typesystem/projects/state_machine/src/sugar.rb

@@ -23,9 +23,9 @@ module Foobara
                 transitions_for_state = transition_map[state] ||= {}
 
                 if transitions_for_state.key?(transition)
-                  # :nocov:
+                  # simplecov:disable
                   raise TransitionAlreadyDefinedError, "There's already a #{transition} for #{state}"
-                  # :nocov:
+                  # simplecov:enable
                 end
 
                 transitions_for_state[transition] = next_state
@@ -85,7 +85,7 @@ module Foobara
               } but should have been one of #{states}"
             end
           else
-            self.initial_state = states.first
+            self.initial_state = states[0]
           end
         end
 

data/projects/typesystem/projects/type_declarations/lib/foobara/type_declarations.rb

@@ -5,7 +5,7 @@ module Foobara
     class << self
       def reset_all(skip_check: nil)
         unless skip_check
-          Foobara.raise_if_production!("reset_all")
+          Foobara.raise_if_production!
         end
 
         Util.descendants(Error).each do |error_class|

data/projects/typesystem/projects/type_declarations/src/attributes.rb

@@ -43,9 +43,9 @@ module Foobara
           invalid_keys = keys_to_keep - valid_keys
 
           if invalid_keys.any?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Invalid keys: #{invalid_keys} expected only #{valid_keys}"
-            # :nocov:
+            # simplecov:enable
           end
 
           keys_to_reject = valid_keys - keys_to_keep

data/projects/typesystem/projects/type_declarations/src/attributes_transformers/from_yaml.rb

@@ -4,9 +4,9 @@ module Foobara
       # TODO: dry this up with a .subclass method in AttributesTransformers?
       def from_yaml(*attribute_names)
         if attribute_names.empty?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "You must specify at least one attribute name"
-          # :nocov:
+          # simplecov:enable
         end
 
         symbol = symbol_for_attribute_names(attribute_names)

data/projects/typesystem/projects/type_declarations/src/attributes_transformers/only.rb

@@ -3,9 +3,9 @@ module Foobara
     class << self
       def only(*attribute_names)
         if attribute_names.empty?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "You must specify at least one attribute name"
-          # :nocov:
+          # simplecov:enable
         end
 
         symbol = symbol_for_attribute_names(attribute_names)

data/projects/typesystem/projects/type_declarations/src/attributes_transformers/reject.rb

@@ -3,9 +3,9 @@ module Foobara
     class << self
       def reject(*attribute_names)
         if attribute_names.empty?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "You must specify at least one attribute name"
-          # :nocov:
+          # simplecov:enable
         end
 
         symbol = symbol_for_attribute_names(attribute_names)

data/projects/typesystem/projects/type_declarations/src/attributes_transformers/set.rb

@@ -8,9 +8,9 @@ module Foobara
 
       def set(attribute_names_to_values)
         if attribute_names_to_values.empty?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "You must specify at least one attribute name/value pair"
-          # :nocov:
+          # simplecov:enable
         end
 
         symbol = symbol_for_attribute_names([*attribute_names_to_values.keys, next_index.to_s.to_sym])
@@ -45,12 +45,12 @@ module Foobara
 
       def to_type_declaration
         # TODO: test this
-        # :nocov:
+        # simplecov:disable
         if from_type
           from_declaration = from_type.declaration_data
           TypeDeclarations::Attributes.reject(from_declaration, *self.class.attribute_names_to_values.keys)
         end
-        # :nocov:
+        # simplecov:enable
       end
 
       def from_type_declaration

data/projects/typesystem/projects/type_declarations/src/desugarizer.rb

@@ -11,9 +11,9 @@ module Foobara
         end
 
         def foobara_manifest
-          # :nocov:
+          # simplecov:disable
           super.merge(processor_type: :desugarizer)
-          # :nocov:
+          # simplecov:enable
         end
       end
 

data/projects/typesystem/projects/type_declarations/src/dsl/attributes.rb

@@ -29,9 +29,9 @@ module Foobara
         end
 
         def respond_to_missing?(...)
-          # :nocov:
+          # simplecov:disable
           false
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -54,9 +54,9 @@ module Foobara
 
         def method_missing(attribute_name, *processor_symbols, **declaration, &block)
           unless respond_to_missing?(attribute_name)
-            # :nocov:
+            # simplecov:disable
             return super
-            # :nocov:
+            # simplecov:enable
           end
 
           _disable_method_missing do
@@ -65,7 +65,7 @@ module Foobara
             if block
               # TODO: technically, current namespace might have an overridden :array type so instead we
               # should lookup :array he to see if we get BuiltinTypes[:array] or not (or "::array" or not)
-              if processor_symbols.first == :array
+              if processor_symbols[0] == :array
                 type, *processor_symbols = processor_symbols
               end
             else
@@ -89,19 +89,19 @@ module Foobara
                 description = processor_symbol
 
                 if declaration.key?(:description)
-                  # :nocov:
+                  # simplecov:disable
                   ::Kernel.raise ArgumentError, "Expected only one description but " \
                                                 "got #{description.inspect} and #{declaration[:description].inspect}"
-                  # :nocov:
+                  # simplecov:enable
                 end
 
                 declaration[:description] = description
               when ::Symbol
                 declaration[processor_symbol] = true
               else
-                # :nocov:
+                # simplecov:disable
                 ::Kernel.raise ArgumentError, "expected a Symbol, got #{processor_symbol.inspect}"
-                # :nocov:
+                # simplecov:enable
               end
             end
 

data/projects/typesystem/projects/type_declarations/src/error_extension.rb

@@ -40,17 +40,17 @@ module Foobara
             if abstract?
               nil
             else
-              # :nocov:
+              # simplecov:disable
               raise
-              # :nocov:
+              # simplecov:enable
             end
           end
         end
 
         def context_type_declaration
-          # :nocov:
+          # simplecov:disable
           raise NoContextTypeSetError
-          # :nocov:
+          # simplecov:enable
         end
       end
 
@@ -72,9 +72,9 @@ module Foobara
       end
 
       def context_type_declaration
-        # :nocov:
+        # simplecov:disable
         self.class.context_type_declaration
-        # :nocov:
+        # simplecov:enable
       end
     end
   end

data/projects/typesystem/projects/type_declarations/src/handlers/extend_array_type_declaration/array_desugarizer.rb

@@ -20,7 +20,7 @@ module Foobara
             strict_type_declaration.is_absolutified = true
 
             unless sugary_type_declaration.empty?
-              element_type_declaration = sugary_type_declaration.first
+              element_type_declaration = sugary_type_declaration[0]
 
               element_type_declaration = if element_type_declaration.is_a?(Types::Type)
                                            element_type_declaration.reference_or_declaration_data
@@ -29,10 +29,10 @@ module Foobara
 
                                            if strict_type_declaration.deep_duped?
                                              # TODO: probably not worth directly testing this path
-                                             # :nocov:
+                                             # simplecov:disable
                                              declaration.is_deep_duped = true
                                              declaration.is_duped = true
-                                             # :nocov:
+                                             # simplecov:enable
                                            end
 
                                            handler = type_declaration_handler_for(declaration)

data/projects/typesystem/projects/type_declarations/src/handlers/extend_array_type_declaration/element_type_declaration_desugarizer.rb

@@ -26,10 +26,10 @@ module Foobara
 
                        if sugary_type_declaration.deep_duped?
                          # TODO: probably not worth directly testing this path
-                         # :nocov:
+                         # simplecov:disable
                          declaration.is_deep_duped = true
                          declaration.is_duped = true
-                         # :nocov:
+                         # simplecov:enable
                        end
 
                        handler = type_declaration_handler_for(declaration)

data/projects/typesystem/projects/type_declarations/src/handlers/extend_array_type_declaration/type_set_to_array_desugarizer.rb

@@ -26,10 +26,10 @@ module Foobara
 
             if sugary_type_declaration.deep_duped?
               # TODO: probably not worth testing this path
-              # :nocov:
+              # simplecov:disable
               strict_type_declaration.is_deep_duped = true
               strict_type_declaration.is_duped = true
-              # :nocov:
+              # simplecov:enable
             end
 
             strict_type_declaration = super(strict_type_declaration)

data/projects/typesystem/projects/type_declarations/src/handlers/extend_attributes_type_declaration/element_type_declarations_desugarizer.rb

@@ -18,10 +18,10 @@ module Foobara
 
                                              if sugary_type_declaration.deep_duped?
                                                # TODO: probably not worth directly testing this path
-                                               # :nocov:
+                                               # simplecov:disable
                                                declaration.is_deep_duped = true
                                                declaration.is_duped = true
-                                               # :nocov:
+                                               # simplecov:enable
                                              end
 
                                              handler = type_declaration_handler_for(declaration)

data/projects/typesystem/projects/type_declarations/src/handlers/extend_registered_type_declaration/to_type_transformer.rb

@@ -37,9 +37,9 @@ module Foobara
                            element_processors
                          else
                            # TODO: add validator that these are all fine so we don't have to bother here...
-                           # :nocov:
+                           # simplecov:disable
                            raise "Not sure where to put #{processor}"
-                           # :nocov:
+                           # simplecov:enable
                          end
 
               category << processor

data/projects/typesystem/projects/type_declarations/src/handlers/extend_registered_type_declaration.rb

@@ -6,9 +6,9 @@ module Foobara
       class ExtendRegisteredTypeDeclaration < RegisteredTypeDeclaration
         def applicable?(sugary_type_declaration)
           strict_type_declaration = if sugary_type_declaration.strict?
-                                      # :nocov:
+                                      # simplecov:disable
                                       sugary_type_declaration
-                                      # :nocov:
+                                      # simplecov:enable
                                     else
                                       desugarize(sugary_type_declaration.clone)
                                     end

data/projects/typesystem/projects/type_declarations/src/handlers/extend_tuple_type_declaration/array_desugarizer.rb

@@ -19,10 +19,10 @@ module Foobara
                 declaration = TypeDeclaration.new(element_type_declaration)
                 if sugary_type_declaration.deep_duped?
                   # TODO: probably not worth directly testing this path
-                  # :nocov:
+                  # simplecov:disable
                   declaration.is_deep_duped = true
                   declaration.is_duped = true
-                  # :nocov:
+                  # simplecov:enable
                 end
                 handler = type_declaration_handler_for(declaration)
                 handler.desugarize(declaration).declaration_data

data/projects/typesystem/projects/type_declarations/src/handlers/registered_type_declaration.rb

@@ -3,7 +3,6 @@ require_relative "../type_declaration_handler"
 module Foobara
   module TypeDeclarations
     module Handlers
-      # TODO: we should just use the symbol instead of {type: symbol} to save space and simplify some stuff...
       class RegisteredTypeDeclaration < TypeDeclarationHandler
         def applicable?(sugary_type_declaration)
           return true if sugary_type_declaration.type
@@ -19,11 +18,13 @@ module Foobara
                                       desugarize(sugary_type_declaration.clone)
                                     end
 
+          return true if strict_type_declaration.claimed_but_error?
+
           if strict_type_declaration.reference?
             unless strict_type_declaration.type
-              # :nocov:
+              # simplecov:disable
               strict_type_declaration.handle_symbolic_declaration
-              # :nocov:
+              # simplecov:enable
             end
 
             unless sugary_type_declaration.equal?(strict_type_declaration)

data/projects/typesystem/projects/type_declarations/src/remove_sensitive_values_transformer.rb

@@ -12,9 +12,9 @@ module Foobara
       end
 
       def transform(_value)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def sanitize_value(type, value)

data/projects/typesystem/projects/type_declarations/src/type_builder.rb

@@ -28,19 +28,19 @@ module Foobara
 
               type_declaration
             else
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Cannot provide both block and declaration of #{args}"
-              # :nocov:
+              # simplecov:enable
             end
           end
         else
           case args.size
           when 0
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "expected 1 argument or a block but got 0 arguments and no block"
-            # :nocov:
+            # simplecov:enable
           when 1
-            arg = args.first
+            arg = args[0]
 
             if arg.is_a?(TypeDeclaration)
               arg

data/projects/typesystem/projects/type_declarations/src/type_declaration.rb

@@ -9,7 +9,8 @@ module Foobara
                   :is_absolutified,
                   :reference_checked,
                   :type,
-                  :base_type
+                  :base_type,
+                  :is_claimed_but_error
 
     # TODO: we should be able to delete absolutified opt once strict declarations
     # use `:ref` instead of `{type: :ref}` format.
@@ -289,10 +290,15 @@ module Foobara
       strict? && declaration_data.is_a?(::Symbol)
     end
 
+    def claimed_but_error!
+      self.is_claimed_but_error = true
+    end
+
     alias absolutified? is_absolutified
     alias duped? is_duped
     alias deep_duped? is_deep_duped
     alias strict? is_strict
     alias reference_checked? reference_checked
+    alias claimed_but_error? is_claimed_but_error
   end
 end

data/projects/typesystem/projects/type_declarations/src/type_declaration_handler.rb

@@ -7,9 +7,9 @@ module Foobara
     class TypeDeclarationHandler < Value::Processor::Pipeline
       class << self
         def foobara_manifest
-          # :nocov:
+          # simplecov:disable
           super.merge(processor_type: :type_declaration_handler)
-          # :nocov:
+          # simplecov:enable
         end
 
         def starting_desugarizers
@@ -51,9 +51,9 @@ module Foobara
         **opts
       )
         if processors && !processors.empty?
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Cannot set processors directly for a type declaration handler"
-          # :nocov:
+          # simplecov:enable
         end
 
         self.desugarizers = Util.array(desugarizers)
@@ -67,15 +67,15 @@ module Foobara
       end
 
       def starting_desugarizers_with_inherited
-        # :nocov:
+        # simplecov:disable
         self.class.starting_desugarizers_with_inherited
-        # :nocov:
+        # simplecov:enable
       end
 
       def starting_desugarizers_without_inherited
-        # :nocov:
+        # simplecov:disable
         self.class.starting_desugarizers_without_inherited
-        # :nocov:
+        # simplecov:enable
       end
 
       def starting_type_declaration_validators
@@ -87,7 +87,7 @@ module Foobara
       end
 
       def inspect
-        # :nocov:
+        # simplecov:disable
         s = super
 
         if s.size > 400
@@ -95,13 +95,13 @@ module Foobara
         end
 
         s
-        # :nocov:
+        # simplecov:enable
       end
 
       def applicable?(_sugary_type_declaration)
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        # simplecov:disable
+        raise NotImplementedError
+        # simplecov:enable
       end
 
       def processors

data/projects/typesystem/projects/type_declarations/src/type_declaration_handler_registry.rb

@@ -3,9 +3,9 @@ module Foobara
     class TypeDeclarationHandlerRegistry < Value::Processor::Selection
       class << self
         def foobara_manifest
-          # :nocov:
+          # simplecov:disable
           super.merge(processor_type: :type_declaration_handler_registry)
-          # :nocov:
+          # simplecov:enable
         end
       end
 

data/projects/typesystem/projects/type_declarations/src/type_declaration_validator.rb

@@ -5,9 +5,9 @@ module Foobara
 
       class << self
         def foobara_manifest
-          # :nocov:
+          # simplecov:disable
           super.merge(processor_type: :type_declaration_validator)
-          # :nocov:
+          # simplecov:enable
         end
       end
 

data/projects/typesystem/projects/type_declarations/src/type_declarations.rb

@@ -62,9 +62,9 @@ module Foobara
         remover_class = sensitive_value_removers[handler.class.name]
 
         unless remover_class
-          # :nocov:
+          # simplecov:disable
           raise "No sensitive value remover found for #{declaration_data}"
-          # :nocov:
+          # simplecov:enable
         end
 
         remover_class

data/projects/typesystem/projects/type_declarations/src/with_registries.rb

@@ -48,9 +48,9 @@ module Foobara
       end
 
       def lookup_absolute_type!(...)
-        # :nocov:
+        # simplecov:disable
         self.class.lookup_absolute_type!(...)
-        # :nocov:
+        # simplecov:enable
       end
 
       def type_registered?(...)

data/projects/typesystem/projects/types/lib/foobara/types.rb

@@ -1,5 +1,3 @@
-require "singleton"
-
 module Foobara
   module Types
     class << self

data/projects/typesystem/projects/types/src/extensions/error.rb

@@ -3,7 +3,7 @@ module Foobara
     class << self
       def types_depended_on(*args)
         if args.size == 1
-          context_type.types_depended_on(args.first)
+          context_type.types_depended_on(args[0])
         elsif args.empty?
           begin
             if context_type
@@ -15,16 +15,16 @@ module Foobara
             if abstract?
               []
             else
-              # :nocov:
+              # simplecov:disable
               raise
-              # :nocov:
+              # simplecov:enable
             end
           end
 
         else
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Too many arguments #{args}"
-          # :nocov:
+          # simplecov:enable
         end
       end
     end