chef 18.7.10 → 18.8.46

data/spec/integration/recipes/notifies_spec.rb

@@ -1,438 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "chef/mixin/shell_out"
-
-describe "notifications" do
-  include IntegrationSupport
-  include Chef::Mixin::ShellOut
-
-  let(:chef_dir) { File.expand_path("../../..", __dir__) }
-  let(:chef_client) { "bundle exec #{ChefUtils::Dist::Infra::CLIENT} --minimal-ohai --always-dump-stacktrace" }
-
-  when_the_repository "notifies a nameless resource" do
-    before do
-      directory "cookbooks/x" do
-        file "recipes/default.rb", <<-EOM
-          apt_update do
-            action :nothing
-          end
-          notify_group "foo" do
-            notifies :nothing, 'apt_update', :delayed
-            action :run
-          end
-          notify_group "bar" do
-            notifies :nothing, 'apt_update[]', :delayed
-            action :run
-          end
-        EOM
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      # our delayed notification should run at the end of the parent run_context after the baz resource
-      expect(result.stdout).to match(/\* apt_update\[\] action nothing \(skipped due to action :nothing\)\s+\* notify_group\[foo\] action run\s+\* notify_group\[bar\] action run\s+\* apt_update\[\] action nothing \(skipped due to action :nothing\)/)
-      result.error!
-    end
-  end
-
-  when_the_repository "notifies delayed one" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/notifying_test.rb", <<~EOM
-          unified_mode true
-
-          default_action :run
-          provides :notifying_test
-          resource_name :notifying_test
-
-          action :run do
-            notify_group "bar" do
-              notifies :write, 'log[foo]', :delayed
-              action :run
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          log "foo" do
-            action :nothing
-          end
-          notifying_test "whatever"
-          log "baz"
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      # our delayed notification should run at the end of the parent run_context after the baz resource
-      expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* log\[baz\] action write\s+\* log\[foo\] action write/)
-      result.error!
-    end
-  end
-
-  when_the_repository "notifies delayed two" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/notifying_test.rb", <<~EOM
-          unified_mode true
-
-          default_action :run
-          provides :notifying_test
-          resource_name :notifying_test
-
-          action :run do
-            notify_group "bar" do
-              notifies :write, 'log[foo]', :delayed
-              action :run
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          log "foo" do
-            action :nothing
-          end
-          notifying_test "whatever"
-          notify_group "baz" do
-            notifies :write, 'log[foo]', :delayed
-            action :run
-          end
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      # our delayed notification should run at the end of the parent run_context after the baz resource
-      expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* notify_group\[baz\] action run\s+\* log\[foo\] action write/)
-      # and only run once
-      expect(result.stdout).not_to match(/\* log\[foo\] action write.*\* log\[foo\] action write/)
-      result.error!
-    end
-  end
-
-  when_the_repository "notifies delayed three" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/notifying_test.rb", <<~EOM
-          unified_mode true
-
-          default_action :run
-          provides :notifying_test
-          resource_name :notifying_test
-
-          action :run do
-            notify_group "bar" do
-              notifies :write, 'log[foo]', :delayed
-              action :run
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          log "foo" do
-            action :nothing
-          end
-          notify_group "quux" do
-            notifies :write, 'log[foo]', :delayed
-            notifies :write, 'log[baz]', :delayed
-            action :run
-          end
-          notifying_test "whatever"
-          log "baz"
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      # the delayed notification from the sub-resource is de-duplicated by the notification already in the parent run_context
-      expect(result.stdout).to match(/\* notify_group\[quux\] action run\s+\* notifying_test\[whatever\] action run\s+\* notify_group\[bar\] action run\s+\* log\[baz\] action write\s+\* log\[foo\] action write\s+\* log\[baz\] action write/)
-      # and only run once
-      expect(result.stdout).not_to match(/\* log\[foo\] action write.*\* log\[foo\] action write/)
-      result.error!
-    end
-  end
-
-  when_the_repository "notifies delayed four" do
-    before do
-      directory "cookbooks/x" do
-        file "recipes/default.rb", <<~EOM
-          log "foo" do
-            action :nothing
-          end
-          notify_group "bar" do
-            notifies :write, 'log[foo]', :delayed
-            action :run
-          end
-          notify_group "baz" do
-            notifies :write, 'log[foo]', :delayed
-            action :run
-          end
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      # the delayed notification from the sub-resource is de-duplicated by the notification already in the parent run_context
-      expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* notify_group\[baz\] action run\s+\* log\[foo\] action write/)
-      # and only run once
-      expect(result.stdout).not_to match(/\* log\[foo\] action write.*\* log\[foo\] action write/)
-      result.error!
-    end
-  end
-
-  when_the_repository "notifies immediately" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/notifying_test.rb", <<~EOM
-          unified_mode true
-
-          default_action :run
-          provides :notifying_test
-          resource_name :notifying_test
-
-          action :run do
-            notify_group "bar" do
-              notifies :write, 'log[foo]', :immediately
-              action :run
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          log "foo" do
-            action :nothing
-          end
-          notifying_test "whatever"
-          log "baz"
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* log\[foo\] action write\s+\* log\[baz\] action write/)
-      result.error!
-    end
-  end
-
-  when_the_repository "uses old notifies syntax" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/notifying_test.rb", <<~EOM
-          unified_mode true
-
-          default_action :run
-          provides :notifying_test
-          resource_name :notifying_test
-
-          action :run do
-            notify_group "bar" do
-              notifies :write, resources(log: "foo"), :immediately
-              action :run
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          log "foo" do
-            action :nothing
-          end
-          notifying_test "whatever"
-          log "baz"
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* log\[foo\] action write\s+\* log\[baz\] action write/)
-      result.error!
-    end
-  end
-
-  when_the_repository "does not have a matching resource" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/notifying_test.rb", <<~EOM
-          unified_mode true
-
-          default_action :run
-          provides :notifying_test
-          resource_name :notifying_test
-
-          action :run do
-            notify_group "bar" do
-              notifies :write, "log[foo]"
-              action :run
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          notifying_test "whatever"
-          log "baz"
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      expect(result.stdout).to match(/Chef::Exceptions::ResourceNotFound/)
-      expect(result.exitstatus).not_to eql(0)
-    end
-  end
-
-  when_the_repository "encounters identical resources in parent and child resource collections" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/cloning_test.rb", <<~EOM
-          unified_mode true
-
-          default_action :run
-          provides :cloning_test
-          resource_name :cloning_test
-
-          action :run do
-            log "bar" do
-              level :info
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          log "bar" do
-            level :warn
-          end
-
-          cloning_test "whatever"
-        EOM
-
-      end
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      expect(result.stdout).not_to match(/CHEF-3694/)
-      result.error!
-    end
-  end
-
-  when_the_repository "has resources that have arrays as the name" do
-    before do
-      directory "cookbooks/x" do
-        file "recipes/default.rb", <<-EOM
-          log [ "a", "b" ] do
-            action :nothing
-          end
-
-          notify_group "doit" do
-            notifies :write, "log[a, b]"
-            action :run
-          end
-        EOM
-      end
-    end
-
-    it "notifying the resource should work" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      expect(result.stdout).to match(/\* log\[a, b\] action write/)
-      result.error!
-    end
-
-  end
-end

data/spec/integration/recipes/notifying_block_spec.rb

@@ -1,116 +0,0 @@
-#
-# Author:: John Keiser (<jkeiser@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "chef/mixin/shell_out"
-
-describe "notifying_block" do
-  include IntegrationSupport
-  include Chef::Mixin::ShellOut
-
-  let(:chef_dir) { File.expand_path("../../..", __dir__) }
-  let(:chef_client) { "bundle exec #{ChefUtils::Dist::Infra::CLIENT} --minimal-ohai --always-dump-stacktrace" }
-
-  when_the_repository "notifying_block test one" do
-    before do
-      directory "cookbooks/x" do
-        file "recipes/default.rb", <<-EOM
-          notifying_block do
-            log "gamma" do
-              action :nothing
-            end
-            notify_group "alpha" do
-              notifies :write, "log[gamma]", :delayed
-              action :run
-            end
-            notify_group "beta" do
-              notifies :write, "log[gamma]", :delayed
-              action :run
-            end
-          end
-          log "delta"
-        EOM
-      end
-      file "config/client.rb", <<-EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-    end
-
-    # implicitly tests -
-    #  1. notifying block opens up a subcontext
-    #  2. delayed notifications are de-dup'd in the subcontext
-    #  3. delayed notifications (to resources inside the subcontext) are run at the end of the subcontext
-    it "should run alpha, beta, gamma, and delta in that order" do
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      expect(result.stdout).to match(/\* notify_group\[alpha\] action run\s+\* notify_group\[beta\] action run\s+\* log\[gamma\] action write\s+Converging 1 resources\s+\* log\[delta\] action write/)
-      result.error!
-    end
-  end
-
-  when_the_repository "notifying_block test two" do
-    before do
-      directory "cookbooks/x" do
-        file "resources/nb_test.rb", <<-EOM
-          unified_mode true
-          default_action :run
-          provides :nb_test
-          resource_name :nb_test
-
-          action :run do
-            notifying_block do
-              notify_group "foo" do
-                notifies :write, 'log[bar]', :delayed
-                action :run
-              end
-            end
-          end
-        EOM
-        file "recipes/default.rb", <<-EOM
-          log "bar" do
-            action :nothing
-          end
-          log "baz" do
-            action :nothing
-          end
-
-          nb_test "testing" do
-            notifies :write, 'log[baz]', :delayed
-          end
-
-          log "quux"
-        EOM
-      end
-      file "config/client.rb", <<-EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-    end
-
-    # implicitly tests -
-    #  1. notifying block will correctly update wrapping new_resource updated_by_last_action status
-    #  2. delayed notifications from a subcontext inside a resource will notify resources in their outer run_context
-    it "should run foo, quux, bar, and baz in that order" do
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      expect(result.stdout).to match(/\* notify_group\[foo\] action run\s+\* log\[quux\] action write\s+\* log\[bar\] action write\s+\* log\[baz\] action write/)
-      result.error!
-    end
-  end
-end

data/spec/integration/recipes/provider_choice.rb

@@ -1,38 +0,0 @@
-require "support/shared/integration/integration_helper"
-
-describe "Recipe DSL methods" do
-  include IntegrationSupport
-
-  context "With resource class providing 'provider_thingy'" do
-    before :context do
-      class Chef::Resource::ProviderThingy < Chef::Resource
-        resource_name :provider_thingy
-        default_action :create
-        def to_s
-          "provider_thingy resource class"
-        end
-      end
-    end
-    context "And class Chef::Provider::ProviderThingy with no provides" do
-      before :context do
-        class Chef::Provider::ProviderThingy < Chef::Provider
-          provides :provider_thingy
-
-          def load_current_resource; end
-
-          def action_create
-            Chef::Log.warn("hello from #{self.class.name}")
-          end
-        end
-      end
-
-      it "provider_thingy 'blah' runs the provider and warns" do
-        recipe = converge do
-          provider_thingy("blah") {}
-        end
-        expect(recipe.logged_warnings).to match(/hello from Chef::Provider::ProviderThingy/)
-        expect(recipe.logged_warnings).to match(/you must use 'provides' to provide DSL/i)
-      end
-    end
-  end
-end