chef 18.7.10 → 18.8.46

data/spec/unit/resource/build_essential_spec.rb

@@ -1,77 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Resource::BuildEssential do
-
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::BuildEssential.new("foo", run_context) }
-  let(:provider) { resource.provider_for_action(:install) }
-
-  let(:softwareupdate_catalina_and_later) do
-    double("shell_out", exitstatus: 0, error!: nil, stdout: "Software Update Tool\n\nFinding available software\nSoftware Update found the following new or updated software:\n* Label: Command Line Tools for Xcode-11.0\n\tTitle: Command Line Tools for Xcode, Version: 11.0, Size: 224868K, Recommended: YES, \n")
-  end
-
-  let(:softwareupdate_catalina_and_later_no_cli) do
-    double("shell_out", exitstatus: 0, error!: nil, stdout: "Software Update Tool\n\nFinding available software\nSoftware Update found the following new or updated software:\n* Label: Chef Infra Client\n\tTitle: Chef Infra Client, Version: 17.0.208, Size: 224868K, Recommended: YES, \n")
-  end
-
-  let(:softwareupdate_pre_catalina) do
-    double("shell_out", exitstatus: 0, error!: nil, stdout: "Software Update Tool\n\nFinding available software\nSoftware Update found the following new or updated software:\n   * Command Line Tools (macOS High Sierra version 10.13) for Xcode-10.0\n")
-  end
-
-  it "has a resource name of :build_essential" do
-    expect(resource.resource_name).to eql(:build_essential)
-  end
-
-  it "sets the default action as :install" do
-    expect(resource.action).to eql([:install])
-  end
-
-  it "supports :install action" do
-    expect { resource.action :install }.not_to raise_error
-  end
-
-  context "when not settting a resource name" do
-    let(:resource) { Chef::Resource::BuildEssential.new(nil) }
-
-    it "the name defaults to an empty string" do
-      expect(resource.name).to eql("")
-    end
-  end
-
-  describe "#xcode_cli_package_label" do
-    it "returns a package name on macOS < 10.15" do
-      allow(provider).to receive(:shell_out).with("softwareupdate", "--list").and_return(softwareupdate_pre_catalina)
-      expect(provider.xcode_cli_package_label).to eql("Command Line Tools (macOS High Sierra version 10.13) for Xcode-10.0")
-    end
-
-    it "returns a package name on macOS 10.15+" do
-      allow(provider).to receive(:shell_out).with("softwareupdate", "--list").and_return(softwareupdate_catalina_and_later)
-      expect(provider.xcode_cli_package_label).to eql("Command Line Tools for Xcode-11.0")
-    end
-
-    it "returns nil if no update is listed" do
-      allow(provider).to receive(:shell_out).with("softwareupdate", "--list").and_return(softwareupdate_catalina_and_later_no_cli)
-      expect(provider.xcode_cli_package_label).to be_nil
-    end
-
-  end
-end

data/spec/unit/resource/cab_package_spec.rb

@@ -1,64 +0,0 @@
-#
-# Author:: Vasundhara Jagdale (<vasundhara.jagdale@msystechnologies.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Resource::CabPackage do
-
-  let(:resource) { Chef::Resource::CabPackage.new("test_pkg") }
-
-  it "is a subclass of Chef::Resource::Package" do
-    expect(resource).to be_a_kind_of(Chef::Resource::Package)
-  end
-
-  it "sets resource name as :cab_package" do
-    expect(resource.resource_name).to eql(:cab_package)
-  end
-
-  it "sets the default action as :install" do
-    expect(resource.action).to eql([:install])
-  end
-
-  it "supports :install, :lock, :purge, :reconfig, :remove, :unlock, :upgrade actions" do
-    expect { resource.action :install }.not_to raise_error
-    expect { resource.action :lock }.not_to raise_error
-    expect { resource.action :purge }.not_to raise_error
-    expect { resource.action :reconfig }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
-    expect { resource.action :unlock }.not_to raise_error
-    expect { resource.action :upgrade }.not_to raise_error
-  end
-
-  it "coerces name property to package_name property" do
-    expect(resource.package_name).to eql("test_pkg")
-  end
-
-  it "coerces name property to a source property if source not provided" do
-    expect(resource.source).to end_with("test_pkg")
-  end
-
-  it "coerces name property to a source property if source not provided and package_name is" do
-    resource.package_name("package.cab")
-    expect(resource.source).to end_with("package.cab")
-  end
-
-  it "coerces source property if it does not looks like a path" do
-    resource.source("package.cab")
-    expect(resource.source).not_to eq("package.cab")
-  end
-end

data/spec/unit/resource/chef_client_config_spec.rb

@@ -1,145 +0,0 @@
-#
-# Author:: Tim Smith (<tsmith@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Resource::ChefClientConfig do
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::ChefClientConfig.new("fakey_fakerton", run_context) }
-  let(:provider) { resource.provider_for_action(:create) }
-
-  it "sets the default action as :create" do
-    expect(resource.action).to eql([:create])
-  end
-
-  it "supports :create and :remove actions" do
-    expect { resource.action :create }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
-  end
-
-  describe "ssl_verify_mode property" do
-    it "coerces String to Symbol" do
-      resource.ssl_verify_mode "verify_peer"
-      expect(resource.ssl_verify_mode).to eql(:verify_peer)
-    end
-
-    it "coerces Symbol-like String to Symbol" do
-      resource.ssl_verify_mode ":verify_peer"
-      expect(resource.ssl_verify_mode).to eql(:verify_peer)
-    end
-
-    it "raises an error if it is not an allowed value" do
-      expect { resource.ssl_verify_mode("foo") }.to raise_error(Chef::Exceptions::ValidationFailed)
-      expect { resource.ssl_verify_mode(:verify_none) }.not_to raise_error
-      expect { resource.ssl_verify_mode(:verify_peer) }.not_to raise_error
-    end
-  end
-
-  describe "no_proxy property" do
-    it "coerces Array into comma separated list" do
-      resource.no_proxy ["something.com", "example.com"]
-      expect(resource.no_proxy).to eql("something.com,example.com")
-    end
-
-    it "accepts String of comma separated values" do
-      resource.no_proxy "something.com,example.com"
-      expect(resource.no_proxy).to eql("something.com,example.com")
-    end
-  end
-
-  describe "ohai_disabled_plugins property" do
-    it "coerces String values into capitalized symbols" do
-      resource.ohai_disabled_plugins %w{foo Bar}
-      expect(resource.ohai_disabled_plugins).to eql(%i{Foo Bar})
-    end
-
-    it "coerces symbol-like string values into capitalized Symbols" do
-      resource.ohai_disabled_plugins [":foo", ":Bar"]
-      expect(resource.ohai_disabled_plugins).to eql(%i{Foo Bar})
-    end
-
-    it "coerces Symbol values into capitalized Symbols" do
-      resource.ohai_disabled_plugins %i{foo Bar}
-      expect(resource.ohai_disabled_plugins).to eql(%i{Foo Bar})
-    end
-  end
-
-  describe "ohai_optional_plugins property" do
-    it "coerces String values into capitalized symbols" do
-      resource.ohai_optional_plugins %w{foo Bar}
-      expect(resource.ohai_optional_plugins).to eql(%i{Foo Bar})
-    end
-
-    it "coerces symbol-like string values into capitalized Symbols" do
-      resource.ohai_optional_plugins [":foo", ":Bar"]
-      expect(resource.ohai_optional_plugins).to eql(%i{Foo Bar})
-    end
-
-    it "coerces Symbol values into capitalized Symbols" do
-      resource.ohai_optional_plugins %i{foo Bar}
-      expect(resource.ohai_optional_plugins).to eql(%i{Foo Bar})
-    end
-  end
-
-  describe "log_level property" do
-    it "accepts auto trace debug info warn fatal" do
-      expect { resource.log_level(:auto) }.not_to raise_error
-      expect { resource.log_level(:trace) }.not_to raise_error
-      expect { resource.log_level(:debug) }.not_to raise_error
-      expect { resource.log_level(:info) }.not_to raise_error
-      expect { resource.log_level(:warn) }.not_to raise_error
-    end
-
-    it "raises an error if an invalid value is passed" do
-      expect { resource.log_level(":foo") }.to raise_error(Chef::Exceptions::ValidationFailed)
-    end
-  end
-
-  describe "log_location property" do
-    it "accepts a String logfile location" do
-      expect { resource.log_location("/foo/bar/") }.not_to raise_error
-    end
-
-    it "accepts a String form of STDOUT/STDERR" do
-      expect { resource.log_location("STDOUT") }.not_to raise_error
-      expect { resource.log_location("STDERR") }.not_to raise_error
-    end
-
-    it "accepts :syslog or :win_evt Symbols" do
-      expect { resource.log_location(:syslog) }.not_to raise_error
-      expect { resource.log_location(:win_evt) }.not_to raise_error
-      expect { resource.log_location(:nope) }.to raise_error(Chef::Exceptions::ValidationFailed)
-    end
-  end
-
-  describe "#format_handler" do
-    it "provides an array of handler object creation code" do
-      expect(provider.format_handler([{ "class" => "Foo", "arguments" => ["'one'", "two", "three"] }])).to eql(["Foo.new('one',two,three)"])
-    end
-  end
-
-  describe "rubygems_url property" do
-    it "accepts nil, a single URL, or an array of URLs" do
-      expect { resource.rubygems_url(nil) }.not_to raise_error
-      expect { resource.rubygems_url("https://rubygems.internal.example.com") }.not_to raise_error
-      expect { resource.rubygems_url(["https://rubygems.east.example.com", "https://rubygems.west.example.com"]) }.not_to raise_error
-    end
-  end
-end

data/spec/unit/resource/chef_client_cron_spec.rb

@@ -1,161 +0,0 @@
-#
-# Author:: Tim Smith (<tsmith@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Resource::ChefClientCron do
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::ChefClientCron.new("fakey_fakerton", run_context) }
-  let(:provider) { resource.provider_for_action(:add) }
-
-  it "sets the default action as :add" do
-    expect(resource.action).to eql([:add])
-  end
-
-  it "supports :add and :remove actions" do
-    expect { resource.action :add }.not_to raise_error
-    expect { resource.action :remove }.not_to raise_error
-  end
-
-  it "coerces splay to an Integer" do
-    resource.splay "10"
-    expect(resource.splay).to eql(10)
-  end
-
-  it "raises an error if splay is not a positive number" do
-    expect { resource.splay("-10") }.to raise_error(Chef::Exceptions::ValidationFailed)
-  end
-
-  it "set splay to 0" do
-    resource.splay "0"
-    expect(resource.splay).to eql(0)
-  end
-
-  it "builds a default value for chef_binary_path dist values" do
-    expect(resource.chef_binary_path).to eql("/opt/chef/bin/chef-client")
-  end
-
-  it "raises an error if nice is less than -20" do
-    expect { resource.nice(-21) }.to raise_error(Chef::Exceptions::ValidationFailed)
-  end
-
-  it "raises an error if nice is greater than 19" do
-    expect { resource.nice(20) }.to raise_error(Chef::Exceptions::ValidationFailed)
-  end
-
-  it "coerces nice to an Integer" do
-    resource.nice "10"
-    expect(resource.nice).to eql(10)
-  end
-
-  it "log_directory is /Library/Logs/Chef on macOS systems" do
-    node.automatic_attrs[:platform_family] = "mac_os_x"
-    node.automatic_attrs[:platform] = "mac_os_x"
-    expect(resource.log_directory).to eql("/Library/Logs/Chef")
-  end
-
-  it "log_directory is /var/log/chef on non-macOS systems" do
-    node.automatic_attrs[:platform_family] = "ubuntu"
-    expect(resource.log_directory).to eql("/var/log/chef")
-  end
-
-  describe "#splay_sleep_time" do
-    it "uses shard_seed attribute if present" do
-      node.automatic_attrs[:shard_seed] = "73399073"
-      expect(provider.splay_sleep_time(300)).to satisfy { |v| v >= 0 && v <= 300 }
-    end
-
-    it "uses a hex conversion of a md5 hash of the splay if present" do
-      node.automatic_attrs[:shard_seed] = nil
-      allow(node).to receive(:name).and_return("test_node")
-      expect(provider.splay_sleep_time(300)).to satisfy { |v| v >= 0 && v <= 300 }
-    end
-  end
-
-  describe "#client_command" do
-    before do
-      allow(provider).to receive(:splay_sleep_time).and_return("123")
-    end
-
-    let(:root_path) { windows? ? "C:\\chef/client.rb" : "/etc/chef/client.rb" }
-
-    it "creates a valid command if using all default properties" do
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} >> /var/log/chef/client.log 2>&1"
-      )
-    end
-
-    it "uses daemon_options if set" do
-      resource.daemon_options ["--foo 1", "--bar 2"]
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client --foo 1 --bar 2 -c #{root_path} >> /var/log/chef/client.log 2>&1"
-      )
-    end
-
-    it "uses custom config dir if set" do
-      resource.config_directory "/etc/some_other_dir"
-      expect(provider.client_command).to eql("/bin/sleep 123; /opt/chef/bin/chef-client -c /etc/some_other_dir/client.rb >> /var/log/chef/client.log 2>&1")
-    end
-
-    it "uses custom log files / paths if set" do
-      resource.log_file_name "my-client.log"
-      resource.log_directory "/var/log/my-chef/"
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} >> /var/log/my-chef/my-client.log 2>&1"
-      )
-    end
-
-    it "uses mailto if set" do
-      resource.mailto "bob@example.com"
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} >> /var/log/chef/client.log 2>&1 || echo \"Chef Infra Client execution failed\""
-      )
-    end
-
-    it "uses custom chef-client binary if set" do
-      resource.chef_binary_path "/usr/local/bin/chef-client"
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /usr/local/bin/chef-client -c #{root_path} >> /var/log/chef/client.log 2>&1"
-      )
-    end
-
-    it "appends to the log file appending if set to false" do
-      resource.append_log_file false
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} > /var/log/chef/client.log 2>&1"
-      )
-    end
-
-    it "sets the license acceptance flag if set" do
-      resource.accept_chef_license true
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} --chef-license accept >> /var/log/chef/client.log 2>&1"
-      )
-    end
-
-    it "uses nice if set" do
-      allow(provider).to receive(:which).with("nice").and_return("/usr/bin/nice")
-      resource.nice(-15)
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /usr/bin/nice -n -15 /opt/chef/bin/chef-client -c #{root_path} >> /var/log/chef/client.log 2>&1"
-      )
-    end
-  end
-end

data/spec/unit/resource/chef_client_launchd_spec.rb

@@ -1,132 +0,0 @@
-#
-# Author:: Tim Smith (<tsmith@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Resource::ChefClientLaunchd do
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:resource) { Chef::Resource::ChefClientLaunchd.new("fakey_fakerton", run_context) }
-  let(:provider) { resource.provider_for_action(:enable) }
-
-  it "sets the default action as :enable" do
-    expect(resource.action).to eql([:enable])
-  end
-
-  it "supports :enable and :disable actions" do
-    expect { resource.action :enable }.not_to raise_error
-    expect { resource.action :disable }.not_to raise_error
-  end
-
-  it "coerces splay to an Integer" do
-    resource.splay "10"
-    expect(resource.splay).to eql(10)
-  end
-
-  it "raises an error if splay is not a positive number" do
-    expect { resource.splay("-10") }.to raise_error(Chef::Exceptions::ValidationFailed)
-  end
-
-  it "set splay to 0" do
-    resource.splay "0"
-    expect(resource.splay).to eql(0)
-  end
-
-  it "builds a default value for chef_binary_path dist values" do
-    expect(resource.chef_binary_path).to eql("/opt/chef/bin/chef-client")
-  end
-
-  it "raises an error if interval is not a positive number" do
-    expect { resource.interval("-10") }.to raise_error(Chef::Exceptions::ValidationFailed)
-  end
-
-  it "coerces interval to an Integer" do
-    resource.interval "10"
-    expect(resource.interval).to eql(10)
-  end
-
-  it "raises an error if nice is less than -20" do
-    expect { resource.nice(-21) }.to raise_error(Chef::Exceptions::ValidationFailed)
-  end
-
-  it "raises an error if nice is greater than 19" do
-    expect { resource.nice(20) }.to raise_error(Chef::Exceptions::ValidationFailed)
-  end
-
-  it "coerces nice to an Integer" do
-    resource.nice "10"
-    expect(resource.nice).to eql(10)
-  end
-
-  describe "#splay_sleep_time" do
-    it "uses shard_seed attribute if present" do
-      node.automatic_attrs[:shard_seed] = "73399073"
-      expect(provider.splay_sleep_time(300)).to satisfy { |v| v >= 0 && v <= 300 }
-    end
-
-    it "uses a hex conversion of a md5 hash of the splay if present" do
-      node.automatic_attrs[:shard_seed] = nil
-      allow(node).to receive(:name).and_return("test_node")
-      expect(provider.splay_sleep_time(300)).to satisfy { |v| v >= 0 && v <= 300 }
-    end
-  end
-
-  describe "#client_command" do
-    before do
-      allow(provider).to receive(:splay_sleep_time).and_return("123")
-    end
-
-    let(:root_path) { windows? ? "C:\\chef/client.rb" : "/etc/chef/client.rb" }
-
-    it "creates a valid command if using all default properties" do
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} -L /Library/Logs/Chef/client.log"
-      )
-    end
-
-    it "adds custom daemon options from daemon_options property" do
-      resource.daemon_options %w{foo bar}
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client foo bar -c #{root_path} -L /Library/Logs/Chef/client.log"
-      )
-    end
-
-    it "adds license acceptance flags if the property is set" do
-      resource.accept_chef_license true
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} -L /Library/Logs/Chef/client.log --chef-license accept"
-      )
-    end
-
-    it "uses custom config dir if set" do
-      resource.config_directory "/etc/some_other_dir"
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c /etc/some_other_dir/client.rb -L /Library/Logs/Chef/client.log"
-      )
-    end
-
-    it "uses custom log files / paths if set" do
-      resource.log_file_name "my-client.log"
-      resource.log_directory "/var/log/my-chef/"
-      expect(provider.client_command).to eql(
-        "/bin/sleep 123; /opt/chef/bin/chef-client -c #{root_path} -L /var/log/my-chef/my-client.log"
-      )
-    end
-  end
-end