chef 18.7.10 → 18.8.46

data/spec/unit/provider/group/groupmod_spec.rb

@@ -1,136 +0,0 @@
-#
-# Author:: Dan Crosta (<dcrosta@late.am>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Group::Groupmod do
-  let(:logger) { double("Mixlib::Log::Child").as_null_object }
-
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    allow(@run_context).to receive(:logger).and_return(logger)
-    @new_resource = Chef::Resource::Group.new("wheel")
-    @new_resource.gid 123
-    @new_resource.members %w{lobster rage fist}
-    @new_resource.append false
-    @provider = Chef::Provider::Group::Groupmod.new(@new_resource, @run_context)
-  end
-
-  describe "manage_group" do
-    describe "when determining the current group state" do
-      it "should raise an error if the required binary /usr/sbin/group doesn't exist" do
-        expect(File).to receive(:exist?).with("/usr/sbin/group").and_return(false)
-        expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Group)
-      end
-      it "should raise an error if the required binary /usr/sbin/user doesn't exist" do
-        expect(File).to receive(:exist?).with("/usr/sbin/group").and_return(true)
-        expect(File).to receive(:exist?).with("/usr/sbin/user").and_return(false)
-        expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Group)
-      end
-
-      it "shouldn't raise an error if the required binaries exist" do
-        allow(File).to receive(:exist?).and_return(true)
-        expect { @provider.load_current_resource }.not_to raise_error
-      end
-    end
-
-    describe "after the group's current state is known" do
-      before do
-        @current_resource = @new_resource.dup
-        @provider.current_resource = @current_resource
-      end
-
-      describe "when no group members are specified and append is not set" do
-        before do
-          @new_resource.append(false)
-          @new_resource.members([])
-        end
-
-        it "logs a message and sets group's members to 'none', then removes existing group members" do
-          expect(logger).to receive(:debug).with("group[wheel] setting group members to: none")
-          expect(@provider).to receive(:shell_out_compacted!).with("group", "mod", "-n", "wheel_bak", "wheel")
-          expect(@provider).to receive(:shell_out_compacted!).with("group", "add", "-g", "123", "-o", "wheel")
-          expect(@provider).to receive(:shell_out_compacted!).with("group", "del", "wheel_bak")
-          @provider.manage_group
-        end
-      end
-
-      describe "when no group members are specified and append is set" do
-        before do
-          @new_resource.append(true)
-          @new_resource.members([])
-        end
-
-        it "logs a message and does not modify group membership" do
-          expect(logger).to receive(:debug).with("group[wheel] not changing group members, the group has no members to add")
-          expect(@provider).not_to receive(:shell_out_compacted!)
-          @provider.manage_group
-        end
-      end
-
-      describe "when removing some group members" do
-        before do
-          @new_resource.append(false)
-          @new_resource.members(%w{ lobster })
-        end
-
-        it "updates group membership correctly" do
-          allow(logger).to receive(:trace)
-          expect(@provider).to receive(:shell_out_compacted!).with("group", "mod", "-n", "wheel_bak", "wheel")
-          expect(@provider).to receive(:shell_out_compacted!).with("user", "mod", "-G", "wheel", "lobster")
-          expect(@provider).to receive(:shell_out_compacted!).with("group", "add", "-g", "123", "-o", "wheel")
-          expect(@provider).to receive(:shell_out_compacted!).with("group", "del", "wheel_bak")
-          @provider.manage_group
-        end
-      end
-    end
-  end
-
-  describe "create_group" do
-    describe "when creating a new group" do
-      before do
-        @current_resource = Chef::Resource::Group.new("wheel")
-        @provider.current_resource = @current_resource
-      end
-
-      it "should run a group add command and some user mod commands" do
-        expect(@provider).to receive(:shell_out_compacted!).with("group", "add", "-g", "123", "wheel")
-        expect(@provider).to receive(:shell_out_compacted!).with("user", "mod", "-G", "wheel", "lobster")
-        expect(@provider).to receive(:shell_out_compacted!).with("user", "mod", "-G", "wheel", "rage")
-        expect(@provider).to receive(:shell_out_compacted!).with("user", "mod", "-G", "wheel", "fist")
-        @provider.create_group
-      end
-    end
-  end
-
-  describe "remove_group" do
-    describe "when removing an existing group" do
-      before do
-        @current_resource = @new_resource.dup
-        @provider.current_resource = @current_resource
-      end
-
-      it "should run a group del command" do
-        expect(@provider).to receive(:shell_out_compacted!).with("group", "del", "wheel")
-        @provider.remove_group
-      end
-    end
-  end
-end

data/spec/unit/provider/group/pw_spec.rb

@@ -1,141 +0,0 @@
-#
-# Author:: Stephen Haynes (<sh@nomitor.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Group::Pw do
-  let(:logger) { double("Mixlib::Log::Child").as_null_object }
-
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    allow(@run_context).to receive(:logger).and_return(logger)
-
-    @new_resource = Chef::Resource::Group.new("wheel")
-    @new_resource.gid 50
-    @new_resource.members %w{root aj}
-
-    @current_resource = Chef::Resource::Group.new("aj")
-    @current_resource.gid 50
-    @current_resource.members %w{root aj}
-    @provider = Chef::Provider::Group::Pw.new(@new_resource, @run_context)
-    @provider.current_resource = @current_resource
-  end
-
-  describe "when setting options for the pw command" do
-    it "does not set the gid option if gids match or are unmanaged" do
-      expect(@provider.set_options).to eq(["wheel"])
-    end
-
-    it "sets the option for gid if it is not nil" do
-      @new_resource.gid(42)
-      expect(@provider.set_options).to eql(["wheel", "-g", 42])
-    end
-  end
-
-  describe "when creating a group" do
-    it "should run pw groupadd with the return of set_options and set_members_option" do
-      @new_resource.gid(23)
-      expect(@provider).to receive(:shell_out_compacted!).with("pw", "groupadd", "wheel", "-g", "23", "-M", "root,aj").and_return(true)
-      @provider.create_group
-    end
-  end
-
-  describe "when managing the group" do
-
-    it "should run pw groupmod with the return of set_options" do
-      @new_resource.gid(42)
-      @new_resource.members(["someone"])
-      expect(@provider).to receive(:shell_out_compacted!).with("pw", "groupmod", "wheel", "-g", "42", "-m", "someone").and_return(true)
-      expect(@provider).to receive(:shell_out_compacted!).with("pw", "groupmod", "wheel", "-g", "42", "-d", "root,aj").and_return(true)
-      @provider.manage_group
-    end
-
-  end
-
-  describe "when removing the group" do
-    it "should run pw groupdel with the new resources group name" do
-      expect(@provider).to receive(:shell_out_compacted!).with("pw", "groupdel", "wheel").and_return(true)
-      @provider.remove_group
-    end
-  end
-
-  describe "when setting group membership" do
-
-    describe "with an empty members array in both the new and current resource" do
-      before do
-        @new_resource.members([])
-        allow(@current_resource).to receive(:members).and_return([])
-      end
-
-      it "should set no options" do
-        expect(@provider.set_members_options).to eql([ ])
-      end
-    end
-
-    describe "with an empty members array in the new resource and existing members in the current resource" do
-      before do
-        @new_resource.members([])
-        allow(@current_resource).to receive(:members).and_return(%w{all your base})
-      end
-
-      it "should log an appropriate message" do
-        expect(logger).to receive(:debug).with("group[wheel] removing group members: all,your,base")
-        @provider.set_members_options
-      end
-
-      it "should set the -d option with the members joined by ','" do
-        expect(@provider.set_members_options).to eql([ ["-d", "all,your,base"] ])
-      end
-    end
-
-    describe "with supplied members array in the new resource and an empty members array in the current resource" do
-      before do
-        @new_resource.members(%w{all your base})
-        allow(@current_resource).to receive(:members).and_return([])
-      end
-
-      it "should log an appropriate debug message" do
-        expect(logger).to receive(:debug).with("group[wheel] adding group members: all,your,base")
-        @provider.set_members_options
-      end
-
-      it "should set the -m option with the members joined by ','" do
-        expect(@provider.set_members_options).to eql([[ "-m", "all,your,base" ]])
-      end
-    end
-  end
-
-  describe "load_current_resource" do
-    before(:each) do
-      @provider.action = :create
-      @provider.load_current_resource
-      @provider.define_resource_requirements
-    end
-    it "should raise an error if the required binary /usr/sbin/pw doesn't exist" do
-      expect(File).to receive(:exist?).with("/usr/sbin/pw").and_return(false)
-      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-    it "shouldn't raise an error if /usr/sbin/pw exists" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect { @provider.process_resource_requirements }.not_to raise_error
-    end
-  end
-end

data/spec/unit/provider/group/solaris_spec.rb

@@ -1,106 +0,0 @@
-#
-# Author:: Joshua Justice (<jjustice6@bloomberg.net>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Group::Solaris do
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::Group.new("wheel")
-    @new_resource.members %w{all your base}
-    @new_resource.excluded_members [ ]
-    @provider = Chef::Provider::Group::Solaris.new(@new_resource, @run_context)
-    allow(@provider).to receive(:run_command)
-  end
-
-  describe "modify_group_members" do
-
-    describe "with an empty members array" do
-      before do
-        @new_resource.append(true)
-        @new_resource.members([])
-      end
-
-      it "should log an appropriate message" do
-        expect(@provider).not_to receive(:shell_out_compacted!)
-        @provider.modify_group_members
-      end
-    end
-
-    describe "with supplied members" do
-      platforms = {
-        "solaris2" => [ "-G" ],
-      }
-
-      before do
-        @new_resource.members(%w{all your base})
-        allow(File).to receive(:exist?).and_return(true)
-      end
-
-      it "should groupmod the whole batch when append is false" do
-        current_resource = @new_resource.dup
-        @provider.current_resource = current_resource
-        @node.automatic_attrs[:platform] = "solaris2"
-        @new_resource.append(false)
-        expect(@provider).to receive(:shell_out_compacted!).with("groupmod", "-U", "all,your,base", "wheel")
-        @provider.modify_group_members
-      end
-
-      platforms.each do |platform, flags|
-        it "should usermod +/- each user when the append option is set on #{platform}" do
-          current_resource = @new_resource.dup
-          current_resource.members(%w{are belong to us})
-          @new_resource.excluded_members(%w{are belong to us})
-          @provider.current_resource = current_resource
-          @node.automatic_attrs[:platform] = platform
-          @new_resource.append(true)
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "+wheel", "all")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "+wheel", "your")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "+wheel", "base")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "-wheel", "are")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "-wheel", "belong")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "-wheel", "to")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "-wheel", "us")
-          @provider.modify_group_members
-        end
-
-      end
-    end
-  end
-
-  describe "when loading the current resource" do
-    before(:each) do
-      allow(File).to receive(:exist?).and_return(false)
-      @provider.action = :create
-      @provider.define_resource_requirements
-    end
-
-    it "should raise an error if the required binary /usr/sbin/usermod doesn't exist" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect(File).to receive(:exist?).with("/usr/sbin/usermod").and_return(false)
-      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-    it "shouldn't raise an error if the required binaries exist" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect { @provider.process_resource_requirements }.not_to raise_error
-    end
-  end
-end

data/spec/unit/provider/group/usermod_spec.rb

@@ -1,112 +0,0 @@
-#
-# Author:: AJ Christensen (<aj@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Group::Usermod do
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::Group.new("wheel")
-    @new_resource.members %w{all your base}
-    @new_resource.excluded_members [ ]
-    @provider = Chef::Provider::Group::Usermod.new(@new_resource, @run_context)
-    allow(@provider).to receive(:run_command)
-  end
-
-  describe "modify_group_members" do
-
-    describe "with an empty members array" do
-      before do
-        @new_resource.append(true)
-        @new_resource.members([])
-      end
-
-      it "should log an appropriate message" do
-        expect(@provider).not_to receive(:shell_out_compacted!)
-        @provider.modify_group_members
-      end
-    end
-
-    describe "with supplied members" do
-      platforms = {
-        "openbsd" => [ "-G" ],
-        "netbsd" => [ "-G" ],
-        "smartos" => [ "-G" ],
-        "omnios" => [ "-G" ],
-      }
-
-      before do
-        @new_resource.members(%w{all your base})
-        allow(File).to receive(:exist?).and_return(true)
-      end
-
-      it "should raise an error when setting the entire group directly" do
-        @provider.action = :modify
-        @provider.define_resource_requirements
-        @provider.load_current_resource
-        @provider.instance_variable_set(:@group_exists, true)
-        expect { @provider.run_action(@provider.process_resource_requirements) }.to raise_error(Chef::Exceptions::Group, "setting group members directly is not supported by #{@provider}, must set append true in group")
-      end
-
-      it "should raise an error when excluded_members are set" do
-        @provider.action = :modify
-        @provider.define_resource_requirements
-        @provider.load_current_resource
-        @provider.instance_variable_set(:@group_exists, true)
-        @new_resource.append(true)
-        @new_resource.excluded_members(["someone"])
-        expect { @provider.run_action(@provider.process_resource_requirements) }.to raise_error(Chef::Exceptions::Group, "excluded_members is not supported by #{@provider}")
-      end
-
-      platforms.each do |platform, flags|
-        it "should usermod each user when the append option is set on #{platform}" do
-          current_resource = @new_resource.dup
-          current_resource.members([ ])
-          @provider.current_resource = current_resource
-          @node.automatic_attrs[:platform] = platform
-          @new_resource.append(true)
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "wheel", "all")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "wheel", "your")
-          expect(@provider).to receive(:shell_out_compacted!).with("usermod", *flags, "wheel", "base")
-          @provider.modify_group_members
-        end
-      end
-    end
-  end
-
-  describe "when loading the current resource" do
-    before(:each) do
-      allow(File).to receive(:exist?).and_return(false)
-      @provider.action = :create
-      @provider.define_resource_requirements
-    end
-
-    it "should raise an error if the required binary /usr/sbin/usermod doesn't exist" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect(File).to receive(:exist?).with("/usr/sbin/usermod").and_return(false)
-      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-    it "shouldn't raise an error if the required binaries exist" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect { @provider.process_resource_requirements }.not_to raise_error
-    end
-  end
-end

data/spec/unit/provider/group/windows_spec.rb

@@ -1,130 +0,0 @@
-#
-# Author:: Doug MacEachern (<dougm@vmware.com>)
-# Copyright:: Copyright 2010-2016, VMware, Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-class Chef
-  class Util
-    class Windows
-      class NetGroup
-      end
-    end
-  end
-end
-
-describe Chef::Provider::Group::Windows do
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::Group.new("staff")
-    @net_group = double("Chef::Util::Windows::NetGroup")
-    allow(Chef::Util::Windows::NetGroup).to receive(:new).and_return(@net_group)
-    @provider = Chef::Provider::Group::Windows.new(@new_resource, @run_context)
-  end
-
-  describe "when creating the group" do
-    before do
-      @current_resource = Chef::Resource::Group.new("staff")
-      @current_resource.members %w{all your base}
-      @provider.current_resource = @current_resource
-    end
-
-    it "should call @net_group.local_add" do
-      expect(@net_group).to receive(:local_set_members).with([])
-      expect(@net_group).to receive(:local_add)
-      @provider.create_group
-    end
-  end
-
-  describe "manage_group" do
-    before do
-      @new_resource.members([ "us" ])
-      @new_resource.comment = "this is group comment"
-      @current_resource = Chef::Resource::Group.new("staff")
-      @current_resource.members %w{all your base}
-      @new_resource.excluded_members %w{all}
-
-      allow(Chef::Util::Windows::NetGroup).to receive(:new).and_return(@net_group)
-      allow(@net_group).to receive(:local_add_members)
-      allow(@net_group).to receive(:local_set_members)
-      allow(@provider).to receive(:lookup_account_name)
-      allow(@net_group).to receive(:local_group_set_info)
-      allow(@provider).to receive(:validate_member!).and_return(true)
-      @provider.current_resource = @current_resource
-    end
-
-    it "should call @net_group.local_set_members" do
-      @new_resource.append(false)
-      expect(@net_group).to receive(:local_set_members).with(@new_resource.members)
-      @provider.manage_group
-    end
-
-    it "should call @net_group.local_add_members" do
-      @new_resource.append(true)
-      expect(@net_group).to receive(:local_add_members).with(@new_resource.members)
-      @provider.manage_group
-    end
-
-    it "when comment is present, should call @net_group.local_group_set_info" do
-      @new_resource.append(true)
-      expect(@net_group).to receive(:local_group_set_info).with(@new_resource.comment)
-      @provider.manage_group
-    end
-
-    it "when comment is not present, should not call @net_group.local_group_set_info" do
-      @new_resource.comment = nil
-      @new_resource.append(true)
-      expect(@net_group).not_to receive(:local_group_set_info).with(@new_resource.comment)
-      @provider.manage_group
-    end
-
-    it "should call @net_group.local_delete_members" do
-      @new_resource.append(true)
-      allow(@provider).to receive(:lookup_account_name).with("all").and_return("all")
-      expect(@net_group).to receive(:local_delete_members).with(@new_resource.excluded_members)
-      @provider.manage_group
-    end
-  end
-
-  describe "remove_group" do
-    before do
-      allow(Chef::Util::Windows::NetGroup).to receive(:new).and_return(@net_group)
-      allow(@provider).to receive(:run_command).and_return(true)
-    end
-
-    it "should call @net_group.local_delete" do
-      expect(@net_group).to receive(:local_delete)
-      @provider.remove_group
-    end
-  end
-end
-
-describe Chef::Provider::Group::Windows, "NetGroup" do
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::Group.new("Creating a new group")
-    @new_resource.group_name "Remote Desktop Users"
-  end
-  it "sets group_name correctly" do
-    expect(Chef::Util::Windows::NetGroup).to receive(:new).with("Remote Desktop Users")
-    Chef::Provider::Group::Windows.new(@new_resource, @run_context)
-  end
-end