chef 18.7.10 → 18.8.46

data/spec/unit/provider/user/pw_spec.rb

@@ -1,235 +0,0 @@
-#
-# Author:: Stephen Haynes (<sh@nomitor.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::User::Pw do
-  before(:each) do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-
-    @new_resource = Chef::Resource::User::PwUser.new("adam")
-    @new_resource.comment   "Adam Jacob"
-    @new_resource.uid       1000
-    @new_resource.gid       1000
-    @new_resource.home      "/home/adam"
-    @new_resource.shell     "/usr/bin/zsh"
-    @new_resource.password  "abracadabra"
-
-    @new_resource.manage_home true
-
-    @current_resource = Chef::Resource::User::PwUser.new("adam")
-    @current_resource.comment  "Adam Jacob"
-    @current_resource.uid      1000
-    @current_resource.gid      1000
-    @current_resource.home     "/home/adam"
-    @current_resource.shell    "/usr/bin/zsh"
-    @current_resource.password "abracadabra"
-
-    @provider = Chef::Provider::User::Pw.new(@new_resource, @run_context)
-    @provider.current_resource = @current_resource
-  end
-
-  describe "setting options to the pw command" do
-    field_list = {
-      "comment" => "-c",
-      "home" => "-d",
-      "gid" => "-g",
-      "uid" => "-u",
-      "shell" => "-s",
-    }
-    field_list.each do |property, option|
-      it "should check for differences in #{property} between the new and current resources" do
-        expect(@current_resource).to receive(property)
-        expect(@new_resource).to receive(property)
-        @provider.set_options
-      end
-
-      it "should set the option for #{property} if the new resources #{property} is not null" do
-        allow(@new_resource).to receive(property).and_return("hola")
-        expect(@provider.set_options).to eql([ @new_resource.username, option, @new_resource.send(property), "-m"])
-      end
-    end
-
-    it "should combine all the possible options" do
-      match_array = [ "adam" ]
-      field_list.sort_by { |a| a[0] }.each do |property, option|
-        allow(@new_resource).to receive(property).and_return("hola")
-        match_array << option
-        match_array << "hola"
-      end
-      match_array << "-m"
-      expect(@provider.set_options).to eql(match_array)
-    end
-  end
-
-  describe "create_user" do
-    before(:each) do
-      allow(@provider).to receive(:shell_out_compacted!).and_return(true)
-      allow(@provider).to receive(:modify_password).and_return(true)
-    end
-
-    it "should run pw useradd with the return of set_options" do
-      expect(@provider).to receive(:shell_out_compacted!).with( "pw", "useradd", "adam", "-m").and_return(true)
-      @provider.create_user
-    end
-
-    it "should modify the password" do
-      expect(@provider).to receive(:modify_password).and_return(true)
-      @provider.create_user
-    end
-  end
-
-  describe "manage_user" do
-    before(:each) do
-      allow(@provider).to receive(:shell_out_compacted!).and_return(true)
-      allow(@provider).to receive(:modify_password).and_return(true)
-    end
-
-    it "should run pw usermod with the return of set_options" do
-      expect(@provider).to receive(:shell_out_compacted!).with( "pw", "usermod", "adam", "-m").and_return(true)
-      @provider.manage_user
-    end
-
-    it "should modify the password" do
-      expect(@provider).to receive(:modify_password).and_return(true)
-      @provider.create_user
-    end
-  end
-
-  describe "remove_user" do
-    it "should run pw userdel with the new resources user name" do
-      @new_resource.manage_home false
-      expect(@provider).to receive(:shell_out_compacted!).with( "pw", "userdel", @new_resource.username).and_return(true)
-      @provider.remove_user
-    end
-
-    it "should run pw userdel with the new resources user name and -r if manage_home is true" do
-      expect(@provider).to receive(:shell_out_compacted!).with( "pw", "userdel", @new_resource.username, "-r").and_return(true)
-      @provider.remove_user
-    end
-  end
-
-  describe "determining if the user is locked" do
-    it "should return true if user is locked" do
-      allow(@current_resource).to receive(:password).and_return("*LOCKED*abracadabra")
-      expect(@provider.check_lock).to eql(true)
-    end
-
-    it "should return false if user is not locked" do
-      allow(@current_resource).to receive(:password).and_return("abracadabra")
-      expect(@provider.check_lock).to eql(false)
-    end
-  end
-
-  describe "when locking the user" do
-    it "should run pw lock with the new resources username" do
-      expect(@provider).to receive(:shell_out_compacted!).with( "pw", "lock", @new_resource.username)
-      @provider.lock_user
-    end
-  end
-
-  describe "when unlocking the user" do
-    it "should run pw unlock with the new resources username" do
-      expect(@provider).to receive(:shell_out_compacted!).with( "pw", "unlock", @new_resource.username)
-      @provider.unlock_user
-    end
-  end
-
-  describe "when modifying the password" do
-    before(:each) do
-      @status = double("Status", exitstatus: 0)
-      allow(@provider).to receive(:shell_out_compacted!).and_return(@status)
-    end
-
-    describe "and the new password has not been specified" do
-      before(:each) do
-        @new_resource.password(nil)
-      end
-
-      it "logs an appropriate message" do
-        @provider.modify_password
-      end
-    end
-
-    describe "and the new password has been specified" do
-      before(:each) do
-        @new_resource.password("abracadabra")
-      end
-
-      it "should check for differences in password between the new and current resources" do
-        expect(@current_resource).to receive(:password)
-        expect(@new_resource).to receive(:password).and_call_original.at_least(:once)
-        @provider.modify_password
-      end
-    end
-
-    describe "and the passwords are identical" do
-      before(:each) do
-        @new_resource.password("abracadabra")
-        allow(@current_resource).to receive(:password).and_return("abracadabra")
-      end
-
-      it "logs an appropriate message" do
-        @provider.modify_password
-      end
-    end
-
-    describe "and the passwords are different" do
-      before(:each) do
-        @new_resource.password("abracadabra")
-        allow(@current_resource).to receive(:password).and_return("sesame")
-      end
-
-      it "should log an appropriate message" do
-        @provider.modify_password
-      end
-
-      it "should run pw usermod with the username and the option -H 0" do
-        expect(@provider).to receive(:shell_out_compacted!).with( "pw usermod adam -H 0", { input: "abracadabra" }).and_return(@status)
-        @provider.modify_password
-      end
-
-      it "should raise an exception if pw usermod fails" do
-        expect(@provider).to receive(:shell_out_compacted!).and_raise(Mixlib::ShellOut::ShellCommandFailed)
-        expect { @provider.modify_password }.to raise_error(Mixlib::ShellOut::ShellCommandFailed)
-      end
-
-      it "should not raise an exception if pw usermod succeeds" do
-        expect { @provider.modify_password }.not_to raise_error
-      end
-    end
-  end
-
-  describe "when loading the current state" do
-    before do
-      @provider.new_resource = Chef::Resource::User::PwUser.new("adam")
-    end
-
-    it "should raise an error if the required binary /usr/sbin/pw doesn't exist" do
-      expect(File).to receive(:exist?).with("/usr/sbin/pw").and_return(false)
-      expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::User)
-    end
-
-    it "shouldn't raise an error if /usr/sbin/pw exists" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect { @provider.load_current_resource }.not_to raise_error
-    end
-  end
-end

data/spec/unit/provider/user/solaris_spec.rb

@@ -1,177 +0,0 @@
-#
-# Author:: Adam Jacob (<adam@chef.io>)
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Author:: Dave Eddy (<dave@daveeddy.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# Copyright:: Copyright 2015-2016, Dave Eddy
-#
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::User::Solaris do
-
-  let(:shellcmdresult) do
-    Struct.new(:stdout, :stderr, :exitstatus)
-  end
-
-  let(:node) do
-    Chef::Node.new.tap do |node|
-      node.automatic["platform"] = "solaris2"
-    end
-  end
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:new_resource) do
-    Chef::Resource::User::SolarisUser.new("adam", @run_context)
-  end
-  let(:current_resource) do
-    Chef::Resource::User::SolarisUser.new("adam", @run_context)
-  end
-
-  subject(:provider) do
-    described_class.new(new_resource, run_context).tap do |p|
-      p.current_resource = current_resource
-      # Prevent the useradd-based provider tests from trying to write /etc/shadow
-      allow(p).to receive(:write_shadow_file)
-    end
-  end
-
-  describe "when we want to set a password" do
-    before(:each) do
-      new_resource.password "hocus-pocus"
-    end
-
-    it "should use its own shadow file writer to set the password" do
-      expect(provider).to receive(:write_shadow_file)
-      allow(provider).to receive(:shell_out_compacted!).and_return(true)
-      provider.manage_user
-    end
-
-    it "should write out a modified version of the password file" do
-      # Let this test run #write_shadow_file
-      allow(provider).to receive(:write_shadow_file).and_call_original
-      password_file = Tempfile.new("shadow")
-      password_file.puts "adam:existingpassword:15441::::::"
-      password_file.close
-      stub_const("Chef::Provider::User::Solaris::PASSWORD_FILE", password_file.path)
-      allow(provider).to receive(:shell_out_compacted!).and_return(true)
-      # may not be able to write to /etc for tests...
-      temp_file = Tempfile.new("shadow")
-      allow(Tempfile).to receive(:new).with("shadow", "/etc").and_return(temp_file)
-      new_resource.password "verysecurepassword"
-      provider.manage_user
-      expect(::File.read(password_file.path)).to match(/adam:verysecurepassword:/)
-      password_file.unlink
-    end
-  end
-
-  describe "#create_user" do
-    context "with a system user" do
-      before { new_resource.system(true) }
-      it "should not pass -r" do
-        expect(provider).to receive(:shell_out_compacted!).with( "useradd", "adam")
-        provider.create_user
-      end
-    end
-
-    context "with manage_home" do
-      before { new_resource.manage_home(true) }
-      it "should not pass -r" do
-        expect(provider).to receive(:shell_out_compacted!).with( "useradd", "-m", "adam")
-        provider.create_user
-      end
-    end
-  end
-
-  describe "when managing user locked status" do
-    let(:user_lock) { "adam:FOO:::::::" }
-    let(:shadow_file_contents) do
-      %W{
-        user1:LK:::::::
-        #{user_lock}
-        user2:NP:::::::
-      }
-    end
-
-    describe "when determining if the user is locked" do
-      before do
-        allow(IO).to receive(:read).and_return(shadow_file_contents.join("\n"))
-      end
-
-      context "when user does not exist" do
-        let(:user_lock) { "other_user:FOO:::::::" }
-
-        it "should raise a sensible error" do
-          expect { provider.check_lock }.to raise_error(Chef::Exceptions::User)
-        end
-      end
-
-      # locked shadow lines
-      [
-        "adam:*LK*:::::::",
-        "adam:*LK*foobar:::::::",
-        "adam:*LK*bahamas10:::::::",
-        "adam:*LK*goonawaLK:::::::",
-        "adam:*LK*LKgir:::::::",
-        "adam:*LK*L....:::::::",
-      ].each do |shadow|
-        context "for user 'adam' with entry '#{shadow}'" do
-          let(:user_lock) { shadow }
-
-          it "should return true" do
-            expect(provider.check_lock).to eql(true)
-          end
-        end
-      end
-
-      # unlocked shadow lines
-      [
-        "adam:NP:::::::",
-        "adam:*NP*:::::::",
-        "adam:foobar:::::::",
-        "adam:bahamas10:::::::",
-        "adam:goonawaLK:::::::",
-        "adam:LKgir:::::::",
-        "adam:L...:::::::",
-      ].each do |shadow|
-        context "for user 'adam' with entry '#{shadow}'" do
-          let(:user_lock) { shadow }
-
-          it "should return false" do
-            expect(provider.check_lock).to eql(false)
-          end
-        end
-      end
-    end
-
-    describe "when locking the user" do
-      it "should run passwd -l with the new resources username" do
-        shell_return = shellcmdresult.new("", "", 0)
-        expect(provider).to receive(:shell_out_compacted!).with("passwd", "-l", "adam").and_return(shell_return)
-        provider.lock_user
-      end
-    end
-
-    describe "when unlocking the user" do
-      it "should run passwd -u with the new resources username" do
-        shell_return = shellcmdresult.new("", "", 0)
-        expect(provider).to receive(:shell_out_compacted!).with("passwd", "-u", "adam").and_return(shell_return)
-        provider.unlock_user
-      end
-    end
-  end
-end

data/spec/unit/provider/user/windows_spec.rb

@@ -1,198 +0,0 @@
-#
-# Author:: Doug MacEachern (<dougm@vmware.com>)
-# Copyright:: Copyright 2010-2016, VMware, Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-class Chef
-  class Util
-    class Windows
-      class NetUser
-      end
-    end
-  end
-end
-
-describe Chef::Provider::User::Windows do
-  let(:logger) { double("Mixlib::Log::Child").as_null_object }
-
-  before(:each) do
-    @node = Chef::Node.new
-    @new_resource = Chef::Resource::User::WindowsUser.new("monkey")
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    allow(@run_context).to receive(:logger).and_return(logger)
-    @current_resource = Chef::Resource::User::WindowsUser.new("monkey")
-
-    @net_user = double("Chef::Util::Windows::NetUser")
-    allow(Chef::Util::Windows::NetUser).to receive(:new).and_return(@net_user)
-
-    @provider = Chef::Provider::User::Windows.new(@new_resource, @run_context)
-    @provider.current_resource = @current_resource
-  end
-
-  it "creates a net_user object with the provided username" do
-    @new_resource.username "not-monkey"
-    expect(Chef::Util::Windows::NetUser).to receive(:new).with("not-monkey")
-    @provider = Chef::Provider::User::Windows.new(@new_resource, @run_context)
-  end
-
-  describe "when comparing the user's current properties to the desired properties" do
-    before do
-      @new_resource.full_name "Adam Jacob"
-      @new_resource.comment   "Some comments"
-      @new_resource.uid       1000
-      @new_resource.gid       1000
-      @new_resource.home      "/home/adam"
-      @new_resource.shell     "/usr/bin/zsh"
-      @new_resource.password  "abracadabra"
-
-      @provider.current_resource = @new_resource.clone
-    end
-
-    describe "and the properties match" do
-      it "doesn't set the comment field to be updated" do
-        expect(@provider.set_options).not_to have_key(:comment)
-      end
-
-      it "doesn't set the home directory to be updated" do
-        expect(@provider.set_options).not_to have_key(:home_dir)
-      end
-
-      it "doesn't set the group id to be updated" do
-        expect(@provider.set_options).not_to have_key(:primary_group_id)
-      end
-
-      it "doesn't set the user id to be updated" do
-        expect(@provider.set_options).not_to have_key(:user_id)
-      end
-
-      it "doesn't set the shell to be updated" do
-        expect(@provider.set_options).not_to have_key(:script_path)
-      end
-
-      it "doesn't set the password to be updated" do
-        expect(@provider.set_options).not_to have_key(:password)
-      end
-
-      it "doesn't set the full_name to be updated" do
-        expect(@provider.set_options).not_to have_key(:full_name)
-      end
-    end
-
-    describe "and the properties do not match" do
-      before do
-        @current_resource = Chef::Resource::User::WindowsUser.new("adam")
-        @current_resource.full_name "Adam Jacob-foo"
-        @current_resource.comment   "some comments"
-        @current_resource.uid       1111
-        @current_resource.gid       1111
-        @current_resource.home      "/home/adam-foo"
-        @current_resource.shell     "/usr/bin/tcsh"
-        @current_resource.password  "foobarbaz"
-        @provider.current_resource = @current_resource
-      end
-
-      it "marks the full_name field to be updated" do
-        expect(@provider.set_options[:full_name]).to eq("Adam Jacob")
-      end
-
-      it "marks the comment field to be updated" do
-        expect(@provider.set_options[:comment]).to eq("Some comments")
-      end
-
-      it "marks the home_dir property to be updated" do
-        expect(@provider.set_options[:home_dir]).to eq("/home/adam")
-      end
-
-      it "ignores the primary_group_id property" do
-        expect(@provider.set_options[:primary_group_id]).to eq(nil)
-      end
-
-      it "marks the user_id property to be updated" do
-        expect(@provider.set_options[:user_id]).to eq(1000)
-      end
-
-      it "marks the script_path property to be updated" do
-        expect(@provider.set_options[:script_path]).to eq("/usr/bin/zsh")
-      end
-
-      it "marks the password property to be updated" do
-        expect(@provider.set_options[:password]).to eq("abracadabra")
-      end
-    end
-  end
-
-  describe "when creating the user" do
-    it "should call @net_user.add with the return of set_options" do
-      allow(@provider).to receive(:set_options).and_return(name: "monkey")
-      expect(@net_user).to receive(:add).with(name: "monkey")
-      @provider.create_user
-    end
-  end
-
-  describe "manage_user" do
-    before(:each) do
-      allow(@provider).to receive(:set_options).and_return(name: "monkey")
-    end
-
-    it "should call @net_user.update with the return of set_options" do
-      expect(@net_user).to receive(:update).with(name: "monkey")
-      @provider.manage_user
-    end
-  end
-
-  describe "when removing the user" do
-    it "should call @net_user.delete" do
-      allow(Chef::ReservedNames::Win32::Security).to receive(:clear_account_rights)
-      expect(@net_user).to receive(:delete)
-      @provider.remove_user
-    end
-  end
-
-  describe "when checking if the user is locked" do
-    before(:each) do
-      @current_resource.password "abracadabra"
-    end
-
-    it "should return true if user is locked" do
-      allow(@net_user).to receive(:check_enabled).and_return(true)
-      expect(@provider.check_lock).to eql(true)
-    end
-
-    it "should return false if user is not locked" do
-      allow(@net_user).to receive(:check_enabled).and_return(false)
-      expect(@provider.check_lock).to eql(false)
-    end
-  end
-
-  describe "locking the user" do
-    it "should call @net_user.disable_account" do
-      allow(@net_user).to receive(:check_enabled).and_return(true)
-      expect(@net_user).to receive(:disable_account)
-      @provider.lock_user
-    end
-  end
-
-  describe "unlocking the user" do
-    it "should call @net_user.enable_account" do
-      allow(@net_user).to receive(:check_enabled).and_return(false)
-      expect(@net_user).to receive(:enable_account)
-      @provider.unlock_user
-    end
-  end
-end