chef 18.7.10 → 18.8.46

data/spec/functional/resource/chocolatey_package_spec.rb

@@ -1,194 +0,0 @@
-#
-# Author:: Matt Wrock (<matt@mattwrock.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-require "spec_helper"
-require "chef/mixin/shell_out"
-
-describe Chef::Resource::ChocolateyPackage, :windows_only, :choco_installed do
-  include Chef::Mixin::ShellOut
-
-  let(:package_name) { "test-A" }
-  let(:package_source) { File.join(CHEF_SPEC_ASSETS, "chocolatey_feed") }
-  let(:package_list) do
-    if provider.query_command == "list"
-      # using result of query_command because that indicates which "search" command to use
-      # which coincides with the package list output
-      proc { shell_out!("choco search -lo #{Array(package_name).join(" ")}").stdout.chomp }
-    else
-      proc { shell_out!("choco list #{Array(package_name).join(" ")}").stdout.chomp }
-    end
-  end
-
-  let(:run_context) do
-    Chef::RunContext.new(Chef::Node.new, {}, Chef::EventDispatch::Dispatcher.new)
-  end
-
-  subject do
-    new_resource = Chef::Resource::ChocolateyPackage.new("test choco package", run_context)
-    new_resource.package_name package_name
-    new_resource.source package_source
-    new_resource
-  end
-
-  let(:provider) do
-    provider = subject.provider_for_action(subject.action)
-    provider
-  end
-
-  # This bit of magic ensures that we pass a mixed-case Path var in the env to chocolatey and not PATH
-  # (both ENV["PATH"] and ENV["Path"] are the same thing in ruby-on-windows, and the first created key
-  # is the one that is actually passed to a subprocess, and choco demands it be Path)
-  #
-  # This is not a no-op.
-  #
-  # I don't know how to tell what state we were in to begin with, so we cannot restore.  Nothing else
-  # seems to care.
-  #
-  before(:all) do
-    ENV["Path"] = ENV.delete("Path")
-  end
-
-  after(:each) do
-    provider.instance_variable_set(:@get_choco_version, nil)
-  end
-
-  context "installing a package" do
-    after { remove_package }
-
-    it "installs the latest version" do
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|2.0.0$/)
-    end
-
-    it "does not install if already installed" do
-      subject.run_action(:install)
-      subject.run_action(:install)
-      expect(subject).not_to be_updated_by_last_action
-    end
-
-    it "installs version given" do
-      subject.version "1.0.0"
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|1.0.0$/)
-    end
-
-    it "installs new version if one is already installed" do
-      subject.version "1.0.0"
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|1.0.0$/)
-
-      subject.version "2.0.0"
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|2.0.0$/)
-    end
-
-    context "installing multiple packages" do
-      let(:package_name) { %w{test-A test-B} }
-
-      it "installs both packages" do
-        subject.run_action(:install)
-        expect(package_list.call).to match(/^test-A|2.0.0\r\ntest-B|1.0.0$/)
-      end
-    end
-
-    it "raises if package is not found" do
-      subject.package_name "blah"
-      expect { subject.run_action(:install) }.to raise_error Chef::Exceptions::Package
-    end
-
-    it "installs with an option as a string" do
-      subject.options "--force --confirm"
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|2.0.0$/)
-    end
-
-    it "installs with multiple options as a string" do
-      subject.options "--force --confirm"
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|2.0.0$/)
-    end
-
-    context "when multiple options passed as string" do
-      before do
-        subject.options "--force --confirm"
-        subject.source nil
-      end
-
-      it "splits a string into an array of options" do
-        expect(provider.send(:cmd_args)).to eq(["--force", "--confirm"])
-      end
-
-      it "calls command_line_to_argv_w_helper method" do
-        expect(provider).to receive(:command_line_to_argv_w_helper).with(subject.options).and_return(["--force", "--confirm"])
-        provider.send(:cmd_args)
-      end
-    end
-
-    context "when multiple options passed as array" do
-      it "Does not call command_line_to_argv_w_helper method" do
-        subject.options [ "--force", "--confirm" ]
-        expect(provider).not_to receive(:command_line_to_argv_w_helper)
-        provider.send(:cmd_args)
-      end
-    end
-
-    it "installs with multiple options as an array" do
-      subject.options [ "--force", "--confirm" ]
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|2.0.0$/)
-    end
-  end
-
-  context "upgrading a package" do
-    after { remove_package }
-
-    it "upgrades to a specific version" do
-      subject.version "1.0.0"
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|1.0.0$/)
-
-      subject.version "1.5.0"
-      subject.run_action(:upgrade)
-      expect(package_list.call).to match(/^#{package_name}|1.5.0$/)
-    end
-
-    it "upgrades to the latest version if no version given" do
-      subject.version "1.0.0"
-      subject.run_action(:install)
-      expect(package_list.call).to match(/^#{package_name}|1.0.0$/)
-
-      subject2 = Chef::Resource::ChocolateyPackage.new("test-A", run_context)
-      subject2.source package_source
-      subject2.run_action(:upgrade)
-      expect(package_list.call).to match(/^#{package_name}|2.0.0$/)
-    end
-  end
-
-  context "removing a package" do
-    it "removes an installed package" do
-      subject.run_action(:install)
-      remove_package
-      expect(package_list.call).to match(/0 packages installed/)
-    end
-  end
-
-  def remove_package
-    pkg_to_remove = Chef::Resource::ChocolateyPackage.new(package_name, run_context)
-    pkg_to_remove.source = package_source
-    pkg_to_remove.run_action(:remove)
-  end
-end

data/spec/functional/resource/cookbook_file_spec.rb

@@ -1,79 +0,0 @@
-#
-# Author:: Tim Hinderliter (<tim@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Resource::CookbookFile do
-  include_context Chef::Resource::File
-
-  let(:file_base) { "cookbook_file_spec" }
-  let(:source) { "java.response" }
-  let(:cookbook_name) { "java" }
-  let(:expected_content) do
-    content = File.binread(File.join(CHEF_SPEC_DATA, "cookbooks", "java", "files", "default", "java.response"))
-    content.force_encoding(Encoding::BINARY) if content.respond_to?(:force_encoding)
-    content
-  end
-
-  let(:default_mode) { (0666 & ~File.umask).to_s(8) }
-
-  it_behaves_like "a securable resource with reporting"
-
-  def create_resource
-    # set up cookbook collection for this run to use, based on our
-    # spec data.
-    cookbook_repo = File.expand_path(File.join(CHEF_SPEC_DATA, "cookbooks"))
-    Chef::Cookbook::FileVendor.fetch_from_disk(cookbook_repo)
-    loader = Chef::CookbookLoader.new(cookbook_repo)
-    loader.load_cookbooks
-    cookbook_collection = Chef::CookbookCollection.new(loader)
-
-    node = Chef::Node.new
-    events = Chef::EventDispatch::Dispatcher.new
-    run_context = Chef::RunContext.new(node, cookbook_collection, events)
-    resource = Chef::Resource::CookbookFile.new(path, run_context)
-    resource.cookbook(cookbook_name)
-    resource.source(source)
-
-    resource
-  end
-
-  let(:resource) do
-    create_resource
-  end
-
-  it_behaves_like "a file resource", :not_supported_on_windows_11
-
-  # These examples cover CHEF-3467 where unexpected and incorrect
-  # permissions can result on Windows because CookbookFile's
-  # implementation
-  # stages files in temp.
-  context "targets a file outside of the system temp directory" do
-    let(:windows_non_temp_dir) { File.join(ENV["systemdrive"], make_tmpname(file_base, "non-temp")) }
-    let(:path) { File.join(windows_non_temp_dir, make_tmpname(file_base)) }
-
-    before do
-      FileUtils.mkdir_p(windows_non_temp_dir) if ChefUtils.windows?
-    end
-
-    after do
-      FileUtils.rm_r(windows_non_temp_dir) if ChefUtils.windows? && File.exist?(windows_non_temp_dir)
-    end
-
-  end
-end

data/spec/functional/resource/cron_spec.rb

@@ -1,179 +0,0 @@
-#
-# Author:: Kaustubh Deorukhkar (<kaustubh@clogeny.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-require "chef/mixin/shell_out"
-
-describe Chef::Resource::Cron, :requires_root, :unix_only, :not_macos_gte_11 do
-
-  include Chef::Mixin::ShellOut
-
-  # Platform specific validation routines.
-  def cron_should_exists(cron_name, command)
-    case ohai[:platform]
-    when "aix", "solaris2", "omnios"
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{cron_name}\"").exitstatus).to eq(0)
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{cron_name}\"").stdout.lines.to_a.size).to eq(1)
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{command}\"").exitstatus).to eq(0)
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{command}\"").stdout.lines.to_a.size).to eq(1)
-    else
-      expect(shell_out("crontab -l -u #{new_resource.user} | grep \"#{cron_name}\"").exitstatus).to eq(0)
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{cron_name}\"").stdout.lines.to_a.size).to eq(0)
-      expect(shell_out("crontab -l -u #{new_resource.user} | grep \"#{command}\"").exitstatus).to eq(0)
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{command}\"").stdout.lines.to_a.size).to eq(0)
-    end
-  end
-
-  def cron_should_not_exists(cron_name)
-    case ohai[:platform]
-    when "aix", "solaris2", "omnios"
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{cron_name}\"").exitstatus).to eq(1)
-      expect(shell_out("crontab -l #{new_resource.user} | grep \"#{new_resource.command}\"").stdout.lines.to_a.size).to eq(0)
-    else
-      expect(shell_out("crontab -l -u #{new_resource.user} | grep \"#{cron_name}\"").exitstatus).to eq(1)
-      expect(shell_out("crontab -l -u #{new_resource.user} | grep \"#{new_resource.command}\"").stdout.lines.to_a.size).to eq(0)
-    end
-  end
-
-  # Actual tests
-
-  let(:run_context) do
-    node = Chef::Node.new
-    node.default[:platform] = ohai[:platform]
-    node.default[:platform_version] = ohai[:platform_version]
-    node.default[:os] = ohai[:os]
-    events = Chef::EventDispatch::Dispatcher.new
-    Chef::RunContext.new(node, {}, events)
-  end
-
-  let(:new_resource) do
-    new_resource = Chef::Resource::Cron.new("Chef functional test cron", run_context)
-    new_resource.user "root"
-    new_resource.minute "0"
-    new_resource.command "/bin/true"
-    new_resource
-  end
-
-  let(:provider) do
-    provider = new_resource.provider_for_action(new_resource.action)
-    provider
-  end
-
-  describe "create action" do
-    after do
-      new_resource.run_action(:delete)
-    end
-
-    it "should create a crontab entry" do
-      new_resource.run_action(:create)
-      cron_should_exists(new_resource.name, new_resource.command)
-    end
-
-    it "should create exactly one crontab entry" do
-      5.times { new_resource.run_action(:create) }
-      cron_should_exists(new_resource.name, new_resource.command)
-    end
-
-    # Test cron for day of week
-    weekdays = { Mon: 1, tuesday: 2, '3': 3, 'thursday': 4, 'Fri': 5, 6 => 6 }
-    weekdays.each do |key, value|
-      it "should create crontab entry and set #{value} for #{key} as weekday" do
-        new_resource.weekday key
-        expect { new_resource.run_action(:create) }.not_to raise_error
-        cron_should_exists(new_resource.name, new_resource.command)
-      end
-    end
-  end
-
-  describe "delete action" do
-    before do
-      new_resource.run_action(:create)
-    end
-
-    it "should delete a crontab entry" do
-      # Note that test cron is created by previous test
-      new_resource.run_action(:delete)
-
-      cron_should_not_exists(new_resource.name)
-    end
-  end
-
-  exclude_solaris = %w{solaris solaris2 omnios}.include?(ohai[:platform])
-  describe "create action with various attributes", external: exclude_solaris do
-    def create_and_validate_with_property(resource, attribute, value)
-      if ohai[:platform] == "aix"
-        expect { resource.run_action(:create) }.to raise_error(Chef::Exceptions::Cron, /Aix cron entry does not support environment variables. Please set them in script and use script in cron./)
-      else
-        resource.run_action(:create)
-        # Verify if the cron is created successfully
-        cron_attribute_should_exists(resource.name, attribute, value)
-      end
-    end
-
-    def cron_attribute_should_exists(cron_name, attribute, value)
-      return if %w{aix solaris}.include?(ohai[:platform])
-
-      # Test if the attribute exists on newly created cron
-      cron_should_exists(cron_name, "")
-      expect(shell_out("crontab -l -u #{new_resource.user} | grep '#{attribute.upcase}=\"#{value}\"'").exitstatus).to eq(0)
-    end
-
-    after do
-      new_resource.run_action(:delete)
-    end
-
-    it "should create a crontab entry for mailto attribute" do
-      new_resource.mailto "cheftest@example.com"
-      create_and_validate_with_property(new_resource, "mailto", "cheftest@example.com")
-    end
-
-    it "should create a crontab entry for path attribute" do
-      new_resource.path "/usr/local/bin"
-      create_and_validate_with_property(new_resource, "path", "/usr/local/bin")
-    end
-
-    it "should create a crontab entry for shell attribute" do
-      new_resource.shell "/bin/bash"
-      create_and_validate_with_property(new_resource, "shell", "/bin/bash")
-    end
-
-    it "should create a crontab entry for home attribute" do
-      new_resource.home "/home/opscode"
-      create_and_validate_with_property(new_resource, "home", "/home/opscode")
-    end
-
-    %i{ home mailto path shell }.each do |attr|
-      it "supports an empty string for #{attr} attribute" do
-        new_resource.send(attr, "")
-        create_and_validate_with_property(new_resource, attr.to_s, "")
-      end
-    end
-  end
-
-  describe "negative tests for create action" do
-    after do
-      new_resource.run_action(:delete)
-    end
-
-    it "should not create cron with invalid user" do
-      new_resource.user "1-really-really-invalid-user-name"
-      expect { new_resource.run_action(:create) }.to raise_error(Chef::Exceptions::Cron)
-      cron_should_not_exists(new_resource.name)
-    end
-  end
-end

data/spec/functional/resource/directory_spec.rb

@@ -1,43 +0,0 @@
-#
-# Author:: Seth Chisamore (<schisamo@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Resource::Directory do
-  include_context Chef::Resource::Directory
-
-  let(:directory_base) { "directory_spec" }
-
-  let(:default_mode) { (0777 & ~File.umask).to_s(8) }
-
-  def create_resource
-    events = Chef::EventDispatch::Dispatcher.new
-    node = Chef::Node.new
-    run_context = Chef::RunContext.new(node, {}, events)
-    Chef::Resource::Directory.new(path, run_context)
-  end
-
-  let(:resource) do
-    create_resource
-  end
-
-  it_behaves_like "a directory resource"
-
-  it_behaves_like "a securable resource with reporting"
-
-end