chef 18.7.10 → 18.8.46

data/spec/unit/provider/group_spec.rb

@@ -1,285 +0,0 @@
-#
-# Author:: AJ Christensen (<aj@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::User do
-
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::Group.new("wheel", @run_context)
-    @new_resource.gid 500
-    @new_resource.members "aj"
-
-    @provider = Chef::Provider::Group.new(@new_resource, @run_context)
-
-    @current_resource = Chef::Resource::Group.new("aj", @run_context)
-    @current_resource.gid 500
-    @current_resource.members "aj"
-
-    @provider.current_resource = @current_resource
-
-    @pw_group = double("Struct::Group",
-      name: "wheel",
-      gid: 20,
-      mem: %w{root aj})
-    allow(Etc).to receive(:getgrnam).with("wheel").and_return(@pw_group)
-  end
-
-  it "assumes the group exists by default" do
-    expect(@provider.group_exists).to be_truthy
-  end
-
-  describe "when establishing the current state of the group" do
-
-    it "sets the group name of the current resource to the group name of the new resource" do
-      @provider.load_current_resource
-      expect(@provider.current_resource.group_name).to eq("wheel")
-    end
-
-    it "does not modify the desired gid if set" do
-      @provider.load_current_resource
-      expect(@new_resource.gid).to eq(500)
-    end
-
-    it "sets the desired gid to the current gid if none is set" do
-      @new_resource.instance_variable_set(:@gid, nil)
-      @provider.load_current_resource
-      expect(@new_resource.gid).to eq(20)
-    end
-
-    it "looks up the group in /etc/group with getgrnam" do
-      expect(Etc).to receive(:getgrnam).with(@new_resource.group_name).and_return(@pw_group)
-      @provider.load_current_resource
-      expect(@provider.current_resource.gid).to eq(20)
-      expect(@provider.current_resource.members).to eq(%w{root aj})
-    end
-
-    it "should flip the value of exists if it cannot be found in /etc/group" do
-      allow(Etc).to receive(:getgrnam).and_raise(ArgumentError)
-      @provider.load_current_resource
-      expect(@provider.group_exists).to be_falsey
-    end
-
-    it "should return the current resource" do
-      expect(@provider.load_current_resource).to equal(@provider.current_resource)
-    end
-  end
-
-  describe "when determining if the system is already in the target state" do
-    %i{gid members}.each do |property|
-      it "should return true if #{property} doesn't match" do
-        allow(@current_resource).to receive(property).and_return("looooooooooooooooooool")
-        expect(@provider.compare_group).to be_truthy
-      end
-    end
-
-    it "should return false if gid and members are equal" do
-      expect(@provider.compare_group).to be_falsey
-    end
-
-    it "should coerce an integer to a string for comparison" do
-      allow(@current_resource).to receive(:gid).and_return("500")
-      expect(@provider.compare_group).to be_falsey
-    end
-
-    it "should return false if append is true and the group member(s) already exists" do
-      @current_resource.members << "extra_user"
-      @new_resource.append(true)
-      expect(@provider.compare_group).to be_falsey
-    end
-
-    it "should return true if append is true and the group member(s) do not already exist" do
-      @new_resource.members << "extra_user"
-      @new_resource.append(true)
-      expect(@provider.compare_group).to be_truthy
-    end
-
-    it "should return false if append is true and excluded_members include a non existing member" do
-      @new_resource.excluded_members << "extra_user"
-      @new_resource.append(true)
-      expect(@provider.compare_group).to be_falsey
-    end
-
-    it "should return true if the append is true and excluded_members include an existing user" do
-      @new_resource.excluded_members += @new_resource.members
-      @new_resource.members.clear
-      @new_resource.append(true)
-      expect(@provider.compare_group).to be_truthy
-    end
-
-  end
-
-  describe "when creating a group" do
-    it "should call create_group if the group does not exist" do
-      @provider.group_exists = false
-      expect(@provider).to receive(:create_group).and_return(true)
-      @provider.run_action(:create)
-    end
-
-    it "should set the new_resources updated flag when it creates the group" do
-      @provider.group_exists = false
-      allow(@provider).to receive(:create_group)
-      @provider.run_action(:create)
-      expect(@provider.new_resource).to be_updated
-    end
-
-    it "should check to see if the group has mismatched properties if the group exists" do
-      @provider.group_exists = true
-      allow(@provider).to receive(:compare_group).and_return(false)
-      allow(@provider).to receive(:change_desc).and_return([ ])
-      @provider.run_action(:create)
-      expect(@provider.new_resource).not_to be_updated
-    end
-
-    it "should call manage_group if the group exists and has mismatched properties" do
-      @provider.group_exists = true
-      allow(@provider).to receive(:compare_group).and_return(true)
-      allow(@provider).to receive(:change_desc).and_return([ ])
-      expect(@provider).to receive(:manage_group).and_return(true)
-      @provider.run_action(:create)
-    end
-
-    it "should set the new_resources updated flag when it creates the group if we call manage_group" do
-      @provider.group_exists = true
-      allow(@provider).to receive(:compare_group).and_return(true)
-      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
-      allow(@provider).to receive(:manage_group).and_return(true)
-      @provider.run_action(:create)
-      expect(@new_resource).to be_updated
-    end
-  end
-
-  describe "when removing a group" do
-
-    it "should not call remove_group if the group does not exist" do
-      @provider.group_exists = false
-      expect(@provider).not_to receive(:remove_group)
-      @provider.run_action(:remove)
-      expect(@provider.new_resource).not_to be_updated
-    end
-
-    it "should call remove_group if the group exists" do
-      @provider.group_exists = true
-      expect(@provider).to receive(:remove_group)
-      @provider.run_action(:remove)
-      expect(@provider.new_resource).to be_updated
-    end
-  end
-
-  describe "when updating a group" do
-    before(:each) do
-      @provider.group_exists = true
-      allow(@provider).to receive(:manage_group).and_return(true)
-    end
-
-    it "should run manage_group if the group exists and has mismatched properties" do
-      expect(@provider).to receive(:compare_group).and_return(true)
-      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
-      expect(@provider).to receive(:manage_group).and_return(true)
-      @provider.run_action(:manage)
-    end
-
-    it "should set the new resources updated flag to true if manage_group is called" do
-      allow(@provider).to receive(:compare_group).and_return(true)
-      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
-      allow(@provider).to receive(:manage_group).and_return(true)
-      @provider.run_action(:manage)
-      expect(@new_resource).to be_updated
-    end
-
-    it "should not run manage_group if the group does not exist" do
-      @provider.group_exists = false
-      expect(@provider).not_to receive(:manage_group)
-      @provider.run_action(:manage)
-    end
-
-    it "should not run manage_group if the group exists but has no differing properties" do
-      expect(@provider).to receive(:compare_group).and_return(false)
-      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
-      expect(@provider).not_to receive(:manage_group)
-      @provider.run_action(:manage)
-    end
-  end
-
-  describe "when modifying the group" do
-    before(:each) do
-      @provider.group_exists = true
-      allow(@provider).to receive(:manage_group).and_return(true)
-    end
-
-    it "should run manage_group if the group exists and has mismatched properties" do
-      expect(@provider).to receive(:compare_group).and_return(true)
-      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
-      expect(@provider).to receive(:manage_group).and_return(true)
-      @provider.run_action(:modify)
-    end
-
-    it "should set the new resources updated flag to true if manage_group is called" do
-      allow(@provider).to receive(:compare_group).and_return(true)
-      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
-      allow(@provider).to receive(:manage_group).and_return(true)
-      @provider.run_action(:modify)
-      expect(@new_resource).to be_updated
-    end
-
-    it "should not run manage_group if the group exists but has no differing properties" do
-      expect(@provider).to receive(:compare_group).and_return(false)
-      allow(@provider).to receive(:change_desc).and_return(["Some changes are going to be done."])
-      expect(@provider).not_to receive(:manage_group)
-      @provider.run_action(:modify)
-    end
-
-    it "should raise a Chef::Exceptions::Group if the group doesn't exist" do
-      @provider.group_exists = false
-      expect { @provider.run_action(:modify) }.to raise_error(Chef::Exceptions::Group)
-    end
-  end
-
-  describe "when determining the reason for a change" do
-    it "should report which group members are missing if members are missing and appending to the group" do
-      @new_resource.members << "user1"
-      @new_resource.members << "user2"
-      allow(@new_resource).to receive(:append).and_return true
-      expect(@provider.compare_group).to be_truthy
-      expect(@provider.change_desc).to eq([ "add missing member(s): user1, user2" ])
-    end
-
-    it "should report that the group members will be overwritten if not appending" do
-      @new_resource.members << "user1"
-      allow(@new_resource).to receive(:append).and_return false
-      expect(@provider.compare_group).to be_truthy
-      expect(@provider.change_desc).to eq([ "replace group members with new list of members: aj, user1" ])
-    end
-
-    it "should report the gid will be changed when it does not match" do
-      allow(@current_resource).to receive(:gid).and_return("BADF00D")
-      expect(@provider.compare_group).to be_truthy
-      expect(@provider.change_desc).to eq([ "change gid #{@current_resource.gid} to #{@new_resource.gid}" ])
-
-    end
-
-    it "should report no change reason when no change is required" do
-      expect(@provider.compare_group).to be_falsey
-      expect(@provider.change_desc).to eq([ ])
-    end
-  end
-
-end

data/spec/unit/provider/http_request_spec.rb

@@ -1,147 +0,0 @@
-#
-# Author:: Adam Jacob (<adam@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::HttpRequest do
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:new_resource) do
-    Chef::Resource::HttpRequest.new("adam").tap do |new_resource|
-      new_resource.name "adam"
-      new_resource.url "http://www.opscode.com/"
-      new_resource.message "is cool"
-    end
-  end
-
-  let(:provider) { Chef::Provider::HttpRequest.new(new_resource, run_context) }
-
-  describe "when making REST calls" do
-    let(:http) do
-      provider.http = double("Chef::ServerAPI")
-    end
-
-    describe "action_get" do
-
-      it "should inflate a message block at runtime" do
-        new_resource.message { "return" }
-        expect(http).to receive(:get).with("http://www.opscode.com/", {})
-        provider.run_action(:get)
-        expect(new_resource).to be_updated
-      end
-
-      it "should run a GET request" do
-        expect(http).to receive(:get).with("http://www.opscode.com/", {})
-        provider.run_action(:get)
-        expect(new_resource).to be_updated
-      end
-    end
-
-    describe "action_put" do
-      it "should run a PUT request with the message as the payload" do
-        expect(http).to receive(:put).with("http://www.opscode.com/", new_resource.message, {})
-        provider.run_action(:put)
-        expect(new_resource).to be_updated
-      end
-
-      it "should inflate a message block at runtime" do
-        new_resource.message(lambda { "return" })
-        expect(http).to receive(:put).with("http://www.opscode.com/", "return", {})
-        provider.run_action(:put)
-        expect(new_resource).to be_updated
-      end
-    end
-
-    describe "action_post" do
-      it "should run a PUT request with the message as the payload" do
-        expect(http).to receive(:post).with("http://www.opscode.com/", new_resource.message, {})
-        provider.run_action(:post)
-        expect(new_resource).to be_updated
-      end
-
-      it "should inflate a message block at runtime" do
-        new_resource.message { "return" }
-        expect(http).to receive(:post).with("http://www.opscode.com/", "return", {})
-        provider.run_action(:post)
-        expect(new_resource).to be_updated
-      end
-    end
-
-    describe "action_delete" do
-      it "should run a DELETE request" do
-        expect(http).to receive(:delete).with("http://www.opscode.com/", {})
-        provider.run_action(:delete)
-        expect(new_resource).to be_updated
-      end
-    end
-
-    # CHEF-4762: we expect a nil return value for a "200 Success" response
-    # and false for a "304 Not Modified" response
-    describe "action_head" do
-      before do
-        provider.http = http
-      end
-
-      it "should inflate a message block at runtime" do
-        new_resource.message { "return" }
-        expect(http).to receive(:head).with("http://www.opscode.com/", {}).and_return(nil)
-        provider.run_action(:head)
-        expect(new_resource).to be_updated
-      end
-
-      it "should run a HEAD request" do
-        expect(http).to receive(:head).with("http://www.opscode.com/", {}).and_return(nil)
-        provider.run_action(:head)
-        expect(new_resource).to be_updated
-      end
-
-      it "should update a HEAD request with empty string response body (CHEF-4762)" do
-        expect(http).to receive(:head).with("http://www.opscode.com/", {}).and_return("")
-        provider.run_action(:head)
-        expect(new_resource).to be_updated
-      end
-
-      it "should update a HEAD request with nil response body (CHEF-4762)" do
-        expect(http).to receive(:head).with("http://www.opscode.com/", {}).and_return(nil)
-        provider.run_action(:head)
-        expect(new_resource).to be_updated
-      end
-
-      it "should not update a HEAD request if a not modified response (CHEF-4762)" do
-        if_modified_since = File.mtime(__FILE__).httpdate
-        new_resource.headers "If-Modified-Since" => if_modified_since
-        expect(http).to receive(:head).with("http://www.opscode.com/", { "If-Modified-Since" => if_modified_since }).and_return(false)
-        provider.run_action(:head)
-        expect(new_resource).not_to be_updated
-      end
-
-      it "should run a HEAD request with If-Modified-Since header" do
-        new_resource.headers "If-Modified-Since" => File.mtime(__FILE__).httpdate
-        expect(http).to receive(:head).with("http://www.opscode.com/", new_resource.headers)
-        provider.run_action(:head)
-      end
-
-      it "doesn't call converge_by if HEAD does not return modified" do
-        expect(http).to receive(:head).and_return(false)
-        expect(provider).not_to receive(:converge_by)
-        provider.run_action(:head)
-      end
-    end
-  end
-end

data/spec/unit/provider/ifconfig/aix_spec.rb

@@ -1,180 +0,0 @@
-#
-# Author:: Kaustubh Deorukhkar (<kaustubh@clogeny.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-require "chef/exceptions"
-
-describe Chef::Provider::Ifconfig::Aix do
-
-  before(:all) do
-    @ifconfig_output = <<~IFCONFIG
-      en1: flags=1e080863,480<UP,BROADCAST,NOTRAILERS,RUNNING,SIMPLEX,MULTICAST,GROUPRT,64BIT,CHECKSUM_OFFLOAD(ACTIVE),CHAIN>
-              inet 10.153.11.59 netmask 0xffff0000 broadcast 10.153.255.255
-               tcp_sendspace 262144 tcp_recvspace 262144 rfc1323 1
-      en0: flags=1e080863,480<UP,BROADCAST,NOTRAILERS,RUNNING,SIMPLEX,MULTICAST,GROUPRT,64BIT,CHECKSUM_OFFLOAD(ACTIVE),CHAIN> metric 1
-              inet 172.29.174.58 netmask 0xffffc000 broadcast 172.29.191.255
-               tcp_sendspace 262144 tcp_recvspace 262144 rfc1323 1
-      lo0: flags=e08084b,c0<UP,BROADCAST,LOOPBACK,RUNNING,SIMPLEX,MULTICAST,GROUPRT,64BIT,LARGESEND,CHAIN>
-              inet 127.0.0.1 netmask 0xff000000 broadcast 127.255.255.255
-              inet6 ::1%1/0
-    IFCONFIG
-  end
-
-  before(:each) do
-    @node = Chef::Node.new
-    @cookbook_collection = Chef::CookbookCollection.new([])
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, @cookbook_collection, @events)
-
-    @new_resource = Chef::Resource::Ifconfig.new("10.0.0.1", @run_context)
-
-    @provider = Chef::Provider::Ifconfig::Aix.new(@new_resource, @run_context)
-  end
-
-  describe "#load_current_resource" do
-    before do
-      @status = double(stdout: @ifconfig_output, exitstatus: 0)
-      allow(@provider).to receive(:shell_out_compacted).and_return(@status)
-      @new_resource.device "en0"
-    end
-
-    it "should load given interface with properties." do
-      current_resource = @provider.load_current_resource
-      expect(current_resource.inet_addr).to eq("172.29.174.58")
-      expect(current_resource.target).to eq(@new_resource.target)
-      expect(current_resource.mask).to eq("255.255.192.0")
-      expect(current_resource.bcast).to eq("172.29.191.255")
-      expect(current_resource.metric).to eq("1")
-    end
-  end
-
-  describe "#action_add" do
-
-    it "should add an interface if it does not exist" do
-      @new_resource.device "en10"
-      allow(@provider).to receive(:load_current_resource) do
-        @provider.instance_variable_set(:@status, double("Status", exitstatus: 0))
-        @provider.instance_variable_set(:@current_resource, Chef::Resource::Ifconfig.new("10.0.0.1", @run_context))
-      end
-      command = "chdev -l #{@new_resource.device} -a netaddr=#{@new_resource.name}"
-      expect(@provider).to receive(:shell_out_compacted!).with(*command.split(" "))
-
-      @provider.run_action(:add)
-      expect(@new_resource).to be_updated
-    end
-
-    it "should raise exception if metric property is set" do
-      @new_resource.device "en0"
-      @new_resource.metric "1"
-      allow(@provider).to receive(:load_current_resource) do
-        @provider.instance_variable_set(:@status, double("Status", exitstatus: 0))
-        @provider.instance_variable_set(:@current_resource, Chef::Resource::Ifconfig.new("10.0.0.1", @run_context))
-      end
-
-      expect { @provider.run_action(:add) }.to raise_error(Chef::Exceptions::Ifconfig, "interface metric property cannot be set for :add action")
-    end
-  end
-
-  describe "#action_enable" do
-    it "should enable an interface if it does not exist" do
-      @new_resource.device "en10"
-      allow(@provider).to receive(:load_current_resource) do
-        @provider.instance_variable_set(:@status, double("Status", exitstatus: 0))
-        @provider.instance_variable_set(:@current_resource, Chef::Resource::Ifconfig.new("10.0.0.1", @run_context))
-      end
-      command = "ifconfig #{@new_resource.device} #{@new_resource.name}"
-      expect(@provider).to receive(:shell_out_compacted!).with(*command.split(" "))
-
-      @provider.run_action(:enable)
-      expect(@new_resource).to be_updated
-    end
-  end
-
-  describe "#action_disable" do
-
-    it "should not disable an interface if it does not exist" do
-      @new_resource.device "en10"
-      allow(@provider).to receive(:load_current_resource) do
-        @provider.instance_variable_set(:@status, double("Status", exitstatus: 0))
-        @provider.instance_variable_set(:@current_resource, Chef::Resource::Ifconfig.new("10.0.0.1", @run_context))
-      end
-
-      expect(@provider).not_to receive(:shell_out_compacted!)
-
-      @provider.run_action(:disable)
-      expect(@new_resource).not_to be_updated
-    end
-
-    context "interface exists" do
-      before do
-        @new_resource.device "en10"
-        allow(@provider).to receive(:load_current_resource) do
-          @provider.instance_variable_set(:@status, double("Status", exitstatus: 0))
-          current_resource = Chef::Resource::Ifconfig.new("10.0.0.1", @run_context)
-          current_resource.device @new_resource.device
-          @provider.instance_variable_set(:@current_resource, current_resource)
-        end
-      end
-
-      it "should disable an interface if it exists" do
-        command = "ifconfig #{@new_resource.device} down"
-        expect(@provider).to receive(:shell_out_compacted!).with(*command.split(" "))
-
-        @provider.run_action(:disable)
-        expect(@new_resource).to be_updated
-      end
-
-    end
-  end
-
-  describe "#action_delete" do
-
-    it "should not delete an interface if it does not exist" do
-      @new_resource.device "en10"
-      allow(@provider).to receive(:load_current_resource) do
-        @provider.instance_variable_set(:@status, double("Status", exitstatus: 0))
-        @provider.instance_variable_set(:@current_resource, Chef::Resource::Ifconfig.new("10.0.0.1", @run_context))
-      end
-
-      expect(@provider).not_to receive(:shell_out_compacted!)
-
-      @provider.run_action(:delete)
-      expect(@new_resource).not_to be_updated
-    end
-
-    context "interface exists" do
-      before do
-        @new_resource.device "en10"
-        allow(@provider).to receive(:load_current_resource) do
-          @provider.instance_variable_set(:@status, double("Status", exitstatus: 0))
-          current_resource = Chef::Resource::Ifconfig.new("10.0.0.1", @run_context)
-          current_resource.device @new_resource.device
-          @provider.instance_variable_set(:@current_resource, current_resource)
-        end
-      end
-
-      it "should delete an interface if it exists" do
-        command = "chdev -l #{@new_resource.device} -a state=down"
-        expect(@provider).to receive(:shell_out_compacted!).with(*command.split(" "))
-
-        @provider.run_action(:delete)
-        expect(@new_resource).to be_updated
-      end
-    end
-  end
-end