chef 18.7.10 → 18.8.46

data/spec/unit/provider/group/dscl_spec.rb

@@ -1,339 +0,0 @@
-#
-# Author:: Dreamcat4 (<dreamcat4@gmail.com>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Group::Dscl do
-  let(:logger) { double("Mixlib::Log::Child").as_null_object }
-
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    allow(@run_context).to receive(:logger).and_return(logger)
-    @new_resource = Chef::Resource::Group.new("aj")
-    @current_resource = Chef::Resource::Group.new("aj")
-    @provider = Chef::Provider::Group::Dscl.new(@new_resource, @run_context)
-    @provider.current_resource = @current_resource
-
-    @status = double(stdout: "\n", stderr: "", exitstatus: 0)
-    allow(@provider).to receive(:shell_out_compacted).and_return(@status)
-  end
-
-  it "should run shell_out with the supplied array of arguments appended to the dscl command" do
-    expect(@provider).to receive(:shell_out_compacted).with("dscl", ".", "-cmd", "/Path", "arg1", "arg2")
-    @provider.dscl("cmd", "/Path", "arg1", "arg2")
-  end
-
-  it "should return an array of four elements - cmd, status, stdout, stderr" do
-    dscl_retval = @provider.dscl("cmd /Path args")
-    expect(dscl_retval).to be_a_kind_of(Array)
-    expect(dscl_retval).to eq(["dscl . -cmd /Path args", @status, "\n", ""])
-  end
-
-  describe "safe_dscl" do
-    before do
-      @provider = Chef::Provider::Group::Dscl.new(@new_resource, @run_context)
-      allow(@provider).to receive(:dscl).and_return(["cmd", @status, "stdout", "stderr"])
-    end
-
-    it "should run dscl with the supplied cmd /Path args" do
-      expect(@provider).to receive(:dscl).with(*"cmd /Path args".split(" "))
-      @provider.safe_dscl(*"cmd /Path args".split(" "))
-    end
-
-    describe "with the dscl command returning a non zero exit status for a delete" do
-      before do
-        @status = double("Process::Status", exitstatus: 1)
-        allow(@provider).to receive(:dscl).and_return(["cmd", @status, "stdout", "stderr"])
-      end
-
-      it "should return an empty string of standard output for a delete" do
-        safe_dscl_retval = @provider.safe_dscl(*"delete /Path args".split(" "))
-        expect(safe_dscl_retval).to be_a_kind_of(String)
-        expect(safe_dscl_retval).to eq("")
-      end
-
-      it "should raise an exception for any other command" do
-        expect { @provider.safe_dscl(*"cmd /Path arguments".split(" ")) }.to raise_error(Chef::Exceptions::Group)
-      end
-    end
-
-    describe "with the dscl command returning no such key" do
-      before do
-        allow(@provider).to receive(:dscl).and_return(["cmd", @status, "No such key: ", "stderr"])
-      end
-
-      it "should raise an exception" do
-        expect { @provider.safe_dscl(*"cmd /Path arguments".split(" ")) }.to raise_error(Chef::Exceptions::Group)
-      end
-    end
-
-    describe "with the dscl command returning a zero exit status" do
-      it "should return the third array element, the string of standard output" do
-        safe_dscl_retval = @provider.safe_dscl(*"cmd /Path args".split(" "))
-        expect(safe_dscl_retval).to be_a_kind_of(String)
-        expect(safe_dscl_retval).to eq("stdout")
-      end
-    end
-  end
-
-  describe "get_free_gid" do
-    before do
-      @provider = Chef::Provider::Group::Dscl.new(@new_resource, @run_context)
-      allow(@provider).to receive(:safe_dscl).and_return("\naj      200\njt      201\n")
-    end
-
-    it "should run safe_dscl with list /Groups gid" do
-      expect(@provider).to receive(:safe_dscl).with(*"list /Groups gid".split(" "))
-      @provider.get_free_gid
-    end
-
-    it "should return the first unused gid number on or above 200" do
-      expect(@provider.get_free_gid).to equal(202)
-    end
-
-    it "should raise an exception when the search limit is exhausted" do
-      search_limit = 1
-      expect { @provider.get_free_gid(search_limit) }.to raise_error(RuntimeError)
-    end
-  end
-
-  describe "gid_used?" do
-    before do
-      allow(@provider).to receive(:safe_dscl).and_return(<<-EOS
-        someprogram		somethingElse:gid = (
-            500
-        )
-      EOS
-                                                        )
-    end
-
-    it "should run safe_dscl with search /Groups gid" do
-      expect(@provider).to receive(:safe_dscl).with(*"search /Groups PrimaryGroupID 500".split(" "))
-      @provider.gid_used?(500)
-    end
-
-    it "should return true for a used gid number" do
-      expect(@provider.gid_used?(500)).to be_truthy
-    end
-
-    it "should return false for an unused gid number" do
-      expect(@provider.gid_used?(0)).to be_falsey
-      expect(@provider.gid_used?(50)).to be_falsey
-      expect(@provider.gid_used?(5000)).to be_falsey
-      expect(@provider.gid_used?(1500)).to be_falsey
-      expect(@provider.gid_used?(18)).to be_falsey
-    end
-
-    it "should return false if not given any valid gid number" do
-      expect(@provider.gid_used?(nil)).to be_falsey
-    end
-  end
-
-  describe "set_gid" do
-    describe "with the new resource and a gid number which is already in use" do
-      before do
-        allow(@provider).to receive(:gid_used?).and_return(true)
-      end
-
-      it "should raise an exception if the new resources gid is already in use" do
-        expect { @provider.set_gid }.to raise_error(Chef::Exceptions::Group)
-      end
-    end
-
-    describe "with no gid number for the new resources" do
-      it "should run get_free_gid and return a valid, unused gid number" do
-        expect(@provider).to receive(:get_free_gid).and_return(501)
-        @provider.set_gid
-      end
-    end
-
-    describe "with blank gid number for the new resources" do
-      before do
-        @new_resource.instance_variable_set(:@gid, nil)
-        allow(@new_resource).to receive(:safe_dscl)
-      end
-
-      it "should run get_free_gid and return a valid, unused gid number" do
-        expect(@provider).to receive(:get_free_gid).and_return(501)
-        @provider.set_gid
-      end
-    end
-
-    describe "with a valid gid number which is not already in use" do
-      it "should run safe_dscl with create /Groups/group PrimaryGroupID gid" do
-        allow(@provider).to receive(:get_free_gid).and_return(50)
-        expect(@provider).to receive(:safe_dscl).with(*"search /Groups PrimaryGroupID 50".split(" ")).and_return("")
-        expect(@provider).to receive(:safe_dscl).with("create", "/Groups/aj", "PrimaryGroupID", 50).and_return(true)
-        @provider.set_gid
-      end
-    end
-  end
-
-  describe "set_members" do
-
-    describe "with existing members in the current resource and append set to false in the new resource" do
-      before do
-        @new_resource.members([])
-        @new_resource.append(false)
-        allow(@current_resource).to receive(:members).and_return(%w{all your base})
-      end
-
-      it "should log an appropriate message" do
-        expect(logger).to receive(:trace).with("group[aj] removing group members all your base")
-        @provider.set_members
-      end
-
-      it "should run safe_dscl with create /Groups/group GroupMembership to clear the Group's UID list" do
-        expect(@provider).to receive(:safe_dscl).with("create", "/Groups/aj", "GroupMembers", "").and_return(true)
-        expect(@provider).to receive(:safe_dscl).with("create", "/Groups/aj", "GroupMembership", "").and_return(true)
-        @provider.set_members
-      end
-    end
-
-    describe "with supplied members in the new resource" do
-      before do
-        @new_resource.members(%w{all your base})
-        @current_resource.members([])
-      end
-
-      it "should log an appropriate debug message" do
-        expect(logger).to receive(:trace).with("group[aj] setting group members all, your, base")
-        @provider.set_members
-      end
-
-      it "should run safe_dscl with append /Groups/group GroupMembership and group members all, your, base" do
-        expect(@provider).to receive(:safe_dscl).with("create", "/Groups/aj", "GroupMembers", "").and_return(true)
-        expect(@provider).to receive(:safe_dscl).with(*"append /Groups/aj GroupMembership all your base".split(" ")).and_return(true)
-        expect(@provider).to receive(:safe_dscl).with("create", "/Groups/aj", "GroupMembership", "").and_return(true)
-        @provider.set_members
-      end
-    end
-
-    describe "with no members in the new resource" do
-      before do
-        @new_resource.append(true)
-        @new_resource.members([])
-      end
-
-      it "should not call safe_dscl" do
-        expect(@provider).not_to receive(:safe_dscl)
-        @provider.set_members
-      end
-    end
-  end
-
-  describe "when loading the current system state" do
-    before(:each) do
-      @provider.action = :create
-      @provider.load_current_resource
-      @provider.define_resource_requirements
-    end
-
-    it "raises an error if the required binary /usr/bin/dscl doesn't exist" do
-      expect(File).to receive(:exist?).with("/usr/bin/dscl").and_return(false)
-
-      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-    it "doesn't raise an error if /usr/bin/dscl exists" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect { @provider.process_resource_requirements }.not_to raise_error
-    end
-  end
-
-  describe "when creating the group" do
-    it "creates the group, password field, gid, and sets group membership" do
-      expect(@provider).to receive(:set_gid).and_return(true)
-      expect(@provider).to receive(:set_members).and_return(true)
-      expect(@provider).to receive(:safe_dscl).with(*"create /Groups/aj Password *".split(" "))
-      expect(@provider).to receive(:safe_dscl).with(*"create /Groups/aj".split(" "))
-      @provider.create_group
-    end
-  end
-
-  describe "managing the group" do
-    it "should manage the group_name if it changed and the new resources group_name is not null" do
-      @current_resource.group_name("oldval")
-      @new_resource.group_name("newname")
-      expect(@provider).to receive(:set_members).and_return(true)
-      expect(@provider).to receive(:safe_dscl).with(*"create /Groups/newname".split(" "))
-      expect(@provider).to receive(:safe_dscl).with(*"create /Groups/newname Password *".split(" "))
-      @provider.manage_group
-    end
-
-    it "should manage the gid if it changed and the new resources gid is not null" do
-      @current_resource.gid(23)
-      @new_resource.gid(42)
-      expect(@provider).to receive(:set_gid)
-      @provider.manage_group
-    end
-
-    it "should manage the members if it changed and the new resources members is not null" do
-      @current_resource.members(%{charlie root})
-      @new_resource.members(%{crab revenge})
-      expect(@provider).to receive(:set_members)
-      @provider.manage_group
-    end
-  end
-
-  describe "remove_group" do
-    it "should run safe_dscl with delete /Groups/group and with the new resources group name" do
-      expect(@provider).to receive(:safe_dscl).with(*"delete /Groups/aj".split(" ")).and_return(true)
-      @provider.remove_group
-    end
-  end
-end
-
-describe "Test DSCL loading" do
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::Group.new("group name aj")
-    @new_resource.group_name("aj")
-    @provider = Chef::Provider::Group::Dscl.new(@new_resource, @run_context)
-    @output = <<~EOF
-      AppleMetaNodeLocation: /Local/Default
-      Comment:
-       Test Group
-      GeneratedUID: AAAAAAAA-AAAA-AAAA-AAAA-AAAAAAAAAAAA
-      NestedGroups: AAAAAAAA-AAAA-AAAA-AAAA-AAAAAAAAAAAB
-      Password: *
-      PrimaryGroupID: 999
-      RealName:
-       TestGroup
-      RecordName: com.apple.aj
-      RecordType: dsRecTypeStandard:Groups
-      GroupMembership: waka bar
-    EOF
-    allow(@provider).to receive(:safe_dscl).with(*"read /Groups/aj".split(" ")).and_return(@output)
-    @current_resource = @provider.load_current_resource
-
-  end
-
-  it "should parse gid properly" do
-    allow(File).to receive(:exist?).and_return(true)
-    expect(@current_resource.gid).to eq("999")
-  end
-  it "should parse members properly" do
-    allow(File).to receive(:exist?).and_return(true)
-    expect(@current_resource.members).to eq(%w{waka bar})
-  end
-end

data/spec/unit/provider/group/gpasswd_spec.rb

@@ -1,119 +0,0 @@
-#
-# Author:: AJ Christensen (<aj@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Group::Gpasswd, "modify_group_members" do
-  let(:logger) { double("Mixlib::Log::Child").as_null_object }
-
-  before do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    allow(@run_context).to receive(:logger).and_return(logger)
-    @new_resource = Chef::Resource::Group.new("wheel")
-    @new_resource.members %w{lobster rage fist}
-    @new_resource.append false
-    @provider = Chef::Provider::Group::Gpasswd.new(@new_resource, @run_context)
-    # @provider.stub(:run_command).and_return(true)
-  end
-
-  describe "when determining the current group state" do
-    before(:each) do
-      @provider.action = :create
-      @provider.load_current_resource
-      @provider.define_resource_requirements
-    end
-
-    # Checking for required binaries is already done in the spec
-    # for Chef::Provider::Group - no need to repeat it here.  We'll
-    # include only what's specific to this provider.
-    it "should raise an error if the required binary /usr/bin/gpasswd doesn't exist" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect(File).to receive(:exist?).with("/usr/bin/gpasswd").and_return(false)
-      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-    it "shouldn't raise an error if the required binaries exist" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect { @provider.process_resource_requirements }.not_to raise_error
-    end
-  end
-
-  describe "after the group's current state is known" do
-    before do
-      @current_resource = @new_resource.dup
-      @provider.current_resource = @new_resource
-    end
-
-    describe "when no group members are specified and append is not set" do
-      before do
-        @new_resource.append(false)
-        @new_resource.members([])
-      end
-
-      it "logs a message and sets group's members to 'none'" do
-        expect(logger).to receive(:debug).with("group[wheel] setting group members to: none")
-        expect(@provider).to receive(:shell_out_compacted!).with("gpasswd", "-M", "", "wheel")
-        @provider.modify_group_members
-      end
-    end
-
-    describe "when no group members are specified and append is set" do
-      before do
-        @new_resource.append(true)
-        @new_resource.members([])
-      end
-
-      it "does not modify group membership" do
-        expect(@provider).not_to receive(:shell_out_compacted!)
-        @provider.modify_group_members
-      end
-    end
-
-    describe "when the resource specifies group members" do
-      it "should log an appropriate debug message" do
-        expect(logger).to receive(:debug).with("group[wheel] setting group members to: lobster, rage, fist")
-        allow(@provider).to receive(:shell_out_compacted!)
-        @provider.modify_group_members
-      end
-
-      it "should run gpasswd with the members joined by ',' followed by the target group" do
-        expect(@provider).to receive(:shell_out_compacted!).with("gpasswd", "-M", "lobster,rage,fist", "wheel")
-        @provider.modify_group_members
-      end
-
-      describe "when no user exists in the system" do
-        before do
-          current_resource = @new_resource.dup
-          current_resource.members([ ])
-          @provider.current_resource = current_resource
-        end
-
-        it "should run gpasswd individually for each user when the append option is set" do
-          @new_resource.append(true)
-          expect(@provider).to receive(:shell_out_compacted!).with("gpasswd", "-a", "lobster", "wheel")
-          expect(@provider).to receive(:shell_out_compacted!).with("gpasswd", "-a", "rage", "wheel")
-          expect(@provider).to receive(:shell_out_compacted!).with("gpasswd", "-a", "fist", "wheel")
-          @provider.modify_group_members
-        end
-      end
-
-    end
-  end
-end

data/spec/unit/provider/group/groupadd_spec.rb

@@ -1,195 +0,0 @@
-#
-# Author:: AJ Christensen (<aj@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Provider::Group::Groupadd do
-  let(:node) { Chef::Node.new }
-  let(:events) { Chef::EventDispatch::Dispatcher.new }
-  let(:run_context) { Chef::RunContext.new(node, {}, events) }
-  let(:new_resource) do
-    Chef::Resource::Group.new("aj").tap do |r|
-      r.gid 50
-      r.members %w{root aj}
-      r.system false
-      r.non_unique false
-    end
-  end
-  let(:current_resource) do
-    Chef::Resource::Group.new("aj").tap do |r|
-      r.gid 50
-      r.members %w{root aj}
-      r.system false
-      r.non_unique false
-    end
-  end
-  let(:provider) do
-    described_class.new(new_resource, run_context).tap do |p|
-      p.current_resource = current_resource
-    end
-  end
-
-  describe "#set_options" do
-    field_list = {
-      gid: "-g",
-    }
-
-    field_list.each do |property, option|
-      it "should check for differences in #{property} between the current and new resources" do
-        expect(new_resource).to receive(property)
-        expect(current_resource).to receive(property)
-        provider.set_options
-      end
-
-      it "should set the option for #{property} if the new resources #{property} is not null" do
-        allow(new_resource).to receive(property).and_return("cactus")
-        expect(provider.set_options).to eql([ option, new_resource.send(property), new_resource.group_name])
-      end
-    end
-
-    it "should combine all the possible options" do
-      match_array = []
-      field_list.sort_by { |a| a[0] }.each do |property, option|
-        allow(new_resource).to receive(property).and_return("hola")
-        match_array << option
-        match_array << "hola"
-      end
-      match_array << "aj"
-      expect(provider.set_options).to eql(match_array)
-    end
-
-    describe "when we want to create a system group" do
-      it "should not set groupadd_options '-r' when system is false" do
-        new_resource.system(false)
-        expect(provider.groupadd_options).to eq([])
-      end
-
-      it "should set groupadd -r if system is true" do
-        new_resource.system(true)
-        expect(provider.groupadd_options).to eq(["-r"])
-      end
-
-      context "on Solaris" do
-        before { node.automatic["platform"] = "solaris2" }
-        it "should not set groupadd -r if system is true" do
-          new_resource.system(true)
-          expect(provider.groupadd_options).to eql([])
-        end
-      end
-    end
-
-    describe "when we want to create a non_unique gid group" do
-      it "should not set groupadd_options '-o' when non_unique is false" do
-        new_resource.non_unique(false)
-        expect(provider.groupadd_options).to eq([])
-      end
-
-      it "should set groupadd -o if non_unique is true" do
-        new_resource.non_unique(true)
-        expect(provider.groupadd_options).to eq(["-o"])
-      end
-    end
-  end
-
-  describe "#create_group" do
-    before do
-      allow(provider).to receive(:shell_out_compacted!).and_return(true)
-      allow(provider).to receive(:set_options).and_return("monkey")
-      allow(provider).to receive(:groupadd_options).and_return([])
-      allow(provider).to receive(:modify_group_members).and_return(true)
-    end
-
-    it "should run groupadd with the return of set_options" do
-      expect(provider).to receive(:shell_out_compacted!).with("groupadd", "monkey").and_return(true)
-      provider.create_group
-    end
-
-    it "should modify the group members" do
-      expect(provider).to receive(:modify_group_members).and_return(true)
-      provider.create_group
-    end
-  end
-
-  describe "#manage_group" do
-    before do
-      allow(provider).to receive(:shell_out_compacted!).and_return(true)
-      allow(provider).to receive(:set_options).and_return("monkey")
-    end
-
-    it "should run groupmod with the return of set_options" do
-      allow(provider).to receive(:modify_group_members).and_return(true)
-      expect(provider).to receive(:shell_out_compacted!).with("groupmod", "monkey").and_return(true)
-      provider.manage_group
-    end
-
-    it "should modify the group members" do
-      expect(provider).to receive(:modify_group_members).and_return(true)
-      provider.manage_group
-    end
-  end
-
-  describe "#remove_group" do
-    before do
-      allow(provider).to receive(:shell_out_compacted!).and_return(true)
-      allow(provider).to receive(:set_options).and_return("monkey")
-    end
-
-    it "should run groupdel with the new resources group name" do
-      expect(provider).to receive(:shell_out_compacted!).with("groupdel", "aj").and_return(true)
-      provider.remove_group
-    end
-  end
-
-  %i{add_member remove_member set_members}.each do |m|
-    it "should raise an error when calling #{m}" do
-      expect { provider.send(m, [ ]) }.to raise_error(Chef::Exceptions::Group, "you must override #{m} in #{provider}")
-    end
-  end
-
-  describe "#load_current_resource" do
-    before do
-      allow(provider).to receive(:shell_out_compacted!).and_return(true)
-      allow(provider).to receive(:set_options).and_return("monkey")
-    end
-
-    before do
-      allow(File).to receive(:exist?).and_return(false)
-      provider.action = :modify
-      provider.define_resource_requirements
-    end
-
-    it "should raise an error if the required binary /usr/sbin/groupadd doesn't exist" do
-      expect(File).to receive(:exist?).with("/usr/sbin/groupadd").and_return(false)
-      expect { provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-    it "should raise an error if the required binary /usr/sbin/groupmod doesn't exist" do
-      expect(File).to receive(:exist?).with("/usr/sbin/groupadd").and_return(true)
-      expect(File).to receive(:exist?).with("/usr/sbin/groupmod").and_return(false)
-      expect { provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-    it "should raise an error if the required binary /usr/sbin/groupdel doesn't exist" do
-      expect(File).to receive(:exist?).with("/usr/sbin/groupadd").and_return(true)
-      expect(File).to receive(:exist?).with("/usr/sbin/groupmod").and_return(true)
-      expect(File).to receive(:exist?).with("/usr/sbin/groupdel").and_return(false)
-      expect { provider.process_resource_requirements }.to raise_error(Chef::Exceptions::Group)
-    end
-
-  end
-end