chef 18.7.10 → 18.8.46

data/spec/integration/recipes/accumulator_spec.rb

@@ -1,245 +0,0 @@
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "chef/mixin/shell_out"
-
-describe "Accumulators" do
-  include IntegrationSupport
-  include Chef::Mixin::ShellOut
-
-  let(:chef_dir) { File.expand_path("../../..", __dir__) }
-
-  # Invoke `chef-client` as `ruby PATH/TO/chef-client`. This ensures the
-  # following constraints are satisfied:
-  # * Windows: windows can only run batch scripts as bare executables. Rubygems
-  # creates batch wrappers for installed gems, but we don't have batch wrappers
-  # in the source tree.
-  # * Other `chef-client` in PATH: A common case is running the tests on a
-  # machine that has omnibus chef installed. In that case we need to ensure
-  # we're running `chef-client` from the source tree and not the external one.
-  # cf. CHEF-4914
-  let(:chef_client) { "bundle exec #{ChefUtils::Dist::Infra::CLIENT} --minimal-ohai --always-dump-stacktrace" }
-
-  let(:aliases_temppath) do
-    t = Tempfile.new("chef_accumulator_test")
-    path = t.path
-    t.close
-    t.unlink
-    path
-  end
-
-  when_the_repository "edit_resource-based delayed accumulators work" do
-    before do
-      directory "cookbooks/x" do
-        file "resources/email_alias.rb", <<-EOM
-          unified_mode true
-
-          provides :email_alias
-          resource_name :email_alias
-
-          property :address, String, name_property: true, identity: true
-          property :recipients, Array
-
-          default_action :create
-
-          action :create do
-            with_run_context :root do
-              edit_resource(:template, "#{aliases_temppath}") do |new_resource|
-                source "aliases.erb"
-                variables[:aliases] ||= {}
-                variables[:aliases][new_resource.address] ||= []
-                variables[:aliases][new_resource.address] += new_resource.recipients
-                action :nothing
-                delayed_action :create
-              end
-            end
-          end
-        EOM
-
-        file "resources/nested.rb", <<-EOM
-          unified_mode true
-
-          provides :nested
-          resource_name :nested
-
-          property :address, String, name_property: true, identity: true
-          property :recipients, Array
-
-          default_action :create
-
-          action :create do
-            email_alias new_resource.address do
-              recipients new_resource.recipients
-            end
-          end
-        EOM
-
-        file "resources/doubly_nested.rb", <<-EOM
-          unified_mode true
-
-          provides :doubly_nested
-          resource_name :doubly_nested
-
-          property :address, String, name_property: true, identity: true
-          property :recipients, Array
-
-          default_action :create
-
-          action :create do
-            nested new_resource.address do
-              recipients new_resource.recipients
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<-EOM
-          email_alias "outer1" do
-            recipients [ "out1a", "out1b" ]
-          end
-
-          nested "nested1" do
-            recipients [ "nested1a", "nested1b" ]
-          end
-
-          email_alias "outer2" do
-            recipients [ "out2a", "out2b" ]
-          end
-
-          doubly_nested "nested2" do
-            recipients [ "nested2a", "nested2b" ]
-          end
-
-          email_alias "outer3" do
-            recipients [ "out3a", "out3b" ]
-          end
-        EOM
-
-        file "templates/aliases.erb", <<-EOM.gsub(/^\s+/, "")
-          <%= pp @aliases %>
-        EOM
-      end # directory 'cookbooks/x'
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<-EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      result.error!
-      # runs only a single template resource (in the outer run context, as a delayed resource)
-      expect(result.stdout.scan(/template\S+ action create/).size).to eql(1)
-      # hash order is insertion order in ruby >= 1.9, so this next line does test that all calls were in the correct order
-      expect(IO.read(aliases_temppath).chomp).to eql('{"outer1"=>["out1a", "out1b"], "nested1"=>["nested1a", "nested1b"], "outer2"=>["out2a", "out2b"], "nested2"=>["nested2a", "nested2b"], "outer3"=>["out3a", "out3b"]}')
-    end
-  end
-
-  when_the_repository "find_resource-based delayed accumulators work" do
-    before do
-      directory "cookbooks/x" do
-        file "resources/email_alias.rb", <<-EOM
-          unified_mode true
-
-          provides :email_alias
-          resource_name :email_alias
-
-          property :address, String, name_property: true, identity: true
-          property :recipients, Array
-
-          default_action :create
-
-          action :create do
-            r = with_run_context :root do
-              find_resource(:template, "#{aliases_temppath}") do
-                source "aliases.erb"
-                variables[:aliases] = {}
-                action :nothing
-                delayed_action :create
-              end
-            end
-            r.variables[:aliases][new_resource.address] ||= []
-            r.variables[:aliases][new_resource.address] += new_resource.recipients
-          end
-        EOM
-
-        file "resources/nested.rb", <<-EOM
-          unified_mode true
-
-          provides :nested
-          resource_name :nested
-
-          property :address, String, name_property: true, identity: true
-          property :recipients, Array
-
-          default_action :create
-
-          action :create do
-            email_alias new_resource.address do
-              recipients new_resource.recipients
-            end
-          end
-        EOM
-
-        file "resources/doubly_nested.rb", <<-EOM
-          unified_mode true
-
-          provides :doubly_nested
-          resource_name :doubly_nested
-
-          property :address, String, name_property: true, identity: true
-          property :recipients, Array
-
-          default_action :create
-
-          action :create do
-            nested new_resource.address do
-              recipients new_resource.recipients
-            end
-          end
-        EOM
-
-        file "recipes/default.rb", <<-EOM
-          email_alias "outer1" do
-            recipients [ "out1a", "out1b" ]
-          end
-
-          nested "nested1" do
-            recipients [ "nested1a", "nested1b" ]
-          end
-
-          email_alias "outer2" do
-            recipients [ "out2a", "out2b" ]
-          end
-
-          doubly_nested "nested2" do
-            recipients [ "nested2a", "nested2b" ]
-          end
-
-          email_alias "outer3" do
-            recipients [ "out3a", "out3b" ]
-          end
-        EOM
-
-        file "templates/aliases.erb", <<-EOM.gsub(/^\s+/, "")
-          <%= pp @aliases %>
-        EOM
-      end # directory 'cookbooks/x'
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<-EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      result.error!
-      # runs only a single template resource (in the outer run context, as a delayed resource)
-      expect(result.stdout.scan(/template\S+ action create/).size).to eql(1)
-      # hash order is insertion order in ruby >= 1.9, so this next line does test that all calls were in the correct order
-      expect(IO.read(aliases_temppath).chomp).to eql('{"outer1"=>["out1a", "out1b"], "nested1"=>["nested1a", "nested1b"], "outer2"=>["out2a", "out2b"], "nested2"=>["nested2a", "nested2b"], "outer3"=>["out3a", "out3b"]}')
-    end
-  end
-end

data/spec/integration/recipes/lwrp_inline_resources_spec.rb

@@ -1,176 +0,0 @@
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "chef/mixin/shell_out"
-
-describe "LWRPs with inline resources" do
-  include IntegrationSupport
-  include Chef::Mixin::ShellOut
-
-  let(:chef_dir) { File.expand_path("../../..", __dir__) }
-
-  # Invoke `chef-client` as `ruby PATH/TO/chef-client`. This ensures the
-  # following constraints are satisfied:
-  # * Windows: windows can only run batch scripts as bare executables. Rubygems
-  # creates batch wrappers for installed gems, but we don't have batch wrappers
-  # in the source tree.
-  # * Other `chef-client` in PATH: A common case is running the tests on a
-  # machine that has omnibus chef installed. In that case we need to ensure
-  # we're running `chef-client` from the source tree and not the external one.
-  # cf. CHEF-4914
-  let(:chef_client) { "bundle exec #{ChefUtils::Dist::Infra::CLIENT} --minimal-ohai --always-dump-stacktrace" }
-
-  context "with a use_inline_resources provider with 'def action_a' instead of action :a" do
-    class LwrpInlineResourcesTest < Chef::Resource
-      provides :lwrp_inline_resources_test
-      allowed_actions :a, :nothing
-      default_action :a
-      property :ran_a
-      class Provider < Chef::Provider::LWRPBase
-        provides :lwrp_inline_resources_test
-        def action_a
-          r = new_resource
-          ruby_block "run a" do
-            block { r.ran_a "ran a" }
-          end
-        end
-      end
-    end
-
-    it "this is totally a bug, but for backcompat purposes, it adds the resources to the main resource collection and does not get marked updated" do
-      r = nil
-      expect_recipe do
-        r = lwrp_inline_resources_test "hi"
-      end.to have_updated("ruby_block[run a]", :run)
-      expect(r.ran_a).to eq "ran a"
-    end
-  end
-
-  context "with an inline resource with a property that shadows the enclosing provider's property" do
-    class LwrpShadowedPropertyTest < Chef::Resource
-      provides :lwrp_shadowed_property_test
-      PATH = ::File.join(Dir.tmpdir, "shadow-property.txt")
-      allowed_actions :fiddle
-      property :content
-      action :fiddle do
-        file PATH do
-          content new_resource.content
-          action %i{create delete}
-        end
-      end
-    end
-
-    after { File.delete(LwrpShadowedPropertyTest::PATH) if File.exist?(LwrpShadowedPropertyTest::PATH) }
-
-    # https://github.com/chef/chef/issues/4334
-    it "does not warn spuriously" do
-      expect(Chef::Log).to_not receive(:warn).with(/is declared in both/)
-      expect_recipe do
-        lwrp_shadowed_property_test "fnord" do
-          action :fiddle
-        end
-      end
-    end
-  end
-
-  context "with an inline_resources provider with two actions, one calling the other" do
-    class LwrpInlineResourcesTest2 < Chef::Resource
-      provides :lwrp_inline_resources_test2
-      allowed_actions :a, :b, :nothing
-      default_action :b
-      property :ran_a
-      property :ran_b
-      class Provider < Chef::Provider::LWRPBase
-        provides :lwrp_inline_resources_test2
-        action :a do
-          r = new_resource
-          ruby_block "run a" do
-            block { r.ran_a "ran a" }
-          end
-        end
-
-        action :b do
-          action_a
-          r = new_resource
-          # Grab ran_a right now, before we converge
-          ran_a = r.ran_a
-          ruby_block "run b" do
-            block { r.ran_b "ran b: ran_a value was #{ran_a.inspect}" }
-          end
-        end
-      end
-    end
-
-    it "resources declared in b are executed immediately inline" do
-      r = nil
-      expect_recipe do
-        r = lwrp_inline_resources_test2 "hi" do
-          action :b
-        end
-      end.to have_updated("lwrp_inline_resources_test2[hi]", :b)
-        .and have_updated("ruby_block[run a]", :run)
-        .and have_updated("ruby_block[run b]", :run)
-      expect(r.ran_b).to eq "ran b: ran_a value was \"ran a\""
-    end
-  end
-
-  when_the_repository "has a cookbook with a nested LWRP" do
-    before do
-      directory "cookbooks/x" do
-
-        file "resources/do_nothing.rb", <<-EOM
-          unified_mode true
-
-          actions :create, :nothing
-          default_action :create
-        EOM
-        file "providers/do_nothing.rb", <<-EOM
-          action :create do
-          end
-        EOM
-
-        file "resources/my_machine.rb", <<-EOM
-          unified_mode true
-
-          actions :create, :nothing
-          default_action :create
-        EOM
-        file "providers/my_machine.rb", <<-EOM
-            action :create do
-            x_do_nothing 'a'
-            x_do_nothing 'b'
-          end
-        EOM
-
-        file "recipes/default.rb", <<-EOM
-          x_my_machine "me"
-          x_my_machine "you"
-        EOM
-
-      end # directory 'cookbooks/x'
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
-      actual = result.stdout.lines.map(&:chomp).join("\n")
-      expected = <<EOM
-  * x_my_machine[me] action create
-    * x_do_nothing[a] action create (up to date)
-    * x_do_nothing[b] action create (up to date)
-     (up to date)
-  * x_my_machine[you] action create
-    * x_do_nothing[a] action create (up to date)
-    * x_do_nothing[b] action create (up to date)
-     (up to date)
-EOM
-      expected = expected.lines.map(&:chomp).join("\n")
-      expect(actual).to include(expected)
-      result.error!
-    end
-  end
-end

data/spec/integration/recipes/lwrp_spec.rb

@@ -1,56 +0,0 @@
-require "spec_helper"
-require "support/shared/integration/integration_helper"
-require "chef/mixin/shell_out"
-
-describe "LWRPs" do
-  include IntegrationSupport
-  include Chef::Mixin::ShellOut
-
-  let(:chef_dir) { File.expand_path("../../..", __dir__) }
-
-  # Invoke `chef-client` as `ruby PATH/TO/chef-client`. This ensures the
-  # following constraints are satisfied:
-  # * Windows: windows can only run batch scripts as bare executables. Rubygems
-  # creates batch wrappers for installed gems, but we don't have batch wrappers
-  # in the source tree.
-  # * Other `chef-client` in PATH: A common case is running the tests on a
-  # machine that has omnibus chef installed. In that case we need to ensure
-  # we're running `chef-client` from the source tree and not the external one.
-  # cf. CHEF-4914
-  let(:chef_client) { "bundle exec #{ChefUtils::Dist::Infra::CLIENT} --minimal-ohai --always-dump-stacktrace" }
-
-  when_the_repository "has a cookbook named l-w-r-p" do
-    before do
-      directory "cookbooks/l-w-r-p" do
-
-        file "resources/foo.rb", <<~EOM
-          unified_mode true
-
-          default_action :create
-        EOM
-        file "providers/foo.rb", <<~EOM
-          action :create do
-          end
-        EOM
-
-        file "recipes/default.rb", <<~EOM
-          l_w_r_p_foo "me"
-        EOM
-
-      end # directory 'cookbooks/x'
-    end
-
-    it "should complete with success" do
-      file "config/client.rb", <<~EOM
-        local_mode true
-        cookbook_path "#{path_to("cookbooks")}"
-        log_level :warn
-      EOM
-
-      result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'l-w-r-p::default'", cwd: chef_dir)
-      expect(result.stdout).to match(/\* l_w_r_p_foo\[me\] action create \(up to date\)/)
-      expect(result.stdout).not_to match(/WARN: You are overriding l_w_r_p_foo/)
-      result.error!
-    end
-  end
-end

data/spec/integration/recipes/noop_resource_spec.rb

@@ -1,24 +0,0 @@
-require "support/shared/integration/integration_helper"
-
-describe "Resources with a no-op provider" do
-  include IntegrationSupport
-
-  context "with noop provider providing foo" do
-    before(:each) do
-      class NoOpFoo < Chef::Resource
-        provides "hi_there"
-        default_action :update
-      end
-      Chef::Provider::Noop.provides :hi_there
-    end
-
-    it "does not blow up a run with a noop'd resource" do
-      recipe = converge do
-        hi_there "blah" do
-          action :update
-        end
-      end
-      expect(recipe.logged_warnings).to eq ""
-    end
-  end
-end