lighthouse 13.1.0 → 13.3.0

package/core/lib/deprecations-strings.d.ts

@@ -50,6 +50,7 @@ export namespace UIStrings {
     let PrefixedVideoExitFullScreen: string;
     let PrefixedVideoExitFullscreen: string;
     let PrefixedVideoSupportsFullscreen: string;
+    let PreventSvgFilterPaint: string;
     let RangeExpand: string;
     let RelatedWebsiteSets: string;
     let RequestedSubresourceWithEmbeddedCredentials: string;
@@ -237,6 +238,11 @@ export namespace DEPRECATIONS_METADATA {
         export { milestone_12 as milestone };
     }
     export { PersistentQuotaType_1 as PersistentQuotaType };
+    export namespace PreventSvgFilterPaint_1 {
+        let chromeStatusFeature_25: number;
+        export { chromeStatusFeature_25 as chromeStatusFeature };
+    }
+    export { PreventSvgFilterPaint_1 as PreventSvgFilterPaint };
     export namespace RTCConstraintEnableDtlsSrtpFalse_1 {
         let milestone_13: number;
         export { milestone_13 as milestone };
@@ -248,25 +254,25 @@ export namespace DEPRECATIONS_METADATA {
     }
     export { RTCConstraintEnableDtlsSrtpTrue_1 as RTCConstraintEnableDtlsSrtpTrue };
     export namespace RTCPeerConnectionGetStatsLegacyNonCompliant_1 {
-        let chromeStatusFeature_25: number;
-        export { chromeStatusFeature_25 as chromeStatusFeature };
+        let chromeStatusFeature_26: number;
+        export { chromeStatusFeature_26 as chromeStatusFeature };
         let milestone_15: number;
         export { milestone_15 as milestone };
     }
     export { RTCPeerConnectionGetStatsLegacyNonCompliant_1 as RTCPeerConnectionGetStatsLegacyNonCompliant };
     export namespace RelatedWebsiteSets_1 {
-        let chromeStatusFeature_26: number;
-        export { chromeStatusFeature_26 as chromeStatusFeature };
+        let chromeStatusFeature_27: number;
+        export { chromeStatusFeature_27 as chromeStatusFeature };
     }
     export { RelatedWebsiteSets_1 as RelatedWebsiteSets };
     export namespace RequestedSubresourceWithEmbeddedCredentials_1 {
-        let chromeStatusFeature_27: number;
-        export { chromeStatusFeature_27 as chromeStatusFeature };
+        let chromeStatusFeature_28: number;
+        export { chromeStatusFeature_28 as chromeStatusFeature };
     }
     export { RequestedSubresourceWithEmbeddedCredentials_1 as RequestedSubresourceWithEmbeddedCredentials };
     export namespace RtcpMuxPolicyNegotiate_1 {
-        let chromeStatusFeature_28: number;
-        export { chromeStatusFeature_28 as chromeStatusFeature };
+        let chromeStatusFeature_29: number;
+        export { chromeStatusFeature_29 as chromeStatusFeature };
         let milestone_16: number;
         export { milestone_16 as milestone };
     }
@@ -277,25 +283,25 @@ export namespace DEPRECATIONS_METADATA {
     }
     export { SharedArrayBufferConstructedWithoutIsolation_1 as SharedArrayBufferConstructedWithoutIsolation };
     export namespace SharedStorage_1 {
-        let chromeStatusFeature_29: number;
-        export { chromeStatusFeature_29 as chromeStatusFeature };
+        let chromeStatusFeature_30: number;
+        export { chromeStatusFeature_30 as chromeStatusFeature };
     }
     export { SharedStorage_1 as SharedStorage };
     export namespace StorageAccessAPI_requestStorageAccessFor_Method_1 {
-        let chromeStatusFeature_30: number;
-        export { chromeStatusFeature_30 as chromeStatusFeature };
+        let chromeStatusFeature_31: number;
+        export { chromeStatusFeature_31 as chromeStatusFeature };
     }
     export { StorageAccessAPI_requestStorageAccessFor_Method_1 as StorageAccessAPI_requestStorageAccessFor_Method };
     export namespace TextToSpeech_DisallowedByAutoplay_1 {
-        let chromeStatusFeature_31: number;
-        export { chromeStatusFeature_31 as chromeStatusFeature };
+        let chromeStatusFeature_32: number;
+        export { chromeStatusFeature_32 as chromeStatusFeature };
         let milestone_18: number;
         export { milestone_18 as milestone };
     }
     export { TextToSpeech_DisallowedByAutoplay_1 as TextToSpeech_DisallowedByAutoplay };
     export namespace UnloadHandler_1 {
-        let chromeStatusFeature_32: number;
-        export { chromeStatusFeature_32 as chromeStatusFeature };
+        let chromeStatusFeature_33: number;
+        export { chromeStatusFeature_33 as chromeStatusFeature };
     }
     export { UnloadHandler_1 as UnloadHandler };
     export namespace V8SharedArrayBufferConstructedInExtensionWithoutIsolation_1 {
@@ -304,8 +310,8 @@ export namespace DEPRECATIONS_METADATA {
     }
     export { V8SharedArrayBufferConstructedInExtensionWithoutIsolation_1 as V8SharedArrayBufferConstructedInExtensionWithoutIsolation };
     export namespace WebBluetoothRemoteCharacteristicWriteValue_1 {
-        let chromeStatusFeature_33: number;
-        export { chromeStatusFeature_33 as chromeStatusFeature };
+        let chromeStatusFeature_34: number;
+        export { chromeStatusFeature_34 as chromeStatusFeature };
     }
     export { WebBluetoothRemoteCharacteristicWriteValue_1 as WebBluetoothRemoteCharacteristicWriteValue };
     export namespace XHRJSONEncodingDetection_1 {
@@ -314,8 +320,8 @@ export namespace DEPRECATIONS_METADATA {
     }
     export { XHRJSONEncodingDetection_1 as XHRJSONEncodingDetection };
     export namespace XSLT_1 {
-        let chromeStatusFeature_34: number;
-        export { chromeStatusFeature_34 as chromeStatusFeature };
+        let chromeStatusFeature_35: number;
+        export { chromeStatusFeature_35 as chromeStatusFeature };
         let milestone_21: number;
         export { milestone_21 as milestone };
     }

package/core/lib/deprecations-strings.js

@@ -212,6 +212,10 @@ export const UIStrings = {
    * @description Standard message when one web API is deprecated in favor of another.
    */
   PrefixedVideoSupportsFullscreen: "HTMLVideoElement.webkitSupportsFullscreen is deprecated. Please use Document.fullscreenEnabled instead.",
+  /**
+   * @description Warning displayed to developers when an SVG filter is applied to a disallowed content type.
+   */
+  PreventSvgFilterPaint: "SVG filters cannot be applied to cross-origin iframes, restricted iframes (e.g., sandboxed), or plugins.",
   /**
    * @description Standard message when one web API is deprecated in favor of another.
    */
@@ -391,6 +395,9 @@ export const DEPRECATIONS_METADATA = {
     "chromeStatusFeature": 5176235376246784,
     "milestone": 106
   },
+  "PreventSvgFilterPaint": {
+    "chromeStatusFeature": 5117170452398080
+  },
   "RTCConstraintEnableDtlsSrtpFalse": {
     "milestone": 97
   },

package/core/lib/navigation-error.js

@@ -131,7 +131,6 @@ function getNonHtmlError(finalRecord) {
 function getPageLoadError(navigationError, context) {
   const {url, networkRecords} = context;
   const mainRecordLantern = Lantern.Core.NetworkAnalyzer.findResourceForUrl(
-    // @ts-expect-error - trace engine types for InitiatorType are outdated
     networkRecords,
     url
   );
@@ -144,7 +143,6 @@ function getPageLoadError(navigationError, context) {
       record.resourceType === NetworkRequest.TYPES.Document
     );
     if (documentRequests.length) {
-      // @ts-expect-error - mainRecord is inferred as a Lantern request from findResourceForUrl, but we assign a raw record here.
       mainRecord = documentRequests.reduce((min, r) => {
         return r.networkRequestTime < min.networkRequestTime ? r : min;
       });
@@ -164,12 +162,8 @@ function getPageLoadError(navigationError, context) {
     context.warnings.push(str_(UIStrings.warningXhtml));
   }
 
-  // @ts-expect-error - mainRecord may be typed as a Lantern request, but functions expect a raw record.
   const networkError = getNetworkError(mainRecord, context);
-  // @ts-expect-error - mainRecord may be typed as a Lantern request, but functions expect a raw record.
   const interstitialError = getInterstitialError(mainRecord, networkRecords);
-  // @ts-expect-error - finalRecord may be a Lantern request, which is compatible enough
-  // for getNonHtmlError.
   const nonHtmlError = getNonHtmlError(finalRecord);
 
   // We want to special-case the interstitial beyond FAILED_DOCUMENT_REQUEST. See https://github.com/GoogleChrome/lighthouse/pull/8865#issuecomment-497507618

package/core/lib/network-request.js

@@ -592,7 +592,6 @@ class NetworkRequest {
 
     record.fromWorker = record.sessionTargetType === 'worker';
 
-    // @ts-expect-error - trace engine types for InitiatorType are outdated
     return {
       rawRequest: record,
       ...record,

package/core/lib/page-functions.d.ts

@@ -88,10 +88,10 @@ declare namespace getOuterHTMLSnippet {
  */
 declare function computeBenchmarkIndex(): number;
 /**
- * @param {Element|ShadowRoot} element
- * @return {LH.Artifacts.NodeDetails}
+ * @param {Node|ShadowRoot} node
+ * @return {LH.Artifacts.NodeDetails | null}
  */
-declare function getNodeDetails(element: Element | ShadowRoot): LH.Artifacts.NodeDetails;
+declare function getNodeDetails(node: Node | ShadowRoot): LH.Artifacts.NodeDetails | null;
 declare namespace getNodeDetails {
     function toString(): string;
 }

package/core/lib/page-functions.js

@@ -450,16 +450,23 @@ function wrapRequestIdleCallback(cpuSlowdownMultiplier) {
 }
 
 /**
- * @param {Element|ShadowRoot} element
- * @return {LH.Artifacts.NodeDetails}
+ * @param {Node|ShadowRoot} node
+ * @return {LH.Artifacts.NodeDetails | null}
  */
-function getNodeDetails(element) {
+function getNodeDetails(node) {
   // This bookkeeping is for the FullPageScreenshot gatherer.
   if (!window.__lighthouseNodesDontTouchOrAllVarianceGoesAway) {
     window.__lighthouseNodesDontTouchOrAllVarianceGoesAway = new Map();
   }
 
-  element = element instanceof ShadowRoot ? element.host : element;
+  let elem = node.nodeType === Node.ELEMENT_NODE ? node : node.parentElement;
+  if (!elem && node instanceof ShadowRoot) {
+    elem = node.host;
+  }
+
+  if (!elem) return null;
+
+  const element = /** @type {Element} */ (elem);
   const selector = getNodeSelector(element);
 
   // Create an id that will be unique across all execution contexts.

package/core/lib/tracehouse/trace-processor.d.ts

@@ -196,9 +196,10 @@ export class TraceProcessor {
      *
      * @param {LH.TraceEvent[]} events
      * @param {LH.TraceEvent} timeOriginEvent
+     * @param {string|undefined} mainFrameId
      * @return {{lcp: LCPEvent | undefined, invalidated: boolean}}
      */
-    static computeValidLCPAllFrames(events: LH.TraceEvent[], timeOriginEvent: LH.TraceEvent): {
+    static computeValidLCPAllFrames(events: LH.TraceEvent[], timeOriginEvent: LH.TraceEvent, mainFrameId: string | undefined): {
         lcp: LCPEvent | undefined;
         invalidated: boolean;
     };
@@ -217,7 +218,7 @@ export class TraceProcessor {
      * @param {LH.Trace} trace
      * @param {{timeOriginDeterminationMethod?: TimeOriginDeterminationMethod}} [options]
      * @return {LH.Artifacts.ProcessedTrace}
-    */
+     */
     static processTrace(trace: LH.Trace, options?: {
         timeOriginDeterminationMethod?: TimeOriginDeterminationMethod;
     }): LH.Artifacts.ProcessedTrace;
@@ -226,7 +227,7 @@ export class TraceProcessor {
      * origin in addition to the standard microsecond monotonic timestamps.
      * @param {LH.Artifacts.ProcessedTrace} processedTrace
      * @return {LH.Artifacts.ProcessedNavigation}
-    */
+     */
     static processNavigation(processedTrace: LH.Artifacts.ProcessedTrace): LH.Artifacts.ProcessedNavigation;
     /**
      * Computes the last observable timestamp in a set of trace events.
@@ -272,7 +273,7 @@ export class TraceProcessor {
      * in addition to the standard microsecond monotonic timestamps.
      * @param {Array<LH.TraceEvent>} frameEvents
      * @param {{timeOriginEvt: LH.TraceEvent}} options
-    */
+     */
     static computeNavigationTimingsForFrame(frameEvents: Array<LH.TraceEvent>, options: {
         timeOriginEvt: LH.TraceEvent;
     }): {

package/core/lib/tracehouse/trace-processor.js

@@ -349,7 +349,7 @@ class TraceProcessor {
 
     const ret = this.getMainThreadTopLevelEventDurations(events, startTime, endTime);
     return this._riskPercentiles(ret.durations, totalTime, percentiles,
-        ret.clippedLength);
+      ret.clippedLength);
   }
 
   /**
@@ -479,9 +479,9 @@ class TraceProcessor {
     const firstResourceSendEvt = events.find(e => e.name === 'ResourceSendRequest');
     // We know that these properties exist if we found the events, but TSC doesn't.
     if (navStartEvt?.args?.data &&
-        firstResourceSendEvt &&
-        firstResourceSendEvt.pid === navStartEvt.pid &&
-        firstResourceSendEvt.tid === navStartEvt.tid) {
+      firstResourceSendEvt &&
+      firstResourceSendEvt.pid === navStartEvt.pid &&
+      firstResourceSendEvt.tid === navStartEvt.tid) {
       const frameId = navStartEvt.args.frame;
       if (frameId) {
         return {
@@ -552,9 +552,9 @@ class TraceProcessor {
    */
   static isScheduleableTask(evt) {
     return evt.name === SCHEDULABLE_TASK_TITLE_LH ||
-    evt.name === SCHEDULABLE_TASK_TITLE_ALT1 ||
-    evt.name === SCHEDULABLE_TASK_TITLE_ALT2 ||
-    evt.name === SCHEDULABLE_TASK_TITLE_ALT3;
+      evt.name === SCHEDULABLE_TASK_TITLE_ALT1 ||
+      evt.name === SCHEDULABLE_TASK_TITLE_ALT2 ||
+      evt.name === SCHEDULABLE_TASK_TITLE_ALT3;
   }
 
   /**
@@ -563,7 +563,7 @@ class TraceProcessor {
    */
   static isLCPEvent(evt) {
     if (evt.name !== 'largestContentfulPaint::Invalidate' &&
-        evt.name !== 'largestContentfulPaint::Candidate') return false;
+      evt.name !== 'largestContentfulPaint::Candidate') return false;
     return Boolean(evt.args?.frame);
   }
 
@@ -602,9 +602,10 @@ class TraceProcessor {
    *
    * @param {LH.TraceEvent[]} events
    * @param {LH.TraceEvent} timeOriginEvent
+   * @param {string|undefined} mainFrameId
    * @return {{lcp: LCPEvent | undefined, invalidated: boolean}}
    */
-  static computeValidLCPAllFrames(events, timeOriginEvent) {
+  static computeValidLCPAllFrames(events, timeOriginEvent, mainFrameId) {
     const lcpEvents = events.filter(this.isLCPEvent).reverse();
 
     /** @type {Map<string, LCPEvent>} */
@@ -628,6 +629,53 @@ class TraceProcessor {
       }
     }
 
+    // If no standard LCP candidate is found, try the UKM AllFramesEvents.
+    if (!maxLcpAcrossFrames) {
+      const ukmEvents = events.filter(
+        (e) =>
+          e.name.includes('LargestContentfulPaint') && e.name.includes('UKM')
+      );
+
+      // In the rare cases this whole fallback is necessary, the
+      // NavStartToLargestContentfulPaint::Candidate::AllFrames::UKM events are missing too.
+      // As a result, the only useful signal left is the AllFrames invalidates.
+      // Not ideal since they are 1 paint behind, but.. better than the dreaded
+      // NO_LCP error
+      const targetEventName =
+        'NavStartToLargestContentfulPaint::Invalidate::AllFrames::UKM';
+      const ukmInvalidates = ukmEvents.filter((e) => e.name === targetEventName);
+
+      if (ukmInvalidates.length > 0) {
+        ukmInvalidates.sort((a, b) => a.ts - b.ts);
+        const lastInvalidate = ukmInvalidates[ukmInvalidates.length - 1];
+
+        log.warn(
+          'TraceProcessor',
+          'LCP candidate missing, falling back to UKM Invalidate event.'
+        );
+
+        // Construct a mock LCP candidate event
+        maxLcpAcrossFrames = /** @type {LCPCandidateEvent} */ (
+          /** @type {unknown} */ ({
+            name: 'largestContentfulPaint::Candidate',
+            cat: 'loading',
+            ph: lastInvalidate.ph,
+            ts: lastInvalidate.ts,
+            pid: lastInvalidate.pid,
+            tid: lastInvalidate.tid,
+            args: {
+              frame: mainFrameId || 'main_frame', // Mocked frame ID
+              data: {
+                size: 1, // Don't know the actuall size so we assign it 1
+                isMainFrame: true,
+                isOutermostMainFrame: true,
+              },
+            },
+          })
+        );
+      }
+    }
+
     return {
       lcp: maxLcpAcrossFrames,
       // LCP events were found, but final LCP event of every frame was an invalidate event.
@@ -669,7 +717,7 @@ class TraceProcessor {
    * @param {LH.Trace} trace
    * @param {{timeOriginDeterminationMethod?: TimeOriginDeterminationMethod}} [options]
    * @return {LH.Artifacts.ProcessedTrace}
-  */
+   */
   static processTrace(trace, options) {
     const {timeOriginDeterminationMethod = 'auto'} = options || {};
 
@@ -677,9 +725,9 @@ class TraceProcessor {
     // *must* be stable to keep events correctly nested.
     const keyEvents = this.filteredTraceSort(trace.traceEvents, e => {
       return e.cat.includes('blink.user_timing') ||
-          e.cat.includes('loading') ||
-          e.cat.includes('devtools.timeline') ||
-          e.cat === '__metadata';
+        e.cat.includes('loading') ||
+        e.cat.includes('devtools.timeline') ||
+        e.cat === '__metadata';
     });
 
     // Find the inspected frame
@@ -699,7 +747,7 @@ class TraceProcessor {
     // Begin collection of frame tree information with TracingStartedInBrowser,
     // which should be present even without navigations.
     const tracingStartedFrames = keyEvents
-        .find(e => e.name === 'TracingStartedInBrowser')?.args?.data?.frames;
+      .find(e => e.name === 'TracingStartedInBrowser')?.args?.data?.frames;
     if (tracingStartedFrames) {
       for (const frame of tracingStartedFrames) {
         framesById.set(frame.frame, {
@@ -738,12 +786,18 @@ class TraceProcessor {
     // Filter to just events matching the main frame ID, just to make sure.
     /** @param {LH.TraceEvent} e */
     function associatedToMainFrame(e) {
+      if (e.name === 'NavStartToLargestContentfulPaint::Invalidate::AllFrames::UKM') {
+        return true;
+      }
       const frameId = TraceProcessor.getFrameId(e);
       return frameId === mainFrameInfo.frameId;
     }
 
     /** @param {LH.TraceEvent} e */
     function associatedToAllFrames(e) {
+      if (e.name.includes('LargestContentfulPaint') && e.name.includes('UKM')) {
+        return true;
+      }
       const frameId = TraceProcessor.getFrameId(e);
       return frameId ? inspectedTreeFrameIds.includes(frameId) : false;
     }
@@ -805,9 +859,16 @@ class TraceProcessor {
    * origin in addition to the standard microsecond monotonic timestamps.
    * @param {LH.Artifacts.ProcessedTrace} processedTrace
    * @return {LH.Artifacts.ProcessedNavigation}
-  */
+   */
   static processNavigation(processedTrace) {
-    const {frameEvents, frameTreeEvents, timeOriginEvt, timings, timestamps} = processedTrace;
+    const {
+      frameEvents,
+      frameTreeEvents,
+      timeOriginEvt,
+      timings,
+      timestamps,
+      mainFrameInfo,
+    } = processedTrace;
 
     // Compute the key frame timings for the main frame.
     const frameTimings = this.computeNavigationTimingsForFrame(frameEvents, {timeOriginEvt});
@@ -822,7 +883,11 @@ class TraceProcessor {
     }
 
     // Compute LCP for all frames.
-    const lcpAllFramesEvt = this.computeValidLCPAllFrames(frameTreeEvents, timeOriginEvt).lcp;
+    const lcpAllFramesEvt = this.computeValidLCPAllFrames(
+      frameTreeEvents,
+      timeOriginEvt,
+      mainFrameInfo.frameId
+    ).lcp;
 
     /** @param {number} ts */
     const getTiming = ts => (ts - timeOriginEvt.ts) / 1000;
@@ -950,7 +1015,7 @@ class TraceProcessor {
    * in addition to the standard microsecond monotonic timestamps.
    * @param {Array<LH.TraceEvent>} frameEvents
    * @param {{timeOriginEvt: LH.TraceEvent}} options
-  */
+   */
   static computeNavigationTimingsForFrame(frameEvents, options) {
     const {timeOriginEvt} = options;
 
@@ -967,7 +1032,8 @@ class TraceProcessor {
     }
 
     // This function accepts events spanning multiple frames, but this usage will only provide events from the main frame.
-    const lcpResult = this.computeValidLCPAllFrames(frameEvents, timeOriginEvt);
+    const frameId = frameEvents.map(e => TraceProcessor.getFrameId(e)).find(Boolean);
+    const lcpResult = this.computeValidLCPAllFrames(frameEvents, timeOriginEvt, frameId);
 
     const load = frameEvents.find(e => e.name === 'loadEventEnd' && e.ts > timeOriginEvt.ts);
     const domContentLoaded = frameEvents.find(

package/core/runner.js

@@ -498,6 +498,7 @@ vs: ${JSON.stringify(normalizedAuditSettings[k], null, 2)}`);
           .map(f => `byte-efficiency/${f}`),
       ...fs.readdirSync(path.join(moduleDir, './audits/manual')).map(f => `manual/${f}`),
       ...fs.readdirSync(path.join(moduleDir, './audits/insights')).map(f => `insights/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './audits/agentic')).map(f => `agentic/${f}`),
     ];
     return fileList.filter(f => {
       return /\.js$/.test(f) && !ignoredFiles.includes(f);
@@ -514,6 +515,8 @@ vs: ${JSON.stringify(normalizedAuditSettings[k], null, 2)}`);
       ...fs.readdirSync(path.join(moduleDir, './gather/gatherers/seo')).map(f => `seo/${f}`),
       ...fs.readdirSync(path.join(moduleDir, './gather/gatherers/dobetterweb'))
           .map(f => `dobetterweb/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './gather/gatherers/agentic'))
+          .map(f => `agentic/${f}`),
     ];
     return fileList.filter(f => /\.js$/.test(f) && f !== 'gatherer.js').sort();
   }

package/core/scoring.d.ts

@@ -750,6 +750,7 @@ export class ReportScoring {
                 acronym?: string | import("./index.js").IcuMessage | undefined;
             }[];
             supportedModes?: import("./index.js").Result.GatherMode[] | undefined;
+            categoryScoreDisplayMode?: import("./index.js").Result.CategoryScoreDisplayMode | undefined;
         };
     };
 }