chrome-devtools-frontend 1.0.943017 → 1.0.944427

package/front_end/panels/elements/components/AccessibilityTreeNode.ts

@@ -4,6 +4,7 @@
 
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Platform from '../../../core/platform/platform.js';
+import * as Protocol from '../../../generated/protocol.js';
 
 import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
 import * as Coordinator from '../../../ui/components/render_coordinator/render_coordinator.js';
@@ -31,10 +32,23 @@ function truncateTextIfNeeded(text: string): string {
   return text;
 }
 
+function isPrintable(valueType: Protocol.Accessibility.AXValueType): boolean {
+  switch (valueType) {
+    case Protocol.Accessibility.AXValueType.Boolean:
+    case Protocol.Accessibility.AXValueType.BooleanOrUndefined:
+    case Protocol.Accessibility.AXValueType.String:
+    case Protocol.Accessibility.AXValueType.Number:
+      return true;
+    default:
+      return false;
+  }
+}
+
 export interface AccessibilityTreeNodeData {
   ignored: boolean;
   name: string;
   role: string;
+  properties: Protocol.Accessibility.AXProperty[];
 }
 
 export class AccessibilityTreeNode extends HTMLElement {
@@ -44,11 +58,13 @@ export class AccessibilityTreeNode extends HTMLElement {
   private ignored = true;
   private name = '';
   private role = '';
+  private properties: Protocol.Accessibility.AXProperty[] = [];
 
   set data(data: AccessibilityTreeNodeData) {
     this.ignored = data.ignored;
     this.name = data.name;
     this.role = data.role;
+    this.properties = data.properties;
     this.render();
   }
 
@@ -57,12 +73,20 @@ export class AccessibilityTreeNode extends HTMLElement {
   }
 
   private async render(): Promise<void> {
+    const role = LitHtml.html`<span class='role-value'>${truncateTextIfNeeded(this.role)}</span>`;
+    const name = LitHtml.html`"<span class='attribute-value'>${this.name}</span>"`;
+    const properties = this.properties.map(
+        ({name, value}) => isPrintable(value.type) ?
+            LitHtml.html`&nbsp<span class='attribute-name'>${name}</span>:&nbsp<span class='attribute-value'>${
+                value.value}</span>` :
+            LitHtml.nothing);
+
     await Coordinator.RenderCoordinator.RenderCoordinator.instance().write('Accessibility node render', () => {
       // clang-format off
       LitHtml.render(
-        LitHtml.html`${this.ignored?
-          LitHtml.html`<span>${i18nString(UIStrings.ignored)}</span>`:
-          LitHtml.html`<span class='role-value'>${truncateTextIfNeeded(this.role)}</span>&nbsp"<span class='attribute-value'>${this.name}</span>"`}`,
+        this.ignored ?
+          LitHtml.html`<span>${i18nString(UIStrings.ignored)}</span>` :
+          LitHtml.html`${role}&nbsp${name}${properties}`,
         this.shadow,
         {host: this});
       // clang-format on

package/front_end/panels/elements/elements-meta.ts

@@ -7,7 +7,6 @@ import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Elements from './elements.js';
 
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/panels/emulation/emulation-meta.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Emulation from './emulation.js';
 
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/panels/help/help-meta.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Help from './help.js';
 
 const UIStrings = {

package/front_end/panels/input/input-meta.ts

@@ -6,7 +6,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Input from './input.js';
 
 const UIStrings = {

package/front_end/panels/issues/issues-meta.ts

@@ -7,7 +7,6 @@ import * as Root from '../../core/root/root.js';
 import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Issues from './issues.js';
 
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/panels/js_profiler/js_profiler-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Profiler from '../profiler/profiler.js';
 
 const UIStrings = {

package/front_end/panels/layers/layers-meta.ts

@@ -3,10 +3,8 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Layers from './layers.js';
 
 const UIStrings = {
@@ -26,8 +24,6 @@ let loadedLayersModule: (typeof Layers|undefined);
 
 async function loadLayersModule(): Promise<typeof Layers> {
   if (!loadedLayersModule) {
-    // Side-effect import resources in module.json
-    await Root.Runtime.Runtime.instance().loadModulePromise('panels/layers');
     loadedLayersModule = await import('./layers.js');
   }
   return loadedLayersModule;

package/front_end/panels/lighthouse/lighthouse-meta.ts

@@ -6,7 +6,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Lighthouse from './lighthouse.js';
 
 const UIStrings = {

package/front_end/panels/media/media-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Media from './media.js';
 
 const UIStrings = {

package/front_end/panels/mobile_throttling/mobile_throttling-meta.ts

@@ -6,7 +6,6 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as MobileThrottling from './mobile_throttling.js';
 
 const UIStrings = {

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -246,6 +246,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 // TODO(crbug.com/1167717): Make this a const enum again
 // eslint-disable-next-line rulesdir/const_enum
 export enum Events {
+  // RequestSelected might fire twice for the same "activation"
   RequestSelected = 'RequestSelected',
   RequestActivated = 'RequestActivated',
 }
@@ -1007,7 +1008,10 @@ export class NetworkRequestNode extends NetworkNode {
       cell.style.setProperty('padding-left', leftPadding);
       this.nameCell = cell;
       cell.addEventListener('dblclick', this.openInNewTab.bind(this), false);
-      cell.addEventListener('click', () => {
+      cell.addEventListener('mousedown', () => {
+        // When the request panel isn't visible yet, firing the RequestActivated event
+        // doesn't make it visible if no request is selected. So we'll select it first.
+        this.select();
         this.parentView().dispatchEventToListeners(Events.RequestActivated, {showPanel: true});
       });
       let iconElement;

package/front_end/panels/network/network-meta.ts

@@ -3,15 +3,14 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
+import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as NetworkForward from '../../panels/network/forward/forward.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Network from './network.js';
 
-import * as i18n from '../../core/i18n/i18n.js';
 const UIStrings = {
   /**
   *@description Command for showing the 'Network' tool

package/front_end/panels/performance_monitor/performance_monitor-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as PerformanceMonitor from './performance_monitor.js';
 
 const UIStrings = {

package/front_end/panels/profiler/profiler-meta.ts

@@ -8,7 +8,6 @@ import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Profiler from './profiler.js';
 
 let loadedProfilerModule: (typeof Profiler|undefined);

package/front_end/panels/protocol_monitor/protocol_monitor-meta.ts

@@ -6,7 +6,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as ProtocolMonitor from './protocol_monitor.js';
 
 const UIStrings = {

package/front_end/panels/screencast/screencast-meta.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../core/common/common.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Screencast from './screencast.js';
 
 let loadedScreencastModule: (typeof Screencast|undefined);

package/front_end/panels/security/security-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Security from './security.js';
 
 const UIStrings = {

package/front_end/panels/sensors/sensors-meta.ts

@@ -5,7 +5,6 @@
 import * as Common from '../../core/common/common.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Sensors from './sensors.js';
 
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/panels/settings/emulation/emulation-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as UI from '../../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Emulation from './emulation.js';
 
 const UIStrings = {

package/front_end/panels/settings/settings-meta.ts

@@ -8,7 +8,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Settings from './settings.js';
 
 const UIStrings = {

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -71,6 +71,7 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
     const editorConfig = [
       CodeMirror.javascript.javascriptLanguage,
       TextEditor.Config.baseConfiguration(oldCondition || ''),
+      TextEditor.Config.closeBrackets,
       TextEditor.Config.autocompletion,
       CodeMirror.EditorView.lineWrapping,
       TextEditor.Config.showCompletionHint,

package/front_end/panels/sources/Plugin.ts

@@ -18,9 +18,6 @@ export class Plugin {
     return false;
   }
 
-  wasShown(): void {
-  }
-
   willHide(): void {
   }
 

package/front_end/panels/sources/UISourceCodeFrame.ts

@@ -70,13 +70,11 @@ export class UISourceCodeFrame extends
         SourceFrame.SourceFrame.SourceFrameImpl) {
   private uiSourceCodeInternal: Workspace.UISourceCode.UISourceCode;
   private muteSourceCodeEvents: boolean;
-  private isSettingContent: boolean;
   private persistenceBinding: Persistence.Persistence.PersistenceBinding|null;
   private uiSourceCodeEventListeners: Common.EventTarget.EventDescriptor[];
   private messageAndDecorationListeners: Common.EventTarget.EventDescriptor[];
   private readonly boundOnBindingChanged: () => void;
   private plugins: Plugin[] = [];
-  private pluginsLoaded = false;
   private readonly errorPopoverHelper: UI.PopoverHelper.PopoverHelper;
 
   constructor(uiSourceCode: Workspace.UISourceCode.UISourceCode) {
@@ -84,7 +82,6 @@ export class UISourceCodeFrame extends
     this.uiSourceCodeInternal = uiSourceCode;
 
     this.muteSourceCodeEvents = false;
-    this.isSettingContent = false;
 
     this.persistenceBinding = Persistence.Persistence.PersistenceImpl.instance().binding(uiSourceCode);
 
@@ -162,27 +159,24 @@ export class UISourceCodeFrame extends
   }
 
   setUISourceCode(uiSourceCode: Workspace.UISourceCode.UISourceCode): void {
-    this.unloadUISourceCode();
-    this.uiSourceCodeInternal = uiSourceCode;
-    if (uiSourceCode.contentLoaded()) {
+    const loaded = uiSourceCode.contentLoaded() ? Promise.resolve() : uiSourceCode.requestContent();
+    const startUISourceCode = this.uiSourceCodeInternal;
+    loaded.then(() => {
+      if (this.uiSourceCodeInternal !== startUISourceCode) {
+        return;
+      }
+      this.unloadUISourceCode();
+      this.uiSourceCodeInternal = uiSourceCode;
       if (uiSourceCode.workingCopy() !== this.textEditor.state.doc.toString()) {
-        this.innerSetContent(uiSourceCode.workingCopy());
+        this.setContent(uiSourceCode.workingCopy());
+      } else {
+        this.reloadPlugins();
       }
-    } else {
-      uiSourceCode.requestContent().then(() => {
-        if (this.uiSourceCodeInternal !== uiSourceCode) {
-          return;
-        }
-        if (uiSourceCode.workingCopy() !== this.textEditor.state.doc.toString()) {
-          this.innerSetContent(uiSourceCode.workingCopy());
-        }
-      });
-    }
-    this.initializeUISourceCode();
+      this.initializeUISourceCode();
+    }, console.error);
   }
 
   private unloadUISourceCode(): void {
-    this.disposePlugins();
     Common.EventTarget.removeEventListeners(this.messageAndDecorationListeners);
     Common.EventTarget.removeEventListeners(this.uiSourceCodeEventListeners);
     this.uiSourceCodeInternal.removeWorkingCopyGetter();
@@ -212,9 +206,6 @@ export class UISourceCodeFrame extends
   wasShown(): void {
     super.wasShown();
     this.setEditable(this.canEditSourceInternal());
-    for (const plugin of this.plugins) {
-      plugin.wasShown();
-    }
   }
 
   willHide(): void {
@@ -277,16 +268,12 @@ export class UISourceCodeFrame extends
 
   async setContent(content: string): Promise<void> {
     this.disposePlugins();
-    this.ensurePluginsLoaded();
+    this.loadPlugins();
     await super.setContent(content);
-    Common.EventTarget.fireEvent('source-file-loaded', this.uiSourceCodeInternal.displayName(true));
-  }
-
-  protected editorInitialized(): void {
-    super.editorInitialized();
     for (const plugin of this.plugins) {
       plugin.editorInitialized(this.textEditor);
     }
+    Common.EventTarget.fireEvent('source-file-loaded', this.uiSourceCodeInternal.displayName(true));
   }
 
   private allMessages(): Set<Workspace.UISourceCode.Message> {
@@ -302,9 +289,6 @@ export class UISourceCodeFrame extends
     const wasPretty = this.pretty;
     super.onTextChanged();
     this.errorPopoverHelper.hidePopover();
-    if (this.isSettingContent) {
-      return;
-    }
     SourcesPanel.instance().updateLastModificationTime();
     this.muteSourceCodeEvents = true;
     if (this.isClean()) {
@@ -323,12 +307,12 @@ export class UISourceCodeFrame extends
     if (this.muteSourceCodeEvents) {
       return;
     }
-    this.innerSetContent(this.uiSourceCodeInternal.workingCopy());
+    this.maybeSetContent(this.uiSourceCodeInternal.workingCopy());
   }
 
   private onWorkingCopyCommitted(): void {
     if (!this.muteSourceCodeEvents) {
-      this.innerSetContent(this.uiSourceCode().workingCopy());
+      this.maybeSetContent(this.uiSourceCode().workingCopy());
     }
     this.contentCommitted();
     this.updateStyle();
@@ -336,7 +320,7 @@ export class UISourceCodeFrame extends
 
   private reloadPlugins(): void {
     this.disposePlugins();
-    this.ensurePluginsLoaded();
+    this.loadPlugins();
     const editor = this.textEditor;
     editor.dispatch({effects: pluginCompartment.reconfigure(this.plugins.map(plugin => plugin.editorExtension()))});
     for (const plugin of this.plugins) {
@@ -348,12 +332,7 @@ export class UISourceCodeFrame extends
     this.updateLanguageMode('').then(() => this.reloadPlugins(), console.error);
   }
 
-  private ensurePluginsLoaded(): void {
-    if (this.pluginsLoaded) {
-      return;
-    }
-    this.pluginsLoaded = true;
-
+  private loadPlugins(): void {
     const binding = Persistence.Persistence.PersistenceImpl.instance().binding(this.uiSourceCodeInternal);
     const pluginUISourceCode = binding ? binding.network : this.uiSourceCodeInternal;
 
@@ -364,9 +343,6 @@ export class UISourceCodeFrame extends
     }
 
     this.dispatchEventToListeners(Events.ToolbarItemsChanged);
-    for (const plugin of this.plugins) {
-      plugin.wasShown();
-    }
   }
 
   private disposePlugins(): void {
@@ -374,7 +350,6 @@ export class UISourceCodeFrame extends
       plugin.dispose();
     }
     this.plugins = [];
-    this.pluginsLoaded = false;
   }
 
   private onBindingChanged(): void {
@@ -385,19 +360,17 @@ export class UISourceCodeFrame extends
     this.unloadUISourceCode();
     this.persistenceBinding = binding;
     this.initializeUISourceCode();
+    this.reloadPlugins();
   }
 
   private updateStyle(): void {
     this.setEditable(this.canEditSourceInternal());
   }
 
-  private innerSetContent(content: string): void {
-    this.isSettingContent = true;
-    const oldContent = this.textEditor.state.doc.toString();
-    if (oldContent !== content) {
+  private maybeSetContent(content: string): void {
+    if (this.textEditor.state.doc.toString() !== content) {
       this.setContent(content);
     }
-    this.isSettingContent = false;
   }
 
   protected populateTextAreaContextMenu(
@@ -422,6 +395,7 @@ export class UISourceCodeFrame extends
 
   dispose(): void {
     this.errorPopoverHelper.dispose();
+    this.disposePlugins();
     this.unloadUISourceCode();
     this.textEditor.editor.destroy();
     this.detach();

package/front_end/panels/sources/sources-meta.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
+import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Workspace from '../../models/workspace/workspace.js';
@@ -10,10 +11,8 @@ import * as ObjectUI from '../../ui/legacy/components/object_ui/object_ui.js';
 import * as QuickOpen from '../../ui/legacy/components/quick_open/quick_open.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Sources from './sources.js';
 
-import * as i18n from '../../core/i18n/i18n.js';
 const UIStrings = {
   /**
   *@description Command for showing the 'Sources' tool

package/front_end/panels/timeline/TimelineController.ts

@@ -93,9 +93,6 @@ export class TimelineController implements SDK.TargetManager.SDKModelObserver<SD
     ];
     categoriesArray.push(TimelineModel.TimelineModel.TimelineModelImpl.Category.LatencyInfo);
 
-    if (Root.Runtime.experiments.isEnabled('timelineV8RuntimeCallStats') && options.enableJSSampling) {
-      categoriesArray.push(disabledByDefault('v8.runtime_stats_sampling'));
-    }
     if (!Root.Runtime.Runtime.queryParam('timelineTracingJSProfileDisabled') && options.enableJSSampling) {
       categoriesArray.push(disabledByDefault('v8.cpu_profiler'));
     }

package/front_end/panels/timeline/timeline-meta.ts

@@ -4,13 +4,11 @@
 
 import * as Common from '../../core/common/common.js';
 import * as UI from '../../ui/legacy/legacy.js';
+import type * as Profiler from '../profiler/profiler.js';
+import * as i18n from '../../core/i18n/i18n.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Timeline from './timeline.js';
 
-import type * as Profiler from '../profiler/profiler.js';
-
-import * as i18n from '../../core/i18n/i18n.js';
 const UIStrings = {
   /**
   *@description Text for the performance of something

package/front_end/panels/web_audio/web_audio-meta.ts

@@ -5,7 +5,6 @@
 import * as i18n from '../../core/i18n/i18n.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as WebAudio from './web_audio.js';
 
 const UIStrings = {

package/front_end/panels/webauthn/webauthn-meta.ts

@@ -6,7 +6,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-// eslint-disable-next-line rulesdir/es_modules_import
 import type * as Webauthn from './webauthn.js';
 
 const UIStrings = {

package/front_end/third_party/codemirror.next/bundle.ts

@@ -7,8 +7,9 @@
 import {StreamLanguage} from '@codemirror/stream-parser';
 
 export {
-  acceptCompletion, autocompletion, completeAnyWord, Completion, CompletionContext,
-  CompletionResult, CompletionSource, currentCompletions, ifNotIn
+  acceptCompletion, autocompletion, closeCompletion, completeAnyWord,
+  Completion, CompletionContext, CompletionResult, CompletionSource, currentCompletions,
+  ifNotIn, selectedCompletion, startCompletion,
 } from '@codemirror/autocomplete';
 export {closeBrackets, closeBracketsKeymap} from '@codemirror/closebrackets';
 export {