aigroup-workflow 2.2.1 → 2.2.3

package/skills/quality/test-master/references/unit-testing.md

@@ -1,113 +1,113 @@
-# Unit Testing
-
-## Jest/Vitest Pattern
-
-```typescript
-describe('UserService', () => {
-  let service: UserService;
-  let mockRepo: jest.Mocked<UserRepository>;
-
-  beforeEach(() => {
-    mockRepo = { findById: jest.fn(), save: jest.fn() } as any;
-    service = new UserService(mockRepo);
-  });
-
-  afterEach(() => jest.clearAllMocks());
-
-  describe('getUser', () => {
-    it('returns user when found', async () => {
-      const user = { id: '1', name: 'Test' };
-      mockRepo.findById.mockResolvedValue(user);
-
-      const result = await service.getUser('1');
-
-      expect(result).toEqual(user);
-      expect(mockRepo.findById).toHaveBeenCalledWith('1');
-    });
-
-    it('throws NotFoundError when user not found', async () => {
-      mockRepo.findById.mockResolvedValue(null);
-
-      await expect(service.getUser('1')).rejects.toThrow(NotFoundError);
-    });
-  });
-});
-```
-
-## pytest Pattern
-
-```python
-import pytest
-from unittest.mock import Mock, AsyncMock
-
-class TestUserService:
-    @pytest.fixture
-    def mock_repo(self):
-        return Mock()
-
-    @pytest.fixture
-    def service(self, mock_repo):
-        return UserService(mock_repo)
-
-    async def test_get_user_returns_user(self, service, mock_repo):
-        mock_repo.find_by_id = AsyncMock(return_value={"id": "1", "name": "Test"})
-
-        result = await service.get_user("1")
-
-        assert result == {"id": "1", "name": "Test"}
-        mock_repo.find_by_id.assert_called_once_with("1")
-
-    async def test_get_user_raises_not_found(self, service, mock_repo):
-        mock_repo.find_by_id = AsyncMock(return_value=None)
-
-        with pytest.raises(NotFoundError):
-            await service.get_user("1")
-```
-
-## Mocking Patterns
-
-```typescript
-// Mock functions
-const mockFn = jest.fn();
-mockFn.mockReturnValue('value');
-mockFn.mockResolvedValue('async value');
-mockFn.mockRejectedValue(new Error('error'));
-
-// Mock modules
-jest.mock('./database', () => ({
-  query: jest.fn(),
-}));
-
-// Spy on existing methods
-jest.spyOn(console, 'log').mockImplementation(() => {});
-```
-
-## Test Organization
-
-```typescript
-describe('Feature', () => {
-  describe('happy path', () => {
-    it('does expected behavior', () => {});
-  });
-
-  describe('edge cases', () => {
-    it('handles empty input', () => {});
-    it('handles max values', () => {});
-  });
-
-  describe('error cases', () => {
-    it('throws on invalid input', () => {});
-  });
-});
-```
-
-## Quick Reference
-
-| Pattern | Use Case |
-|---------|----------|
-| `describe()` | Group related tests |
-| `it()` / `test()` | Single test case |
-| `beforeEach()` | Setup before each test |
-| `jest.fn()` | Create mock function |
-| `mockResolvedValue()` | Mock async return |
-| `expect().toThrow()` | Assert exception |
+# Unit Testing
+
+## Jest/Vitest Pattern
+
+```typescript
+describe('UserService', () => {
+  let service: UserService;
+  let mockRepo: jest.Mocked<UserRepository>;
+
+  beforeEach(() => {
+    mockRepo = { findById: jest.fn(), save: jest.fn() } as any;
+    service = new UserService(mockRepo);
+  });
+
+  afterEach(() => jest.clearAllMocks());
+
+  describe('getUser', () => {
+    it('returns user when found', async () => {
+      const user = { id: '1', name: 'Test' };
+      mockRepo.findById.mockResolvedValue(user);
+
+      const result = await service.getUser('1');
+
+      expect(result).toEqual(user);
+      expect(mockRepo.findById).toHaveBeenCalledWith('1');
+    });
+
+    it('throws NotFoundError when user not found', async () => {
+      mockRepo.findById.mockResolvedValue(null);
+
+      await expect(service.getUser('1')).rejects.toThrow(NotFoundError);
+    });
+  });
+});
+```
+
+## pytest Pattern
+
+```python
+import pytest
+from unittest.mock import Mock, AsyncMock
+
+class TestUserService:
+    @pytest.fixture
+    def mock_repo(self):
+        return Mock()
+
+    @pytest.fixture
+    def service(self, mock_repo):
+        return UserService(mock_repo)
+
+    async def test_get_user_returns_user(self, service, mock_repo):
+        mock_repo.find_by_id = AsyncMock(return_value={"id": "1", "name": "Test"})
+
+        result = await service.get_user("1")
+
+        assert result == {"id": "1", "name": "Test"}
+        mock_repo.find_by_id.assert_called_once_with("1")
+
+    async def test_get_user_raises_not_found(self, service, mock_repo):
+        mock_repo.find_by_id = AsyncMock(return_value=None)
+
+        with pytest.raises(NotFoundError):
+            await service.get_user("1")
+```
+
+## Mocking Patterns
+
+```typescript
+// Mock functions
+const mockFn = jest.fn();
+mockFn.mockReturnValue('value');
+mockFn.mockResolvedValue('async value');
+mockFn.mockRejectedValue(new Error('error'));
+
+// Mock modules
+jest.mock('./database', () => ({
+  query: jest.fn(),
+}));
+
+// Spy on existing methods
+jest.spyOn(console, 'log').mockImplementation(() => {});
+```
+
+## Test Organization
+
+```typescript
+describe('Feature', () => {
+  describe('happy path', () => {
+    it('does expected behavior', () => {});
+  });
+
+  describe('edge cases', () => {
+    it('handles empty input', () => {});
+    it('handles max values', () => {});
+  });
+
+  describe('error cases', () => {
+    it('throws on invalid input', () => {});
+  });
+});
+```
+
+## Quick Reference
+
+| Pattern | Use Case |
+|---------|----------|
+| `describe()` | Group related tests |
+| `it()` / `test()` | Single test case |
+| `beforeEach()` | Setup before each test |
+| `jest.fn()` | Create mock function |
+| `mockResolvedValue()` | Mock async return |
+| `expect().toThrow()` | Assert exception |

package/skills/ruby/rails-expert/SKILL.md

@@ -1,154 +1,154 @@
----
-name: rails-expert
-description: Rails 7+ specialist that optimizes Active Record queries with includes/eager_load, implements Turbo Frames and Turbo Streams for partial page updates, configures Action Cable for WebSocket connections, sets up Sidekiq workers for background job processing, and writes comprehensive RSpec test suites. Use when building Rails 7+ web applications with Hotwire, real-time features, or background job processing. Invoke for Active Record optimization, Turbo Frames/Streams, Action Cable, Sidekiq, RSpec Rails.
-license: MIT
-metadata:
-  author: https://github.com/Jeffallan
-  version: "1.1.0"
-  domain: backend
-  triggers: Rails, Ruby on Rails, Hotwire, Turbo Frames, Turbo Streams, Action Cable, Active Record, Sidekiq, RSpec Rails
-  role: specialist
-  scope: implementation
-  output-format: code
-  related-skills: fullstack-guardian, database-optimizer
----
-
-# Rails Expert
-
-## Core Workflow
-
-1. **Analyze requirements** — Identify models, routes, real-time needs, background jobs
-2. **Scaffold resources** — `rails generate model User name:string email:string`, `rails generate controller Users`
-3. **Run migrations** — `rails db:migrate` and verify schema with `rails db:schema:dump`
-   - If migration fails: inspect `db/schema.rb` for conflicts, rollback with `rails db:rollback`, fix and retry
-4. **Implement** — Write controllers, models, add Hotwire (see Reference Guide below)
-5. **Validate** — `bundle exec rspec` must pass; `bundle exec rubocop` for style
-   - If specs fail: check error output, fix failing examples, re-run with `--format documentation` for detail
-   - If N+1 queries surface during review: add `includes`/`eager_load` (see Common Patterns) and re-run specs
-6. **Optimize** — Audit for N+1 queries, add missing indexes, add caching
-
-## Reference Guide
-
-Load detailed guidance based on context:
-
-| Topic | Reference | Load When |
-|-------|-----------|-----------|
-| Hotwire/Turbo | `references/hotwire-turbo.md` | Turbo Frames, Streams, Stimulus controllers |
-| Active Record | `references/active-record.md` | Models, associations, queries, performance |
-| Background Jobs | `references/background-jobs.md` | Sidekiq, job design, queues, error handling |
-| Testing | `references/rspec-testing.md` | Model/request/system specs, factories |
-| API Development | `references/api-development.md` | API-only mode, serialization, authentication |
-
-## Common Patterns
-
-### N+1 Prevention with includes/eager_load
-
-```ruby
-# BAD — triggers N+1
-posts = Post.all
-posts.each { |post| puts post.author.name }
-
-# GOOD — eager load association
-posts = Post.includes(:author).all
-posts.each { |post| puts post.author.name }
-
-# GOOD — eager_load forces a JOIN (useful when filtering on association)
-posts = Post.eager_load(:author).where(authors: { verified: true })
-```
-
-### Turbo Frame Setup (partial page update)
-
-```erb
-<%# app/views/posts/index.html.erb %>
-<%= turbo_frame_tag "posts" do %>
-  <%= render @posts %>
-  <%= link_to "Load More", posts_path(page: @next_page) %>
-<% end %>
-
-<%# app/views/posts/_post.html.erb %>
-<%= turbo_frame_tag dom_id(post) do %>
-  <h2><%= post.title %></h2>
-  <%= link_to "Edit", edit_post_path(post) %>
-<% end %>
-```
-
-```ruby
-# app/controllers/posts_controller.rb
-def index
-  @posts = Post.includes(:author).page(params[:page])
-  @next_page = @posts.next_page
-end
-```
-
-### Sidekiq Worker Template
-
-```ruby
-# app/jobs/send_welcome_email_job.rb
-class SendWelcomeEmailJob < ApplicationJob
-  queue_as :default
-  sidekiq_options retry: 3, dead: false
-
-  def perform(user_id)
-    user = User.find(user_id)
-    UserMailer.welcome(user).deliver_now
-  rescue ActiveRecord::RecordNotFound => e
-    Rails.logger.warn("SendWelcomeEmailJob: user #{user_id} not found — #{e.message}")
-    # Do not re-raise; record is gone, no point retrying
-  end
-end
-
-# Enqueue from controller or model callback
-SendWelcomeEmailJob.perform_later(user.id)
-```
-
-### Strong Parameters (controller template)
-
-```ruby
-# app/controllers/posts_controller.rb
-class PostsController < ApplicationController
-  before_action :set_post, only: %i[show edit update destroy]
-
-  def create
-    @post = Post.new(post_params)
-    if @post.save
-      redirect_to @post, notice: "Post created."
-    else
-      render :new, status: :unprocessable_entity
-    end
-  end
-
-  private
-
-  def set_post
-    @post = Post.find(params[:id])
-  end
-
-  def post_params
-    params.require(:post).permit(:title, :body, :published_at)
-  end
-end
-```
-
-## Constraints
-
-### MUST DO
-- Prevent N+1 queries with `includes`/`eager_load` on every collection query involving associations
-- Write comprehensive specs targeting >95% coverage
-- Use service objects for complex business logic; keep controllers thin
-- Add database indexes for every column used in `WHERE`, `ORDER BY`, or `JOIN`
-- Offload slow operations to Sidekiq — never run them synchronously in a request cycle
-
-### MUST NOT DO
-- Skip migrations for schema changes
-- Use raw SQL without sanitization (`sanitize_sql` or parameterized queries only)
-- Expose internal IDs in URLs without consideration
-
-## Output Templates
-
-When implementing Rails features, provide:
-1. Migration file (if schema changes needed)
-2. Model file with associations and validations
-3. Controller with RESTful actions and strong parameters
-4. View files or Hotwire setup
-5. Spec files for models and requests
-6. Brief explanation of architectural decisions
+---
+name: rails-expert
+description: Rails 7+ specialist that optimizes Active Record queries with includes/eager_load, implements Turbo Frames and Turbo Streams for partial page updates, configures Action Cable for WebSocket connections, sets up Sidekiq workers for background job processing, and writes comprehensive RSpec test suites. Use when building Rails 7+ web applications with Hotwire, real-time features, or background job processing. Invoke for Active Record optimization, Turbo Frames/Streams, Action Cable, Sidekiq, RSpec Rails.
+license: MIT
+metadata:
+  author: https://github.com/Jeffallan
+  version: "1.1.0"
+  domain: backend
+  triggers: Rails, Ruby on Rails, Hotwire, Turbo Frames, Turbo Streams, Action Cable, Active Record, Sidekiq, RSpec Rails
+  role: specialist
+  scope: implementation
+  output-format: code
+  related-skills: fullstack-guardian, database-optimizer
+---
+
+# Rails Expert
+
+## Core Workflow
+
+1. **Analyze requirements** — Identify models, routes, real-time needs, background jobs
+2. **Scaffold resources** — `rails generate model User name:string email:string`, `rails generate controller Users`
+3. **Run migrations** — `rails db:migrate` and verify schema with `rails db:schema:dump`
+   - If migration fails: inspect `db/schema.rb` for conflicts, rollback with `rails db:rollback`, fix and retry
+4. **Implement** — Write controllers, models, add Hotwire (see Reference Guide below)
+5. **Validate** — `bundle exec rspec` must pass; `bundle exec rubocop` for style
+   - If specs fail: check error output, fix failing examples, re-run with `--format documentation` for detail
+   - If N+1 queries surface during review: add `includes`/`eager_load` (see Common Patterns) and re-run specs
+6. **Optimize** — Audit for N+1 queries, add missing indexes, add caching
+
+## Reference Guide
+
+Load detailed guidance based on context:
+
+| Topic | Reference | Load When |
+|-------|-----------|-----------|
+| Hotwire/Turbo | `references/hotwire-turbo.md` | Turbo Frames, Streams, Stimulus controllers |
+| Active Record | `references/active-record.md` | Models, associations, queries, performance |
+| Background Jobs | `references/background-jobs.md` | Sidekiq, job design, queues, error handling |
+| Testing | `references/rspec-testing.md` | Model/request/system specs, factories |
+| API Development | `references/api-development.md` | API-only mode, serialization, authentication |
+
+## Common Patterns
+
+### N+1 Prevention with includes/eager_load
+
+```ruby
+# BAD — triggers N+1
+posts = Post.all
+posts.each { |post| puts post.author.name }
+
+# GOOD — eager load association
+posts = Post.includes(:author).all
+posts.each { |post| puts post.author.name }
+
+# GOOD — eager_load forces a JOIN (useful when filtering on association)
+posts = Post.eager_load(:author).where(authors: { verified: true })
+```
+
+### Turbo Frame Setup (partial page update)
+
+```erb
+<%# app/views/posts/index.html.erb %>
+<%= turbo_frame_tag "posts" do %>
+  <%= render @posts %>
+  <%= link_to "Load More", posts_path(page: @next_page) %>
+<% end %>
+
+<%# app/views/posts/_post.html.erb %>
+<%= turbo_frame_tag dom_id(post) do %>
+  <h2><%= post.title %></h2>
+  <%= link_to "Edit", edit_post_path(post) %>
+<% end %>
+```
+
+```ruby
+# app/controllers/posts_controller.rb
+def index
+  @posts = Post.includes(:author).page(params[:page])
+  @next_page = @posts.next_page
+end
+```
+
+### Sidekiq Worker Template
+
+```ruby
+# app/jobs/send_welcome_email_job.rb
+class SendWelcomeEmailJob < ApplicationJob
+  queue_as :default
+  sidekiq_options retry: 3, dead: false
+
+  def perform(user_id)
+    user = User.find(user_id)
+    UserMailer.welcome(user).deliver_now
+  rescue ActiveRecord::RecordNotFound => e
+    Rails.logger.warn("SendWelcomeEmailJob: user #{user_id} not found — #{e.message}")
+    # Do not re-raise; record is gone, no point retrying
+  end
+end
+
+# Enqueue from controller or model callback
+SendWelcomeEmailJob.perform_later(user.id)
+```
+
+### Strong Parameters (controller template)
+
+```ruby
+# app/controllers/posts_controller.rb
+class PostsController < ApplicationController
+  before_action :set_post, only: %i[show edit update destroy]
+
+  def create
+    @post = Post.new(post_params)
+    if @post.save
+      redirect_to @post, notice: "Post created."
+    else
+      render :new, status: :unprocessable_entity
+    end
+  end
+
+  private
+
+  def set_post
+    @post = Post.find(params[:id])
+  end
+
+  def post_params
+    params.require(:post).permit(:title, :body, :published_at)
+  end
+end
+```
+
+## Constraints
+
+### MUST DO
+- Prevent N+1 queries with `includes`/`eager_load` on every collection query involving associations
+- Write comprehensive specs targeting >95% coverage
+- Use service objects for complex business logic; keep controllers thin
+- Add database indexes for every column used in `WHERE`, `ORDER BY`, or `JOIN`
+- Offload slow operations to Sidekiq — never run them synchronously in a request cycle
+
+### MUST NOT DO
+- Skip migrations for schema changes
+- Use raw SQL without sanitization (`sanitize_sql` or parameterized queries only)
+- Expose internal IDs in URLs without consideration
+
+## Output Templates
+
+When implementing Rails features, provide:
+1. Migration file (if schema changes needed)
+2. Model file with associations and validations
+3. Controller with RESTful actions and strong parameters
+4. View files or Hotwire setup
+5. Spec files for models and requests
+6. Brief explanation of architectural decisions