scss_lint 0.38.0

data/spec/scss_lint/linter/zero_unit_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ZeroUnit do
+  context 'when no properties exist' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when properties with unit-less zeros exist' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when properties with non-zero values exist' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 5px;
+        line-height: 1.5em;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when properties with zero values contain units' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 0px;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when properties with multiple zero values containing units exist' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 5em 0em 2em 0px;
+      }
+    SCSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when function call contains a zero value with units' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: some-function(0em);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when mixin include contains a zero value with units' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include some-mixin(0em);
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when string contains a zero value with units' do
+    let(:scss) { <<-SCSS }
+      p {
+        content: func("0em");
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property value has a ".0" fractional component' do
+    let(:scss) { <<-SCSS }
+      p {
+        margin: 4.0em;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property value has a color hex with a leading 0' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #0af;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property with zero value is a dimension' do
+    let(:scss) { <<-SCSS }
+      p {
+        transition-delay: 0s;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter_registry_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe SCSSLint::LinterRegistry do
+  context 'when including the LinterRegistry module' do
+    after do
+      described_class.linters.delete(FakeLinter)
+    end
+
+    it 'adds the linter to the set of registered linters' do
+      expect do
+        class FakeLinter < SCSSLint::Linter
+          include SCSSLint::LinterRegistry
+        end
+      end.to change { described_class.linters.count }.by(1)
+    end
+  end
+
+  describe '.extract_linters_from' do
+    module SCSSLint
+      class Linter::SomeLinter < Linter; end
+      class Linter::SomeOtherLinter < Linter; end
+    end
+
+    let(:linters) do
+      [SCSSLint::Linter::SomeLinter, SCSSLint::Linter::SomeOtherLinter]
+    end
+
+    before do
+      described_class.stub(:linters).and_return(linters)
+    end
+
+    context 'when the linters exist' do
+      let(:linter_names) { %w[SomeLinter SomeOtherLinter] }
+
+      it 'returns the linters' do
+        subject.extract_linters_from(linter_names).should == linters
+      end
+    end
+
+    context "when the linters don't exist" do
+      let(:linter_names) { ['SomeRandomLinter'] }
+
+      it 'raises an error' do
+        expect do
+          subject.extract_linters_from(linter_names)
+        end.to raise_error(SCSSLint::NoSuchLinter)
+      end
+    end
+  end
+end

data/spec/scss_lint/linter_spec.rb

@@ -0,0 +1,292 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter do
+  describe 'control comments' do
+    let(:linter_config) { {} }
+    subject             { SCSSLint::Linter::Fake.new }
+
+    module SCSSLint
+      class Linter::Fake < SCSSLint::Linter
+        def visit_prop(node)
+          return unless node.value.to_sass.strip == 'fail1'
+          add_lint(node, 'everything offends me')
+        end
+
+        def visit_class(klass)
+          return unless klass.to_s == '.badClass'
+          add_lint(klass, 'a bad class was used')
+        end
+
+        # Bypasses the visit order so a control comment might not be reached before a lint is
+        # added
+        def visit_rule(node)
+          node.children
+              .select { |child| child.is_a?(Sass::Tree::PropNode) }
+              .reject { |prop| prop.name.any? { |item| item.is_a?(Sass::Script::Node) } }
+              .each do |prop|
+                add_lint(prop, 'everything offends me 2') if prop.value.to_sass.strip == 'fail2'
+              end
+
+          yield
+        end
+      end
+    end
+
+    context 'when a disable is not present' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: fail1;
+
+          a {
+            border: fail1;
+          }
+        }
+      SCSS
+
+      it { should report_lint }
+    end
+
+    context 'when a disable is present at the top level' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Fake
+        p {
+          border: fail1;
+
+          a {
+            border: fail1;
+          }
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a disable is present at the top level for another linter' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Bogus
+        p {
+          border: fail1;
+        }
+        p {
+          border: bogus;
+        }
+      SCSS
+
+      it { should report_lint lint: 3 }
+    end
+
+    context 'when a linter is disabled then enabled again' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Fake
+        p {
+          border: fail1;
+        }
+        // scss-lint:enable Fake
+        p {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint line: 3 }
+      it { should report_lint line: 7 }
+    end
+
+    context 'when a linter is disabled within a rule' do
+      let(:scss) { <<-SCSS }
+        p {
+          // scss-lint:disable Fake
+          border: fail1;
+
+          a {
+            border: fail1;
+          }
+        }
+
+        p {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint line: 3 }
+      it { should_not report_lint line: 6 }
+      it { should report_lint line: 11 }
+    end
+
+    context 'when more than one linter is disabled' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Bogus, Fake
+        p {
+          border: fail1;
+        }
+
+        p {
+          border: bogus;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when more than one linter is disabled without spaces between the linter names' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Fake,Bogus
+        p {
+          border: fail1;
+        }
+
+        p {
+          border: Bogus;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when more than one linter is disabled without commas between the linter names' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Fake Bogus
+        p {
+          border: fail1;
+        }
+
+        p {
+          border: bogus;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when two linters are disabled and only one is reenabled' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Fake, Bogus
+        p {
+          border: fail1;
+        }
+        // scss-lint:enable Fake
+
+        p {
+          margin: fail1;
+          border: bogus;
+        }
+      SCSS
+
+      it { should_not report_lint line: 3 }
+      it { should report_lint line: 8 }
+    end
+
+    context 'when all linters are disabled' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable all
+        p {
+          border: fail1;
+        }
+
+        p {
+          margin: fail1;
+          border: bogus;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when all linters are disabled and then one is re-enabled' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable all
+        p {
+          border: fail1;
+        }
+        // scss-lint:enable Fake
+
+        p {
+          margin: fail1;
+          border: bogus;
+        }
+      SCSS
+
+      it { should_not report_lint line: 3 }
+      it { should report_lint line: 8 }
+    end
+
+    context 'when a linter is bypassing the visit tree order' do
+      let(:scss) { <<-SCSS }
+        p {
+          // scss-lint:disable Fake
+          border: fail2;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the command comment is next to other comments' do
+      let(:scss) { <<-SCSS }
+        p {
+          // scss-lint:disable Fake
+          // more comments
+          border: fail2;
+        }
+
+        p {
+          // more comments
+          // scss-lint:disable Fake
+          border: fail2;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the command comment is at the end of a statement' do
+      let(:scss) { <<-SCSS }
+        p {
+          border: fail1; // scss-lint:disable Fake
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'when global disable comes before an @include' do
+      let(:scss) { <<-SCSS }
+        // scss-lint:disable Fake
+        p {
+          border: fail1;
+        }
+
+        @include mixin(param) {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when // control comment appears in the middle of a comma sequence' do
+      let(:scss) { <<-SCSS }
+        .badClass, // scss-lint:disable Fake
+        .good-selector {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint line: 1 }
+      it { should report_lint line: 3 }
+    end
+
+    context 'when /* control comment appears in the middle of a comma sequence' do
+      let(:scss) { <<-SCSS }
+        .badClass, /* scss-lint:disable Fake */
+        .good-selector {
+          border: fail1;
+        }
+      SCSS
+
+      it { should_not report_lint line: 1 }
+      it { should report_lint line: 3 }
+    end
+  end
+end