scss_lint 0.38.0

data/spec/scss_lint/linter/mergeable_selector_spec.rb

@@ -0,0 +1,283 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::MergeableSelector do
+  context 'when single root' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when different roots' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: #000;
+        margin: 5px;
+      }
+      a {
+        background: #000;
+        margin: 5px;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when different roots with matching inner rules' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: #000;
+        margin: 5px;
+        .foo {
+          color: red;
+        }
+      }
+      a {
+        background: #000;
+        margin: 5px;
+        .foo {
+          color: red;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when multi-selector roots and parital rule match' do
+    let(:scss) { <<-SCSS }
+      p, a {
+        background: #000;
+        margin: 5px;
+        .foo {
+          color: red;
+        }
+      }
+      a {
+        background: #000;
+        margin: 5px;
+        .foo {
+          color: red;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when nested and unnested selectors match' do
+    let(:scss) { <<-SCSS }
+      a.current {
+        background: #000;
+        margin: 5px;
+        .foo {
+          color: red;
+        }
+      }
+      a {
+        &.current {
+          background: #000;
+          margin: 5px;
+          .foo {
+            color: red;
+          }
+        }
+      }
+    SCSS
+
+    context 'when force_nesting is enabled' do
+      let(:linter_config) { { 'force_nesting' => true } }
+      it { should report_lint }
+    end
+
+    context 'when force_nesting is disabled' do
+      let(:linter_config) { { 'force_nesting' => false } }
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when same class roots' do
+    let(:scss) { <<-SCSS }
+      .warn {
+        font-weight: bold;
+      }
+      .warn {
+        color: #f00;
+        @extend .warn;
+        a {
+          color: #ccc;
+        }
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
+  context 'when same compond selector roots' do
+    let(:scss) { <<-SCSS }
+      .warn .alert {
+        font-weight: bold;
+      }
+      .warn .alert {
+        color: #f00;
+        @extend .warn;
+        a {
+          color: #ccc;
+        }
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
+  context 'when same class roots separated by another class' do
+    let(:scss) { <<-SCSS }
+      .warn {
+        font-weight: bold;
+      }
+      .foo {
+        color: red;
+      }
+      .warn {
+        color: #f00;
+        @extend .warn;
+        a {
+          color: #ccc;
+        }
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
+  context 'when rule in a mixin @include matches a root root' do
+    let(:scss) { <<-SCSS }
+      p {
+        font-weight: bold;
+      }
+      @include enhance(small-tablet) {
+        p {
+          font-weight: normal;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule in a mixin definition matches a root rule' do
+    let(:scss) { <<-SCSS }
+      p {
+        font-weight: bold;
+      }
+      @mixin my-mixin {
+        p {
+          font-weight: normal;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule in a media directive matches a root rule' do
+    let(:scss) { <<-SCSS }
+      p {
+        font-weight: bold;
+      }
+      @media only screen and (min-device-pixel-ratio: 1.5) {
+        p {
+          font-weight: normal;
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule in a keyframes directive matches a root rule' do
+    let(:scss) { <<-SCSS }
+      @keyframes slideouttoleft {
+        from {
+          transform: translateX(0);
+        }
+
+        to {
+          transform: translateX(-100%);
+        }
+      }
+
+      @keyframes slideouttoright {
+        from {
+          transform: translateX(0);
+        }
+
+        to {
+          transform: translateX(100%);
+        }
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when there are duplicate rules nested in a rule set' do
+    let(:scss) { <<-SCSS }
+      .foo {
+        .bar {
+          font-weight: bold;
+        }
+        .baz {
+          font-weight: bold;
+        }
+        .bar {
+          color: #ff0;
+        }
+      }
+    SCSS
+
+    it { should report_lint }
+  end
+
+  context 'when force_nesting is enabled' do
+    let(:linter_config) { { 'force_nesting' => true } }
+
+    context 'when one of the duplicate rules is in a comma sequence' do
+      let(:scss) { <<-SCSS }
+        .foo,
+        .bar {
+          color: #000;
+        }
+        .foo {
+          color: #f00;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when rules start with the same prefix but are not the same' do
+      let(:scss) { <<-SCSS }
+        .foo {
+          color: #000;
+        }
+        .foobar {
+          color: #f00;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a rule contains interpolation' do
+      let(:scss) { <<-SCSS }
+        .\#{$class-name} {}
+        .foobar {}
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/name_format_spec.rb

@@ -0,0 +1,282 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::NameFormat do
+  shared_examples 'hyphenated_lowercase' do
+    context 'when no variable, functions, or mixin declarations exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 0;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a variable name contains a hyphen' do
+      let(:scss) { '$content-padding: 10px;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a variable name contains an underscore' do
+      let(:scss) { '$content_padding: 10px;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when a variable name contains an uppercase character' do
+      let(:scss) { '$contentPadding: 10px;' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when a function is declared with a capital letter' do
+      let(:scss) { <<-SCSS }
+        @function badFunction() {
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when a function is declared with an underscore' do
+      let(:scss) { <<-SCSS }
+        @function bad_function() {
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when a mixin is declared with a capital letter' do
+      let(:scss) { <<-SCSS }
+        @mixin badMixin() {
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when a mixin is declared with an underscore' do
+      let(:scss) { <<-SCSS }
+        @mixin bad_mixin() {
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when no invalid usages exist' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: 0;
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a referenced variable name has a capital letter' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: $badVar;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when a referenced variable name has an underscore' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: $bad_var;
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when a referenced function name has a capital letter' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: badFunc();
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when a referenced function name has an underscore' do
+      let(:scss) { <<-SCSS }
+        p {
+          margin: bad_func();
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when an included mixin name has a capital letter' do
+      let(:scss) { '@include badMixin();' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when an included mixin name has an underscore' do
+      let(:scss) { '@include bad_mixin();' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when function is a transform function' do
+      %w[rotateX rotateY rotateZ
+         scaleX scaleY scaleZ
+         skewX skewY
+         translateX translateY translateZ].each do |function|
+        let(:scss) { <<-SCSS }
+          p {
+            transform: #{function}(2);
+          }
+        SCSS
+
+        it { should_not report_lint }
+      end
+    end
+
+    context 'when mixin is a transform function' do
+      let(:scss) { <<-SCSS }
+        p {
+          @include translateX(2);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when a mixin contains keyword arguments with underscores' do
+      let(:scss) { '@include mixin($some_var: 4);' }
+
+      it { should report_lint }
+    end
+
+    context 'when a mixin contains keyword arguments with hyphens' do
+      let(:scss) { '@include mixin($some-var: 4);' }
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when no configuration is specified' do
+    it_behaves_like 'hyphenated_lowercase'
+
+    context 'when a name contains a leading underscore' do
+      let(:scss) { <<-SCSS }
+        @function _private-method() {
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when leading underscores are not allowed' do
+    let(:linter_config) { { 'allow_leading_underscore' => false } }
+
+    it_behaves_like 'hyphenated_lowercase'
+
+    context 'when a name contains a leading underscore' do
+      let(:scss) { <<-SCSS }
+        @function _private-method() {
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'when the camel_case convention is specified' do
+    let(:linter_config) { { 'convention' => 'camel_case' } }
+
+    context 'when a name contains all lowercase letters' do
+      let(:scss) { '$variable: 1;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains all lowercase letters and underscores' do
+      let(:scss) { '$my_variable: 1;' }
+
+      it { should report_lint }
+    end
+
+    context 'when a name contains all lowercase letters and hyphens' do
+      let(:scss) { '$my-variable: 1;' }
+
+      it { should report_lint }
+    end
+
+    context 'when a name is written in camelCase' do
+      let(:scss) { '$myVariable: 1;' }
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when the snake_case convention is specified' do
+    let(:linter_config) { { 'convention' => 'snake_case' } }
+
+    context 'when a name contains all lowercase letters' do
+      let(:scss) { '$variable: 1;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains all lowercase letters and underscores' do
+      let(:scss) { '$my_variable: 1;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when a name contains all lowercase letters and hyphens' do
+      let(:scss) { '$my-variable: 1;' }
+
+      it { should report_lint }
+    end
+
+    context 'when a name contains any uppercase letters' do
+      let(:scss) { '$myVariable: 1;' }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when type-specific convention is defined with a global convention' do
+    let(:linter_config) do
+      { 'convention' => 'camel_case', 'variable_convention' => 'snake_case' }
+    end
+
+    context 'when specific type satisfies the type-specific convention' do
+      let(:scss) { '$my_variable: 1;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when specific type does not satisfy the type-specific convention' do
+      let(:scss) { '$myVariable: 1;' }
+
+      it { should report_lint }
+    end
+
+    context 'when other type satisfies the global convention' do
+      let(:scss) { '@function myFunction() {}' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when other type does not satisfy the global convention' do
+      let(:scss) { '@function my_function() {}' }
+
+      it { should report_lint }
+    end
+  end
+end