scss_lint 0.38.0

data/spec/scss_lint/linter/empty_rule_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::EmptyRule do
+  context 'when rule is empty' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule contains an empty nested rule' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: #000;
+        display: none;
+        margin: 5px;
+        padding: 10px;
+        a {
+        }
+      }
+    SCSS
+
+    it { should report_lint line: 6 }
+  end
+end

data/spec/scss_lint/linter/final_newline_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::FinalNewline do
+  let(:linter_config) { { 'present' => present } }
+
+  context 'when trailing newline is preferred' do
+    let(:present) { true }
+
+    context 'when the file is empty' do
+      let(:scss) { '' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the file ends with a newline' do
+      let(:scss) { "p {}\n" }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the file does not end with a newline' do
+      let(:scss) { 'p {}' }
+
+      it { should report_lint }
+    end
+  end
+
+  context 'when no trailing newline is preferred' do
+    let(:present) { false }
+
+    context 'when the file is empty' do
+      let(:scss) { '' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when the file ends with a newline' do
+      let(:scss) { "p {}\n" }
+
+      it { should report_lint }
+    end
+
+    context 'when the file does not end with a newline' do
+      let(:scss) { 'p {}' }
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/hex_length_spec.rb

@@ -0,0 +1,104 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::HexLength do
+  let(:linter_config) { { 'style' => style } }
+  let(:style) { 'short' }
+
+  context 'when rule is empty' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains properties with valid hex code' do
+    let(:scss) { <<-SCSS }
+      p {
+        color: #1234ab;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when ID selector starts with a hex code' do
+    let(:scss) { <<-SCSS }
+      #aabbcc {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when color is specified as a color keyword' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include box-shadow(0 0 1px 1px gold);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when short style is preferred' do
+    let(:style) { 'short' }
+
+    context 'with short hex code' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #ccc;
+          background: #CCC;
+          @include crazy-color(#fff);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with long hex code that could be condensed to 3 digits' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #cccccc;
+          background: #CCCCCC;
+          @include crazy-color(#ffffff);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'when long style is preferred' do
+    let(:style) { 'long' }
+
+    context 'with long hex code that could be condensed to 3 digits' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #cccccc;
+          background: #CCCCCC;
+          @include crazy-color(#ffffff);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with short hex code' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #ccc;
+          background: #CCC;
+          @include crazy-color(#fff);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+end

data/spec/scss_lint/linter/hex_notation_spec.rb

@@ -0,0 +1,104 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::HexNotation do
+  let(:linter_config) { { 'style' => style } }
+  let(:style) { nil }
+
+  context 'when rule is empty' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains color keyword' do
+    let(:scss) { <<-SCSS }
+      p {
+        border-color: red;
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'lowercase style' do
+    let(:style) { 'lowercase' }
+
+    context 'when rule contains properties with lowercase hex code' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #ccc;
+          color: #cccccc;
+          @include crazy-color(#fff);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with uppercase hex codes' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #CCC;
+          color: #CCCCCC;
+          @include crazy-color(#FFF);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'uppercase style' do
+    let(:style) { 'uppercase' }
+
+    context 'with uppercase hex codes' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #CCC;
+          color: #CCCCCC;
+          @include crazy-color(#FFF);
+        }
+      SCSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when rule contains properties with lowercase hex code' do
+      let(:scss) { <<-SCSS }
+        p {
+          background: #ccc;
+          color: #cccccc;
+          @include crazy-color(#fff);
+        }
+      SCSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'when ID selector starts with a hex code' do
+    let(:scss) { <<-SCSS }
+      #aabbcc {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when color is specified as a color keyword' do
+    let(:scss) { <<-SCSS }
+      p {
+        @include box-shadow(0 0 1px 1px gold);
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/hex_validation_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::HexValidation do
+  context 'when rule is empty' do
+    let(:scss) { <<-SCSS }
+      p {
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains valid hex codes or color keyword' do
+    gradient_css = 'progid:DXImageTransform.Microsoft.gradient' \
+                   '(startColorstr=#99000000, endColorstr=#99000000)'
+
+    let(:scss) { <<-SCSS }
+      p {
+        background: #000;
+        color: #FFFFFF;
+        border-color: red;
+        filter: #{gradient_css};
+      }
+    SCSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule contains invalid hex codes' do
+    let(:scss) { <<-SCSS }
+      p {
+        background: #dd;
+        color: #dddd;
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+  end
+end

data/spec/scss_lint/linter/id_selector_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::IdSelector do
+  context 'when rule is a type' do
+    let(:scss) { 'p {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is an ID' do
+    let(:scss) { '#identifier {}' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule is a class' do
+    let(:scss) { '.class {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is a type with a class' do
+    let(:scss) { 'a.class {}' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule is a type with an ID' do
+    let(:scss) { 'a#identifier {}' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule is an ID with a pseudo-selector' do
+    let(:scss) { '#identifier:active {}' }
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when rule contains a nested rule with type and ID' do
+    let(:scss) { <<-SCSS }
+      p {
+        a#identifier {}
+      }
+    SCSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when rule contains multiple selectors' do
+    context 'when all of the selectors are just IDs, classes, or types' do
+      let(:scss) { <<-SCSS }
+        #identifier,
+        .class,
+        a {
+        }
+      SCSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+end

data/spec/scss_lint/linter/import_path_spec.rb

@@ -0,0 +1,300 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ImportPath do
+  context 'when the path includes no directories' do
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:scss) { '@import "filename";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:scss) { '@import "_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:scss) { '@import "filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:scss) { '@import "_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:scss) { '@import "foo", "bar";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and the second has a leading underscore' do
+        let(:scss) { '@import "foo", "_bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and the first has a filename extension' do
+        let(:scss) { '@import "foo.scss", "bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when the path includes directories' do
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:scss) { '@import "path/to/filename";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:scss) { '@import "../to/_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:scss) { '@import "/path/to/filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:scss) { '@import "path/to/_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:scss) { '@import "path/to/foo", "../../bar";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and the second has a leading underscore' do
+        let(:scss) { '@import "path/to/foo", "../../_bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and the first has a filename extension' do
+        let(:scss) { '@import "path/to/foo.scss", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when option `leading_underscore` is true' do
+    let(:linter_config) { { 'leading_underscore' => true } }
+
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:scss) { '@import "path/to/filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:scss) { '@import "../to/_filename";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:scss) { '@import "/path/to/filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:scss) { '@import "path/to/_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:scss) { '@import "path/to/foo", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and both have a leading underscore' do
+        let(:scss) { '@import "path/to/_foo", "../../_bar";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and only one has a leading underscore' do
+        let(:scss) { '@import "path/to/foo.scss", "../../_bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when option `filename_extension` is true' do
+    let(:linter_config) { { 'filename_extension' => true } }
+
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:scss) { '@import "path/to/filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:scss) { '@import "../to/_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:scss) { '@import "/path/to/filename.scss";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:scss) { '@import "path/to/_filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:scss) { '@import "path/to/foo", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and both have filename extensions' do
+        let(:scss) { '@import "path/to/foo.scss", "../../bar.scss";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and only one has a filename extensions' do
+        let(:scss) { '@import "path/to/foo.scss", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when options `leading_underscore` and `filename_extension` are true' do
+    let(:linter_config) { { 'leading_underscore' => true, 'filename_extension' => true } }
+
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:scss) { '@import "path/to/filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:scss) { '@import "../to/_filename";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:scss) { '@import "/path/to/filename.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:scss) { '@import "path/to/_filename.scss";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and multiple files are @imported' do
+      context 'and neither have leading underscores or filename extensions' do
+        let(:scss) { '@import "path/to/foo", "../../bar";' }
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'and both have filename extensions and leading underscores' do
+        let(:scss) { '@import "path/to/_foo.scss", "../../_bar.scss";' }
+
+        it { should_not report_lint }
+      end
+
+      context 'and only one has both a filename extension and a leading underscore' do
+        let(:scss) { '@import "path/to/_foo.scss", "../../bar.scss";' }
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'when the @import directive compiles directly to a CSS @import rule' do
+    context 'and the @import is a CSS file' do
+      let(:scss) { '@import "_foo.css";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import contains a protocol' do
+      let(:scss) { '@import "http://foo.com/_bar.css";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import contains a media query' do
+      let(:scss) { '@import "_foo.css" screen;' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import is a URL' do
+      let(:scss) { '@import url(_foo.css);' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the @import contains interpolation' do
+      let(:scss) { <<-SCSS }
+        $family: unquote("Droid+Sans");
+        @import url("http://fonts.googleapis.com/css?family=\#{$family}");
+      SCSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when the partial has the same name as its directory' do
+    context 'and the filename has no leading underscore or filename extension' do
+      let(:scss) { '@import "foo/foo";' }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the filename has a leading underscore' do
+      let(:scss) { '@import "_foo/_foo";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a filename extension' do
+      let(:scss) { '@import "foo/foo.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'and the filename has a leading underscore and a filename extension' do
+      let(:scss) { '@import "_foo/_foo.scss";' }
+
+      it { should report_lint line: 1 }
+    end
+  end
+end